GitLab

BUG=634085

Review-Url: https://codereview.chromium.org/2163623003
Cr-Commit-Position: refs/heads/master@{#414882}

Cr-Commit-Position: refs/heads/master@{#414881}

Revert of Move gyp-win-tool to the GN Windows toolchain. (patchset #6 id:100001 of https://codereview.chromium.org/2287603003/ )

Reason for revert:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10319/steps/compile/logs/stdio

Original issue's description:
> Move gyp-win-tool to the GN Windows toolchain.
>
> Renames it tool_wrapper.py but otherwise keeps it unchanged from the original
> https://chromium.googlesource.com/external/gyp.git/+/master/pylib/gyp/win_tool.py
>
> I changed internal references to itself to tool_wrapper.py, and split the internal strings containing the word "Copyright" (which it uses to filter tool output) to avoid triggering the copyright presubmit check.
>
> Changes the build to refer to the file in-place rather than copying it to the build directory which was confusing.
>
> The tool runs itself in the link_manifest step. Since the file is no longer copied to what will be the current directory when linking, I believe this will be broken. But the GN build does not use the manifest linking command. To keep changes minimal, I kept this code in for now.
>
> Committed: https://crrev.com/6afaa104b1fa8c6caee4e53b2e37142832ec9f9e
> Cr-Commit-Position: refs/heads/master@{#414859}

TBR=scottmg@chromium.org,dpranke@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2287833002
Cr-Commit-Position: refs/heads/master@{#414880}

This CL enables isolated extensions. Removal of the command line flag and
the field trial will be done in a separate CL.

BUG=545200

Review-Url: https://codereview.chromium.org/2285883002
Cr-Commit-Position: refs/heads/master@{#414879}

Hunspell cannot handle invalid UTF8. Chrome makes sure that all
data is in valid UTF8 - this CL enforces the same for the fuzzer.

BUG=none
R=mmoroz@chromium.org

Review-Url: https://codereview.chromium.org/2223603002
Cr-Commit-Position: refs/heads/master@{#414878}

BUG=598141

Review-Url: https://codereview.chromium.org/2246263002
Cr-Commit-Position: refs/heads/master@{#414877}

Review-Url: https://codereview.chromium.org/2286963002
Cr-Commit-Position: refs/heads/master@{#414876}

Also changes FindTrustAnchorsByNormalizedName to FindTrustAnchorsForCert, as
some different implementations may do normalization differently. By passing in
the target cert, the implementation can decide whether to use the
pre-normalized issuer or the raw one.

BUG=635203

Review-Url: https://codereview.chromium.org/2266333002
Cr-Commit-Position: refs/heads/master@{#414875}

If you have lots of processes running then N/A makes the available stats
stand out less clearly from the not-available or not-applicable fields.

Using a dash instead makes it easier to glance across the available
stats.

Review-Url: https://codereview.chromium.org/2175003003
Cr-Commit-Position: refs/heads/master@{#414874}

BUG=
TBR=jbudorick@chromium.org

Review-Url: https://codereview.chromium.org/2282893002
Cr-Commit-Position: refs/heads/master@{#414873}

Added a new multi-track (2 audio + 2 video tracks) .mp4 file for tests
and MP4StreamParser to handle multiple tracks properly.

BUG=249427, 249428

Review-Url: https://codereview.chromium.org/2254733006
Cr-Commit-Position: refs/heads/master@{#414872}

This was a recent regression. Logic was added to make a top level editable a container (so that navigation would descend into it). However, we were previously using the container predicate to decide whether or not to set focus; this prevents focus() on roots which sometimes triggered other side effects such as focusing a descendant.

Make the focus precondition check the structuralContainer predicate instead.

BUG=640587
TEST=chromevox_tests

Review-Url: https://codereview.chromium.org/2273373002
Cr-Commit-Position: refs/heads/master@{#414871}

Playing this animation right after the task transition animation
causes a lot of jank. Removing it for external intents.

BUG=641592

Review-Url: https://codereview.chromium.org/2280233004
Cr-Commit-Position: refs/heads/master@{#414870}

https://pdfium.googlesource.com/pdfium.git/+log/3e98158a6c47..35396df876cb

$ git log 3e98158a6..35396df87 --date=short --no-merges --format='%ad %ae %s'
2016-08-26 vmpstr build_gyp: Remove deprecated flag, which is enabled by default.
2016-08-26 npm Revert "Remove the document tagged code as it is unused."
2016-08-26 tsepez Rework CFX_CountRef in terms of CFX_RetainPtr.
2016-08-26 npm Move the classes in fpdf_text_int.cpp into their own files
2016-08-26 thestig Roll DEPS for skia to 3bf7509c.
2016-08-26 thestig Roll DEPS for icu to 2341038b.
2016-08-26 thestig Roll DEPS for clang to 797371be.

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2284023002
Cr-Commit-Position: refs/heads/master@{#414869}

BUG=626802

Review-Url: https://codereview.chromium.org/2280473002
Cr-Commit-Position: refs/heads/master@{#414868}

Reland of Background tracing: Added config option for repeated trigger behavior (patchset #1 id:1 of https://codereview.chromium.org/2265423002/ )

Reason for revert:
Re-landing with fix

Original issue's description:
> Revert of Background tracing: Added config option for repeated trigger behavior (patchset #1 id:1 of https://codereview.chromium.org/2247033005/ )
>
> Reason for revert:
> Test is flaky on builder "Android Tests"
>
> Builder: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests
>
> Failure:
> https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/30899
>
> Output:
> BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored (run #1):
> [ RUN      ] BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored
> [WARNING:dns_config_service_posix.cc(316)] Failed to read DnsConfig.
> [ERROR:devtools_http_handler.cc(228)] Cannot start http server for devtools. Stop devtools.
> ../../content/browser/tracing/background_tracing_manager_browsertest.cc:1210: Failure
> Value of: BackgroundTracingManagerImpl::GetInstance()->IsTracingForTesting()
>   Actual: false
> Expected: true
> ../../content/browser/tracing/background_tracing_manager_browsertest.cc:95: Failure
> Value of: value
>   Actual: true
> Expected: expected
> Which is: false
> [  FAILED  ] BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored, where TypeParam =  and GetParam() =  (188 ms)
> [----------] 1 test from BackgroundTracingManagerBrowserTest (188 ms total)
>
> Original issue's description:
> > Background tracing: Add config option to control whether or not to stop reactive tracing when a repeated trigger occurs
> >
> > R=simonhatch@chromium.org
> > BUG=637129
> >
> > Committed: https://crrev.com/fba230c24383ae08ea6d924401bdff81b46c7108
> > Cr-Commit-Position: refs/heads/master@{#412577}
>
> TBR=simonhatch@chromium.org,ssid@chromium.org,petrcermak@chromium.org,oysteine@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=637129
>
> Committed: https://crrev.com/ccb0f2af13bf3cc4ebdcdd7a08e19b281d788897
> Cr-Commit-Position: refs/heads/master@{#413627}

TBR=simonhatch@chromium.org,ssid@chromium.org,petrcermak@chromium.org,megjablon@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=637129

Review-Url: https://codereview.chromium.org/2285853002
Cr-Commit-Position: refs/heads/master@{#414867}

The sliding subpages in neon-animated-pages (settings-animated-pages)
shouldn't protrude past the edges of the card when sliding left/right. A
stacking context ensures this without screwing up positioning of the card.

BUG=640315
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2264353004
Cr-Commit-Position: refs/heads/master@{#414866}

BUG=641559

Review-Url: https://codereview.chromium.org/2283193002
Cr-Commit-Position: refs/heads/master@{#414865}

TBR=kbr@chromium.org
BUG=638744
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2283963003
Cr-Commit-Position: refs/heads/master@{#414864}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/8cd6b383748124dfa3c7f27ab70ee75377bf16f6 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/0fb3089acff0b491685af54a4f90e0a4de693e39 Add dtu to recipes/bisection OWNERS. (dtu@chromium.org)
depot_tools:
  https://crrev.com/0b7cf885e03dcabae34c29e2a751a88ac9af9d7f Remove Deps2Git references from bot_update.py (hinoka@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2282883004
Cr-Commit-Position: refs/heads/master@{#414863}

Build and link against the Ubuntu Precise amd64 sysroot on Desktop
Chrome OS instead of always using the system libraries.

BUG=638394

Committed: https://crrev.com/c575bbcd130b38994e36b0a97bfe5ceea954a643
Review-Url: https://codereview.chromium.org/2272273002
Cr-Original-Commit-Position: refs/heads/master@{#414564}
Cr-Commit-Position: refs/heads/master@{#414862}

This was added so that chrome_elf wouldn't try to initialize crash
reporting when loaded in browser_tests, etc. But subsequently the
dependencies have been cleaned up, and browser_tests doesn't link
chrome_elf, so shouldn't be necessary any more.

Also messes up the obscure case when people rename chrome.exe.

R=robertshield@chromium.org, ananta@chromium.org
BUG=604923, crashpad:106, 568664

Review-Url: https://codereview.chromium.org/2279943002
Cr-Commit-Position: refs/heads/master@{#414861}

The palm suppression is enabled by an internal stylus enabled
TouchEventConverterEvdev via a callback to InputDeviceFactoryEvdev.
When in palm suppression mode, all internal touchscreen devices will
be disabled.
Before a touchscreen would lift all touches when disabled, and
re-initialize when re-enabled. To prevent the unnecessary ioctls the
code has been updated to force cancel all touches while disabled, but
continue to read and sync the internal touch state. This will also
make sure that touches that went down while disabled, will not
suddenly show up after enabling and continue to stay cancelled until
lifted.

BUG=636458

Review-Url: https://codereview.chromium.org/2263693003
Cr-Commit-Position: refs/heads/master@{#414860}

Renames it tool_wrapper.py but otherwise keeps it unchanged from the original
https://chromium.googlesource.com/external/gyp.git/+/master/pylib/gyp/win_tool.py

I changed internal references to itself to tool_wrapper.py, and split the internal strings containing the word "Copyright" (which it uses to filter tool output) to avoid triggering the copyright presubmit check.

Changes the build to refer to the file in-place rather than copying it to the build directory which was confusing.

The tool runs itself in the link_manifest step. Since the file is no longer copied to what will be the current directory when linking, I believe this will be broken. But the GN build does not use the manifest linking command. To keep changes minimal, I kept this code in for now.

Review-Url: https://codereview.chromium.org/2287603003
Cr-Commit-Position: refs/heads/master@{#414859}

Changed the pin keyboard to match the specs at https://folio.googleplex.com/cros-core-ui/spec#%2F5.1%20-%20Start%20screen%20Pin%20lock%20pods.png%3Fz=width, minus the submit button on the normal pod and the errors on the pin keyboard.

BUG=627222
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2222583002
Cr-Commit-Position: refs/heads/master@{#414858}

Revert of Adding Site Isolation Win bot filtering for WindowOpenPanelTest.WindowOpenFocus. (patchset #1 id:1 of https://codereview.chromium.org/2269523003/ )

Reason for revert:
The filter file is apparently not needed anymore: despite the fact that the test got renamed in r413759, we are not seeing failures in the WindowOpenFocus test in the latest builds on Site Isolation Win bot.

Original issue's description:
> Adding Site Isolation Win bot filtering for WindowOpenPanelTest.WindowOpenFocus.
>
> BUG=639510
>
> Committed: https://crrev.com/a98073ac85514395939268f9d71a5d609867d450
> Cr-Commit-Position: refs/heads/master@{#413773}

TBR=creis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=639510

Review-Url: https://codereview.chromium.org/2287743002
Cr-Commit-Position: refs/heads/master@{#414857}

BUG=636109

Review-Url: https://codereview.chromium.org/2281963002
Cr-Commit-Position: refs/heads/master@{#414856}

This CL is a follow-up to CL 2273083002 where the <h2> sub-labels were
updated to the current mocks. The displays sub-page (chromeos only) also
needed to be updated.

BUG=638461
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2283933002
Cr-Commit-Position: refs/heads/master@{#414855}

BUG=none

Review-Url: https://codereview.chromium.org/2283963002
Cr-Commit-Position: refs/heads/master@{#414854}

Revert of exo: Disable RGBX fullscreen overlays. (patchset #1 id:1 of https://codereview.chromium.org/2278803003/ )

Reason for revert:
crrev.com/2281033003 makes it so the compositor sends only one plane to Ozone.

In this way Ozone will accept an RGBX fullscreen plane.

Original issue's description:
> exo: Disable RGBX fullscreen overlays.
>
> Fullscreen overlays have been enabled on minnie.
> Unfortunately there are some issues in HardwareDisplayPlaneManager::
> AssignOverlayPlanes with RGBX buffers.
>
> This patch disables the overlay optimization for those buffers
> while we work on a fix.
>
> BUG=b/29430506
>
> Committed: https://crrev.com/18d1778af83ec9877cdf33401eddf4b082f766ef
> Cr-Commit-Position: refs/heads/master@{#414281}

TBR=reveman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=b/29430506

Review-Url: https://codereview.chromium.org/2287773002
Cr-Commit-Position: refs/heads/master@{#414853}

Review-Url: https://codereview.chromium.org/2282963002
Cr-Commit-Position: refs/heads/master@{#414852}

Plugins (soon to be called Flash) needs to support 3 modes in the
default content setting.

This patch updates the MD SiteSettingsHandler to return the default
content setting as a string (instead of just a boolean).

BUG=622922
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2282603002
Cr-Commit-Position: refs/heads/master@{#414851}

BUG=none
TEST=none
TBR=pastarmovj

Review-Url: https://codereview.chromium.org/2282073002
Cr-Commit-Position: refs/heads/master@{#414850}

WindowAndroid object is cached in PermissionInfobars, and the object is
not updated since their creation. Yet after reparenting, WindowAndroid
has changed. This CL fixes this issue by adding a new public call,
onTabReparented() to Infobar.java

BUG=632477

Review-Url: https://codereview.chromium.org/2282953003
Cr-Commit-Position: refs/heads/master@{#414849}

When there's only one button, we show the gear icon with text. Otherwise, just show the icon directly.

BUG=641300
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2287453002
Cr-Commit-Position: refs/heads/master@{#414848}

This adds the experiment "PrerenderSilence" to disable all performance-related
uses of prerendering. The group name encodes a timestamp. After reaching this
timesamp, prerendering should continue as normal.

The expiration timestamp should be in GMT, since all Field Trial logic both on
the server and on the client are also in GMT.

Note: This makes FieldTrial metrics incorrect for the days shortly after the
expiration timestamp because the experiment is sticky to the session.

BUG=640592

Review-Url: https://codereview.chromium.org/2275933002
Cr-Commit-Position: refs/heads/master@{#414847}

Using StringView for inbound parameters and StringBuffer for outbound helps to avoid copies in important places (mostly when passing large protocol messages around).

This opens possibility to:
- use WTF::String in core/inspector instead of String16;
- make String16 an alias to std::basic_string<uint16_t> to leverage all existing
optimizations.

One possible optimization is to migrate search utility (in V8StringUtil) to
StringView and avoid any copies of content there.

BUG=637032

Review-Url: https://codereview.chromium.org/2260233002
Cr-Commit-Position: refs/heads/master@{#414846}

Generalizing updateInstancesAnimatedAttribute{,NoInvalidate} to one
higher-level helper to get rid of the subtle differences brought on
by the differences in invalidation semantics.

BUG=640676

Review-Url: https://codereview.chromium.org/2280923002
Cr-Commit-Position: refs/heads/master@{#414845}

Previously it was possible for a merge to trigger a tab model
model selection change. The tab model that was selected before
the merge should still be selected after.

BUG=637064

Review-Url: https://codereview.chromium.org/2281293002
Cr-Commit-Position: refs/heads/master@{#414844}

Review-Url: https://codereview.chromium.org/2283513002
Cr-Commit-Position: refs/heads/master@{#414843}