- 07 Nov, 2018 9 commits
-
-
Nate Fischer authored
No change to logic. This adds an UMA metric to see if the WebViewClient is a WebViewClientCompat or not. This will only ever be boolean (at least for the foreseeable future), so this should be safe to keep as a boolean histogram for now. R=changwan@chromium.org, isherman@chromium.org Bug: 901581 Test: N/A (not feasible to test metrics right now) Change-Id: I9e6ba219d4f5f26f1fec947ef9974549490e2258 Reviewed-on: https://chromium-review.googlesource.com/c/1318748 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605888}
-
Nate Fischer authored
loadDataWithBaseURL doesn't always accept encoded content. This moves the histogram code into the branch which actually accepts encoded content (since it's reasonable to expect an unencoded '#' in unencoded content). R=smcgruer@chromium.org, torne@chromium.org Bug: 902223 Bug: 823666 Test: None Change-Id: If5c912640ea81a4d6e333496233958f3323d9bd6 Reviewed-on: https://chromium-review.googlesource.com/c/1319347 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#605887}
-
Fabrice de Gans-Riberi authored
Bug: 902138 Test: Builds locally. Change-Id: If898f335dc9600d0de3996ecf45498bddb1322d9 Reviewed-on: https://chromium-review.googlesource.com/c/1321029 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#605886}
-
Dan Sanders authored
This UMA counts pictures output to Pepper clients, categorized by size and decoder type (HW vs SW). This will be used as a proxy for watch time / compute resources when evaluating PPB_Video_Decoder deprecation. Bug: 880984 Change-Id: Ifac8de6ada9ae8a700dc61db91830307a99aa85c Reviewed-on: https://chromium-review.googlesource.com/c/1306917 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#605885}
-
Varun Khaneja authored
Server side change: http://cl/219735922 Tested by checking the "ClientSafeBrowsingReportRequests" tab on chrome://safe-browsing Bug: 867518,901215 Change-Id: I04356eb38f7b2306c5b74baed6ca3f73969a3dbd Reviewed-on: https://chromium-review.googlesource.com/c/1313881Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#605884}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/34fc346a0c77..dc98b9b975fa git log 34fc346a0c77..dc98b9b975fa --date=short --no-merges --format='%ad %ae %s' 2018-11-06 peah@webrtc.org AEC3: Corrected include 2018-11-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7841106b..793c8566 (605607:605715) 2018-11-06 sprang@webrtc.org Update Android encoder to use GetEncoderInfo() 2018-11-06 gustaf@webrtc.org AEC3: Compensate comfort noise level for loss due to filter bank 2018-11-06 gustaf@webrtc.org AEC3: Computation of comfort noise gains from suppression gains Created with: gclient setdep -r src/third_party/webrtc@dc98b9b975fa The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:902262,chromium:902262 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3e5de56c6457fe51e999dd549f6f476401e4f482 Reviewed-on: https://chromium-review.googlesource.com/c/1320613Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605883}
-
Dmitry Titov authored
This reverts commit f3fe6cc9. Reason for revert: Broke compile: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/58434 Snippet: In file included from ../../chrome/browser/devtools/devtools_window.cc:31: In file included from ../../chrome/browser/ui/browser_window.h:31: ../../chrome/browser/chromeos/apps/intent_helper/apps_navigation_types.h:13:10: fatal error: 'chrome/browser/apps/foundation/app_service/public/mojom/types.mojom.h' file not found #include "chrome/browser/apps/foundation/app_service/public/mojom/types.mojom.h" Original change's description: > Move the app_service code to //chrome/services > > The app_service code was originally created under //chrome/browser, > specifically //chrome/browser/apps/foundation. This was because of an > early concern that the app_service implementation would need to be > tightly coupled to browser concepts, especially a Profile. More recent > prototyping suggests that this won't be the case. > > This is just a "git mv" plus some semi-mechanical clean-up, e.g. keeping > "#include" lines sorted. > > Change-Id: I0e511f5cab636afb7ac5e5235139873d75230377 > Reviewed-on: https://chromium-review.googlesource.com/c/1312435 > Reviewed-by: Dominic Battré <battre@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Nigel Tao <nigeltao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605876} TBR=avi@chromium.org,battre@chromium.org,rockot@google.com,dominickn@chromium.org,nigeltao@chromium.org Change-Id: I24d6e63366a96f0bf24ce62c74951187e2151bca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1321771Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#605882}
-
Jonathan Metzman authored
Bug: 901836 Change-Id: I086972b916d5b46d497a4b57ae60f64627d25551 Reviewed-on: https://chromium-review.googlesource.com/c/1321569Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605881}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e5f6a771e82..0ab40518b6d4 Created with: gclient setdep -r src-internal@0ab40518b6d4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9c0c40390dbfbff10b09fa19edbc88071e01261b Reviewed-on: https://chromium-review.googlesource.com/c/1321171Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605880}
-
- 06 Nov, 2018 31 commits
-
-
Qiyu Hu authored
CQ-DEPEND=CL:1316428 Bug: chromium:887029,b:118334521 Test: unittest Change-Id: I02bf1d4af3f08762c7ecf0ff69637ad53f0e014b Reviewed-on: https://chromium-review.googlesource.com/c/1313412 Commit-Queue: Qiyu Hu <qiyuh@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#605879}
-
CJ DiMeglio authored
This CL makes sure that the |video_frame_compositor_context_provider_| and references to it get dereferenced to the thread it is bound to (in this case, the |video_frame_compositor_task_runner_| Bug: 898989 Change-Id: I98654bb5a6b29a43a384ce0308b4b97d575903a0 Reviewed-on: https://chromium-review.googlesource.com/c/1303178 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#605878}
-
Kenichi Ishibashi authored
This is a follow-up CL of https://crrev.com/c/1307015. We don't use |dispatch_event_time| any longer. Change-Id: If14e295eb6c0a8d9b83f499e3b7f65d4ff6d1d27 Bug: 898020, 872567 Reviewed-on: https://chromium-review.googlesource.com/c/1319398Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605877}
-
Nigel Tao authored
The app_service code was originally created under //chrome/browser, specifically //chrome/browser/apps/foundation. This was because of an early concern that the app_service implementation would need to be tightly coupled to browser concepts, especially a Profile. More recent prototyping suggests that this won't be the case. This is just a "git mv" plus some semi-mechanical clean-up, e.g. keeping "#include" lines sorted. Change-Id: I0e511f5cab636afb7ac5e5235139873d75230377 Reviewed-on: https://chromium-review.googlesource.com/c/1312435Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#605876}
-
Istiaque Ahmed authored
Add caching for ContentHash instances for a particular version of an extension. Since ContentHash is required for all extension resource requests when content verification applies, this should speed up ContentVerifyJob. Note that we should expect gains in "ExtensionContentVerifyJob.TimeSpentUS" UMA. Bug: 796395 Test: No visible behavior changes expected. Change-Id: I4d03bcd95f00215628eb9b3f143e15e7bd2c84d5 Reviewed-on: https://chromium-review.googlesource.com/c/1266604 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605875}
-
Brandon Wylie authored
- Allows java to interact with the native CachedImageFetcher. - Android-side tries to read from disk directly, so the JNI can be skipped if the image is cached. Binary-Size: Temporary increase to support quick rollback. Bug: 897362 Change-Id: Ifd7c77e0eeef56ea49ec53b398b83f7cc134a479 Reviewed-on: https://chromium-review.googlesource.com/c/1297639Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#605874}
-
Lan Wei authored
Since we are not updating hover during mouse wheel scroll, we should update hover when we handle the GestureScrollEnd event on compositor or main thread. Bug: 877132 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I732aea455db927ff5ad44b89e7a446917ad94e35 Reviewed-on: https://chromium-review.googlesource.com/c/1265555Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#605873}
-
Albert J. Wong authored
The existing code null defers for RenderWidgetHosts that do not have a delegate registered. This occurs at least in some setups with file pickers and shared workers. Bug: 899430 Change-Id: Idfd22c18b06cd968100cfab8d8c5c060f4e42bdb Reviewed-on: https://chromium-review.googlesource.com/c/1321031Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#605872}
-
Fady Samuel authored
viz::LocalSurfaceIdAllocation bundles a viz::LocalSurfaceId and an allocation time for that viz::LocalSurfaceId. The purpose of this allocation time is to determine how long it takes for a surface to get embedded once an ID has been allocated for it. There was some concern raised about drift between LocalSurfaceIds and allocation times and so a previous CL bundled the two together in a class. This CL plumbs LocalSurfaceIdAllocation to more places to ensure the two quantities remain in sync with one another. This CL plumbs LocalSurfaceIdAllocation from ui::Compositor/RenderWidget to LayerTreeHost to LayerTreeHostImpl. Bug: 655231 Change-Id: I32b4734b187f4fb87dd3cb3e57a5ea86e0c4e359 Reviewed-on: https://chromium-review.googlesource.com/c/1318688 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#605871}
-
Christian Biesinger authored
Makes it possible to write slightly nicer code. R=dgrogan@chromium.org Change-Id: Id56804b53b0564bb4b9448459e7c9ab9ffdb9c66 Reviewed-on: https://chromium-review.googlesource.com/c/1321230Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#605870}
-
Sebastien Marchand authored
These bots don't exist anymore. Change-Id: Ia0554e83190a02184b5c53875d2aa1380498edfb Reviewed-on: https://chromium-review.googlesource.com/c/1321210Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#605869}
-
Xing Liu authored
This CL starts to add security check for download without renderer in non network service code path. The security hook is in content, so we may need to introduce some content dependency on network service code path as well. The in memory download backend of background download may have the same issue. These scenarios will be addressed in following up CLs. Bug: 883387 Change-Id: I02001fe97a54960903f26d0e5376f2a8b46e2db6 Reviewed-on: https://chromium-review.googlesource.com/c/1318840Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605868}
-
Scott Violet authored
The id is necessary for single-process-mash so that the browser process can know it's id and lookup windows (everything runs in the same process in single-process-mash). Outside of single-process-mash the id is really only useful for debugging. BUG=756085 TEST=covered by tests Change-Id: I3819c5492fe2bfeeb243c44c36cc948168824ab6 Reviewed-on: https://chromium-review.googlesource.com/c/1318447Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#605867}
-
Douglas Creager authored
Piece by piece, we are moving the Reporting and NEL processing code from URLRequest and friends into HTTPNetworkTransaction, to make sure that we produce reports for network requests as defined by the spec (e.g., for redirects and cached responses). This patch moves the processing of the NEL configuration header. Bug: 895823 Change-Id: If4bee0b03f3d6d5868146578551b7362f933a890 Reviewed-on: https://chromium-review.googlesource.com/c/1291231Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Douglas Creager <dcreager@chromium.org> Cr-Commit-Position: refs/heads/master@{#605866}
-
Christopher Cameron authored
The function RWHVMac::SynchronizeVisualProperties was inappropriate in a few ways: - it belongs in BrowserCompositorMac -- we can see this because all of its calls are to BrowserCompositorMac (and two helper functions were added to BrowserCompositorMac to allow this function to be put in the wrong place) - it calls DelegatedFrameHost::EmbedSurface, yet several of its callers also call DelegatedFrameHost::EmbedSurface just before calling it, usually with the almost-the-same-arguments (only differing by accident), making the call redundant - similarly, it calls AllocateNewRendererLocalSurfaceId, which updates dfh_local_surface_id_allocator_, usually with arguments that were just retrieved from dfh_local_surface_id_allocator_, making it a convoluted no-op - it has two different modes which should be two different functions, namely (1) force creation of a new surface id and (2) notify the host of a changed surface id Make some motions in the direction of cleaning this up - Rename BrowserCompositorMacClient::SynchronizeVisualProperties (which is fairly meaningless at this point) to OnBrowserCompositorSurfaceIdChanged. - Also change this function to not take an optional argument. Inline the optional-argument-not-passed version of this function at its only callsite, RenderWidgetHostViewMac:: EnsureSurfaceSynchronizedForLayoutTest. - Rename BrowserCompositorMac::SynchronizeVisualProperties to UpdateSizeFromChild Bug: 897156 Change-Id: Ib01aae5c0ef4e92298697c1840da7bc6e8cbf3a0 Reviewed-on: https://chromium-review.googlesource.com/c/1316678 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#605865}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/fa0076282e62..7808cc796ef1 $ git log fa0076282..7808cc796 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 johann.koenig vpx_codec_enc_config_default: disable 'usage' 2018-11-01 johann.koenig clang-tidy: fix vpx_img_wrap align 2018-11-02 johann.koenig fix snprintf error on windows 2018-10-30 sdeng Add highbd Hadamard transform C implementations 2018-10-30 johann.koenig clang-tidy: fix vpx_dsp parameters 2018-10-30 johann.koenig clang-tidy: normalize variance functions 2018-10-31 johann.koenig vp8 boolcoder: normalize to "bc" 2018-10-31 johann.koenig vp8dx_get_quantizer: normalize VP8D_COMP 2018-08-07 jianj vp8: fix to address overflow in decoder. 2018-10-30 johann.koenig clang-tidy: fix vp9/encoder parameters 2018-10-30 johann.koenig clang-tidy: fix vp9/decoder parameters 2018-10-29 chiyotsai Add SSE2 support for hbd 4-tap interpolation filter. 2018-10-30 johann.koenig clang-tidy: fix vp9/common parameters 2018-10-30 johann.koenig clang-tidy: fix vp8/encoder parameters 2018-10-30 johann.koenig clang-tidy: fix vp8/decoder parameters 2018-10-30 johann.koenig clang-tidy: fix vp8/common parameters 2018-10-25 johann.koenig vpx postproc: rewrite in intrinsics 2018-10-29 jingning Properly space qp in q mode for multi-layer ARF 2018-10-26 chiyotsai Add AVX2 support for hbd 4-tap interpolation filter. 2018-10-14 komh Fix compilation on OS/2 (...) Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I36192789bc9f35afe184700af394517db1cd8370 Reviewed-on: https://chromium-review.googlesource.com/c/1320509Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#605864}
-
Matt Reynolds authored
This CL defines the GamepadButtonEvent and GamepadAxisEvent types that will be used to return button and axis events to event listeners. BUG=856290 Change-Id: I52d4eb91f9e40fe86e45d498e8aa97ec341341d6 Reviewed-on: https://chromium-review.googlesource.com/c/1167976Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#605863}
-
Henrique Nakashima authored
Change-Id: Iecb28b4434c642dad8fe478f07606e8fab484d89 Reviewed-on: https://chromium-review.googlesource.com/c/1320809Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#605862}
-
Zhongyi Shi authored
Change-Id: Ic8678f6334ca6de12bfd0a07509500066ff3a25d Reviewed-on: https://chromium-review.googlesource.com/c/1318749Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#605861}
-
Martin Kreichgauer authored
This imports https://github.com/Microsoft/webauthn into //third_party. Bug: 898718 Change-Id: I71da8a1528475e5c287f2f2dbf549f8b9414a8da Reviewed-on: https://chromium-review.googlesource.com/c/1320202Reviewed-by:
Justin Schuh <jschuh@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#605860}
-
Steve Anton authored
Bug: 874296 Change-Id: Ic86b9420c7cbfc190a79fef13dfe4494bf039c3c Reviewed-on: https://chromium-review.googlesource.com/c/1318392 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#605859}
-
Sam Maier authored
This is a reland of ba0225d1 Fixed the build breakage downstream TBR=reland Original change's description: > Reland "Android: turning on bytecode checker" > > This is a reland of 0301a791 > > I don't think this would have caused a runtime chromeos error, since it's > a build time android change. If it pops up again that I broke the test, > I will investigate further. > > TBR=retry > > Original change's description: > > Android: turning on bytecode checker > > > > This arg was defaulting to false when it should have defaulted to true. > > > > TBR=turning off bytecode checks for certain dirs > > > > Bug: 874854 > > Change-Id: I248ccab0ed52079106b07e43a302927bfa4414c8 > > Reviewed-on: https://chromium-review.googlesource.com/c/1309973 > > Commit-Queue: Sam Maier <smaier@chromium.org> > > Reviewed-by: agrieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#605068} > > Bug: 874854 > Change-Id: Idc95750d4465ca53b72db26a98ce74724fe21968 > Reviewed-on: https://chromium-review.googlesource.com/c/1318071 > Reviewed-by: Sam Maier <smaier@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605347} Bug: 874854 Change-Id: I7d9cecced393853e9bfe2e6d9f5b184f6c9f1ffc Reviewed-on: https://chromium-review.googlesource.com/c/1320930 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#605858}
-
Katie Dillon authored
As pointed out in the bug, unhandled errors on worker threads were not properly being propagated for the parent thread to handle as the spec requires (https://html.spec.whatwg.org/multipage/workers.html#runtime-script-errors-2). This fix adds in the code to do that. Bug: 685303 Change-Id: Ie3e7ec03153a43efdc6e70b874d6b1a1d8ac35ef Reviewed-on: https://chromium-review.googlesource.com/c/1287208 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#605857}
-
Mason Freed authored
This changes the prior DCHECK() on double-calls to CompositeAllFramesThen() into a NOTREACHED/return. Previously, it was possible, in release builds, to start another composite while the previous one was still running, causing use-after-free situations. This doesn't normally happen in layout testing, and can't happen at all in a Chrome build, but this protects from ClusterFuzz issues. See https://clusterfuzz.com/v2/testcase-detail/4929420383748096 Bug: 899465 Change-Id: I2acd1128bf808b035850c9f36779326f18585864 Reviewed-on: https://chromium-review.googlesource.com/c/1311131 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#605856}
-
Dmitry Titov authored
This reverts commit 406c50b3. Reason for revert: Speculative revert to fix the test external/wpt/workers/semantics/structured-clone/shared.html first started to fail in build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/75530 If this won't fix the test, I'll reland the patch. Original change's description: > Fix 64 bit truncation warnings in renderer/core/fetch. > > Use appropriate types in fetch code. > > BUG=879657 > > Change-Id: I7f26d8a6651abafbb185193cc2670bcdb5eff05e > Reviewed-on: https://chromium-review.googlesource.com/c/1298329 > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605685} TBR=bokan@chromium.org,dtapuska@chromium.org Change-Id: I36f8751112daf958ef849549b2c94a57c297ab8f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 879657 Reviewed-on: https://chromium-review.googlesource.com/c/1321251Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#605855}
-
Mike Frysinger authored
The "help" ad-hoc parsing only works in the simplest case: grit help grit help foo When passing options to grit, the "help" builtin fails and producing confusing output: $ grit -i ... help No such tool. Try running 'grit help' for a list of tools. $ grit -i ... help xmb No such tool. Try running 'grit help' for a list of tools. Delay parsing of the "help" tool until after we've processed grit's core options. Bug: 747171 Change-Id: Iae5fdee2493346cee4272368ac8862647433faaf Reviewed-on: https://chromium-review.googlesource.com/c/1320690Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#605854}
-
Jun Mukai authored
The current combination of WindowTargeter with MaskedWindowDelegate isn't working well with Mash. Instead of doing this, it needs to use window targeter's new API for setting window masks. The GetEventHandlerForPoint should be fixed in a way to follow this new way. BUG=901546 TEST=the new test case also covers Change-Id: I0b095777450fab3fa28ff9ebd8473667f644ab9e Reviewed-on: https://chromium-review.googlesource.com/c/1320689Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#605853}
-
Mason Freed authored
This is a reland of c33a38d7 Original change's description: > Re-baseline tests after --enable-display-compositor-pixel-dump > > This CL enabled display compositor pixel dumps by default, which caused > this group of tests to fail due to either a) minor antialiasing artifacts, > or b) known differences in output due to being captured from the browser > side. > > https://chromium-review.googlesource.com/c/chromium/src/+/1213864 > > These bugs should be resolved with this CL: > - crbug.com/881040: Media controls now contain an overflow menu. > - crbug.com/667551: A bunch of tests are listed under this bug, and just > require rebaselining to fix non-material single-pixel > antialiasing failures. > - crbug.com/895556: These tests double their background size when the flag > is enabled. These were already fixed by another CL, > so they are NOT being rebaselined here, just removed > from TestExpectations. > > > Bug: 895912, 881040, 667551, 895556 > Change-Id: I14a1065df604151ed06f2a6be4da7eaa53968705 > Reviewed-on: https://chromium-review.googlesource.com/c/1303179 > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605004} Bug: 895912, 881040, 667551, 895556 Change-Id: I9b9d41cfda7ea06cf64313537ba2eaaa6336b513 Reviewed-on: https://chromium-review.googlesource.com/c/1318171Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#605852}
-
Shawn Gallea authored
Add enable_cast_wayland_server flag to selectively enable exo server use. Add a Cast-specific implementation of wm_helper. This implementation contains the minimum required to make exo work on cast shell. support EXO. Bug: 896710 Test: Built on ChromeOS, is not utilized yet as cast does not yet Change-Id: I0e38a415fbdecdbe7f116885ed9048834cbca1b5 Reviewed-on: https://chromium-review.googlesource.com/c/1294835 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#605851}
-
Adithya Srinivasan authored
After resetting the operation runner, we should clean up any existing FileSystemCancellableOperation bindings as they all point to operations that no longer exist. Bug: 899146 Change-Id: I70cf4008f64534a1ac22c2ffe507d5b2a9d16208 Reviewed-on: https://chromium-review.googlesource.com/c/1301960Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#605850}
-
Ken Rockot authored
Renames the "user ID" and "instance name" fields to "instance group" and "instance ID", respectively, per discussion on the bug. A follow-up will change the types of the instance group and ID fields to be optional UnguessableTokens instead of free-form strings. TBR=jam@chromium.org Bug: 895591 Change-Id: I0c4d75f5e12a468dad251f238813bc79c497830a Reviewed-on: https://chromium-review.googlesource.com/c/1318836 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#605849}
-