- 18 Sep, 2020 40 commits
-
-
Geoff Lang authored
The block size requirement for each mip level meant that all DXT textures had to be POT sized. Relax these restrictions for non-zero mip levels to allow NPOT DXT textures. Bug: angleproject:4841 Change-Id: I6d5cde0c9eec220d9d82a73fc069743d3a934746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416748Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808427}
-
Abigail Klein authored
loaded. AX-Relnotes: Give feedback when the accessibility tree has loaded on the chrome:accessibility page. Bug: 1082502 Change-Id: I4acacca12ed56b7e50af31c789aac300d939b845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418973Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#808426}
-
Alice Wang authored
This CL adds and records the metric StartedGuestSession when user opens incognito tab in the web sign-in flow. Bug: 1127841 Change-Id: I58b01077089f6cbf949719ba699c06d65bb7cb77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418095 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#808425}
-
Claude van der Merwe authored
Add wifi sync and phonehub multidevice features to proximity-auth webui for logging. Bug: 1117619, 1106937 Change-Id: Ibabda5a2d53642ece09fa070f49059cfb5f628b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418565Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Cr-Commit-Position: refs/heads/master@{#808424}
-
Olivier Robin authored
This CL adds a breakdown of the connection type as 2G/3G/4G. Previously, only 3G was reported. Change-Id: I4e80eb6d568e2ff56450ebd979e5461f5f4a035c Bug: 1128867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412310 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808423}
-
Victor-Gabriel Savu authored
It was replaced by Cryptohome.FreeDiskSpaceTotalTime2 since crrev.com/c/1955412 . Bug: None Change-Id: I7e567c4e204e77b6e36a80315b853bbc0d2480f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416277Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#808422}
-
Fredrik Söderqvist authored
* fO with composited descendant under other fO. * gBCR on fO and fO descendant. Bug: 738022, 848693, 976224, 1066421, 1111779 Change-Id: I0ea5e23ec4466fc206acdc60e04ae8582c587bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419011 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#808421}
-
Muyao Xu authored
AudioDeviceEntryView is changed to be a sub-class of HoverButton. Changed button colors and added ink drop effects in Cast/AudioDeviceEntryView. Bug: b/161610050, 1107162 Change-Id: If91d5041cbf81954bd2a3c9a8b5fd79fe3fdf22e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387204 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#808420}
-
rbpotter authored
These statements are no longer needed since Print Preview uses preprocess_grit to generate rollup input. Bug: 1128583 Change-Id: I9a513f6bdcc972bbfd823c39117634766b650b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414703Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#808419}
-
Ioana Pandele authored
This reverts commit 1f9b9db0. Reason for revert: The test failure was caused by the new button pushing list items off screen. The fix for this and other related test cases is at: crrev.com/c/2418672 Original change's description: > Revert "Add field trial testing config for password and safety check" > > This reverts commit 2346288a. > > Reason for revert: Suspected cause of failures of password related tests (testSelectedStoredPasswordIndexIsSameAsInShowPasswordEntryEditingView) on android-marshmallow-x86-rel and others: > > https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1349 > > Original change's description: > > Add field trial testing config for password and safety check > > > > Make sure that tests which were not meant for Safety Check explicitly > > disable the feature. > > > > Bug: 1070620, 1092444 > > Change-Id: I83ba782b73cff33f6b4b6f5afa0df9d9e4db2fd6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410866 > > Auto-Submit: Ioana Pandele <ioanap@chromium.org> > > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > > Reviewed-by: Mark Pearson <mpearson@chromium.org> > > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#807803} > > TBR=mpearson@chromium.org,ioanap@chromium.org,chouinard@chromium.org > > Change-Id: Ia51936bc2889d9fc9a8423f8d3c3186358fb045d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1070620 > Bug: 1092444 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416930 > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807928} TBR=mpearson@chromium.org,mdjones@chromium.org,ioanap@chromium.org,chouinard@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1070620 Bug: 1092444 Change-Id: I8ffe45012305e47bbc36c1972e17e28c54e0c5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418405Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#808418}
-
Xing Liu authored
Add the file size metric when the user select to download later. Add the download later choice metric with data reduction proxy turned on or off. Bug: 1128007 Change-Id: Ia31314fa5642f3fbc90f8e218e6549a69ca32b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416765Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808417}
-
Chris Hamilton authored
Currently the existence of an RTCPeerConnection in a LocalDOMWindow prevents that context from being throttled. RTCPeerConnection objects are used in fingerprinting libraries (typically for the IP information that the ICE exploration yields), but not subsequently actually used to send any data. This prevents these contexts from being throttled. It has been observed that these same fingerprinting libraries add RTCDataChannels to the RTCPeerConnection, and these channels stay forever in the 'connecting' state and never transition to 'open'. To allow the context to be throttled this CL modifies the logic to only notify the scheduler once the RTCPeerConnection is supplemented with an 'open' RTCDataChannel or a 'live' MediaStreamTrack, which indicates with much higher likelihood that actual data will be sent. The feature handle is removed when RTCDataChannel or MediaStreamTrack transition to readyState == 'closed'. BUG=1127481,1075553,1101731 Change-Id: I9d07992da717a9e36eb004a7af27c4b72f9ea08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406685Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#808416}
-
Tom Sepez authored
No functional change to shipping chrome, but avoid linking in some dead code should some third-party build chromium with the GN arg pdf_enable_v8 = false. Change-Id: Ib96547b7632bafc3aca992d903b24d4d1a348608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416850 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#808415}
-
Wenyu Fu authored
Currently shadow is only listening to scrolling behavior for ScrollingView, but didn't handled the view changes. This fix will update the shadow view visibility #onGlobalLayout. Bug: 1127816 Change-Id: I3a0b04bfb077d543fa0b41a9ece7890e5198d77f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416565 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#808414}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/feb4d10f7b2d..2e69a13d838d 2020-09-18 mtklein@google.com avx2 specialization for gather32 2020-09-18 johnstiles@google.com Migrate SkSL error tests to golden outputs. 2020-09-18 jvanverth@google.com D3D: Reset current descriptor tables when changing root sig. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I609f22f8f13fea59eb48e7c11a50fc2d046210e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418833Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808413}
-
Hiroki Nakagawa authored
This CL adds the DelayCompetingLowPriorityRequests UKM that sets to 1 when the DelayCompetingLowPriorityRequests optimization is used. This is used for measuring the application ratio of the optimization. UKMs on the Blink loading pipeline are basically recorded via LocalFrameClient::DidObserveLoadingBehavior, but it's not available from platform/loader/ where ResourceLoadScheduler lives. To make it accessible from the platform layer, this CL introduces LoadingBehaviorObserver interface. The interface is declared in the platform layer, and implemented by FrameFetchContext in the core layer. The implementation of the observer is passed to the scheduler on the scheduler's constructor. In browser tests, this CL replaces CloseWebContentsAndWait() with navigating to another page like other UKM browser tests. This is because WebContentsDestroyedWatcher used in the function apparently doesn't wait for metrics updates sent from the renderer process on frame destruction, and that results in test failures. UKM Privacy Review: https://docs.google.com/document/d/1qG9y8Q2N9C5VjMrli2lNPnt8qkJM3v_kpLeWCiyb0LU/edit?usp=sharing Change-Id: Ifc5fa6bfb1658420002f06be2959d4c19f428e1e Bug: 1112515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405343Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#808412}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009180800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/eFtZxt_O0mdourFDOeb_JGEWZ7XC8XgbJH1VY4D3tKsC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/167982582 Tbr: help-app@grotations.appspotmail.com Change-Id: I7c0866cafdd542d7a13f086f167537a0b02399a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418841Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808411}
-
Ayu Ishii authored
Change-Id: I58fc3bb0ea61cb2a04bde0b3c54e8ff8bd1ab00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414678 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#808410}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I8d0c9abb6509d312070ef2e2ad88a9c183b1b095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418835Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808409}
-
Dave Tapuska authored
Implement RequestDecode solely in blink calling a ScheduleAnimationForWebTests after a decode is queued. This matches the previous WebWidgetTestProxy override and is a similar flow for ForcedDraw presentation callback. BUG=1097816 Change-Id: I0beed33165e4e3b7245c5221ddc3f50bd95b0763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416256Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#808408}
-
Allen Bauer authored
Bug: 938501 Change-Id: Id081d75d91818bf63c78f07dd457d282d510c7a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415368Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#808407}
-
Andrew Grieve authored
Also: * Throws a more explicit exception for failed fetch. * Stops setting Cache-Control: no-cache Bug: None Change-Id: I380207b32497f1cb5467ff62bcd3c857dc03ff58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418799 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#808406}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bf3ca769044b..ac3fc4afea5d 2020-09-17 tcwang@google.com cros_build_lib: Fix UncompressFile to cope with xz_auto If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: If85ad8b4275bbf81f92e1e288095744c07236824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418837Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808405}
-
Gayane Petrosyan authored
Add range to text fragment selector when selection is too long is spans across block boundaries. Gradually add words from beginning and end of the selection until unique match is found. Bug: 1102382 Change-Id: I71ce2623dae410aa7f21861bf2a6de6911cfe692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412698 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#808404}
-
rbpotter authored
Bug: 1128583 Change-Id: I2398ae172380f4bb8478c7d4a0c51fa981e5ebb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414681 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#808403}
-
Fabrice de Gans-Riberi authored
The test is flaky on multiple platforms. TBR=joedow@chromium.org Bug: 1126973 Change-Id: I4584e882fa96a9e442f01ad975c3acf92c406aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418977Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#808402}
-
Dan Harrington authored
- Offline pages integration with zine is not needed, since Zine is iOS only, and offline_pages is Android only. This includes code in both ntp_snippets/ and offline_pages/. - Remove SuggestionsEventReporter Java integration, none of these apply to the new Feed. Bug: 1069183 Change-Id: Icd538c9cac875c0f656e6a1f2893ef238e313142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405810Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#808401}
-
Michael Lippautz authored
Avoids the propagation of the detached'ness state of DOM nodes. Instead, the state is just passed in as embedder data field, which is then picked up by the DevTools front end to compute the same information. This allows a unified heap implementation in V8 to be independent of the detached'ness state of DOM nodes. Dependencies: - https://crrev.com/c/2332174 - https://crrev.com/c/2328862 Bug: chromium:1110816 Change-Id: Iecae3cfaf5177e53958e468ae7342548a8e4e184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332442 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808400}
-
John Abd-El-Malek authored
Also add comments for the delegate methods. Change-Id: I39119f7496c8b57d9c51dcc39b6fbf1b3afdf6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413017 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#808399}
-
Omar Morsi authored
This CL changes the behaviour of ManagedNetworkConfigurationHandler::RemoveConfiguration to respect network configurations done by policy by preventing removing them. Bug: 470104 Change-Id: Ica30268a979c27084a58fd86745e613de10fce51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410865Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#808398}
-
Eugene But authored
The data is retrieved from PreviousSessionInfo singleton and includes the following fields: - free_disk_in_kb - memory_warning_in_progress Bug: 1103752 Change-Id: I10e6fe758bfde8ad753cbbd363ab34afc1a52e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414784 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#808397}
-
Patrick Noland authored
CustomTabToolbar uses different theme coloring logic than the other browsing mode toolbars; it only distinguishes between light and dark, without any consideration of site-specific customizations. This means we should use the AppThemeColorProvider in this context, rather than the TabThemeColorProvider. Bug: 1128337 Change-Id: I613e81b5fb735689c313bb1c7579a35012cd74bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415370Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#808396}
-
Ben Mason authored
TBR=eugene@chromium.org Bug: 1129740, 1122955 Change-Id: I2b70502587c1c889388113f58c9987e737a19d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418851Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#808395}
-
Evan Stade authored
The changes broke signin. Bug: 11289611 Change-Id: Id39601cef6257eaffa3b4fb0a3b6fb2ddd22107f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418564Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#808394}
-
Kevin Marshall authored
This is a reland of 13c126e3 Addresses the size increase by removing the dep on //ui/base. All uses of ui::ResourceBundle in CastRunner are replaced with disk reads. Original change's description: > [bindings] Define cross-platform NamedMessagePortConnector impl. > > Refactors NamedMessagePortConnector into a platform-agnostic component, > which can be reused across FIDL, in-process, and testing contexts. > It uses Blink messages and message ports as a common basis for > message and port transport. > > * Implements some missing portions of the Blink/FIDL MessagePort > conversion layer. > * Adds a Fuchsia implementation of NMPC. > > Bug: 1104369 > Change-Id: I01e86c38963bfb114a7466c6f73b143e5302ad1e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293110 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: David Dorwin <ddorwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806684} Bug: 1104369 Change-Id: I77dc7679030e0f0aa61ad4dba2050ce2cb6e22d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417492Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#808393}
-
Clayton Wilkinson authored
This updates the local-sdk.py script to build the terminal product vs. the core product. This is done to align local-sdk configuration with the configuration used when creating the prebuilt SDK images from Fuchsia. Change-Id: Icda16c36e2f850bd2ab595cbb35edc128657fa95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418848Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#808392}
-
Fabrice de Gans-Riberi authored
This reverts commit 34905419. Reason for revert: Causes crash in tests on linux-chromeos-dbg. First failing build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20491 Original change's description: > Add mock policy option to extension install mixin > > Add an option to initialize ExtensionForceInstallMixin with a > MockConfigurationPolicyProvider. > Use this option in ForceInstalledAffiliatedExtensionApiTest. > Add mixin support to ForceInstalledAffiliatedExtensionApiTest. > > Bug: 1090941 > Change-Id: Ieea931c108e091679be607045f405b55f4186a57 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416453 > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: David Bertoni <dbertoni@chromium.org> > Reviewed-by: Omar Morsi <omorsi@google.com> > Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808281} TBR=emaxx@chromium.org,dbertoni@chromium.org,omorsi@google.com,fabiansommer@chromium.org Change-Id: I1b888be0d90a6ef99ac4f9e6c431296062bdb5cc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1090941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419237Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#808391}
-
Rouslan Solomakhin authored
Before this patch, it was possible to delete the render frame host before the secure payment confirmation app, which owned an instance of an authenticator that must outlive the render frame host. This caused a crash. This patch makes secure confirmation app observe the render frame host deletion, so the app can delete the authenticator that it owns before the associated render frame host is deleted. The android implementation (currently behind chrome://flags/#enable-web-platform-experimental-features flag) has been changed to match the desktop implementation (behind origin trial in M-86) to create the authenticator on the main frame of the web page, so cross-origin web pages can exercise the payment credential, too. After this patch, the authenticator is deleted before the render frame host, which avoids the crash. Bug: 1125614 Change-Id: I83502b1b6bf23b838211687497a6498d5c4777ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410348Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808390}
-
Artem Sumaneev authored
Make IsManagedSessionEnabledForUser return default value when DeviceLocalAccountPolicyBroker is unavailable. IsManagedSessionEnabledForUser can crash while dereferencing nullptr broker. The crash can happen when: - DeviceSettingsProvider does not have a list of device local accounts in kAccountsPrefDeviceLocalAccounts, - and there is an attempt to autologin with public account before the device settings become available. The crash happens only during early initialization stage of browser. Specifically, upon call of ProfileManager::CreateInitialProfile(). Future calls of IsManagedSessionEnabledForUser (and there is a lot of them) will resolve default value into real policy value. Bug: 1061522 Test: manual with switches::kLoginUser and public account autologin Change-Id: Ia8b727fc96924da98003b7d06ff5f5397decb74f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410867 Commit-Queue: Artem Sumaneev <asumaneev@google.com> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#808389}
-
Rahul Arakeri authored
This CL fixes an issue with thumb drag after a jump-click. When user does a jump-click (but doesn't let go of the pointer) and drags the thumb, the scroller doesn't scroll. This happens because the "drag_state_" doesn't get initialized when a jump-click is performed. The fix is to initialize the drag_state_ so that the thumb can be dragged. Bug: 1127561 Change-Id: I32d38007e15e923fedfeb7ef81e9af98632510d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416864Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#808388}
-