- 27 Jul, 2020 22 commits
-
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I7c3351be98c309e93361f746d812be0dc361866d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319791Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791700}
-
Fergal Daly authored
NavigationControllerBrowserTest.SameDocumentNavigationToHttpPortZero exposed this by killing the renderer for having sent a bad message from ValidateDidCommitParams. By that point the |navigation_request_| has been consumed so ResetNavigationRequest does nothing and so CancelPendingIfNecessary does not destroy the speculative render frame. This test only fails when RenderDocument for subframes is enabled however, it seems it could happen without that. The fix is to ensure that CleanUpNavigation gets called even if there is no navigation_request_. Bug: 1100745 Change-Id: Icdcc17822be04237e9f038063d45ec993dc7ed92 Fixed: 1100745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275640 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#791699}
-
jongdeok.kim authored
Disallows LCD text if the effect node has normal filter operations. This CL simply checks only the intermediate node. Bug: 1074521 Change-Id: I6e9caec484599fa47e1649356e9762ca265bee22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312059Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: jongdeok.kim <jongdeok.kim@navercorp.com> Cr-Commit-Position: refs/heads/master@{#791698}
-
Honglin Yu authored
Add another two owners who come form the same team and are also primarily working on mlservice in CrOS. BUG=none TEST=no need for test Change-Id: If299a76ae10a50ed1a58edf7f02b7b34bcde3a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308614Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791697}
-
Wei Lee authored
Since we use worker for mp4 encoding in CCA. Bug: 980846 Test: The error in CCA(SWA) about content security policy gone Change-Id: Iaabec3ed8b80c1a53eec7f411f5fd3ff7284aa3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257080 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#791696}
-
jongdeok.kim authored
Uses explicit deletion instead, removes use of base/macros.h. Bug: 1010217 Change-Id: If003b6afe03b27581949e4a5aaaa64eab686d7db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315722 Commit-Queue: jongdeok.kim <jongdeok.kim@navercorp.com> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#791695}
-
Rachel Carpenter authored
Previously this was crashing if the user tried to open the help app from an incognito browser via shortcut or menu item. Bug: 1109517 Change-Id: I217e8d0d710c4b68ef22762752727bdc7ef0f03e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318888Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791694}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 97dc0827. With Chromium commits locally applied on WPT: 9c2ef271 "[COOP report] Add support for report-only" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dgrogan@chromium.org: external/wpt/css/css-tables NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I71c3ce16c2e52c41910bc26a6b5701aa60055da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318430Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791693}
-
Andrew Moylan authored
This reverts commit 5d615d61. Reason for revert: Rollback per pdyson concerns post-commit Original change's description: > Simplify some code and rely on TimeDelta::operator/() less. > > This code can use TimeDelta::operator%() to express the same thing in a > shorter way. Add a comment on one less-obvious block. > > Bug: none > Change-Id: I2d639ee85b4427a78a902cf8b8c1930828132edc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318967 > Reviewed-by: Andrew Moylan <amoylan@chromium.org> > Commit-Queue: Andrew Moylan <amoylan@chromium.org> > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791688} TBR=pkasting@chromium.org,amoylan@chromium.org Change-Id: Ib9e224f477393b8798c91fe2f3c2a1e99cb7c42b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319809Reviewed-by:
-
Koji Ishii authored
This pathc fixes hit-testing [culled inline] in the following conditions: a. The first fragment does not fit, but it is an atomic inline that it cannot be truncated. b. The atomic inline is within a culled inline. The culled inline algorithm relies on fragments from a |LayoutObject| appear in a row. Ellipsis for an atomic inline has the same |LayoutObject| as the atomic inline, but can appear at the top level. This patch fixes this by eliminating ellipsis from culled inline logic. [culled inline]: https://chromium.googlesource.com/chromium/src/+/master/third_party/blink/renderer/core/layout/ng/inline/README.md#culled Bug: 1104477 Change-Id: Ib0f7e5899e58c766554c78ddf45019deaf35ca96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318887 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791691}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4092923f790e..e1b484c6ce52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: johannkoenig@google.com Change-Id: I6e01e74514685db08ef6537735e2ec10c098ddb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319829Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791690}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595785360-983d9025ff958d5a15a6c9927ca675e304475be4.profdata to chrome-mac-master-1595807480-d008dd705c9cf90df13ad0e43c19aa435d2837a8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Iffefcc9bcecaf63de79e60639180fd7f796128e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319841Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791689}
-
Peter Kasting authored
This code can use TimeDelta::operator%() to express the same thing in a shorter way. Add a comment on one less-obvious block. Bug: none Change-Id: I2d639ee85b4427a78a902cf8b8c1930828132edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318967Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1595505150-4b6923c63ca1fabc99171826cfe4658bec498e66.profdata to chrome-win32-master-1595789207-a5f1c4250bc5f6d42bdf1b980d8df879d82cd223.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I0dda001a1380258f2fef6c0e2ab9a3041f65e7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319716Reviewed-by:
-
dpapad authored
This is necessary in order to have the Viewport class work for both PDFViewerUpdate=false/true codepaths. Previously the Viewport constructor was expecting a Window instance to be passed as the scrolling container, but that is no longer the case in the PDFViewerUpdate UI. This CL modifies the code such that the scrolling container passed to the Viewport constructor is: - the <html> element for PDFViewerUpdate=false - the #main element for PDFViewerUpdate=true In order to do so - the <html> element is given a height of 100%, so that offsetHeight has a meaningful non-zero value. - innerHeight/innerWidth is replaced with offsetHeight/offsetWidth. - pageXOffset/pageYOffset is replaced with scrollLeft/scrollTop - a new MockElement class is introduced to replace MockWindow in some tests (MockWindow is still used in toolbar_manager_tests.js) Bug: 1101598 Change-Id: I0d3fa1a8a0146c97ef636b01954911750b5be942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308865 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#791686}
-
Reilly Grant authored
This change prevents NFCHost from creating a new subscription to the PermissionController if one already exists from a previous call to GetNFC(). Bug: 1108299 Change-Id: Ie64f806971acca64a914bfbbc7eead35d5a8c1f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314789Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#791685}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8adc54693b70..07ae186b5ed8 2020-07-26 jmadill@chromium.org Capture/Replay: Update headers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I861df1d86c47d93bf1ccab9847f23fcb18d66850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319722Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1595762871-f2fc22bdf1dd8f288d28123992fa5967a6d5fda0.profdata to chrome-win64-master-1595785360-159b80f78c6519bfeba1228f89c3740bd393f1a5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I3f6e9a11c624b847b3bcd2a3c5a5d81b693cfccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319709Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I24d321195e91298e4704feca98e156fd3925952a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319725Reviewed-by:
-
Scott Violet authored
The profile a WebContents is created with should always outlive the WebContents, so this conditional shouldn't be necessary. This was likely a work around for this fix: https://chromium-review.googlesource.com/c/1359827 BUG=none TEST=none Change-Id: I37f1117e706e0cf31ef508fdda63dcdb6c2885c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317830Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#791681}
-
Scott Violet authored
This has been enabled for ~2.5 years. I think we can get rid of the feature at this point. BUG=none TEST=none Change-Id: Ie10c5c1577176f44d1ba5b2589d9e5fda93f3bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315420 Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#791680}
-
tby authored
We currently don't handle tablet mode correctly, because the launcher is considered 'shown' in fullscreen mode at all times behind the active app. We need to observe some extra signal of when the launcher is shown or hidden. Talking to mmourgos@, the AppListControllerObserver is the right way to do this. Observer: I've had to lift the AddObserver and RemoveObserver methods out of the AppListControllerImpl and into the AppListController itself, so they are visible from chrome. Impressions logic: When the view state is 'shown', only the chips are shown. When the state is 'closed', we should set all views to none. Bug: 1097599 Change-Id: Idf971ccc5a4bb91c6167e234449a8ed6bee564f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309770Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#791679}
-
- 26 Jul, 2020 18 commits
-
-
David Munro authored
On track to launch for realsies this milestone. Additionally, PM guidance was that we should be enabling then merging a change to disable (if needed) before stable rather than using Finch which is what we're currently doing. The test check was hanging, and since the condition was never true before let's remove it. Bug: None Test: None Change-Id: Ie16eca37622ef1ad78c655fc7999ec7a0604286f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308430 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#791678}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72837dd225e3..4092923f790e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I7aee405d29b26e4dea643863301b3963071d317f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319721Reviewed-by:
-
Anand K Mistry authored
Bug: 1007788 Change-Id: If13e051b2d2c8800a802c4a29e0bde77b8afda84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279294 Commit-Queue: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Anand K Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#791676}
-
Yingbing Wu authored
This reverts commit 1cd61996. Reason for revert: "Kana" mode doesn't work when enable "ImeMozcProto". BUG=chromium:1108729 Original change's description: > Enable "ImeMozcProto" flag by default. > > Change-Id: I33d949c64f1432ae6ff29ab26e9a94cb7e97a2c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155763 > Reviewed-by: Darren Shen <shend@chromium.org> > Commit-Queue: David Vallet <dvallet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760747} TBR=dvallet@chromium.org,shend@chromium.org,googleo@chromium.org,wuyingbing@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I78651fa9deca36864583bbb76d93465783488dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319085Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#791675}
-
Jinsuk Kim authored
Omnibox is getting Tab instance from LayoutManager to find the right color for its background. After restart (by forcing-stop Chrome or by changing theme), however, LayoutManager was not setting the current Tab instance properly. This CL ensures it is done in the initialization step. Bug: 1108235 Change-Id: I3445e6c8b9de6bcb7582a42bd0544b05fbfe00b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315463Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#791674}
-
Zhenyao Mo authored
BUG=1109268 TEST=about:gpu R=kbr@chromium.org Change-Id: I3d72e4937cc43c3a3b816fbfd574247eb5c05f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317711 Auto-Submit: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#791673}
-
Zhenyao Mo authored
This may allow DWM and OS to reduce vsync when video is fullscreen and iflip. BUG=711140 TEST=manual R=khushalsagar@chromium.org,sunnyps@chromium.org,Rafael.Cintron@microsoft.com Change-Id: I77631a64f61961bccb983df6893d67cba71c99b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303646Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#791672}
-
Rachel Carpenter authored
These ones seem smaller as well which is a bonus. Bug: b/160203781 Change-Id: Ia7cc64693b881a6b71a0ba5f41b93a9536db6309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317245Reviewed-by:
-
Ian Kilpatrick authored
Bug: 958381 Change-Id: I702af63724bac4962258186b089940f3f397c9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295834 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#791670}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e861108bc656..72837dd225e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I6787c81c64b9297b0d26c19485d27c53e8f4c1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319712Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bef908ee7878..8adc54693b70 2020-07-26 syoussefi@chromium.org Vulkan: Generate mipmap in compute If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I830aee8c4f2e8f8e756d7effec6df74e69043057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319710Reviewed-by:
-
Xiyuan Xia authored
It turns out the problem is not with the display smoothness test itself. It is introduced by my CL:2132683 that attempts to fix acceleratorTest. It wraps chrome.test.succeed() in a setInterval callback. On slow bots, chrome.test.succeed() could be called more than once. As a result, tests could be invoked prematurely before the previous one finishes. This causes the problem for startSmoothnessTrackingExplicitDisplay because only one tracking per display is allowed hence it could only run after the previous startSmoothnessTracking finishes. This CL changes to setTimeout instead of setInterval to avoid checking test end condition multiple times during getAppWindowList call. It also moves chrome.test.succeed() out of timeout callback to ensure it is only called once. Bug: 1098886, 1108515 Change-Id: I8c04dc4d66f54bb28e8f3d407941083e89796b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316410Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791667}
-
Maxim Kolosovskiy authored
Bug: 1095627 Change-Id: If0b2ce840067480b4847a558b57b04c82ae8abff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310529 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#791666}
-
Ian Kilpatrick authored
As above - this only existed for modifying the baseline position on radio/checkbox for MacOS previously. With the form controls refresh launched this is no longer nessecery. Change-Id: I87091516980dec70287231045f1248bf1ce83aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225375 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#791665}
-
dpapad authored
Bug: 1101598 Change-Id: Ic83fc7e442158942a62feb8584471007447468c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309031 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595762871-f57a18dae0d23eb5476a17afe73c8569c909d4b4.profdata to chrome-mac-master-1595785360-983d9025ff958d5a15a6c9927ca675e304475be4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I948d15d4b2029df033244f1b810bda3e237dce06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319707Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed1310e11068..e861108bc656 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ifb870c572a2d846344b85528461d8c71a9bdb3c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319264Reviewed-by:
-
Yuke Liao authored
Bug: 816629, 1104318 Change-Id: I1280691aa11ba42b39af2fcc1534173eada2ce69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315422 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#791661}
-
