- 08 Dec, 2020 40 commits
-
-
James Cook authored
Per discussions with product and legal, we want to continue to use a single metrics reporting / crash upload consent on Chrome OS, for both the OS and the lacros browser. Notes at go/lacros-crash-consent Per design doc at go/lacros-metrics-consent, the initial value is sent as part of LacrosInitParams, which is available early in lacros startup. Lacros then registers itself over mojo as an observer for future changes. The observer is fired immediately when added to avoid a possible race condition. Future CLs will implement: * lacros -> ash communication if the user disables metrics in browser settings * Better interactions with device vs. user policy controls Bug: 1148604, 1143851 Test: added to unit_tests and lacros_chrome_browsertests Change-Id: Ib6431d33acab6cb8d4e95584a7d95288dc52ea27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570045Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#834531}
-
kouhei authored
This CL adds a loading telemetry benchmark that measures performance of agents heavy web-sites, which the MBI team currently targets optimization. The added benchmark is for an internal team use, and not yet scheduled on the perf waterfall (thus UNSCHEDULED_ prefix). Bug: 1051790 Change-Id: I96b9305bc8200153fa8587de338824d56bc47459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576056Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#834530}
-
Sammie Quon authored
For all modes for either rotation/bounds change: - End current drag - Redraw capture session layer - Reposition capture label and capture bar Additionally for region: - Reset selection region if rotation changes - Clamp the selection region to root window bounds if size changes Also fixes a bug where the user can select a large region on a display, exit and then enter capture mode on a smaller display. This CL will ensure the initial region is clamped to size of the smaller display. Fixed: 1154465 Test: manual + added Change-Id: I4dde6b97af9532d08f7e53348d7a8a28c0c38714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568669 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#834529}
-
Mila Green authored
Bug: 1148839 Change-Id: I79e98003e07ad15fbdf507e03aecd8699ee9d826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569103Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#834528}
-
Gabriel Charette authored
R=dmurph@chromium.org Bug: 1064645 Change-Id: I09c8e8fdf7a1555b6de5584d9b1d6ea04c273807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576631 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#834527}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607363880-e91185c7ee902dd489788046475ba4c3a284e8fb.profdata to chrome-mac-master-1607385573-20176c861cfdd390234dbdfc41d000ee505c292a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6aaa4d8354f3907de9dc0522ed5bd2d9dbd51a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577950Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834526}
-
Curt Clemens authored
Some error states are best resolved by trying again, so add that message to those error strings. On error, replace the white "Cancel" button with a blue "Close" button to help indicate that the process is finished and closing the dialog is the only way forward. Also update the info string on the discovery page. Bug: 1148581 Change-Id: Id8070de2fdc59a56a7d83d2196bc288452e558b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570337 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#834525}
-
Hirokazu Honda authored
This adds av1 10 bit streams decoding support to VaapiVideoDecoder. Bug: b:172223934, b:172217032 Test: video_decode_accelerator_tests --use_vd bear-320x180-10bit.av1.ivf Change-Id: I1c50516dba300fbe5e4b1056e931fb7da7264ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563183 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
David Staessens <dstaessens@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#834524}
-
Zhaoyang Li authored
The experiment has ended. Removing ios-simulator-code-coverage, ios-simulator-coverage-exp and ios-simulator-full-configs-coverage-exp from try builder list. chromium/tools/build: crrev/c/2578177 Bug: 1090188 Change-Id: I2c6c0a96bbb76c18afa58a5d853e3c09fbbd80a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577626Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#834523}
-
Yaron Friedman authored
Stopped when I hit TabObserver but this covers most of the clients BUG=783819 Change-Id: I499c6105c7c64f09d65bc07436cdb7c2112e7dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572244Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#834522}
-
Łukasz Anforowicz authored
This reverts commit 207fb0e1. Reason for revert: Trying again on M89 (with new crash keys from https://crrev.com/c/2575368) Original change's description: > Revert "Enable |request_initiator_site_lock| enforcement on Android." > > This reverts commit becee7ed. > > Reason for revert: Spike on M88 - most likely caused by https://crbug.com/1151008 and https://crbug.com/1151438 > > Original change's description: > > Enable |request_initiator_site_lock| enforcement on Android. > > > > The "RequestInitiatorSiteLockEnfocement" feature is enabled on desktop > > platforms in M87, because we want to be more careful on Android, since a > > mojo::ReportBadMessage might lead there to renderer kills (if > > NetworkService is hosted in the Browser process, something that never > > happens on desktop platforms). > > > > Since the M87 data so far looks good so far [1], this CL enables the > > enforcement on all platforms for M88. > > > > [1] https://docs.google.com/document/d/132ZPqDZdH-rcvBvHEAd-m86P2udVCi07ccnI0DXmJgE/edit# > > > > Bug: 920634 > > Change-Id: I5f27d9402b3e60668305312aa437252554890bc8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465803 > > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > > Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#816410} > > TBR=yhirano@chromium.org,lukasza@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 920634, 1151008, 1151438 > Change-Id: I7b2157914d8a091d21ce55bfc108c3029a4ff4aa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575358 > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833868} TBR=yhirano@chromium.org,lukasza@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 920634 Bug: 1151008 Bug: 1151438 Change-Id: Iff849597312d7843b1fff809a00743d0785680e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578100Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#834521}
-
Sammie Quon authored
This is a reland of 9771027b Original change's description: > desks: Fix crash when touchpad swipe with external monitors. > > The crash was because a new screenshot is requested when the current > screenshot is about to get scrolled out of bounds. It was using a fixed > number threshold, meaning displays that are not the same size could > get out of sync easily, leading to a CHECK failure. > > This CL addresses that by requesting screenshot on all displays if even > one of them needs one. Another approach would be change the spacing and > threshold to be based on the display width instead of fixed number, but > that could be prone to roundoff error which may cause a similar issue. > > Also noticed visible desk metric was double counting when there are > multiple displays. Added a TODO for that one as it is lower priority. > > Bug: 1154868 > Test: manual, added regression test > Change-Id: I48f5ef62d3284b710f44a2808f75c95686bc9b3d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570551 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833993} Bug: 1154868 Change-Id: Ib5a1fdd6b5778d350931663862c3204b1bab34fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575850Reviewed-by:
-
Bruce Dawson authored
NewTabButton::OnMouseReleased sets a member variable to point at a local variable, and leaves that pointer set after the local variable is "freed" (i.e.; after the function returns). That pointer is dereferenced during the destructor with undefined consequences. The fix is to zero the pointer before returning. A smart object that does this in its destructor would be safer, but is out of scope for now. I audited the other seven instances of this pattern that I could find and they are all fine. Bug: 1152152 Change-Id: Ia52d0abb80485503e9c2ae074e98ed12d654cbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578011Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#834519}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1c9380eb..8c0eca5f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idada0085508de1922a887b13ef8257ee0b465b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578157Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834518}
-
Regan Hsu authored
This CL is separate from CL 2577542 (to be merged to M88) because strings cannot be merged as well to M88. Bug: 1142971, 1106937 Change-Id: Ia63ab8a618b0fd9c5703f7d2a450b3a5496b5ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577544 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Chris Mumford authored
IndexedDBControlWrapper::BindRemoteIfNeeded gets a raw pointer to immediately wrap it with a scoped_refptr - which it already has. This change uses that existing pointer. This is a cleanup change - not expected to change any behavior. Bug: none Change-Id: I8b61717dcbb652d80ad7e80fde0a1e4ab108e5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569781Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#834516}
-
chrome-untrusted://croshJoel Hockey authored
Only use the builtin chrome-untrusted://crosh for Ctrl+Alt+T shortcut rather than allowing Secure Shell App to override. Users can still manually use Secure Shell urls such as chrome-extension://okddffdblfhhnmhodogpojmfkjmhinfp/html/crosh.html Bug: None Change-Id: I87743b662527ef8e42e27318dea47c407a951963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574639Reviewed-by:
Jason Lin <lxj@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#834515}
-
chrome://watchchrome://kaleidoscopeBecca Hughes authored
This will be the user facing URL for Kaleidoscope when it launches. We create an alias so existing users will not be affected by this change. Change-Id: I82a80c37374757a0e51b42a39f3bc918b35edf8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575389 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#834514}
-
Sara Kato authored
The array will ensure that the same properties are checked in ComputeNameFromContents() and HasText(). This will address b:172611390, as the on/off status was propagated as stateDescription (in ARC++ R), as opposed to name. By having the same properties checked in ComputeNameFromContents() and HasText(), this will also mean that the switch will not receive focus. ....On/Off" Test: AccessibilityNodeInfoDataWrapperTest.NameFromTextProperties Test: manual. Toggling hangouts switch will read "Improve Hangouts Bug: b:172611390 Change-Id: Ibdedf1a2dcde5db1ba7d78043d056423d6f74cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543527Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Auto-Submit: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#834513}
-
Reilly Grant authored
Enable most of the existing internal Web Platform Tests for the Web Serial API in worker contexts. The easiest way to make them work in the new context was to migrate to using test-only-api.js to load scripts at runtime. This will also make it easier to upstream these to the WPT repo later. Bug: 884928 Change-Id: If5e4219bfc51c39f50d0188c7281ba325c0ab5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572693 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#834512}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 561bac59. With Chromium commits locally applied on WPT: 86af9c78 "Revert "[blinkpy] Re-enable four css-background/ tests that need fuzzy reftest"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I648bd7d2a679643b91389e7bccaeb5e31bc557cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574679Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834511}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7bcd79eccf28..84b9bb6621c7 2020-12-07 ynovikov@chromium.org Add status host to CQ config If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1069673 Tbr: swiftshader-team+autoroll@google.com Change-Id: Id212c6d68531c93dc09c6c665ca6b27c8f0b5456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577534Reviewed-by:
-
Regan Hsu authored
ChromeVox will now verbalize "Phone Battery [displayed percent] percent" instead of "[displayed percent]" without any context about what the percent means. Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/72b4b1039e35fdd7f6d42bc25d509c1227e94d16 Fixed: 1152779 Change-Id: Icf6ccaf130989b8c73e12e6e47f760a987293bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577756Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Megan Jablonski authored
"rw", "or", "tt", "tk", and "ug" were launched by the Translate service in March. Add those that are supported by l10n to the default Translate supported languages list. Also update translate and l10n comment names to match those in the Translate service. Bug: 1150514 Change-Id: Ifd69d003c1f2b917af3ac57b2631a566c33f3853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561268Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#834508}
-
Peng Huang authored
Bug: 1155622 Change-Id: I8def57cef648ec4881f666aec614200d13eac972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577815 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Liquan (Max) Gu authored
This CL removes AndroidPaymentApp's dependency' on ChromeActivity by WebContents.getTopLevelNativeWindow().getActivity().get(). Bug: 1140340, 1156191 Change-Id: I8c0a5295ab931748c35c4d7c442f5b59b888af6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577856 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834506}
-
Nancy Wang authored
This reverts commit 2cf475dd. Reason for revert: <INSERT REASONING HERE> This CL looks break browser tests: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29 2 Test Suite(s) failed. browser_tests failed because of: NewTabPageCustomizeDialogTest.All ProfilePickerEnterpriseCreationFlowBrowserTest.CreateSignedInProfile NewTabPageModulesDummyModuleTest.All NewTabPageModulesModuleWrapperTest.All ...17 more failure(s) (21 total)... interactive_ui_tests failed because of: NewTabPageDoodleShareDialogFocusTest.All NewTabPageCustomizeDialogFocusTest.All NewTabPageMostVisitedFocusTest.All Original change's description: > NTP: Allow modules to instantiate the header > > This CL removes the module header from the wrapper and instead allows > the modules to instantiate it instead. This makes the title and actions > properties of the ModuleDescriptor obsolete, so this CL also removes > those. > > Bug: 1152205, 1152216 > Change-Id: Ib524a59c8c8a7cc69e130b31a8557b903233ab95 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570390 > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834424} TBR=tiborg@chromium.org,steimel@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I2a3471f3bef9d8b6b1c3c7c6f026f0d1c9da00d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1152205 Bug: 1152216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578296Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#834505}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under web_tests/fast/. Bug: 1113033 Change-Id: I0a7a2fbc4c32d1bb8ea4ad7f6af297c25c332778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573000 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Gavin Mak <gavinmak@google.com> Cr-Commit-Position: refs/heads/master@{#834504}
-
Hongchan Choi authored
AudioWorkletProcessor::CopyParamValueMapToObject() assumed the array topology is always valid (DCHECK), but if the user code actively mangles the parameter descriptor getter the array to return invalid content this assumption becomes invalid. The fix is to fail gracefully when the object type or the array content is not correct. Bug: 1151069 Test: The repro case does not reproduce any more after 1 hour run. Change-Id: I3f8decd3721e9b00ba201e2f76751e4bc941e05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569788Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834503}
-
Fabrice de Gans-Riberi authored
* Add an implementation for a Cast Streaming Sender for testing at // fuchsia/cast_streaming:cast_streaming_test_sender * Move some common conversion code to its own header Bug: 1087537 Change-Id: Icdf95dea5436646b5a6f9da72735720f64f6a359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573238 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#834502}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under web_tests/fast/. Bug: 1113033 Change-Id: Ia264d11f713b04f392be52ca503eb8dd5d412a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573157 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Shimi Zhang authored
Since the Android platform has this feature on Android R and above, we need to make it consistent with the platform. Bug: 1126778 Change-Id: Ie1404bc963e01b5154b4751413423f2e58ef9289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575729Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607353071-6048a593794456949e3ffd6a87397fecfdc4317e.profdata to chrome-win64-master-1607363880-ba632ae780cc1bebf61d324b0c586630719677ae.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2498f51fa6923e493d37b3bd4d340c04a7b4abe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577799Reviewed-by:
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under web_tests/http/. Bug: 1113033 Change-Id: I2e0be3a743d657d8ad986b56abde73b52fd15806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573001 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I8d224a4e5f9e77cebc7f24f11b9a53e4454d5ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577805Reviewed-by:
-
Nodir Turakulov authored
This reverts commit 76bc29ba. Reason for revert: the rolled CL was problematic and was reverted. https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2576761 Original change's description: > Roll Depot Tools from 3b055d329e60 to 8bbab2d87493 (1 revision) > > https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3b055d329e60..8bbab2d87493 > > 2020-12-08 nodir@chromium.org [dirmd] Roll dirmd > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/depot-tools-chromium-autoroll > Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: chromium:1154541 > Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com > Change-Id: I7708e6eed2fb6dbb672aca41e0f684536c27ac43 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577728 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#834492} TBR=ehmaldonado@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com,ajp@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,apolito@google.com,sokcevic@google.com Change-Id: Ic37722200d7c22be014a4f2d9d7707c8e9953d90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1154541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577763Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#834496}
-
John Lee authored
This CL adds support for screen readers to read out when browsing data is being cleared and when it has successfully cleared. There seems to be an issue when the IronA11yAnnouncer's element lives outside of a modal dialog as it is ignored by the screenreader. Similarly, if the alert is inside of the dialog, its contents do not get read if the dialog closes. Therefore, the "Clearing data" alert needs to live inside the dialog as it is read while the dialog is open, and the "Data cleared" alert needs to live outside of the dialog as it is read after the dialog is closed. Fixed: 1101151 Change-Id: I88c3dd98383b5d1b66a4b8492dcc8e8b817a8843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569942 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#834495}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I5d825e91720fcab6bafd486f41b6c67fe2dd7fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577798Reviewed-by:
-
Joel Hockey authored
Bug: 1098615 Change-Id: Ia0ac1e49eb8255b762211a13d1158395d05dca06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576233 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3b055d329e60..8bbab2d87493 2020-12-08 nodir@chromium.org [dirmd] Roll dirmd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1154541 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I7708e6eed2fb6dbb672aca41e0f684536c27ac43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577728Reviewed-by:
-
