- 25 Mar, 2020 40 commits
-
-
Mathias Bynens authored
The test was temporarily disabled (+ its expectations updated) here: https://chromium-review.googlesource.com/c/chromium/src/+/2119533 DevTools front-end CL that changed the expectations: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2119672 The downstream DevTools change rolled into Chromium here: https://chromium-review.googlesource.com/c/chromium/src/+/2119928 Bug: chromium:1051186, chromium:1051822, chromium:1057096 Change-Id: I1dfa629d3c763171d577ac04e554a6dad652efa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119513 Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#753196}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/054d61d117f0..bdb8301ab9c1 git log 054d61d117f0..bdb8301ab9c1 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 phoglund@google.com Remove some prints I accidentally left in. Created with: gclient setdep -r src/third_party/catapult@bdb8301ab9c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: Ib0dc5589f1b30436ab333ed26f78a64b2d89c433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120513Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753195}
-
Mark Cogan authored
I (marq) have rewritten most of the device sharing code in the last couple of weeks, so this CL adds me as an owner. I think erikchen@ isn't active on this code any more, so removing them as an owner. Change-Id: Id3c216b106260996099aa6516ee1073318ab340a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119852 Auto-Submit: Mark Cogan <marq@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#753194}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/26d52e1ba090..f5bbd1f06880 git log 26d52e1ba090..f5bbd1f06880 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c145d480..73b2f9fe (752799:753151) 2020-03-25 jonaso@webrtc.org remove deprecated fields in rtc::NetworkRoute Created with: gclient setdep -r src/third_party/webrtc@f5bbd1f06880 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I56f81820d7b72429b05a9287e93a7a0a9c7f9a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120512Reviewed-by:
-
Dominik Röttsches authored
Style, stretch and weight descriptor allow specifying ranges for the variable font that the src: descriptor is referencing. The range definitions allow both the smaller or larger value to go first and need to be swapped by the UA. Keep range value lists in reversed order in the computed style, but swap them in the FontFace implementation to become meaningful values.This keeps serialisation intact as specified in the @font - face declaration( as opposed to reversing the list at the CSS parsing level) and matches Firefox' behaviour. Adjust test expectations in at-font-face-descriptors.html for bounds out of order test cases: expect out of order bounds to be returned in order as specified. Test case was previously failing in all browsers [1] - with this change it will pass in Chrome and Firefox. Mark font-parse-numeric-stretch-style-weight.html test case "500 400 matches 500 400 for weight in @font-face" as passing in Chrome. [1] https://wpt.fyi/results/css/css-fonts/variations/at-font-face-descriptors.html?label=master&label=experimental&aligned&q=css%2Fcss-fonts%2Fvariations%2F Fixed: 1063867 Change-Id: I5ae7bc5f3e3a75fa9dce09ca0a66dd083ef29b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116447 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#753192}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d8f7a94b9dd6..b5ccc09e06b6 Created with: gclient setdep -r src-internal@b5ccc09e06b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I4ee6358a0a02e30821a190f0709bc6785ef92556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119929Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753191}
-
Stephen McGruer authored
Replaced with promise_rejects_js and promise_rejects_dom. Bug: 1051932 Change-Id: I3719c7857d55d177c39984390ef1a3a8f892ad69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116950Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#753190}
-
Vitor Carvalho authored
Supervised users are not longer calling SafeSearchUrlCheckerClient (crbug/940454). Bug: 936432 Change-Id: I34ae41f052a794d896262312c303fad88951a29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017003Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Vitor Carvalho <vtrmc@chromium.org> Cr-Commit-Position: refs/heads/master@{#753189}
-
Nohemi Fernandez authored
Enables new sign-in architecture using core Bling design paradigms. Design Doc: go/chrome-ios-signin-architecture-migration Bug: 971989 Change-Id: Iae18cd270ef688abf6bbdf5d67b072d3d890b0fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116071 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753188}
-
Milica Selakovic authored
This CL introducing 2 modes of collaboration between Password Manager and Autofill Assistant (who handles form submissions, whether to show prompts or not). Change-Id: I0394efa077060af2b6783add8a935658de8ee935 Bug: 1063347 Change-Id: I0394efa077060af2b6783add8a935658de8ee935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110231 Commit-Queue: Milica Selakovic <selakovic@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#753187}
-
Vadym Doroshenko authored
The autofill server sends the main prediction and the additional predictions. Now Password Manager processes only the main prediction. And it might lead to missing server prediction. Eg. when the main prediction is EMAIL, but additional is USERNAME. This CL implements using relevant additional predictions. Bug: 959776 Change-Id: Id1f82d40a8abc5e2cb4aff6750d68b156340f344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120393Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#753186}
-
Eriko Kurimoto authored
This CL handles parse error events in modules shared workers. By this change, parse error events invoked by top-level scripts and statically imported scripts can be handled by AbstractWorker.onerror. The HTML spec defines script parsing should occur during the fetch step and invoke a parse error event at that point if needed. This CL obeys this behavior for module script workers, but not for classic script workers because of an implementation reason that classic script workers are supposed to parse the script during the evaluation step. Therefore, the timing to catch parse error events differs. In this CL, parse error handling is only implemented for module shared workers, not for classic. This is discussed in the html spec issue: https://github.com/whatwg/html/issues/5323 The wpt to check this feature will be added from external github: https://github.com/web-platform-tests/wpt/pull/22185 Bug: 1058259 Change-Id: I2397a7de8e2ae732fb0b29aea8d8703dd2a79a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100058Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#753185}
-
Oksana Zhuravlova authored
This change addresses the unreachable code warning by moving the return statement to the outside of the array parameter handling loop in JSValueToMojom(). Also adds a check for size in the corresponding browser test. Bug: 346399, 794320 Change-Id: I1b4d77f395bc68c568c8969c398c1eab625aaa80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116648 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#753184}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3b9e4cb4..aafdcc7e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic7d7f8249b0043f0fb490346dc80e898dd43c696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119842Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753183}
-
Yuki Shiino authored
This patch implements indexed / named properties in the new bindings generator (not yet shipped). No change in prod. Bug: 839389 Change-Id: I4ebda31736eb0da9f2df2d3fbc70381677d7a56c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105653Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#753182}
-
Denis Kuznetsov authored
Change-Id: I5c8ce837ae685c86dc6383790dc6cf1e384def1d Bug: 1058022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110850Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#753181}
-
Mark Cogan authored
Removes the now-obsolete DEPS file from ios/chrome/browser/tabs. Bug: 620465 Change-Id: Icc1867e969fab76fdcc6d3577eb6eaddb4c59940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117738 Auto-Submit: Mark Cogan <marq@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#753180}
-
Nazerke authored
This CL modernizes the SadTabCoordinator - to use |browser| in the initializer - to remove the public property for dispatcher and browserstate. - to use self.browser to get browserstate and dispatcher values. This CL also updates the unit tests. Bug: 1029346, 1048669 Change-Id: Ia830b1f39448005109eb1193fdb82c11e14dfb4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093671Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#753179}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c6a4eddf528c..4e1cc676b6f7 git log c6a4eddf528c..4e1cc676b6f7 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 mathias@chromium.org Reland "Enable emulating locales" 2020-03-25 bmeurer@google.com Add petermarshall@ to OWNERS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@4e1cc676b6f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051186,chromium:1051822,chromium:1057096 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If4d19a47a1504c683345de2bf8668eec1f8d4017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119928Reviewed-by:
-
Eric Leese authored
This test verifies broken behavior, specifically ensuring disabled breakpoints are lost when in a script in multiple workers. This test has been replaced by a devtools end-to-end test. Bug: chromium:670180 Change-Id: I82e73eca50eaa7bddecb01ca7e7bf120bb354791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116214Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#753177}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9583c724. With Chromium commits locally applied on WPT: bb6643e9 "Simplify image-loading-subpixel-clip.html." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I219fbfbf595b02e532449cfbbaf1259c14fb159c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119841Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753176}
-
Olivier Robin authored
This has been replaced by ios_providers_resources_targets Change-Id: I591a4dabae484ed42ef502d364777a2dfaadb605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105302Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753175}
-
Jan Wilken Dörrie authored
This change removes PasswordUiEntry.numCharactersInPassword in favor of always showing 10 placeholder characters in the UI for hidden passwords. Bug: 1047726 Change-Id: I4801044d92ad545dc5856ba75cb850f0283f84b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116412 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753174}
-
Jiawei Shao authored
Reland with the fixes on the missing check in the test bodies so that they can early return when the platform does not support WebGPU. Original change's description: WebGPU: Add early-returns in the request of adapter and device when context is lost This patch adds early-returns in the request of GPUAdapter and GPUDevice when the WebGPU context is lost. In the following patches we will implement more clean-ups when the WebGPU context is lost. TBR=kbr@chromium.org Change-Id: I64f6b4c88d868f0e83c131875bfacd465279948a Bug: chromium:996713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119350 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#753173}
-
Jinsuk Kim authored
This CL deletes the public method |getProfile| in TabImpl. All the callsites uses Profile.fromWebContents directly. Bug: 995903 Change-Id: I6f9130628f9199dbe07006d883fc2299fed2e28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052404Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#753172}
-
Arthur Hemery authored
This CL adds two tests that exercise the interaction between COOP+COEP and the process reuse mechanism. Currently, the process used to commit a COOP+COEP page is included in the process reuse mechanism. We'd like to take it out of the mechanism, to ensure that no document are ever placed in a COOP+COEP process. Bug: 922191 Change-Id: I2055b20676350cf13c24328ac2bc019a6adcdcbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063005 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#753171}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8c53b6f52b29..c6a4eddf528c git log 8c53b6f52b29..c6a4eddf528c --date=short --first-parent --format='%ad %ae %s' 2020-03-25 szuend@chromium.org [issues] For affected cookies we link to corresponding requests Created with: gclient setdep -r src/third_party/devtools-frontend/src@c6a4eddf528c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0213e3bcf304e760c73cc8dd9e9c5dfc8337491b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119925Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2ffc95da474e..d8f7a94b9dd6 Created with: gclient setdep -r src-internal@d8f7a94b9dd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iaa4ee60a80762c62c117d0036afb902c22657ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119924Reviewed-by:
-
Ehimare Okoyomon authored
Disable the relevant radio buttons when cookie settings are managed by policy. Add the managed icon and string as well. ContentSettingManaged: https://screenshot.googleplex.com/XgDzZSKDnAZ.png TPCManaged: https://screenshot.googleplex.com/woXqLqAsqVX.png Bug: 1060118 Change-Id: Id896af4fc842795c123ed4b626278d36cf8db6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106584Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#753168}
-
Martin Šrámek authored
Since the corresponding setting was removed during the privacy settings redesign. We also back up its old value in case the redesign is rolled back. See https://docs.google.com/document/d/1gJVRKDO14ztyPyqiQpYKXPhmHyu9AgDh9v2nzd7yWaQ/ for the background. Bug: 1062698 Change-Id: I25cfddaec4646d2a588855c81cad36bfa6a5c590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107986 Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#753167}
-
Kinuko Yasuda authored
Examples: https://test-results.appspot.com/data/layout_results/Linux_Tests__dbg__1_/87734/blink_web_tests/layout-test-results/results.html https://test-results.appspot.com/data/layout_results/Mac10_13_Tests__dbg_/17624/blink_web_tests/layout-test-results/results.html TBR=npm@chromium.org Bug: 1062984 Change-Id: I48c5ee507812447f4e8089aeb6d2086d430ed25a No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119779 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#753166}
-
chrome://settingsVictor Hugo Vianna Silva authored
Feature kEnablePasswordsAccountStorage disabled: https://screenshot.googleplex.com/AaNqS7OxpNw Feature enabled, user not opted in: https://screenshot.googleplex.com/RBR6E3yzmkk Feature enabled, user opted in: https://screenshot.googleplex.com/4GbzCGPeddp On click of the opt-in button, a reauth flow will be triggered. On click of the opt-out button, no reauth is triggered. The UI is only temporary and will be updated once mocks are available. Bug: 1049141 Change-Id: Iceb293f3809e8995056a7c36989a6abeb462db62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108030Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
Eriko Kurimoto authored
This CL adds upgrade-insecure-request wpts to test static-import from dedicated workers and shared workers. The test scheme is implemented in the previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/2102036. This CL only removes 'worker-import' and 'sharedworker-import' from the excluded subresource list in spec.src.json and auto-generates tests. Bug: 989399 Change-Id: I3b799d7743306a8b5fca0d7292360a88d9b36ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117591Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#753164}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b867e14cac14..0eff2a2b463f git log b867e14cac14..0eff2a2b463f --date=short --first-parent --format='%ad %ae %s' 2020-03-25 jiawei.shao@intel.com Add validations on the creation of bind groups with storage textures Created with: gclient setdep -r src/third_party/dawn@0eff2a2b463f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I048a7396eb511a87316205660b56c7487656d565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119922Reviewed-by:
-
Mark Cogan authored
This CL updates the overscroll controller delegate protocol to also vend the fullscreen controller for the tab that's overscrolling. The delegate protocol already vends several other UI-specific objects, so this is in keeping with the existing protocol responsibilities. The OverscrollActionsControllerDelegate methods are also all updated to consistently follow ObjC style, passing the delegating object as the first argument in all cases. Since the OverscrollActionsController now gets the fullscreen controller from its delegate, there's no need for it to have a browser state injected, so that property is removed. Bug: 1063521 Change-Id: Ia42da793584d49225486887108403dd93022080d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116234 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#753162}
-
Nick Diego Yamane authored
Segfaults were observed when running under Wayland compositors that do not advertise primary selection protocol extension objects. For now, Ozone/Wayland supports only gtk_primary_selection version 1, which is likely not available in some compositors, such as, weston, sway, etc. This fixes the crashes by properly handling cases where the gtk primary selection protocol objects are not in place. R=msisov@igalia.com Bug: 1064410 Change-Id: Ia90b423208e64919f717442309a4c92cdb6749a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118237Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#753161}
-
Wei-Yin Chen (陳威尹) authored
Also update the default parameter of zooming-min-sdk-version to M. Bug: 964406 Change-Id: I90d35c365b690d788a6284a610a3828334e98cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114392 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753160}
-
Mathias Bynens authored
DevTools front-end CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2119672 Once that CL lands and rolls into Chromium, we can re-enable the test with its new expectations. Bug: chromium:1051186, chromium:1051822, chromium:1057096 Change-Id: I2bf3fff8443f96d3fcdc7b2e00fb721240f06b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119533Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#753159}
-
Wenbin Zhang authored
This CL added a argument for process_perf_results to allow skipping upload the results to perf dashboard. It is needed in the future when tester will skip the uploading step. Bug: chromium:1045256 Change-Id: I505dcf5625a193d030b44924f51fb51738a678a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113804Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#753158}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bb656b90. With Chromium commits locally applied on WPT: bb6643e9 "Simplify image-loading-subpixel-clip.html." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dcheng@chromium.org, palmer@chromium.org: external/wpt/domxpath NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I62ffee94d8011f098ed3ecaa0f04878bc483fa7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119835Reviewed-by:
-
