- 27 Jul, 2018 40 commits
-
-
Yiming Zhou authored
This change removes queuing the DidCommitAndDrawCompositorFrame message when Chrome commits a paint update. Queuing the message causes an additional blink update, resulting in a serious performance regression. The original intent of queuing the DidCommitAndDrawCompositorFrame message is to notify the WebContents when Chrome performs a paint, which in turn helps Chrome's experimental capture sites automation test framework. Since this performance regression is particularly large, and the absence of this event only impacts the test framework, we decide to remove queuing the message for now. Bug: 866981 Change-Id: I20e6fa6dbe1fd30f1529d6dda20e6208ae719bd1 Reviewed-on: https://chromium-review.googlesource.com/1153594Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578800}
-
Etienne Bergeron authored
Adding the navigation category to get better trace for omnibox debugging. R=oysteine@chromium.org Bug: 868419 Change-Id: I08842d4f8de7845f63a8add5ef2f10ab460b1ce5 Reviewed-on: https://chromium-review.googlesource.com/1153457Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#578799}
-
Aidan Wolter authored
Relanding go/chromium-cl/1145892 with the fix. This reverts commit 3f6d2857. Bug: b/111694183 Test: Numerous runs of cast_media_unittest Change-Id: I46dd922bd99e8a957d90446cfcebd56f405fdc0f Reviewed-on: https://chromium-review.googlesource.com/1153504Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#578798}
-
Peter Collingbourne authored
This reverts commit 1ba5d611. Reason for revert: Broke chromeos builders. Original change's description: > build: Enable ThinLTO in official Android builds. > > With this change we start building Chromium with ThinLTO when targeting > Android. In 64-bit Monochrome builds, the 32-bit binary is also built > with ThinLTO. This change is expected to reduce code size significantly > (in local measurements it reduced the size of MonochromePublic.apk by 2.3MB) > and is a prerequisite for enabling control flow integrity in official > builds. > > Note that although this change enables ThinLTO, it does not enable > the cross-TU optimizations normally associated with LTO. Enabling > cross-TU optimizations is a separate project. > > On my local machine (a Lenovo P920) libmonochrome.so link times increase > as follows: > > before after (first link) after (incremental links) > 32-bit 18s 140s 50s > 64-bit 13s 107s 41s > > All known blockers have now been fixed. This CL is likely to uncover > unknown blockers. > > Bug: 469376 > Change-Id: I8981e17abd50bc5ca00440e0d74dda878c911749 > Reviewed-on: https://chromium-review.googlesource.com/1150870 > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578195} TBR=thakis@chromium.org,dpranke@chromium.org,pcc@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 469376, 868426 Change-Id: I3938b0bbc5fdc0d689de21b52de2dd859852139b Reviewed-on: https://chromium-review.googlesource.com/1153396 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#578797}
-
Eric Karl authored
InProcessCommandBuffer doesn't currently handle dropping to 565 low-bit-depth on low-end Android. This CL adds this logic. To safely handle low bit depth and virtualized contexts, we need to know whether our target bit depth is compatible with the default offscreen context. This change passes the surface format of this context through CommandBufferTaskExecutor to allow this to be queried from InProcessCommandBuffer. Finally, as error-handling for the creation of the offscreen surface is currently a bit scattered, this CL simplifies things by creating this surface during init and passing it in to GpuChannelManager, so any callers can just assume success. BUG=868476 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8ffaa05e2ebbf6e910e76a8ef75095edf1cd3fe5 Reviewed-on: https://chromium-review.googlesource.com/1150966Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#578796}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ae0c5273bfa1..7e4b89eab724 git log ae0c5273bfa1..7e4b89eab724 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 michaschwab@google.com Number of Grid Lines depends on window width 2018-07-27 hjd@google.com perfetto-ui: Add TrackControllerRegistry Created with: gclient setdep -r src/third_party/perfetto@7e4b89eab724 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I17ba02694a0a55eeb6010825f92c1168c089b6df Reviewed-on: https://chromium-review.googlesource.com/1153511 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578795}
-
Vladimir Levin authored
In order to use geometry mapper, we need to ensure that the prepaint step of the lifecycle has run. However, if the target frame is throttled this is not the case. We don't want to force run it, because it causes compositing to run which has memory implications. Instead fall back to slow path in intersection geometry. Bug: 868230 R=chrishtr@chromium.org, pdr@chromium.org Change-Id: Icaef44dd3e399b12df77eb550eb5ae0fa43291b6 Reviewed-on: https://chromium-review.googlesource.com/1150876 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578794}
-
Steven Bennetts authored
In the two (soon to be three) places where we call BluetoothPairingDialog::ShowDialog, we first call device::BluetoothDevice::CanonicalizeAddress(address). We should do this in the ShowDialog call instead to simplify the calling code. Bug: 756094 Change-Id: Ie4b6ee4935bd9a632e231f5c07b4830fc590a832 Reviewed-on: https://chromium-review.googlesource.com/1153573Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#578793}
-
Kyle Horimoto authored
This CL inserts the appropriate strings to be displayed in the unified setup flow, and adjusts some styling to match the mocks. Still to be done: (1) Adding animations on both the "start setup" and "setup succeeded" pages; these animations have not yet been provided in the required SVG or PNG formats. (2) Inserting the correct icons on the "start setup" page; currently, the Google "G" icon is displayed multiple times. These icons have not yet been provided by UX. (3) Adjusting the forward/backward button styles. Multiple sets of mocks exist, each with different styles and different button text. (4) Making the pages "pixel-perfect"; this CL causes the page to match the mocks roughly, but there are a few edge cases. I didn't make all CSS perfect yet due to some inconsistencies with the mocks, and I want to make sure that the mocks are truly finalized before perfoming the rest of the UI polish work. Bug: 824568 Change-Id: I840afcb30f07d9d899ff17e156faa0268a5f556e Reviewed-on: https://chromium-review.googlesource.com/1152030Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#578792}
-
Pedro Amaral authored
Moved the incognito toggle button to the bottom toolbar and removed the new tab button and incognito toggle button from the top toolbar. Bug: 847639 Change-Id: I1a8c081251f2058f74ec7ad9b76865758fe136e4 Reviewed-on: https://chromium-review.googlesource.com/1152541 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#578791}
-
Peter Kasting authored
These will eventually be used for three purposes: (1) To allow generating different background tab images from a common tint for the inactive and incognito cases, thus allowing background tabs that blend into the frame for custom themes. (2) To allow autogenerating the background tab colors from the background tab images, thus letting us autocalculate better tab text/separator/etc. colors. (3) To allow theme authors to customize/override this behavior more precisely. Reasons (1) and (2) dictated the design here; reason (3) is basically a free bonus. I thought about not making these resources overrideable by theme authors, but there was some technical reason that turned out to not be easily feasible, and there seems little reason to prevent it. This also allows us to read THEME_TAB_BACKGROUND_INCOGNITO on Mac (Views). This shouldn't result in a visual change on its own. Bug: 862664 Change-Id: Icc57f78fd526d68b83c692fbac669a7371bb38ff Reviewed-on: https://chromium-review.googlesource.com/1147869 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#578790}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d8072e683a00..b9813d2fdd13 git log d8072e683a00..b9813d2fdd13 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 changwan@google.com Attempt to fix flakiness in webview_startup perf tests Created with: gclient setdep -r src/third_party/catapult@b9813d2fdd13 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:814330 TBR=sullivan@chromium.org Change-Id: I13248cdb34caeee208cd90f7c8e03f7c40e81cc6 Reviewed-on: https://chromium-review.googlesource.com/1153288Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578789}
-
Yafei Duan authored
Homepage tile should not be added to Most Visited tiles if the homepage url is google.com. Bug: 862786 Change-Id: Icb42ce4fb5f0c26bece80b7a7dd82bfd8526bcb2 Reviewed-on: https://chromium-review.googlesource.com/1152298Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#578788}
-
Steven Bennetts authored
IP config only exists for connected networks. Proxy config only exists for networks with a proxy configured. Storing these as a DictionaryValue takes 32 bytes, whereas storing these as a unique_ptr<> only takes 8 bytes. It also makes the symantics of whether or not the property as set a bit more clear. Bug: 651157 Change-Id: I4ab04ada996406bcace85c9038ac35f32b77054d Reviewed-on: https://chromium-review.googlesource.com/1152148 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#578787}
-
chaopeng authored
In this patch, we introduce a feature behind the flag: TouchpadAsyncPinchEvents to improve touchpad pinch zoom performance. We record the ACK of in a synthetic wheel event the first in pinch sequence. Then send the rest of the synthetic wheel events of the pinch sequence as non-blocking if the first event’s ACK is not consumed. We also add phase information to synthetic wheel event based on pinch event phase. Bug: 565980 Change-Id: Ic5d642d75f4102ee12b86fded0d6418fbe8b76e3 Reviewed-on: https://chromium-review.googlesource.com/1140909Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#578786}
-
bsheedy authored
Adds a couple of extra waitForTabPageLoaded to VrBrowserNavigationTest#testIncognitoMaintainsSeparateHistoryStack as a workaround for Incognito tabs reporting page load too quickly, which was causing flakiness. This can be removed once the root cause is fixed. TBR=asimjour@chromium.org Bug: 868506 Change-Id: Ie91a8213e641d9f51dc353d5215e8ac0695db059 Reviewed-on: https://chromium-review.googlesource.com/1153614Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#578785}
-
Ben Pastene authored
This prints an error if: - A line begins with '//' or '/*' - A non-comment contains a whitespace And prints a warning if: - A filter file contains both inclusions and exclusions Bug: 868000 Change-Id: I2a04504d3a17f4f7536b529a0e2e626eb6e61f66 Reviewed-on: https://chromium-review.googlesource.com/1153427 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Dmitry Gozman authored
WillSendRequest for main resource happens during BeginNavigation, so we can just skip it during commit time. The logic of saving metrics from DidReceiveResponse has been copied to CommitNavigation. We could get rid of DidReceiveResponse entirely if we were always going through CommitNavigation path, but we sometimes don't (see kWebNavigationPolicyCurrentTab returned from RFI::DecidePolicyForNavigation). Bug: 855189 Change-Id: Ib78bda6e22e4a301adf7c66215568ca6f02fa01d Reviewed-on: https://chromium-review.googlesource.com/1145900 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#578783}
-
Jun Choi authored
Create observer interface so that WebAuthN UI components (i.e. ChromeAuthenticaterRequestDelegate and AuthenticatorRequestDialog) can get notified of device discovery. Bug: 866601 Change-Id: I0af544f4c3754bd0b76b6a354833ed12858a0967 Reviewed-on: https://chromium-review.googlesource.com/1147307 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#578782}
-
Ben Pastene authored
TBR=jbudorick@chromium.org Bug: 840967 Change-Id: I69e89b0fc3ec3f658cd90e930d0cef7410cd3ae8 Reviewed-on: https://chromium-review.googlesource.com/1152040Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
The following patches change generic baselines, leaving NG-specific baselines stale and making those tests fail on layout_ng bot. This patch updates the NG baselines to keep up with the generic ones. https://chromium-review.googlesource.com/c/chromium/src/+/590273: - http/tests/loading/nested_bad_objects.php - http/tests/loading/preload-picture-nested.html - http/tests/loading/preload-picture-sizes-2x.html - http/tests/loading/preload-picture-sizes.html https://chromium-review.googlesource.com/c/chromium/src/+/1109819 - http/tests/navigation/form-targets-cross-site-frame-get.html - http/tests/navigation/form-targets-cross-site-frame-no-referrer.html - http/tests/navigation/form-targets-cross-site-frame-post.html - http/tests/navigation/form-with-enctype-targets-cross-site-frame.html https://chromium-review.googlesource.com/c/chromium/src/+/1006528 - http/tests/security/xssAuditor/block-does-not-leak-location.html https://chromium-review.googlesource.com/c/chromium/src/+/1147890 - http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events.html https://chromium-review.googlesource.com/c/chromium/src/+/1142571 - media/video-layer-crash.html - media/video-poster-scale.html - media/video-zoom.html Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id14eb56af7076931dd79c3815854177ca02c5acc Reviewed-on: https://chromium-review.googlesource.com/1153548 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#578780}
-
James Cook authored
This is a reland of 2094f015 Reason for previous revert: viz_browser_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/28406 The test wasn't cleaning up a test-only observer, so it was accessing invalid memory during the test shutdown spin of the message loop. Original change's description: > chromeos: Support a11y caret highlight in shortcut viewer app and mash > > The existing code updates the text input caret highlight by observing > input method state. This works in classic ash because the input method > is shared globally across ash and browser code. This doesn't work with > remote apps because ash can't see the input method in the remote > process. The caret doesn't work in mash because the ash process can't > see the browser's input method. > > Add support for a11y to observe the input method objects created by the > browser's input method driver / bridge. Explicitly forward the > text caret bounds to ash, which then updates the highlight. > > Bug: 867110 > Test: added to ash_unittests and browser_tests > Change-Id: I27058e091ad5a597de4ab644654df8d535e95b72 > Reviewed-on: https://chromium-review.googlesource.com/1151897 > Commit-Queue: James Cook <jamescook@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578473} TBR=tsepez@chromium.org Bug: 867110 Change-Id: I47b3b1af6d0bbc7183bbc7248492cb4d6ec3feca Reviewed-on: https://chromium-review.googlesource.com/1152373Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#578779}
-
Hiroshige Hayashizaki authored
Bug: 861564 Change-Id: Ia41cf740fc405269307a8c92c85d8aaf4b54c9d1 Reviewed-on: https://chromium-review.googlesource.com/1128541 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#578778}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b3bab6ce43ca..d72fd5888686 git log b3bab6ce43ca..d72fd5888686 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 thestig@chromium.org Fix some nits in FPDFEditEmbeddertest. Created with: gclient setdep -r src/third_party/pdfium@d72fd5888686 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I72ed8f9bbebf30397b365f7ce7f41561ce947fe5 Reviewed-on: https://chromium-review.googlesource.com/1153289Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578777}
-
Kenneth Russell authored
Better diagnostics have been added to the test, so expose any flakes that are still happening. Tbr: kainino@chromium.org Bug: 830901 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5b1ba714f4854ef87b89f52c6bcfcf7652f06350 Reviewed-on: https://chromium-review.googlesource.com/1153556Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578776}
-
Peter Kasting authored
* Add GetDefaultColor() mapping function to make it easy to fix DCHECKs due to this code using raw _INCOGNITO color constants but ThemeProperties::GetDefaultColor() not expecting them. This is the change that led me to get annoyed and do all the other stuff here. * Convert typedefs to type aliases. * Add TP = ThemeProperties type alias for brevity. * Use =default. * Mark functions that don't touch member variables "static". * Fix wrapping issues. * Because the class here is so long, split it into declaration and definition pieces so it's easier to see what's the API and what's helper functions. * Make the API protected; make helpers private. * Make data members private. Add a const accessor for the one member tests use. Bug: none Change-Id: I4cc058bb29747cfa84835edbc5ce765401e14527 Reviewed-on: https://chromium-review.googlesource.com/1152108Reviewed-by:
-
Donn Denman authored
Fixes a crash just introduce in CL https://chromium-review.googlesource.com/c/chromium/src/+/1045178 when clicking on a search result in the Overlay Panel. This click calls maximizePanel, but the previous CL needed to expose that to ContextualSearchPanel so it was overridden. That simple override was done incorrectly: it should call the super method but calls itself. BUG=868247 Change-Id: I2cabc1585d47f89414808f39c26b900d2e98f206 Reviewed-on: https://chromium-review.googlesource.com/1153442Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#578774}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f12600a8ba80..d795ab891c15 git log f12600a8ba80..d795ab891c15 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 jeremya@chromium.org Use system unzip on macOS 2018-07-27 jbudorick@chromium.org Add --patch_ref to bot_update. Created with: gclient setdep -r src/third_party/depot_tools@d795ab891c15 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:865882 TBR=agable@chromium.org Change-Id: I05fa055224a181227579280eb5427a86363e1115 Reviewed-on: https://chromium-review.googlesource.com/1153510Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578773}
-
Peter Kasting authored
* 16 DIP min width * 2.5 DIP minimum padding around favicons * Clamp radius to no more than 1/3 the width of the top of the tab The second and third bullets are subject to change pending further feedback. Bug: 848412 Change-Id: I5d800eb183b6ec2d3cd4933207f51f92b954fc9d Reviewed-on: https://chromium-review.googlesource.com/1152546Reviewed-by:
-
Bailey Berro authored
This change adds a NetworkFileSharesAllowed pref and policy to store whether or not a user is allowed to use the Network File Shares feature. Bug: chromium:757625 Change-Id: Icaf2015a841c31328b8cb36d26c73b2fa09fbcb6 Reviewed-on: https://chromium-review.googlesource.com/1141301 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#578771}
-
Bruce Dawson authored
Handling failures by crashing turns out to work poorly on Windows because it is confusing (it looks like a bug rather than a build failure) and because the process return code ends up being zero, so ninja doesn't realize anything is wrong. This change fixes these problems by detecting write failures and returning an error code. This particular CHECK is being fixed because it is easy to accidentally hit it simply by building Chrome while it is still running. The new error checking is also better in that it verifies that all Bug: 866656 Change-Id: I4303afaa898c85c72bd9d337fe8e19e239f17513 Reviewed-on: https://chromium-review.googlesource.com/1152159 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#578770}
-
Allen Bauer authored
Bug: 868169 Change-Id: I9adeed2a4fd8d57d3ae26e7885f66eb3bcfcd85d Reviewed-on: https://chromium-review.googlesource.com/1153581 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#578769}
-
Scott Violet authored
The number of shards for browser_tests on "Linux Chromium OS ASan LSan Tests (1)" was increased to 30 a while back, but not mash_browser_tests. This means mash_browser_tests often timeout on the bot. I'm upping the number of shards to be the same for the two. BUG=794372 TEST=none Change-Id: I24dd03bb0c61a65d34dfb290af1269026f9563a3 Reviewed-on: https://chromium-review.googlesource.com/1153549Reviewed-by:
-
Ramya Nagarajan authored
Specifically, this removes NewTabPageUIMd (which inadvertently enabled all UI features), and also removes NewTabPageCustomLinks (which is only available in M69). Bug: 831910 Change-Id: I03bc12477bba7f94576ff9a8f35f12ac3ba62299 Reviewed-on: https://chromium-review.googlesource.com/1153211Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#578767}
-
Kenneth Russell authored
These bots weren't building with these codecs and should have been. In at least one case (Win Builder), the fact that the waterfall bot wasn't building with the codecs represented a mismatch in configuration between the waterfall bot and trybot. This CL affects the configurations of the following machines: chromium.linux:Linux Builder (dbg) chromium.linux:Linux Builder (dbg)(32) chromium.linux:Linux Builder chromium.mac:Mac Builder (dbg) chromium.win:Win Builder chromium.win:Win Builder (dbg) chromium.win:Win x64 Builder chromium.win:Win x64 Builder (dbg) tryserver.chromium.linux:linux_chromium_dbg_32_ng tryserver.chromium.linux:linux_chromium_dbg_ng tryserver.chromium.mac:mac_chromium_compile_dbg_ng tryserver.chromium.mac:mac_chromium_dbg_ng tryserver.chromium.win:win10_chromium_x64_dbg_ng tryserver.chromium.win:win10_chromium_x64_rel_ng tryserver.chromium.win:win_chromium_compile_dbg_ng tryserver.chromium.win:win_chromium_dbg_ng tryserver.chromium.win:win_chromium_x64_rel_ng Bug: 867536 Change-Id: I04584548cb903df49ab1071535612ea151310c88 Reviewed-on: https://chromium-review.googlesource.com/1150450Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/021bad40ff8b..9bf86f07acd5 git log 021bad40ff8b..9bf86f07acd5 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 geofflang@chromium.org Don't sync the read framebuffer on draw calls. 2018-07-27 lrn1986@gmail.com Support EGL_(WIDTH|HEIGHT) in eglSurfaceAttrib(), fixed resize 2018-07-27 jmadill@chromium.org D3D: Return error from getVertexSpaceRequired. 2018-07-27 jmadill@chromium.org D3D: Pass gl::Context to many more functions. Created with: gclient setdep -r src/third_party/angle@9bf86f07acd5 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I1ef966bf7450d269cf65820f935cb9ca81e37c81 Reviewed-on: https://chromium-review.googlesource.com/1153508Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578765}
-
Scott Violet authored
This reverts commit 1fa4591e. Reason for revert: In hopes of greening tree. Sample failure from https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win/71221 : (see the compile no-op stage) ninja explain: output obj/content/test/nested_message_pump_android.lib doesn't exist ninja explain: obj/content/test/nested_message_pump_android.lib is dirty Original change's description: > Merge all content_shell renderer layout_test code. > > R=dcheng@chromium.org > TBR=jochen@chromium.org > > Currently layout test code is split over: > > - content/shell/test_runner/ (separate component) > Has renderer-side code, is allowed to use content/renderer/, does not > use content/shell/renderer/. > > - content/shell/renderer/layout_test/ (part of content_shell_lib) > Has renderer-side code, makes light use of content/shell/renderer/, but is > not able to use content/renderer/. > > - content/shell/browser/layout_test/ (part of content_shell_lib) > Has browser-side code, makes heavy use of content/shell/browser/, but is > not able to use content/browser/. > > - content/public/test/layouttest_support.h > Header for access to content/renderer/ things and content/browser/ > things. Used by content/shell/renderer/layout_test/ and > content/shell/browser/layout_test/. > > - content/test/layouttest_support.cc > Impls for access to content/renderer/ and content/browser/ things. > > > This patch aims to > 1. Combine the test_runner/ and shell/renderer/layout_test/ pieces of > code so they don't need to use indirections to interact. Their > separation is a legacy of test_runner/ being implemented inside blink > (WebKit) in the past. > 2. Move layouttest_support.h out of content/public/ and the .cc out of > content/test/ to a layout_test-specific code location. > > To do (1), test_runner/* moves to shell/renderer/layout_test/*. This > is fairly straight forward. We remove the TEST_RUNNER_EXPORT macro > as they are now part of a static library. They are left in the > test_runner namespace at the moment. > > To do (2), we move layouttest_support.(cc|h) to > shell/renderer/layout_test/. There are 3 methods in the file that > are called from shell/browser/layout_test/ and use content/browser > so we split those out to shell/browser/layout_test/. > > However this causes a problem that content_shell_lib will depend > on content/{browser,child,renderer}/ via the layouttest_support.cc > file. To avoid this, we > - Move content/shell/renderer/layout_test/* into a separate build > target called //content/shell:layout_test_renderer_lib and we > give it visibility to content/renderer/ and content/child/. > - Move content/shell/browser/layout_test/layouttest_support.* into > a separate build target called > //content/shell:browser_layout_test_support_lib. We don't move all > of content/shell/browser/layout_test/* because of heavy interaction > between it and its parent directory at this time. > - For a few files used by the shell/renderer/ (and shell/) and > shell/renderer/layout_test/ directories, we move them out to a > shared library as well, called > //content/shell:content_shell_renderer_common_lib. > - And for the common/layout_test/layout_test_switches.cc files, > which are used in both, but we'd like to not leak out of > content_shell_lib since they are part of .../layout_test/, we > make a non-public dep on //content/shell:content_shell_common_test_lib > > Ideally, I think we have a separate library for > //content/shell/browser/layout_test > //content/shell/common/layout_test > //content/shell/renderer/layout_test > > But we need better indirection between the content_shell_lib and > the .../layout_test/ code in order to do that. Once it was so, we > would be closer to making it possible to have a content_shell build > target that does not include any test code (and thus truly only uses > the public APIs), and a separate content_shell-like build target > that includes the layout test code. > > Bug: 866140 > Change-Id: Ia39f7385711bdb610948a07fd473ad9b346b82ae > Reviewed-on: https://chromium-review.googlesource.com/1145644 > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578734} TBR=dgozman@chromium.org,danakj@chromium.org,dcheng@chromium.org,jochen@chromium.org Change-Id: Ie61b12dcfc00e5c59cf0c5e3137b305d957cb261 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866140 Reviewed-on: https://chromium-review.googlesource.com/1153611Reviewed-by:
-
Johann authored
R=tomfinegan@chromium.org Change-Id: I926b4d76701861c4351baf6e4982ce0beb962e49 Reviewed-on: https://chromium-review.googlesource.com/1153584Reviewed-by:
James Zern <jzern@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#578763}
-
Gabriel Charette authored
This reverts commit 9442f946. Reason for revert: didn't budge the graph (https://chromeperf.appspot.com/report?sid=d99ad2294f639cf4e0d0bbfa0e9aee1cac5a0352ef9f35d266f375f52466a608&start_rev=1526716391&end_rev=1532706078) Original change's description: > [TaskScheduler] Require constant initialization for g_heartbeat_for_testing > > Somehow r562248 caused a regression whereby it should have been strictly > more performant, the only difference is the potential static > initializer (which if incorrectly initialized could result in it being > non-zero? and somehow cause the timer to be fast?). > Let's try to suppress it. > > R=fdoray@chromium.org > > Bug: 848255 > Change-Id: I21111ddd4c069b9171badc58fc4a1914bb068641 > Reviewed-on: https://chromium-review.googlesource.com/1090794 > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578420} TBR=gab@chromium.org,fdoray@chromium.org Change-Id: I457751dc2d9d410e049685e22cf3f79cf39d3c11 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 848255 Reviewed-on: https://chromium-review.googlesource.com/1153230Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#578762}
-
Klaus Weidner authored
The kMaxArea downsizing logic in WebGLRenderingContextBase::Reshape causes the drawing buffer size to be smaller than the canvas size if the size would exceed 16 MiPixels. See https://crbug.com/445542 for additional background. The GetStaticBitmapImage has two separate implementations that are selected based on the preserve_drawing_buffer attribute. The non-preserving mode returns an image sized to match the drawing buffer, while the preserving snapshot used the canvas size. Change GetImage to use the drawing buffer size also for consistency. BUG=845742 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8cb00444e18f075abde881c5bb155ef039f7a68e Reviewed-on: https://chromium-review.googlesource.com/1153483Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
-
