- 28 May, 2019 40 commits
-
-
Saman Sami authored
This CL enables all viz_unittests that pass with Vulkan. Bug: 961373 Change-Id: Ie0d0c590d58a930bf5e005dc233240203d76e773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625015 Commit-Queue: Saman Sami <samans@chromium.org> Auto-Submit: Saman Sami <samans@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#663761}
-
Koji Ishii authored
This patch stops propagation of setting NeedsCollectInlines at atomic inlines. Usually atomic inlines that have children are LayoutBlockFlow, but LayoutSVGRoot is one example that are not LayoutBlockFlow. This patch also clarifies the distinction when a parent of object needs to collect from when the object itself needs to collect. Bug: 966699 Change-Id: I260824f3e8e211f842aa7990c6d504a3c72549b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631016 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#663760}
-
Koji Ishii authored
This patch adds CHECKs to `LazyLineBreakIterator:: NextBreakablePosition` before reading from a raw pointer. This is a speculative fix. It is likely that there's a case where `NGLineBreaker` over runs `NGInlineItem::EndOffset()`, but we have not be able to find a locally reproducing case yet. The case in issue 967167 has a broken surrogate pair at the end, but it's still not enough to reproduce. Bug: 967167, 967439 Change-Id: I64973e8e7e41b5089147b0383178af6217b4db47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630141 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Lan Wei authored
In WebDriver spec, we assume that the actions with the same id and type are the same, we should give the pointer actions of different source types a different id. Bug: 606367 Change-Id: I1d8f6a08ee8d98c4afd281f077e23067ad915ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626960Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#663758}
-
Yi Su authored
This CL moves //ios/web/web_state/error_translation_util* into //ios/web/web_view:util. Bug: 942244,956511 Change-Id: Iee866e5f371e203720dfa3e128f848272ef78f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630160Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#663757}
-
Eric Stevenson authored
Change-Id: I54c4f60513076030258b1b6b3a6a6e681f353578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632300 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#663756}
-
Daniel Libby authored
This is a reland of 7e329171 Original change's description: > Log SCROLLBAR LatencyInfo's for main thread injected scrolls > > Note: based on crrev.com/1595296 > > When scroll gestures are injected during the handling of an input on > the main thread, we want to dispatch the scroll gesture with the > LatencyInfo information from the original input event, but with a > different type. This allows the end to end latency metrics to be > computed correctly and classified separately as a specific type of > scroll (not just, e.g. as mouse latency). > > Bug: 954007 > Change-Id: I725eaa46f21883aff08ab209d73dc5d0398a85db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603342 > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659630} TBR=tdresser@chromium.org, bokan@chromium.org Bug: 954007 Change-Id: I70f2c0e445c872bf357469f64f1d8104c1da62f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628955 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#663755}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cf49b6472020..176b214f91bc git log cf49b6472020..176b214f91bc --date=short --no-merges --format='%ad %ae %s' 2019-05-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@176b214f91bc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: Ia53e61f4d36b75bd62e2e8a0fcef38ea0a7b34d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631573Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663754}
-
Ivan Sandrk authored
Extending the histogram for another 6 months as the feature this is tracking is in public beta currently, and not fully launched yet. Bug: 967501 Change-Id: I6e66d4c9feabfa1a8d2883d33f17fedb2dbff6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631381Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#663753}
-
Sky Malice authored
Touchless doesn't support snackbars so use toasts instead. Bug: 959333 Change-Id: I14fcea19a53e6d3d7e7bfee6542ff71775dbed03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626884Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#663752}
-
Nico Weber authored
After clang r360674, each .obj file embeds the path to the profile library as a dependent lib. No intended behavior change. Change-Id: Ie892fccdb8aaefc2545db56fb3274dc6f0992a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630986Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#663751}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/71c012b1b956..51e9e5659a55 git log 71c012b1b956..51e9e5659a55 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 capn@google.com Implement Y′CbCr conversion 2019-05-28 capn@google.com Fix single-plane views of YCbCr formats 2019-05-28 capn@google.com Refactor writing texture level descriptor info 2019-05-28 capn@google.com Take the plane/aspect into account when copying/blitting 2019-05-28 capn@google.com Implement VkSamplerYcbcrConversion object 2019-05-28 capn@google.com Claim support for YCbCr 3- and 2-plane 420 format 2019-05-28 capn@google.com Allow additional info to be passed to object's Create functions 2019-05-28 capn@google.com Add 8-bit YCbCr 420 format info 2019-05-28 capn@google.com Refactor obtaining format aspect info 2019-05-28 capn@google.com Implement OpImageGather 2019-05-28 capn@google.com Refactor texel names 2019-05-28 capn@google.com Fix taking the sampling instruction type into account Created with: gclient setdep -r src/third_party/swiftshader@51e9e5659a55 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/132437008,chromium:b/132437008,chromium:b/132437008,chromium:b/132437008,chromium:b/132437008,chromium:b/132437008,chromium:b/132437008,chromium:b/116336664,chromium:b/132437008,chromium:b/132437008,chromium:b/129523279,chromium:b/129523279,chromium:b/129523279 TBR=swiftshader-team+autoroll@google.com Change-Id: I93e2f4c68994dfd5097f61ccfb3a85c0b7157f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632416Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b42d4c7a..68951d2c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5f552b17b8bfb7b0df5fec77e4428c2c51e51322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631733Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663749}
-
Eric Stevenson authored
Also added a note about a known issue that can cause build failures. Bug: 967618 Change-Id: Iebf4df4a15453e525653ee2052f61e84c0e169f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632299 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
-
Stepan Khapugin authored
When the DSE is Google, omnibox should use the bundled icon instead of the google favicon. Bug: 966389 Change-Id: I95d683a7bf1c3f460ec2d73ccd39d1b8fa305fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631697 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#663747}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c66b67119b9..15902f4c7d5d Created with: gclient setdep -r src-internal@15902f4c7d5d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I1094223b1dadbd3cb23e06b5c2a4a2ac4c6ed0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632417Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663746}
-
Tomasz Wiszkowski authored
Bug: 961158, 960421 Change-Id: I584060d95247b66e38fd6dfb765356ebf193664b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603684 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#663745}
-
Ivan Sandrk authored
Extending the histogram for another 6 months as the bug this was introduced for isn't fully fixed yet. Additionally, transferring ownership of the metric as both original owners switched to different projects. Bug: 960033 Change-Id: I732fceae598371ef6efffd6adb07ff748c21c529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631407Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Devices that had /data/local/tmp/ command-line flags file need to read from SharedPreferences from attachBaseContext(). This was causing all tests to fail when this file is present. Also improves failure message somewhat. Bug: 441859 Change-Id: Ifdf8f8f4117690ef6c739189d53f361dbe9b5626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631716 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Henrik Boström authored
In Unified Plan, iceConnectionState is calculated in the blink layer. In edge cases, there are differences between this state and the one calculated in third_party/webrtc. This CL makes sure the same state is exposed in chrome://webrtc-internals/ as the one exposed in JavaScript. For debugging purposes, this CL also exposes the old ("legacy") implementation of the iceConnectionState. This is not observable in JavaScript, but it will help us debug issues such as https://crbug.com/966798. Bug: 967451 Change-Id: I5793b648e7c98cfd0c0f3301b648dad00ba69823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632190Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#663742}
-
Moe Ahmadi authored
Adds histograms for page impressions and actions identical to Android's. Bug: 957688 Change-Id: I5985cca226c0ec15cdd67ed4dcf99a73a8876e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628031Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#663741}
-
Raphael Kubo da Costa authored
Since commit 4874fdef ("[blinkpy] Stop rebaselining on Android bots"), android_blink_rel is no longer part of the rebaselining bots used by wpt-importer. However, 'android' is still part of Port.CONFIGURATION_SPECIFIER_MACROS, which is passed as |specifier_macros| to simplify_specifiers(). And since Android is no longer covered by trybots, |versions| in that function ends up an empty set, which by definition means all its elements are in |specifiers|. In practice, this means that a test such as external/wpt/preload/onload-event.html, which was failing on some Mac bots, would cause simplify_specifiers() to return something like ['Android', 'Mac10.10'] and we would try to add repeated lines to TestExpectations that look like crbug.com/626703 [ Android ] foo [ Failure Timeout ] crbug.com/626703 [ Mac10.13 ] foo [ Failure Timeout ] crbug.com/626703 [ Android ] foo [ Failure Timeout ] crbug.com/626703 [ Mac10.12 ] foo [ Failure Timeout ] which fails our presubmit checks as expected. Fix it by not taking empty sets into consideration when looping. This unblocks WPT imports again. Bug: 567947 Change-Id: Ia471cad213192fa23425d5e8eecf47457605f9ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631663 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#663740}
-
Alex Oldemeier authored
This adds a feature flag to ensure that additional Crostini session status enterprise reporting is still disabled even when the policy for Crostini reporting is enabled (which is used for existing reporting). Test: compile Bug: 844468 Change-Id: Id9f25dc344cb804679312d6488964de23de9610b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631654 Auto-Submit: Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org> Cr-Commit-Position: refs/heads/master@{#663739}
-
Benoît Lizé authored
From the field trial (see https://bugs.chromium.org/p/chromium/issues/detail?id=758566#c71 for details), ordered prefetch improves startup performance significantly on low-end devices, and regresses it on high-end ones. As a consequence, enable only on low-memory. From the field trial, this is time to commit for cold starts: - Devices with >=2GB of RAM: Regression of 110ms (5.44%) at the median, 175ms (2.96%) @95th percentile - Devices with <=1.2GB of RAM: Improvement of 135ms (2.71%) at the median, 650ms (4.34%) at the 95th percentile Also removes the command-line switch and the synthetic field trial setting. As such, this is partially a revert of https://chromium-review.googlesource.com/c/chromium/src/+/1270936. Bug: 758566 Change-Id: I3a95f97bd5c9eda7840a107fa22b7d016a4a08c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631380Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Stephen McGruer authored
There is no point sending DeferredImages to cc until the PaintWorklet has been properly registered; it just requires cc to have null-checking logic. Instead, this CL adds support for off-thread PaintWorklet to CSSPaintImageGenerator::IsImageGeneratorReady and uses it to defer creating DeferredImages. Bug: 965632 Change-Id: I351bf85ee0eec1df4ac401de2c78a4e99a38ea03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622868Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#663737}
-
Kush Sinha authored
In the event of an account removal or token update, Chrome OS Account Manager sometimes revokes old tokens before informing its observers about the update. Sometimes this causes certain Chrome services to mark the current newly minted token as invalid and in other cases, it causes unnecessary error notifications. Fix this by making old token revocation as the last step of a token update and notify Account Manager's observers before revoking the old token. Bug: 952570 Test: chromeos_components_unittests --gtest_filter="*AccountManager*Test*" Change-Id: Idaf222417eecfd88cae77a7471cb9ee03b8c85b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631666 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#663736}
-
Sahel Sharify authored
This cl adds EVENT_COULD_NOT_SHOW to JourneyLogger::events_ and records the bit vector when payment sheet is not shown. This is because we still want to know value of other bits like EVENT_CAN_MAKE_PAYMENT_[TRUE|FALSE] or EVENT_REQUEST_METHOD_[BASIC_CARD|GOOGLE|OTHER]. Without this change on Desktop NotShown cases were recorded as aborted with JourneyLogger::ABORT_REASON_MOJO_CONNECTION_ERROR error, while on Android not recorded at all. Bug: 966150 Change-Id: Ifddfb68622b2d8eb67b8b687077836e863868ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626013Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#663735}
-
Nazerke authored
Currently, when the top suggestion is a suggestion from history (with URL), we show the favicon for that page in the popup. If the favicon doesn't exist, then the omnibox will use a fallback when it can't load the favicon, but the fallback will be the history icon, the icon for the suggestion, instead of the globe. Fixed: When omnibox suggestion is a history type, then the icon is fallback to the globe in this case. Bug: 966347 Change-Id: I9c8210b55c6818facf4034abbd20be3386da46ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625996 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#663734}
-
Leszek Swirski authored
Change-Id: I84340afa4357764155d92279aa53cef63db3d1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632237 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#663733}
-
Stephane Zermatten authored
This CL reports to the server the time it took to run each action, so we have more precise tracking of run time than what is currently visible from the server. Bug: b/129665463 Change-Id: I5aadded949479a1d324042b574deddb10cde4e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611689 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#663732}
-
Kush Sinha authored
In the event of a revocation of a token associated with a device id, Gaia revokes all tokens associated with that device id, including the ones that may have been issued only recently. This is a bug for Device Account token updates in Chrome OS Account Manager. If the user ends up at the online Gaia re-auth screen, revoking the old Device Account token invalidates the current, newly minted token too, causing the user to be re-directed to online Gaia auth at next login and the cycle keeps repeating. Please check the attached bugs for context. Fix this by skipping token revocation for Device Accounts. Gaia has a clean up cron that clears up old, unused tokens attached to a device id. Bug: 952570, 865189 Test: chromeos_components_unittests --gtest_filter="*AccountManager*Test*" Change-Id: I631d14c2d6cc65fbd5f57576cbf2787513efedaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631278Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#663731}
-
Polina Bondarenko authored
Content-Type header is not changed if request_body is not empty in WilcoDtcSupportdWebRequestService::PerformRequest BUG=b:133733514 TEST=unit_tests Change-Id: I6ab7ff53a69396007993173fd85acf2e35a83504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631695Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/213aa46af167..cf49b6472020 git log 213aa46af167..cf49b6472020 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 bsalomon@google.com Define SK_GL in Flutter. Created with: gclient setdep -r src/third_party/skia@cf49b6472020 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I138d0046085ef736e4637583aaf68b665a4c0525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632410Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f2e9cab3835c..9ab520e24bb9 git log f2e9cab3835c..9ab520e24bb9 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 minyue@webrtc.org Reland "Avoid encrypting empty audio packet." 2019-05-28 ilnik@webrtc.org Use ';' to escape '/' characters in path to dumped received video stream 2019-05-28 sprang@webrtc.org Add field trial for selecting potentially useful packets as padding. 2019-05-28 hta@webrtc.org Deprecate functions returning cricket::DataContentDescription. Created with: gclient setdep -r src/third_party/webrtc@9ab520e24bb9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/132861665,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7736a8e50a5186e69fa407b77f8b6ae5114a5144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632413Reviewed-by:
-
Jordan Demeulenaere authored
- Before: https://screenshot.googleplex.com/LG9DBrd21We.png - After: https://screenshot.googleplex.com/uONtfqZx37R.png Screenshots: Change-Id: I25ddcef07fbe74a0a7f42d897b788f06ba752a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631696Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#663727}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/26af0d34d281..778c7f117aee git log 26af0d34d281..778c7f117aee --date=short --no-merges --format='%ad %ae %s' 2019-05-28 iannucci@chromium.org Make tryserver API only update the presentation of its own steps. Created with: gclient setdep -r src/third_party/depot_tools@778c7f117aee The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:910369 TBR=agable@chromium.org Change-Id: I72c7bd662cad0470cddbbc9eaaf73a35bee5ccdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632411Reviewed-by:
-
Ludovico de Nittis authored
//src/dri.c needs to be included in the minigbm build because it is required when using the "use_amdgpu_minigbm" flag. Bug: 967346 Change-Id: I5dc1407eecacc96d49cde4e793b40dc9e766ae75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631382 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#663725}
-
Jonathan Backer authored
Removing the lightweight ref will call ~gles2::Texture, if there are no outstanding gles2::TextureRef. What happens in certain viz_unittests when running with Vulkan is the following. 1) ~InProcessCommandBuffer releases the current GLContext. 2) SkiaOutputSurfaceImplOnGpu::ReleaseSkImages releases an ExternalVkImageBacking. This may call ~gles2::Texture with no GL context current, which causes a crash. More video tests pass with this change (e.g. out/release/viz_unittests --enable-vulkan --use-gpu-in-tests --gtest_filter="VideoRendererPixelTest/1.FullyTransparentYUVARect") Bug: 960797 Change-Id: Ice8c85a5cb4c63b8b45c8fa7fc27adccba90a5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631730Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#663724}
-
Moe Ahmadi authored
Makes TableViewTextItem adjust its font size for Dynamic Type Bug: 957688 Change-Id: Id3522bb1419ba2c7036481fb6cc90015f346c348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630973Reviewed-by:
-
Lukasz Suder authored
Whole traffic will be divided by the experiment_id it belongs to. The experiment_id comes from the caller (GWS) and is available within intent. For traffic outside of GWS there will be no experiment_id. Registering Synthetic groups: cr/249817984 Bug: 806868 Bug: b/133124492 Change-Id: I9b1cccf10b6d442966c2f60ee34870a6e3d9686e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630480Reviewed-by:
-
