- 26 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4af595189fe3..1c105ca31096 git log 4af595189fe3..1c105ca31096 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 szuend@chromium.org Prepare TimelineUIUtils.js for asynchronous source mapping 2020-02-26 pfaffe@chromium.org Fix can-format-sourcecode test: await proper indicator 2020-02-26 aerotwist@chromium.org [e2e] Add user metrics tests 2020-02-26 aerotwist@chromium.org [screenshot] Updates server encoding Created with: gclient setdep -r src/third_party/devtools-frontend/src@1c105ca31096 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032016,chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6f74cda8dddb227c3b1e6749a47545e75537f6e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073778Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744612}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/651a1d860c99..9b1b5d932a2a git log 651a1d860c99..9b1b5d932a2a --date=short --first-parent --format='%ad %ae %s' 2020-02-26 hjd@google.com Merge "CTS: Increase timeouts to 5s" Created with: gclient setdep -r src/third_party/perfetto@9b1b5d932a2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I32ab09d5a6ed99fc6e88d761270efcf811d69755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073780Reviewed-by:
-
Jose Lopes authored
The MojoSharedBufferDoneCB callback is a once callback because it's executed only once during the class's constructor: * https://cs.chromium.org/chromium/src/media/mojo/common/mojo_shared_buffer_video_frame.cc?rcl=8184a68c47988fb128372c9c688f77455dfcb5db&l=250 This is also documented in its definition: * https://cs.chromium.org/chromium/src/media/mojo/common/mojo_shared_buffer_video_frame.cc?rcl=8184a68c47988fb128372c9c688f77455dfcb5db&l=250 The callback is passed in the TransformToVideoFrame method, in: * https://cs.chromium.org/chromium/src/media/mojo/common/mojo_shared_buffer_video_frame.cc?rcl=8184a68c47988fb128372c9c688f77455dfcb5db&l=250 and this method can only be called once. The evidence of the following statements: * DCHECK(FrameBuffer()): https://cs.chromium.org/chromium/src/media/mojo/services/mojo_cdm_allocator.cc?rcl=8184a68c47988fb128372c9c688f77455dfcb5db&l=116 * SetFrameBuffer(nullptr): https://cs.chromium.org/chromium/src/media/mojo/services/mojo_cdm_allocator.cc?rcl=8184a68c47988fb128372c9c688f77455dfcb5db&l=116 Together these guarantee that the method can only be called once. This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Ib4dff4d9c491682b8abd134723ef88bcf5252bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069540 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#744610}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Mac. (The [2] CL enabled it earlier for Windows, Linux, and ChromeOS.) In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/2063530 [2] http://crrev.com/c/1967608 Bug: 1053725 Change-Id: If59ce711ad8baadc4089ec99bdac3510a3e67b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071581 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#744609}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5a7f01b6. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 6532b4a4 "WPT: Remove XMLDocument#load test from html/.../query-encoding/" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I28c8a6d9a106866e5aa05d74856a8a01ab1dce8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073677Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744608}
-
Nohemi Fernandez authored
This patch adds the authentication flow required to cancel a sign-in operation following a click on the 'Cancel' button in the 'Turn on Sync?' page. This CL is part of a series of refactors to move the existing sign-in architecture to the Coordinator-Mediator design paradigm. Fore more information, see go/chrome-ios-signin-migration. Bug: 971989 Change-Id: I72e8bf3c8fc15338d419dc2d3a888eecc430b807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067076 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#744607}
-
Rune Lillesveen authored
We were not checking dirty flags for pseudo elements in AssertLayoutTreeUpdated. Change-Id: Icad8f8fabd45bdb973258c4da9ada440b6952e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073878Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#744606}
-
Mugdha Lakhani authored
This also moves strings from chrome/app/generated_resources.grd to components/components_strings.grd. Bug: 1052375 Change-Id: If11c8922c9faa7e8470744d329b838b528b7c460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062418Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#744605}
-
Renato Silva authored
This is a reland of 8411cc66 Original change's description: > OOBE - Improve reset screen confirmation dialog > > - Replace the dialog on the reset screen with the oobe-help-dialog > that complies with UX specs and reuses available code. > > - Refactor the confirmation dialog logic so that it lives in the > main element 'oobe-reset'. > > - Remove the intermediate oobe_reset_screen by using LoginScreenBehavior > > - Add a waiter to test::OobeJS for waiting upon the presence of an > attribute. Such as waiting on the 'open' attribute of dialogs. > > - Add constants and modifications to the browser tests of the reset > screen. > > Fixed: 933310 > Change-Id: I54001745326b60ab5a0a19519923c54dffa5baec > Bug: 933310 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041474 > Commit-Queue: Renato Silva <rrsilva@google.com> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Auto-Submit: Renato Silva <rrsilva@google.com> > Cr-Commit-Position: refs/heads/master@{#744288} Bug: 933310 Change-Id: I12aca96e98373beda746fc92f3d06cb6d1e86c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072383 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744604}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33b4927e0d74..4db5c0713efc Created with: gclient setdep -r src-internal@4db5c0713efc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ibf1f318caafd8ef2aeb689b66dcb6123ff0de98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073611Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744603}
-
Javier Ernesto Flores Robles authored
Bug: 1052505 Change-Id: Icef96c97f24aecf5eb17dddc24d7d73d1878355f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062973 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#744602}
-
sandromaggi authored
This test has been missing. It's the sibling of the same test for creating a contact. Bug: none Change-Id: I1a7fc847f24ded1148e49b302b2851dbd383b71d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071263 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#744601}
-
Kent Tamura authored
- Move HTMLFormControlElementWithState::TypeShouldForceLegacyLayout() to HTMLSelectElement and HTMLTextAreaElement Another subclass, HTMLInputElement, already has it. - Change the default value of InputTypeView::TypeShouldForceLegacyLayout from |true| to |false| Remove TypeShouldForceLegacyLayout() of InputTypeView subclasses returning |false| Add TypeShouldForceLegacyLayout() of InputTypeView subclasses so that it returns |true|. This CL has no behavior changes. Bug: 1040826 Change-Id: If307fcd1b15adfc84bf5a2786bec0569e33827a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073183 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#744600}
-
Maksim Ivanov authored
Make the error handling more sane in the test certificateProvider extension (which is, roughly speaking, used for simulating a smart card driver with a fake smart card in browser tests). Specifically: * In the case the chrome.certificateProvider.requestPin() call from the extension returns an empty result (=="cancellation"): * after the CL: a warning is logged and the crypto operation is aborted; * before the CL: a new PIN request was made (because we were misinterpreting at as an incorrect PIN error). * In the case the requestPin() call fails with a chrome.runtime.lastError error: * after the CL: a warning is logged, with the contents of |lastError|, and the crypto operation is aborted; * before the CL: JS error is raised, due to not checking the state of |lastError|, and a new PIN request was made. This should make the test extension closer to the behavior of real smart card drivers, and also simplify debugging of test flakiness. Bug: 1033936 Change-Id: Id035fa8366cce4a3ff9c404bac8169bd146fefd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072381 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#744599}
-
Victor Costan authored
The feature gated by BlobReadMethods has launched in Chrome 76. At this point, it's safe to assume the feature will remain launched. https://chromestatus.com/feature/6206980857266176 Change-Id: Ibdd53ffda2553495985f6062c86c46336ea88a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073468 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#744598}
-
Victor Costan authored
The features gated by AsyncClipboard have launched in Chrome 66 and Chrome 76. At this point, it's safe to assume the features will remain launched. Relevant chromestatus entries: https://chromestatus.com/feature/5861289330999296 https://chromestatus.com/feature/5074658793619456 Change-Id: I5041570cea17385e72fc40c01b6dab26f69b4a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073467 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4a9ec2ef6f2a..908dc2208b7c git log 4a9ec2ef6f2a..908dc2208b7c --date=short --first-parent --format='%ad %ae %s' 2020-02-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src a09ab94aa920..3f4d08da8897 (2 commits) Created with: gclient setdep -r src/third_party/angle@908dc2208b7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I428dd56a524f19966e84ec9f50038be539169e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073609Reviewed-by:
-
Anastasiia Nikolaienko authored
Bug: 1006341 Change-Id: I24886a69ec50d0c1bd464575cdf70e1f36dc4aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071265Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#744595}
-
Anastasiia Nikolaienko authored
Append email to query parameters so it's getting pre-filled on the login page. Bug: 1043108 Change-Id: Ica6284bc525ae9be9498c24cb5756b075c14b2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070202Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/54f0b120..6736f968 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I23ff7486e0a6fd83305184051989c97875b4e766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073619Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744593}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4e52bbdf7162..4af595189fe3 git log 4e52bbdf7162..4af595189fe3 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 gabriel.luong@gmail.com Typecheck common/QueryParamHandler.js with TypeScript 2020-02-26 gabriel.luong@gmail.com Typecheck common/App.js with TypeScript Created with: gclient setdep -r src/third_party/devtools-frontend/src@4af595189fe3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie28885bf326aea8ede1747a9c8cc29aee76e8645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073610Reviewed-by:
-
Victor Costan authored
The feature gated by StorageQuotaDetails has launched in Chrome 75. At this point, it's safe to assume the feature will remain launched. https://chromestatus.com/feature/5737131066523648 Change-Id: I3aa6b14a5b53ef07df73c43b923f1c77d89dcdb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072822 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Nazerke authored
ios_chrome_settings_eg2tests_module. This CL moves GoogleServicesSettings EarlGrey2 tests from ios_chrome_ui_eg2tests_module to ios_chrome_ui_eg2tests_module as previously GoogleServicesSettings EarlGrey (1.0) tests were in ios_chrome_settings_egtests_module. Change-Id: Ic0957d45ab985589598c03a2bd1355b1d846e70c Bug: 1053737. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064910Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#744590}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<IDBCursorWithValue> and DynamicTo<IDBCursorWithValue> as new downcast helper 2. Use IsA<IDBCursorWithValue>(element) in place of IsIDBCursorWithValue(element) Bug: 891908 Change-Id: I495cfb89dabb4242f86fcbe62cf295afcf1eda10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019646Reviewed-by:
-
Mason Freed authored
See the CSS Resolution [1], the I2R [2], and the chromestatus entry [3]. [1] https://github.com/WICG/construct-stylesheets/issues/119#issuecomment-588352418 [2] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/RKG8oxp22RY [3] https://chromestatus.com/feature/4735925877735424 Bug: 1055943 Change-Id: I0f71af0d3dae5001a9ba93d1b5e41a859be6481f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073204 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#744588}
-
David Roger authored
The remaining uses of diceEnabled are replaced by signinAllowed. Since diceEnabled used to be available at load time, signin allowed is moved to load time data as well. This is possible because the kSigninAllowed preference can only change at startup. Fixed: 891781 Change-Id: Ibac21acb09c6f0c98297a043f64584c02cb654a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044172Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#744587}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/227568451b44..2f0f850da8aa git log 227568451b44..2f0f850da8aa --date=short --first-parent --format='%ad %ae %s' 2020-02-26 enga@chromium.org Add Toggle to disable sampler compare function on Metal. Created with: gclient setdep -r src/third_party/dawn@2f0f850da8aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ia89ce41536dd08ace27b95387c0bb554e9a0b0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073606Reviewed-by:
-
Side Yilmaz authored
DataReductionPreferenceFragment. |Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates DataReductionPreferenceFragment class. Since settings is considered as always running on regular mode, it is safe to use regular profile even called in incognito mode. For this reason, there is no need to make change on code behavior to act differently for each profile. Therefore, it is safe to leave behavior as-is today. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I0585683c1d6d844b2749e36095d941f02f19d237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066908Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#744585}
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is depreciated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates WebContentsFactory class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I78995577933aba3cf06e3720ae5ccd0d7b77851f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069322Reviewed-by:
-
Makoto Shimazu authored
ServiceWorkerImportedScriptsUpdateCheck is now enabled by default. Previously the browser had a branch based on the feature flag when starting a new service worker for update, but now the branch is not needed. This CL removes the branch and removes tests assuming ServiceWorkerNewScriptLoader may do an update check. Bug: 999907 Change-Id: I7360ee7bea01f8a8cc389129cb2e8d35d413a609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061635 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#744583}
-
Yutaka Hirano authored
Bug: 1056096 Change-Id: Ie4057f5584cf017cc4a6f2933cc289160530b1f4 Tbr: peter@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072485Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#744582}
-
Alice Wang authored
This CL adds bookmark loading in bookmark signin promo dismiss tests to reduce its random flakiness. Bug: 1045480 Change-Id: Ied531522a06e45ada3674ddfe6be987f5f5855c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031038 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
Rushan Suleymanov authored
Empty or duplicate storage keys may cause crash in some cases. More strict checks could help to understand user reports better. This patch also introduces UMA to find out the reason of DCHECK violation which may happen in ExpireAllEntities for AUTOFILL_WALLET data type. Bug: 1045641 Change-Id: I5abf4a1342c71b883c42fa6c09f34671d11d1227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064999Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#744580}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/98a160373b23..33b4927e0d74 Created with: gclient setdep -r src-internal@33b4927e0d74 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I95cb08ce6407ad0d77f0779ba001180f479ef5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073599Reviewed-by:
-
Hirokazu Honda authored
PSNR and SSIM are popular image quality estimations. This CL adds functions to compute PSNR and SSIM using libyuv. Bug: 1044452 Test: None Change-Id: Ied55ad80b005fce274b66faaf2f395027353ec9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023714 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#744578}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/03a8e2e30f01..4e52bbdf7162 git log 03a8e2e30f01..4e52bbdf7162 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 szuend@chromium.org Prepare CompilerScriptMapping.js for asynchronous live locations Created with: gclient setdep -r src/third_party/devtools-frontend/src@4e52bbdf7162 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032016 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I35a27d0b1dd9a70f73bbe3b69db71ef244e8172d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073600Reviewed-by:
-
Olivier Robin authored
Bug: 1047236, 1046998 Change-Id: Ib9d6812d50e0fc55739f3a866cbf79e4f44786c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072159Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744576}
-
Jérôme Lebel authored
Adding a EG test to make sure the import data view controller is fully presented before to interrupt the sign-in. The sign-in might be interrupted while the view is not yet presented or while being animated. Change-Id: Ic61ea3beb846810645ef5f19d7d130cd39f01353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072041Reviewed-by:
-
Colin Blundell authored
The one place that Tab is referenced in ExternalNavigationDelegate it is not actually used. Remove it from this interface in order to aid in ExternalNavigationDelegate's componentization for sharing with WebLayer. Bug: 1031465 Change-Id: Ib744f050ea358fdb956f4d41a871fbe488156a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072239 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#744574}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/57083a22..54f0b120 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2e3dcd102409fbef7461667d8d4694db9f043b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071959Reviewed-by:
-
