GitLab

More work to remove GLInterface from the shared GPU context on the main
thread. This updates CopyRenderingResultsFromDrawingBuffer to use the
CopySubTexture API on RasterInterface.

Bug: 1023252
Change-Id: I2bbc047362fa38bce5a6f698710acdaad95bfadf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960184Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#727003}

Currently we check if the keyboard has the 'Assistant' key to enable
Assistant. It seems some external wireless keyboards report they do
have the 'Assistant' key.

Since the reason we were checking the keyboard is for nocturne, we
decide to only special case board 'eve', 'nocturne' and 'atlas' instead
of doing the keyboard layout check.

For more background, see discussion in crbug/1025961

Bug: 1025961
Test: Manual Test
Change-Id: Iacb42a6b8bfc01b662002f0d93258642b6976ca0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978838
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727002}

https://chromium.googlesource.com/external/github.com/material-foundation/material-font-disk-loader-ios/+log/93acc021e303..8e30188777b0

git log 93acc021e303..8e30188777b0 --date=short --first-parent --format='%ad %ae %s'
2017-02-17 willlarche@users.noreply.github.com [Docs] Clarity in README (#1)

Created with:
  gclient setdep -r src/ios/third_party/material_font_disk_loader_ios/src@8e30188777b0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/material-font-disk-loader-ios-chromium
Please CC bling-p10-rolls@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc
Bug: None
Tbr: bling-p10-rolls@google.com
Change-Id: I63b7292b633762c3dcbab53498e9cc99bd0ba569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979151Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#727001}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1e430429c148..254ce3f8dfb0

git log 1e430429c148..254ce3f8dfb0 --date=short --first-parent --format='%ad %ae %s'
2019-12-20 comoody@microsoft.com Add undefined check in contentAsDataUrl to prevent unhandled exceptions
2019-12-20 tmathmeyer@chromium.org Redesign Media properties view

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@254ce3f8dfb0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:794255
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I048c9e34393e50ace6600a892333f2268b3d27b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979419Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#727000}

TBR=scheib@chromium.org

Change-Id: I2b665cc24dea17e3b585df1f925262121f577b98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978915Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726999}

Remove manage input section from the browser settings resources and
move the files to the OS settings.

Bug: 990139
Change-Id: I5feac5828b964ee51afae48f6064ae41169ffc76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977840
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726998}

Address zmo's comments on the earlier change:
https://chromium-review.googlesource.com/1885636
which were published after the CL landed.

Bug: 681341
Change-Id: Ib89967cc4f6b7f11371e7694689445d8afc34883
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977739
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726997}

This reverts commit 24eca4b9.

Reason for revert: Crashing Tot

Original change's description:
> Reparent the current Tab when the theme is changed
>
> * Creating a class which handles reparenting the current tab when the
>   theme is swapped.
> * Hooking that class into ChromeActivity.
> * Adding plumbing to a few ReparentingTask/TabReparentingParams to
>   facilitate the process.
>
> Bug: 944302
> Change-Id: I2801eba979b3acafa02856a9053bc474bf2f581c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931763
> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
> Commit-Queue: Brandon Wylie <wylieb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#726136}

TBR=fgorski@chromium.org,yusufo@chromium.org,wylieb@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 944302
Change-Id: If032ff5e4cf61f4047e4cf146c8ae6a03a78aa77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979398Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726996}

Instead of going through mojom::blink::FileUtilitiesHost and passing a path
from the renderer back to the browser, add a new method to mojom::blink::Blob
to do the same thing. Since the blob already knows what file a blob is
referencing, this both makes things slightly more secure (or at least gets
us closer to a place where we can get rid of things like
ChildProcessSecurityPolicyImpl::CanReadFile) and makes this
work in a couple more cases after a File is for example postMessaged to a
worker or frame in a different process as well.

Additionally this gets us closer to unifying what the renderer and browser
processes consider to be "the" snapshot state of any particular blob. In
a follow-up CL the browser side code will change to return its snapshot
state (if any), rather than always returning the current state on disk.

This is part of a series of changes to improve consistency surrounding how
snapshot state of files/blobs is implemented.

Bug: 844874
Change-Id: Ia05cfd21a3d78955ff70933995e93bbe59e3bb3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970301
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726995}

If the frame count of an image decreases after appending more data to
it, the image is assumed to be broken. Avoid painting such images. This
can result in fatal errors in the downstream code.

And also miscellaneous cleanups.

R=pdr@chromium.org

Bug: 867479
Change-Id: I90b5c7030f80076fdc44beb88910667c6182cb8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972904
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726994}

This CL completes the basic implementation of the flags UI. During
startup, the embedded WebView implementation will check if the user has
enabled developer mode, and if so, fetch the flag overrides from the
service.

This uses a ContentProvider instead of an aidl method on the service
interface for the sake of a simple synchronous IPC. Although aidl itself
supports synchronous IPC, the Android framework only supports binding to
the service asynchronously. We require fully synchronous IPC so we can
block startup while we fetch the flags.

Now that we've settled on using a ContentProvider to plumb information
from the developer UI to embedded WebViews, this changes "developer
mode" to be defined by the ContentProvider's state rather than the
Service's state, which has the side benefit of simplifying some of the
Activity/Service code.

We rely on PackageManager APIs to check if developer mode is enabled.
The check itself should have very little impact to startup time, since
PackageManager caches its state in RAM. I benchmarked this check (when
developer mode is disabled) at 0ms on my Google Pixel 2 device. For
simplicity, we do not care about performance when developer mode is
enabled, as this is not the usual user experience.

Bug: 981143
Test: Manual - toggle debug border flag, start WebView shell, see borders
Test: Benchmark isDeveloperModeEnabled() with System.currentTimeMillis()
Test: run_android_webview_junit_tests -f *ServiceNamesTest*
Change-Id: I7cc67d1bdf8f0f2ce0fce714fb359160899354a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977828
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726993}

https://chromium.googlesource.com/openscreen/+log/2c5e3d4c9d60..8b5e9a4830ef

$ git log 2c5e3d4c9..8b5e9a483 --date=short --no-merges --format='%ad %ae %s'
2019-12-20 jophba Fix build issues in Chrome causing unit tests build to fail
2019-12-18 rwkeane mDNS: Add Known Answer Suppression to Querier
2019-12-20 rwkeane mDNS: Responder Known Answer Suppression
2019-12-19 btolsch Clear fqdn in mDNSResponder setup

Created with:
  roll-dep src/third_party/openscreen/src

TBR=mfoltz@chromium.org

Change-Id: Ic815d00d8e490271c395b9caaba56e454471fa25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978845Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726992}

These histograms were recorded under the incorrect name:
  Permissions.Prompt.Disposition.*

Bug: 986737, 1036520
Change-Id: I6d27725257bbc96d1b18ec20c67d7e28533b6ac4
TBR: andypaicu@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978692
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726991}

Previously, they could be invoked directly by load events (which would
sometimes force layout first, and sometimes not). This is
problematic because layout may not be clean, and forcing layout
is not straightforward or desirable in these cases.

Now the fragment anchors can only be invoked during the main lifecycle
or a forced layout (*), and in both cases after layout is done. In order
to make sure that one of these occurs during page load, queue an
animation frame after finishing load of the document (this is where
previously it would have synchronously invoked the fragment anchor),
or setting a fragment anchor.

(*) We still need fragment anchors to be invoked by forced layouts,
because script is allowed to change anchors and read back their results
synchronously, and this is necessary for web compatibility.

Bug: 1018632

Change-Id: I6121962e12e50913a58a80330a3b5de96fef5f4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935508
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726990}

This will allow to replace ".is_dict()" or ".is_none()" checks to ".has_value()"
checks.

Bug: 949269
Change-Id: I5cfd37515cdbed4f765b80bfc213877a2458d0db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972948
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726989}

This is a reland of 7511f14a

Original change's description:
> Remove animator implementations from UiElementContainerView.
>
> This is part of a multi-CL effort to clean up the Assistant UI element
> modeling/rendering pipeline. This CL simply moves the ElementAnimator
> implementations that were previously in UiElementContaienrView into
> AssistantUiElement. In the future, UiElementContainerView will have no
> concept of AssistantTextElementView or AssistantCardElementView, it
> will only understand AssistantUiElementView.
>
> More details of the effort in the bug.
>
> Bug: b:145003512
> Change-Id: I0228556d5837f5466ca8fd5f9fc59c6ffd1239a3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954666
> Commit-Queue: David Black <dmblack@google.com>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#726636}

Bug: b:145003512
Change-Id: I833ca7d8c4713a1d13f4db6ba36911fd486f1ac2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979401Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#726988}

Bug: 964919
Change-Id: I2122c17fac16f0ba01995402cf4a00fca15a31a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978010Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726987}

This CL updates the New Tab button to have fixed positioning. This
CL also updates the scroll animation so that it takes the edge of
the New Tab button as the right-most boundary, instead of the
edge of the viewport.

Bug: 1032650
Change-Id: If656545b5d4b4a50197a5f0d94baeb26b6f7df09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977841Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726986}

Re-enabled the mark.html and ins.html
DumpAccessibilityTreeTest's on Android platform with updated
expected output.

Bug: 413531
Change-Id: I52fbe1c3ec05be2507eaeab6ffd680bbbeccdecf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979352
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Auto-Submit: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/master@{#726985}

Updates the "Long-press Resolves" Feature to only have one experiment
arm.  We had a few others, but when talking with privacy it became
pretty clear that we only need one.

BUG=956277

Change-Id: I7404fd87656f144b36e44671a17f03546979fb7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971226
Auto-Submit: Donn Denman <donnd@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726984}

This CL gets rid of the classes WebScopedUserGesture (WSUG) and
WebUserGestureIndicator (WUGI), by introducing the following new methods
on WebLocalFrame:
- NotifyUserActivation for WSUG ctor,
- HasStickyUserActivation for WUGI::IsProcessingUserGestureSinceLoad,
- HasTransientUserActivation for WUGI::IsProcessingUserGesture, and
- ConsumeTransientUserActivation for WUGI::ConsumeUserGesture.

Other related changes done here are:
- rename {Frame,FrameTreeNode}::HasBeenActivated() to
  HasStickyUserActivationrelated for consistent names across the board,
- rename Frame::ClearActivation to ClearUserActivation for overall
  clarity,
- move LocalFrame::HasTransientUserActivation() to Frame hide the state
  from subclasses.

  dvadym@chromium.org, jbroman@chromium.org, rdevlin.cronin@chromium.org

Bug: 959850
Change-Id: I8f38bfd1a219e952225de533a53ddf9caf0e994c
TBR: alexmos@chromium.org, chcunningham@chromium.org, dcheng@chromium.org,
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968967
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726983}

Show the existing browser sync consent dialog when the first browser
window opens. Long-term we will add a first-run "welcome" WebUI,
which will instantiate the helper. For now this unblocks development
on other browser sync settings UI.

Basically, the parts that observe the browser list are speculative,
everything else we will probably keep.

Screenshot: http://screen/CLjXCGd5SQn

Bug: 1013466
Test: added to unit_tests
Change-Id: I8510527b692daf42e3a87e40f4fc5ca36c7f8993
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930946Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726982}

This CL moves SyncAndServicesPreferencesTest#waitForActivityState() to
ApplicationTestUtils where it can be shared with WebApkActivityTest,
BookmarkTest and ApplicationTestUtils#finishActivity()

BUG=1015449

Change-Id: I929b308722e8c575ca8dcf5e82a33ace4afa6200
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977742Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726981}

We had a number of different test SharedImageBackings. Centralize these
in one file.

Bug: 1003686
Change-Id: I09897394248a4aa560dffb84ce96f459db8d6821
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974605
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726980}

This reverts commit dd88bcce.

Reason for revert: There was a bug in the CL, that I can only fix after my vacation.

Original change's description:
> [webgl] Introduce ExtraceDataLengthIfValid helper function
> 
> As discussed in https://crrev.com/c/1970172, this CL introduces a helper
> function to check the size of an ArrayBuffer and creates an error if it
> exceeds the maximum supported size.
> 
> R=​kbr@chromium.org
> 
> Bug: chromium:1008840
> Change-Id: If8eaa8686f9f787484e094e78deaf741cdc436d8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972145
> Commit-Queue: Andreas Haas <ahaas@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#726341}

TBR=kbr@chromium.org,ahaas@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:1008840
Change-Id: Ic1a96bd8266a898f9f840cb26c55cfacd368af97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978691Reviewed-by: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726979}

Some followup mentioned in https://crrev.com/c/1829245.

Bug: 1033715
Change-Id: Ic4f1641f9c6f8db0e051788249eee701ea86e791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966246Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#726978}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e10a22d68021..16caad77d2b7


Created with:
  gclient setdep -r src-internal@16caad77d2b7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1024586,chromium:1028270,chromium:1033098
Tbr: jbudorick@google.com
Change-Id: I257efee9a5cd5340a8b1492eb38bcc2796d6c2a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979329Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726977}

g_browser_process->GetApplicationLocale() should be used over
l10n_util::GetApplicationLocale(std::string()).

Bug: 1036000
Change-Id: I5ff962526868ddbcbd3f2ac8b095ac99247c396e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978009
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726976}

Test: None
Bug: chromium:893332
Change-Id: I54730c17b01c5f0af64ee22a6aa60827a1a5674f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979367
Auto-Submit: Victor Hsieh <victorhsieh@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Victor Hsieh <victorhsieh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726975}

The analysis and stack trace are in the filed bug.

Bug: 1035593
Change-Id: Ia9d81f872cb27d19ce34a3c1c5e381fc05311dba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974618Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Callum May <camay@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#726974}

Bug: 546640
Change-Id: I9149fdcfba9140a3c6665e058b8439db3d6fa2c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978039
Commit-Queue: Oliver Li <olivierli@chromium.org>
Auto-Submit: Oliver Li <olivierli@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726973}

Craete feature flags for homepage UI conversion.

Bug: 1036470
Change-Id: I1ff3b9d99d2718b3220fa602188060bb11612e2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979326
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Auto-Submit: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726972}

Restricts the TestTapALot test to < Android Pie and later.

BUG=1036414

Change-Id: Ida7f3cf38c6147a32b3a04ee6d57527a503a5a5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978837
Auto-Submit: Donn Denman <donnd@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726971}

The functionality of GetSplitviewBoundsMaintainingAspectRatio is only
intended for tablet mode, but before the present CL, it also operates in
clamshell mode. Like almost all code that is specific to tablet mode, it
assumes that there is only one root window (see the header comment on
SplitViewController::Get). This assumption causes blatantly broken
behavior in clamshell mode.

Fixed: 1035186
Change-Id: Ic7f97aaa1a13973e7c3b7bfbee22b41f14597acb
Bug: 1035186
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978840
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726970}

The corresponding to patch to apply the workaround in skia is:
https://skia-review.googlesource.com/c/skia/+/261211

R=ericrk@chromium.org

Bug: 1027981
Change-Id: I1b1cbdd39ebacaf8fe4e1cf61438bbec5306ad39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977697
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726969}

https://skia.googlesource.com/skia.git/+log/c15afe488bfa..28b0c5d4b3bb

git log c15afe488bfa..28b0c5d4b3bb --date=short --first-parent --format='%ad %ae %s'
2019-12-20 michaelludwig@google.com Pass Arenas* to GrOpsTask and GrOps instead of multiple pointers to each pool type
2019-12-20 csmartdalton@google.com Shorten argument lists in GrMesh::SendToGpuImpl
2019-12-20 reed@google.com move clip-stencil function into GpuDevice

Created with:
  gclient setdep -r src/third_party/skia@28b0c5d4b3bb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC borenet@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: borenet@google.com
Change-Id: Ia8ef4a6a9bb4f3e6e29e6313843958ad5e67e760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979152Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726968}

The DictationButtonTray is updating its visibility in the constructor, which
causes a crash now that we have more complicated visibility logic. Instead move
the visibility update to the Initialize() function.

TEST=manually verified on device
BUG=1036052

Change-Id: I887a47ac2a655994b99d438df1b644d8fe75fd98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976857Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726967}

TBR=bsheedy@chromium.org

Bug: dawn:311, chromium:1035957, chromium:1035590
Change-Id: I873c927beab701ced22ada0babf19b1e60aead28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977736Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726966}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e730e5b1a28a..1e430429c148

git log e730e5b1a28a..1e430429c148 --date=short --first-parent --format='%ad %ae %s'
2019-12-20 jalyn@microsoft.com Prevent unhandled exception in ObjectPropertyTreeElement

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@1e430429c148

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1017953
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I3f0a5b6e875e751994fe970e6275f63d9d2db7fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979237Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726965}

Before this change, for ordered set item that exposes hierarchical
level and when it has attribute |aria-setsize="-1"|, we intended on
setting the set size to UNKNOWN(-1), but we end up setting the set size
to be the max of number of elements in the set, largest assigned set
size, and set container's size, which we term 'max_set_size_value'
here.

This change fixes the above issue and returns UNKNOWN size -1 rather
than 'max_set_size_value' when |aria-setsize="-1"| according to
WAI-ARIA spec on |aria-setsize|:
https://www.w3.org/TR/wai-aria-1.1/#aria-setsize

Note: WAI-ARIA spec does not explicitly specify that UNKNOWN set size
to be returned when |aria-setsize="-1"| only for items that expose
hierarchical level, such as tree item and list item.
The spec seems to indicate |aria-setsize="-1"| would return UNKNOWN
set size for all items rather than 'max_set_size_value'.
The current practice which supports |aria-setsize| to override
'max_set_size_value' only for items that expose hierarchical level
seems to make practical sense rather adhering to the spec, such as for
scenario of flattened tree item structure (CL:1461539).

This change includes:
1. Fix in AXTree::ComputeSetSizePosInSetAndCache to properly assign
   |AXTree::ordered_set_info_map_[item].set_size| when item exposes
   hierarchical level, such as tree item and list item.
   (Parent CL:1928639 exposes hierarchical level for list item).
   This enables |aria-setsize="-1"| UNKNOWN set size to properly
   propagate to accessibility APIs.

2. AXNode::GetSetSize() to return base::nullopt if calculated set size
   from #1 is UNKNOWN (i.e. set size is -1)

3. Fix for AxPlatformNodeWin::GetPropertyValue(UIA_SizeOfSetPropertyId)
   to return default value of 0 for unknown setsize.
   UIA spec, UIA_SizeOfSetPropertyId:
   https://docs.microsoft.com/en-us/windows/win32/winauto/uiauto-automation-element-propids
-------------------------------------------
Motivation behind this change:
Consider the following case, which is used by Microsoft Word Online,
which represents a flat list with list items:
 1. item1
 2. item2
 3. item3
--------------
<div role="list">
  <div role="listitem" aria-setsize="-1" aria-posinset="1">item1</div>
</div>

<div role="list">
  <div role="listitem" aria-setsize="-1" aria-posinset="2">item2</div>
</div>

<div role="list">
  <div role="listitem" aria-setsize="-1" aria-posinset="3">item3</div>
</div>
--------------
The previous behavior Windows Narrator would see the following:
"item1, index 1 of setsize=1;
 item2, index 2 of setsize=2;
 item3, index 3 of setsize=3;"
The new behavior Windows Narrator would see the following:
"item1, index 1;
 item2, index 2;
 item3, index 3;"

Bug: 1033618

Change-Id: Ie572c63f15b141f4744f93aa198d425462301f65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963108
Commit-Queue: Victor Fei <vicfei@microsoft.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726964}