- 06 Mar, 2020 40 commits
-
-
Omer Katz authored
This is a reland of 2f69de56 Original change's description: > heap: Enable concurrent marking for HashTable based collections > > All known data races in HashTable based collections have been resolved. > > Bug: 986235 > Change-Id: Ia7a22d707aaaea1ab3ebc70c47da0876fc426aa9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078617 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746694} Bug: 986235 Change-Id: I3bdc6c53fcf7f2d0cc17c5eabbb1a86f470a263c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090421Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#747728}
-
Jan Wilken Dörrie authored
This change implements the passwordsPrivate.getPasswordCheckStatus extension API. In order to obtain this information, the PasswordCheckDelegate instantiates a BulkLeakCheckAdapter, and forwards its GetBulkLeakCheckState(). An event listener that notifies about changes to this event will be added in a follow-up CL. Bug: 1047726 Change-Id: Id9b6aeff1d604df4924be81a2213d77c16cd0ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085273 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747727}
-
Andrew Luo authored
Bug: 1058637 Change-Id: I519f740d02078cb38d67e38d7d4a3307f5cce88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090839Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#747726}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0b1579a826af..88d9224c538a git log 0b1579a826af..88d9224c538a --date=short --first-parent --format='%ad %ae %s' 2020-03-06 lalitm@google.com Merge "tp: refactor systrace serialization code in raw table" Created with: gclient setdep -r src/third_party/perfetto@88d9224c538a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1bdd286458a2239445f8c92c41fa76069cc549c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091417Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747725}
-
Omer Katz authored
Moved the CHECK to when we pop from the worklist on the main thread instead of before we push concurrently. Bug: 1059185 Change-Id: I3b010d263c943395c7e483b3775a03e766ee1b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091525Reviewed-by:
-
ckitagawa authored
This CL makes FileManager async friendly for common IO operations required for Paint Previews. The aim of this change is to improve the FileManager and add support for SequencedTaskRunner to avoid risk of races when manipulating subdirectories which store Paint Previews. Bug: 1055508 Change-Id: I758bf4687cbec46eb9ef98ace8a0d3ada55d7ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082319Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#747723}
-
Christopher Cameron authored
Remove the remaining use of extension::Extension from ExtensionAppShimHandler. All uses are now in ExtensionAppShimHandler::Delegate, which we can move out of app code. Bug: 1057195 Change-Id: Ia5844bbe72d865ca54a69f3f3bfd7f9de7a204e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089677 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#747722}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/51afe2e3ccf5..93731aec6bd2 git log 51afe2e3ccf5..93731aec6bd2 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-06 tvanderlippe@chromium.org Fix clang-format configuration 2020-03-06 sigurds@chromium.org [COEP] Improve error messages for COEP Created with: gclient setdep -r src/third_party/devtools-frontend/src@93731aec6bd2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051473 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id340565a05db4fe96ce8f2127e51d866a4db0c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091414Reviewed-by:
-
Livvie Lin authored
Since we're adding lookalike interstitials, which also need the tab helper, IOSSSLErrorTabHelper should live in a common folder and be renamed to something more general. Bug: 1058898 Change-Id: Ia27eca489a0f62ce3584ca7d25ca13126810f973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089149Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747720}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I39db7fce8ef18f7000dba88307e8e76908901487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091545Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747719}
-
Anqing Zhao authored
Whenever upload list is loaded from log file, the format is checked at first. The JSON format and CSV format will be handled respectively. Following methods are extended. - ClearUploadList - ParseLogEntries Bug: 1040078 Change-Id: Ib0370ac4565c7c28b7a9a8480d080b628abaabc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058808Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#747718}
-
Justin Miron authored
Change-Id: I425ce0487fa3306a4f3cd50fa8b4ed0c2ee86539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078416Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Justin Miron <justinmiron@google.com> Cr-Commit-Position: refs/heads/master@{#747717}
-
chrome://browser-switchNicolas Ouellet-Payeur authored
On chrome://browser-switch, show a building icon next to the heading. Screenshot: https://i.imgur.com/F2ShKHz.png Bug: 1056718 Change-Id: Ib43064bf8dd6ad072c3d7c06f71c66724260d170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089961 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#747716}
-
Samuel Huang authored
Previously ProcessInitException thrown from LibraryLoader gets swallowed by AsyncInitTaskRunner. For the main usage (where the caller is NativeInitializationController.startBackgroundTasks()), AsyncInitializationActivity.onStartupFailure() is called, and it creates a new ProcessInitException while forgetting the old ones. This CL changes: * AsyncInitTaskRunner.onFailure(), * ChromeActivityNativeDelegate.onStartupFailure(), to take an Exception |failureCause|, so that it can be propagated wherever possible. This allows the old ProcessInitException to be attached to the new ProcessInitException instance, and gets passed to RuntimeException. Unfortunately, the old failure still does not get used to render start up error logs -- but at least now we have a better pipeline to enable better logging. This CL also refactors AsyncInitTaskRunner to make its completion criteria (in tasksPossiblyComplete()) more explicit, and simplify the inner class FetchSeedTask. Change-Id: I8f0443cbafd491f521d3f799622a82733b770099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085735 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#747715}
-
Christoph Schwering authored
</dom-module> was missing the >. Change-Id: Ic2a588c819de882878a0f3d0d62a6ad65c7020c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091350Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#747714}
-
Dominique Fauteux-Chapleau authored
These tests use the least possible amount of overrides to ensure DeepScanningDialogDelegate every requests/callbacks eventually resolves and returns to the caller. Also add code to handle the web contents being destroyed and avoid ASAN issues. Bug: 1041890 Change-Id: Ibfe232354f0591ae9e854bf5a0163ede68d6faf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083598 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#747713}
-
Joshua Pawlicki authored
Integrity of the check is still guaranteed by CUP. The check will no longer be confidential. Bug: 1057341 Change-Id: I366453b1586f3116ec75a11ef3718cfbbf5522ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090336 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#747712}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I385d19863911be4a72161ae9184a17ca8e536abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091421Reviewed-by:
-
Robbie Gibson authored
This reverts commit 2aa19d70. Reason for revert: Breaks QR code scanner. In investigating that, I think I found a better solution. Original change's description: > Fix NTP omnibox animation when there are suggestions > > Before, if there were suggestions on the NTP, they would immediately > appear. The better animation is to scroll the fakebox up to the top > of the screen and then present the suggestions. > > To do this, when entering the omnibox from NTP, we only focus the > location bar, which causes the scrolling animation. -fakeboxFocused > is already called in the animation completion block, which does the > actual work to make the omnibox text field first responder, causing the > suggestions to appear. > > To finish off, the -locationBarDidBecomeFirstResponder code now only > focuses the location bar if we are not on the regular NTP. > > Bug: 1057643 > Change-Id: I472ee1ee5693fa4102717275bf266f4ab97e121a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082556 > Commit-Queue: Robbie Gibson <rkgibson@google.com> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746450} TBR=stkhapugin@chromium.org,gambard@chromium.org,rkgibson@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1057643 Change-Id: Ifda283f7733b9439e3803d1110b0afefeee084f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089782Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#747710}
-
Thomas Lukaszewicz authored
Removed GetInstanceForNativeUi() from NativeFileSystemUsageBubbleView and CastDialogSinkButton. Changed the FileSystemUsageBubble to update its icons on theme change to keep sync with the current theme color values. Bug: 1056916 Change-Id: I81254025570f009cfea5db26ee982cf14ad45580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089986Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#747709}
-
David Tseng authored
This is the first step in a series of changes to improve touch interaction with ChromeVox. This change: - introduces a new earcon when entering a touch anchor - introduces a new earcon when touching a blank area of the screen (defined as an anchor that is neither a touch leaf nor a touch object) - when moving from a touch anchor to a non-touch anchor, immediately stop speech so the user knows they have left. This will help avoid confusion about what's currently focused or not when hovering a finger. This might also be familiar (e.g. iOS behaves this way). Note for the last point, we will have to solve the issue of really small touch targets. One potential solution (not for this change) is to come up with a way to do "fuzzy" hit testing. Change-Id: I262c664bc0d86aa6e8ce96cf1e263db7a8f184cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088510 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#747708}
-
Gabriel Charette authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2076423 After https://chromium-review.googlesource.com/c/chromium/src/+/2087971 and https://chromium-review.googlesource.com/c/chromium/src/+/2087892 R=ajwong@chromium.org Bug: 1026641 Change-Id: Ia2c180759677a51502c5c1c04508d165f7c35856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087893 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#747707}
-
Andrew Shulaev authored
Change-Id: I91e8da3812ae5870f56023a247ca9b83ea1cb5d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089850 Commit-Queue: Andrew Shulaev <ddrone@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#747706}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py 9284abd0040afecfd619dbcf1b244a8b533291c9`. linux_chromium_chromeos_msan_rel_ng trybot redness: Also red on the main waterfall in similar ways and has been for days (!). ipad-device, iphone-device trybot redness: happens on whitespace cl too, filed crbug.com/1059256 Bug: 1058012 Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Iafc17a96a7d40e9b99f58bce474ed50dc6bfb0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086341 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#747705}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/33be9dfe7a23..8e9fd4857e2e git log 33be9dfe7a23..8e9fd4857e2e --date=short --first-parent --format='%ad %ae %s' 2020-03-06 zetilovn@google.com Fix FakeVp8Encoder name. 2020-03-06 kron@webrtc.org Rename index.md to README.md to make it automatically show up Created with: gclient setdep -r src/third_party/webrtc@8e9fd4857e2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6bc81dbf783f7114f13217fd91f49938419e598f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091411Reviewed-by:
-
Yuzu Saijo authored
This CL adds an additional CHECK to ensure that the controller status is REDUNDADNT when crash happens. Bug: 1021718 Change-Id: I534d1198fb1f27368e41435d8127f6530a7e4bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087500Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Auto-Submit: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#747703}
-
Justin Miron authored
Introduces a new SafeBrowsingStatus field to Popup.Closed indicating the safe browsing status of a pop-up's navigation. This is checked using the sub resource filter observer's OnSafeBrowsingChecksComplete callback, similar to safe_browsing_triggered_popup_blocker. BUG=1044601 Change-Id: I012fbbde60741d30bad74457ddd3058f2fd909eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085161 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#747702}
-
Anna Malova authored
Bug: 1007815 Change-Id: Ia37eefa5925208304469a2859f05a915d392525e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089828Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#747701}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2de34c1791f3..e3f3e9a80d5f git log 2de34c1791f3..e3f3e9a80d5f --date=short --first-parent --format='%ad %ae %s' 2020-03-06 cwallez@chromium.org Revert "Vulkan: Report and enable subgroup size control device extension." 2020-03-06 cwallez@chromium.org Revert "Vulkan: Enforce fixed subgroup size for compute shaders." 2020-03-06 cwallez@chromium.org GN: Use the hermetic XCode if available. 2020-03-05 natlee@microsoft.com Query if Texture subresource has been initialized 2020-03-05 david.turner.dev@gmail.com Vulkan: Enforce fixed subgroup size for compute shaders. 2020-03-05 david.turner.dev@gmail.com Vulkan: Report and enable subgroup size control device extension. Created with: gclient setdep -r src/third_party/dawn@e3f3e9a80d5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1036080,chromium:1059205 Tbr: cwallez@google.com Change-Id: I3b42808fc1c72dd2c0812e1f09cf32906edbdade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091413Reviewed-by:
-
Mirko Bonadei authored
This is requred to fix some //base tests compiled by standalone webrtc when running "ninja -C out/Debug all". Bug: webrtc:11411 Change-Id: Ibcc43e19c594f3860fe5ebbc435aad5fd3a928f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090420 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#747699}
-
Sorin Jianu authored
After introducing the App instance, --install is broken on Windows. * pv is not handled correctly and it is not clear if this ever worked at all, even before refactoring. * the splash screen object has an incorrect life time. * the prefs are not save correctly due to threading and run loop issues. Bug: 1059135 Change-Id: I3a5930dcdbf530b0229692722734cb05680d63aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090973Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747698}
-
Maksim Moskvitin authored
This CL supports transitions from trusted vault passphrase to keystore and custom passphrases. To avoid data corruptions by buggy clients the bridge verifies that the remote keybag contains the last trusted vault key, which was used as the default key. Since browser restart can happen in between of receiving the remote update and decryption of the new remote keybag, |last_trusted_vault_key| stored in NigoriLocalData. Bug: 1020084 Change-Id: Ica654898a3499f599258bf9e65eb8d91580fcc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087766 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#747697}
-
Fredrik Söderquist authored
SVGSMILElement::ResolveActiveEnd() is the only caller of NextAfter(kEnd, ...), and it already handles the case of an empty list, so hoisting this check makes it more obvious that 'indefinite' is the initial value, and the failure to find a proper instance time means failure. This makes NextAfter() less dependent on what list it is searching, which will help split it out (and optimize certain operations on it). Bug: 1039243 Change-Id: I8fbc8b86521df53b32ea67bbd5e3281e261246cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089867 Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#747696}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e9030e1f5b01..0b1579a826af git log e9030e1f5b01..0b1579a826af --date=short --first-parent --format='%ad %ae %s' 2020-03-06 lalitm@google.com metrics: make null values passed to repeated fields more obvious Created with: gclient setdep -r src/third_party/perfetto@0b1579a826af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic206d0d7c0b3cd0a69fce2440b52c3b77a67bfed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091412Reviewed-by:
-
Stepan Khapugin authored
Reparents the tab grid to SceneController. Note that the lazy getter loses a DCHECK - it seems too hard to cleanly port to SceneController at the moment, though once multiwindow is operational we should add new invariant checks everywhere. Bug: 1045657 Change-Id: I7e4eecd58bea4338a634f9e01e2cbc255c49c328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087337 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#747694}
-
Surma authored
The WebAssembly Web API spec[1] prescribes that the responses for `WebAssembly.{compile,instantiate}Streaming()` must have the `Content-Type` header `application/wasm` without any extra parameters. So far we ignored extra parameters, causing interop issues with Firefox. [1]: https://www.w3.org/TR/wasm-web-api-1/#streaming-modules Bug: 1057973 Change-Id: I2273e2b5577dc6a11343536d55fa72b9e518c0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085257 Commit-Queue: Surma <surma@chromium.org> Reviewed-by:Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Ehimare Okoyomon authored
OnJavascriptDisallowed does not get called to remove the observer if the incognito ntp tab is closed, which can result in a crash (see bug). To fix this, add RemoveObserver call to the destructor. Bug: 1058769 Change-Id: I18413d0ae54593adc032aa017f39f5787bd5bc31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088713 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#747692}
-
Mike West authored
This patch checks in failing expectations instead to make our existing behavior clear. Bug: 1024786 Change-Id: I1cf5b536cc410b7798ce69a6a140b01f61ca2481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089704 Commit-Queue: Mike West <mkwst@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Auto-Submit: Mike West <mkwst@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#747691}
-
Kevin Ellis authored
This patch resolves most of the known cases for resolving potential conflicts between play state changes originating from web-animation API calls and animation-play-state. Next steps: - resolve the behavior of methods that indirectly call play such as reverse. Additional tests will likely be required for these cases. - fix pending. When pending is called from JavaScript on a CSSAnimation, the style must be flushed to ensure than any pending change to play state is resolved; however, there are other call sites to pending that should simply check the status without a forced style update. An additional method is needed to separate the two use cases. The change is straightforward, but potentially bulky, and thus deferred to a separate CL. Bug: 1006086 Change-Id: I65d1f51c3c2fd026255099ac7f200257b3ece7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078414 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#747690}
-
Monica Basta authored
This CL removes the history usage hint for the sWAA on and updates the strings for the sync setup page. Bug: 1035421 Change-Id: Ife04c81e5994874e3f437adecd4f4d5afd923456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089872Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#747689}
-
