GitLab

Bug: 1061906
Change-Id: I798d592945cadcb5b375ee508369738224d78caa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132330Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Hao Dong <spdonghao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756384}

Casting content from a local server is broken because the request is
auto upgraded to HTTPS.

Bug: b/153100172
Test: CQ
Change-Id: Ib3cb140df74cbc9336b245069c050163bac120ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135889Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Junbo Ke <juke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756383}

This CL adds more tests for FileUtils:
  * batchDeleteFiles() (not testing content URL deletion).
  * copyStream().
  * copyStreamToFile().
  * readStream().
  * getUriForFile().

Bug: 1066730
Change-Id: I7ac4d2f1c5eecd82aebf931a797c9bac8a96d635
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135814Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756382}

These logs were previously incorrect making it slightly
confusing to read debug logs after the fact. This CL
makes it clear when advertisements are received and
a connection is beginning to be created.

Change-Id: I93ff8b8b415878c499844ae8b3b99d99f9f2a481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134770
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Auto-Submit: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756381}

In the latest CTAP 2.1 draft, an authenticator can have a default
credProtect level other than one. Previously, Chromium couldn't
distinguish level one from not-specified thus, first, this change adds
that distinction.

Then there are additional complexities because Chromium sets a default
credProtect level of two for discoverable credentials, but we don't want
to override an authenticator default of three. Therefore the credProtect
level for a request becomes a property that can only be resolved in the
context of the specific authenticator that will receive the request.

We already have a property like this: the Android ClientDataJSON
extension. Thus pull these meta-level request properties into a
different structure so that MakeCredentialRequestHandler can craft
per-authenticator requests from that when needed.

This isn't perfectly clean because the Windows API acts as an
authenticator, but is actually a front for many authenticators. So we
have to stuff |cred_protect_enforce| in the request object, despite it
being a meta-level property.

BUG=1057126

Change-Id: Id1c02d4689492d597f5f29674166b97a8e720d2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130869Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756380}

Add tests that show current printing behavior of contents being aligned
to the bottom right corner of the printed page. Show the behavior for
both portrait and landscape PDFs. Also show the behavior on large and
small destinations.

Bug: 919596
Change-Id: I1519f59b22e9c29f46c941e10b851f5d78d2fafc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124986
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756379}

A crash can result from the following sequence of events (as debugged
by ellyjones):
  1.  displays_require_update_ is false
  2.  The configure timer ticks, ConfigureTimerFired is called
  3.  ConfigureTimerFired -> UpdateDisplaysIfNeeded, which is a noop
      because displays_require_update_ is false
  4.  ConfigureTimerFired -> NotifyDisplaysChanged, which starts
      iterating the list
  5.  One instance of NativeWidgetNSWindowBridge::
      OnDisplayMetricsChanged calls ScreenMac::GetDisplayNearestWindow
  6.  Since the display list has not yet been updated (at step 3), that
      falls back to GetCachedDisplayForScreen (and its call to
      UpdateDisplaysIfNeeded is a noop)
  7.  Since the display list still hasn't been updated,
      GetCachedDisplayForScreen calls OnNSScreensMayHaveChanged, which
      sets displays_require_update_ to true
  8.  The iteration from step 4 resumes, and another instance of
      NativeWidgetNSWindowBridge::OnDisplayMetricsChanged runs
  9.  For *this* instance, displays_require_update_ is true, so
      UpdateDisplaysIfNeeded destroys the old version of displays_
  10. The iteration from step 4 resumes, now iterating on a destroyed
      displays_.

Break this by removing the call to OnNSScreensMayHaveChanged from
GetCachedDisplayForScreen, to see if it removes the crashes.

Bug: 1033866
Change-Id: I1271c83d5456ab9c863969842816661c6b3e0569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135312Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756378}

Bug: 1062408
Change-Id: Ifbfe36bb8b777c0fde98ce0666cb43a7aaeace6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135496Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Sam Bowen <sgbowen@google.com>
Cr-Commit-Position: refs/heads/master@{#756377}

This CL removes |ImageLoader::Task::request_url_| in favor of lazily
parsing the image request's absolute URL when ImageLoader::Task is run.

Currently ImageLoader::Task stores a KURL |request_url_|, which is a
snapshot of the image's absolute URL, parsed relative to the image
element's node document at the time ImageLoader::Task is queued.
We shouldn't have to store a snapshot of the parsed URL, because the
source URL at the time an ImageLoader::Task is run is the same as when
the task is queued.

The reason we stored a snapshot of the parsed URL is because what *can*
change in between when an ImageLoader::Task is queued and run, is the
document's base URL, via a `<base>` element. In https://crbug.com/569760
a CL was landed that takes this snapshot, so that if a `<base>` element
was dynamically-inserted before the ImageLoader::Task was run, the URL
would be unaffected by the addition of the `<base>`. However, the spec
is very clear that the parsing of an image request's URL [1] happens
after the microtask is run, meaning our snapshot is unnecessary, and
incorrect.

This CL:
 - Removes the snapshot
 - Fixes the associated test
 - Exports the test to external/wpt so other impls can benefit

[1]: https://html.spec.whatwg.org/multipage/images.html#updating-the-image-data:parse-a-url-2

Bug: 569760,1061685
Change-Id: I8d9e3dbefd27a26626bb930acc809196753c7506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103987
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#756376}

This is the chrome-side counterpart of
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2128732

Bug: 1059577, 795595
Change-Id: Iec2ee772a42b4c7bc2249627c0839f7506f0cd1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129344Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756375}

Previously DefaultDecoderFactory could crash when creating decoders
after the GPU context has been lost because it was assuming that
GetMediaContextProvider() always returns a valid result. Fixed it to it
to validate the result before trying to use it.

Bug: 1057959
Change-Id: I767a8fa7dcfcfb122be98449cc1aa46c43ceae62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135531
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756374}

Instead of using magic numbers for test arguments, name
them according to their function, e.g. kPositiveInt.
This makes it clear what the number represents.

Bug: chromium:1066251
Change-Id: Ie9525667d4fe62dcd0c61f39250f61cb9fc70fe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134504
Commit-Queue: Paul Moy <pmoy@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756373}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/039884bb8c63..b70ef7756a4d


Created with:
  gclient setdep -r src-internal@b70ef7756a4d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I702e2801916a5c3b956259c37c5b04f409edd4f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135971Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756372}

This rolls testharness.js, idlharness.js, and webidl2.js from the
external copy in external/wpt/resources/ to the internal copy in
resources/, bringing us up to WPT SHA e343467e.

Note that the webidl2.js changes are just tab characters present in the
original file that I accidentally cleaned into spaces in the previous
roll.

Bug: 1067618, 1066131
Change-Id: I1ccdf13418e10ace29564695d3dd20a738a7a3eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135540Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756371}

This is a first pass at implementing a header-based version of origin
isolation, alongside our existing origin policy-based one, per [1]. It
does not yet parse the header, instead simply using its presence or
absence. This CL includes browser tests only for now; web platform tests
will be done in a follow-up.

[1]: https://github.com/WICG/origin-isolation/commit/1c16647387b6be1bb170ed8ce24a5bd179abfa98

Bug: 1042415
Change-Id: Iaaa97a87e166aeedac2313f718322e5cdb7462e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113152
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756370}

The network process crashes flakily in these tests on trying to read a
file and being blocked:

[217947:217958:0403/143350.056670:FATAL:url_loader.cc(1828)] Check failed: response_.
#0 0x5604f137b829 base::debug::CollectStackTrace()
#1 0x5604f12a3ae3 base::debug::StackTrace::StackTrace()
#2 0x5604f12b9174 logging::LogMessage::~LogMessage()
#3 0x5604f2afe5d7 network::URLLoader::CompleteBlockedResponse()
#4 0x5604f2afcf29 network::URLLoader::OnReceivedRedirect()
#5 0x5604f194d027 net::URLRequestJob::NotifyHeadersComplete()
#6 0x5604f1950a04 net::URLRequestHttpJob::NotifyHeadersComplete()
#7 0x5604f1952ec2 net::URLRequestHttpJob::SaveCookiesAndNotifyHeadersComplete()
#8 0x5604f1951d28 net::URLRequestHttpJob::OnStartCompleted()
#9 0x5604f186697c net::HttpCache::Transaction::DoLoop()
#10 0x5604ee97ab9c base::internal::Invoker<>::Run()
#11 0x5604f185fae3 net::HttpNetworkTransaction::DoCallback()
#12 0x5604f1820853 net::HttpStreamParser::OnIOComplete()
#13 0x5604ee97ab9c base::internal::Invoker<>::Run()
#14 0x5604f18c8a69 net::TCPClientSocket::DidCompleteRead()
#15 0x5604f1983a9c net::TCPSocketPosix::ReadCompleted()
#16 0x5604f198526a base::internal::Invoker<>::RunOnce()
#17 0x5604f1987137 net::SocketPosix::RetryRead()
#18 0x5604f1987eff net::SocketPosix::ReadCompleted()
#19 0x5604f1987c28 net::SocketPosix::OnFileCanReadWithoutBlocking()

When that happens the StoragePartition's NetworkContext is recreated.
WebTestContentBrowserClient was storing the NetworkContext* into a
RepeatingCallback against the advice of the method returning it
(ie StoragePartition::GetNetworkContext()), and then if the process
crashed, the Callback would have a dead pointer bound.

This changes the tests to grab the pointer when the callback is run
instead. The WebTestClientImpl's cookie_manager_ will still become
useless after the network service crashes, but these tests don't
depend on that... and WebTestClientImpl is created per-renderer so
it should not impact other tests.

R=nasko@chromium.org

Bug: 1067445
Change-Id: Ieeaca88e5baee9aa3f1bf969c1486503819dcdf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135424Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756369}

Bug: 1067673
Change-Id: I25b6cf86091568ca96e9dd53772b95e9f7d08dac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135888
Auto-Submit: Haiyang Pan <hypan@google.com>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756368}

Previously, the Trust Tokens request helpers enforced a collection of
uniform preconditions on their issuer and top frame origins via DCHECKs.
These were both conceptually enforced at the level "immediately above"
the factories (the request helper factory: crrev.com/c/2097057).

This CL makes a couple changes:
1. it removes the top frame origin DCHECKs and enforces the top frame
origins' constraints by requiring SuitableTrustTokenOrigin-typed top
frame origins; the type itself enforces the preconditions.
2. it moves the issuer origin checks conceptually into the request
helpers themselves, because the source of the issuer origin varies from
operation to operation (for issuance and redemption, it's the request's
destination URL; for signing, it's an additional parameter).

R=csharrison

Test: Expand unittests to cover unsuitable issuer origins.
Bug: 1042962
Change-Id: I8f0125eb796c3421bf082ea22fb1fe5f0f85007e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134588
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756367}

Disable org.chromium.chrome.browser.browsing_data.
ClearBrowsingDataFragmentTest#testImportantSitesDialogNoopOnCancel
It's flaky on android-marshmallow-arm64-rel

Bug: 1067686
Change-Id: Ia9d878ee52ab649e5a7b4a3b8892335d7b571029
Tbr: msramek@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136027
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756366}

Disable SitePerProcessBrowserTest.ScrollBubblingFromNestedOOPIFTest
because it's flaky on multiple release build.

Bug: 1063045
Tbr: kenrb@chromium.org
Change-Id: Ie731a5c72c39d890b639f7cc6a97562db6e025ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135890Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756365}

Currently, the Switch Access back button is drawn by the extension, but
in order to match the visual specification (see bug) the back button
needs to be drawn using native views.

This change creates a bubble controller for Switch Access and adds the
ability to show the back button. This functionality is not yet used.

Relnotes: N/A
Bug: 973719
Change-Id: I6da3772e8183d0cdbd04b554a4764719d12b8e25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124234
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/master@{#756364}

The existing media foundation encoding path has been enabled by
default for a long time. Remove the old switch in preparation for
a new one which controls usage of the asynchronous MFT.

Bug: 982799
Change-Id: I9456029bf38f5af3710b93d693876f20e69d2768
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135313Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756363}

Bug: 1062838
Change-Id: I89022a61759a3f2b19650c4ee61d35df57d58f16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135334
Auto-Submit: Haiyang Pan <hypan@google.com>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756362}

that particular user sid.

Note: Tested the changes locally on a VM instance. It works great !

Bug: 1045080
Change-Id: I3e05cbd8d6448a601109787f3de2a9a36236709e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135188
Commit-Queue: Rakesh Soma <rakeshsoma@google.com>
Reviewed-by: Yusuf Sengul <yusufsn@google.com>
Cr-Commit-Position: refs/heads/master@{#756361}

This CL adds ListBoxOption role as an item for Group role in
AXNode::SetRoleMatchesItemRole() since Group role could have
ListBoxOption as an item[1]. With this change, when the parent
of ListBoxOption is a group role, PosInSet and SetSize has
proper values.

[1]https://w3c.github.io/aria-practices/examples/listbox/listbox-grouped.html

Bug: 1066632
Change-Id: I23cf0c34ee479d6e8ee33b3f9e327def820527e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134037
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756360}

Bug: 1065763
Change-Id: I154a3446d3893916831c66f6a5ecbd36d94b4f57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127428
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756359}

This is necessary in the short term because we dropped 82.

BUG=1067701
TEST=none

Change-Id: Iee16ec4083e53cfa532ea5b2bbeb1111453d45cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135338Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756358}

Simplify fraction centering calculation by not computing
content_inline_size, since this is equal to child_available_size.inline_size.

Bug: 6606
Change-Id: If2c734f0ea644922d49e1527b1ac599df17bc7bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134300Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#756357}

We observed an issue in Microsoft Edge where a certain printer driver
was being called on two different threads simultaneously and reacted
by making an unbalanced CoUninitialize() call on the browser UI thread.
If this happens enough times, the CoInitialize() count of the UI thread
will eventually drop to zero and cause problems when, for example,
out-of-process accessibility clients attempt to access objects that are
only safe to call on the UI thread - the COM marshaler will see that
the UI thread is in the implicit MTA and assume that these objects can
be called from any MTA thread. I haven't successfully reproduced the
same issue in Chrome, but the threading pattern for printer driver
calls is the same, so the potential for it to occur is there.

Existing code comments document that some Windows printer drivers are
only safe to call from the UI thread. Accordingly, this CL addresses
the issue by moving work done by the local printer handler from a
generic task runner thread to the browser UI thread on Windows.

Bug: 1065145
Change-Id: Ic20872cb33bfb6c94381059578c2055cb1a9a1eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135054
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756356}

Not done in this CL, but intended in the future:
* Genre should be able to store multiple values.
* TV episode images.
* Play next episode.
* Storage of the media feed items in media history.
* End to end testing using a full JSON example.

Change-Id: Ib4c6d9421c61ed98426aabc5b6056f0437195782
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112957Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Sam Bowen <sgbowen@google.com>
Cr-Commit-Position: refs/heads/master@{#756355}

This class inherits from |AssistantInteractionSubscriber| and provides
a dummy implementation of all the methods, so that test classes can
derive from this and only implement what they need.

It also adds a |mojom::Remote| that every test class needs.

Bug: b/151800188
Change-Id: I1f06f180e2f99c76a09171122777e24561e0a562
Tests: Ran existing unittests
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128838Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/master@{#756354}

https://webrtc.googlesource.com/src.git/+log/16d0d371d549..f687d90f4219

git log 16d0d371d549..f687d90f4219 --date=short --first-parent --format='%ad %ae %s'
2020-04-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ae03941a..9dce00d2 (756130:756252)

Created with:
  gclient setdep -r src/third_party/webrtc@f687d90f4219

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ice387e71076029be8d4193d9464a2ce0503901af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135802Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756353}

An integration test was failing on L bots because the hiding animation
in the compositor wouldn't complete and the indicator would get stuck
shown. Upon investigating, I discovered that this issue was not limited
to tests and was reproducible on an emulator.

The issue was that #onLayoutChanged would be called during the hide
animation causing a wrong height value to be sent to the compositor as
if it's being shown.

A simple fix is to add a boolean to ignore #onLayoutChange calls when
we no longer need them, and we're basically done once we get a height to
run the show animation.

Bug: 1059297
Change-Id: I943300ebc1e93172eec9311ec28c44172464ba4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130781
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756352}

When the legend is larger than the fieldset border-top, the fieldset's
border box gets pushed down. In the case of fragmentation, allow
this adjustment if the legend fits inside the first fragment.
Otherwise, don't adjust the fieldset border block-start offset.

This is similar to how fragmentation was handled in the case where the
legend is smaller than the border-top:
https://chromium-review.googlesource.com/c/chromium/src/+/2125230

Tests were not added at this time for the following reasons:
1. It currently isn't possible to test where the fieldset border
starts using unit tests.
2. Paint for legend fragmentation isn't currently working, so testing
this via web tests was also not possible.

Bug: 875235
Change-Id: I9594ab35bce23a4e9dd1a3aa2e7d913900ec14b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131348Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#756351}

Nightmode is not supported on Kitkat devices. Disable the test for now.

Bug: 1067575
Change-Id: Ie81b15f55a3e17ed8b22b8e6866ebfe5ebf19921
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135946
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Auto-Submit: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756350}

Package configurations do not change at run-time, so cache it the first
time it is read, to avoid the cost of repeatedly re-reading it from the
filesystem.

Change-Id: I53c6ea55be5fca48bf3c81f189e251d8a11a55a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135607
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756349}

Bug: 1052476
Change-Id: I5d453d31bfd96dddbf303b41fb9adc36110d9ac8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092159
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756348}

As pointed out in [1] the style guide recommends against out parameters.
This change rewrites most of the helper functions in UsbServiceWin to
return their value directly, using an empty string or nullopt as a
sentinel for failure.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/2132532

Bug: 637404
Change-Id: I54b4b807fae95f9ff93e9a02546e2748cf00b9f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135129
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756347}

Allow media playback in CastComponents to be controlled by the owning
Agent.

Bug: 879317
Change-Id: I6a744faa0b236f3a856d5c4aa0b9f0846f6970ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130546
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756346}

Add a histogram that records the size of the
database in KB.

BUG=1024362

Change-Id: I4fac8d7184b0c9e2c53554df0175512c0266a1d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125269
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756345}