GitLab

TEST=<new pipeline integration test>

Review-Url: https://codereview.chromium.org/2096813002
Cr-Commit-Position: refs/heads/master@{#402649}

This makes SetFillsBoundsOpaquely() call consistent with opaque_rect
used in UpdateSurface() when creating a texture quad.

BUG=549781

Review-Url: https://codereview.chromium.org/2101453002
Cr-Commit-Position: refs/heads/master@{#402648}

Currently chooser bubble and chooser dialog have different ChooserController
ownership models. For chooser bubble, the ChooserController is owned by
ChooserBubbleDelegate, which is a subclass of BubbleDelegate and BubbleManager
owns it. For chooser dialog, ChromeExtensionBluetoothChooser owns it, which
is a subclass of BluetoothChooser.

Since the ChooserController is only used by view classes, a better way is to
let ChooserContentView (for non-Mac) and ChooserContentViewCocoa (for Mac)
own it.

BUG=621216

Review-Url: https://codereview.chromium.org/2086663003
Cr-Commit-Position: refs/heads/master@{#402647}

BUG=609731
TBR=tdanderson@chromium.org

Review-Url: https://codereview.chromium.org/2109663004
Cr-Commit-Position: refs/heads/master@{#402646}

Also fix include/namespace use and session state delegate access.

BUG=619636
TEST=Compiles; no behavior changes.
R=jamescook@chromium.org
TBR=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2101263004
Cr-Commit-Position: refs/heads/master@{#402645}

  In order to roll GN 520de0f3..cadaad43 (r400967:r402556) and pick up
  the following changes:

  c0ff8864 Add GN split_list function.
  db530b15 Reland of actor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2104083002/ )
  74af4d66 Revert of Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2108683002/ )
  9f1375ea Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python.
  01c8157e Remove calls to deprecated MessageLoop methods in tools.
  d6fd033c [Mac/iOS/GN] Document enable_stripping and enable_dsyms vs their GYP equivalents.
  120e860e Add documentation about no sources for GN guide.

TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2102313002
Cr-Commit-Position: refs/heads/master@{#402644}

In Material Design we display a white tab spinner for Incognito mode
tabs, but we need to also do so for dark themes.

R=avi@chromium.org
BUG=624106

Review-Url: https://codereview.chromium.org/2103073003
Cr-Commit-Position: refs/heads/master@{#402643}

When creating a new contact, the AutofillContact object is created with
both null phone number and null email address. Therefore, asserts that
one of them should be not null are not correct. This patch removes these
asserts.

BUG=624211

Review-Url: https://codereview.chromium.org/2101983004
Cr-Commit-Position: refs/heads/master@{#402642}

BUG=603217

Review-Url: https://codereview.chromium.org/2104053003
Cr-Commit-Position: refs/heads/master@{#402641}

This patch updates the code to prevent auto deducing to a raw pointer.

R=hubbe, danakj, dcheng
BUG=554600

Review-Url: https://codereview.chromium.org/2101403005
Cr-Commit-Position: refs/heads/master@{#402640}

This CL reduces the effect of iron-list clipping off the ink ripple
effect on paper-checkbox (e.g. in the language settings). The ripple can
still be clipped on the top and bottom. This CL fixes the more noticeable
clipping on the left edge.

BUG=608647
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2098123002
Cr-Commit-Position: refs/heads/master@{#402639}

The string overallocation strategy of StringBuilder doesn't really make sense
since we need to create a copy at the end now that StringImpl::reallocate was
removed by https://codereview.chromium.org/1390033003

We probably should add back an optimization that forcibly sets the length of the
String and uses overallocation to avoid doing a string copy in every StringBuilder,
but until we decide to do that lets switch to using a Vector for the buffer since
it can handle growing the buffer automatically for us and makes the code in
StringBuilder much simpler.

Review-Url: https://codereview.chromium.org/2046353002
Cr-Commit-Position: refs/heads/master@{#402638}

Currently, the Windows perf bisector is flakily failing on the CQ because of
WPO on Windows.

zxiong@ is going to fix the root cause but for now, we want to disable the bot
to eliminate the flakiness.

BUG=601699

Review-Url: https://codereview.chromium.org/2105653005
Cr-Commit-Position: refs/heads/master@{#402637}

We can't copy cube map or 3D textures using CompressedCopyTextureCHROMIUM, make
sure we check the targets before trying to look up level images etc. otherwise
we'll use the wrong target (texture target instead of image target).

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2094343003
Cr-Commit-Position: refs/heads/master@{#402636}

BUG=b/28987931
BUG=b/29121207
TEST=Manually on device. In case Arc is managed no UI is shown and
     Arc is started automatically. Emulate error and OptIn is
     automatically recovered without user interaction.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2102793002
Cr-Commit-Position: refs/heads/master@{#402635}

BUG=618763

Review-Url: https://codereview.chromium.org/2082723002
Cr-Commit-Position: refs/heads/master@{#402634}

It is only useful for sites that require dedicated processes, or
in --site-per-process mode.

BUG=none
TEST=No behavior change.

Review-Url: https://codereview.chromium.org/2101293003
Cr-Commit-Position: refs/heads/master@{#402633}

Allow component installers to specify a map of installer attributes to be used in the update check requests.

This change extends the mechanism to specify "ap" in such a way that a map of name-value pairs can be returned by the component installer which need this capability.

R=waffles
BUG=599703

Review-Url: https://codereview.chromium.org/2102083002
Cr-Commit-Position: refs/heads/master@{#402632}

This will give us a bit more test coverage prior to
the branch.

R=brettw@chromium.org
BUG=618468, 605318

Review-Url: https://codereview.chromium.org/2105043003
Cr-Commit-Position: refs/heads/master@{#402631}

Adds state type changed event to remote_shell_protocol.

BUG=b/29817350

Review-Url: https://codereview.chromium.org/2109763002
Cr-Commit-Position: refs/heads/master@{#402630}

BUG=548423

Review-Url: https://codereview.chromium.org/2103383002
Cr-Commit-Position: refs/heads/master@{#402629}

BUG=613883

Review-Url: https://codereview.chromium.org/2073713002
Cr-Commit-Position: refs/heads/master@{#402628}

This Should make it so a user can override Websockets through devtools
protocol.

BUG=446909

Review-Url: https://codereview.chromium.org/2003253002
Cr-Commit-Position: refs/heads/master@{#402627}

Tables can be the containing block for positioned objects too, so when we take over
the overflow calc duties from LayoutBlock we need to cater for positioned objects
like it does too.

I also spotted an error in LayoutTable::recalcChildOverflowAfterStyleChange() - we
need to recalc overflow for all sections regardless of whether a section has already
changed its overflow.

BUG=619510

Review-Url: https://codereview.chromium.org/2100343002
Cr-Commit-Position: refs/heads/master@{#402626}

As discussed in
https://github.com/w3c/webcomponents/issues/192

document.pointerLockElement should be now shadow-dom aware,
and it gets adjusted to its node tree.

ShadowRoot.pointerLockElement is also added so it should
work similar to how document/ShadowRoot.activeElement works.

BUG=622584

Review-Url: https://codereview.chromium.org/2086293004
Cr-Commit-Position: refs/heads/master@{#402625}

R=inferno@chromium.org,ochang@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2108013002
Cr-Commit-Position: refs/heads/master@{#402624}

This will also get rid of "libfuzzer/../../" strings in libfuzzer stacktraces.

BUG=

Review-Url: https://codereview.chromium.org/2108713003
Cr-Commit-Position: refs/heads/master@{#402623}

This is a drop-in replacement of ICU library performing automatic text
encoding detection with CED (Compact Encdoing Detection).

CED is used extensively in Google for every crawled web page,
email message, query string, etc., and recently open-sourced for
public use. (https://github.com/google/compact_enc_det)

Also it is a much better alternative to ICU in terms of speed.
ICU introduces significant regression in page loading (up to 30%):

= ICU auto-detection vs. TOT =
page_cycler.typical_25:cold_times.page_load_time 1085.13±9.31% 754.28±12.03% (30.49%)

http://storage.googleapis.com/chromium-telemetry/html-results/results-2016-05-08_21-20-58

while CED adds virtually no additional loading time (delta < sigma):

= CED auto-detection vs. TOT =
page_cycler.typical_25:cold_times.page_load_time ms 705.70±9.49% vs. 760.31±11.90% (-7.74%)

http://storage.googleapis.com/chromium-telemetry/html-results/results-2016-05-08_20-37-54

With CED, it is feasible to turn on auto encoding detection by default
so that web pages without encoding label can be taken care of. It will be
done in a follow-up CL.

BUG=597488

Review-Url: https://codereview.chromium.org/2081653007
Cr-Commit-Position: refs/heads/master@{#402622}

Stores the updates as a V4StoreFileFormat proto with the following fields:
1. Magic number (integer)
2. Version (integer)
3. Hash prefix information (ListUpdateResponse proto).

Overall design document: https://goto.google.com/design-doc-v4store

Only FULL_UPDATEs are written to disk.

Includes tests to read from and write to the disk.

BUG=543161

Review-Url: https://codereview.chromium.org/2066083002
Cr-Commit-Position: refs/heads/master@{#402621}

Introduces CSSPendingSubstitutionValue for each longhand, containing a
reference back to the shorthand property.

Changes CSSVariableResolver to just resolve variables, rather than
resolving and applying them (a task that StyleBuilderCustom can pretty
easily take care of).

Introduces a property cache on StyleResolverState to limit the amount
of parsing required during resolution. This is somewhat unattractive to
me, but there was a lack of better alternatives.

BUG=612634

Review-Url: https://codereview.chromium.org/2089593002
Cr-Commit-Position: refs/heads/master@{#402620}

BUG=b/28602162

Review-Url: https://codereview.chromium.org/2101883002
Cr-Commit-Position: refs/heads/master@{#402619}

This patch updates the code to prevent auto deducing to a raw pointer.

R=sky, danakj, dcheng
BUG=554600

Review-Url: https://codereview.chromium.org/2101323003
Cr-Commit-Position: refs/heads/master@{#402618}

DialogPresenter provides an abstract interface for handling JavaScript
alerts and the HTTP Authentication prompt. A subclass can be provided
through the WebStateDelegate.

Proposal Link:
https://docs.google.com/document/d/1d3PxHcDGyZlrgEBa58oh-eFFOWUYLOv8kIiuftFjli8/edit

BUG=620739

Review-Url: https://codereview.chromium.org/2074733002
Cr-Commit-Position: refs/heads/master@{#402617}

Revert of Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule() (patchset #13 id:240001 of https://codereview.chromium.org/2046583002/ )

Reason for revert:
Sheriff reverting on suspicion of causing the Win x64 build to fail:
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1995

From the log:
FAILED: obj/base/base.file_version_info_win.obj
ninja -t msvc -e environment.x64 -- C:\b\build\slave\cache\cipd\goma/gomacc "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\base\base.file_version_info_win.obj.rsp /c ..\..\base\file_version_info_win.cc /Foobj\base\base.file_version_info_win.obj /Fdobj\base\base.cc.pdb
c:\b\build\slave\win_x64\build\src\base\file_version_info_win.cc(81): error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win_x64\build\src\base\file_version_info_win.cc(81): warning C4267: 'argument': conversion from 'size_t' to 'DWORD', possible loss of data
[8341/32887] CXX obj\base\threading\base.thread_collision_warner.obj

Original issue's description:
> Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule()
>
> Currently, base::FileVersionInfo::CreateFileVersionInfoForModule()
> calls ::GetModuleFileName and ::GetFileVersionInfo, grabs the loader
> lock and potentially touches the disk to obtain the VS_VERSION_INFO
> of the module. This is gratuitous for a module that is already loaded.
>
> With this CL, base::FileVersionInfo::CreateFileVersionInfoForModule()
> uses base::win::GetResourceFromModule() to get the VS_VERSION_INFO
> resource from memory.
>
> BUG=609709
>
> Committed: https://crrev.com/f177a678814f97f0b35bd6aa678c1cf885ad1656
> Cr-Commit-Position: refs/heads/master@{#402549}

TBR=grt@chromium.org,thestig@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=609709

Review-Url: https://codereview.chromium.org/2102363002
Cr-Commit-Position: refs/heads/master@{#402616}

This CL is part 2 of 2 for making cc::CompositorFrames
movable. This CL primarily tackles making cc::Surface
hold a cc::CompositorFrame by value. This impacts tons of
callsites which are updated in this patch.

https://codereview.chromium.org/2096493002/

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/2d9cc5abb4745280a002822a2380e925f835ef51
Review-Url: https://codereview.chromium.org/2098953003
Cr-Original-Commit-Position: refs/heads/master@{#402545}
Cr-Commit-Position: refs/heads/master@{#402615}

R=michaelpg@chromium.org
BUG=622037
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2094223004
Cr-Commit-Position: refs/heads/master@{#402614}

BUG=619686

Review-Url: https://codereview.chromium.org/2094013003
Cr-Commit-Position: refs/heads/master@{#402613}

When a PaintLayerScrollableArea is not using composited scrolling, it must
usually issue a paint invalidation for every scroll, but it can skip the
invalidation if all scrolling content is composited.  This optimization was
added by http://crrev.com/27239004.

However, one subtlety was not accounted for: a composited child that is not a
stacking context paints negative z-index content into the GraphicsLayer of the
nearest stacking-context ancestor.  If we have such a child, we must still issue
the invalidation.

Note that any any transform-related property creates a stacking context (see
call to setZIndex(0) in StyleAdjuster::adjustComputedStyle), so this will not
de-optimize scrollers that force compositing with translateZ(0) or similar.

BUG=596060

Review-Url: https://codereview.chromium.org/2107903002
Cr-Commit-Position: refs/heads/master@{#402612}

> [DomKey] Expose Korean special keys on Korean keyboard layout only
>
> Korean keyboard has special keys "HangulMode" and "HanjaMode", we should
> only expose them when the system layout is Korean. Otherwise we should
> return "Unidentified".
>
> This matches Firefox and windows virtual key.
>
> Note: This also works with JIS keyboard + Korean layout, because we are
> mapping DomKey based on KeyboardCode instead of DomCode.
>
> BUG=612736
>
> Committed: https://crrev.com/bdcfb5a1816f1bad537d7611c7ccb972b550339c
> Cr-Commit-Position: refs/heads/master@{#399783}
> Revert: https://codereview.chromium.org/2061123005

Original issue:
Windows API |LoadKeyboardLayout()| won't pass DrMemory
tests for Korean and Japanese locale.
This should be an issue of DrMemory test or Windows itself.
See https://crbug.com/612736#c11

Solution:
Just skip |LoadKeyboardLayout()| and hardcode locale for Korean,
it works because we are only testing non-printable keys, which
doesn't care about |ToUnicodeEx()|.

Note:
|ToUnicodeEx()| returns empty string if the specified locale is invalid. (e.g. Korean HKL without calling 'LoadKeyboardLayout()')

Also Note:
"mock_keyboard.h" has the similar issue, e.g.
Call "MockKeyboard::GetCharacters(MockKeyboard::LAYOUT_KOREAN, ..)" somewhere and run DrMemory full test, which will fail as well.

BUG=612736

Review-Url: https://codereview.chromium.org/2097643002
Cr-Commit-Position: refs/heads/master@{#402611}

This fixes null dereference crashes when tabs close with open bubbles.

BUG=622973

Review-Url: https://codereview.chromium.org/2103733002
Cr-Commit-Position: refs/heads/master@{#402610}