- 10 Nov, 2017 40 commits
-
-
Wenzhao Zang authored
1) We need larger bullets, which is essentially the same with setting different sizes (or FontList) for the bullets and placeholder. 2) We need letter spacing, which can be done by making the line advance more each time in |RenderTextHarfBuzz::ShapeRunWithFont|. Bug: 719015 Change-Id: Ie5370e44d767e54264fa2e4ccb02a481063558da Reviewed-on: https://chromium-review.googlesource.com/732526Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#515470}
-
Will Harris authored
This is a reland of bc2056c3 Original change's description: > Change size in memory mapped region to size_t > > Subsequently, remove some static_casts that are no longer needed. > > On Windows, while it is possible to create a file mapping of a file > > 32-bits long it is not possible to create the view to the file > mapping, so changing this to size_t should have no loss of functionality. > > BUG=778316 > > Change-Id: I81cd2e0808794fdb83fc21c796367369ea2da220 > Reviewed-on: https://chromium-review.googlesource.com/755114 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515257} Bug: 778316 Change-Id: I7456feb2e84fc8bf78514d570f868212093500dd Reviewed-on: https://chromium-review.googlesource.com/761408Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#515469}
-
Timothy Loh authored
The durable storage permission is automatically granted or denied based on various heuristics and we never prompt the user for permission. This patch removes this permission from histograms which are only logged for permissions that prompt. Bug: 638076 Change-Id: I7b421f87b5eb2f6fcb0527a90efe1b7908842e4d Reviewed-on: https://chromium-review.googlesource.com/756476Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#515468}
-
Yuwei Huang authored
This CL implements OAuthTokenGetter for Android. This is part of the project of implementing a centralized access token getter in client C++ code, so that multiple components like telemetry logger, ICE config fetcher, and session connector can use the same token fetcher without requesting access token back and forth through JNI. Bug: 780736 Change-Id: I265fe963ef6f9e1720b3a7e3f209704be8686957 Reviewed-on: https://chromium-review.googlesource.com/760184 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#515467}
-
Dave Schuyler authored
This Cl replaces the use of paper-menu in MD extensions with an iron-selector Bug: 779282 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I424fbced792781e1ad2a063ab50ce9a93f156660 Reviewed-on: https://chromium-review.googlesource.com/762107Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#515466}
-
Ian Vollick authored
This reverts commit 053d939f. Reason for revert: Hit testing artifacts. Original change's description: > [vr] Ensure that hit testing uses the same stacking order as rendering > > The rendering code was updated to sort elements in tree rather than > depth order in this cl: > https://chromium-review.googlesource.com/c/chromium/src/+/727342 > > The hit testing code, however, was not similarly updated. Consequently, > there can be discrepancies. This CL updates the hit testing code to > use nearly the same stacking order as rendering. Note: it is not quite > perfect because the ui renderer still summons swaths of elements from > the scene explicitly. Eventually, the ui renderer will simply sort > and render all elements in the tree and these will be truly identical. > However, until then, this ensures we do use the same element sorting > routines. > > Bug: None > Change-Id: I12483713f19b678aa9a69b91e5d910e408b73007 > Reviewed-on: https://chromium-review.googlesource.com/754554 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#514136} TBR=vollick@chromium.org,mthiesse@chromium.org,cjgrant@chromium.org Change-Id: I920d8ffcb2dc7aad53ed021d272302cad060f083 Reviewed-on: https://chromium-review.googlesource.com/763007 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#515465}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/7501b1c3d110..d2f37d85bd0a $ git log 7501b1c3d..d2f37d85b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icd3eb1e8192a71cd0fb054952b173e7663214bcf Reviewed-on: https://chromium-review.googlesource.com/762065Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#515464}
-
Ian Vollick authored
The following CL caused a regression in DrawFrame wall time (and a progression in self time). https://chromium-review.googlesource.com/c/chromium/src/+/752344 I'd changed how we plumbed the current frame time in VrShellGl and this CL speculatively reverts that change. TBR=klausw@chromium.org,mthiesse@chromium.org Bug: None Change-Id: Ie89dfcf515b0c87614bcdeb27a3d87c21ffc83f4 Reviewed-on: https://chromium-review.googlesource.com/763047Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#515463}
-
Yuly Novikov authored
Also build angle_perftests on Android builders BUG=675997 TBR=eyaich@chromium.org,dpranke@chromium.org Change-Id: I9e73e19599e3cc435f02960839f2e780402d0188 Reviewed-on: https://chromium-review.googlesource.com/752582 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#515462}
-
Chris Harrelson authored
Going to see if this reduces the crash rate on Windows. TBR=pdr@chromium.org Bug: 781301 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I87df512006b5a71e8ab82b918662e4cdc5eb27b9 Reviewed-on: https://chromium-review.googlesource.com/762338Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#515461}
-
Giovanni Ortuño Urquidi authored
Rather than navigating to a third party website that probably has no way to get back to the original app, we bounce back to an existing browser window. Bug: 772803 Change-Id: Ie662bfa59e920d059ade3cc06d77664732ab31fe Reviewed-on: https://chromium-review.googlesource.com/706882 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#515460}
-
Shivani Sharma authored
Since multiple transactions can now be added to Writers, those transactions will have a WRITE bit set. Thus remove the DCHECKS that assume otherwise in HttpCache::DoneWithResponseHeaders. Bug: 750725 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I791177522956ca23d6702254bbf7ee0b25c83bdf Reviewed-on: https://chromium-review.googlesource.com/760540Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#515459}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/14592920..c8bfcb14 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic25a1925dc5146416f56a0af3b0e4771620d8384 Reviewed-on: https://chromium-review.googlesource.com/762576Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#515458}
-
Luciano Pacheco authored
Add named arguments to "bool" arguments with default values for readability, as identified by the following command: $ git ls-files | grep -E '*\.(h)$' | xargs egrep --color \ "bool = (false|true)" Also update the unnamed double argument in the transform include file, IdentityTransformOperation.h Bug: 781101 Change-Id: I7cd541b1329063805c60b3ee86247d494f8793b4 Reviewed-on: https://chromium-review.googlesource.com/759272Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Chris Watkins <watk@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#515457}
-
Lily Houghton authored
This adds a CronetMetricsDelegate interface, as well as addMetricsDelegate and removeMetricsDelegate methods, which are used to register/unregister metrics callbacks. Currently the callback is never actually called; this is simply defining the interface and registration methods. Bug: 702796 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0a3933bf623265d675e3a10ef5ed25149c89e101 Reviewed-on: https://chromium-review.googlesource.com/748819 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#515456}
-
Yoshifumi Inoue authored
This patch makes |SelectionModifier| constructors to take |SelectionInDOMTree| instead of |VisibleSelection| since constructors don't need to take |VisibleSelection|, to reduce usage usage of |VisibleSelection| for improving code health. Bug: 657237 Change-Id: Ibe8989566d23530b13bd50d9365da2339051f571 Reviewed-on: https://chromium-review.googlesource.com/760062Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515455}
-
Yuichiro Hanada authored
The cause of the failure was fixed in crrev.com/c/645586. Bug:515596 Test: Run the test 100 times on local machine Change-Id: I64c613b23f3147f5c8cdb69f9c23adb1cb7bff21 Reviewed-on: https://chromium-review.googlesource.com/667556 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#515454}
-
Kunihiko Sakamoto authored
This fixes a bug where @font-face with font-display: optional causes unnecessary font downloads of subsequent sources when the first source fails to download by the "short time limit" (100ms). Bug: 770978 Change-Id: I24ad7c803d04b9eb310b6b916c999660a23c61b5 Reviewed-on: https://chromium-review.googlesource.com/760137Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#515453}
-
Stuart Langley authored
This patch removes the hand crafted implementation of WTF type traits with the versions now available in the std:: type_traits library. The first patch will have the WTF versions use the std:: implementation, a followup patch will remove the WTF versions entirely. This patch replaces the implementations of -> with: WTF::IsCopyAssignable -> std::is_copy_assignable WTF::IsMoveAssignable -> std::is_move_assignable WTF::IsTriviallyCopyAssignable -> std::is_trivially_copy_assignable WTF::IsTriviallyMoveAssignable* -> std::is_trivially_move_assignable WTF::IsDestructible -> std::is_destructible WTF::IsTriviallyDefaultConstructible -> std::is_trivially_default_constructible Bug: 579462 Change-Id: I4ac335929e298f8b28a23021fef8e58ae855f3c6 Reviewed-on: https://chromium-review.googlesource.com/756258 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#515452}
-
Joel Hockey authored
Fixes ICU flush and pivot buffer causing fuzzing error. BUILD.gn updated to not set WIN32_LEAN_AND_MEAN which is defined in libxml. Bug: 722420 Change-Id: Ib4ff2f870f99fb78e02f9841e33f6ad7e72e059e Reviewed-on: https://chromium-review.googlesource.com/759919 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#515451}
-
Findit authored
This reverts commit c4ea951f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 515427 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2M0ZWE5NTFmMzZlYTFjMTk2MGQ1Njk0OTQyZGE5OWMzN2M2ODE3YWYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Mac/34475 Original change's description: > Serialize more of message_center::Notification for mojo. > > Adds NotificationType and (partial) RichNotificationData. Now you can > see progress bars in download item notifications on Chrome OS when > using --enable-features=NativeNotifications > > Bug: 578868 > Change-Id: I781c10387479ed921f0a7b4efce262b18f04844f > Reviewed-on: https://chromium-review.googlesource.com/755317 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515427} Change-Id: I3eac7eb2400781c22fd59c8f6eb7fc2cdd80e1b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 578868 Reviewed-on: https://chromium-review.googlesource.com/762881 Cr-Commit-Position: refs/heads/master@{#515450}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: I4ed482399911f51506d9aea50fbad090c4c22b18 Reviewed-on: https://chromium-review.googlesource.com/762987Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#515449}
-
Tatsuhisa Yamaguchi authored
This is a preparation before enabling the feature by default. Bug: 780688 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4a1bf78085f24289a9e2c8955815ebc6752d95ff Reviewed-on: https://chromium-review.googlesource.com/758279Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#515448}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/9e888a46f04d..ee6884e7be66 $ git log 9e888a46f..ee6884e7b --date=short --no-merges --format='%ad %ae %s' 2017-11-09 geofflang Generate generic error messages for Error objects without messages. Created with: roll-dep src/third_party/angle BUG=783054 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I73a79aab393f4a52c030dde8fb945571e3758f47 Reviewed-on: https://chromium-review.googlesource.com/762519Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515447}
-
Kyle Horimoto authored
This CL changes icons such that: (1) If no networks exist for the network type, a light-grey "0-bar" icon is displayed. (2) If at least one network exists for the network type but none of them are connected, a light-grey icon with an X is displayed. (3) If the network type is disabled, a darker strikethrough icon is displayed. (4) If a network is connecting, the icon is animated. (5) If a network is connected, an icon displaying the signal strength is displayed. Bug: 764110, 672263 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie433e21017bda469da81f7a297f08cf3cd515fd6 Reviewed-on: https://chromium-review.googlesource.com/762598Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#515446}
-
Matt Menke authored
Also convert ChromeMojoProxyResolverFactory to a ProxyResolverFactory. The class now relies on the the proxy service to manage its own lifetime, instead of expecting to be responsible for managing that itself. Bug: 754007 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ifab3624ea083b4e1e00beaa66e274ab8d0656496 Reviewed-on: https://chromium-review.googlesource.com/660723Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#515445}
-
Lily Houghton authored
[Cronet] Define CronetMetrics class implementing the iOS NSURLSessionTaskTransactionMetrics interface This creates a class |CronetMetrics| which provides setters for all of the propeties defined in NSURLSessionTaskTransactionMetrics. Bug: 702796 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icdcc917001c0ceb20107e2f128dba88259330f78 Reviewed-on: https://chromium-review.googlesource.com/744401 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#515444}
-
Patti authored
Extract the BackgroundColorHoverButton from the ProfileChooserView and turn it into a standalone View which is compliant with the Harmony spec. This prepares the HoverButton to be used in the Harmony Page Info bubble view. Notable changes include the blue background changing to a gray one, and some padding changes. Screenshot - https://drive.google.com/open?id=1z97-fEe9LTw0BCBpIMZj9-ft34UYXMGa Bug: 535074 Change-Id: Idd964d17868a7057d5c18b1b96c6d150b7a6d866 Reviewed-on: https://chromium-review.googlesource.com/730031 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#515443}
-
Gregory Chatzinoff authored
Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I11e058b4dbb86a547ffbb7d96fd5c11286ec80d2 Reviewed-on: https://chromium-review.googlesource.com/759141Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#515442}
-
Jay Civelli authored
Making the SafeArchiveAnalyzer interface part of the Chrome file_util service. Moving the associated calling classes, SandboxedZipAnalyzer and SandboxedDmgAnalyzer to chrome/services/file_util/public/cpp, making them the client library to the service. The unit-tests have been moved as well. Bug: 781072 Change-Id: I2947ca13742baef85ab4f9d539f743ea427c883e Reviewed-on: https://chromium-review.googlesource.com/752555 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#515441}
-
Shivani Sharma authored
Bug: 472740 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I959c0e461b1388ab3d812569ca90be3b68571098 Reviewed-on: https://chromium-review.googlesource.com/738531 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515440}
-
Daniel Cheng authored
Bug: 780139 Change-Id: Ie67187ba0ee59a87a50dd18df36e5ae38082184f Reviewed-on: https://chromium-review.googlesource.com/755526Reviewed-by:
Dimitri Glazkov <dglazkov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#515439}
-
Darren Shen authored
This patch adds some tests for serialization of style values constructed from the IDL. Tests for the following classes were added: - CSSKeywordValue - CSSUnitValue - CSSPositionValue There's currently three types of serialization [1]. We are testing the second case ("the value was constructed using an IDL constructor"). Along with testing the IDL constructor, we also test what happens when we obtain a CSSStyleValue from a DOMString or CSSOM (case 1 and 3) and modify it using IDL setters. Currently our code will trivially pass this test, but it'll be harder when we implement all three serialization types, as the style value needs to remember whether which case it belongs to. There's a failing test due to the fact that we haven't implemented normalization of <position> values. Bug: 782103, 774887 Change-Id: I4a379dcb51ea718642e6889f9c0b63bf0bc7d60c Reviewed-on: https://chromium-review.googlesource.com/759407Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#515438}
-
Tom Anderson authored
BUG=782028 R=sky@chromium.org Change-Id: Idc91012a8cd8d851f85d6c45d81677354f05364e Reviewed-on: https://chromium-review.googlesource.com/759100 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#515437}
-
Weidong Guo authored
Changes: Remove the Caps Lock modifier for key event when Caps Lock key is remapped to another key. BUG=782572 TEST=EventRewriterTest.TestRewriteCapsLock Change-Id: I561931034acb94719750f9c70f7b8feb6cee5219 Reviewed-on: https://chromium-review.googlesource.com/759816Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#515436}
-
Joel Einbinder authored
These were accidentally removed in crrev.com/512716 and broke C++ syntax highlighting. Change-Id: Ic86ad294792aa2b1f11c5e40812ebefd07f3b6de Reviewed-on: https://chromium-review.googlesource.com/762103Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#515435}
-
Brett Wilson authored
Creates a new view for rendering the experimental tab strip and tabs. The experimental tabs use rendering code copied from the regular tab strip. Currently it's pretty broken but new tabs do show up and the title updates. No mouse events are supported. This is really a skeleton for future additions. Minor C++11 improvements to TabStripImpl. Also fixes a model dialog initialization crash with the experimental tab strip. Bug: 778461, 780932 Change-Id: Icba2048e8f5abb3b10907456d7f093e4074a8cad Reviewed-on: https://chromium-review.googlesource.com/755623Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#515434}
-
Chris Mumford authored
Instead of moving std::unique_ptr<std::vector<ServiceWorkerResponse>> am now moving std::vector<ServiceWorkerResponse>. This reduces heap use and fragmentation. Bug: None Change-Id: Ia0ee309eecd6d5603bd3b5bdf6a522b0b74d6d1a Reviewed-on: https://chromium-review.googlesource.com/762076Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#515433}
-
Xianzhu Wang authored
In the following case: Parent layer paint chunk property scope Parent layer background <-- chunk1 Negative z-index layers Child layer paint chunk property scope <-- chunk2 ... Parent layer foreground <-- chunk3 ... previously chunk3 didn't have an Id because of no dedicated paint chunk property scope associated with it. We couldn't use chunk1's id because that would cause duplicated ids for chunk1 and chunk3. For the case we used the id of the first display item in the chunk as the chunk id. This caused unnecessary full layer raster invalidation for some layout tests e.g paint/invalidation/css-grid-layout/grid-item-z-index-change-repaint.html, before repaintTest, there is only one chunk for HTML. Then a layer gets a negative z-index, causing a no-id chunk after the negative z-index layer chunk. PaintController sees that the HTML chunk disappeared, and a no-id chunk appeared, and invalidates the whole HTML layer. Actually the no-id chunk contains most of the content of the original HTML layer, and we just need to invalidate the changed part. Now always give chunk1 and chunk3 dedicated chunks with meaningful ids. In the top example, now we give chunk1 Id(layer, kLayerChunkBackground) and chunk3 Id(layer, kLayerChunkForeground). Bug: 771643 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic1a304b84a007d86a8f3e4d48a2bd45b98c05879 Reviewed-on: https://chromium-review.googlesource.com/756339Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#515432}
-
chrome://interventions-internalsThanh Le authored
Since the log type already indicate whether the message is a navigation or a decision made, there is no need to put that in the description. Bug: 764419 Change-Id: I869173fb7c14a98de633bf006754819e350ebbc5 Reviewed-on: https://chromium-review.googlesource.com/762406Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Thanh Le <thanhdle@chromium.org> Cr-Commit-Position: refs/heads/master@{#515431}
-