- 24 Mar, 2018 2 commits
-
-
Evangelos Foutras authored
Ensure ICU symbols have public visibility and are thus excluded from CFI checks and whole-program optimization. The former caused a startup crash and the latter has the potential to break virtual calls in weird ways. BUG=822820 Change-Id: Ia809eefcb9e93b3c612f2381d394db83bbc67120 Reviewed-on: https://chromium-review.googlesource.com/978008Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#545638}
-
Jialiu Lin authored
Bug: 825268 Change-Id: I575c9600b2989fbedc78bfa38f4888b8aec8965d Reviewed-on: https://chromium-review.googlesource.com/978505 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#545637}
-
- 23 Mar, 2018 38 commits
-
-
wutao authored
KeycodeConverter::DomKeyToKeyString cannot show correct string if the dom_key has no mapping. This cl handles this corner case to display alternative string in Keyboard Shortcut Helper (KSV). Bug: 824495 Test: On device with Swedish keyboard layout. Change-Id: I3c54941b89ce34244c8b69d4a905cb1ddbdffb11 Reviewed-on: https://chromium-review.googlesource.com/974474 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#545636}
-
Sammie Quon authored
Test: manual Bug: 824868 Change-Id: I9d008311447215bce541a7c294b451470a0c5aac Reviewed-on: https://chromium-review.googlesource.com/978451Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#545635}
-
Daniel Cheng authored
Update the IPC owners checks to skip files that don't parse. This is OK since invalid JSON already triggers a separate presubmit error. Once the error is fixed, subsequent presubmit runs will verify that IPC owners are correctly set. Bug: 825053 Change-Id: I2295901bf706c1a62ebee3710c5d87e415bd011a Reviewed-on: https://chromium-review.googlesource.com/978611Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#545634}
-
Ahmed Fakhry authored
The header of a browser window snapped in SplitView mode should use the same height as that of a maximized browser window header. This is true for both touchable and non-touchable chrome. This bug became more obvious with touchable chrome since the header height is much bigger. BUG=823371 TEST=Added test that would fail without the fix Change-Id: Ica52701338b4fdf94582392bbebbbdfc96328433 Reviewed-on: https://chromium-review.googlesource.com/969585 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#545633}
-
Tommy Steimel authored
This CL adds a check in the overlay play button double-click code to make sure the user should be able to toggle fullscreen before actually toggling. Bug: 823476 Change-Id: I8d61292516ed4b385f732f9259ed262b4685a314 Reviewed-on: https://chromium-review.googlesource.com/972347 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#545632}
-
Matt Mueller authored
Change-Id: If6d42457b8d40040ef09695eaf8197b06fd99575 Reviewed-on: https://chromium-review.googlesource.com/967322 Commit-Queue: Nathan Parker <nparker@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#545631}
-
Peter Boström authored
This separator isn't called for in either the touchable spec or MD refresh. Bug: None Change-Id: I99a1c3ddd1d478aec6258426f4c6a9865cd7eadf Reviewed-on: https://chromium-review.googlesource.com/978879 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#545630}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/31a3eb064ea3..a03592f3d2e2 $ git log 31a3eb064..a03592f3d --date=short --no-merges --format='%ad %ae %s' 2018-03-21 jrbarnette Add a 'kevin-full' builder. Created with: roll-dep src/third_party/chromite BUG=chromium:817547 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0b7823460c8221ea9655914f3f6aeb11fbe6e8c3 Reviewed-on: https://chromium-review.googlesource.com/978880Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545629}
-
https://chromium.googlesource.com/angle/angle.git/+log/49cef9a52181..ad4f9642a655 $ git log 49cef9a52..ad4f9642a --date=short --no-merges --format='%ad %ae %s' 2018-02-08 ynovikov Allow ANGLE libs to have arbitrary suffix. 2018-03-22 lucferron Vulkan: Depth / stencil attachments bug fixes 2018-03-23 oetuaho Increment ANGLE_SH_VERSION Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I14c42f835b942abbdea348eb66cea440d34a6098 Reviewed-on: https://chromium-review.googlesource.com/978885 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545628}
-
Devlin Cronin authored
Manifest v1 had an "inIncognitoTab" on the chrome.extension API object property instead of the new "inIncognitoContext". Remove support for this fully (and update a stale reference). Bug: 816677 Change-Id: I4cefe0359ff3c4cae0df06b467c5628f6cd27fc6 Reviewed-on: https://chromium-review.googlesource.com/973542Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545627}
-
Conley Owens authored
This change adds a boolean `was_cached` to the SubresourceLoadInfo struct. This lets consumers know whether or not the response was fetched from the network cache. Notably, this is important for recording page load metrics when the Network Service is enabled. This reverts commit 0b2b1a92. Issues in the previous commit are fixed by retaining the exists_in_cache field. In a many cases when NavigationURLLoaderDelegate::OnRequestFailed() is called, NavigationURLLoaderNetworkService::OnResponseStarted() has not been called. In these cases, we cannot rely on using a stored was_cached value, since it may not be properly updated. BUG=816684,822237 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I0beb72b825ae0a12122170cec2e4f4358dda58af Reviewed-on: https://chromium-review.googlesource.com/966792Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#545626}
-
Yuly Novikov authored
conformance/extensions/oes-texture-float-with-video.html on Win Intel TBR=kbr@chromium.org BUG=825338 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2b3116e48264c503b034d1230f24555a639858db Reviewed-on: https://chromium-review.googlesource.com/978038 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#545625}
-
Kevin Bailey authored
Primarily adds 2 fields to the Omnibox event proto, but also makes tiny changes to other protos to bring them up to date with the master copies. About the 2 new fields: The first indicates whether the autocomplete match also advertised that a tab switch suggestion was present. i.e. whether the URL was already open in another tab. The second indicates whether the user selected the tab switch option (or whether they chose to navigate). Tab switch suggestion is orthogonal from the suggestion type because most any suggestion can have its URL be present in another tab. Additionally we wish to know the original type in order to give credit to that provider. We wish to know whether the user selected the tab switch option to gauge whether the indication for the tab switch option was obvious enough, and clear enough (if it was noticed). Bug: 780835 Change-Id: Ib4e8af9275283fe0eac3c7734e1647a4b2c0a133 Reviewed-on: https://chromium-review.googlesource.com/977047 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#545624}
-
Istiaque Ahmed authored
This will allow ContentHash caching to be (trivially) implemented in the future in ContentVerifier::GetContentHash(). This CL also makes extension load at startup to queue all inflight requests to load verified_contents and computed_hashes reading from disk. This is because inflight requests will be served by single file read. Summary of changes: The primary method is ContentVerifier::GetContentHash(). This method is responsible for retrieving ContentHash on IO thread. It uses ContentVerifier::HashHelper to manage thread hops and such. HashHelper is not thread safe and it uses static method + weak pointers to safely call ContentHash methods on blocking thread. ContentHash class is responsible for fetching verified_contents.json from network, using ContentHashFetcher. ContentHashFetcher manages its own lifetime and is no longer ref-counted. Also, ContentHashFetcherJob is no longer required. ContentHashFetcher is currently an implementation detail of ContentHash, and can be further restricted so that it cannot be instantiated outside of ContentHash. Because of async nature requirement of net fetch, ContentHash::Create is now async. Since ContentHash instance can travel between sequences, they are RefCountedThreadSafe now. ContentVerifier::VerifyFailed used to be (also) called when we fail to retrieve hashes on disk and it would fall back to ContentHashFetcher for fetching the hashes. As GetContentHash currently takes care of this through ContentHash::Create, ContentVerifier is only made aware of failures on when hash mismatch occurs, simplifying things further. Bug: 796395 Change-Id: I7eb6bf93daba908258ae604a8cd45ea643b4e00d Reviewed-on: https://chromium-review.googlesource.com/933863 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545623}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/728244f70a8b..0d9ecc925d38 $ git log 728244f70..0d9ecc925 --date=short --no-merges --format='%ad %ae %s' 2018-03-23 ehmaldonado Reland "gclient eval: Expand vars while parsing DEPS files" 2018-03-23 sergiyb Correct documentation for the --no-referenced-issues argument 2018-03-23 iannucci Clear $VPYTHON_CLEAR_PYTHONPATH when setting $PYTHONPATH. Created with: roll-dep src/third_party/depot_tools BUG=chromium:821199,chromium:825290,chromium:825174 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I58cbb0ca469176bb99a5a86d7504c986fa9b162b Reviewed-on: https://chromium-review.googlesource.com/978865 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545622}
-
Tao Bai authored
Bug: 825248 Change-Id: I5bb5bbe2b7dd0e147d409ce6074ae6adab2dd14d Reviewed-on: https://chromium-review.googlesource.com/978883Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#545621}
-
Reilly Grant authored
This change wraps strong references to libusb_device objects in a ScopedLibusbDevice class (specializing ScopedGeneric) in order to better document when these references are expected to be dropped. Bug: 819356 Change-Id: I9671d340f0d5353637405ddd72846456e23a5f1f Reviewed-on: https://chromium-review.googlesource.com/972623Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#545620}
-
Qiang Xu authored
changes: - Fix regression from crrev.com/1972033002. - Rename multi_user_window_manager_test.h to multi_user_window_manager_test.h. Bug: 766834 Test: manual test and added test coverage Change-Id: I08d9beca388bf71eecb19f9c7b6412c6f8157365 Reviewed-on: https://chromium-review.googlesource.com/977040 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#545619}
-
Carlos Knippschild authored
With this change version checking will also ignore the line from the version string that presents the local installation path for adb. Change-Id: Ie7a3b26965b1d94d6d269f1b4b0919468d8eea2c Reviewed-on: https://chromium-review.googlesource.com/978775Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#545618}
-
Scott Chen authored
After this CL, when the unified-consent feature is enabled, user will see a "sync and personalization" row instead of a "sync" row with status icon. This "sync and personalization" row will be present even when the user's not signed in yet, and will open the /syncSetup subpage even when the user is not signed in. This change DOES apply to CrOS if the unified-consent feature is enabled. if the unified-consent feature is not enabled, there should be no user-perceivable changes. ** The content of the sync subpage while non-signed-in is still WIP so it will be a bit wonky (there will be follow-up CLs to complete this work before unified-consent launches). Screenshots + captions: https://imgur.com/a/Usx6z Bug: 800972 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3bbbf4e5b55eb25116d19d0f959a549116dce3d2 Reviewed-on: https://chromium-review.googlesource.com/974476Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545617}
-
Matt Menke authored
ResourceDispatcherHost pushes pending load state of all frames to the UI thread once every 250 milliseconds when there's a pending load. This happens even when the UI thread is blocked. Apparently it's causing an OOM when the UI thread is blocked. Whatever is blocking the UI thread is another issue entirely, but we shouldn't use unbounded memory in the browser process. This CL prevents load state updates from being sent until the previous set was ACKed by the UI thread. Bug: 824869 TBR: jam@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I3b68522c5281d477d3a621ac02e5df1f75153d99 Reviewed-on: https://chromium-review.googlesource.com/978383 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#545616}
-
wutao authored
This cl puts the focus on the search box when Keyboard Shortcut Viewer (KSV): 1. The first time the window is created. 2. Every time it exits search mode by Esc or back arrow. Bug: 822333 Test: manual test. Change-Id: Ia0fdeb744e3090d246769aee58c9ee42d58e14e5 Reviewed-on: https://chromium-review.googlesource.com/978784Reviewed-by:
Qiang Xu <warx@google.com> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#545615}
-
Matt Menke authored
The system ProxyConfigService is now created on Chrome's UI thread, so the references were outdated. Also, net/ really shouldn't know about content/'s threads. Bug: 823063 Change-Id: I399bdc13fa46b89f45111cafb393e2c9cd735bdd Reviewed-on: https://chromium-review.googlesource.com/978386 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#545614}
-
Yuly Novikov authored
TBR=kbr@chromium.org BUG=675997 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I688e9e0987a3359c904f3be9ff1cd4f26efc4d1d Reviewed-on: https://chromium-review.googlesource.com/978627 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
-
Xida Chen authored
At this moment, this is how we check whether an animation is main thread compositable or not: 1. The runtime feature TurnOff2DAndOpacityCompositorAnimationsEnabled is on 2. There is either an opacity or 2d transform animation There is a problem with this logic. When there is an opacity animation on an element and the element has "will-change: transform", we will put this animation as main thread compositable. This is not true, we should categorize it as composited animation because "will-change: transform" will create a layer anyways. This CL fixes this problem. We care about the most common cases: "will-change: transform" and 3D transform. So step 2 in the above becomes: when there is no "will-change: transform" and there is no 3D transform, and there is either opacity or 2D transform, then this is a main thread compositable animation. This CL also added a test to verify that an element with "will-change: transform" + opacity animation will end up having a composited animation even when the runtime feature is on. Bug: 818809 Change-Id: Ifcd027223df96c17447955eb52568d74bb5505ff Reviewed-on: https://chromium-review.googlesource.com/951719 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#545612}
-
Charlie Harrison authored
Before PlzNavigate, we needed this because BLOCK_REQUEST_AND_COLLAPSE was only supported at navigation start. Now, it is unused. Bug: None Change-Id: Icb9274ed41283afafb73b32ab72d1389a4ed5dd0 Reviewed-on: https://chromium-review.googlesource.com/978391Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#545611}
-
Stephen Kyle authored
Certain telemetry benchmarks in tools/perf don't use the default telemetry mechanism for handling commandline arguments. As such, we reimplement the handling of --enable-systrace in each case. This covers: smoothness.* blink_perf.* thread_times.* Change-Id: I276f7ab96d8a17bd9f053b6159c26b0224055b6d Bug: catapult:#3504 Reviewed-on: https://chromium-review.googlesource.com/978122Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#545610}
-
liberato@chromium.org authored
Previously, MCVD destroyed the textures that back the VideoFrames when MCVD was destroyed. When the pipeline suspends, this causes any VideoFrame to become undrawable. This CL adds TexturePool, which holds references to the textures until all VideoFrames are destroyed. While the implementation isn't exactly a pool, we will be adding pool functionality to it shortly. This CL also introduces a wrapper for GL command buffer stubs, to allow for easier testing. Similarly, this CL adds a wrapper around TextureRef. Bug: 737220 Test: TexturePoolTest Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3d9bd42b9f8d3782b3eb4ceca30388774dc4854b Reviewed-on: https://chromium-review.googlesource.com/966782 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#545609}
-
Yue Li authored
Bug: 820255 Test: Manual Change-Id: Id7d63099b36f2b59c2389c539c5b433dd14c0b65 Reviewed-on: https://chromium-review.googlesource.com/978660Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#545608}
-
Filip Gorski authored
This patch only changes how files are built and target name. Change-Id: Ifbeec1a862208db183c2dd8107df7bab43f70c76 Reviewed-on: https://chromium-review.googlesource.com/978846 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@google.com> Cr-Commit-Position: refs/heads/master@{#545607}
-
Chris Harrelson authored
PLC::CollectFragments includes fragmentation offset if called in GeometryMapper mode. However, when hit testing under transform, we apply fragmentation and transform, then hit test each fragment without any fragmentation or transform offset. Therefore, in this post-fragment/transform mode, don't apply fragmentation offset again. The callsites in PaintLayerPainter for the equivalent situation during paint already correctly pass an empty LayoutPoint offset for layer bounds. Bug: 823255 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3135e51b72c5fd02a9d67b3dcbdc51e39ef3cde2 Reviewed-on: https://chromium-review.googlesource.com/978675Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#545606}
-
Kevin Marshall authored
A previous CL regressed this behavior, leading to the generated runner being generated with absolute paths in the buildbot's filesystem. Change-Id: I16aaca1556c9f8eccc81d3cdd841b4a3c71de3f2 Reviewed-on: https://chromium-review.googlesource.com/978639Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#545605}
-
Abhishek Arya authored
Use base::StringPiece in cases where caller expects input in std: :string is null terminated whereas base::StringPiece is not. base: :StringPiece as it helps to catch for overflow cases. Change-Id: I0c70d1f8c40fc5f0e826ced5073f563bc74d1d80 Reviewed-on: https://chromium-review.googlesource.com/978036 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
-
Fredrik Hubinette authored
VP8 has no color space information apart from full range / limited range. However, because of a comment in the VP8 spec that says that vp8 content is "like bt601", ffmpeg sets the matrix to SMPTE470BG. When we assign the color space to the video frame we default the other parameters to BT709, leading to a color space like: { primaries=BT709, transfer=BT709, matrix=SMPTE470BG, range=Limited } This mix of color spaces is is clearly wrong. This fix works around the ffmpeg behavior and leaves the color space completely unset when this happens. Unset color spaces defaults to BT709 later on, which is probably what we weant. Full-range content gets a JPEG color space. Bug: 754986 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I04694e949d211b134312ade01555fa1954a82bad Reviewed-on: https://chromium-review.googlesource.com/912436 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#545603}
-
Erik Chen authored
This is required to correctly perform accounting of shared memory on macOS. Bug: 823915 Change-Id: I75a3bc4951e38bc24cc8c2b7867cfdd952fb860d Reviewed-on: https://chromium-review.googlesource.com/974443Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545602}
-
David Jacobo authored
This one-liner is to make this UI looks like the spec, also the other bubbles on the omnibox doesn't have a visible arrow. Bug: None. Test: Build, also on an ARC device enabled poked around with pinterest. Change-Id: Iad9913d68d86b9a276f793b5a34962644c836344 Reviewed-on: https://chromium-review.googlesource.com/978671Reviewed-by:
-
Alexey Kozyatinskiy authored
TBR=pfeldman@chromium.org Bug: chromium:825349 Change-Id: I70390a29c684afa69555b14aa20b96345d5ce1e3 Reviewed-on: https://chromium-review.googlesource.com/978844Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#545600}
-
Jonathan Metzman authored
TBR=inferno@chromium.org Change-Id: I0aa9a1a30dba80b064b0fcb59598d69def1f8071 Reviewed-on: https://chromium-review.googlesource.com/978866 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#545599}
-
