- 18 Sep, 2019 30 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0033008d95ac..f3c4a829c64f git log 0033008d95ac..f3c4a829c64f --date=short --no-merges --format='%ad %ae %s' 2019-09-17 herb@google.com SkZip - synchronized indexing of several pointers 2019-09-17 ethannicholas@google.com fixed an SkSL parse issue Created with: gclient setdep -r src/third_party/skia@f3c4a829c64f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: Ic317422d5ac6ab9553cd2907a7f221ab36da57f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810001Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697435}
-
chrome://bluetooth-internalsKyle Horimoto authored
If supported, this toggle is displayed in a new tab named "Debug Logs", and when the toggle's value is changed, BluetoothInternalsHandler::ChangeDebugLogsState() is invoked. In this context, the toggle is only supported if the associated flag is enabled and if the primary account is a Googler's corp account. Bug: 1004572 Change-Id: I2fd7a3a34d95cf5f642c6525a22d84245d81084b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804683Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#697434}
-
Nick Diego Yamane authored
This is a reland of a798c106 Original change's description: > Get rid of native event (i.e: XEvent) usage in libgtkui > > Get rid of native event (i.e: XEvent) usage when translating ui::KeyEvent into > GdkEvent in GtkUi GdkKeyBindingsHandler and InputMethod context implementation. > Native event usage outside platform code is undesired and blocks changes such > as Aura/X11 => Ozone/X11 migration (e.g: PlatformEvent migration > crbug.com/965991). > > It is worth noting that aura IME code has been slightly modified to set root > window as Event::target() during the PRE_DISPATCH phase (for some reason > InputMethodContext::DispatchKeyEvent() is called at this phase) so that IME > context implementation is then able to retrieve the X11 Window id, needed by > GdkEvent system. > > To be able to retrieve XEvent group field in gtkui code, an Event::Property has > been added and for now is set only for non-ozone X11. Ozone/X11 will be > addressed in a follow-up CL. > > Rationale: > https://docs.google.com/document/d/1Neh2p6f8pew9SPuEAtnJMafozAY7uhAIfhwd43CLETc/edit?usp=sharing > > Bug: 965991, 987939 > Change-Id: I64929d6866c1dfcfddbfe75166a1bad139c2da8d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789603 > Commit-Queue: Nick Yamane <nickdiego@igalia.com> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695827} Bug: 965991, 987939 Change-Id: I921805b73cd9c55d1e069026091f0526d242b9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805156Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#697433}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95dfac5bc324..bbd0b15a0667 Created with: gclient setdep -r src-internal@bbd0b15a0667 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:1004848,chromium:None,chromium:None Change-Id: I4453e1c97d0922f17ab100bf556594a83b200347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809552Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697432}
-
rbpotter authored
Bug: 1001958 Change-Id: I1c90122d4bc43ae9fb073d78ffad5b5516689cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809667Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#697431}
-
Julie Jeongeun Kim authored
This CL converts GeneralAudienceBrowsingAPIKeyObserver and GeneralAudienceBrowsingAPIKeyObserver to new Mojo types. It uses PendingRemote, Remote, Receiver and PendingReceiver and also updates GeneralAudienceBrowsingAPIKeySubject from general_audience_browsing.mojom. Bug: 955171 Change-Id: I277c3e5722012bf72d005dd6d6797d35aed4ad5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803944Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#697430}
-
Bo Liu authored
Implement the animation demo using webview behind a compile time variable. There is no url bar. Useful for comparison purpose. Duplicates a bunch of code, which is ok assuming demo will not be long lived. Change-Id: I2280255e4d5f546afe1f7c5d054474d228cafe0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809623Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697429}
-
Johannes Henkel authored
This is as a debugging aid, to rule out that we're calling io_session_->DeleteSoon twice from this method, for some reason. Bug: 1004684 Change-Id: I13192c75a884f824c7d6ffd92cd17b834a34db6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809999 Commit-Queue: Johannes Henkel <johannes@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#697428}
-
Istiaque Ahmed authored
Extension service workers pause evaluation if the corresponding extension hasn't loaded yet (ExtensionMsg_OnLoaded). However while deciding whether to pause an evaluation, the underlying registry (RendererExtensionRegistry) can change as more extensions can continue to load within GetExtensionOrAppByURL and GetExtensionOrAppIDByURL from DidInitializeServiceWorkerContextOnWorkerThread. Fix this by moving the two accesses to RendererThreadRegistry using the existing single lock. hundred times. Bug: 1004833 Test: Locally by running ServiceWorkerTest.Update(un)PackedExtension few Change-Id: I9830462502e44eb4af7bb46e6f74f2ecc39a65bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809597 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#697427}
-
Jeevan Shikaram authored
App Serice updates are issued as delta of changes. This means that every app update will not have the ShowInManagement field. This causes every app update to be sent to the App Management front end. This CL ignores any app updates to apps that are not already in App Management. Adding new apps is unaffected. Bug: 1002233 Change-Id: Ie2d674238a2d43d167c54f45c78bdb9060a770e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807650Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#697426}
-
Gyuyoung Kim authored
This CL applies mojo::Receiver to |client_receiver_| member variable. Bug: 955171, 978694 Change-Id: I6c473edc4cb46d2e92c6dd0e6a3b8a9343b2f978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808658Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/65a5036eb041..a7003d5fc306 git log 65a5036eb041..a7003d5fc306 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 j.vigil@samsung.com Reland "EGL: Implement EGL_KHR_no_config_context" Created with: gclient setdep -r src/third_party/angle@a7003d5fc306 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: I72622515287957637f154aa7a2364248dae87c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809614Reviewed-by:
-
Joel Hockey authored
Ensure route for /crostini/exportImport is not added when backup and restore is disabled by policy. Bug: 1003944 Change-Id: I9c88d038e928948e5bea2363592612097bf42d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809122Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#697423}
-
Weiliang Chen authored
Video smoothness regressed and bisect to previous CL. Since most of that CL is yet to be used, the suspect change is when NotifyPromotionHint is called for ScheduleOverlay. Change the behavior back in attempt to fix video smoothness regression. TBR=liberato Bug: 1004859 Change-Id: I2e32dbc7c38c56e443fffb69721995481ffbaf2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810000Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#697422}
-
Dale Curtis authored
During the changes made for preload=metadata suspend, it was assumed that OnBufferingHaveEnough() had no lingering effects after the next call to MediaIsPlaying(). It turns out this was not true. The method would only clear |cancel_upon_defer_| the first time. The fix is to always clear |cancel_upon_defer_| once the DataSource has been informed of playback. A new unittest verifies this. BUG=1004530 TEST=new unittest, clip from bug does not create more than 1 loader after a seek from the suspended state. R=tguilbert Change-Id: I7655d7ff0ee0ba1024ec0486331d84aeda16918c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807160 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#697421}
-
Ahmed Fakhry authored
- The UMA of color temperatures should only be reported when the user makes changes to it, not whenever we refresh the values on the displays. - The Reported temperature UMA should use the value set by the user, not the effective value we set on the displays (which overrides the user's value to 0 when NL is off). - Fix a bug that caused temperature value of 1.f (100%) to go out of bounds of the UMA range. - Do not animate the temperature if the new value doesn't change the current one. BUG=997931 Change-Id: Ic087cad6901b8d4d8ec56815b48e4afc5b8d66cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808809 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#697420}
-
Jazz Xu authored
Bug: 1003450 Change-Id: I5a7a601442cc1d58ba0510f306f76369685f4cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797249 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#697419}
-
Taylor Bergquist authored
When tabs are laid out, some of their widths are rounded down and some rounded up in order to make the sum of their widths exactly equal the available width. This change remembers how many tabs were rounded up in order to ensure that there is no teleportation when the tabstrip enters closing mode. Bug: 958173 Change-Id: I6f239b93531854860737c99c5194a7deaf1b95fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796305 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#697418}
-
Julie Jeongeun Kim authored
This CL converts PasswordManagerDriverAssociatedRequest and PasswordManagerDriverPtr to new Mojo types. It uses PendingReceiver, PendingAssociatedReceiver and Receiver instead of PasswordManagerDriverAssociatedRequest PasswordManagerDriverAssociatedRequest and Binding. Bug: 955171 Change-Id: Ied592687400614e480750dd4e056446bb1ad5e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808937Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Robert Liao authored
BUG=897377 TBR=sky@chromium.org Change-Id: I39a05ebd74bc766f1d54dab54decb518c23294fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809553Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#697416}
-
Lily Chen authored
This adds a histogram that logs whether a cookie's SameSite attribute is present, and if so, whether its attribute value is empty, unrecognized, or one of the currently recognized values. Bug: 993120 Change-Id: I4bf3d86cd58e4a60975eee76e192331bcfa51e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803762Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#697415}
-
Matt Simmons authored
Extend the existing impl rather than reimplementing SuggestionsUiDelegate. Bug: 1004609 Change-Id: I6b79967c925be304dcaf93ceb8c65942ce34fecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808787 Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#697414}
-
Jason Lin authored
Bug: 929571 Test: Turn on flag crostini-webui-installer and install crostini from settings Change-Id: I78895c2a84800d87d4e885e4bc35195d2329db74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798072Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7fd753567d3c..384489020136 git log 7fd753567d3c..384489020136 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 lamontjones@chromium.org paygen: use image_lib.LoopbackPartitions Created with: gclient setdep -r src/third_party/chromite@384489020136 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I511d73776128c1edf247afdebc101eb2d8851ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809917Reviewed-by:
-
Daniel Rubery authored
For WebProtect real time reporting, we would prefer to report dangerous downloads when the warning is seen, and when the warning is dismissed, rather than when the file is opened from within Chrome. This CL adds real time events for dangerous download warnings seen and bypassed, and removes the events for dangerous downloads opened. Bug: 1002976 Change-Id: Ic736390bf8db5fb88bc2b2b68ce824c09d159b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802524 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#697411}
-
Hirokazu Honda authored
We set mb_skip_coeff and loop_filter_adj_enable to 1 in crrev.com/c/1773662. They are mainly for a workaround that some decoders shows artifacts with the VP8 stream produced by an intel encoder. After some investigations, it turns out they are a proper fix. This CL updates the reasons in the comment why those parameters are set to 1. no artifact is there Bug: b:139766881, b:138840822 Test: decode VP8 stream produced by Intel encoder on eve and atlas, and confirm Change-Id: I6e4e4425edfd59e9be70680c32786d5a95aa9d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792219Reviewed-by:
Sreerenj Balachandran <sreerenj.balachandran@intel.com> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#697410}
-
Lei Zhang authored
Add browser tests to make sure PdfNupConverterClient works as expected: - 2-up conversion for a 3 page document generates 2 page output. - 4-up conversion for a 3 page document generates 1 page output. - Garbage data input results in a conversion error. Bug: 1004529 Change-Id: Ie31397dc0b9eb9d098763de3395f99bf69846889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808581 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#697409}
-
ssid authored
The threads after startup tracing is cancelled should write to trace writer created by perfetto producer instead of startup registry. This can be done by incrementing the session id when cancelling startup registry. BUG=993799 Change-Id: Ib2ad173a788dd4fe6d3fb563b761c5bc12549fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809918 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#697408}
-
Collin Baker authored
Bug: 1003122 Change-Id: Ic1301579a3eff6a418bf5a8c3cea7d3938fd5085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809411 Commit-Queue: Collin Baker <collinbaker@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#697407}
-
Khushal authored
Make fuzzers happy. R=ericrk@chromium.org Bug: 1001916 Change-Id: I7b0c32848f321171407b9e4fdf6d6cb5cfb0ca3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803959 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#697406}
-
- 17 Sep, 2019 10 commits
-
-
Kyle Milka authored
This was caused by https://crrev.com/c/1805253. Bug: 1004696 Change-Id: I848d28e0ddb4f6ea1ab1cd7eb9df554832f3479e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809401 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#697405}
-
Dirk Pranke authored
Previously run_web_tests implemented an overly simplistic variant of the test runner api documented in bit.ly/chromium-test-runner-api, in that it only supported a single occurrence of the flag, it didn't support negative (skip) filters, and it implemented it as if you had just listed the globs as positional arguments instead. This CL implements the full semantics of the flag, so that you can specify the arg multiple times, and negative (skip) filters work correctly. This is a non-backwards-compatible change, because it changes things such that we first filter by positional arguments and *then* apply the filters from --isolated-script-test-filter. However, it seems unlikely that anyone is using the combination of the two and so hopefully this will not break things. If it does, we'll need to update callers. BUG=994943 Change-Id: I7cc10c92364e145e84f3750f0c773b8ab9d371f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790432Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#697404}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/368d002e489e..86314cfb5dc0 git log 368d002e489e..86314cfb5dc0 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 srte@webrtc.org Cleaning up C++14 move into lambda TODOs. Created with: gclient setdep -r src/third_party/webrtc@86314cfb5dc0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I2e041559aa675ae9d6551b663636c7c58862ae43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808530Reviewed-by:
-
Eric Roman authored
Bug: 1004516 Change-Id: I5c489ce94d9bea9d7b16fd8954008a28f7ddb8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808116Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#697402}
-
Matt Jones authored
With the growing number of bottom sheet users, it no longer makes sense to initialize it based on a list of feature flags. Instead, the bottom sheet is initialized the first time someone queries for the controller. Bug: 986310, 1002277 Change-Id: I61e68a1a89c98f72bfa9ef5e9d75cf6172cd51cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808180Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#697401}
-
Brian Sheedy authored
Switches latency_perftests to use PerfResultReporter instead of PrintResult and whitelists it for conversion to histograms before uploading to the perf dashboard. Shouldn't affect anything on the bots since these tests seem to currently only be used for local testing. Bug: 923564 Change-Id: I0386ad93c65e6bb79928f0f9c4fe4a2d27d9716e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793790Reviewed-by:
-
Marialicia Villarreal Garcia authored
This fix is needed to make touch work in the browser frame when a screen reader is on. It consists in two main parts: 1. Apply the scale factor to the hit point received after touching any element in the frame. 2. Add unit tests for the scale factor. Bug: 990560 Change-Id: I00c3cd4de4ea49e8e8f881eb1db17c6a649b873c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796888 Commit-Queue: Maria Villarreal <mavill@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#697399}
-
David Bienvenu authored
These will be used to register the file extensions the PWA handles in the Windows registry, and set up the shim app, when a PWA is installed, once the Windows-specific code is implemented. Bug: 960245 Change-Id: Id6142b59277c60cb72204c37f086f4df3c0ffb91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797024 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#697398}
-
Nico Weber authored
Revert "win: Pass /libpath: on Windows too, and use /lldignoreenv to make lld ignore the %LIB% env var." This reverts commit 1a693093. Reason for revert: Apparently breaks cross builds: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/yhbrbPU0yLQ Original change's description: > win: Pass /libpath: on Windows too, and use /lldignoreenv to make lld ignore the %LIB% env var. > > See https://reviews.llvm.org/D67456 > > Makes the build a bit more hermetic, and should have no behavior change. > > Bug: none > Change-Id: I90080aa7f8ec814e6ec9b1a4fbcad464e12a450d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807154 > Auto-Submit: Nico Weber <thakis@chromium.org> > Commit-Queue: Reid Kleckner <rnk@chromium.org> > Reviewed-by: Reid Kleckner <rnk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697369} TBR=thakis@chromium.org,rnk@chromium.org Change-Id: Idccc2a0bd54f6543734bf6f24a5cd73bbe0295d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808036Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#697397}
-
Kyle Milka authored
Use CachedMetrics to prevent a crash when notifications are clicked before the native code is loaded. Bug: 994438 Change-Id: Iabe6dffc10c66c719b4af65dea68abfd374e5e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809544Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#697396}
-
