- 07 Apr, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/275e665173c6..852ebea2d55d git log 275e665173c6..852ebea2d55d --date=short --first-parent --format='%ad %ae %s' 2020-04-07 csmartdalton@google.com Reland "Reland "Reland "Reland "Use glDraw.*BaseInstance calls to avoid deferred buffer binding"""" 2020-04-07 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps Created with: gclient setdep -r src/third_party/skia@852ebea2d55d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I5a46266b0c5075299b8b2ead185e0cde6997b10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139251Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756986}
-
Sean Harrison authored
Bug: 1032584 Change-Id: Ic18e3947f11d756f8e6d28b53d380f7cde59d7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133970 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#756985}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f526d777e0b3..c3c6694d8f0f git log f526d777e0b3..c3c6694d8f0f --date=short --first-parent --format='%ad %ae %s' 2020-04-07 cwallez@chromium.org Rename BG[L]Binding to BG[L]Entry Created with: gclient setdep -r src/third_party/dawn@c3c6694d8f0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ifbbbbab40bba512b6ced6672cd09c6b7fdebefe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139129Reviewed-by:
-
Noel Gordon authored
<cr-action-menu> is Polymer3 and so won't be active during a files app unittest framework. Add window.UNIT_TEST guards to prevent the breadcrumb.js unittest from trying to access undefined (in unittest) <cr-action-menu> api. Define window.UNIT_TEST and window.IN_TEST for closure compilation. It seems window.IN_TEST is only closure defined in gallery externs so add these new closure defines to a files app common externs file. Bug: 1061388 Change-Id: Id5c11649f32969d5b1b11cbf30236c80edbc69c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138939Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#756983}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e8697a423557..e29095b1961e git log e8697a423557..e29095b1961e --date=short --first-parent --format='%ad %ae %s' 2020-04-07 mathias@chromium.org Add more countWtf8Bytes unit tests Created with: gclient setdep -r src/third_party/devtools-frontend/src@e29095b1961e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iece6bbc6104073d7b1ba65fcb25a6e4aa4274cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139123Reviewed-by:
-
Dominic Battré authored
This reverts commit 66559848. Reason for revert: broke Cast Linux builder, see https://crbug.com/1066880#c11 Original change's description: > Fix issue with accessibility events on hidden nodes > > This is an issue with AXObjects that are ignored and not > included in the accessibility tree. When we fire an event > on such a node, the serializer owned by > RenderAccessibilityImpl first walks up to find a common > ancestor that is in the tree, and then serializes that > node, even if it was already serialized. It breaks the > mechanism that avoids re-serializing nodes that were > already just serialized. > > In extreme circumstances, this led to a bug where the > size of the AXTreeUpdate for a large table grew to 200MB > for one particular website, even though the resulting > AXTree had only around 2MB worth of data. > > The fix is simple: when a node changes, only fire a > notification on the nearest ancestor that's in the tree. > That way the serializer can avoid redundantly processing > the same node more than once. > > Covered by a new test and a DCHECK that asserts that we > should never get an AXTreeUpdate with more nodes than the > size of the resulting tree. Without the new fix, the test > fails with an AXTreeUpdate containing 1000 nodes with a > tree of size 10. > > Bug: 1066880 > > Change-Id: I247ad6aecaaf45b02371d2dad430b50489a86fa2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134848 > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756970} TBR=dmazzoni@chromium.org,aleventhal@chromium.org,Adam.Ettenberger@microsoft.com Change-Id: I8c28e60d58d4270dd2942de2b1e067c3f390c40e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1066880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138415Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#756981}
-
Matthias Körber authored
Bug: 1065001 Change-Id: If942491a835311080ef5f64f4cce76e3ba64ca67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121267Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#756980}
-
Rune Lillesveen authored
Bug: 1067277 Change-Id: I255b78ea9edece09ceb2c74848dc7a48d2166ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137343Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#756979}
-
Hiroshige Hayashizaki authored
The test is no longer flaky. TBR=battre@chromium.org Bug: 960623 Change-Id: I0a6d3ac4ddd64faf7c4f2b36654e570a0955abcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138995Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#756978}
-
Anastasiia Nikolaienko authored
Bug: 1068231, b/141108534 Change-Id: I263857af7a4e1e0e13eba367b66bbe12bbe6f1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135758Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#756977}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c048306eaf01..bc1001ace1ff git log c048306eaf01..bc1001ace1ff --date=short --first-parent --format='%ad %ae %s' 2020-04-07 dberris@chromium.org Dashboard: Terminate on Permutation Test Convergence Created with: gclient setdep -r src/third_party/catapult@bc1001ace1ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1067589 Tbr: nuskos@google.com Change-Id: If853adf72219b794462d28d2829aa8b8c857333c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139115Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5846ff3c7ae0..275e665173c6 git log 5846ff3c7ae0..275e665173c6 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src c0b367bf..ebd295df (366 commits) Created with: gclient setdep -r src/third_party/skia@275e665173c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I521d612e267d16387d238d952ef8276105b9c494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139111Reviewed-by:
-
Alex Danilo authored
Changes the setting of 'transparent' background color to only apply for the non files-ng case - allowing the files-ng background color to inherit. This also has the side-effect of allowing all the files-ng background color rules to work as well (e.g. no hover color when pointer is active). Bug: 1068079 Change-Id: Icb4611d9138404b8ba9854e518619adf02c44246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138936Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#756974}
-
Melissa Zhang authored
This reverts commit 4c027362. Reason for revert: Potentially breaking https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/4672 Original change's description: > [CrOS settings] Fix printing new route in settings page > > https://chromium-review.googlesource.com/c/chromium/src/+/2126332 > Changes the routes to printing pages in settings. os_printing_page has a > route that was missed. This CL updates the route in > os_printing_page.html to match the new route, from /printing to > osPrinting. > > Fix: 1068322 > Change-Id: I2e9095ff805d2f94bf4c520717d3290fab912807 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138632 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: jimmy gong <jimmyxgong@chromium.org> > Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> > Cr-Commit-Position: refs/heads/master@{#756949} TBR=khorimoto@chromium.org,jimmyxgong@chromium.org,hsuregan@chromium.org,tjohnsonkanu@google.com Change-Id: I50d29f93d85233a198f62baec0e65b4c5eda9b4f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139172Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756973}
-
Dominic Mazzoni authored
Completely mechanical/automated. Doing it in small chunks and landing with TBR to minimize collisions. Bug: 1063155 Tbr: aleventhal@chromium.org Relnotes: N/A Change-Id: I5fbd94675e32b998f3817923f6c5c619e5d59629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131528 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#756972}
-
Alex Danilo authored
Adds a blue focus ring around the cancel selection button only when it's being focused from keyboard interaction. Sets width of the cancel selection button to match the width of buttons on the action bar. Bug: 1068079, 1065837 Change-Id: I2adad00e74dbf1a8515b4dabbdcc704c51aa8e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139054Reviewed-by:
-
Dominic Mazzoni authored
This is an issue with AXObjects that are ignored and not included in the accessibility tree. When we fire an event on such a node, the serializer owned by RenderAccessibilityImpl first walks up to find a common ancestor that is in the tree, and then serializes that node, even if it was already serialized. It breaks the mechanism that avoids re-serializing nodes that were already just serialized. In extreme circumstances, this led to a bug where the size of the AXTreeUpdate for a large table grew to 200MB for one particular website, even though the resulting AXTree had only around 2MB worth of data. The fix is simple: when a node changes, only fire a notification on the nearest ancestor that's in the tree. That way the serializer can avoid redundantly processing the same node more than once. Covered by a new test and a DCHECK that asserts that we should never get an AXTreeUpdate with more nodes than the size of the resulting tree. Without the new fix, the test fails with an AXTreeUpdate containing 1000 nodes with a tree of size 10. Bug: 1066880 Change-Id: I247ad6aecaaf45b02371d2dad430b50489a86fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134848 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5540fdbe7451..55cc5f2199b1 git log 5540fdbe7451..55cc5f2199b1 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 tsepez@chromium.org Move uint8_t vectors to data partition in xfa/ 2020-04-06 tsepez@chromium.org Move uint8_t vectors to data partition in fxjs/ 2020-04-06 tsepez@chromium.org Put uint8_t vectors into data partition in fpdfsdk/ 2020-04-06 tsepez@chromium.org Put uint8_t vectors into the Data partition in fpdfapi/ 2020-04-06 thestig@chromium.org Fix regression in FPDF_CountNamedDests(). 2020-04-06 thestig@chromium.org Add more tests for FPDF_CountNamedDests(). 2020-04-06 thestig@chromium.org Fix typos in some .in files and regenerate the .pdf files. Created with: gclient setdep -r src/third_party/pdfium@55cc5f2199b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I85b9bb34d3abe405ae35d672c27ac0b2343a2131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138968Reviewed-by:
-
Peter Kasting authored
The bulk of this is simply moving the contents of toolbar_button_interactive_uitest.cc into toolbar_button_unittest.cc. Originally, the tests in this file were split out due to fears that showing a context menu in a unittest would lead to flakiness (due to e.g. setting mouse capture) (see https://codereview.chromium.org/1864423002/#msg7 ). However, we run menus in plenty of other unittests (e.g. ui/views/controls/menu/menu_runner_unittest.cc), and it doesn't cause problems. I also tested this locally and could not detect any problems either running in a debugger and allowing the menu to set capture, or trying to do mouse input while the tests ran. I suspect this is not going to cause an issue; certainly it's worth a shot. This also moves these tests from ViewEventTestBase, which was being misused to not actually run event tests, to ChromeViewsTestBase, which does the desired frameworky bits without the unnecessary ones. Finally, this makes use of ViewsTestBase::CreateTestWidget(), SimpleMenuModel, and a few other classes to dramatically reduce the amount of boilerplate code necessary. Bug: none Change-Id: I6658760610e963d44e557e4985bb936bacd1a118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139112 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#756968}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/029854ebc997..e8697a423557 git log 029854ebc997..e8697a423557 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 kimanh@chromium.org Wait for line to be loaded before setting breakpoints Created with: gclient setdep -r src/third_party/devtools-frontend/src@e8697a423557 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id6d5d22331712fe47008d1a119a7add4e752b380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138967Reviewed-by:
-
Minyue Li authored
Bug: 1056230 Change-Id: I7cc0529eaa2e476192d62637fb70e6542920021a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126291Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Minyue Li <minyue@chromium.org> Cr-Commit-Position: refs/heads/master@{#756966}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: Ic5b4050f5e9c4e2a7f09e79510537fba9e7995dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138655 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#756965}
-
Roman Sorokin authored
* Removed webui_login option. * Simplified ctor. * Migrated tests to LoginManagerMixin where possible * Changed base class to OobeBaseTest where makes sense Change-Id: I011ec80a5c9ef97d500b9cb396fe90de3409b87d Bug: 987587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122927 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#756964}
-
David Bokan authored
This feature has been enabled for close to a year so it's safe to remove the flag. Bug: 772130 Change-Id: I3e52f442de3d9aec4a55eeed5c9c8bd4c771bf6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136103Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756963}
-
Charles William Dick authored
It is not possible to directly reclaim memory from ARCVM based Android apps, so don't kill them. In ARCVM, the virtio balloon is sized to balance available memory between host and guest, so if there is critical memory pressure in Chrome, there will also be limited memory in the Android guest. ARCVM relies on the Android Low Memory Killer running in the guest to kill apps, increasing the memory available to the guest, which will be returned to the host with the virtio balloon. BUG=b:147336074 TEST=launch ARCVM, run 'grep 'WARNING debugd' /var/log/messages'. verify there's no warning from debugd. tast run <DUT> arc.MemoryChromeOSPerf.vm, also see no warnings in /var/log/messages. (this will force critical memory pressure) Change-Id: I7d610ea44eaf45494f6b4143b053779f6f3df6d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135094Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Charles Dueck <cwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#756962}
-
Joel Hockey authored
TBR=lxj@google.com Change-Id: Iba61e0db0a9643277afb16d9a118c86854c8dca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138912Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#756961}
-
Kent Tamura authored
Converts max_option_width to LayoutUnit instead of casting to int. The LayoutUnit constructor uses base::saturated_cast<> internally. Bug: 1068338 Change-Id: Id13f98c440eaad1ba2fad8ad0ae84129121c734c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138672 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#756960}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Idf295365ed27f4299f717bf3995a45afae252c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137106Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#756959}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/76f4fff613b5..5846ff3c7ae0 git log 76f4fff613b5..5846ff3c7ae0 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 csmartdalton@google.com Make glDraw*BaseInstance non-optional when extension(s) are present Created with: gclient setdep -r src/third_party/skia@5846ff3c7ae0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: Ia25cbb01846168e27d5a3036c8d3f187bd1449ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138959Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3549e2d6063c..e89877724aba Created with: gclient setdep -r src-internal@e89877724aba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC zmin@google.com,jarhar@google.com,cfroussios@google.com,aboxhall@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1050094,chromium:1055749 Tbr: zmin@google.com,jarhar@google.com,cfroussios@google.com,aboxhall@google.com Change-Id: Icb102e444f03d30e5ab18b8b61ea44130dfb491f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138955Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756957}
-
Kuo Jen Wei authored
Bug: b:147986763 Test: Pass 'tast run <DUT> camera.CCAUIResolutions' with crrev.com/c/2128208 on treeya Change-Id: Ia3181cbfd0438b36f403ace4f4771b0fdfd40955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127995Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#756956}
-
Jarryd authored
Bug: 997262 Change-Id: I597c51641d6cdab16558cc3611c8187739be6e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137858Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#756955}
-
David Munro authored
Test: Manual with ChromeVox Bug: chromium:1061778 Change-Id: Iec82ac9c785dafea14e4a4484178b2b5c0fca007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135104 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#756954}
-
Mei Liang authored
This CL modifies the list tab card item to show the domain of the tab's URL, and falls back to show the full URL if no domain associated with the URL of the tab. Change-Id: Idd508f46e62a53ae47a8ce90ec4e2ef424a58664 Bug: 1042890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133428Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756953}
-
Bruce Dawson authored
This improves the assert message when user32.lib cannot be found during gn gen on Windows. This is an ongoing source of problems for external contributors and this change may help with diagnostics. Change-Id: I1649fb4d9cac4a735377df14149f554b434d63cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136889Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#756952}
-
Ionel Popescu authored
Prior to this CL, the outline-offset was *ignored when drawing the default focus ring (see AdjustedFocusRingOffset): - for FormControlsRefresh, GetDefaultOffsetForFocusRing was used instead - on Windows the value was completely ignored - on Mac the value was used This CL updated the behavior so that the default focus ring respects the value of outline-offset. Because of this, GetDefaultOffsetForFocusRing is not needed anymore since now we can directly update the outline-offset to correctly reflect what we are painting. Another difference in behavior is that the offset is not going to be zoom independent anymore. This fix is just for FormControlsRefresh (the feature is enabled on all platforms except Android) to minimize regression risks. The fix is validated by: focus-ring-outline-offset.html Bug: 945181 Change-Id: I2cff82556571d9f541b95f8cece9b7c3be1191c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138156 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#756951}
-
Johann authored
Use the HeapMojoReceiver wrapper so that Oilpan will GC the object. Bug: 1049056 Change-Id: Ica0b2b1410ee8940e8210cd2fd1d8966d8b7c377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117790 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#756950}
-
Nnamdi Theodore Johnson-Kanu authored
https://chromium-review.googlesource.com/c/chromium/src/+/2126332 Changes the routes to printing pages in settings. os_printing_page has a route that was missed. This CL updates the route in os_printing_page.html to match the new route, from /printing to osPrinting. Fix: 1068322 Change-Id: I2e9095ff805d2f94bf4c520717d3290fab912807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138632Reviewed-by:
jimmy gong <jimmyxgong@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#756949}
-
Curtis McMullan authored
This commit enables resize for the virtual keyboard by default. BUG=1019990 Change-Id: I5e71d411b9997c31b8e2f3414f8913df68641e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138679Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#756948}
-
ssid authored
When unique db is missing and migration state says it should, the database could have been deleted by other means. In this case just return an empty shared db instead of error. Change-Id: I5b15955662405b306583ed1942d8591703ebf942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130685Reviewed-by:
Salvador Guerrero <salg@google.com> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#756947}
-
