GitLab

BUG=423019

Review URL: https://codereview.chromium.org/691183002

Cr-Commit-Position: refs/heads/master@{#302401}

Blink roll 2842c5f8ea181eb3415ae3b124b873eb4355e6e2: c51b33ed3d9bc7d1ccc45231a5d48432a2be6740 (svn 184758:184775)

TBR=morrita

Review URL: https://codereview.chromium.org/699533002

Cr-Commit-Position: refs/heads/master@{#302400}

Cr-Commit-Position: refs/heads/master@{#302399}

These objects don't have the same lifetime and we were using raw pointers to them  in a few places, which could lead to use-after-free.

BUG=429477
TBR=perkj@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/698803002

Cr-Commit-Position: refs/heads/master@{#302398}

Disable WebViewInteractiveTest.NewWindow_OpenInNewTab on OS_MACOSX, until the problem to miss keyup event with command key is fixed

BUG=425859
R=avi@chromium.org
R=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/692113002

Cr-Commit-Position: refs/heads/master@{#302397}

Cr-Commit-Position: refs/heads/master@{#302396}

This addresses the issue of getStats blocking the UI thread for excessive amounts of time and also opens the door for us to do other heavy-lifters such as setRemoteDescription and setLocalDescription asynchronously.

This CL builds on several others that have landed this week (see bug for details), but here are the key changes:

- PeerConnectionDependencyFactory has a separate signaling thread instead of using the UI thread.
- Classes that join WebRTC and Blink objects need to be aware of the signaling thread being different.  This means that callbacks will come in on the signaling thread from webrtc and need to be sent to the UI thread for javascript callbacks.

BUG=369796

Review URL: https://codereview.chromium.org/675013005

Cr-Commit-Position: refs/heads/master@{#302395}

Currently our code assumes that high res tiling comes before the low
res tiling (for eviction iterators). However, that doesn't seem to be
the case in all situations. Rather that just fixing the problem (if
it is a problem), this patch makes the eviction code be able to proceed
without crashing. In these situations the eviction order of tilings
won't be ideal, but would still visit all tilings.

BUG=429397, 429201
R=danakj, reveman

Review URL: https://codereview.chromium.org/694143002

Cr-Commit-Position: refs/heads/master@{#302394}

This patch adds more eviction cache invalidations in order to avoid
use after free scenarios. This problem will be fixed by faster eviction
since we won't need the cache, but until that is in place, this is
a necessary fix.

BUG=429201
R=danakj, reveman

Review URL: https://codereview.chromium.org/687573003

Cr-Commit-Position: refs/heads/master@{#302393}

This patch removes the initial binding when the renderer commits a
navigation, rather than after a fixed delay from starting the renderer.

We have to wait until the first commit before relying on the  visibility
signal, because a renderer for the foreground tab is considered
background until it commits.

BUG=421041

Review URL: https://codereview.chromium.org/673573003

Cr-Commit-Position: refs/heads/master@{#302392}

Revert of Hold the Pepper proxy lock for all Pepper GL calls. (patchset #3 id:40001 of https://codereview.chromium.org/692683003/)

Reason for revert:
causing huge crashes in canary. bug=429446

Original issue's description:
> Hold the Pepper proxy lock for all Pepper GL calls.
>
> BUG=418651
>
> Committed: https://crrev.com/057f7a69dd40c93550b375b4287dba70d719316a
> Cr-Commit-Position: refs/heads/master@{#302303}

TBR=dmichael@chromium.org,dmichael@google.com,penghuang@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=418651

Review URL: https://codereview.chromium.org/698463006

Cr-Commit-Position: refs/heads/master@{#302391}

For example, vendor, renderer, driver version, etc.This
way a developer can gather data on what platforms the app
fails to run. This needs changes on both blink and chromium.

Below steps are followed to implement this

1. Add basic headers in blink.
2. Add the necessary apis in chromium.
3. Start using this in WebglRenderingContxt.cpp.

This patch represents step-2 in this process.

BUG=412440

Review URL: https://codereview.chromium.org/645613002

Cr-Commit-Position: refs/heads/master@{#302390}

BUG=429300

Review URL: https://codereview.chromium.org/695993003

Cr-Commit-Position: refs/heads/master@{#302389}

Revert of Revert of Add logs to debug a flakiness on GPU Mac bots. (patchset #1 id:1 of https://codereview.chromium.org/684253003/)

Reason for revert:
Ah, reverted the wrong CL.

Original issue's description:
> Revert of Add logs to debug a flakiness on GPU Mac bots. (patchset #2 id:20001 of https://codereview.chromium.org/684423005/)
>
> Reason for revert:
> Should turn on logging in telemetry_gpu_tests in general.
>
> Original issue's description:
> > Add logs to debug a flakiness on GPU Mac bots.
> >
> > This is temporary and will be removed after we pin down the issue.
> >
> > BUG=424024
> > TEST=
> > R=kbr@chromium.org
> > TBR=dgozman@chromium.org
> > NOTRY=true
> >
> > Committed: https://crrev.com/16aa242c3456dc68cd91ef2c683158799c8441b0
> > Cr-Commit-Position: refs/heads/master@{#302371}
>
> TBR=dgozman@chromium.org,kbr@chromium.org,pfeldman@chromium.org,yurys@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=424024
>
> Committed: https://crrev.com/ec506e7f57922e5a068d76128f020877bc7986cb
> Cr-Commit-Position: refs/heads/master@{#302387}

TBR=dgozman@chromium.org,kbr@chromium.org,pfeldman@chromium.org,yurys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424024

Review URL: https://codereview.chromium.org/698783002

Cr-Commit-Position: refs/heads/master@{#302388}

Revert of Add logs to debug a flakiness on GPU Mac bots. (patchset #2 id:20001 of https://codereview.chromium.org/684423005/)

Reason for revert:
Should turn on logging in telemetry_gpu_tests in general.

Original issue's description:
> Add logs to debug a flakiness on GPU Mac bots.
>
> This is temporary and will be removed after we pin down the issue.
>
> BUG=424024
> TEST=
> R=kbr@chromium.org
> TBR=dgozman@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/16aa242c3456dc68cd91ef2c683158799c8441b0
> Cr-Commit-Position: refs/heads/master@{#302371}

TBR=dgozman@chromium.org,kbr@chromium.org,pfeldman@chromium.org,yurys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424024

Review URL: https://codereview.chromium.org/684253003

Cr-Commit-Position: refs/heads/master@{#302387}

NOTRY=true
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/695873003

Cr-Commit-Position: refs/heads/master@{#302386}

This is unnecessary as image ids are not reused. CreateImage will
fail if generation of image ids wraparound as negative ids are
considered an error.

R=piman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/689253002

Cr-Commit-Position: refs/heads/master@{#302385}

Cr-Commit-Position: refs/heads/master@{#302384}

BUG=

Review URL: https://codereview.chromium.org/694763003

Cr-Commit-Position: refs/heads/master@{#302383}

Only one should be set, so update functions to reflect this. In the rare
case both are set, always-on takes precedence.

BUG=397019

Review URL: https://codereview.chromium.org/685053002

Cr-Commit-Position: refs/heads/master@{#302382}

VC++ hits internal compiler errors on a source file in each of yasm and
libexif. This halts the build and prevents full analysis. Therefore this
change disables /analyze for those two projects, to increase total
coverage.

Also fix a typo in libexif's README.chromium

BUG=427616

Review URL: https://codereview.chromium.org/657883003

Cr-Commit-Position: refs/heads/master@{#302381}

Cr-Commit-Position: refs/heads/master@{#302380}

Chrome add "X-Chrome-UMA-Enabled" (and sometimes "X-Client-Data") headers while accessing Google servers if UMA is enabled.
This header is added before sending the request to the ServiceWorker.
So the request which is passed to the ServiceWorker contains this header.

If event.request.mode is 'cors' and event.request.headers has "x-chrome-uma-enabled", fetch(event.request) send a CORS preflight request.
This preflight request contains "Access-Control-Request-Headers: x-chrome-uma-enabled" header.
But the response from the Google server doesn't contain "Access-Control-Allow-Headers: x-chrome-uma-enabled" header.
So this fetch fails.

To avoid this problem this patch removes these headers before sending the request to the ServiceWorker.

This patch introduces ServiceWorkerContext::AddExcludedHeadersForFetchEvent() method and changes DevToolsNetworkTransactionFactory to call this method.

BUG=425649

Review URL: https://codereview.chromium.org/666973003

Cr-Commit-Position: refs/heads/master@{#302379}

This change renames MediaIndicatorView to MediaIndicatorButton, and then
merges-in the new functionality to support tab muting by clicking on the
indicator.  This is the "Cocoa port" of a previous change that added
this feature to the views UI: http://codereview.chromium.org/591963002

See change description in link above for details.

Also, this change resolves a long-standing bug where navigating back
into a NTP would leave the audio indicator turned on even though the NTP
does not emit sound.

BUG=360372, 344229
TEST=With --enable-tab-audio-muting, user can click audio indicator to toggle tab muting, or use the tab context menu to toggle muting of one or more selected tabs.

Review URL: https://codereview.chromium.org/688523002

Cr-Commit-Position: refs/heads/master@{#302378}

BUG=421291

Review URL: https://codereview.chromium.org/692523004

Cr-Commit-Position: refs/heads/master@{#302377}

This CL:
- Adds !defined(USE_ATHENA) ifdefs where Ash is used.
- Stops compiling KeyboardOverlayUI in Athena because it is not necessary
- Stops compiling in Athena for simplicity:
   DisplayOptionsHandler, PowerHandler, FirstRunUI

BUG=426561
TEST=None
TBR=oshima,estade,stevenjb

Review URL: https://codereview.chromium.org/684143003

Cr-Commit-Position: refs/heads/master@{#302376}

TBR=darin@chromium.org for trivial third_party/*/BUILD.gn changes

Review URL: https://codereview.chromium.org/698733002

Cr-Commit-Position: refs/heads/master@{#302375}

BUG=424453

Review URL: https://codereview.chromium.org/653283007

Cr-Commit-Position: refs/heads/master@{#302374}

Reduce the maximum number of Session ID cache entries to save
memory but increase the session ID cache timeout to be useful.

BUG=426630

Review URL: https://codereview.chromium.org/687343002

Cr-Commit-Position: refs/heads/master@{#302373}

BUG=416184
TEST=as in bug

Review URL: https://codereview.chromium.org/689163002

Cr-Commit-Position: refs/heads/master@{#302372}

This is temporary and will be removed after we pin down the issue.

BUG=424024
TEST=
R=kbr@chromium.org
TBR=dgozman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/684423005

Cr-Commit-Position: refs/heads/master@{#302371}

The BrokerProcess class is too complex. It both serves as management
of a new broker process, as well as the implementation of an
async-signal-safe IPC mechanism suitable to broker syscall.

We split the BrokerProcess class into 4 simpler classes. This will make it
easier to replace the broker process with a thread or a new Chrome process
type.

BUG=429028

Review URL: https://codereview.chromium.org/688843003

Cr-Commit-Position: refs/heads/master@{#302370}

They are no longer needed since nearly no extensions code gets built when extensions are disabled.

Review URL: https://codereview.chromium.org/672403002

Cr-Commit-Position: refs/heads/master@{#302369}

These calls are not available on MacViews without Aura, so put them behind an
interface through views::Widget.

BUG=425229

Review URL: https://codereview.chromium.org/693523003

Cr-Commit-Position: refs/heads/master@{#302368}

The mojo_surface_converters get their own file to avoid dependency
cycles between media/ and cc/

BUG=none
TEST=no more cycles when media depends on type conveters.

Review URL: https://codereview.chromium.org/691573003

Cr-Commit-Position: refs/heads/master@{#302367}

Previously the client cursor would revert to a default arrow if the
host cursor was hidden or empty, or in mouse-lock mode.

BUG=429368

Review URL: https://codereview.chromium.org/696873002

Cr-Commit-Position: refs/heads/master@{#302366}

Per mock:
https://beta-dot-folio.googleplex.com/chrome-ux/mocks/212-stars-iphone/20/phone#%2F05-detail-edit-bookmark.png%3Fc=hidden

All tags/filters associated with a bookmark should be displayed in
enhanced bookmark detail page. This CL introduced related APIs to jni
bridge for UI to retrieve.

BUG=NONE

Review URL: https://codereview.chromium.org/694093002

Cr-Commit-Position: refs/heads/master@{#302365}

Webkit roll 9eddd919681ed3642ac37d811e6b3f30e0f152db(r184753):2842c5f8ea181eb3415ae3b124b873eb4355e6e2(r184758)

TBR=morrita
BUG=

Review URL: https://codereview.chromium.org/695043003

Cr-Commit-Position: refs/heads/master@{#302364}

The root cause was that ImageTransportSurfaceFBO was using the pixel
size of the surface to early-out of surface reallocation. This is a problem
when scale factor changed and pixel size doesn't -- the change in scale
factor is never propagated to the underlying CALayer.

Move all logic for changing the size of the surface and for skipping
changes in the size of the surface to AllocateOrResizeFramebuffer.

Rename ambiguous sizes to be labeled as pixel_size or dip_size.

Remove a stray ScopedCAActionDisabler that does nothing (found by
inspection of nearby code).

Add myself as an OWNER for this path.

BUG=424713

Review URL: https://codereview.chromium.org/696823002

Cr-Commit-Position: refs/heads/master@{#302363}

Moving the DirectiveHandler to be owned by CopresenceManager. This also adds the ability to queue Directives. Tests will be forthcoming.

BUG=424253

Review URL: https://codereview.chromium.org/684273004

Cr-Commit-Position: refs/heads/master@{#302362}