- 10 Sep, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/feb1579dfb25..3b19b9d3347f 2020-09-10 fmayer@google.com Merge changes Ief0ffa2c,Icce0f62c 2020-09-10 hjd@google.com Merge "Remove d8, we never used it" 2020-09-10 hjd@google.com Merge "ui: Add --incremental to TypeScript build" 2020-09-10 delphij@google.com Merge "Merge Android R" 2020-09-10 treehugger-gerrit@google.com Merge "ui: Add support to decode metrics in the UI" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0e296d0ebcbde22955555d42ab5f62199e232bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404205Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805891}
-
Liquan (Max) Gu authored
Since OnSectionOptionSelected is PaymentRequest UI logic, move it into PaymentUIsManager. Bug: 1102522, 1114791 Change-Id: I8268493c6d65ec14aa89444b461910d58c5af4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402119 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#805890}
-
Ryan Hansberry authored
Two tests related to Read() have been excluded from running on Windows due to undiagnosed crashes. We can resolve them in the future when Nearby launches for Windows devices. Bug: 1124992 Change-Id: I682cf64604344314c40e276042c08dbb8023c800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402442 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#805889}
-
James Vecore authored
This CL adds an observer interface to allow clients of the service to be notified when high visibility state changes as well query the current state. Previously, high-visibility was not part of the api. It was an implied state when a foreground receive surface was registered and advertising was is started successfully with a device name in the end-point info. This change makes it possible to query and monitor high visibility so UI surfaces can be in sync with the service state. Additional methods will be added to the observer interface in follow up CLs (i.e. Shutdown). Change-Id: I40b718fb9fb1ab185ef45a4ff0085d4c59c8bad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401851 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#805888}
-
Leonard Grey authored
These are to support displaying hotkeys and tagging different types of result with specific icons. Bug: 1014639 Change-Id: I93f432a2368c25285dd714c4f2fbdaef96434a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403661Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#805887}
-
chrome://nearby-internalsJosh Nohle authored
(1) Add a newline at the end of each line when saving logs file. (2) Show logs in chronological order. (3) Fix issue which showed "../../" at the start of every filename. (4) Fix issue where logs extend a few pixels past the horizontal width of the page, resulting in an overflow and making it possible to scroll left and right. (5) Clean up some code in the <log-object> element. (6) Use Polymer's array mutation method for unshift, which notifies other elements bound to the same array of the changes. This will fix the issue of needing to refresh to page to show log changes. Changes 1-5 mirror exactly crrev/c/2372600 and crrev/c/2383790, which correct the issues on the analogous chrome://multidevice-internals page. Change-Id: I3bd2d922e291f86be5533716cfac74f67c5bdd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401807 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#805886}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1599738815-c7c05d9aad543471c0ca5060fdc90a37df9de6fc.profdata to chrome-linux-master-1599760756-c4035dc0b0474f5a6f2e7d19fc7457941683bae1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I0f67e98af99f1924960aea72786f1580119937d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404781Reviewed-by:
-
Federico Paredes authored
MenuScrollViewContainer now has a kIgnored (instead of kMenuBar) role on Mac. This allows the SubmenuView to be recognized as a menu by VoiceOver, so it can now read the total number of MenuItemViews inside it when navigating via keyboard. Bug: 954701 Change-Id: I4ee11c09d3331d55899ece6741f9821cbd3b2285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402098 Commit-Queue: Federico Paredes <fedpar@microsoft.com> Reviewed-by:
-
Yulun Wu authored
Bug: 1110757 Change-Id: Ide6c6ecfbfc259ac1a5b22e2441afedad6655adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392949 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#805883}
-
Trevor Perrier authored
This CL adds the AppLocaleController interface and the GlobalAppLocaleController implementation which use the APPLICATION_OVERRIDE_LANGUAGE value to override the Clank language. Early in ChromeApplication.attachBaseContext the GlobaleAppLocaleController singleton is initialized with the override language and updates the Application level Locales/LocaleList. Doing the Application override this early also overrides the ContextUtils wrapped application Context. The base Context passed by Android to the Activity level attachBaseContext still uses the system locales so an Activity level locale override is also done. The override language is used for CCTs. This is the third of four CLs for this feature. The next will introduce the UI changes to allow users to control the preference. Bug: 1068667 Change-Id: Ifbbe9f8ed592c1b890a9069ef5cbfb685d34e00f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354546Reviewed-by:
Trevor Perrier <perrier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#805882}
-
Sebastien Lalancette authored
This reverts commit 40d318a5. Reason for revert: New tests are failing on many builders, like: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/49280 Original change's description: > Direct Sockets: Browser implementation for TCP connection establishment > > DirectSocketsServiceImpl::OpenTcpSocket() now calls > CreateTCPConnectedSocket() on the network context. > > Browser test DirectSocketsBrowserTest.OpenTcp_Options verifies > that the remote address, port, buffer sizes and no-delay flag > are passed successfully. > > NavigatorSocket::PendingRequest has been split into > TCPSocket and UDPSocket classes, currently with no web-exposed > members implemented. > https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md#tcp > https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md#udp > > > > > Explainer: https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md > > Intent to Prototype: > https://groups.google.com/a/chromium.org/g/blink-dev/c/ARtkaw4e9T4/m/npjeMssPCAAJ > > Design doc: > https://docs.google.com/document/d/1Xa5nFkIWxkL3hZHvDYWPhT8sZvNeFpCUKNuqIwZHxnE/edit?usp=sharing > > > > Bug: 905818 > Change-Id: I7030f73d4863767b3d51a615fd84380148011bec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391181 > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > Auto-Submit: Eric Willigers <ericwilligers@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805850} TBR=kinuko@chromium.org,jbroman@chromium.org,ericwilligers@chromium.org,dullweber@chromium.org,glenrob@chromium.org Change-Id: I1dd6b7bab117365bf22384c61dc1d3158bf10c58 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404821Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#805881}
-
Anne Lim authored
This is a follow-up after instrument_id has been added to the AutofillTable in cr/2390970. Please refer to bug for design doc. Bug: 1121806 Change-Id: Ie118b2dba1e0d7890333de35c92489398cdae6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402130Reviewed-by:
Anne Lim <annelim@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#805880}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I84b21f5e3155072f67d04fde846bef1adf9dcf14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404403Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#805879}
-
Maxim Kolosovskiy authored
fieldtrial_testing_config Bug: 1108692 Change-Id: I36000025bdfe905232f9b6af55997692833f98c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403366 Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#805878}
-
Ryan Hansberry authored
As per recommendation in Comment #30 of crbug.com/1114876. This is the same grey used in Network Settings secondary text. Bug: b:167556640 Change-Id: I5a669cae3e43fc7cfe3d57eb276a4f6584a322e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404141 Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
Roman Aleksandrov authored
Make dots clickable and add proper aria-labels and role. Add aria-label to slides for better spoken feedback. Bug: 1125620 Change-Id: I6f20d4b1e3293aa89c81d4a6da960b6fd0fb0b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396084 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#805876}
-
Roberto Moura authored
Using a fake pan gesture recognizer, simulate 4 changes of state in the ViewRevealingVerticalPanHandler (Hidden -> Peeked -> Revealed -> Peeked -> Hidden), which are observable through a fake animatee that has a public |state| property. Bug: 1094335, 1124380 Change-Id: I2a2b1017b78fce48eb48cbde95eb9967870aee7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396090 Commit-Queue: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#805875}
-
Ben Goldberger authored
Bug: 1125930 Change-Id: I8613a3c881eadb7a162550bf0321c1b87cb2ca2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397319 Commit-Queue: Ben Goldberger <benwgold@google.com> Reviewed-by:
-
Mitsuru Oshima (Slow: gardener) authored
This reverts commit a420f12c. Reason for revert: causing failure on chromeos-amd64-generic-rel bot. (crbug.com/1127015) Original change's description: > Enable UsingRealWebcam_* test on ChromeOS > > Bug: 1069608 > Test: Pass 'tast --verbose run <betty> "camera.CaptureUnittests"' 15 > times in a row. > > Change-Id: I30d6872ad9a6d30a41cc14648a12d71a1fed274a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387911 > Commit-Queue: Inker Kuo <inker@chromium.org> > Auto-Submit: Inker Kuo <inker@chromium.org> > Reviewed-by: Shik Chen <shik@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804650} TBR=shik@chromium.org,guidou@chromium.org,inker@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1069608, 1127015 Change-Id: I850771baa03d86fc5bb03e87fd1151eb6fefa167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404266Reviewed-by:
Mitsuru Oshima (Slow: gardener) <oshima@chromium.org> Commit-Queue: Mitsuru Oshima (Slow: gardener) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#805873}
-
Dan Harrington authored
- Try to make the tasks more general purpose. * Add mechanism to switch output directories. Most tasks will work with this value. * Add tasks to run tests for the current file or directory instead of pre-determined targets. - Try to simplify it. * Remove some parameters which are defaults * Move pattern matches to top-level, to avoid duplicates. Change-Id: Ifff15bc264be510c0859e4adcce7b996349ac343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402189Reviewed-by:Chase Phillips <cmp@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#805872}
-
Tamir Duberstein authored
Bug: https://github.com/google/gvisor/issues/3839 Change-Id: Idb68fbe87c402d1832bd7004d26a2706d8ddd1fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404621 Commit-Queue: Tamir Duberstein <tamird@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#805871}
-
Eugene But authored
Test is consistently failing on downstream bots (iPhone and iPad device) Bug: 1127005 TBR: kazinova@chromium.org Change-Id: I317f1df8363dfe5139810d8082209e0e9434e57b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404404Reviewed-by:
-
Findit authored
This reverts commit 612ba1ba. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 805855 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzYxMmJhMWJhZTc3M2VkMmY0OGUwY2M3Y2FhMDI5ZTM3MWFjZjRlMDIM Sample Failed Build: https://ci.chromium.org/b/8869520836042840528 Sample Failed Step: compile Original change's description: > CookieStore: Remove matchType > > This change removes matchType option from CookieStoreGetOptions. > This decision has been discussed here [1], and will > be revisited after launch to re-evaluate if the option > is good to have or if we should do a full cleanup of > the option. > > [1] https://github.com/WICG/cookie-store/issues/128 > > Bug: 1124497 > Change-Id: I845c6e872aa25d138114ccf0b0a74332adeb650d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402132 > Commit-Queue: Ayu Ishii <ayui@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805855} Change-Id: I34db3d51b56ed808b6b8df3c2e09ac8e659e57f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1124497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404780 Cr-Commit-Position: refs/heads/master@{#805869}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I18f4c342ba73eed37fc63ccf54e9073438cd26df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404401Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805868}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/12e6ff85f6e2..eed10d12ed49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kmoon@google.com,seblalancette@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kmoon@google.com,seblalancette@google.com Change-Id: I0f5986239d1fc9d30183e0246a3d3825d24b1c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404201Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Kahmy Moon <kmoon@google.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805867}
-
Sven Zheng authored
These are sync tests for Android. First run with experimental. Test: Tested locally and tryjobs. Bug: 1117345 Change-Id: Ie0989cc23e646314d6f747ac3d700c3fb5a61c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399498 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#805866}
-
Zarah Tesfai authored
Purpose: Move Minimal UI related logic to PaymentUIsManager Changes: * Added get/setMinimalUI() methods in PaymentUIsManager * Moved testing related methods * Added hideMinimalUI() method Bug: 1108099 Change-Id: Ibb35f92f8f61c68056b37ee5f9019e7a7f05cb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381063 Commit-Queue: Zarah Tesfai <ztesfai@google.com> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Robert Sesek authored
Under the sandbox, _CSCheckFix() can result in a lot of unnecessary disk I/O. Bug: 1110292 Change-Id: I8507156d75fa046b3d5be1d5b0121abce0967af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401334 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805864}
-
Jordan Taylor authored
This issue was fixed in the following CL by changing the calculation for inherited_time that gets passed to effects in Animation::Update. https://chromium-review.googlesource.com/c/chromium/src/+/2092188 This CL is adding test coverage for the issue. It has been verified to fail without the above changes. Bug: 1082504 Change-Id: I4a15a0dcd23f351fd5fb9e659693d6c803937360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393059 Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#805863}
-
Liquan (Max) Gu authored
Change: * Move parseAndValidateDetails() into PRSpec. * Assign id in PRSpec constructor as opposed to after parsing details. Bug: 1102522 Change-Id: Ie292c723ee26c4f6237115f6d1dc367319aa031a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391264Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#805862}
-
Ryan Keane authored
This CL adds a new class skeleton, to be implemented in a future CL and used in AudioPipelineImpl and CastAudioOutputStream. Bug: b/167424911 Change-Id: I3dd799f29808a5046b983195120df393b1514510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401305Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Ryan Keane <rwkeane@google.com> Cr-Commit-Position: refs/heads/master@{#805861}
-
Josiah K authored
Same as original CL below, but with a less flaky test. https://chromium-review.googlesource.com/c/chromium/src/+/2388402 Change-Id: Ie689601521e88affd7569ab1adfaad840660bc21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402579 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#805860}
-
Ghazale Hosseinabadi authored
DevToolsWindowCreationObserver::WaitForLoad clears its MessageLoopRunner right when DevToolsWindowCreated is called, this means the runner would be destroyed while its QuitClosure is running. This CL fixes the issue by moving the destruction after MessageLoopRunner::Run(). This bug is evident when there is no DevToolsWindow at DTWCObserver instantiation time. This CL adds a regression test for that. Bug: 1126105 Change-Id: I68b122c657abbc9a0ecca7875ed19dc6d33914eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363886Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Cr-Commit-Position: refs/heads/master@{#805859}
-
Maksim Ivanov authored
This reverts commit 8f840cb8. Reason for revert: The tests, as reported, should pass now. Original change's description: > [Sheriff] Disable graphics.TraceReplay.glxgears_stable > > It has been failing consistently on CrOS bots. > This disables it. > > Bug: 1123872 > Change-Id: I79152a991118af02a215e3f809c50f42c12d24cd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387101 > Commit-Queue: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803459} TBR=emaxx@chromium.org,mamir@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1123872 Change-Id: I676d000fb95648985a533b1ef860d50dedf7d129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404580Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#805858}
-
Eugene Zemtsov authored
Bug: 1124933, 1121794 Change-Id: Ic8089d8793ffdb0bff0cb40da12582bc3b891f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402280 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#805857}
-
rbpotter authored
- Change PdfAccessbility tests to validate only the accessibility tree for the embeddedObject (i.e. the PDF), and not other containers on the page. With this change, the tests pass with the update enabled. - Parameterize all accessibility tests to run in both flag states. Bug: 1120279 Change-Id: Ie7ece749af71da48ac39c5ebdd947e26f09f271b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393245 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#805856}
-
Ayu Ishii authored
This change removes matchType option from CookieStoreGetOptions. This decision has been discussed here [1], and will be revisited after launch to re-evaluate if the option is good to have or if we should do a full cleanup of the option. [1] https://github.com/WICG/cookie-store/issues/128 Bug: 1124497 Change-Id: I845c6e872aa25d138114ccf0b0a74332adeb650d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402132 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#805855}
-
Reda Tawfik authored
1) Adds list all user credentials to the Model from the Mediator. 2) Adds the credential model to properties class. 3) Creates a ViewHolder for the credential view. 4) Implements the Adapter for the RecyclerView. 4) Implements |bindCredentialView()|. 5) Sends focused field type from native to java. 6) Adds a test to check if the model updates the view properly. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1104132#c11 Bug: 1104132 Change-Id: I4606a13214f5e815bce41207e72cde6caed60fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370542 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#805854}
-
Fredrik Söderqvist authored
This has only one actual user - AnimatedPropertyTypeSupportsAddition() which is only called when the animation has a target. Since a test reads the type add GetAnimatedPropertyTypeForTesting(). Bug: 1017723 Change-Id: Iaada97a2d281c0067f73f44a80f9e84837ca951d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403471Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#805853}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/625eb197594e..feb1579dfb25 2020-09-10 treehugger-gerrit@google.com Merge "metrics: Extend metric proto before registering metric" 2020-09-10 treehugger-gerrit@google.com Merge "traceconv: add missing flush in output writer" 2020-09-10 treehugger-gerrit@google.com Merge "Add back reserved lines commented earlier" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4c916d735961aeb4cd154a94e34d6e6543cc33d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404040Reviewed-by:
-
