- 11 Aug, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/870a1acaea40..ea4f2acc6399 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC apotapchuk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:897470 Tbr: apotapchuk@google.com Change-Id: I6b0ff33230c6386e3643b4840082d4d6df02f94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348198Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796793}
-
Rouslan Solomakhin authored
Before this patch, requesting "secure-payment-confirmation" method in PaymentRequest API would not validate the parameters. This patch adds the "secure-payment-confirmation" parameters to PaymentRequest API and validates them, if the "SecurePaymentConfirmation" feature is enabled. After this patch, PaymentRequest API validates the secure payment confirmation parameters. Explainer: https://github.com/rsolomakhin/secure-payment-confirmation Feature status: https://chromestatus.com/feature/5702310124584960 Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/myUR5gyd5Js/m/iELL67NQAgAJ Bug: 1110324 Change-Id: I7a4b6f9da1b3e1d7604bcd9e4733dc789f77ec4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341163Reviewed-by:
Nick Burris <nburris@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796792}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9d66bcc60d13a2bc5480eef731069ef589500170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349310Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796791}
-
Wez authored
Since there have been several AEMU rolls since the last version that we think was good, doing this as a normal CL rather than a revert. Tbr: chonggu@google.com Bug: fuchsia:58045 Change-Id: Ib534292189155bc7bd6313c67f61c5327f44175a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346334Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#796790}
-
Bruce Long authored
This change fixes an issue with the delayed initialization of the spellcheck service (a feature that in Chromium is currently behind the WinDelaySpellcheckServiceInit feature flag). While the first click in the editable content indeed initializes the spellcheck service by loading dictionaries, it does not guarantee a successful spell check request. Spelling may not be checked until further typing or focusing in a different editable element. If the text is long enough (multilined?), then a single click works. The bug is caused by a race condition in the mojo calls from the browser to the renderer process. There is no guarantee that the callback to the renderer process when InitializeDictionaries completes will be invoked in the renderer process after the call to SpellCheck::Initialize that results from the browser method SpellcheckService::InitForRenderer. If the first call wins the race, no spellchecking will occur because the spellcheck provider thinks there are no dictionaries available and does not check spelling. Mojo does not guarantee ordering in separate message pipes, which the SpellChecker and SpellCheckHost interfaces comprise. One fix that I considered was to make these associated interfaces that share a single channel between the browser and renderer processes. But I believe this risks breaking other platforms. So the fix I have here instead ensures that when the InitializeDictionaries callback is received in the renderer, SpellCheck::Initialize is called with the list of dictionaries provided by the browser process. Test coverage is provided by a browser test based on the original test that caught this bug (ChromeSitePerProcessTest.OOPIFSpellCheckTest): ChromeSitePerProcessSpellCheckTestDelayInit.OOPIFSpellCheckTest. The HTML source for this browser test contains just a snippet of editable content, so putting focus in it to invoke spellchecking and initialize the spellcheck service on demand exposed the issue. Bug: 1103847 Change-Id: I809e4aef3d51808d222012ddd0c0b46e3d57098a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335028Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Commit-Queue: Bruce Long <brlong@microsoft.com> Cr-Commit-Position: refs/heads/master@{#796789}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/86f54785..dd1a9165 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia84c44fc4d9005e328d0f97a855319e058d4713e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348029Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796788}
-
Rushan Suleymanov authored
This CL removes following feature toggles as they were enabled by default in M83 or earlier: * InvalidateBookmarkSyncMetadataIfClientTagDuplicates * SyncScheduleForEntityMetadataChangesOnly Bug: 1114738 Change-Id: Ic15e946e52124d49e28343e0969ffe0ed4931cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346654 Commit-Queue: Rushan Suleymanov <rushans@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#796787}
-
Wei Lee authored
We can pouplate the following data on load time: 1. I18N strings 2. Chrome specific data * Such as board name, CrOS version, etc Bug: 980846 Test: Check chrome://camera-app/strings.js Change-Id: Ieb46d4007ca93ca4d9e7a23bcd8005da65617ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245986 Commit-Queue: Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#796786}
-
Robbie Gibson authored
Accessing the clipboard should now use the new async APIs so all clipboard accesses go through the same path. Bug: 1110849 Change-Id: I36fbad6807a75bc72c50aba1fdcd9b8ce94b1ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346434Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#796785}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/faa233ccab76..c61e780dc832 2020-08-11 landrey@webrtc.org Revert "[XProto] Add SharedXDisplay::IgnoreXServerGrabs" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1066670 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic535d140cae3b5e3622a13c7896ba84095cce887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348607Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/95df5d3cbaf6..97adc5795ed2 2020-08-11 clemensb@chromium.org [man] Fix link to the git repository If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I8b31dde2aece2fb4813b454a6f91463c06a56a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348598Reviewed-by:
-
Swapnil authored
We want to add session type of currently logged in user to the existing LOGIN event for the event based reporting for force installed extensions. Bug: 1109693 Change-Id: I81a1c74d2b4403af4f1c8784d5e081385dd72a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317800 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#796782}
-
Rune Lillesveen authored
Also a bugfix to make sure we call BatterySavingsChanged() when all meta elements have been removed. Bug: 1114184 Change-Id: I8409a11289764b15605d5865ff3bae20e8da28a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346287 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#796781}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/23335ac01cb8..de914d018068 2020-08-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from b399fb08896a to fcfe5a3b19d5 (2 revisions) 2020-08-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 7b2dd11dda7a to 8e1380996d6a (3 revisions) 2020-08-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 8446db62f194 to 6eaf979e7366 (1 revision) 2020-08-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 2de6d657dde3 to b60e067b4374 (2 revisions) 2020-08-11 lehoangq@gmail.com Metal: Init format table using Metal-Feature-Set-Tables.pdf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I263d8400b44e1359531aafd67949e9a457385f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348604Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/33cec725dff9..fe1bb43b7a38 2020-08-11 szuend@chromium.org [ts] Type check ui/ActionDelegate.js with TypeScript 2020-08-11 szuend@chromium.org [issues] Change 'No issues detected' message If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1080589 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I90ff75fe68e1b295e5491f92582265b42a3cd03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348605Reviewed-by:
-
Naoki Fukino authored
I'm going to land implementation (prototype: crrev.com/c/2227714) behind this flag to make it playable/testable on devices. Bug: 1114721 Test: Ran unit_tests Change-Id: I1ed7843216436f91c51fafaebf45e86c79b28821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346094 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#796778}
-
Friedrich Horschig authored
With this CL, the check is automatically started if a user clicks the restart button or navigates to the password check page from a non-safety check origin. The check is run to completion unless all observers unsubscribe before the end of the check (e.g. because their surface is closed). Promoted bugs: * List receives full update for each new credential * The "last run" date range does not seem sensible Bug: 1109691, 1092444 Change-Id: Icfb25b91508d36b938e56cea2516922089963de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346387 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#796777}
-
David Jean authored
Move life cycle to scene delegate instead of app delegate when MW is active. Bug: 1108363,1045579 Change-Id: I8acc693b8a277701d74b1e5d912ce797a74f5e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332607 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#796776}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I046cd133f21f94e876602c439f308bfd760f95fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346689Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#796775}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2bdada43. With Chromium commits locally applied on WPT: 6e0097aa "[WPT] Add tests for sandbox directive for shared/service workers" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I08f318b446be66efaf1cc023f70a8364716b37ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348054Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796774}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/35ae05bf9fc1..870a1acaea40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC apotapchuk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: apotapchuk@google.com Change-Id: I877421ccf6421fd868f6f0abfd4e2789cf4c51a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348600Reviewed-by:
-
Sami Kyostila authored
Use libpango-1.0-0 instead of the old transitional name libpango1.0-0 for installing libpango. Tested on Rodete (which no longer has the old transitional package). TEST=sudo build/install-build-deps.sh Bug: 1114652 Change-Id: I40affdc14d223e339bf6ccb5b33deac248b01279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346184Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#796772}
-
Niels Möller authored
Avoids using wertc's VideoEncoderFactory::QueryVideoEncoder() and CodecInfo::is_hardware_accelerated, features that webrtc strives to delete. Bug: None Change-Id: Ibcb6cd27b2149669a5bd6fda24e68fe5dd19091c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338614Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#796771}
-
My Nguyen authored
Long overdue tests. Added for https://crrev.com/c/2315728. Done after polymer3 migration of os_languages_page at https://crrev.com/c/2308549. Bug: 1106033 Change-Id: Ibaa2fca8c2ba4def0b4da8287dc984ac1a8d4b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345926Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#796770}
-
Christian Dullweber authored
This reverts commit 1d4d72e9. Reason for revert: I don't see flakiness on testers for trunk. Maybe the issue got fixed already and only exists in M85. Original change's description: > Marking SiteSettingsTest.testClearDomainCookies as flaky test. > > TBR=dullweber@chromium.org > > Bug: 1112409 > Change-Id: Idf31c4a8d709ddc3f4f87cff63d63881f0198424 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346853 > Reviewed-by: Ben Mason <benmason@chromium.org> > Commit-Queue: Ben Mason <benmason@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796524} TBR=benmason@chromium.org Change-Id: Idbbd6d8947bc9d986a16ccd094775e49bd7243d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348769Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#796769}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ida69c979cb1e03acd37a8a3a8b92841810e50152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348599Reviewed-by:
-
Hajime Hoshi authored
There are various UKM source IDs that are used in the observers (e.g., the page's UKM source ID or a history navigation's source ID). This change makes the purpose explicit by renaming. Bug: 1112282 Change-Id: I004b382755da57c85700dae8dd3673c823b3f128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338494 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796767}
-
David Jean authored
Change-Id: I4fb60ddc8f9d3595fc000b7b6c8215ee8426ce09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260537 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7b2dd11dda7a..8e1380996d6a 2020-08-11 stevenperron@google.com Handle no index access chain in local access chain convert (#3678) 2020-08-10 rharrison@google.com Roll 2 dependencies (#3677) 2020-08-10 stevenperron@google.com Avoid using /MP4 for clang on windows. (#3662) Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers from 5538bf4386f1 to 3fdabd0da293 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: Ia5d1358ca45abbe7b5fe2d6f464580151f68dedf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348596Reviewed-by:
-
Jaeyong Bae authored
The security icon color in the payment handler should match a color of icon in the regular URL bar. A color is decided according to the theme and security level. Bug: 1052493 Change-Id: I0f818835537f4d77978f390f72ae22d93aa71aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345928Reviewed-by:
-
Clemens Arbesser authored
Bug: b/163423875 Change-Id: Id8c08771d851888551949fedca9e216a68bd2ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346651 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796763}
-
Marc Treib authored
Using a different host was a workaround for crbug.com/1112789. Now that is fixed, we don't need the workaround anymore. Bug: 1110878, 1112789 Change-Id: I916a8baa2d80c447ae6bab25ed7874af3c016c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346426 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#796762}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3903e3a96c5d..33cec725dff9 2020-08-11 szuend@chromium.org [ts] Remove @ts-nocheck in two files where its unnecessary If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib607c52ea4de4f553e6739ad467fa8abe5d4cfa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348597Reviewed-by:
-
Anastasiia N authored
Currently |TestingProfile| initializes Chrome OS Account Manager with |chromeos::DelayNetworkCall|, which uses |NetworkHandler|. It leads to crashes in tests which do not initialize |NetworkHandler| properly. (This code path was not exercised before, but in https://crrev.com/c/2232324 we start using Account Manager in tests and some tests crash because of this issue.) Fix this by not using |chromeos::DelayNetworkCall| and instead supplying a fake runner which immediately executes its callbacks. Bug: 1068240 Change-Id: I220ebc32fa069876f4cd607ba1bae89a35ac7d41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346350Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#796760}
-
Jonathan Wright authored
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/0241a1304fd1..9d4f8005bc6c $ git log 0241a1304..9d4f8005b --date=short --no-merges --format='%ad %ae %s' 2020-07-23 jonathan.wright Remove duplicate MSan check 2020-07-23 jonathan.wright Refactor floating-point test parameters 2020-08-05 jonathan.wright Update libjpeg-turbo to v2.0.5 2020-08-06 enh Use hidden visibility for jpeg_nbits_table. Created with: roll-dep src/third_party/libjpeg_turbo Bug: 922430 Change-Id: I44f24d2500b5b00133a7a2a97973da7217bacce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345312Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Jonathan Wright <jonathan.wright@arm.com> Cr-Commit-Position: refs/heads/master@{#796759}
-
Rushan Suleymanov authored
The feature toggle was enabled by default in M83 and now it is a good time to clean it up with related code. Bug: 1114738 Change-Id: I87a7cb9464a0802a219527e3958e6b33a9708f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346307Reviewed-by:
-
Minoru Chikamune authored
HeapMojoWrapperMode provides tentative modes so that we can keep the original behaviour. But we need to enphasize to use kWithContextObserver. Bug: 1049056 Change-Id: I4ab677a60f1c91824f83f3c29c6c0c2a3cc9e3ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345935Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
sauski authored
The no-search attribute was erroneously left permanently enabled for the cookies-page element after the solidification of the privacy settings redesign. This CL removes the attribute, which should never be present. Bug: 1067336 Change-Id: Ifc56db8e951492d0aee9fdee67efe9f9b7589a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346668Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#796756}
-
My Nguyen authored
Autocorrect range and bounds are wrong after new line because the offset is in a different node. Need to use PlainTextRange instead. Bug: 1114543 Change-Id: I913bd8a2d150388fc034236eba42e5983f765383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344566 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796755}
-
Kent Tamura authored
Add a fieldset check to NGSimplifiedLayoutAlgorithm() to avoid CHECK failures in the following tests. - external/wpt/inert/inert-retargeting-iframe.tentative.html - external/wpt/inert/inert-retargeting.tentative.html They failed in NGPhysicalBoxFragment::CheckSameForSimplifiedLayout() at DCHECK_EQ(is_fieldset_container_, other.is_fieldset_container_). Bug: 875235 Change-Id: I14251ee9385375076317f983e9c21c9f89c51a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346100Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#796754}
-
