- 15 Apr, 2020 40 commits
-
-
Xing Liu authored
This CL implements the eviction logic for HOLD_UNTIL_EXPIRE. 1. The GetEstimatedSize() is based on cache strategy now. 2. Each RunEviction will also check entries for CacheStrategy::HOLD_UNTIL_EXPIRE. TBR=wylieb@chromium.org Bug: 1067049,1058534 Change-Id: I38007b8eeac8cac19a28f10906a711211382838a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144741 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#759153}
-
Toby Huang authored
Tast is using a Chrome extension for testing supervised users, but extensions are blocked by default for supervised users. This CL hard- codes the Tast extension id and always allows it. Bug: 1068265 Change-Id: I2ba7f66877c3113db6da5b55a47d5c007b5c95db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144469Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759152}
-
Philipp Hancke authored
tests the equality of the synchronizationSource, timestamp and type (which is undefined for audio) in addition to frame data equality. BUG=chromium:1069278 Change-Id: If9d3c3de747b6b9ede71a90477e9a8aec88f0716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148603Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#759151}
-
François Beaufort authored
This CL adds a new "panTiltZoom" PermissionDescriptor key to the Permissions API to be used as an extension to camera permission. The normal camera permission can still be queried using {name: "camera"} (panTiltZoom is false by default) while the pan/tilt/zoom camera permission can be requested using {name: "camera", panTiltZoom: true}. navigator.permissions.query({"name":"camera","panTiltZoom":true}) This CL only implements the Permissions API. getUserMedia implementation will follow when detection for PTZ connected/selected camera is added. Spec change: https://github.com/w3c/permissions/pull/204 Manual test: https://ptz.glitch.me/ Bug: 934063 Change-Id: I0884caebfdba3df9d66599cb84f437db9af35b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116070Reviewed-by:Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#759150}
-
Wei Lee authored
Bug: 980846 Test: Launch CCA and CCA can send metrics successfully Tricium: disable Change-Id: I2ed39b7fc1b133fd2ed8d6dc122f029101837b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106984 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#759149}
-
Timothy Loh authored
r754449 removed usage of the aforementioned string but not the string itself. Bug: 1041311 Change-Id: I8f4298f974f51839a625393a5fbce25326d36e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149480Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#759148}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2888ca384f7b..422a2f9fece9 Created with: gclient setdep -r src-internal@422a2f9fece9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1070150 Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com Change-Id: Ic6655eb1a50d1bdf1ccddc583b0f7f410b7c3ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149878Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759147}
-
yjliu authored
Bug: 1035639 Change-Id: I274e2e2d2ae4285386df6923ee24634956747073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136348Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#759146}
-
Matt Falkenhagen authored
These can help figure out what happens in the life of a request, as otherwise it can be hard to figure out which implementation of the Mojo interfaces are being used. Change-Id: I24e2e33cd45cf80e936b2feba62c0dab62463e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147162Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#759145}
-
Kent Tamura authored
This CL introduces LayoutNGRubyAsBlock, which is LayoutNGBlockFlowMixin<LayoutRubyAsBlock>. <ruby> with display:block uses it if LayoutNGRuby flag is enabled. This CL has no behavior changes. Bug: 1069817 Change-Id: Ia8c80ed4727a0788f1a8c2a1a502ceabd5ebab96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147408Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#759144}
-
Ramin Halavati authored
Profile API are updated for better support of multiple off-the-record profiles (issue 1033903) and Independent OTR profiles will be deprecated. This CL updates HatsHatsSurveyStatusChecker to use the newer profile APIs and removes the dependency on Independent OTRs profiles. Bug: 1033903 Change-Id: Ief2ff3e1462c469d6adab2de3f2f40531b245835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144036 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#759143}
-
Johann authored
Use HeapMojoRemote wrapper so that Oilpan will GC the object. BUG=chromium:1049056 Change-Id: I79e80eecadf9f15c43ef2a1f952440b8b677b6aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145744 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#759142}
-
Gyuyoung Kim authored
This CL migrates filter-region-transformed-composited-child [-expected].html tests from css3/filters to external/wpt/css/filter-effects with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to filter-region-transformed-composited-child-001[-ref].html to be align with existing test naming style. Bug: 1063749 Change-Id: Ie6b779978770416df22cf702b377c4d04b207033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143021Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#759141}
-
Wei Lee authored
Originally, for reprocess request, we will put the Jpeg orientation information when constructing the second request. However, the frame data is actually filled when processing the first request. If the orientation changes between these two requests, we might put the wrong orientation into the second request which is inconsistant to the actual image data. Therefore, this CL stores the orientation information when constructing the first request and use that info for the second request. Bug: b/153828264 Test: Manually test on Kukui and it works as expectation Change-Id: Ic19a395b21ed934efca46b160ae18fd223ded6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143179 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/81d176721689..8073a50204ee git log 81d176721689..8073a50204ee --date=short --first-parent --format='%ad %ae %s' 2020-04-15 ehmaldonado@google.com gclient: Set with_branch_heads if asked to sync to refs/branch-heads/* 2020-04-15 ehmaldonado@chromium.org Revert "metrics: Use vpython3 instead of sys.executable" Created with: gclient setdep -r src/third_party/depot_tools@8073a50204ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1068263,chromium:1070545 Tbr: agable@chromium.org Change-Id: I9d94595c75c7f1dcf3f7c90b52bbd6aa009857d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147720Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759139}
-
Wanming Lin authored
This CL removes duplicated tests in wpt and moves uncovered checkpoints from those duplicated tests to existing tests. Tests in device-orientation-on-secure-origin.https.html are covered in several existing tests. devicemotionevent-init.https.html duplicates with motion/optional-event-properties.https.html deviceorientationevent-init.https.html duplicates with orientation/optional-event-properties.https.html motion/add-child-listener.https.html duplicates with device-orientation-events-of-detached-documents.https.html orientation/window-property.https.html, motion/window-property.https.html duplicate with idlharness.https.window.js t001-manual.https.html, t002-manual.https.html, t003-manual.https.html duplicate with orientation/add-listener-from-callback.https.html t021-manual.https.html, t022-manual.https.html, t023-manual.https.html duplicate with motion/add-listener-from-callback.https.html ondeviceorientationabsolute.https.html duplicates with orientation/deviceorientationabsoluteevent.https.html Bug: 816462 Change-Id: Ic1f604e144a6a853c989f1596873d079247f21f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147359Reviewed-by:
-
Alexandre Courbot authored
V4L2Buffer::GetVideoFrame() is an internal method that is never exposed outside of V4L2Device. Change a regular error handling (which would be the way to do if this was exposed) into a NOTREACHED() so we catch potential bugs in our code. BUG=None TEST=VDAtest --use_vd passes on Kukui. Change-Id: Ide5cf00447df154d39d1400d156633ea67b45e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143426 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#759137}
-
Yue Zhang authored
* Instead of holding on to references of RecyclerViews to check tab switcher state within two Activities, use Espresso style checks. Benefits of doing so are: 1) Espresso style requires us to use moveActivityToFront() to bring current activity to the front, which makes tests more readable. 2) It aligns better with the approach that we are using across tab_ui. * Use helper functions from TabUiTestHelper. Bug: 1017141 Change-Id: I939fc48f258a0c0b8089fd91a1492f0479370cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145076Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#759136}
-
Eric Willigers authored
LaunchReleaseNotesImpl() now uses web_app functionality instead of relying on the Extensions implementation of Bookmark Apps. Bug: 1070469 Change-Id: Ib42a0ca72c5e4ef0f0cfd6f0c0095b9a84b0a063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149727Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#759135}
-
Alexandre Courbot authored
Add a simple method that allows to query a single control of a V4L2Device and use it in the V4L2VDA. This will also come handy for the V4L2VD. BUG=b:149663704 TEST=VDAtest --use_vd passes on Kukui. Change-Id: I9e306fcf4115936dde07e8595631b86ceeb6e917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143425 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4a4e82967f41..bce98d0a1b9f git log 4a4e82967f41..bce98d0a1b9f --date=short --first-parent --format='%ad %ae %s' 2020-04-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@bce98d0a1b9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie9f718354b547ef220e03e0ab5626fee108b697e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147726Reviewed-by:
-
John Z Wu authored
- Replace SigninErrorController with the errors wrapped by SyncService - Call opt ins for transport only data - Rely on SyncService state change for delegate callbacks - Introduce some new userInfo keys in the NSError object - Redo unit test to use more fakes Change-Id: Ibb954e142c254627380658dc9af1e624b96edf98 Bug: 1056416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103555 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#759132}
-
Alexandre Courbot authored
jkardatzke@ is to become one of the main owners of the Chrome OS/V4L2/VAAPI parts. Add him to the OWNERS file. BUG=None TEST=None Change-Id: Ic2b13e3e9aa67165e44ba875275c10022019c903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148799 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#759131}
-
Jeroen Dhollander authored
This is a reland of f5bc3fb9 It also includes the rolldep of src-internal, so it also contains the following private CLs that are required: * crrev.com/i/2879257 * crrev.com/i/2837749 * crrev.com/i/2883185 Original change's description: > Reland "Uprev LibAssistant to 1.46s" > > This is a reland of e3f29527 > > Original change's description: > > Uprev LibAssistant to 1.46s > > > > The current LibAssistant branch (1.42c) is no longer maintained, > > and also does not contain the latest features. > > > > * This will only be landed after M83 branches > > * This depends on the internal changes to land first > > > > Note: > > Bug: b/152777569 > > Change-Id: Ic34b6ca3ba1d793c719ebb58ab9766e943fc5ec6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134617 > > Commit-Queue: Jeroen Dhollander <jeroendh@google.com> > > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > > Reviewed-by: Tao Wu <wutao@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#758408} > > Bug: b/152777569 > Change-Id: I2aa720f229708d8ccfac7656a5d5d41606a13b37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147808 > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Jeroen Dhollander <jeroendh@google.com> > Cr-Commit-Position: refs/heads/master@{#758603} Bug: b/152777569 Change-Id: I3b044b99b85ae73184085d6abc4b54aecfe64a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148067Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#759130}
-
Donna Wu authored
Bug: 520391 Change-Id: I2dc1160947ea6b97ee5dc7e5d5cf5ca57e57b1e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145263 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
-
Alexandre Courbot authored
The ApplyResolutionChange() method is already called in the right sequence, so we can call our own callback directly instead of posting it as a task. BUG=b:149663704 TEST=VDAtest --use_vd passing on Kukui. Change-Id: I78407ecfa42c79753263ae09c5542caa525af6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143424 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759128}
-
chrome://appsDaniel Murphy authored
R=calamity@chromium.org, loyso@chromium Fixed: 1070185 Change-Id: I84aafb1203586e272bb0d68d8f0aed49f0d7f827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147805 Auto-Submit: Daniel Murphy <dmurph@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#759127}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 1067031 Change-Id: Iedab6684bf2cc2a18e9ddd04154cb121d69d5d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147404Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759126}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ibb49659029e01fbfeb3fd79d6ea938ec21fdd18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147725Reviewed-by:
-
Xiaocheng Hu authored
Currently, there are two different invalidation code paths for font-face related changes: 1. Via FontSelector::FontFaceInvalidated(). This is called when: - The loading status of a font changes - A FontFace is changed via the JavaScript API This code path also allows partial style invalidation when the feature CSSReducedFontLoadingInvalidations is enabled; Otherwise, it marks the full document's style as dirty. 2. Via StyleEngine::InvalidateForRuleSetChanges(). This is called when StyleEngine identifies changes in the active @font-face rules. It marks the full document's style as dirty. This patch makes (2) to also use FontSelector::FontFaceInvalidated() to update style and layout, instead of directly marking full document style dirty. As a result: - When the feature is enabled, @font-face rule changes don't need full document style recalc - We no longer need to compare FontSelector versions in style diff. This is required by partial layout recalc for font loading - There is no essential behavioral change when the feature is disabled, since in that case both code paths mark style dirty on the full doc Note: there's also a renaming to certain variables & functions to make code more readable, since what they actually rebuild is FontFaceCache instead of FontCache. Bug: 441925 Change-Id: I5207e99fdb7e610bcdedc4c7b3615b0c13b69c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147687Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/05dc1d6cad93..b2bcf0eb3a4d git log 05dc1d6cad93..b2bcf0eb3a4d --date=short --first-parent --format='%ad %ae %s' 2020-04-15 rwkeane@google.com Discovery: Multi Network Interface part 2 Created with: gclient setdep -r src/third_party/openscreen/src@b2bcf0eb3a4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I0e0b1579dfb116e9bba757387789c4aede94b374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150086Reviewed-by:
-
Anne Lim authored
Temporarily cache the result of unmask calls on a page. The card can be filled again later without attempting to auth. This is cleared upon page navigation. Bug: 152444825 Change-Id: I5d6706a488a2c50694d481e1ea07e051d68ef4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134610 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#759122}
-
Justin Cohen authored
This reverts commit 79d88adc. Reason for revert: Fix test. Original change's description: > [ios] Disables failing tests in RestoreTestCase. > > These tests are attempting to load an invalid URL that happen to no > longer be invalid. > > TBR=justincohen@chromium.org > BUG=1070790 > > Change-Id: I03df3f99989b70013e4a047c3636f7e0b5d45fc4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148029 > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Commit-Queue: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759036} TBR=rohitrao@chromium.org,justincohen@chromium.org Change-Id: I31bc8c06a54f2d106e5b040ced6730c8bf4fc121 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1070790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150010Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#759121}
-
John Z Wu authored
Change-Id: I1d59001345830e59a0e57834490f9f5afbaa0247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150126 Auto-Submit: John Wu <jzw@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: Ib75716cf8070b3e2b0a91b818fa8317696076c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150186Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759119}
-
Jeevan Shikaram authored
Fixes a bug that did not show the correct web apps in App Management when BMO is turned on. Fixed: 1064877 Change-Id: I38dcd7485c59cd6b9a821b15b14f04c08e7590bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147127Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#759118}
-
Shakti Sahu authored
This CL refactors query tiles into a generalized component 1 - Moved to components/browser_ui/widget 2 - Subclassed generic Tile to QueryTile for query tile usage 3 - Moved XML layouts, drawables, dimensions etc to components as well. 4 - Future clients will have to add their layout resources and specific java classes in the same directory. Bug: 1068687 Change-Id: I48646b8d2f2160cdfbec74cfaa1ebc74ed7dbaf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140921 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#759117}
-
Rohit Rao authored
RestoreIOSLiveTab is not compiled with ARC and therefore is not properly retaining the CRWSessionStorage* which it is passed. Temporarily work around this bug by keeping a strong pointer to the CRWSessionStorage* in ClosingWebStateObserver, until RestoreIOSLiveTab can be fixed properly. BUG=1070852 Change-Id: Ic3d8a4d0cc3c29bfae4f657de06b98aa869b3bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150035Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759116}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e0950f3cd2c6..81d176721689 git log e0950f3cd2c6..81d176721689 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 apolito@google.com upgrade git to 2.26.1 2020-04-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-04-14 iannucci@chromium.org Fix recipe autoroller account. 2020-04-14 ehmaldonado@google.com metrics: Use vpython3 instead of sys.executable Created with: gclient setdep -r src/third_party/depot_tools@81d176721689 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1068263,chromium:1070694 Tbr: agable@chromium.org Change-Id: I9257ae3b42eeedf414af29a5b4cced28f2e16d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149823Reviewed-by:
-
David Black authored
On creation, AssistantSearchProvider will sync its results with the cache of Assistant conversation starters. It will also observe changes to the conversation starters cache to keep itself in sync. Bug: b:153165835 Change-Id: I678bb6c8b8d80148c18c4970107872089d02dd12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140210 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
