- 16 Apr, 2020 40 commits
-
-
dpapad authored
Also migrating test to use Mocha, and eliminating the need to refer to prod code using the cert_viewer namespace. The test code previously was replacing a prod code function as a way to intercept the response handler and make assertions, now replaced by an event instead. Bug: 1028829 Change-Id: Ieb5210965b311743c003a28c425f75d6ac1be462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145934 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#759518}
-
John Z Wu authored
This will allow password autofill to work on already opened pages without doing a navigation or a reload. NSNotification was used because currently there is no good way to go from WebViewAccountPasswordStoreFactory to a CWVPasswordController. Bug: 1056406 Change-Id: I44bc1b2ca8ba3150738584bc705aed4e7d9f394e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151548Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#759517}
-
dpapad authored
Specifically this CL affects the C++ backends of chrome://settings and chrome://terms replacing some call sites of GetRawDataResource() as well as GetStringUTF8(). The latter was somewhat misused, since it's not intended to be used to load entire file contents. GetRawDataResource assumes that underlying files are not compressed, whereas LoadDataResourceString automatically decompresses if necessary. This is one of many CLs, in preparation of compressing all HTML, JS, CSS, SVG files by default (meaning without requiring compress="gzip" to be specified). Bug: 1068407 Change-Id: Ie06dda1c3bd37e66b79aa06ca3ce40a1cf85dc3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151677 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#759516}
-
Victor Costan authored
This reverts commit 24ee6490. Reason for revert: large value wrapping amplifies the IndexedDB Blob leak in https://crbug.com/488851. This CL also disables IndexedDBBrowserTest.DeleteCompactsBackingStore due to brittleness. Re-enabling is tracked in https://crbug.com/1071292. Original change's description: > IndexedDB: Re-enable large value wrapping. > > This CL removes the feature flag gating IndexedDB large value wrapping. > The feature will be rolled out using Chrome's standard waterfall release > model. > > Bug: 844782 > Change-Id: Ie33675293a1c592c8731ab380ae9c55674ee6ae4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056863 > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Auto-Submit: Victor Costan <pwnall@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741600} TBR=dmurph@chromium.org,pwnall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1071257, 844782, 488851 Change-Id: I1ba9fc1402c1831dd7daaa4b88fde68821a9d1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151885 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#759515}
-
John Z Wu authored
- Also removed some unnecessary setup code Change-Id: I65f46565e6c2c1f21da4e8db22b876125c2d6c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151089Reviewed-by:
-
Luciano Pacheco authored
Bug: 1067478 Change-Id: If02f41840491558f3a6c33a07b2e507b8378e184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148919 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#759513}
-
Brandon Wylie authored
Bug: 1066256 Change-Id: I0f8233fd451fd39fea60d07d4e9e8a3e5e311511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148122 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#759512}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I09c2d31c8acce5691b7bea2c49b7551790c7ecb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152107Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759511}
-
Luciano Pacheco authored
Change AppWindowWrapper.launch() to be an async function and to use await when waiting for asynchronous APIs. This allows to change the task queue from running the calls to async APIs to only be used as a lock to synchronize these async calls between AppWindowWrapper.launch() and SingletonAppWindowWrapper.launch(). Bug: 1067478 Change-Id: I04ab4caec274c48e9661d577970b8a09c173d866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143187 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Klaus Weidner authored
Depending on the shutdown sequence, we may get to OnExitPresent via OnPipeConnectionError / NotifyError when the client is not bound. On the assumption that this is due to being called twice, clear the client set to avoid "Cannot issue Interface method calls on an unbound Remote" errors. Bug: 1070806 Change-Id: I1081512948ca175a99707b158e32243eb45d569e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150033 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#759509}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b79724f8. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 788a3bf1 "[css-grid] Migrate grid-auto-repeat-intrinsic.html to WPT" f9b790bb "[css-grid] Fix percentage track sizing functions in size containment" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I902ebb33d70caa291d2ce1ac7b5259d257abf525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151965Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759508}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b1bd631c010d..f1eb13a3e372 git log b1bd631c010d..f1eb13a3e372 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 michael.liao@microsoft.com [Coverage]: Fixing focus for inline reload button 2020-04-16 caseq@chromium.org Only declare trailing optional param names as {type=} in generated JSDoc Created with: gclient setdep -r src/third_party/devtools-frontend/src@f1eb13a3e372 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1070707 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7f85fdd4884262a859be0814a43604076a3ca1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151833Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759507}
-
Caitlin Fischer authored
Bug: 1066910 Change-Id: I6aa4ad45bf3f3b76c71b57091bc7686602f4075f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151333 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#759506}
-
rbpotter authored
SettingsAccessibilityTest is now only used by the OS settings a11y tests, because browser settings a11y tests have been migrated to use SettingsAccessibilityV3Test. Rename the class and folder to reflect this, change the browsePreload to chrome://os-settings, and remove extraLibraries and setup logic that were only used by browser settings. This allows several OS settings a11y subclasses to inherit from the new OSSettingsAccessibilityTest, and avoid needing to override browsePreload. Include the file in the build only on Chrome OS, and remove the line disabling kSettingsPolymer3 as this is no longer respected. Bug: 1069258 Change-Id: I38a719d6156c6e4505f7c63cd9c6a9060b4c1adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150295 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#759505}
-
Kai Ninomiya authored
There are now two copies of the WebGPU CTS: - A build of the cts master branch, in external/wpt/webgpu/. - A build of the glsl-dependent branch, in wpt_internal/webgpu/. This branch depends on a cipd dependency on glslang.js, and is expected to be used with Chromium only. The branch will dissolve back into master when we can migrate the GLSL-dependent tests to WGSL. Bug: 1069302 Change-Id: Iceb75deea668aee56d77c0d0a5f188c79ef9844c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144926 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#759504}
-
Hiroshi Ichikawa authored
Lack of this functionality was revealed in the Trybot failure of: https://crrev.com/c/2137201 With this change, CRWKeyValueObserverForwarder is now created for each call to -addObserver:, not for each pair of (observer, keyPath), to allow restoration of all observations. -startObservingScrollView: is now called in the initializer. KVO against the placeholder UIScrollView is not necessary, but it simplifies the implementation. Otherwise it needs to keep track of two KVO observation states separately (one for observations by |self| and another for external observations) which looks complicated. Bug: 1023250 Change-Id: I2f553d38d319f7b064c8c76e5d13e914ebcef8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147433Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
This CL migrates grid-element-bad-cast.html from fast/css-grid-layout to external/wpt/css/css-grid with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to grid-item-script-002[-ref].html to be align with existing tests. Bug: 1063749, 767015 Change-Id: I6bc718d99b15372882f80cb23d1d2be0c5aa70a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147525 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#759502}
-
Eric Roman authored
Bug: 960874 Change-Id: Iecc7c1a4e22dcc79ac7de28cfc7090339b883f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151889 Commit-Queue: Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#759501}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/edc2dacb3ab5..694ec49ed075 git log edc2dacb3ab5..694ec49ed075 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 bsalomon@google.com GrMatrixConvolutionEffect uses GrTextureEffect Created with: gclient setdep -r src/third_party/skia@694ec49ed075 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I6c4de5d8114165e3db59a7fabe13a12ed2489fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151638Reviewed-by:
-
Hiroki Nakagawa authored
ServiceWorkerNewScriptLoader and ServiceWorkerUpdatedScriptLoader have DCHECKs to make sure the consistency between ServiceWorkerVersion's status and script resource types to be fetched. Before this change, the DCHECKs for importScripts() were a bit laxed. This is because importScripts() was allowed to be called at any time on the service worker lifecycle. However, this was changed spec-wise and implementation-wise, and now it's allowed only during the initial script evaluation and the install event. This CL makes the DCHECKs aligned with the latest spec and implementation. This doesn't change functional behavior. Bug: 719052 Change-Id: Ic9a188b43206a0a2def600f2c5e6ffc0bb752435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148794 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#759499}
-
Andrew Grieve authored
The listed commands no longer work. Change-Id: I224b59577c3cb0f7cc82b0759d49b3e4cd764add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116510 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#759498}
-
Alexander Cooper authored
The WebXrPermissionsApi was approved to launch via finch in M83. This change enables the feature by default for M84+ Change-Id: I8ba4af00b3216b351094204f67a1f267d7fc4256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151847 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759497}
-
Nate Fischer authored
This adds an option to open the Play Store for the current WebView provider. This falls back to launching a browser intent if the Play Store is not installed (ex. on emulators). Bug: 1068856 Test: manual - build for dev channel, click option, play store opens Test: manual - on emulator (no play store), observe browser opens Change-Id: I46824935f53b6d8364dadbade472dda91b67d050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151339Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#759496}
-
Mason Freed authored
With this CL, the .content() property of a declarative shadow root (a <template shadowroot="open|closed"> element being parsed) will return null. Note that this <template> element only exists during parsing, and upon the closing </template> tag being encountered by the parser, the shadowroot will be created, the <template> contents will be moved into the shadowroot, and the <template> itself will be deleted. So this change is only visible from MutationObservers and other script that runs *during* parsing. This CL prevents that script from accessing the contents of the (potentially closed) shadow root. See point #1 at [1] for more context. [1] https://github.com/whatwg/dom/issues/831#issuecomment-608129380 Bug: 1042130 Change-Id: Id096d1b65dc94b7a75afdc6143341eb4521da41a Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133308 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#759495}
-
Johann authored
Previously the Remote connection was lazy-initialized the first time it was used. Change-Id: Ic4d37cb296b15304150b8b0531c97cd8ae08c14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144796Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
-
David Van Cleve authored
The prototype Trust Token API (https://github.com/wicg/trust-token-api) provides new JS functionality with which one can specify certain cryptographic operations to execute along outgoing requests. These operations can affect persistent state stored in the network service, so tests exercising them would be non-hermetic absent additional functionality to reset the state. Additionally, the operations rely on the presence of "key commitments" (collections of cryptographic keys and associated metadata) obtained through the component updater in standard operation; tests need a way to set these keys without relying on the updater. This CL adds testRunner bindings to 1. reset persistent Trust Tokens state and 2. manually set Trust Tokens key commitments so that it's possible to write end-to-end Blink layout tests for the new Trust Tokens functionality. Eventually, the same functionality will likely become available through WPT testdriver, and the Trust Tokens tests will be able to migrate to WPT: since it's slightly more involved to implement equivalent functionality via testdriver, this is a first pass allowing writing end-to-end HTML/JS tests before the equivalent WPT automation exists. Test: Migrate a WPT to use the state reset binding. Fixed: 1061764 Change-Id: I0d8b9458f89e1ba4c641f27a189480028957094d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139444 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#759493}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4c0a21a0882d..b1bd631c010d git log 4c0a21a0882d..b1bd631c010d --date=short --first-parent --format='%ad %ae %s' 2020-04-15 michael.liao@microsoft.com [Accessibility Pane]: Collapse accessibility node on click 2020-04-15 michael.liao@microsoft.com [TabbedPane]: Fix focus bug where the placeholder view would steal keyboard focus upon setting Created with: gclient setdep -r src/third_party/devtools-frontend/src@b1bd631c010d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1045349,chromium:1070731 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2710815786b9ea46e88223923998605d49cae401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151631Reviewed-by:
-
Xianzhu Wang authored
It's not used. Change-Id: I2efa6ceea86bf6a92f45cc88170e523d627304e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151477 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#759491}
-
Kenichi Ishibashi authored
These methods are wrappers of corresponding methods defined in ServiceWorkerStorage. Bug: 1055677 Change-Id: Id2a28050cd156be1b2622adcedbd9d4e1c83046c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144803 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#759490}
-
Lei Zhang authored
- Use content::HasWebUIScheme() in one spot. - Use range-based for-loops and default ctor/dtor. - Better organize the #includes. Change-Id: I46e71a74c7e578b0b5bbb6ed96931117694ebe12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149950 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Daniel Nicoara authored
Whitelist the video encoder library and device such that the encoder works in a sandboxed GPU process. Bug: 1052499 Test: On device making a video call. Change-Id: Iae04f0afeb2945318b54aa623f88ca44cc32ebc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057638Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Doug Steedman <dougsteed@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#759488}
-
Eliot Courtney authored
This function sets a window to the given bounds and display id then waits for the window to update the bounds and display it's on. It returns the new bounds and display the window is on, which may be different to what was requested (e.g. setting the bounds of a window for an ARC app). Bug: 1053851 Test: tast run <eve> lacros.GpuCUJ Change-Id: I00df24df06280559f3e2a5b34c4adb22929f40dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132557Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#759487}
-
Andrey Lushnikov authored
Currently, Input.dispatchMouseEvent uses `RenderWidgetHostInputEventRouter::GetRenderWidgetHostAtPoint` to find a target OOPIF to dispatch to. This moves `Input.dispatchMouseEvent` and `Input.dispatchTouchEvent` to use a more correct `RenderWidgetHostInputEventRouter::GetRenderWidgetHostAtPointAsync` that trips over Mojo for proper hit testing. R=dgozman Change-Id: Ic26797b876d319e94458f7ecbf52cb6d68155d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099229 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#759486}
-
Luciano Pacheco authored
Move tasks code from being an anonymous function in the queue to private async methods, in preparation to remove the task queue and use async and await. Add IGNORE_APP_ERROR in the integration test because now the method createWindow_() logs the error if it fails to create a window. Bug: 1067478 Change-Id: I69360ea65f01e953d84060b253343fe4e7669a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143418 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Karandeep Bhatia authored
Perform the following renames: - rule_indexing_unittest.cc -> declarative_net_request_unittest.cc - RuleIndexingTestBase -> DeclarativeNetRequestUnittest - SingleRulesetIndexingTest -> SingleRulesetTest - MultipleRulesetsIndexingTest -> MultipleRulesetsTest This is necessary because the file and the associated test fixtures now contain non-indexing related tests. It's now meant to be a generic unit test class for declarativeNetRequest. BUG=754526 Change-Id: I71ac1cc1db004b40b0a45f167e43eac97ad6c54e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146290 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Dominique Fauteux-Chapleau authored
Bug: 1069345 Change-Id: I9b7fdcb0dd813ad5432d45e2a4c90a24df7b6e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144252Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#759483}
-
Rohit Rao authored
Adds an iOS-specific version of policy_test_cases.json and uses it to generate unittest cases for policy->pref mappings. BUG=1069528 Change-Id: I80a69f96c70ba45ab4bb2fd20332001f92d06595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151206Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759482}
-
jchen10 authored
Currently ui/resources/cursors/none.cur is used to hide the cursor, which is a dark 1x1 bit bmp. This may cause DWM to do composition with the underlay video at very frame. To solve it, the hidden cursor should be further removed from the screen. Bug: 1069698 Change-Id: I4122a7a2085dbde5a78053e69f29f988a1b20de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145234Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9e1e913c81cd..edc2dacb3ab5 git log 9e1e913c81cd..edc2dacb3ab5 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 mtklein@google.com convert load_store / stack_load_store to new style 2020-04-15 michaelludwig@google.com Revert "Refactor GL and Metal FinishCallback into a helper object." Created with: gclient setdep -r src/third_party/skia@edc2dacb3ab5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I53428dfc2e46ba03bc453972b09666ace5e20bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151632Reviewed-by:
-
Mike Wasserman authored
Add 'onscreenschange' global event when ScreenEnumeration is enabled. Add ScreenChangeMonitor helper class to observe screen change events. WebContentsImpl uses this to notify RenderFrameHostImpls on changes. Use blink::mojom::LocalFrame to dispatch kScreensChange on DOMWindow. Add content_browsertest fixtures for getScreens() and onscreenschange. TODO(crbug.com/1068774): Send screen info with the event. TODO(crbug.com/1071233): Investigate test failures/crashes on Fuchsia. This requires the ScreenEnumeration experimental flag to be enabled: chrome://flags#enable-experimental-web-platform-features OR $ chrome --enable-blink-features=ScreenEnumeration Try with: https://github.com/michaelwasserman/window-placement-demo Bug: 994889 Test: Automated, demo w/flags and manual system screen config changes Change-Id: Ib601245bfe0533f2dee5573b9c302f2bb08a6c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986234 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#759479}
-
