- 11 Apr, 2018 40 commits
-
-
Rohit Rao authored
Recent Tabs tableview cells are no longer marked with the Button a11y trait, so the matcher for the "Other Devices" button needed to be updated accordingly. BUG=825431 TEST=None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2daa26fb0b2aa2fa45d4df0b62361f512fcb243e Reviewed-on: https://chromium-review.googlesource.com/1008046Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#549961}
-
Ria Jiang authored
Fix stack-overflow in hit_test_manager_fuzzer by limiting how many levels of embedding we can have in hit-test data. Updated coverage report: (still ~98%) https://goto.google.com/riajiang-hit-test-fuzzer-report-update Bug: 830183, 831028, 831029 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I53e2203fe47c94b915a4ad1cfee65b5a3b50cc5d Reviewed-on: https://chromium-review.googlesource.com/1007963Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#549960}
-
Nate Fischer authored
With this CL, we only plumb WebViewClient callbacks to the support_library glue code if the WebViewClientCompat supports the relevant Feature. This lets WebViewClientBoundaryInterface extend FeatureFlagHolderBoundaryInterface, because WebViewClientCompat is only instantiated on the support-lib side. The corresponding Android change is http://ag/3877212. Bug: 781764 Test: Manual Change-Id: I66f23e18fabd013c5b4872f3310819608a78394c Reviewed-on: https://chromium-review.googlesource.com/1006051 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Gustav Sennton <gsennton@chromium.org> Cr-Commit-Position: refs/heads/master@{#549959}
-
Eugene But authored
Tabs which don't have any navigation items and display Download Manager UI will be special cased to show 'Download' title, instead of 'Untitled' Bug: 824148 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If781b5b1aadfaa6ee7eb2181d0f3222bfb812705 Reviewed-on: https://chromium-review.googlesource.com/1006036Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#549958}
-
Adrienne Walker authored
This will enable Skia to also have its own independent workaround list, that Chrome can also include while building. This prevents the need for rolls as there is just a loose coupling of workaround names. After this patch, Skia can be updated to have its own workaround list and some header defined at build time to either use Chrome's version or its own internal version of the autogen'd header. Bug: 829614 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I596d315d41bb543106a5f656402043356fdf2737 Reviewed-on: https://chromium-review.googlesource.com/1005362Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#549957}
-
Karan Bhatia authored
This CL makes the following improvements in ExtensionInfoGenerator unittests: - Changes CreateExtensionInfoFromPath to use ChromeTestExtensionLoader. This has the benefit of better mocking the non-test code, since this would use UnpackedInstaller for the test extension, and end up granting it file access (like non-test code). This also necessitates modifying some test expectations. - Changes WrapUnique to std::make_unique. BUG=830112 Change-Id: I420a8e871abef3ebe8db0aedef64cc87fe4b4835 Reviewed-on: https://chromium-review.googlesource.com/1006486Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#549956}
-
Raphael Kubo da Costa authored
Previously, the custom bindings code for CSSStyleDeclaration only create an ExceptionState locally to pass to SetPropertyInternal(). Go back to this behavior and drop [RaisesException] from the setter due to performance issues: [RaisesException] causes an ExceptionState to be generated automatically in namedPropertySetter(), and an expensive CString needs to be created to set the ExceptionState's |property_name| argument. By creating an ExceptionState ourselves in AnonymousNamedSetter(), we can avoid creating a CString altogether and use a custom value for |property_name|. This brings some performance tests back to the values they used to report when we had custom bindings for CSSStyleDeclaration, namely: - blink_perf.css' CSSPropertySetterGetter and CSSPropertyUpdateValue - blink_perf.layout's SimpleTextPathLineLayout Bug: 764633, 829408 Change-Id: I99db6021d4483c5743daa452f9cb532eacda79a7 Reviewed-on: https://chromium-review.googlesource.com/1002881 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#549955}
-
Javier Fernandez authored
Several functions in the editing logic rely in the IsHTMLBodyElement() function to determine whether a node is the body element or not. Since HTML5 spec allows multiple Body elements, we shouldn't use that function and instead compare with the result of GetDocument().body() call. The bug 542529 has been filed as a task to apply these changes. The IsVisuallyEquivalentCandidateAlgorithm function is one of those still calling to isHTMLBodyElement() to determine whether a node is the body element. The consequence is that 2 different bodies could be used as selection boundaries and produce a range selection, even if it's an empty selection (which should be collapsed). This is the root cause of the the bug 825120, which should be fixed with this CL. Bug: 542529, 825120 Change-Id: I7f6b88e53788fb9221fc16166c7f7ba26d942bc4 Reviewed-on: https://chromium-review.googlesource.com/977927 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549954}
-
Lei Zhang authored
Change-Id: I346326a6cc017cdbc97ad1707e628cfc6151cf42 Reviewed-on: https://chromium-review.googlesource.com/1007890Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#549953}
-
Christopher Grant authored
The original URL bar hint text was drawn over the URL bar without being a member of the URL bar's layout. This is fragile, and broke. Now it's simpler and less fragile. Do a bit of URL state cleanup as well. BUG=831646 R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1846d6bee11363ff87c846aca9a4e4ef99430fda Reviewed-on: https://chromium-review.googlesource.com/1008125 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#549952}
-
Rohit Rao authored
This shield will dismiss the presented view controller when tapped. BUG=805154 TEST=With UIRefreshPhase1 enabled on tablet, tapping outside of the Recent Tabs view should dismiss Recent Tabs. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5f723382e5e048078461622b23247d5bbfa24644 Reviewed-on: https://chromium-review.googlesource.com/1007766Reviewed-by:
-
Xi Cheng authored
Change-Id: Ifb8cc1ef4ded42bae8f3e4d0b1dad13533dca2e1 Reviewed-on: https://chromium-review.googlesource.com/1006369Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#549950}
-
Yusuf Ozuysal authored
Right now new tabs opened from a link in Android using the long press context menu, uses the AUTO_TOP_LEVEL PageTransition. Although this is inline with other FROM_CHROME_UI TabLaunchTypes, it signals a change of context whereas the user is moving to use multiple tabs within the same context. Desktop continues to use LINK PageTransitionType in these cases. This change moves to align Android with Desktop, also making TaskTracker correctly track the new tabs opened as in the same task. BUG=828217 Change-Id: Iecb20506a1de08048fbf648c0b03f99d56fd7714 Reviewed-on: https://chromium-review.googlesource.com/1005437Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#549949}
-
Egor Pasko authored
The goal is to launch Chrome in WebApk mode, hosting the "Maps Go" PWA as part of a performance test. With regular WebApk.apk the URL (https://pwa.rocks/) is from a different scope than the maps URL sent from the benchmark via the intent. This causes: 1. Launching ChromeTabbedActivity because of URL mismatch during WebApk verification 2. Even if verification is skipped with --skip-webapk-verification, the CCT-like topmost toolbar will pop out from WebappBrowserControlsDelegate.shouldShowBrowserControls(). To avoid overriding security measures in a few places, this change introduces a new GN target that produces a new webapk that is bound to the maps URL. The specific URL was advised by the maps team for benchmarking purposes. The shortcut names were not modified because duplicating the .grd and its references in GN was verbose and did not seem worth it. The splash screen icon is not modified either, which is OK for benchmarking. Alternatives considered: * start as webapp on --skip-webapk-verification (cons: different codepaths, for example it loads the icon from shared prefs instead of the APK) * introduce another flag to override more security checks Bug: 760498 Change-Id: Id995d283b827bbebbda7e1a56f455d39b171fa87 Reviewed-on: https://chromium-review.googlesource.com/1002656Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#549948}
-
Mike Dougherty authored
The system truncates the middle of the launch screen if content is centered on it and the status bar is visible. Hide the status bar while the launch screen is displayed in order to prevent this distortion. After the application launches, the status bar visibility will be based on the values returned from |prefersStatusBarHidden| methods. Bug: 784130 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1ec35a8cf657e9eceb179b8f9da433fedc20161d Reviewed-on: https://chromium-review.googlesource.com/1005782Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#549947}
-
Wez authored
Bug: 812058, 821764, 831697 Change-Id: I86759e3ed14cdda2e397f67a23481dd1cf5c7844 Reviewed-on: https://chromium-review.googlesource.com/1007882 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549946}
-
Scott Graham authored
I was getting this on `gclient sync`: Removing old SDK from /usr/local/google/work/cr/src/third_party/fuchsia-sdk. Traceback (most recent call last): File "src/build/fuchsia/update_sdk.py", line 99, in <module> sys.exit(main()) File "src/build/fuchsia/update_sdk.py", line 54, in main Cleanup(os.path.join(REPOSITORY_ROOT, 'third_party', 'fuchsia-sdk')) File "src/build/fuchsia/update_sdk.py", line 42, in Cleanup shutil.rmtree(to_remove) File "/usr/lib/python2.7/shutil.py", line 239, in rmtree onerror(os.listdir, path, sys.exc_info()) File "/usr/lib/python2.7/shutil.py", line 237, in rmtree names = os.listdir(path) OSError: [Errno 2] No such file or directory: '/usr/local/google/work/cr/src/third_party/fuchsia-sdk/arch' Not sure how I got in this state, but seems ok to avoid raising during a cleanup task. Change-Id: Id2524b90077507a41c2d87a6709ac2ef3307cc73 Reviewed-on: https://chromium-review.googlesource.com/1006015 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#549945}
-
Misha Efimov authored
Internal issue b/77525665 Bug: 786559 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1e24b1d8f7ed1cc1fd9a2ac211c02f5b2ed54ab6 Reviewed-on: https://chromium-review.googlesource.com/1007644Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#549944}
-
Tien-Ren Chen authored
BUG=756265 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I92274be4c9ed75922d675c7c027c2fcce54709a2 Reviewed-on: https://chromium-review.googlesource.com/1006398Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#549943}
-
Justin Cohen authored
This was broken by crrev.com/548047, which should have been wrapped in a ui refresh flag. Bug: 819460, 831555 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4b081548de5f058a81530d9dd20f369e2e1fca7d Reviewed-on: https://chromium-review.googlesource.com/1008044Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#549942}
-
Sadrul Habib Chowdhury authored
De-virtualize UpdateRootWindowSizeInPixels(), and make sure the root-window's bounds/scale are set only by WindowTreeHost. To allow ash to override how it applies the transforms, introduce GetTransformedRootWindowBoundsInPixels() as a const method. This makes it easier to reason about how LocalSurfaceIds are allocated for a WindowTreeHost (or its root window). BUG=821987 Change-Id: I61f4fd54dbe2ec0034fdb1697deb2b4abd65a41c Reviewed-on: https://chromium-review.googlesource.com/1005566Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#549941}
-
Ian Vollick authored
Previously, we would return the identity transform in this case causing flashes. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I220235f11e9eccab025a97e549bfa1dfca9843b1 Reviewed-on: https://chromium-review.googlesource.com/1007002Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#549940}
-
Bruce Dawson authored
PROCESS_CREATION_MITIGATION_POLICY2_RESTRICT_INDIRECT_BRANCH_PREDICTION_ALWAYS_ON first shows up after the 16299 SDK but we need to use it immediately. Now that the 10.0.17133.0 SDK has shipped we can define it in such a way that Chrome will cleanly build with or without it. Once Chrome requires the 17133 SDK or later we can remove our local define of it. Bug: 808526 Change-Id: I964a75616191e98acf0d7d3c4f570de5c6d9f15a Reviewed-on: https://chromium-review.googlesource.com/1006397Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#549939}
-
Kenneth Russell authored
This was marked failing on Linux/Intel on an older bot. Probably passing by now. Tbr: kainino@chromium.org Bug: 664180 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2f64dac931d031aeb07cbbdb8f6c1420171d8522 Reviewed-on: https://chromium-review.googlesource.com/1007822Reviewed-by:
-
Yuly Novikov authored
BUG=831355 Change-Id: Id214cee1a95b8b665d94ddc197bde7d7d4e80467 Reviewed-on: https://chromium-review.googlesource.com/1006060Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#549937}
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I630ebcf453bd8f60b17183246663d679e7231036 Reviewed-on: https://chromium-review.googlesource.com/1007975Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#549936}
-
Rob Percival authored
Previously, a crash could occur in the following scenario: 1) An inclusion check begins (LogDnsClient::QueryAuditProof() called). 2) A second inclusion check begins but is throttled. 3) A network change occurs, resulting in SingleTreeTracker::pending_entries_ being cleared. Step 3 involves: 3a) The AuditProofQueryImpl corresponding to inclusion check #1 is deleted. 3b) The AuditProofQueryImpl destructor calls its cancellation callback (LogDnsClient::QueryAuditProofCancelled()). 3c) The cancellation callback calls the not_throttled_callback registered during step #2 (SingleTreeTracker::ProcessPendingEntries()). 3d) ProcessPendingEntries() interates over pending_entries_, which is still in process of being cleared and contains a partially-destructed AuditProofQueryImpl - this leads to a crash. By swapping pending_entries_ out into a temporary, the cancellation callbacks will not run until after pending_entries_ has been cleared, avoiding the crash. Future work should be undertaken to investigate the possibility of simplifying the state machine in this code, as the cancellation callbacks could potentially be removed entirely if some refactoring was undertaken to change ownership semantics. Bug: 827841 Change-Id: I7341639dfb0adffcb2ca61933e7388f7513abadd Reviewed-on: https://chromium-review.googlesource.com/989672Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549935}
-
Andrii Shyshkalov authored
R=jchinlee@chromium.org Bug: 731543 Change-Id: I5e5575dbb1fb40facf19f0114bb2e3e5b803bde9 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/1006354Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549934}
-
Christopher Thompson authored
This adds a new histogram for tracking the content types of downloads started over insecure connections (or with insecure redirects). This will help us determine how realistic it would be to start blocking nonsecure downloads of dangerous file types. Bug: 821037 Change-Id: I43484490c46be37dfbcb2e039b3c43584b884d77 Reviewed-on: https://chromium-review.googlesource.com/972375Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#549933}
-
Gabriel Charette authored
Flakes reproducible locally via: net_unittests.exe --gtest_repeat=10 --gtest_filter=NetworkErrorLoggingEndToEndTest* TBR=juliatuttle@chromium.org Bug: 829650, 820950 Change-Id: Ie97028bce64a4c8f5d0fc9d164ad0174ae9f95d5 Reviewed-on: https://chromium-review.googlesource.com/1007643 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#549932}
-
Becky Zhou authored
Make dialog title and contents above button bar scrollable as a whole by using FadingEdgeScrollView. Bug: 812453 Change-Id: I0033c3927b56f8f10938b8472b4ce158467d4c8e Reviewed-on: https://chromium-review.googlesource.com/940433Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#549931}
-
Xiaocheng Hu authored
This patch adds a utility function to obtain the inline descendants of a paint fragment. It is a preparation patch for crrev.com/c/1000952 Bug: 822575 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id5fcb927a3621607708637984e414f30b50f6d88 Reviewed-on: https://chromium-review.googlesource.com/1006059 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#549930}
-
Emily Hanley authored
This is needed for soft device affinity so we have a way to know which bot each shard ran on last. Bug: 831252 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idfde1b5f85816fdc9f496de2e9bbac4ef8298693 Reviewed-on: https://chromium-review.googlesource.com/1005721 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
-
Daniel Murphy authored
For the last 4 years we 'saved' the new schema version number, so any v2 databases are never marked as v3. The 'migration' always deleted all blob files. This correctly upgrades v2 databases to v3 if they have no corrupt blobs. To gather more information we don't blob away corrupt blob backing stores yet, and instead log when we encounter them. This also fixes the enums.xml values for IDB setup errors, which have been missing 'DeleteIndex' and 'ClearObjectStore' (and subsequently have had incorrect reporting on values > 23) since 2014: https://crrev.com/b05831ee Bug: 831316 Change-Id: Ifa11292b6337be09184de1eed1c667cb99057a96 Reviewed-on: https://chromium-review.googlesource.com/1005984 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#549928}
-
Ojan Vafai authored
TBR=ikilpatrick@chromium.org Change-Id: I4cb43256e6fece3299ddda6eab6840f675933522 Reviewed-on: https://chromium-review.googlesource.com/998747 Commit-Queue: Ojan Vafai <ojan@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#549927}
-
Tommy Steimel authored
This CL adds a check in UpdateOverflowMenuWanted to only show the overlay play button when the video is wide enough to avoid clipping the button. Bug: 831429 Change-Id: I484d3623f7c49448e57835f70e27678e858f7518 Reviewed-on: https://chromium-review.googlesource.com/1006399Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#549926}
-
Joe Downing authored
After a recent sync I started hitting DCHECKs when attempting to connect using a debug Android CRD client build. It looks like this is due to the recent refctoring work. I beleive the DCHECKs just have the wrong bool value (they should be checking that the callback members are empty but instead check that they are already set). Reversing the logic allows me to connect. Change-Id: I987ee70610a7deb0b2935bf991ee9bede3aa09dd Reviewed-on: https://chromium-review.googlesource.com/1007493Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#549925}
-
Conley Owens authored
Several of our polling errors are logged without specific reference to the function that was called. This change adds more detail to the logging messages. Change-Id: I49cbee2010379a4f2eb56055974deedf776606da Reviewed-on: https://chromium-review.googlesource.com/1005886Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#549924}
-
Vlad Tsyrklevich authored
Blacklist two functions that can call casted function pointers, there is not an easy way to fix these failures yet. BUG=v8:7164 Change-Id: I39b1a2550a86efe08a721bc2b2ff149656b0e842 Reviewed-on: https://chromium-review.googlesource.com/1002543Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#549923}
-
sczs authored
- Migrates the basic business logic from LegacyHistoryViewController. All the logic has been copied and modified slightly in order to work with a TableView. - Displays History entires, and supports fetching entries while scrolling (fetches 100 entries per query). - Moves TitleFormat from LegacyHistoryItem to history_util. - It currently doesn't show anything on the first StatusSection, but the code was still left there since removing it and adding later could introduce errors. - Moves HistoryInserter and HistoryUtils to the history_ui target. Screenshot: https://drive.google.com/open?id=1IvYBq59ykSj46aGn-YGBUTmYNGZcWEmm Bug: 805190 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5eb5d8160182b49e254c4e91704ed4c5db98aa43 Reviewed-on: https://chromium-review.googlesource.com/997108Reviewed-by:
-
