- 09 Nov, 2020 40 commits
-
-
Dale Curtis authored
This fixes a few different issues with our HLG support: - Windows was missing the DXGI define for HLG. - Windows was not excluding HLG content from the brightness slider. - HLG AV1 was not decoding to P010 where available. To avoid having HLG content scaled by the brightness slider the unused |f| parameter in the skcms_TransferFunction for HLG is used to store the SDR white level. Skia will need to be updated to use this scaling factor to fix HLG based HDR images. gfx::ColorTransform has been updated to use the SDR white level information in its HLG transforms. Bug: 1144260 Test: Manual + updated unittests. Change-Id: Iedd5d4b1ae0e67de685300306384e8a4e6edf086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511269 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#825435}
-
Reilly Grant authored
This change reduces the latency between when a byte is received and when it is available to script by configuring the COMMTIMEOUTS structure so that ReadFile() return immediately rather than either waiting for the buffer to be full or a timeout to be exceeded. The previous timeout of 1ms was insufficient because on Windows the minimum timing interval is frequently 16ms and so this introduced a sizable amount of latency. Bug: 1142799 Change-Id: Ie02cb64162dcf7ee178ab9dfcca614d63f79c13e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522196 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#825434}
-
Chan Li authored
Bug: 1129654 Change-Id: Ie2092143272e93ac9e06a7fc9ae29b4c2f98ad36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523068Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#825433}
-
John Abd-El-Malek authored
Remove FrameTreeNodeIdRegistry which is no longer needed now that networking callbacks are on the UI thread. Change-Id: Ic66af3c207262aac8b955cb15a2f4a4922e0d898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524281 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#825432}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011090600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/E4D0gMpEOK-9ZjBkcQ2WWgNdHFGpHjbbbc5Y1U0IVywC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/172781941 Tbr: media-app@grotations.appspotmail.com Change-Id: I4e3581447c592897a9c3ca81d41970c9ffe5230e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525862Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825431}
-
Raymond Toy authored
All the histograms with expiry date of M85 are removed, along with the corresponding code. Bug: 1088659 Change-Id: I49af6e8a30ae2ed688a36d34d74eb8c817c4e78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519726Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#825430}
-
Tanya Gupta authored
Created a skeleton for the Long Screenshots service. This will eventually be used to call Freeze-Dried Tabs and generate the bitmaps needed for the screenshot. Bug: 1142520 Change-Id: Ia9e9ff5cc79d316ea6048e127c83f70a55c54996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518090Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#825429}
-
Guillaume Jenkins authored
Adds several unit tests for the ReportSchedulerIOS class. The test cases ensure an enterprise report is triggered at the correct times, that the report can be generated successfully, and that error handling is done correctly, including retrying. Bug: 1114853 Change-Id: I8e1ca4019067b40b9df40b0cb008983dec4bd9cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517620 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825428}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I5aba8ef4c7e7ffe29b8840a0828c2d4d0cdec74f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525745Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825427}
-
David Black authored
The context menu will only show when the content forward entry point is enabled and will eventually be used to allow the user to enable/disable holding space item previews in the tray. This CL adds and shows the context menu but does not wire it up to perform its intended action. That will be done in the next CL. Bug: 1142572 Change-Id: Ic81bf57b84467d28757b311e73aeacf0eef401b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523905Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#825426}
-
Connie Wan authored
Second CL in a series that introduces the Tab Groups extension API. This CL adds the implementation and tests for all Tab Groups API functions except for Move, which was complex enough to split out. It does not include events yet. Skipping translation screenshots because there isn't a good way to bring up the permissions prompt that I can see. This might be easier to circle back on once the API is out there and at least one extension that uses it exists. Bug: 1106846 Change-Id: I56b9f24ac7323676073855977c381449f49300d1 Skip-Translation-Screenshots-Check: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419971Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#825425}
-
WangHui authored
The ActiveMatch may be null when make a FindRequest with options that kWrapAround is false, while the active_rect in |FindRequestManager| will not update when it is empty then we will show a incorrect tickmark(active_rect of last FindRequest) on Android. so We should reset the active_rect in |FindRequestManager| when there is a new FindRequest. Bug: 1141374 Change-Id: Ieac210a2b72f4f92649e68e1b2e2969fd707dbf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491726Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#825424}
-
Peter Kvitek authored
The previous code used to activate all existing keyboard layouts one by one, then retrieve activated keyboard layout name and compare it to US keyboard layout identifier. The comparison failed since on modern Windows keyboard layout name includes keyboard device identifier (like Dvorak keyboard, etc) in the high word and this caused the last checked keyboard layout to be left active. That layout is rarely a US layout, which caused character to virtual key conversion API ::VkKeyScan() to fail on ASCII character keys. The new code uses LoadKeyboardLayout() API that loads and activates the specified keyboard layout (US English) or leaves system default language of the system, if US English layout does not exist. Bug: 783703 Change-Id: I2cdc1d4984131e455d30a16dbbd9c66c209e686e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521836 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#825423}
-
Ryan Hansberry authored
Nearby Connections invokes ::OnEndpointLost() and ::OnEndpointFound() back-to-back. Without this change, these back-to-back calls cause a crash in Mojo's message passing logic, within the Nearby utility process. Bug: 1145818 Change-Id: Iee297ccb4aadebb71072d6155a1eb6f7ddd63cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523738 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#825422}
-
Clark DuVall authored
This is the parent the system uses when creating ClassLoaders, so it makes sense to match that: https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/java/android/app/ApplicationLoaders.java Startup time improvements: 8% on android-go: https://pinpoint-dot-chromeperf.appspot.com/job/10079579520000 9% on Pixel 2: https://pinpoint-dot-chromeperf.appspot.com/job/16c9aec6520000 3.4% improvement in first contentful paint: https://pinpoint-dot-chromeperf.appspot.com/job/13b83f01520000 Bug: 1146438 Change-Id: I157fb0d69ac8e2e9a4f14887d6530d02e2748090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521936 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#825421}
-
Dominic Mazzoni authored
Previously, any time an AXObject updated its list of children it would compute the set of owned nodes due to aria-owns. This could result in "stealing" a node that was previously the child of a different parent and edge cases or bugs in the tree serializer (because it would encounter the same node twice with different parents). With this new patch, when we encounter a node that might need to change its list of owned children (either due to the aria-owns attribute changing or due to an id previously referenced by aria-owns appearing), the update is queued until later, and then all updates are processed together as part of the kInAccessibility lifecycle phase. During serialization, the aria-owned relationships are thus kept consistent and these problematic scenarios are avoided. All existing aria-owns tests pass and one new regression test is added. One aria-owns test has different expectations because the tree serializer no longer encounters reparenting; this is a good thing! Bug: 1143572, 11397833 Change-Id: If5ded18c76eac3ad5c4f9125c8649a4bcd888628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516258 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#825420}
-
Xi Han authored
In LocationBarLayout#onFinishNativeInitialization, LocationBarPhone#setShowIconsWhenUrlFocused() is called to update the |mFirstVisibleFocusedView| from UrlBar to StatusView. This means the LocationBarPhone doesn't populate extra fade animation in populateFadeAnimations(). However, when Instant Start is enabled, the ToolbarPhone#triggerUrlFocusAnimation() will populate the URL focusing animation before the LocationBarPhone is initialized. Thus, unnecessary animation is created and results in the missing of page info icon. To fix it, ToolbarPhone#triggerUrlFocusAnimation() will early exit before native initialization. Bug: 1137973 Change-Id: I5ce8031df2d0d618495e34cf8badc779e5d639dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521199 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#825419}
-
Emily Stark authored
This CL adds a Finch feature to show a "Suspicious site" Safety Tip when there is a Safe Browsing delayed warning, i.e. when a page is known to be malicious but Chrome is delaying the Safe Browsing warning until user interaction. This will allow us to measure 2 things: - How a Safety Tip influences user behavior on known-bad sites - How omnibox UI treatments influence user behavior when there is something (a Safety Tip) drawing their attention to the omnibox This is implemented by checking if a delayed warning is present (and the relevant Finch feature is enabled) inside ReputationService::GetReputationStatusWithEngagedSites(). There's a bit of trickiness with the Finch features. Delayed warning Safety Tips are controlled with their own separate Finch feature, so that they can be controlled independently of the regular Safety Tips feature. This is so that we can have simultaneous experiments where one enables regular Safety Tips and another enables delayed warning Safety Tips. (We aren't allowed to run multiple simultaneous experiments that both enable the same feature.) Running simultaneous experiments like this could mean that we end up with some users in both experiments, but this should be rare, and even rarer still that a user encounters both different types of Safety Tips (regular and delayed warnings), so this shouldn't affect our metrics. For convenience, I've reused the suspicious sites Safety Tips variant -- both the UI and the SafetyTipStatus -- rather than introduce a new type of Safety Tip. This seemed okay to me because we're not really actively using/studying the suspicious site variant, so I figured we can reuse it for this purpose. This does mean that we'll want to make sure to turn off any existing Finch config for the suspicious site Safety Tip before we run delayed warnings Safety Tip experiments. Bug: 1146471 Change-Id: Ie98a12d0f95b1e4313493697d218385edb58212a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523674Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#825418}
-
Torne (Richard Coles) authored
Use the chrome_orderfile_config config for libwebviewchromium (as is already done for the WebView-only variants of libmonochrome) so that we get the same benefit from orderfile optimisation in this build variant. Bug: 1101454 Change-Id: I7accacb50b988065060517e7ec67eba9107a03b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486120Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#825417}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0e30faf062f7..0bec1380d03d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id50eb4b541244f3f593636d301571731cadb999d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525847Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825416}
-
Scott Lee authored
Re-enable SinkAPI-integration on blink_web_tests. A patch was made in https://crrev.com/c/2519885, and sample swarming tasks show that blink_web_tests with the SinkAPI integration ran acceptably fast enough, compared to it without the integration.. R=bsheedy@chromium.org, chanli@chromium.org,dpranke@google.com CC=robertma@chromium.org,bpastene@chromium.org,nodir@chromium.org Bug: 1141606 Change-Id: Ibb45d081f8d2fd869f2632da066fb461c641b21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523747Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Scott Lee <ddoman@chromium.org> Cr-Commit-Position: refs/heads/master@{#825415}
-
Mark Pearson authored
It seems to be flaky. TBR=marq@chromium.org BUG=1146303 Change-Id: Ibaa9ea626a6179af72a1b98d5660f990b3390f1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526608Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#825414}
-
James Vecore authored
NearbyConnectionsManagerImpl holds a raw ptr to the PayloadTracker and it was not being cleaned up in all cases when the PayloadTracker was destroyed. Fixed: 1145726 Change-Id: I62321c6f9316b4af504d2db01dfa55c871d4c0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523917 Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#825413}
-
Asanka Herath authored
Previously the Privacy Budget project added a tool to generate a list of APIs along with enough information to keep track of which ones have been marked with `HighEntropy`. This CL replaces that tool with one which captures a bit more detail about APIs. Bug: 1144960 Change-Id: I281b713839bf22e38d1963a54290f891dcd624ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515283Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Alex Turner <alexmt@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#825412}
-
Christian Dullweber authored
Also add render test. Bug: 1146983 Change-Id: I3c411741e9043ff780708bed3a49e07b4a197453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526443 Auto-Submit: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#825411}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/40c5e53e7bba..9217d49db032 2020-11-09 m.maiya@samsung.com Vulkan: Add EXT_external_buffer entry points If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I4d781ed887956e4f7360f7fa285203a0d29fec76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525744Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825410}
-
edchin authored
Change-Id: Id54a2d8ce9f5054eb4479e345568e93665133d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523673 Auto-Submit: edchin <edchin@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#825409}
-
Joey Arhar authored
This is the same issue/fix as crrev.com/703403 but for mac. On mac WebPagePopupImpl::HandleKeyEvent is called instead of WebPagePopupImpl::HandleCharEvent, but I'm not sure why. fast/forms/color/color-picker-no-tab-character.html should have already been testing this, but when the test is run on mac it doesn't actually insert tab characters into the input elements, which does happen when testing it manually. After doing much debugging, I wasn't able to figure out why, but I did find that keypress events are another observable side effect which happens in parallel with inserting tab characters, so I added a check for it to color-picker-no-tab-character.html as a test for this change. Fixes: 1146693 Bug: 1011168 Change-Id: Ib395fdad80d92452158c867bafb867e8db08e597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524290Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Sanket Joshi <sajos@microsoft.com> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#825408}
-
Roman Arora authored
polymer_bundled.min.js file size increased by 10 bytes. Fixed: 1147095 Change-Id: Ic56ea90e44aff3aca19701db461451af93c1e978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527185 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#825407}
-
Michael Checo authored
- Options are sorted alphabetically (http://shortn/_nYkelby30A) - "Default" will be displayed before scanner capabilities are loaded or when the scanner does not report any sources. - A follow-up CL will update "getSourceTypeString_" to return localized strings. Bug: 1059779 Test: browser_tests --gtest_filter=ScanningAppBrowserTest.All Change-Id: I148e720ae3345baa069c385f6a977d8d90e809a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508366 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#825406}
-
Mark Yacoub authored
1. Extend Mock DRM Device to get a count of test | modeset and modeset commit flags. 2. Test of the expected number of test modeset and commit modeset on displays enable/disable. BUG=b/172622447 TEST=ScreenManagerTest.{CheckWithNoControllers, CheckWithValidController, CheckForSecondValidController, CheckControllerAfterDisabled, CheckMultipleControllersAfterBeingRemoved, CheckMultipleControllersAfterBeingDisabled} Change-Id: Iac4b1fae4119677dad19b904ff6b1923d18b6a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526944Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#825405}
-
Gauthier Ambard authored
This CL makes sure that when the application doesn't start a new navigation when an error occurs while loading a session restoration page. Fixed: 1138895 Change-Id: I9d0b4558ddccf3f53f9dd8dd7d671434b31f1d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520896 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#825404}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=caseq@chromium.org Change-Id: Ic1010c21616f2349627b9219907376b419d85871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526941 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#825403}
-
Nico Weber authored
Still far from working though. Bug: 1147069 Change-Id: Ie6d519915076fe774c3a2af5fc4e089a6681eb2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526911 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825402}
-
Rainhard Findling authored
Bug: 1087263 Change-Id: I939c65d12c4f1ecbc840d0f6fe9d13fae3f861ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526446Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#825401}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3e17e33724b4..0053fef8a47d 2020-11-09 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 8655b62207a5 to 7b750dc7337d (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: I1951967c5c144c2dde7f8cdb56b9ba6c2e9d6c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526605Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825400}
-
Illia Klimov authored
Bug: 1142548 Change-Id: Id0275f770fb2ffa2070438a1d16581d725937fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517492Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Auto-Submit: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#825399}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/8655b62207a5..7b750dc7337d 2020-11-09 bclayton@google.com wsgl parser: Prefix methods with `expect_` If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sarahmashay@google.com Change-Id: Ib70bb2c765bf960b5bc34cfcf89062ea85971e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525874Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825398}
-
Clemens Arbesser authored
With this change, LiteScriptShownToUser and LiteScriptFinished UKM metrics will now be recorded with the native coordinator. Unfortunately, the other two metrics (LiteScriptOnboarding and LiteScriptStarted) are still in Java for now. Recording the UKMs in native allows for better unit tests and tighter control of when to emit those events. This CL also fixes a bug which surfaced during testing: navigation events while the web_contents are invisible should be ignored. This CL does not add any new UKMs. The existing set of UKMs was approved in crbug.com/1110887 in the privacy section of the design doc. Note that this is not yet hooked up to prod. The relevant CL is currently under review, here: http://crrev/c/2524524 Bug: b/172548211 Change-Id: I93cdfc2ac52a33d63247f967063d34a353924833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521810 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#825397}
-
Chris Sharp authored
No-Presubmit: true Bug: 1146426 Change-Id: Idaca0e26e8414d42ffccfccdd8e2a95cf2363770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522235 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#825396}
-