- 14 Oct, 2020 23 commits
-
-
Weilun Shi authored
We want to update histograms with tokens first before updating histograms with suffixes. As we're migrating to the new patterned histgorams, some based histograms will be generated from variants so _UpdateHistogramsWithTokens function need to be aware of that. Bug: 758782 Change-Id: I94910b384d8880b9ed314a8b70dbe831c58a9de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464431Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#816844}
-
Lambros Lambrou authored
This replaces a NOTREACHED() with a basic RTC log writer implementation that simply returns a protocol error to the client. The RTC log FileOperations class is meant to be download-only, but the file-transfer protocol permits the client to try to upload files to it. This code-path is never intended to be exercised - this CL simply prevents the host from crashing in this situation. Bug: 1122798 Change-Id: I838e575530a89b837f64f2fe28c29fd291a88820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461225Reviewed-by:
Erik Jensen <rkjnsn@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#816843}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ie480e82698afba82b4a34cbef6bb717d707b7214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469696Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816842}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7d87fc47381a..cae3bad79262 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alancutter@google.com,marshallk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: alancutter@google.com,marshallk@google.com Change-Id: Ia1592b0140b50f77a6a7de18a46fa05a9d906cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469657Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816841}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/095444c21262..0150a791fcb7 2020-10-13 treehugger-gerrit@google.com Merge "docs: fix instructions for adb shell perfetto" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ife68d0e14a99d03a65cf378e3f61d21d68bb1433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469658Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1148dc0fdaad..ad59e7a16b5d 2020-10-14 jalyn@microsoft.com Show tooltips on keyboard focus If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id3b446ef09ec3d4553deb9e2084c6bd80cc55982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469665Reviewed-by:
-
Alexandre Courbot authored
BUG=b:153935975 TEST=Chromium builds for arm-generic. Change-Id: I9d4fe6fc3345e6b78240e8218603e50a8dd7e1d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460528 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#816838}
-
Avi Drissman authored
If the user attempts to open a file selection dialog but they are disabled by policy, the policy code attempts to show a warning infobar. Do not crash in the case where it is not possible to show an infobar. Fixed: 1137482 Change-Id: I64c02a42e8c84293e73ec3eefb3d72323c933a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469256 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816837}
-
Findit authored
This reverts commit 4363f493. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 816834 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQzNjNmNDkzNDNkZjgyZDNiOWJiMmZiYmI1NWJjNDQ0OGVhYmZmNGEM Sample Failed Build: https://ci.chromium.org/b/8866507600045542768 Sample Failed Step: compile Original change's description: > [PartitionAlloc] Zero on free. > > This CL 'zaps' (`memset`s) the allocated region on free. This may > help detect some instances of UAF, causing them to crash (with > nullptr deref). > > Rather than doing so on every free, we zap probabilistically to > reduce the performance impact. > > If the perf bots show an unacceptable regression, we'll revert this. > But, it might be acceptable. > > Bug: 1005070, 1013329, 1013326, 1013324 > Change-Id: Ia36ee17625290646216985dd6fdffabfa84a9ba2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873272 > Commit-Queue: Chris Palmer <palmer@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816834} Change-Id: I3ebcc5179fa0830faa5c9df8dae63a562cdb0b1b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1005070, 1013329, 1013326, 1013324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469840 Cr-Commit-Position: refs/heads/master@{#816836}
-
Gordon Seto authored
Remove the close button from the disable confirmation dialog as it duplicates functionality already in the cancel button. Remove the confirmation description as it repeats the title. Screenshots: Before: Autoclick: https://screenshot.googleplex.com/uB3ZhRSmVTGSLRg.png Switch Access: https://screenshot.googleplex.com/7WsEbWDBb77MwDg After: Autoclick: https://screenshot.googleplex.com/3DNmukRFCNQ6WoG.png Switch Access: https://screenshot.googleplex.com/3xveLtXSYo86cYL.png Bug: 1125247 Change-Id: Iaf0f008e7e3d6f8fa17ec58eaf7575c27df90303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466508 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#816835}
-
Chris Palmer authored
This CL 'zaps' (`memset`s) the allocated region on free. This may help detect some instances of UAF, causing them to crash (with nullptr deref). Rather than doing so on every free, we zap probabilistically to reduce the performance impact. If the perf bots show an unacceptable regression, we'll revert this. But, it might be acceptable. Bug: 1005070, 1013329, 1013326, 1013324 Change-Id: Ia36ee17625290646216985dd6fdffabfa84a9ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873272 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#816834}
-
Kenichi Ishibashi authored
To remove ServiceWorker{Registration,Version} dependencies from the test so that the test can be moved to the Storage Service. Bug: 1016064 Change-Id: Ic1653d69e432bcbcf4f50e725a7c3e70bf29f637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467260Reviewed-by:Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816833}
-
Joe DeBlasio authored
This CL prevents same-document navigations such as history.pushState and fragment navigations from resulting in a closed Safety Tip. Fixed: 1137661 Change-Id: Id0125055147d50c936c26a8763839e1f47244f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468189Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#816832}
-
yjliu authored
Throttling Android apps from ash through wayland protocol. This is done by manipulating the vsync updates intervals in exo. Because vsync is global for all android apps, we don't apply throttle if at least one android app shouldn't be throttled. Bug: 1107201 Change-Id: I39f761f9460120928687058732942739bb26c88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389326Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816831}
-
Kenichi Ishibashi authored
The following test uses ServiceWorker{Registration,Version}. * InstallingRegistrationsAreFindable * OriginTrialsAbsentEntryAndEmptyEntry * AbsentNavigationPreloadState ServiceWorker{Registration,Version} can't be used from the Storage Service. Move the test to service_worker_registry_unittest.cc so that service_worker_storage_unittest.cc can be moved to the Storage Service. Bug: 1016064 Change-Id: I2b1f25c5ac0f0461d51cb2eeaa7d4ccf1f180a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467303 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#816830}
-
Daniel Ng authored
Logging the exo-pointer-flag when Borealis is launched, this is to help debug broken mouse lock issues. Bug: b:170443708 Change-Id: Id06b10e1b6a18a8c20196952f0c331584d9e7feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462977 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#816829}
-
Gyuyoung Kim authored
This CL replaces all uses of web_pref::ViewportStyle with mojom::ViewportStyle to reduce unnecessary type conversions. Bug: 1097943 Change-Id: I60654404773b4c94520bb5a1736d41b0c33dfe28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463000Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#816828}
-
Hiroki Sato authored
This is a follow up of CL:2462883. Android VIEW_TEXT_CHANGED event is value changed or name changed events in Chrome, and both are handled by AXEventGenerator. Dispatching text changed event is unnecessary, and actually no 1st party accessibility extensions are lisntening this event type. AX-Relnotes: n/a Bug: None Test: tast arc.AccessiblityEvent with CL:2467224. Change-Id: Idcaf2f71c233d4890beee0d6d0fc7584f9fe1ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463001Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#816827}
-
Wei Li authored
Allow builder and metadata access to HomeButton class. Bug: 1130078 Change-Id: Idbe96f4888b9fb77406efbafbe2d04110f7ea8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450848 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Allen Bauer authored
Bug: 772945 Change-Id: I3ef3c5d1dda8d9d37ce165323fdcd384cbe8c5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468944 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#816825}
-
Yulun Wu authored
This CL addresses changes in: https://chromium-review.googlesource.com/c/chromium/src/+/2421441 Bug: 1134800 Change-Id: Idfe0c66caa4c3e9219a7bdc5c61f91a0bb77856c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464343Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816824}
-
Lachlan Ford authored
Updated the OpenXR spec which changes the way extension methods are queried. I separated the extension support enumeration and method querying. Updating the spec retains backwards and forward compatibility with apps as that is mediated through the loader which is unchanged. Extension lookup is now dynamic, and after this change, we can implement AR features on OpenXR (e.g. hand tracking, anchors etc.) Change-Id: I8a4ae718ca244c91b85e02f9441525a9b1416b58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406701Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Commit-Queue: Lachlan Ford <laford@microsoft.com> Cr-Commit-Position: refs/heads/master@{#816823}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ccaef8525710..cac0442277f7 2020-10-13 enga@chromium.org dawn_wire: Support chunked commands If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1123861,chromium:951558 Tbr: enga@google.com Change-Id: I90b182d873c7f1d5c4f1f1e8886d3b84a3c82c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469576Reviewed-by:
-
- 13 Oct, 2020 17 commits
-
-
Michael Irani authored
When in ChromeVox mode and using the touchscreen, the expected behavior: - Single tap on navigation options should announce the name of the option - Single tap, wait, then double tap will actually open the navigation page Removing the pointer-events property above, fixes the issues. The pointer-events property was originally introduced as part of this change: https://chromium.googlesource.com/chromium/src.git/+/2a7833f23c226fa1650883dd30a825bc96e78971https://chromium-review.googlesource.com/c/chromium/src/+/1702788 Bug: 1115704 Test: manual Change-Id: I493a29f7ad631f578a4ce8555f9c3008ac35bdeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468387 Auto-Submit: Michael Irani <michaelirani@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Michael Irani <michaelirani@chromium.org> Cr-Commit-Position: refs/heads/master@{#816821}
-
Collin Baker authored
This is a reland of f5d2f7eb ThumbnailImage's data can be null. This adds a null check to GetCompressedDataSizeInBytes() in which case it returns 0. This reland also adds a unit test for this case. Original change's description: > Add metrics for thumbnail memory usage > > Adds two metrics logged every 5 minutes: > * Per-thumbnail compressed data memory usage > * Total compressed data memory usage > > The former has a sample for each thumbnail every 5 minutes, while the > latter has exactly one every 5 minutes. > > Bug: 11261624 > Change-Id: I1595c6a6b771f73e3be9a5497d1cf6f6ec3d1af7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462685 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Dana Fried <dfried@chromium.org> > Commit-Queue: Collin Baker <collinbaker@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815714} Bug: 11261624 Change-Id: I330f6a74041faf7ee1758e8b5f7a146456161f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463510 Commit-Queue: Collin Baker <collinbaker@chromium.org> Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#816820}
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base and a follow up will remove warning exemption. Bug: 999886 Test: no errors building Change-Id: Ic31911e488e5b2d83ec960b2090dc44b8def25db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468960 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#816819}
-
Eugene But authored
This will allow using PreviousSessionInfo from CrashKeyStringImpl::Set to set variations for synthetic crash reports, see crrev.com/c/2462822 Notable changes: - moves PreviousSessionInfo from //ios/chrome to //components - moves IsMultiwindowSupported(), IsSceneStartupSupported() and generated multi_window_buildflags.h from //ios/chrome to //base/ios (so these functions could be used from components) - old IsMultiwindowSupported() and IsSceneStartupSupported() functions are kept in place to avoid changing the calling code and make cherry-picks easier. Old functions simply call new functions. Bug: 1103752 Change-Id: I700b2c9811890c9ea03d6b1199ee797e2b3f0dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462683 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#816818}
-
Xinghui Lu authored
screenshots: http://dr/corp/drive/folders/1oBaL1kn0atceglGP02LWFVUPPxLLsqx9, files start with v2*. Bug: 1137616 Change-Id: I9e90d6a94fd37b12cade3b60d2ff174416b2a2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469176Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#816817}
-
Mustafa Emre Acer authored
NavigationSuggestion.Event histogram records each lookalike domain in a redirect chain as a separate entry. This slightly overcounts lookalike matches. This CL changes the histogram name to NavigationSuggestion.Event2 and records only one entry per navigation. Bug: 1136296 Change-Id: I5b947d387f3dbc2bef1a95d4171c9ff22526d0f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459430 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#816816}
-
Robert Ogden authored
Adds a new method that returns the URLLoaderCompletionStatus from the URL Loader's OnComplete. This is needed since the completion status provides additional metrics needed to compute fetch duration and encoded body length which are used in https://chromium-review.googlesource.com/c/chromium/src/+/2463544. The returned completion status is Optional to account for cases where the URLLoader never starts, or gets an unexpected response from the network. Bug: 1136174 Change-Id: Ib956135f30ec738f85f22739372387b1093815fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468347 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#816815}
-
Aaron Leventhal authored
- Add null check for MainFrame() similar to elsewhere in VisualViewport::UpdatePaintPropertyNodesIfNeeded() Bug: 1134597 Change-Id: Iaaf6d91788051c650f8ed270787cf47782649053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468737 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#816814}
-
Klaus Weidner authored
This uses an estimated GPU utilization ratio from ArCoreGl. The goal is to reduce the recommended viewport scale if the web app is unable to hit a target framerate due to excessive GPU work, but not do so if it's slow due to excessive JS computations or similar where reducing the viewport wouldn't help. This is opt-in, the scale only takes effect if the app calls view.requestViewportScale(view.recommendedViewportScale) followed by xrwebgllayer.getViewport(view). (Dynamic viewport scaling is only available if WebXRIncubations is enabled.) Spec link for context: https://immersive-web.github.io/webxr/#dom-xrview-recommendedviewportscale Change-Id: I0a8598d8bd03f27fd1d2cc6c542ff79812825d74 Bug: 1133381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213113 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#816813}
-
Maggie Chen authored
For the case of emitting a new surface in SA HandleSurfaceQuad(), We only need to call AddSurfaceDamageToDamageList once. Bug: 1117235 Change-Id: I3ac337aaf0a7876790180636288e60b3c1471963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454569Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#816812}
-
Jason Lin authored
VM media capture state was used only in NotifyVmCaptureState(). This CL makes NotifyCaptureState() take it into account too. UserChooserView is the only class subscribing to NotifyCaptureState(), so it will also display the media capturing red dot now when VM is using the camera or mic. Bug: 167491603 Change-Id: I426a83858eb209ec016e1b77580fd94c5817055c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465895 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
-
Dave Tapuska authored
The callback implemented on RenderViewImpl simply called the blink Autofill client. This can easily be done inside blink. Remove a few other unused functions on RenderWidgetDelegate. There is one subtle change in this CL that WebFrameWidgetImpl instances will react to a DidCompletePageScaleAnimationi now. I believe this is correct because it brings it inline with the focus change code as well which works for WebFrameWidgetImpl. BUG=1097816 Change-Id: I558455385e3abbb2d23b4658ce453eb3483d3929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462680 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#816810}
-
Lukasz Anforowicz authored
The "RequestInitiatorSiteLock" feature has been introduced in r673974 back in Q3 2019, as a way to minimize the risk of shipping NetworkService to all the platforms. Since NetworkService has already shipped everywhere, let's remove the no-longer-necessary feature / kill switch. Bug: 979357 Change-Id: Ie83399aeb56439edbeb130d9e7365dc7fb0ef582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466354 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#816809}
-
Daniel Libby authored
When focus moves from the main WebContents to a guest WebContents, there currently isn't any mechanism to make sure focus moves to the guest WebContents. Due to this, the focus call ends up being a no-op which causes focus not to move along with AT navigation. Ensure the guest web contents is focused before performing the rest of the accessibility focus action which allows it to have the desired effect. This has to happen whether or not the RenderWidgeHostView believes it is focused (which it does in a guest web contents that itself does not have focus). The new test is disabled for ozone wayland - it's passing on all other platforms (including ozone x11) so will probably need an independent platform-specific fix (tracked by crbug.com/1137626). Bug: 1130710 Change-Id: Idd5b9709f255b4085a5268ee52dd6375e88e9412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446789Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#816808}
-
Mounir Lamouri authored
Removing one not very useful and noisy enum entry and updating the timeframe as there will be more work on Picture-in-Picture for Android soon. Bug: 1125691, 1125690 Change-Id: I6190852d0129311590287cb11e2f6538f54c071b Fixed: 1125691, 1125690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463983Reviewed-by:
-
Brian Sheedy authored
Skips the following tests on Nexus 5Xs w/ the validating decoder, as they're flaking on the trybots and making FindIt unhappy despite already having the RetryOnFailure expectation. conformance/textures/canvas/tex-2d-rgba-rgba-unsigned_short_5_5_5_1.html conformance/textures/canvas/tex-2d-alpha-alpha-unsigned_byte.html conformance/textures/canvas/tex-2d-rgb-rgb-unsigned_short_5_6_5.html conformance/textures/canvas/tex-2d-luminance-luminance-unsigned_byte.html conformance/textures/canvas/tex-2d-luminance_alpha-luminance_alpha-unsigned_byte.html conformance/textures/canvas/tex-2d-rgba-rgba-unsigned_short_4_4_4_4.html TBR=kbr@chromium.org Bug: 1095679 Change-Id: I810be0f879136bec193627237ed13e26b8c51b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468566Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#816806}
-
Eric Orth authored
Bug: 1109792 Change-Id: I49997074fe07eeb4dec4d94572d607110898d02d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451379 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#816805}
-
