- 10 Apr, 2018 40 commits
-
-
Aaron Leventhal authored
Fetching the tooltip in the find bar icon's constructor is causing a startup regression. Wait to fetch it once the find bar icon becomes visible for the first time. Bug: 813827 Change-Id: I87d03a6e986d14793e0f5b21781e23cc8fd28549 Reviewed-on: https://chromium-review.googlesource.com/956422 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#549546}
-
kylechar authored
Fix file names for precompiled headers in blink. The case mismatch of build/win/Precompile.h vs build/win/precompile.h was causing errors when cross compiling for Windows on Linux. Also fix some mangled files. Bug: 768828 Change-Id: I56d657a7cbd79dcdd021785fee9d4e9e8d402a9f Reviewed-on: https://chromium-review.googlesource.com/1005276 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#549545}
-
Mikel Astiz authored
Lists another tricky scenario that is currently fixed on trunk, but worth having dedicated test coverage for, considering that some discussed solutions don't work well in this scenario. Credits to pkotwciz@ for discovering. Bug: 828196 Change-Id: I97f248cff717de02ee02203994fc296af9a18dd2 Reviewed-on: https://chromium-review.googlesource.com/1000790Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#549544}
-
Misha Efimov authored
Bug: 812334 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I99f120d624916af57ccbc068e5162b920299fc89 Reviewed-on: https://chromium-review.googlesource.com/984114Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#549543}
-
Daniel Cheng authored
Change-Id: Ia41f32591c6009f2366421850903838d29e35234 Reviewed-on: https://chromium-review.googlesource.com/1005015Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#549542}
-
David Roger authored
Bug: 829218 Change-Id: I4db1e432cbe32b6a0de5a502eba5acb1af3e16d0 Reviewed-on: https://chromium-review.googlesource.com/1005035Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#549541}
-
kapishnikov authored
BUG=830634 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I7930f0578fb5f4981c99da4d36ae2fa385f51d34 Reviewed-on: https://chromium-review.googlesource.com/990154Reviewed-by:
-
Xu Xing authored
To run layout test over SkiaRenderer, need to add flag --additional-driver-flag=--use-skia-renderer. BUG=820356 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic289b19cda9cfcb96bf38217eb20b890bb808f5a Reviewed-on: https://chromium-review.googlesource.com/1001872Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#549539}
-
David Roger authored
A lot of the usage can be replaced by simple calls to the token service itself. This is better, because the delegate is not meant to be exposed. Change-Id: I8e4813308c890e0bccad03779f429fa902066178 Reviewed-on: https://chromium-review.googlesource.com/995893Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#549538}
-
arthursonzogni authored
Check using chrome.app.window.create() with the about:blank URL is not allowed. Bug: None. Change-Id: Ib8ca494921ca588540857b11e81584e686ba590e Reviewed-on: https://chromium-review.googlesource.com/995892Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#549537}
-
Sandra Sun authored
This patch enables smooth scroll for "Find" on Android. This is implemented by setting a "smooth_scroll_for_find_enabled" in WebPreferences so that it can be disabled by tests. Currently, smooth scroll is only enabled for ProgrammaticScrolls. However, "Find" is a UserScroll that doesn't scroll "overflow: hidden" scrollers. This patch also makes sure those scrollers won't be affected by the smooth scroll. Bug: 702966 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I65b5e20b2dad36bc1e6532d20162a643471d43c0 Reviewed-on: https://chromium-review.googlesource.com/978364Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#549536}
-
stkhapugin@chromium.org authored
UITextField appears to use an internal, undocumented and unprefixed -clearButton method. This conflicts with our -clearButton method causing unexpected behavior. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I54434cd143bef76975f7aea1ffe811dc9135eed1 Reviewed-on: https://chromium-review.googlesource.com/962442 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#549535}
-
Florian Uunk authored
This is a resubmit with a fix of http://crrev/960005, after it broke webgl tests. (see revert in http://crrev/1002854). Modification since original CL: In DesktopProfileSessionDurationService::OnSessionEnded, return early if total_session_timer_ is null, which is the case when there was no DesktopProfileSessionDurationService::OnSessionStarted call before it. Original description: This tracker reports the time that the user spent actively using chrome, with their associated sync and sign-in state. Definition of syncing: Having opted in to sync, and sync not being in an "error" state because of a content-area sign-out. Definition of signed in: The user is signed in to the content area. These metrics will let us track: - How long on average users spend being signed in to the content area - How long users on average spend syncing - Which proportion of a user's time is being spent signed in - Which proportion of a user's time is being spent syncing TBR reason: Small change to previously approved CL. TBR=sdefresne@chromium.org, asvitkine@chromium.org Bug: 820188 Change-Id: Ifbcd995d0d32ce4b967f9a6c215ba2fcc5477298 Reviewed-on: https://chromium-review.googlesource.com/1004675 Commit-Queue: Florian Uunk <feuunk@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#549534}
-
Elad Alon authored
AreLogParametersValid() must set the error message when it returns false. This is better ensured by a DCHECK than by a comment. Bug: 775415 Change-Id: I40c4963cc53c8751d681efeffec9f85fc35838b7 Reviewed-on: https://chromium-review.googlesource.com/1004615Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#549533}
-
rodmartin authored
This CL makes the calls to GetSessionList and DoRenameSession safe as was noted in CL 929754. Bug: 830913 Change-Id: I7ad22b5712e032f256bd46ae9f04c28255861af7 Reviewed-on: https://chromium-review.googlesource.com/996472 Commit-Queue: Martin Rodriguez <rodmartin@google.com> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#549532}
-
Christian Biesinger authored
cached_result_ is used for CurrentFragment(); we need to make sure it is up-to-date. Therefore, we can't just refuse to store a fragment if we have unpositioned floats. Instead, we just store the new fragment in these cases and handle the check when checking whether we can reuse the fragment. This supersedes https://crrev.com/c/1001722 Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I934d2290ec496da6dbdd4a8a9c5e3dc78907049e Reviewed-on: https://chromium-review.googlesource.com/1004586Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#549531}
-
Justin Donnelly authored
The existing method of determining whether upload was active was based on whether it was enabled and not protected by an encrypted passphrase. However, we need to also ensure that syncing is in the correct auth state. Using the new GetUploadToGoogleState method does this. Bug: 824090 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I442e0b3513cbfde6af9748dd82c463ffa56e7812 Reviewed-on: https://chromium-review.googlesource.com/978465Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#549530}
-
stkhapugin@chromium.org authored
Rolls MDC and updates the BUILD.gn following the changes in MDC. Bug: 831114 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ida3e76d77c68be7830575a2c261d214c51fd81dd Reviewed-on: https://chromium-review.googlesource.com/1005156Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549529}
-
https://chromium.googlesource.com/angle/angle.git/+log/fe4bbe6cbec6..26084d0aae38 $ git log fe4bbe6cb..26084d0aa --date=short --no-merges --format='%ad %ae %s' 2018-04-09 jmadill Vulkan: Create TextureVk's Image lazily. 2018-04-09 jmadill Optimize Subject's binding method. 2018-03-30 jiawei.shao Use ShaderBitSet for active use bits on uniforms Created with: roll-dep src/third_party/angle BUG=chromium:829906 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I56fc6e687699170e99bd4d210db0b1ac88aedf48 Reviewed-on: https://chromium-review.googlesource.com/1005023 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549528}
-
Devlin Cronin authored
Signature parsing failed in cases where an optional parameter of a certain type was followed by a required parameter of the same type. The parsing was greedy, and would always use a parameter if it matched. This meant that passing a value like `1` to a signature that matched (optional int, int) would fail, because the `1` would be applied to the first optional int, and the second int would be missing. Tweak signature parsing to find the signature that matches the supplied arguments (if any possible signature matches) and resolve the arguments before performing parsing. Update unittests for the same. Bug: 818555 Change-Id: I57c9909ff73505467fb9d333690113bea8eea433 Reviewed-on: https://chromium-review.googlesource.com/993532Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549527}
-
David Bokan authored
This patch fixes the Android find-in-page feature when used by dragging down the tickmarks. The issue was that prior to RLS, absolute coordinates were equivalent to "document" coordinates. That meant that after scrolling, they don't change. When RLS is turned on, absolute coordinates are frame-relative so scrolling will change the location of an absolute rect. This find in page feature would scroll the text match into view and then attempt to zoom in on it. However, because of the above change, the coordinates used for the zoom have now changed. The solution here is to simply query the bounding rect after the scroll into view again. Bug: 828758 Change-Id: I807a05b89707080b1eed1bb3682147411776aa44 Reviewed-on: https://chromium-review.googlesource.com/1004010Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#549526}
-
Mikel Astiz authored
We adopt them already in some existing tests and plan to use them in future patches as part of the migration of session sync to USS. Bug: 681921 Change-Id: I91bcb5b2d0383be89bef1b905e1d3b16259f94bb Reviewed-on: https://chromium-review.googlesource.com/983918Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#549525}
-
Matthew Wang authored
This is a reland of 34f59cac Turns out it was enough to clobber the WebRTC mac builder. Original change's description: > ONC: Add FTEnabled property to WiFi > > Support FTEnabled property in ONC. > > BUG=791202 > TEST=chromeos_unittests > TEST=chrome.networkingPrivate.createNetwork with "FTEnabled":true > enables the device to connect to an FT network. Setting > "FTEnabled":false disables the device from connecting to an FT > network. > > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I2470753fd139505704987e301b18983dc51c5c47 > Reviewed-on: https://chromium-review.googlesource.com/982275 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Matthew Wang <matthewmwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549366} TBR=matthewmwang@chromium.org Bug: 791202 Change-Id: Ia7c49d75e3c7b769e5853e377ef860fef6663abc Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1005114 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#549524}
-
kylechar authored
Make OzoneGpuTestHelper::Initialize() run UI thread tasks after OnGpuProcessLaunched(). In https://crrev.com/c/980574 Ozone DRM was changed so the DRM display controller handle was only accessed on the UI thread to prevent races. This means that when GpuPlatformSupportHost OnGpuProcessLaunched() is called from the IO thread there is a UI thread task that needs to run to finish initialization. This CL adds a RunLoop that runs on the UI thread and immediately posts a task to quit that run loop. That will run any tasks on the UI thread that are pending and then continue, ensuring the Ozone DRM initialization is finished. This should be safe for other Ozone platforms as well. Bug: 830233 Change-Id: I5b2e45c36f7042d59800c0822ca97b13a60a7aab Reviewed-on: https://chromium-review.googlesource.com/1003076Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#549523}
-
Francois Doray authored
Previously, the test ran all pending tasks, waited for all stores to be equal, and then verified that the printer description was equal in all stores. It is better practice not to wait for all pending tasks to run, and instead wait for the specific condition that we want to verify. Bug: 810408 Change-Id: Ifa5fe80368285786664498991c82c1ccdecb5072 Reviewed-on: https://chromium-review.googlesource.com/1003224 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Nicolas Zea (slow) <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#549522}
-
Sebastien Marchand authored
Initial piece of the Site Characteristics Local Database[1], this is the internal class that will be used by the LocalSiteCharacteristicsDataStore. Bug: 773382 Change-Id: Ic125fb1200b0b22bf4c985eff4f140d7db2357c3 [1] @google: https://docs.google.com/document/d/1OODhTnNu4v9dUv6tl6i2vofh0K2DS1OM6EfKs5ewbPA/edit?usp=sharing Change-Id: Ic125fb1200b0b22bf4c985eff4f140d7db2357c3 Bug: 773382 Reviewed-on: https://chromium-review.googlesource.com/976603 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
-
Mikel Astiz authored
The last known device name is already loaded in current_session_name_ by the time InitFromSyncModel() is called, so there's no point in overriding the field with another string that we restore from the persisted state. Bug: 314681 Change-Id: I91abebec85204a8d86a44f35e65bf3803ae1c44e Reviewed-on: https://chromium-review.googlesource.com/1004994Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#549520}
-
Peter Beverloo authored
TBR=jianli, finnur and jamescook for include path changes Bug: 829604 Change-Id: Icb53714ede7a4ce40ca38ee4c79740b64c70997a Reviewed-on: https://chromium-review.googlesource.com/1001894Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
Gabriel Charette authored
As promised @ https://chromium-review.googlesource.com/c/chromium/src/+/999795 Scripted via https://crbug.com/825327#c18 Also cleaning up MessageLoop/MessagePump APIs from now unused types. TBR=fdoray@chromium.org Bug: 825327 Change-Id: I9b458bc24223e57afb3e8a08678f97b2cd8330da Reviewed-on: https://chromium-review.googlesource.com/1003080 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#549518}
-
Gabriel Charette authored
(MessagePumpIOSForIO|MessagePumpLibevent)::FileDescriptorWatcher => (MessagePumpIOSForIO|MessagePumpLibevent)::FdWatchController (MessagePumpIOSForIO|MessagePumpLibevent)::Watcher => (MessagePumpIOSForIO|MessagePumpLibevent)::FdWatcher TBR=fdoray@chromium.org Bug: 825327 Change-Id: Id7268678ace3e713173483abc077c8a27e680554 Reviewed-on: https://chromium-review.googlesource.com/1003058 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by: -
Henrik Grunell authored
Bug: 826664, 830624 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I61b09bfbc5c71d0f8573da8d315475b32727f289 Reviewed-on: https://chromium-review.googlesource.com/1002851 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549516}
-
Adithya Srinivasan authored
- TraverseChildNodes.html has been disabled since it's creation in 2013 - event-target-wrapper.html has been disabled for almost 4 years (https://crrev.com/11fa29bfc9db3ab9befd51719fdd086394570449) and is a "manual" test, it's unclear whether we actually use it - click_webkit_user_select_none.html was disabled (https://crrev.com/8c2c59c239e9d02eb14d88fa7596d0e15caba70d) 2 weeks after it was created, and never fixed after Bug: 825837 Change-Id: Ied18ae861d704f99e215360aecc1caf1a127d97c Reviewed-on: https://chromium-review.googlesource.com/1003081Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#549515}
-
Troy Hildebrandt authored
When cutting/copying text in the URL bar, there's currently an assumption that we're copying a URL and it sends some formatted version of the URL to the clipboard instead of copying what's in the URL bar verbatim. This change allows us to copy the text as-is if we're displaying search terms. Bug: 830050 Change-Id: If45ecdb68a08f2333274a785c29b2c15ce78d9bb Reviewed-on: https://chromium-review.googlesource.com/1003314Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#549514}
-
Aleksei Loshkarev authored
We discover heap use after free in ASAN builds for our signin unit tests. It happens because the asynchronous processing in IdentityManager does not check own lifetime. This cl adds WeakPtr usage for PostTask in IdentityManager. R=blundell@chromium.org Change-Id: I85cbdd4d5da97c0c3d3ab92a01642523c6d0a8f0 Reviewed-on: https://chromium-review.googlesource.com/999607 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
-
Luciano Pacheco authored
This change helps when debugging failing tests by displaying the caller's file name and line number/column when a test fails. I have tested it on |waitForFiles| function and it showed the exact test and file failing when waiting for files that haven't appeared. [31960:31960:0329/003500.134613:INFO:CONSOLE(112)] "Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (112) With this patch: [260320:260320:0405/133233.683120:INFO:CONSOLE(136)] "at /file_manager/directory_tree_context_menu.js:125:23: Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbp ejbbpdbkdjmoco/test_util.js (136) Bug: 829203 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I97e07683b52f107b36ff8af2335e98193ff275b2 Reviewed-on: https://chromium-review.googlesource.com/995242Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#549512}
-
Adithya Srinivasan authored
This CL adds a way to check if an element is focusable without requiring layout to be up to date. This allows us to skip doing a full layout for elements that aren't focusable. Bug: 808503 Change-Id: I9cbcde28262039e908aac6cbc9ce00a057320c30 Reviewed-on: https://chromium-review.googlesource.com/955544Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#549511}
-
Mihai Sardarescu authored
This CL passes the information that the default promo account was selected from the settings WebUI when the user attempts to enable sync. This leads to the right histograms Signin.SigninStartedAccessPoint.{NewAccount|NotDefault|WithDefault} when sync is enabled from settings. This CL is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/986141 Bug: 819431 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I55c7390819ace71ae6cb937248d2d425a5a0396f Reviewed-on: https://chromium-review.googlesource.com/999420 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#549510}
-
Josh Karlin authored
Includes the script of the top stack frame in ads detection processing. Bug: 807640 Change-Id: I8f4d0364ea088bf00abcc7310e4dccce7fec78f3 Reviewed-on: https://chromium-review.googlesource.com/986337 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#549509}
-
Chih-Yu Huang authored
We added Flush() function in VEA interface, but not all devices and drivers support this. This CL adds a new argument "--disable_flush" into VEA unittest to skip checking the flush function. Bug: chromium:829276 Test: Pass video_encode_accelerator_unittest --disable_flush at peach-pit device Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I82477a75178ec6aeb3ebf382b601005455c957a4 Reviewed-on: https://chromium-review.googlesource.com/999233Reviewed-by:Ricky Liang <jcliang@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#549508}
-
Gabriel Charette authored
TBR=fdoray@chromium.org Bug: 825327 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I935efa140d0e97cc91a9d76ae8acbf821eb24312 Reviewed-on: https://chromium-review.googlesource.com/1003221 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
