- 14 Dec, 2017 40 commits
-
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/604f5b9e0422..fe9d640ea90c $ git log 604f5b9e0..fe9d640ea --date=short --no-merges --format='%ad %ae %s' 2017-12-14 dsinclair Create classes for XFA JS objects Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I59061412b1a11f0bcbe0f7c08015aa4f047e78c6 Reviewed-on: https://chromium-review.googlesource.com/827553 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524168}
-
Dale Curtis authored
This uses the player ID assigned to every MediaMetricsProvider per WebMediaPlayerImpl instance to correlate metrics like watch time, video decoder stats, and more. A new Media.WebMediaPlayerState UKM event is added which tracks the player id and final pipeline status. Later on we can add other one-time lazily-generated metrics like time to first frame, or time to load, etc. The player id value is then added to both the existing UKM events for watch time and decoder stats. Also later on we can use this to move more of the metrics logged through MediaInternals today to the metrics provider. BUG=706276,794263 TEST=updated unittests. TBR=bauerb Change-Id: I59ecad7f858b228f1fddb4eb8215b127e606ca93 Reviewed-on: https://chromium-review.googlesource.com/822168 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#524167}
-
Dominic Mazzoni authored
I don't think we currently have a way that this bad cast could be triggered on the open web, we only call hit test on the LayoutView. But it was possible to trigger this bad cast from a test, so we should fix it. Bug: 777150 Change-Id: I8ec81a4a86edd5956936a480e2733e6bee9a5865 Reviewed-on: https://chromium-review.googlesource.com/827528 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#524166}
-
Ian Vollick authored
With this change, button becomes disc button and the base class can be used as a generic button (a thing with hover, press states and a callback). This was used to get hover states in the omnibox suggestions. This change also includes some color scheme changes (mostly for these new buttons, but also brings a number of other colors up to spec). Bug: 777542 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id0262e5c677d2022593e9bf3574dd92c12cfe7f0 Reviewed-on: https://chromium-review.googlesource.com/827034Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#524165}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/0e2365136c55..6ee03a73439b $ git log 0e2365136..6ee03a734 --date=short --no-merges --format='%ad %ae %s' 2017-12-12 dtu [pinpoint] Adjust statistical parameters. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I1153424b3a54f680863e1f12feab056268df2ace Reviewed-on: https://chromium-review.googlesource.com/827529 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524164}
-
Takumi Fujimoto authored
We will record the type of the sink (Cast, Audio, Hangouts, etc.) when Media Router attempts to create a route. Bug: 783850 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I697af8c9d032bfbd0c6033a87261b75a9f408982 Reviewed-on: https://chromium-review.googlesource.com/764188Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#524163}
-
Charlie Andrews authored
This is the last part of a three-sided change in which the return value of StopTracing() was changed from a TraceValue object to a (TraceValue object, list of nonfatal exceptions) tuple. Bug: catapult:#3798 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6e237ce13f7cf263ca453fa47c859f65d1c051b8 Reviewed-on: https://chromium-review.googlesource.com/827549Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#524162}
-
Tim Brown authored
Cinnamon uses a different settings schema to specify the window button layout compared to Gnome. This affects Ubuntu 14.04 using Cinnamon since my change to use GSettings to read the button layout. To fix this I had to add an enum value for Cinnamon. system title bar, and changed window button layout. Bug: 794376 Test: Forced the use of the GSettings provider, ran Chrome not using Change-Id: I2e41df59a71467ac9161751c1fd3e6582c99fdab Reviewed-on: https://chromium-review.googlesource.com/826027 Commit-Queue: Tim Brown <timbrown@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#524161}
-
Reilly Grant authored
This patch adds a new constructor for RefCountedBytes that initializes it with a given length of zeros and non-const versions of the front() and front_as<>() methods to accompany the non-const data() method. This is split out from https://crrev.com/c/786680 which uses this class as a replacement for net::IOBufferWithSize (but with an unsigned buffer). Change-Id: I36c16d02e0a524da3da8679b883321388febaf82 Reviewed-on: https://chromium-review.googlesource.com/822165Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#524160}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/327c9d94..7f26ff95 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ifaf67c873c6fa0f5e7d7201bd0d50aebb779134b Reviewed-on: https://chromium-review.googlesource.com/826087Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#524159}
-
Lei Zhang authored
Change-Id: Iab66904da43d2aaee616f754691e3e0f720637c7 Reviewed-on: https://chromium-review.googlesource.com/826472Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#524158}
-
Jialiu Lin authored
Proto change copied from cl/176384092. This CL expand the "has_user_gesture" boolean field into a enum to include more information on how the navigation happens. Tests updated accordingly. Bug: 780532 Change-Id: Ic13d8472aa6ea3e42f268f92bf46c6cae64f4066 Reviewed-on: https://chromium-review.googlesource.com/802185 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#524157}
-
Ian Vollick authored
This change reverts my previous attempt at sorting the reticle into the list of UI elements. It turns out that this is more subtle than I'd originally appreciated, and until we can come up with a robust approach that avoids all artifacts, I'm reverting to a state where the reticle consistently draws atop all UI elements. Bug: 779692 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I185b70f4c0137a6513c67765c1696fe16f996352 Reviewed-on: https://chromium-review.googlesource.com/826431Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#524156}
-
Stuart Langley authored
This fixes a crashing bug, where an empty WebString is passed to WriteImage for the title parameter. When mojo serializes this it is converted to a WTF::String that mojo detects is null and sends null across the wire. On the receive side it is expecting a non null string so deserialization of the message fails. This patch sends an empty string instead of a null string, which matches the pre-mojo state of the code that used to call Utf16() on the WebString. Bug: 794512 Change-Id: I3eb8d6c23ca6a9ff435802521366f03f7cb60d43 Reviewed-on: https://chromium-review.googlesource.com/826826Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#524155}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0afcd104300d..2e8d8348b857 $ git log 0afcd1043..2e8d8348b --date=short --no-merges --format='%ad %ae %s' 2017-11-30 hinoka gsutil.py: bump default version to 4.28 from 4.13 2017-12-13 watk Add a --dry-run option to git cl split 2017-12-12 maruel roll_dep: Allow rolling multiple dependencies simultaneously 2017-12-12 agable Use core.quotePath=false for more git diffs 2017-12-04 agable Update depot_tools prod win git to 2.15.1.2 2017-12-12 agable Reland "Use core.quotePath=false when git is listing files" 2017-12-11 qyearsley Add more fields to try-results --json for WPT importer 2017-12-12 iannucci Revert "Use core.quotePath=false when git is listing files" 2017-12-07 agable Use core.quotePath=false when git is listing files 2017-12-07 agable git-cl: fix 'status --field=patch' for Gerrit 2017-12-07 agable gerrit_util: Slightly modify retry backoff behavior 2017-12-06 iannucci [led] Reland: Update led to the latest version. 2017-12-06 iannucci [PRESUBMIT] Add cipd package checks for all known manifests. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I2ed7bd5cbee1eae3494dcb87d6571c61238a505a Reviewed-on: https://chromium-review.googlesource.com/826330Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524154}
-
Dominic Mazzoni authored
Bug: 770886 Change-Id: I2f15ece913da0d5d7d21369329005a58fd06aa0e Reviewed-on: https://chromium-review.googlesource.com/827525Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#524153}
-
Vladimir Levin authored
This patch does two things: - Binds the test context to the thread, avoiding a dcheck - Ensures to mark the reader as invalid if we couldn't read textblob data R=ericrk@chromium.org Bug: 794921 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I1cdf8a0c5571587b0d3a66f1a25d99ed5e3daed9 Reviewed-on: https://chromium-review.googlesource.com/827506Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524152}
-
Christopher Cameron authored
These are marked as obsolete in histograms.xml, but are still being generated. Bug: 777695 Change-Id: I02797b2fc00dd5eff444104bc5b665755a360599 Reviewed-on: https://chromium-review.googlesource.com/826143Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#524151}
-
Charlie Andrews authored
The benchmark regularly takes around 2h50m-3h on Android One, and has been regularly timing out for the past several months on the waterfall. NOTRY=true TBR=nednguyen@google.com Bug: 775242 Change-Id: I2945eef4c12bcf9540c93760c33f54df66dffc9a Reviewed-on: https://chromium-review.googlesource.com/827605 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#524150}
-
Justin Carlson authored
BUG=764562 Change-Id: I0e8dfdf4769c78e949da9d662fba0898ce8a98d4 Reviewed-on: https://chromium-review.googlesource.com/776010Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Justin Carlson <justincarlson@chromium.org> Cr-Commit-Position: refs/heads/master@{#524149}
-
Vlad Tsyrklevich authored
gold, used to link on Android and CrOs, does not create a read-only segment. It places read-only sections, like the one for ProtectedMemory, in the read-execute segment and could cause executable pages to be marked read-only. Workaround this by requiring the use of lld on Linux builds while those platforms are ported to lld. BUG=chromium:792777 Change-Id: I5e9fd5cebb96852f1f2891109e1ecca6cd23790e Reviewed-on: https://chromium-review.googlesource.com/823274Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#524148}
-
Stephen McGruer authored
Both EffectStack::GetAnimatedBoundingBox and CompositorAnimations::GetAnimatedBoundingBox are unused, and have been for some time. The functionality involved in them moved to the compositor at one point, then was later deleted from even there. Bug: None Change-Id: I0662e19af9c45dfdf6cba6c897b42479931076f2 Reviewed-on: https://chromium-review.googlesource.com/824565Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#524147}
-
Corentin Wallez authored
BUG=chromium:793055 TBR=zmo@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I47ae5b9c289631b8182c6015e0e975dfb341e6ab Reviewed-on: https://chromium-review.googlesource.com/825147 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#524146}
-
Steven Bennetts authored
This adds a wrapper, IsNetworkSettingsConfigEnabled() so simplify inverting the switch again if necessary. Bug: 380937 Change-Id: I5036beeb359d0381d04ec9ae0fc36a33dfee215c Reviewed-on: https://chromium-review.googlesource.com/818567 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#524145}
-
Andrey Lushnikov authored
This patchs starts running browser-side reload for data URLs. Note: this means that "scriptToEvaluateOnLoad" argument will be ignored when reloading data URLs. BUG=754470 R=dgozman Change-Id: Ib0a07a4395ea2aca881958587e82d18dded81d95 Reviewed-on: https://chromium-review.googlesource.com/823702Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#524144}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7382ee76. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/7713 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts TBR=leon.han@intel.com No-Export: true Change-Id: I11efa6fdb9efe2e84d40af8176fb3a58c4b75784 Reviewed-on: https://chromium-review.googlesource.com/826286 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524143}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/e9188850ec2f..77dd6c28d090 $ git log e9188850e..77dd6c28d --date=short --no-merges --format='%ad %ae %s' 2017-12-14 angle-deps-roller Roll skia/third_party/externals/angle2/ 9af765dd2..9d4d7f06f (1 commit) 2017-12-14 brianosman Remove SkClampRange (unused) 2017-12-14 mtklein quick-reject before transforming images 2017-12-14 brianosman Remove SkColorSpace_Base::MakeNamed, along with most uses of Adobe RGB 2017-12-14 reed convert pipe over to serial procs 2017-12-14 caryclark fix broken flatten example and update usingBookmaker 2017-12-13 reed pre-api change, preparing for expanding metadata 2017-12-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 21f67ae06..9af765dd2 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I72904aff829fa24e7d7be999d7cdf09d4c7a836d Reviewed-on: https://chromium-review.googlesource.com/827162Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524142}
-
Dirk Pranke authored
This CL adds - site_per_process_components_browsertests - site_per_process_components_unittests - site_per_process_content_browsertests - site_per_process_content_unittests - site_per_process_extensions_browsertests - site_per_process_extensions_unittests - site_per_process_interactive_ui_tests - site_per_process_sync_integration_tests to the Linux Tests and Linux Tests (dbg)(1) builders; this will also add them to linux_chromium_rel_ng in the CQ. This CL also removes these tests from the "Linux Site Isolation" builder on chromium.fyi. R=jam@chromium.org, creis@chromium.org, jbudorick@chromium.org BUG=786554 Change-Id: I5b26655138a0120e17a88e1f6aee1ae73cbb8571 Reviewed-on: https://chromium-review.googlesource.com/821554Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#524141}
-
Matthew Jones authored
Metrics indicate that users are more likely to use the bottom sheet when it is quickly swiped open instead of slowly dragged. This change updates the relevant code to handle this. The expectation in this state is that ~50% of useless swipes will be blocked while only blocking ~30% of useful ones (requiring a more deliberate fling). BUG=779615 Change-Id: Iad9928da98da9e95e77052b6bd070553b0d94243 Reviewed-on: https://chromium-review.googlesource.com/825992 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#524140}
-
Dale Curtis authored
This refactors the existing WatchTimeRecorderProvider and the existing VideoDecodeStatsRecorder::SetPageInfo into a common provider interface, MediaMetricsProvider. This is done in preparation of providing a common ID to both that represents the associated WebMediaPlayerImpl instance in a session unique way that can be used for UKM reporting. There are no functional changes in this CL, but the lifetime of the provider interface has changed. The provider interface is now bound to the lifetime of a given WebMediaPlayerImpl instance; again this is do that we can have 1:1 mapping of playback_id to WMPI. BUG=779192 TEST=existing tests all pass. Change-Id: Ia1ff5d99f2bc833fed3a973e0888666a106fdbf9 Reviewed-on: https://chromium-review.googlesource.com/821770Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#524139}
-
Vlad Tsyrklevich authored
As brought up in crbug.com/771365, if this file was compiled with use_gtk3=false it would fail because the declaration of g_gdk_set_allowed_backends was not guarded by the same #if statement guarding its use. Bug: 771365 Change-Id: Ib765cf8d59d7249aeb2f9cb1144121228edf826d Reviewed-on: https://chromium-review.googlesource.com/826622Reviewed-by:
Marshall Greenblatt <marshall@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#524138}
-
Zhenyao Mo authored
BUG=744658 TEST=bots R=piman@chromium.org,danakj@chromium.org,junov@chromium.org,dcheng@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0f75939f5996ad0767214ba817344639332f1f18 Reviewed-on: https://chromium-review.googlesource.com/826252Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#524137}
-
Daniel Vogelheim authored
Bug: Change-Id: I8cae31aaf14516949aa812f2fd65db7503bfeeb2 Reviewed-on: https://chromium-review.googlesource.com/823963 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#524136}
-
Jonathan authored
This is the initial test config for the Linux Viz FYI bot. I'll be adding more tests as we prepare them. Bug: 793820 Change-Id: I13140ef85c2b0c4819b099a83cee343814b8970c Reviewed-on: https://chromium-review.googlesource.com/826424Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#524135}
-
Boris Sazonov authored
This CL moves Profile instance obtaining from ProfileDataCache clients to ProfileDownloader. It improves testability of ProfileDataCache and dependent code by removing requirement for Profile object and allowing simple faking with FakeProfileDataSource. Bug: 746519 Change-Id: Ia81ef9c429384f2b9ec5e04ecb220f9aba90358a Reviewed-on: https://chromium-review.googlesource.com/824662 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#524134}
-
Vadym Doroshenko authored
This CL contains 3 small cleanups. 1.Removed unused functions isAutofilled/setAutofilled (setAutofilled is used, but isAutofilled is not used, so no reasons to keep them) 2.Removed try/catch in getPasswordFormDataList, this function is called only for main frame or same origin iframes. So no need in try/catch. Moreover function fillPasswordFormWithData_, which is called in the same circumstances, doesn't have try/catch. 3.Rewritten for loop by iframes with one line with call of .some(). Bug: 782224 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I72a07181ffd643329b7217825ec182e948b3c57b Reviewed-on: https://chromium-review.googlesource.com/825998Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#524133}
-
Fan Yang authored
Flip quic_reloadable_flag_quic_explicit_close_after_tlp to true. Fix direct reference to FLAGS_quic_reloadable_flag_quic_2rtt_drop_client_cached_certs. Merge internal change: 178764077 https://chromium-review.googlesource.com/c/chromium/src/+/825467 Deprecate FLAGS_quic_reloadable_flag_quic_bbr_fully_drain_queue and gfe2_reloadable_flag_quic_bbr_slower_startup. Merge internal change: 178696596 https://chromium-review.googlesource.com/c/chromium/src/+/824986 In QUIC, add OnStreamFrameLost to QuicSession and QuicStream. No functional change expected. When QuicStream gets chance to write, it will try to retransmit lost data if any before write new data. Add list of streams with lost data to QuicSession. When QuicSession gets chance to write, it will try to let streams retransmit lost data. A special case is crypto stream, as the data needs to be retransmitted with appropriate encryption level. Merge internal change: 178674419 https://chromium-review.googlesource.com/c/chromium/src/+/825146 Deprecate FLAGS_quic_reloadable_flag_quic_frames_deque3. Merge internal change: 178636591 https://chromium-review.googlesource.com/c/chromium/src/+/825145 Add quic_array_size. Merge internal changes: 178382821, 178776675 https: //chromium-review.googlesource.com/c/chromium/src/+/825164 Change-Id: I1006534e79cfaf2890674ea2a4841ab5419838eb Reviewed-on: https://chromium-review.googlesource.com/826083 Commit-Queue: Fan Yang <fayang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#524132}
-
Becca Hughes authored
It looks like some of the bots are still having problems with the preloading browser test. This ensures we use full paths for referencing files. BUG=794629 Change-Id: I814d74bf973968350207e4b6f4879f767c82a225 Reviewed-on: https://chromium-review.googlesource.com/827135Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#524131}
-
Jonathan authored
We want to begin getting coverage of browser_tests with --enable_viz. To start we would like to run them on a Windows FYI bot to find flakes. I'll be triaging the failures found so far, and updating the filter later on with the associated bugs. TEST: viz_browser_tests BUG: 794961 Change-Id: I554af1c3d308da1b7fd0496c08efa24e17bd6799 Reviewed-on: https://chromium-review.googlesource.com/822295Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#524130}
-
Nico Weber authored
64-bit builds have been working for a while now. 32-bit chrome/win still cannot build on Mac hosts due to bug 794838. TBR=brettw Bug: 774209,794838 Change-Id: I762853e7e5d2b4470642402e8b585dfe8f84b53e Reviewed-on: https://chromium-review.googlesource.com/826010 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#524129}
-