- 08 Oct, 2019 40 commits
-
-
Robert Flack authored
sandboxed_zip_analyzer_unittest.cc uses test_utils.h which depends on browser mojom bindings. Add this dependency to resolve build errors. Bug: 1012304 Change-Id: I10b39b3b658eb07c253bf25dc60794fe784c9691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847876 Auto-Submit: Robert Flack <flackr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#703839}
-
Gayane Petrosyan authored
Bug: 1008813 Change-Id: I700da434baeecc626196b7e725adcf1262f558fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829943Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#703838}
-
Ken Rockot authored
This forces the Video Capture Service to run in the browser process on Windows 7 (or, theorectically, older unsupported versions of Windows). Bug: 992328 Change-Id: I89a9a724b656323bb0617dea0f31171ef8e29ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846559Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#703837}
-
Chris Harrelson authored
Bug: 1008483 Change-Id: Ia3a312607d6c1b6785dc4982c305902e4eeb92b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838267Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703836}
-
Nasko Oskov authored
This CL adds some basic tests that verify process model and security expectations of WebUI. It adds basic bindings tests and a test for iframing same WebUI page. More tests will be added to this as work progresses on making WebUI be per frame and supporting site isolation. Bug: 713313 Change-Id: Ib680cf85dbfdee26d40896588edd4d7364332e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835014Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#703835}
-
John Delaney authored
This is a reland of abaf4c65 The original CL introdcued flakes in AdsPLMOBrowsertests. The test loaded the threshold + maximum noise to make the test deterministic. This caused a problem because we also waited for all of that data to be received. When the noise was small, the frame was unloaded before the rest of bytes were received, causing the test waiter to hang indefinitely. These waits were actually unnecessary, so tests were reordered to not use them. There was also a small issue in the change where we were recording the status without noise to the intervention type histograms, which are supposed to use the status with noise. The histogram name does not need to be versioned because this code path is not currently enabled. Original change's description: > Add fuzzing to network threshold for heavy ads > > This CL adds up to 1303 KB of uniform random noise to the network threshold > for the heavy ad intervention. This is to done to prevent frames from > learning cross-origin resource sizes in the clear. > > We add a second computed type metric to measure > the number of frames that we are missing due to the fuzzing. > > Bug: 1010619 > Change-Id: Ia48a4253beafcfbfdbdc689f2ae381dfe5a34c43 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835166 > Commit-Queue: John Delaney <johnidel@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702994} Bug: 1010619 Change-Id: Ie22a1ca0cce402be63d39511e9901fbfba3024e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846313 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#703834}
-
Johannes Henkel authored
Adds a DevToolsSession::FinalizeMessage method which is called just before the message is put on the wire, converting the message to JSON if needed, and sticking it inside a Mojo object. Change-Id: Ie9005a79e3dabf65810ebd727a06460dcf79e9ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846248Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#703833}
-
danakj authored
This was setting the value to 0 after setting up the RenderWidget and applying the VisualProperties. That means that if the browser later tried to set the zoom factor to 0, RenderViewImpl would believe it was not being changed and not do anything. This prevented the browser from controlling the page zoom when there is a default zoom factor applied to all tabs, but it wants to change it back to the default zoom level. R=avi@chromium.org Bug: 1011366 Change-Id: I5d84d3f633bf860947481e05d3ec11d39302afbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845590Reviewed-by:
-
Ted Meyer authored
New UI allows the selection and viewing of events and properties for each media player open on the tab being inspected. This feature depends on enabling the InspectorMediaLogging flag to get any data. What's missing: - A timeline view for events - A right click menu on a media player to inspect it Design Doc: https://docs.google.com/document/d/1NMTjKc-Q99UDTS0QFoftVwhmzZTEh0fsHGQJ6I82IRY/edit#heading=h.vhj3t4rsmjte UX discussion: https://docs.google.com/document/d/1EKuv_KNFFIclJOEx6k70WMUOPgsXJs7DmMHNQayKSuI/edit?ts=5d7c04d2 Screenshots: https://files.tedm.io/dtss/5.png https://files.tedm.io/dtss/6.png Bug: 794255 Change-Id: Iff2d4f057168e7f20829ef4752f6dfcdea75a293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755008Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#703831}
-
Ben Kelly authored
On some platforms the base path timestamp can be a few microseconds different from the file contained in the directory. Relax the DCHECK to permit +/- 10 microseconds difference. Bug: 1002892 Change-Id: Iebdc1685c5b3e48e674f938bd530a5247caef1e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847732Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#703830}
-
Jiawei Li authored
Since this is no longer required, remove the check so that people will not hit this by accident. Bug: internal b/139237561 Test: CQ Change-Id: Id78877054329147ee63816d4d17a9a0b62e4326b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748070Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Jiawei Li <lijiawei@chromium.org> Cr-Commit-Position: refs/heads/master@{#703829}
-
Toby Huang authored
Update kClearCutOAuth2Scope to be "https://www.googleapis.com/auth/cclog" instead of "https://wwww.googleapis.com/auth/cclog". Bug: 1010603 Change-Id: I18afbb69a66a23c55cca782a5b7bfb0cb0334262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846315Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#703828}
-
Martin Barbella authored
In general, we expect it to be easier for developers to reproduce libFuzzer and AFL crashes using these instructions than the tool. Change-Id: Ifecbcf616004c36633bd7e2e0cf4d2e23eceb9ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847867 Auto-Submit: Martin Barbella <mbarbella@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#703827}
-
Abhishek Arya authored
ClusterFuzz relied on NetworkDelegate::NotifyBeforeURLRequest to know a test case's resource dependencies and archive them. This regressed when file url loads were moved to FileURLLoader. Add logging to capture them for file loads. Bug: 715656 Change-Id: Ibb2938a569223534d2b7dc7d757390973a6d172e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845589Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#703826}
-
Bettina authored
chrome://password-manager-internals logs domains for password reuse. Password protection will be expanded to use saved passwords so this will be useful for debugging. Bug: 1010764 Change-Id: Ie26f80740c711326e179c01762439223dfc57d8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846666 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#703825}
-
Lily Chen authored
This change adds a CookieStore method, GetAllCookiesWithAccessSemanticsAsync, which returns a list of all cookies in the CookieStore along with a list of the CookieAccessSemantics for each returned cookie. These lists will be in the same order, so that each cookie in the returned list of cookies has the access semantics at the same index in the other list. This is implemented for CookieMonster only, and other CookieStore implementations will use the default impl which returns UNKNOWN for all the cookies. A later CL will additionally expose this method via the CookieManager interface. Bug: 978172 Change-Id: I8463806f5cc6ce6c8d200bec57bbecba5fe3aec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846071Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#703824}
-
Thomas Lukaszewicz authored
Moved the "single-process-tests" switch definition from the unit_test_launcher.cc to base/test/test_switches.h and base/test/test_switches.cc to conform to the convention used for other test flags in the base project. The motivation for this change to be able to reuse the "single-process-tests" switch outside the base/ project. Bug: 460513 Change-Id: If8fe29a790b51255ec128a93484e4cd494de373a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845959Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#703823}
-
Willie Koomson authored
This change adds a throttle observer for Crostini windows, so that the container is unthrottled while a Crostini window is active. run on device, watch logs to see crostini un/throttle in response to crostini window becoming active/inactive. Bug: 997397 Test: Run CrostiniActiveWindowThrottleObserverTest unittest; build and Change-Id: I8212c9c99995e8901ec0b70de9984e2a04e5def9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845696Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Willie Koomson <wvk@google.com> Cr-Commit-Position: refs/heads/master@{#703822}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/26f21f5e0ac0..81425dcacf74 git log 26f21f5e0ac0..81425dcacf74 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 treehugger-gerrit@google.com Merge "processor: support file descriptors for export_json()" 2019-10-08 hjd@google.com Merge "trace_processor: Add fuzzer test cases" Created with: gclient setdep -r src/third_party/perfetto@81425dcacf74 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ibd8b3111141ac8973f47adebfb239cc24fcebe88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847885Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703821}
-
Kyle Horimoto authored
This CL reverts https://chromium-review.googlesource.com/c/chromium/src/+/1784011. This UI will be implemented in a different way; see discussion on https://crbug.com/1010996. TBR: stevenjb@chromium.org Bug: 1010996 Change-Id: Id97868df660ec86e61d50aa100399c3b96801715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846814 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#703820}
-
Regan Hsu authored
Currently if CrOS and chrome are out of date, the eol_date field of update_engine::StatusResult may not exist, and default to 0, triggering a Final End of Life notification. This issue will never reach end users, but may affect developers who have an old version of cros and a newer version of chrome. The E2E test https://goto.google.com/autoupdate-eol-control in chromium should also change from eol_date=0 to eol_date=1, as sending a 0 will not trigger any changes as initially intended. Bug: 998983 Change-Id: I92a6aadd0721cbde6a6e31b4dda79213ac612083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846093Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703819}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c4823069..a3b4ceff Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie2ab75073c5b6190d217d600f7523f9aedd201a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847811Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703818}
-
Nina Satragno authored
When multiple virtual authenticators are in scope and a MakeCredential request is received, a credential is created on every authenticator due to the way we dispatch requests. Since this reflects the real behaviour (although in reality it's a very unlikely scenario), I don't think it's a bug. This created a non-deterministic failure where the ID of a created credential would not match the expected value on layout tests since the credential returned on an empty allowCredentials request would be the one created on a second authenticator. Fix this by cleaning up virtual authenticators created on individual tests so they do not interfere with each other. Bug: 1010863 Change-Id: Ibe2a987a3bb7a094008ab0c426f09065fc9bb59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847852 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#703817}
-
zhaoyangli authored
Changed headers and moved some function calls to ChromeEarlGrey calls. Will create EG2 test target along with autofill automation framework migration in following CLs. Bug: 987646 Change-Id: I127aada72669c20bb01d87c711644e89a9326886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815582Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#703816}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7efb1a6dbcff..5899485b9a87 git log 7efb1a6dbcff..5899485b9a87 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 herb@google.com Add tests for SkZip first, data, and consting copy ctor 2019-10-08 brianosman@google.com Remove SkCurve and SkColorCurve 2019-10-08 egdaniel@google.com Also blacklist path_text benches on vulkan pixel3a. 2019-10-08 robertphillips@google.com Black list failing test(s) on internal bot 2019-10-08 fs@opera.com Fix mapping the morphology filter's radius when the CTM is a mirror op Created with: gclient setdep -r src/third_party/skia@5899485b9a87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:595244 Change-Id: I82736a6fa64218d7e8abd740215cdd7e49ba8e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846762Reviewed-by:
-
Xiaocheng Hu authored
After turning on CORS for '-webkit-mask-image' (crrev.com/c/1838592), the most visited iframe can no longer perform the cross origin fetch for "chrome-search://local-ntp/images/close_3_mask.png" from its own origin "chrome-search://most-visited/". To prevent this, this patch changes the mask image to be served from the same origin "chrome-search://most-visited/". Since the image is used only by NTP, this patch also moves the image files from ui/resources/ to chrome/browser/resources/. Bug: 786507 Change-Id: I3b44489040c036cf24d8539517cc363d2b510c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841506 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#703814}
-
Mandy Chen authored
The localization parser currently logs the error stack and error message when running without the --autofix flag. Since the stack includes the error message, this CL takes out the call to log the error message to avoid duplicate error messages. Bug: 941561 Change-Id: If8c5f05148be6e2eb666eb17cefe649715006209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820088Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703813}
-
Lei Zhang authored
Move iOS strings from ui/strings/ui_strings.grd to ios/chrome/app/strings/ios_strings.grd. Change-Id: I1e8c443bd3dc3631e77d06cbc4cfc9eb286aeb7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839373Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#703812}
-
Yulun Wu authored
Bug: 1011933 Change-Id: Ia485a0263f891e303fe6906bb608d7ce6e2a67cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846035Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#703811}
-
Albert J. Wong authored
This paves the road for deleting the RenderWidgetHost for RenderViewHosts that do not have an in-process top-level frame by removing unnecessary accesses to the underlying RenderWidgetHost. Bug: 545684 Change-Id: I78b7d93c9f17f767a10ec28a098a99d098bcc60c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846087 Auto-Submit: Albert J. Wong <ajwong@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to logic. This moves WebView's Safe Browsing java code into a subfolder, and links the OWNERS file against //aw/browser/safe_browsing/OWNERS (which has the same ownership as the Java files do currently). This adds a temporary adapter version of AwSafeBrowsingConfigHelper, in order to keep the downstream targets building. Bug: 934597 Test: ninja -C out/Default system_webview_google_apk Change-Id: I81c1ca498a7d6c2d76256b46e734f2cbf8d95b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845882Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703809}
-
Jimmy Gong authored
- Update the empty state of the printer settings landing page. Bug: 1010716 Test: End to End manual, browser tests Change-Id: I69e84035acd0f859f9f707a2550dee16ec9daa9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845993Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Miguel Casas authored
This CL adds the simplest MailboxVideoFrameConverterTest that basically initializes a MailboxVideoFrameConverter and lets it fall out of scope. Later CLs will add more testing. Test: media_unittests --gtest_filter=MailboxVideoFrameConverterTest* Bug: 998279 Change-Id: I74ecb0b02b00cd5d301819e1e8466dc89f0144d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830108Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#703807}
-
John Budorick authored
This reverts commit ed8151f9. Reason for revert: suspected cause of increased CQ false rejection rate, https://bugs.chromium.org/p/chromium/issues/detail?id=1011915 Original change's description: > Change default retries for components unittests to 0 > > Bug: 993428 > Change-Id: Id21490633dfb7ae92f73b0bdc9b2f81191f00ccb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801021 > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Ilia Samsonov <isamsonov@google.com> > Cr-Commit-Position: refs/heads/master@{#700857} TBR=thakis@chromium.org,erikchen@chromium.org,isamsonov@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 993428 Change-Id: Ie9c97d3e250eb5789d7095dd145b66afddf4363d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846805Reviewed-by:
-
Gavin Williams authored
Three places where this was changed: - When opening the Language settings from the notification tray. - When opening the Language settings from the accessibility virtual keyboard. - When opening the Language settings from ARC++. Bug: 1008353 Change-Id: I247380aed63004b61c397726498541485076add7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836551Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
As part of upcoming changes to cellular representation in OOBE, we will no longer be providing the option to attempt cellular activation, so unactivated cellular networks will no longer be able to be chosen. However, omitting cellular networks entirely could confuse users who expect a cellular entry to be on the list. Thus, instead of removing it entirely, we show a "Not available" message beneath the network name. Note that this property is not actually used yet at this time; it will be applied to network_select_login.html at a later time when the rest of the cellular OOBE changes are complete. Bug: 1011574 Change-Id: I157bae86270ff82a432b66d93f6f6bc4d4737d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842222 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Koji Ishii authored
When there are no script segments (i.e., all the text is in single script) and in vertical flow, we create a single segment and split it at the font-orientation boundaries. This patch fixes to create the single segment from the first text item, not from the first item. If it is created from the first item and the first item is not a text item, we may give incorrect script and/or font-orientation to HarfBuzz. Bug: 10061548 Change-Id: I5ea87920f8cbc76cdc13fe25611f7a7a34284813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847697Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#703803}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1ad5811accae..1458d572f950 git log 1ad5811accae..1458d572f950 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 tandrii@google.com recipe_module git: remove non-LUCI mode. Created with: gclient setdep -r src/third_party/depot_tools@1458d572f950 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1012148 Change-Id: I653f2a4dad0c45b7878f829d7554a7968c50a912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846765Reviewed-by:
-
Xinghui Lu authored
Pros: Good memory locality, low overhead especially for smaller maps. Cons: Inserts and removals are O(n). But since the keys are profiles, there shouldn't be too many insert and remove operations. Bug: 995926 Change-Id: I2b26d5ebeba3c12732c3ad71a772afaa0262cf08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845577Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#703801}
-
Lei Zhang authored
Clearly indicate pointer ownership. Fix nits along the way. Change-Id: I721a6c543197f18effe5b050885b7a9a8f3f524b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843394Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#703800}
-
