- 02 Jun, 2020 40 commits
-
-
Joel Hockey authored
App browsers can now support tab strips and should be included in some of the calls to IsBrowserTypeNormal. Added function IsTabStripSupported and changed calls relating to tablet mode in BrowserNonClientFrameViewAsh and ImmersiveModeControllerAsh to use it rather than IsBrowserTypeNormal. Bug: 1090208 Change-Id: I158e24debf44cd68b62725d96e8c287944af4dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226236 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#774384}
-
danakj authored
This moves it out of the site isolation error section. This appears to be a bug in the spec for intersection-observer when dealing with a child local root, and not a bug in the implementation of site isolation or the test (since it's testing a bad spec). R=szager@chromium.org Bug: 1007229 Change-Id: I639cb6ddb1d1a82df837fb0ba466922d29151943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222910 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#774383}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e5cd744fe49e..76a2918f55cd 2020-06-02 vadimsh@chromium.org [lucicfg] Update to 1.14.5. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1082296,chromium:1085650 Tbr: agable@chromium.org Change-Id: I325049adfcc60828bb7e7dd253b1f5a6db3a0418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774382}
-
Jun Mukai authored
Sometimes TrayItemView::SetVisible() can be called repeatedly. An example is PowerTrayView() -- its SetVisible() can be called periodically based on the power status. That causes animation and AnimationProgressed(), but that is redundant. Bug: 1082562 Test: manually Change-Id: I45573360edda49572975966d1a84d4d067edbf13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223432Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#774381}
-
Dominic Mazzoni authored
Tbr: sandromaggi@chromium.org Bug: 1090215 Change-Id: I381c018c9a0b763dbb39a468754c78c895b8a9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227181Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#774380}
-
Miriam Zimmerman authored
BUG=None TEST=None Change-Id: I1d562f0e930b27ab90d814b9ff97c033582e2070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226069Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#774379}
-
Yue Zhang authored
Bug: 1078169 Change-Id: I62bd049309a19ef41bb503fcaff8e1c7ed998847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225533Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#774378}
-
Matt Falkenhagen authored
Bug: 1089495 Change-Id: I8af3f627d076a03a58c61d183f63216ac31add79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226000Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#774377}
-
OlivierLi authored
Under critical memory pressure the system is probably already swapping out memory and making heavy use of IO. Adding to that is not desirable. Furthermore, scheduling a task to write files to disk risks paging-in memory that was already committed to disk which compounds the problem. Bug: 1087530 Change-Id: I2f5ba6e703eef0d804e6f4d99dd504c7eadf7740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227029Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#774376}
-
Mitsuru Oshima authored
The targeter can be null and in that case it should use the parents. Bug: b/157910224 Test: covered by unittest. also tested manually. see bug for repro step. Change-Id: I13db092a6ee062ef9547aec70b6f7cd077558e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225854 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#774375}
-
Adam Norberg authored
The file name doesn't match because the intended next CL is to rewrite ScopedXPCUpdateServiceMock as ScopedXPCServiceMock that takes the @protocol for the XPC service as an argument, and modify the existing test to use it in this manner. I figured splitting it into two CLs would simplify the review. Bug: 1055876 Change-Id: I5134d8f29124538441fe1430ed3cacbdf56dd186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225857 Auto-Submit: Adam Norberg <norberg@google.com> Commit-Queue: Adam Norberg <norberg@google.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774374}
-
Esmael El-Moslimany authored
Third-party search providers may or may not have third-party NTPs. When they do not have a third-party NTP, the local-ntp is used to display the most-visited tiles. Bug: 1087531 Change-Id: I799e252edba04e07601fc43938688cf1d381d183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225625Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#774373}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591113598-81d0db8118cc6885d9786065771de10da2a65ecd.profdata to chrome-mac-master-1591127928-6ca3eedb8c11f1c6551de9c000f330ab07bf1259.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I248eeda08bdd7c40a45bd5a97c40ad833627de26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227167Reviewed-by:
-
Abhijeet Singh authored
For the case when a menu is active, QuickAnswersView currently is unable to obtain the focus because that would require activating its top-level widget, which would cause the menu to disappear like it does on observing any change in the activated window. This CL makes QuickAnswerView's widget a child of the menu's owning widget, as a result of which it can now share the owning widget's FocusManager and successfully request focus. This is needed to incorporate keyboard accessibility for the view. Key or accelerator handling will be added in follow up CLs. Tests are also added. Bug: b:152057976 Test: Tested on Chrome OS VM and ran ash_unittests. Change-Id: I2acbbd5d3f918fffe33d31d8f7764ecf28ffcaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222119Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Cr-Commit-Position: refs/heads/master@{#774371}
-
Eugene But authored
Currently HeapProfilerController uses 24 hours interval for Desktop and Android. While 24h is good for Desktop, the interval is too big for Android, which likely has median process up time of less than an hour. iOS uses 30 minutes interval, which is equal to median process up time duration. 30m would be more appropriate interval for Android. Bug: 1090017 Change-Id: Ia8dfc09a75e036265298e3d69ad04fb8cc1b1124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225359 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774370}
-
Ben Schwartz authored
This change (1) adds dns_over_https to the tests' fake prefs. (2) makes TestPrivacyPageBrowserProxy usable in its default state. (3) adds a check for undefined prefs to secure_dns.js, to match the other privacy preference UI elements. Bug: 1087444 Change-Id: Ic8fb7e200d515d7a1da541c62ca3e90640e56060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223639Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Ben Schwartz <bemasc@chromium.org> Auto-Submit: Ben Schwartz <bemasc@chromium.org> Cr-Commit-Position: refs/heads/master@{#774369}
-
Matt Menke authored
I believe this was added when investigating some sort of change in logic to close idle sockets, but it's no longer being used. Fixed: 1089020 Change-Id: Iccb2670d9e65b717ceb3763367af3f87a4e2036d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225262Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774368}
-
Rahul Arakeri authored
- Reverted change: crrev.com/c/2174809 - Reverted CL is in PS1. - Reverted because ScrollbarController::StartAutoScrollAnimation tried to dereference a null ScrollbarLayerImplBase. - Relanded CL + fix is in the latest PS. Root cause: When the user rapidly clicks on the scrollbar, a second mousedown can arrive within the same VSync as the first mousedown. When handling the second mousedown, the first thing that happens is that the ScrollbarController schedules an autoscroll task. After this, the InputHandlerProxy notices that this 2nd mousedown occurred in the same VSync and that will lead to LayerTreeHostImpl::ScrollEnd getting called. ScrollbarController::captured_scrollbar_metadata_ then gets cleared by ScrollEnd. Due to this, the scrollbar layer reference that is needed by StartAutoScrollAnimation is null. The previously scheduled autoscroll task then tries to proceed (after 250ms) by using a null ScrollbarLayer and fails. Why didn't this fail before this change: This bug was masked because when the autoscroll task was previously created, a pointer to the scrollbar layer was directly passed from the HandlePointerDown to StartAutoScrollAnimation. This reference always remains valid even though the InputHandlerProxy cancelled the scroll. With the refactor, the scrollbar layer needed for StartAutoScrollAnimation is now queried on demand using captured_scrollbar_metadata_ which gets cleared on ScrollEnd and this is what exposed the bug. The fix is to clear the scheduled autoscroll task as well on ScrollEnd. Original description: This CL gets rid of the several ScrollbarLayerImplBase references in the private methods of ScrollbarController. They need not be passed around because the ScrollbarLayerImplBase can easily be looked up by calling ScrollbarController::ScrollbarLayer (which retrieves the needed scrollber layer by using CapturedScrollbarMetadata::scroll_element_id). Bug: 1077093, 1078765 Change-Id: Ida68e4323e69757a7bfaeab7a7986fb64d07feb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224606 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#774367}
-
Kyle Horimoto authored
Before this change, we arbitrarily returned "true" for search result items which were deemed equal to each other, but this was incorrect because the comparison function is testing whether the first item is less than the second item. This CL updates this function so that it returns false in this case, which induces a strict weak ordering of results. Fixed: 1090184 Change-Id: I763112cef36d68731a88fd8a3696a800292899a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225930 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#774366}
-
Jonathan Ross authored
On Mac10.13 Tests (dbg) form-validation-reportValidity is flaking, adding it back into the expectations. TBR=robertocn@chromium.org TEST=virtual/web-components-v0-disabled/external/wpt/html/semantics/forms/constraints/form-validation-reportValidity.html Bug: 1041973 Change-Id: Ib5b69a0b58c1cc694b4c0e1e09f1bde9ea9edce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227253Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#774365}
-
Clark DuVall authored
I was testing my in-progress popup change, and found a crash when opening multiple popups. Bug: 1090492 Change-Id: I2c3cb3cc655d13ce5476192117c4d863c9d4c044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225626 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2ad3dfb46bb6..4af57c9c55fd 2020-06-02 bsalomon@google.com Check for sync extensions only on correct context types 2020-06-02 reed@google.com Revert "Revert "gms for SkParagraph"" 2020-06-02 mtklein@google.com does -fms-compatibility-version=19 still matter? 2020-06-02 herb@google.com Make strike fields private 2020-06-02 nifong@google.com A example of 3D rotation that shows a quotation with all the glyphs rotated. 2020-06-02 michaelludwig@google.com Add localmatrix w/ perspective GM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I9804c0609a41ac050a00d0cffa7e7fc2b932cbc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227161Reviewed-by:
-
kylechar authored
Fix NOTIMPLEMENTED() that gets hit with SkiaRenderer+Dawn for max texture size. There is no API to query max texture size but WebGPU needs to support 8k textures so that is a safe placeholder for now. Bug: 1090476 Change-Id: Ia25ab3441b717410f09e21bb3785413c8a3c097a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225624 Auto-Submit: kylechar <kylechar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#774362}
-
Marijn Kruisselbrink authored
For drag&drop we'll need a different implementation of this mojo interface. This CL factors out the common code into an abstract base class, with the existing implementation as a concrete subclass. Later for drag&drop a different concrete subclass will be added. Bug: 1080811 Change-Id: Ie16836f315918e1f20dde82fc2a7efac40f67c3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2221432 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#774361}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib2ce63d55287247b34dd8c3cc89117692b3a8941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227171Reviewed-by:
-
Katie D authored
No translation screenshots as this is not yet UX approved. cursor colors in chromebook a11y settings. AX-Relnotes: Users with cursor color flag enabled can now change their Bug: 1085442 Change-Id: I583f6b28ea69387e598e595b513bf4cf6928bbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220492 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Ian Vollick authored
With this CL, we count the portal's web contents as a single frame in its parent, ensuring that we do not exceed NodeRareData's connected frame count bits. However, we do not yet include frames within the portal in the total. If limit is exceeded, HTMLPortalElement::InsertedInto will early out. Successful insertion and removal of portal elements will impact the subframe count (and, naturally, the consistency check on subframe count must also account for portals as well as frames). In order for the test to run in a reasonable amount of time, I've also made it possible to reduce the frame limit for testing. Bug: 970038 Change-Id: I64d458b640c193c96662b0dd1e2101b6438e2e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187200Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#774358}
-
Lei Zhang authored
For instance, if (ptr != nullptr) can just become if (ptr). Change-Id: I56fc1a8f97d72f46bca8035e3bcb9b4fae199b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227114Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#774357}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2fbd57b6362a..907433b9f820 2020-06-02 bclayton@google.com SpirvShaderDebugger: Implement Array types 2020-06-02 bclayton@google.com SpirvShaderDebugger: Replace 'builtins' / 'root' with a global scope 2020-06-02 bclayton@google.com SpirvShaderDebugger: Silence release only warning 2020-06-02 bclayton@google.com SpirvShaderDebugger: Handle None sizes for composite types 2020-06-02 bclayton@google.com SpirvShaderDebugger: Handle template types 2020-06-02 bclayton@google.com SpirvShaderDebugger: Don't display SSAs for array types 2020-06-02 bclayton@google.com SpirvShaderDebugger: Don't display SSA values with DebugInfo 2020-06-02 capn@google.com Make ManagedStatic registration thread-safe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:950343 Tbr: swiftshader-team+autoroll@google.com Change-Id: If9d9b4d797122029bd272992a663e5109fdf8b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226963Reviewed-by:
-
Jon Mann authored
Previously, networks were only synced after they have had a successful connection. This change now allows syncing after they are configured so long as the password isn't rejected during a 20s waiting period. Bug: 966270 Change-Id: I21d4e9d71c0fd2a55a22303bc3febca28fb787b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223152 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#774355}
-
Zach Trudo authored
This change adds ReportQueue for generating reports. File Changes: ~ chrome/browser/ | ~ BUILD.gn | | Add report_queue.h to the buildable unit. | ~ policy/messaging_layer/ | | ~ proto/record.proto | | | Change EncryptedRecord::encrypted_wrapped_record from byte to | | | string. Behind the scenes they are treated the same, but in | | | practice it is easier to work with std::string(). | | + proto/test.proto | | | Adds a test proto for testing. | | + public/report_queue.h/cc | | | Add ReportQueue, temporary StorageModule and temporary | | | EncryptionModule. | | + public/report_queue_unittest.cc | | | Add tests for ReportQueue | | ~ public/report_queue_configuration_unittest.cc | | | Import missing library. ~ chrome/test/BUILD.gn | Add unit tests and test proto. Bug: chromium:1078512 Change-Id: If3fff7ac59e7d4a486d47ab87148cb27020c2866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191201Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#774354}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Icf8e7f1cd9751fd79d13ad21aa708a4cea8e38aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227162Reviewed-by:
-
Peter Kasting authored
Major changes: * Remove mutable reference section from Blink guide due to recent Google style changes. Minor changes: * Remove Blink guide section on documentation since the Google style guide already mandates this. * Add section on TODO formatting to Dos-And-Don'ts page; remove similar section from Blink guide in hopes the Google guidelines + Dos-And-Dont's text covers it. * Add information about C++17 (lack of) support. Trivial changes: * Clarify that the Blink style guide is a diff atop the Chromium guide (which is a diff atop the Google guide). * Cite Chromium guidance around bare "new" from Blink guide. * Minor link fixes, wording changes, inlining. Bug: none Change-Id: I1e3c2b265930cc73501e3557b25ca52b6902126e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223452 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Yi Gu authored
Previously CompositorTimeline was updated on Animation level which introduced a reverse dependency. This patch moves the update logic up to AnimationTimeline level to fix this issue. Bug: 921031 Change-Id: Iaaa92686003c741cad424eb9867a0993193c05c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225853Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#774351}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e246638c18ca..cd6894f0a29e 2020-06-02 taylori@google.com Fix slice interleaving bug If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: wenbinzhang@google.com Change-Id: I9fed1ca29c65c12d9b53906baf10c6a32fbf18c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227150Reviewed-by:
-
Arthur Wang authored
This reverts commit 41dddd7d. Reason for revert: Break gclient runhooks for someone https://bugs.chromium.org/p/chromium/issues/detail?id=1090465 Original change's description: > Refractor manage_render_test_goldens.py and add manage_wpr_archives.py > > R=bsheedy@chromium.org,harringtond@chromium.org > > Bug: 1060399 > Change-Id: Ifb06c6a94a51a6b1a2815bf94fa8f5a53dec1db8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219525 > Reviewed-by: Haiyang Pan <hypan@google.com> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Reviewed-by: Dan H <harringtond@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Arthur Wang <wuwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774253} TBR=iannucci@chromium.org,bsheedy@chromium.org,hypan@google.com,harringtond@chromium.org,wuwang@chromium.org Change-Id: I3597b11b7ae43b93747ae4ee2821c15d5072d50c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1060399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225632Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#774349}
-
Tom Anderson authored
This is a reland of 0af7d7aa Original change's description: > [XProto] Remove all remaining non-event usages of XRandR > > BUG=1066670 > R=msisov > CC=sky > > Change-Id: Iecd593c0c77878a80bf84e9e3c504fd90815db6c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220686 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Maksim Sisov <msisov@igalia.com> > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773876} Bug: 1066670 R=msisov TBR=jamiewalch Change-Id: Id24ace289778fc9f6feb8de9ed2744a2630be766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226785Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/c43545625d9c..724a60fb10c7 2020-06-02 rwkeane@google.com Code Coverage: Force CI Bot Waterfall Run If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ib3a2716014a42a0777041f90bafafc61c8867196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226967Reviewed-by:
-
Roman Aleksandrov authored
Since the pin pad buttons are no more tabbable (see for more details: https://crbug.com/1043194) we can return focus to textfield on number insert. Bug: 1009417 Change-Id: I4b1ebeef0a8e32a5ff2ba9b39da3ee424b7bdb3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208864Reviewed-by:
-
Findit authored
This reverts commit 00c7f91f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 774325 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzAwYzdmOTFmMDk0NjIzOTlmZmY1ZTUyNjZlZWRkY2Q2ZTBjOTQwNWMM Sample Failed Build: https://ci.chromium.org/b/8878570367609188432 Sample Failed Step: compile Original change's description: > Re-land migrate md5sum tool to portable zlib utils > > Use the set of portable code from zlib that shouldn't have > extra dependencies (e.g. 'base'). > > Also allow building the tool for other targets (e.g. Linux, > OSX, etc) as that allows easier testing and profiling. > > Compilation is disabled for Windows, see crbug.com/1090428. > > Bug: 1076580, 1087999 > Change-Id: Ic036685029be99b06753ea18f9fc62ce7c1a6540 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225526 > Reviewed-by: Tao Bai <michaelbai@chromium.org> > Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774325} Change-Id: I90e7158af6e9484a63f523cc75f5bfc52288262b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1076580, 1087999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227311 Cr-Commit-Position: refs/heads/master@{#774345}
-
