GitLab

Change-Id: If93e959f82073fb6f1ad6dd22dd21979300c2e7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627708
Auto-Submit: Clifford Cheng <cliffordcheng@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664857}

This makes it so that inspector_protocol instantiations within
Chromium stop using the copy of the encoding library in the template -
that is, third_party/inspector_protocol/lib/encoding_{h,cpp}.template -
and use the C++ library directly instead. This is done
by having third_party/inspector_protocol/lib/Values_cpp.template
include it, which is configured in the
inspector_protocol_config.json.

Change-Id: Ia38fa2b36585ae90d2889946cae346e168dc5f59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634423
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664856}

Add a No thanks used only by Payments Autofill. So when we want to override strings
with Finch overrides no other usages will be affected.

Bug: 961082
Change-Id: I85519146a5b4b3b88c65065e2378aba15c6e6971
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610308Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664855}

Bug: 968566
Change-Id: I48867b1c932d41c2654b9529fe41a86d8ab2bab6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637504Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664854}

Tested using CronetSampleApk, which crashes without this fix:

ninja -C out/Debug-x86/ cronet_sample_test_apk
out/Debug-x86/bin/run_cronet_sample_test_apk

Bug: 968172
Change-Id: I6cd3662b145e920464654b2af50c44801280ee1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636560Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664853}

I'm hoping this will make Milo's colors make sense again.

Currently if a benchmark fails completely and provides no
test_results json, then we will ignore that
output and not surface it in the merged output.json. This
fixes that.

Bug: 947100
Change-Id: I42259ae6c3597586da4c35b1f2bea76f1972529f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637037Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664852}

This patch makes sure we honour all VirtualAuthenticator options
instead of silently ignoring most of them.

Bug: 826936
Change-Id: I34e81b5d11ced056226d6e36588a0e0ca1074cc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632729
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664851}

Transient XRInputSources need to be added and removed from the input
source list as they are needed.  This exposes two helper methods on
XRSession to add/remove a transient source, and updates the canvas input
provider to call those methods when sending events.

Bug: 968229
Change-Id: I49e0313217a9d1526722c8a9f1e57f1141d3ee3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635775Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664850}

All supporting code now assumes STYLE_TEXTBUTTON, so we no longer need
this enum or supporting code.

BUG=642920

Change-Id: I4817a8383f9e6470f2950767ea5a2f5805a5755c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636481
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664849}

FTL currently returns raw email address so NormalizeJid() seems to work
out of the box. But they do plan to change it to a more aggresive
canonical form, which will cause users with email addresses with dots
fail to generate signatures or validate sender/receiver.

This CL implements the new normalization logic that will be used when
normalizing an FTL ID.

Bug: 968368
Change-Id: Ic7fa27e183124096563a6a7b4e337479e7edbb1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636594
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664848}

This is missed from the earlier patch.
In reduced mode, only InProgressDownloadManager will be created.
As a result, we should call OnDriverReady() when it is initialized.
This doesn't affect existing code when reduced mode is not enabled
for DownloadService though. As we will always create DownloadManagerImpl
when creating the download service.

BUG=942770

Change-Id: Ic6b54ccc47b8764796bf54eb086099d1c638cc6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636814
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Auto-Submit: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664847}

WebVR apps could potentially transfer ArrayBuffers that were in use by native code.
This CL prevents that by either ensuring that buffers have not been transferred before
writing to them, or preventing the WebApp from moving the internal buffer at all.

Additionally, ArrayBufferView did not null out its base_address_ member when neutering.
This CL adds that, so that unchecked reads and writes cause a null pointer dereference
instead of a (much more) severe use-after-free scenario.

Bug: 957516
Change-Id: I5dbadab03f96d6f742cd41cec16d5c7423cc9b3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636091
Commit-Queue: Will Cassella <cassew@google.com>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664846}

This will allow graph observers to immediately know the page
visibility in the OnNodeAdded() function.

Bug: 910288
Change-Id: Ib369b4dc36447a408b0fc4971ed01779ef42df1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637579
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664845}

External component extensions are loaded through the external provider
mechanism. These external extensions, by default, have a lower fetch
priority. For external policy extensions, we increase the priority. Do
the same for external component extensions, and add a test.

Bug: 965686

Change-Id: Ied58e08f403d574c4b6e8f7bdc484db90f926018
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627783
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664844}

Prior to this patch, during simplified layout we'd calculate the block-size
of a table-cell the same as any node. This missed the specific table-cell
logic within the NGBlockLayoutAlgorithm.

This moves this logic down into the ComputeBlockSizeForFragment method.

Bug: 968016
Change-Id: Idb4d76bb199d1690705e1f24d9de3ea53e2c8af4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637219Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664843}

When running the condition for the AutofillOffNoServerData feature,
I added a check to see if Autofill's client-side heuristics were
predicting a CVC field. If they do, then we won't overwrite the type to
"Unknown", as that breaks the CVC filling flow when unmasking server
cards via the CVC prompt.

Testing:
Added unit tests
Manually tested on the problematic website.

Bug: 968036
Change-Id: I9fa010d148fd168bd8c0348e93e18edf903db88b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636256
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664842}

This is a followup to https://crrev.com/c/1614282 which adds more
expectations to verify the contents of sandboxed <iframe>s and ensures
the documents are empty.

Bug: 963641
Change-Id: I5106aff83c25b3f9e0d5a6239ef24f8351529530
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637218Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664841}

MessageLoopCurrent::task_runner() is depecated.
This CL replaces it with with ThreadTaskRunnerHandle::Get().
A small step towards deleting MessageLoop.

This CL was generated with git cl split.
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1631693

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=newcomer@chromium.org

Bug: 616447
Change-Id: I8cfb4b77da06edc6ed251bcad917f6e4369fc7f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636063
Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664840}

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=bajones@chromium.org

Change-Id: Icf167d4cc8395db1bad4cc2252b4acb8bbb5c691
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635613Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Auto-Submit: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#664839}

This CL re-lands
https://chromium-review.googlesource.com/c/chromium/src/+/1611620,
which is reverted because the test is flaky on Chrome Dev on upstream
WPT. We should land the code first, once the code reaches to Chrome
Dev, I will enable the test.

Bug: 493078
Change-Id: I34f23e4fb47b8d781a8459471fd69740da25792e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632795Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664838}

This changes TouchIdAuthenticator::IsAvailable to check whether the
current executable is signed with a keychain-access-groups entitlement
matching the value that the authenticator is instantiated with. Without
it, calls to the keychain API to access credentials will fail.

Some embedders seem to provide a TouchIdAuthenticatorConfig that
attempts to configure Touch ID but don't entitle their binary as
required. This results in Touch ID being available but
MakeCredential/GetAssertion calls hanging until they time out. With this
change, Touch ID will simply be unvavailable instead.

Bug: 898577
Change-Id: I7b653a492661f36c921ab4fcd8785d90c92612ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628734
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664837}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/27bffdf23dd3..538a9d21bcb7


git log 27bffdf23dd3..538a9d21bcb7 --date=short --no-merges --format='%ad %ae %s'
2019-05-30 zoddicus@users.noreply.github.com Add ability to transform spvc input from WebGPU SPIR-V (#631)
2019-05-30 zoddicus@users.noreply.github.com Ran 2to3 on git-sync-deps (#636)


Created with:
  gclient setdep -r src/third_party/shaderc/src@538a9d21bcb7

The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=radial-bots+chrome-roll@google.com

Change-Id: I5c941448000896e14145d1376ab8d674f3a3311e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637394Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#664836}

MessageLoopCurrent::task_runner() is depecated.
This CL replaces it with with ThreadTaskRunnerHandle::Get().
A small step towards deleting MessageLoop.

This CL was generated with git cl split.
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1631693

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=pkasting@chromium.org

Bug: 616447
Change-Id: Id64bb062447c5e8347aca63c83672bd45d5dee70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635624
Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664835}

https://chromium.googlesource.com/angle/angle.git/+log/6d9b8908b0bb..0a56f0e3d22d


git log 6d9b8908b0bb..0a56f0e3d22d --date=short --no-merges --format='%ad %ae %s'
2019-05-30 timvp@google.com Vulkan: Update front face mode during syncState()
2019-05-30 cnorthrop@google.com Revert "Vulkan: Use atomics in SerialFactory."


Created with:
  gclient setdep -r src/third_party/angle@0a56f0e3d22d

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@google.com

Change-Id: I8b441387e8e0b60d8038598ed3a5db8bd6565a1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637500Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#664834}

The other ends of these pipes should normally not write negative values, but
since attackers can control them, treat negatives as 0.

Other alternatives:
* checked_cast -- rejected since then attackers can trivially crash the browser
  and "force negative to zero" doesn't seem to bad.  Also hard to fuzz
* Adding some kind of SizeTAttribute/GetSizeTAttribute() wrapper -- seems like a
  lot of work, but would provide the ability to pass these across the wire as
  unsigned via Mojo uint32_t values

Let me know if I should pursue that second alternative.

Bug: 966275
Change-Id: I232359e9e99eb73c862650b092f73e3ea4263249
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627826Reviewed-by: Zachary Kuznia <zork@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664833}

Rolls goldctl to a revision that's actually available for all platforms.
The previous roll worked for Linux, Mac, and 64 bit Windows, but not for
32 bit Windows.

TBR=kbr@chromium.org

Bug: 968339
Change-Id: Ie15f9eb83fb774188297107d0cf9f2fe166e5ef8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636636Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664832}

Bug: 966700
Change-Id: I3062ed3eb31da69c6e3eaa9eb8be947256be840f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628498Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Auto-Submit: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664831}

This CL introduces a policy for marking hidden tabs for reload when
they experience a sad frame.  Only visible (either in viewport or
scrolled out of view) sad frames trigger this policy; pages with
hidden sad frames (e.g., display: none) are not affected.  The goal is
to experiment with this policy to see whether it can reduce the # of
sad frames experienced by users without raising the tab reload count
too much.

The policy is turned on for Android by default but may be turned off
via the "ReloadHiddenTabsWithCrashedSubframes" base::Feature in case
something goes wrong.

Bug: 841572
Change-Id: Ie0bb947e79e8e3e34b02657446ee283aee3a898b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629175Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664830}

BaseState::OnWMEvent is not called when the system settings
bubble is shown or hidden in the OOBE and Login screens,
seemingly because WorkspaceLayoutManager::NotifySystemUiAreaChanged
has no windows_. This change pushes the logic to notify autoclick
when workspace changes occur into workspace_layout_manager.

Bug: 966154
Change-Id: I486d7962653819bd70854a3991fc2e2c7d871926
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627897
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664829}

JaCoCo agent will write execution data during building and throw exception when building "compile_java" targets.

Bug: 967049, 843307
Change-Id: I152e12ced21c919bc43ca1a2836146d4bd65426b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636313Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#664828}

Looks like this file moved into docs/testing/ at some point and several
references were stale.

TBR=mef@chromium.org

Bug: None
Change-Id: I3c35be9d3ac9f3821593406746cc9b230a26de80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637637
Auto-Submit: Ken Rockot <rockot@google.com>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#664827}

This reverts commit 2b4b4ee8.

Reason for revert: CrOS OOBE/login-screen failures

See crbug.com/968554
eg: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/9026

Original change's description:
> ThreadPool: Do not run BEST_EFFORT tasks during startup.
>
> With this CL, a task posted with:
>
> base::PostTaskWithTraits(
>     FROM_HERE,
>     {base::TaskPriority::BEST_EFFORT, ...},
>     base::BindOnce(...));
>
> Will not be allowed to run before startup is complete.
>
> The signal used to know that "startup is complete" is the same as
> AfterStartupTaskUtils. It is not perfect. It will be improved in a
> separate CL.
>
> This CL aims to be the smallest change possible to allow seamless
> migration of BrowserThread::PostAfterStartupTask() to
> base::PostTaskWithTraits().
>
> Bug: 887407
> Change-Id: I83ef387b82496ece3ed10c0c2466f42a6a5b19b3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631668
> Commit-Queue: François Doray <fdoray@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Carlos Caballero <carlscab@google.com>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#664488}

TBR=avi@chromium.org,gab@chromium.org,fdoray@chromium.org,carlscab@google.com

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 887407, 968554

Change-Id: I205b250267fd629b5da5db646d3b93c522642949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637005Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664826}

Fixes a weakSelf lifetime issue in the target device sheet that
prevented the sending of the tab after the user selected a device.

Bug: 949226
Change-Id: Icda0279baea3bc524d36fbcc4d363a455d29d933
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635412
Commit-Queue: sebsg <sebsg@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Auto-Submit: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664825}

This makes it a little easier to read / removes an ifdef.

Change-Id: If1d6505bf4820508e4bdd212be54bb3cb110a786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593733
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664824}

This CL fixes 2 bugs with Clank Start Phase 2.

1. When focusing URL bar, the current tab's URL was displaying.

2. Primary color was returning default color during tab switcher exit
transition. Fixed by observing if a tab switcher exit is in progress.

R=yusufo@chromium.org

Bug: 968210
Change-Id: Id2a934be168e38aa5ffd50f6bddbe393e8500c70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635415Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Matt Simmons <mattsimmons@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664823}

This is a reland of 514383cf
Relanding without any changes. This got reverted at crrev.com/c/1636667 but the
CL is unrelated to the failures, as we can tell from the fact that the bots
didn't stop failing after the revert.

Original change's description:
> Make ChromeDriver/DevTools APIs return sink structs
>
> Make the get_sinks API return sink structs instead of sink name strings.
>
> Bug: 963963
> Change-Id: Idb6b555544f29aaa308b8d289335073348c653f5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615982
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: John Chen <johnchen@chromium.org>
> Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#664485}

TBR=caseq,johnchen

Bug: 963963
Change-Id: I5c5484e804388a237e9db652bf4704a0cce0fd6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637408Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664822}

This test is really fuzzy when it doesn't need to be, allowing for
fairly large error when all of the test cases match it exactly. Remove
the fuzziness.

Bug: 948128
Change-Id: I1101377700def57816f7479e139c4804ffe8aa0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637397Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664821}

VaapiVDA reuses and decodes into buffers after they come back from
clients.
This patch sets a flag |read_lock_fences_enabled| on the Picture passed
to VAAPI clients to make sure buffers won't be sent back until they're
completely used by clients.
This should prevent possible races where buffers are reused for decoding
before their contents are fully displayed.

Bug: 961411
Test: Instructions in the bug
Change-Id: I5584969f0c09b5b35584bf6f955b1a599b6ac0e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636453Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664820}

* Enabled network service by default on Clank.
* Network service is in-process by default on Android and
  out-of-process by default on all other platforms.

Note: Network service in Android WebView is still disabled by default
      until further testing supports enabling the network service
      for WebView.

Bug: 953463, 962735

Change-Id: Ia775c01c29e51de082b8d60225c2b48bc7d5d59f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588996
Commit-Queue: Chris Mumford <cmumford@google.com>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664819}

Registering the factory on OffscreenCanvas in modules, adding
ImageBitmapRenderer to the union type for OffscreenCanvas.
Adding new functionality to bitmaprenderer to let it be used
in offscreencanvas.
Changing IDL and some tests to validate new functionality.
Adding a new virtual test to guarantee testing validation
of trasnsfertooffscreencanvas for bitmaprenderer.


Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ufFQ4OvtqxQ

Bug: 907141
Change-Id: I18b4af39d13289a26abee1f36564538d9f8a14c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630970Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664818}