- 17 Aug, 2020 40 commits
-
-
Taylor Bergquist authored
This reverts commit b25056de. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1116917 Original change's description: > Reland "Tab strip only occupies the space needed for its tabs." > > This is a reland of b6c0ca2a > > The only change is a line in tab_scrubber_browsertest.cc that ensures > that any invalid layout are laid out after modifying the tabstrip. > > Original change's description: > > Tab strip only occupies the space needed for its tabs. > > > > Bug: 1093972 > > Change-Id: I0ca6cc1a7dad9240b85745fefb39ac4f52eb9355 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300993 > > Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> > > Reviewed-by: Connie Wan <connily@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#793270} > > Bug: 1093972 > Change-Id: I4ded68fde336b14b38ad862cd63118ebc9fc7a72 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336296 > Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> > Reviewed-by: Connie Wan <connily@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797853} TBR=pbos@chromium.org,tbergquist@chromium.org,connily@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1093972 Change-Id: I3de1d647a4fbba593ce3ef52f59127b6495e5ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358591Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#798790}
-
Lei Zhang authored
Add a method to query the focus state of the PDF plugin. This information will be used to implement focus changes in the PdfAccessibilityTree. This CL is partially based on code borrowed from https://crrev.com/c/2230804/21. Bug: 1015350 Change-Id: I3475010b8aec146f258d5f481ec2d60133d1acda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351721 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#798789} -
Martin Kreichgauer authored
FidoDiscoveryFactory ownership and lifetime currently is a bit muddled. "Regular" instances are owned by AuthenticatorRequestClientDelegate, of which AuthenticatorCommon instantiates one per request. The virtual authenticator environment that manages the WebAuthn testing API can install and uninstall discovery factory overrides for a particular frame node. The lifetime of these overrides is decoupled from WebAuthn request lifetime, which is conceptually problematic (see e.g. crbug/1087158). Lastly, ReplaceDefaultDiscoveryFactoryForTesting() is another avenue for injecting a long-lived FidoDiscoveryFactory that we use extensively in unit and browser tests. To simplify, limit FidoDiscoveryFactory lifetime to a single WebAuthn request and put ownership into AuthenticatorCommon next to the FidoRequestHandler. To accomplish this, break VirtualFidoDiscoveryFactory, which implements the WebAuthn testing API, into a long-lived part that handles testing API configuration and a now short-lived discovery factory. As an exception, overrides injected by ReplaceDefaultDiscoveryFactoryForTesting() remain long-lived and owned outside of AuthenticatorCommon. They should probably be broken up in a similar fashion, but that involves changing many unit tests, and this CL is already a bit large. Change-Id: Ie7da2b3cca4eea78b541eb341708b113ad43a905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350026Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#798788}
-
Jan Wilken Dörrie authored
This change adds the algorithms from [alg.min.max] and [alg.clamp] to //base/util/ranges and adds appropriate tests. Bug: 1071094 Change-Id: I14d8c3c15fe2b6e2dab8a37afb931562a8c54984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358969 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798787}
-
Sky Malice authored
This reverts commit 2ea849e2. Reason for revert: Flakes on Android, see crbug.com/1117003 and crbug.com/1116744 Original change's description: > [remoteobjects] Use new codepath for Java bridge in instrumentation tests > > This CL is parameterizing the Java bridge instrumentation tests to > run with and without using Mojo in JavascriptInjector, running all > the relevant tests and using > JavaBridgeActivityTestRule#MojoTestParams for the ones that pass > and JavaBridgeActivityTestRule#LegacyTestParams for the ones that > fails. So, all tests still run for the old codepath. > > Bug: 1105928 > Change-Id: Idb3ee3ed4d1cb49fa0fc37d7609ac2e8ef166177 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348488 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Cr-Commit-Position: refs/heads/master@{#798370} TBR=boliu@chromium.org,oksamyt@chromium.org,myid.shin@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1105928 Change-Id: I348787f3ca85c778a1ad9ebfb6ec0e97dada5dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359738Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#798786}
-
Virender Singh authored
This change removes the pp::TouchInputEvent dependency from PDFiumEngine. There are two reasons to remove this dependency - Ability to unit test touch event handling. - Facilitate the PPAPI deprecation by moving some PPAPI dependencies out of PDFiumEngine. Bug: 1091834 Change-Id: I500faa950bbc8459e78f66fbe84db63f505777c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340360 Commit-Queue: Virender Singh <virens@microsoft.com> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798785}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/22e7f7a0d7d7..699711c7e3cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iccbfc48ed92b5eed509614f4e4635f68eeacb89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359157Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798784}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/699711c7e3cd..f926b0866fe4 2020-08-17 fmayer@google.com Merge "Do not show meaningless object counts for dump at max." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic1d1ebedd4aaa0be20559b756cfb225015578269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359640Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4c7d5ed732ae..78fa1f578a2c 2020-08-17 patrick.brosset@microsoft.com Remove the previewed class when pressing Escape in the .cls pane 2020-08-17 jacktfranklin@chromium.org Add supports for Sets to TypeScript bridges If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1114726 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I21bb50902f2789f3542250ebac0110b0c44b7af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359641Reviewed-by:
-
Hui Yingst authored
1. Add method PDFiumEngine::GetAttachmentData(). Giving an attachment index number, the method returns the content of that attachment in a buffer. 2. Add unit tests for GetAttachmentData() in an existing PDFiumEngineTest, and rename the test "GetDocumentAttachments" since it not only checks the meta data of attachments, but also checks the contents of attachments now. Bug: 177188 Change-Id: I418173abd77033d8edba33de61bac0d30ae51120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229765Reviewed-by:
-
Renato Silva authored
Rename AnimationState to UiState and use it to determine the visibility of elements. Remove multiple variables in favor of UiState. Bug: 1075994 Change-Id: I0d7413fb173dadbff22cde0eb3af6f43586bdee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352883 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#798780}
-
Lukasz Anforowicz authored
This CL changes how the content::LoadBasicRequest test API acquires a URLLoaderFactory to use. Before this CL, LoadBasicRequest would always create a new factory via network::mojom::NetworkContext::CreateURLLoaderFactory. The problem was that the URLLoaderFactoryParams were malformed: - process_id was not kBrowserProcessId - request_initiator_site_lock was nullopt (The 2 conditions above are supposed to be mutually exclusive.) After this CL, LoadBasicRequest has been split into 2 overloads: 1. The overload that creates the URLLoaderFactory from network::mojom::NetworkContext: 1.1. Always sets URLLoaderFactoryParams::process_id to kBrowserProcessId 1.2. Never sets frame-dependent URLLoaderFactoryParams::cookie_observer and/or ResourceRequest::render_frame_id 2. The overload that creates the URLLoaderFactory from content::RenderFrameHost reuses the production code that creates a URLLoaderFactory for the frame. This means that the same URLLoaderFactoryParams are used as the ones used in the product. Fixed: 1115147 Change-Id: Ia046b0889cd7ab37e1156bc264d901dda41df6d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348545Reviewed-by:John Abd-El-Malek <jam@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#798779}
-
Yue Zhang authored
Since SharingHub doesn't really support TabGroup sharing now, this CL makes TabGroup sharing use Android share sheet regardless of whether SharingHub feature is enabled or not. Bug: 1114963, 1085078 Change-Id: I310b8403dbf236369c30e4eff511c358ab136247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353405 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#798778}
-
Mark Pearson authored
This feature was enabled by default in https://chromium-review.googlesource.com/c/chromium/src/+/2298180 Bug: 1043329 Change-Id: I87dcb2c4922a5c942dd8b880f741e5623ae3230e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357678Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#798777}
-
Peter Wen authored
Previously all lint targets shared one lint suppressions/config file: //build/android/lint/suppressions.xml This resulted in many unnecessary suppressions being added which then suppress the lint checks for every lint target. e.g. if monochrome fails ObsoleteSdkInt checks, suppressing it globally turns off the checks for all other apks, which decreases the utility of android lint for all those other apks. This CL removes the shared suppressions.xml file and splits its content between the targets that actually need them, and adds lint-baseline.xml files where necessary. This also removes the bottleneck of requiring a //build/android/OWNERS to stamp every lint suppression change. This CL also adds suppressions for targets depending on code that chrome already lints via monochrome. E.g. errors in //base are shared by all embedders' lint targets, and it should not become the burden of targets like cast shell or cronet to fix. Thus these errors are suppressed in cronet/cast/remoting-specific suppressions.xml files. This CL changes lint to run in the output directory so that baseline suppressions work for generated files (e.g. AndroidManifest.xml). Bug: 1113795,1115594 Fixes: 1115594 Change-Id: I2d70128707c0fa862c109b6f91631a07916c90d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346857 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#798776}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/383f2cfca4a1..c8ac35879c9d 2020-08-17 sprang@webrtc.org Revert "Call OnReceivedOverhead after audio network adaptor is created." 2020-08-17 sprang@webrtc.org Revert "Add ability to state whether the APM output will be used" 2020-08-17 guidou@webrtc.org Revert "[Adaptation] Remove QualityScalerResource when disabled." 2020-08-17 jakobi@webrtc.org Call OnReceivedOverhead after audio network adaptor is created. 2020-08-17 hta@webrtc.org Deprecate RtpTransceiver.setDirection() 2020-08-17 peah@webrtc.org Add ability to state whether the APM output will be used 2020-08-17 hta@webrtc.org Modify Android API to use SetDirectionWithError 2020-08-17 mbonadei@webrtc.org Revert "reenable mouse_cursor_monitor tests on linux" 2020-08-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a5e24c44..2ecce21d (798477:798579) 2020-08-17 zhaoliang.ma@intel.com Reland "Support AVX2/FMA intrinsics in Audio Resampler module" 2020-08-17 eshr@google.com [Adaptation] Move min pixel limit logic out of adaptation processor 2020-08-17 hta@webrtc.org Make Objective-C interface use SetDirectionWithError 2020-08-17 nisse@webrtc.org Move definition of SpatialLayer to api/video_codecs/spatial_layer.h 2020-08-17 dharmesh.r.chauhan@gmail.com Updated IOS documentation with correct build_ios_libs.py path 2020-08-17 philipp.hancke@googlemail.com reenable mouse_cursor_monitor tests on linux 2020-08-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d83bc854..a5e24c44 (798377:798477) 2020-08-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 01ece160..d83bc854 (798214:798377) 2020-08-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ecbdf319..01ece160 (798066:798214) 2020-08-14 eshr@google.com [Adaptation] Don't allow frame dropping to re-enable when scaling is off 2020-08-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8aaf5430..ecbdf319 (797879:798066) 2020-08-14 sakal@webrtc.org Log a warning in STHelper if a frame is already pending. 2020-08-14 eshr@google.com [Adaptation] Make resource most limited if kLimitReached hit 2020-08-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6631cffc..8aaf5430 (797748:797879) 2020-08-13 deadbeef@webrtc.org Removing NetworkMonitorFactory static global. 2020-08-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d2e8a52a..6631cffc (797613:797748) 2020-08-13 nisse@webrtc.org Delete VideoCodec::plType member 2020-08-13 jakobi@webrtc.org Log audio network adaptor and DSCP in AudioSendStream. 2020-08-13 eshr@google.com [Adaptation] Extract adaptation constraints to their own files 2020-08-13 eshr@google.com [Adaptation] Apply AdaptationConstraints to all resources 2020-08-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 82995245..d2e8a52a (797326:797613) 2020-08-13 eshr@google.com [Adaptation] Remove QualityScalerResource when disabled. 2020-08-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 54b8c1d0..82995245 (797178:797326) 2020-08-12 danilchap@webrtc.org Delete legacy MockEncodedImageCallback::OnEncodedFrame If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1086942,chromium:980879 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ide8b46c689db8434ee8f78a2da4ea71c5fb82265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360257Reviewed-by:
-
Scott Violet authored
BUG=1076463 TEST=covered by tests Change-Id: I7891791fdc1e5e3a7025ff007fb6aefdeae019b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354554 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#798774}
-
Xiaoqian Dai authored
Currently notification code is not wired up yet. Bug: 1115153 Change-Id: I4ec6456e86623d8236065336ec2658709f005b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354558Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#798773}
-
Maksim Sisov authored
We used to be linking with system provided libwayland-egl, but it's not suitable for our script that controls required packages. The thing is that libwayland-egl1 is available on Debian => 9 and Ubuntu >= 16. On older versions (Trusty and Jessie), libwayland-egl0 is available. We don't support different packages for different versions. Thus, use the wayland-egl from the //third_party. And there is also another problem with libwayland-client. When we statically link with the library from //third_party/wayland:wayland_client, libffi dependency is also added. However, Ubuntu 20 names this package libffi7, while older versions name that as libffi6. Thus, to avoid this problem, link with that package differently through libs = [ "wayland-client" ]. Bug: 1116384 Change-Id: I76f7205db0d6425e92bd66c7b1981d525f49d2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355944Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#798772}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b93d82c4c5a8..42e3f1d3cb76 2020-08-17 ddoman@chromium.org [resultdb] move the cipd pin to deploy wramup If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1113089 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: Ie4d271d2b38061f4e1734f6b1caa4af6cd43df2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360389Reviewed-by:
-
Sky Malice authored
This reverts commit 730698e1. Reason for revert: Near 100% flakes on some Android builders. See crbug.com/1117149 Original change's description: > Don't store rfh when current navigation entry is replaced. > > This CL fix store rfh in bf cache when current navigation entry > is replaced (e.g from JS window.location.replace(url)) > because in this case we don't store navigation entry and > we don't need store corresponding rfh in bfcache. > > Bug: 1002978 > Change-Id: Iaa15e13c5cb7c0b063d0db7b6d2eb54bc604a755 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247033 > Commit-Queue: Alexander Timin <altimin@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Auto-Submit: Alexandr Rakov <alrakov@yandex-team.ru> > Cr-Commit-Position: refs/heads/master@{#798335} TBR=alexmos@chromium.org,altimin@chromium.org,alrakov@yandex-team.ru # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1002978 Change-Id: Ibc43aff9f5a1ad97b88d17469b16914f56f80518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360114Reviewed-by:
-
OlivierLi authored
This also introduces the first use of HangWatchScopeDisabled to ignore cases where tasks are not processed because an nested loop is processing only native events. Bug: 1034046 Change-Id: I5f425226d20d3c0f75038f0ea234ae7308bcbc9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340076Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#798769}
-
Mark Schillaci authored
This CL implements an alternative approach to aria-invalid content on Android. The current implementation, see here: https://chromium-review.googlesource.com/c/chromium/src/+/1320219 uses an ElapsedTimer to ensure that content invalid is set on a focused field only during the first 6 seconds after the field was focused. This prevents the user from hearing the invalid content after each letter typed beyond initial 6 seconds, since it is overwhelming to hear so many warnings. The new implementation uses a debounce approach and instead will communicate that an item is content invalid at any time, but at most once per 3 seconds. This is closer to a "slow drip", which will allow the user to always know the content is invalid, but without so many utterances. This new approach also shifts the code to Java and tracks only the currently focused virtualViewId and the time index of the most recent utterance, as opposed to the ElapsedTimer approach. This eliminates all ElapsedTimer objects from the browser_accessibility_android nodes. AX-Relnotes: Throttled the frequency of invalid content warnings on Android. Change-Id: I1232d70150b0eb6a68737bce9d51eb67834a5c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354836 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#798768}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5e9b29fab92d..988f19e208bb 2020-08-17 bryan.bernhart@intel.com Pool sub-allocated resource heaps. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I98f6739c5f737287b78acd5dc41aa2de71dd1a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359642Reviewed-by:
-
Anastasia Helfinstein authored
Switch Access is not receiving some key events that it should be when certain UI elements are focused. The events are instead passed directly to those UI elements (e.g. Launcher text field, omnibar), effectively trapping the user and leaving them unable to use the device. This change converts the SwitchAccessEventHandler into an event rewriter, so that Switch Access will receive events before any other source. AX-Relnotes: n/a. Bug: 1106573 Change-Id: Ib34de857acc8d6985e769fb83adb93b9ea41649e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317833 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798766}
-
Arthur Eubanks authored
Bug: 1114873 Change-Id: I0438a12c93fcff3d3d1d17c4951e3dc03b454cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357516Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#798765}
-
Bo Liu authored
After some discussion of a bug in webview that detects "abnormal" renderer process terminations, this failing DCHECK may be the cause. So add a DumpWithoutCrashing and see if it gets and if so, what the stack is. Bug: 1115216 Change-Id: Iaa969d2c6cd7e25237be3ee0ae52fcd5aececfd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359555Reviewed-by:
-
Ian Wells authored
- Add NetworkResponse type to types.h and make ImageFetcher use it - Unrelated to image fetching, add implementations for logError and logWarning so incoming log calls aren't silently dropped by XSurface's empty default implementations Bug: 1044139 Change-Id: Ic5ee9dc10c256a3362a2999dd3c766df66f2f09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347404Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#798763}
-
Hesen Zhang authored
- Setup proto_conversions and unittest. - Add and verify Tutorial struct conversion. Bug: 1115755 Change-Id: Ia42ee8f87c1b30bebc61992b1f7f30da6ab2cd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357854 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798762}
-
Fred Mello authored
https://docs.google.com/document/d/1FNzZqRmy6Y1vF5Y094RUr9t7KSVEXzcDiFdAKv4BZno Bug: 1112872 Change-Id: Ice96817a3e8ea5dcc0a10b00884127540642fd6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359576 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
-
Mitsuru Oshima authored
This was an workaround as these keys are remapped. With new mapping, they're not remapped, so virtual desks can just use OEM_PLUS / MINUS Bug: 1064383 Change-Id: I7dc7b3dc8419e5489e043dbed1a4687ec3e63d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327866Reviewed-by:
-
Peter Kasting authored
This ensures these places also use the most specific naming schemes possible. Bug: 1113007 Change-Id: I87800caf53c214410a0bd1d3a04064019ac09404 AX-Relnotes: n/a. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343777 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798759}
-
Chase Phillips authored
Bug: None Change-Id: I8fb3c4b282081b5070233766c0ce3440d3f6d72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359581 Auto-Submit: Chase Phillips <cmp@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#798758}
-
Joe Mason authored
Upgrade lazy requests to bounded to prevent starvation if the lazy request has not received a result by the time the next bounded request would be sent. R=chrisha, ulan Bug: 1080672 Change-Id: Ic3f44a67ff8052efdd83160ba453218fbb6f24e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349978 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#798757}
-
Renato Silva authored
LoginPinInputView is the view that will be used for PIN auto submit. It contains a child view - LoginPinInput - that is created anew as the length of the pin input field changes for different users. Minor modifications to FixedLengthCodeInput were made to enable code reuse. Unit tests will be adeed once the view becomes embedded in LoginAuthUserView in a upcoming CL. Bug: 1075994 Change-Id: Ia451a2eeabdede24c29667eecc883d213fc4288f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226308 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, invoking PaymentRequest API with secure payment confirmation method identifier and options to request shipping or contact information was considered valid. This patch throws RangeError in PaymentRequest constructor if secure payment confirmation method identifier is requested together with shipping or contact information. After this patch, it's not possible to request secure payment confirmation method together with shipping or contact information. Bug: 2348410 Change-Id: I3e01f9b758645a1653533f41da9688c453199b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359554Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798755}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I5ed2c329df64d6b2d448d6c7223b9c6fedaa7a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358957Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#798754}
-
Thomas Anderson authored
This reverts commit 4e31d46a. Reason for revert: MediaStreamPermissionTest.DenyingPermissionStopsStreamWhenRelevant flakes on "Win7 Tests (1)": https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/106475 Original change's description: > Immediately stop media streams if users revokes consent > > Since camera and microphone are particularly sensitive permissions we > should be viligent and stop streams immediately when the user revokes > the permission. > > This CL uses the permission controller subscription functionality to > listen to permission changes on the relevant origins. Each DeviceRequest > will have up to 2 permission subscriptions (1 audio, 1 video). When > a permission is changed to non-Granted the specific DeviceRequest is > canceled. Subscriptions are removed when the DeviceRequest is deleted. > > Because MediaStreamManager is an IO thread class but > PermissionController is a UI thread class, this CL has to do a bit of > thread hoping: > > FinalizeStream(IO) > SubscribeToPermissionControllerOnUIThread(UI) > > SetPermissionSubscriptionIDs(IO) >(maybe)> > UnsubscribeFromPermissionControllerOnUIThread(UI) > > DeleteRequest(IO) > UnsubscribeFromPermissionControllerOnUIThread(UI) > > Bug: 1116435 > > Change-Id: I6649125e028d607eeb7ba5701b710a715addf6f2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352790 > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798564} TBR=guidou@chromium.org,andypaicu@chromium.org Change-Id: I59eabef07aa990fd22bebba445c36c273c1a8342 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360119Reviewed-by:
-
Mario Bianucci authored
My change should not have any impact on a .PNG case that is now failing. While trying to figure out what is causing things to fail, split the new SVG cases out into their own test, with the hope that this will allow the original test to be re-enabled. Hopefully this will also have the side-effect of fixing the SVG cases as well. Possibly related to crbug.com/652536 Bug: 1113521 Change-Id: I885e531968dfabdaa11e4219e2b73b2cd40c7b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354666 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#798752}
-
Mohamed Heikal authored
Only depend on the aliased protobuf runtime rather than the real target. This also updates a deprecated method usage (valueOf) since it is no longer available in the latest runtime. TBR=mechanical changes Bug: 1114836 Change-Id: I8896cd81e17c4fbd9dc368b5906618fe743d124e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357634 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#798751}
-
