- 31 Jan, 2018 40 commits
-
-
Sahel Sharify authored
I cannot reproduce the test failures on my local official windows build, in this cl I force wheel scroll latching to be disabled in the tests to see if it changes the test results on Win official or not. Bug: 800822 Change-Id: Ife07a29617ca5e0142e75f926967685cb61e2a08 Reviewed-on: https://chromium-review.googlesource.com/895842Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#533347}
-
Robert Ma authored
Using wpt-import in Chromium 2ad329a8. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/11388 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts jsbell@chromium.org: external/wpt/resources ksakamoto@chromium.org: external/wpt/resource-timing meade@chromium.org: external/wpt/web-animations rego@igalia.com: external/wpt/css/selectors tyoshino@chromium.org, yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=lukebjerring No-Export: true Change-Id: I3d3acd548e4d95a9f377f5104597fb1928130b7d Reviewed-on: https://chromium-review.googlesource.com/895662 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#533346}
-
Charles Harrison authored
This relands crrev.com/531639. This is fixed by upstreaming CrOS change https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/886864 Original description: This also enables the filtering after a phishing interstitial by default. Bug: 805966 Change-Id: I691058f6e9c636b6c494b8d03b2e8fa82416d994 Reviewed-on: https://chromium-review.googlesource.com/729144Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531639} Reviewed-on: https://chromium-review.googlesource.com/895707 Cr-Commit-Position: refs/heads/master@{#533345}
-
John Abd-El-Malek authored
Bug: 753658 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I4fa031a0044307c56351a4d5072d7fcee1b8f053 Reviewed-on: https://chromium-review.googlesource.com/895262Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#533344}
-
Tomas Popela authored
In file included from ../../chrome/browser/vr/sample_queue.cc:5: ../../chrome/browser/vr/sample_queue.h:22:3: error: unknown type name 'int64_t' int64_t GetSum() const { return sum_; } ^ ../../chrome/browser/vr/sample_queue.h:24:18: error: unknown type name 'int64_t' void AddSample(int64_t value); ^ ../../chrome/browser/vr/sample_queue.h:32:3: error: unknown type name 'int64_t' int64_t sum_ = 0; ^ ../../chrome/browser/vr/sample_queue.h:35:15: error: use of undeclared identifier 'int64_t' std::vector<int64_t> samples_; ^ ../../chrome/browser/vr/sample_queue.cc:17:19: error: out-of-line definition of 'AddSample' does not match any declaration in 'vr::SampleQueue' void SampleQueue::AddSample(int64_t value) { ^~~~~~~~~ [choco@choco-rhel6-vm chromium-65.0.3325.31]$ /opt/rh/llvm-toolset-7/root/usr/bin/clang++ -v clang version 4.0.1 (tags/RELEASE_401/final) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /opt/rh/llvm-toolset-7/root/usr/bin Found candidate GCC installation: /opt/rh/devtoolset-6/root/usr/lib/gcc/x86_64-redhat-linux/6.3.1 Found candidate GCC installation: /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7 Found candidate GCC installation: /usr/lib/gcc/x86_64-redhat-linux/4.4.4 Found candidate GCC installation: /usr/lib/gcc/x86_64-redhat-linux/4.4.7 Selected GCC installation: /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7 Candidate multilib: .;@m64 Candidate multilib: 32;@m32 Selected multilib: .;@m64 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icb4db046d907eb0dde94201d8b5bd8082e10337e TBR=bajones@chromium.org Change-Id: Icb4db046d907eb0dde94201d8b5bd8082e10337e Reviewed-on: https://chromium-review.googlesource.com/895583Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#533343}
-
Danyao Wang authored
This EarlGrey test tests the behavior of renderer-initiated back navigation. With WKBasedNavigationManager, renderer-initiated back navigation happens completely in the WebProcess. Adding the wait makes sure the Omnibox URL check is performed after the navigation finishes. Bug: 807428 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I636f4b991e6bcb901b09851de08b4fef6970002a Reviewed-on: https://chromium-review.googlesource.com/894177 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#533342}
-
Derek Cheng authored
This patch removes Start/ReconnectPresentation from content/renderer presentation_dispatcher. Also removed a few WebPresentation* classes that are no longer used as a result. Bug: 749327 Change-Id: I0cddaa9822cd7924cf3afd195b71bb1a64db3cc8 Reviewed-on: https://chromium-review.googlesource.com/887927 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Mounir Lamouri (slow) <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#533341}
-
Marijn Kruisselbrink authored
Intent to Implement and Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/zm0ZUCINXBk Bug: 732750 Change-Id: I07b45276f3e0ddf991f1f8a6c390bf5b843ec22e Reviewed-on: https://chromium-review.googlesource.com/893942Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#533340}
-
Android AFDO Autoroller authored
Updating from 66.0.3334.0_rc-r1. This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Bug: None Test: CQ Change-Id: I89f5b0a9aa82035c4c2e70488e650e2059aa8187 Reviewed-on: https://chromium-review.googlesource.com/895384Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#533339}
-
Scott Violet authored
There are two motivations for this change: 1. In order to run a field trial for state setup in creating toolkit. 2. To have local state ready at the time ash is created. In order to have field trial ready I need to load local state and everything it touches. This ended up including ResourceBundle (not really the ResourceBundle, but the ResourceBundle code is used to determine the locale, and the locale is needed by code related to metrics, specifically ChromeMetricsServiceClient::GetApplicationLocale). As much of this code was previously created at a time when task runners were available I had to create a deferring task runner that queues up tasks and then flushes them when the real task runner is available. I've tried to only move what is necessary and leave as mush initialization as possible in the place before this change. You'll notice this creates g_browser_process early on. I explored not doing this, but it turns out very painful as instead some code then has to cache state that is later available in g_browser_process. The camel that broke the straws back was the application locale. See https://chromium-review.googlesource.com/c/chromium/src/+/853300 for the early approach. BUG=800358 Change-Id: Ib9aaddfbc04a0f3937bf268dd2af770b3f6746e0 Reviewed-on: https://chromium-review.googlesource.com/882558 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#533338}
-
Varun Khaneja authored
This reverts commit 29a153c3. Reason for revert: Causing build failures https://bugs.chromium.org/p/chromium/issues/detail?id=807391 Original change's description: > [2] Build unrar only for full safe browsing mode. > > - Enables exception handling: throw/try/catch. > - Disables a bunch of warnings that this library is full of. > - "-Wno-dangling-else" > - "-Wno-logical-op-parentheses" > - "-Wno-switch" > > Bug: 750327 > Change-Id: Ic08f67e328da2f22f3503eab074be6aaf2f2fc90 > Reviewed-on: https://chromium-review.googlesource.com/872219 > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Nathan Parker <nparker@chromium.org> > Reviewed-by: Jialiu Lin <jialiul@chromium.org> > Commit-Queue: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531926} TBR=rockot@chromium.org,nparker@chromium.org,vakh@chromium.org,jialiul@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 750327 Change-Id: Ided3cdfc2b4849de090a329a29de94288b616a3c Reviewed-on: https://chromium-review.googlesource.com/894999Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#533337}
-
Sorin Jianu authored
Bug: 329883 Change-Id: I5e613e0d4834553d476955cb405bff4bbf01460a Reviewed-on: https://chromium-review.googlesource.com/892201Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533336}
-
Vaclav Brozek authored
This CL adds a progress bar to the password export flow. The progress bar is shown if the user already completed reauthentication and export confirmation but the passwords are still being serialized in the background. The user can cancel the whole export with a Cancel button next to the progress bar. The screenshot is at https://crbug.com/788701#c22, the mocks at go chrome-pwd-export-mocks-android (Google only). This CL also merges the existing flags mExportOptionSuspended, mExportRequested and mExportConfirmed into a single mExportState to improve the clarity of the whole process. Bug: 788701 Change-Id: I1857b135df255124a1507139095f36eca7c3dc3d Reviewed-on: https://chromium-review.googlesource.com/881019Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533335}
-
Jinsong Fan authored
browser_process_impl.h contains declarations for CreateStatusTrayManager(), CreateSafeBrowsingDetectionService() and CreateViewedPageTracker() methods, whose implementations have since been removed. This CL removes these unused declarations and add check for private field created_notification_ui_manager_. Bug: Change-Id: If9337bae7a5fc20a5fcc1a98c42e53e803102660 Reviewed-on: https://chromium-review.googlesource.com/892685 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#533334}
-
Dmitry Gozman authored
We can get rid of our custom chunking. Bug: 776009 Change-Id: Ib5ffe7ce1e4e1b6758a5963c68fc0eedb9af8e41 Reviewed-on: https://chromium-review.googlesource.com/869191 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#533333}
-
David Bokan authored
This CL fixes coordinate differences in RotationViewportAnchor that were assuming pre-RLS coordinates. This CL fixes the conversions to use the correct RLS-aware methods in LocalFrameView (AbsoluteToDocument, etc.) For details, see: https://www.chromium.org/developers/design-documents/blink-coordinate-spaces We also avoid using Node::BoundingBox as the name is a bit of a lie (ContainerNode::BoundingBox has specific cases for how scrollIntoView should work with empty inlines, for example). LayoutObject::AbsoluteBoundingBoxRect is both clearer in the coordinate space and it makes more sense to get this directly from the LayoutObject. Unfortunately, we were lacking test coverage so this CL also adds new tests that would have caught these bugs. Bug: 806355 Change-Id: I96fea83ced6c0ce7ea8c37c4a1b82a8e9a6bb66e Reviewed-on: https://chromium-review.googlesource.com/894887Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533332}
-
Josh Karlin authored
The | and || fields were flipped, and the tests failed to catch it because the UrlPattern class doesn't parse the anchors like I thought it did. Bug: 793025 Change-Id: I1154783844a3f2915a7b0609a3ed4b04b69d9ae4 Reviewed-on: https://chromium-review.googlesource.com/895664Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533331}
-
Tom Anderson authored
R=erg Change-Id: I7707cf02b88a08e416d2fc0a17bfd75b918fe42c Reviewed-on: https://chromium-review.googlesource.com/894993Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#533330}
-
Helen Li authored
io_thread's GetNetworkServiceOnUIThread() is removed in r525444. This is to update the header file. R=mmenke@chromium.org Change-Id: I0ce2f34c68c333fa1a525952d43f6058329afe11 Reviewed-on: https://chromium-review.googlesource.com/895803 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#533329}
-
Nico Weber authored
Since native_client_sdk can't include base/ headers, and since the sdk is always built by clang, just use the clang attribute directly. (Alternatively, we could've disabled the warning for this target.) This CL was uploaded by git cl split. R=binji@chromium.org Bug: 177475 Change-Id: I14cf95478a0da89a8426e748ded165eb177c4c24 Reviewed-on: https://chromium-review.googlesource.com/891900Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#533328}
-
Istiaque Ahmed authored
Bug: None Change-Id: I89c72bc8905a6a7dd8e339ba328e92e67f949b3e Reviewed-on: https://chromium-review.googlesource.com/894504Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533327}
-
Matthew Jones authored
Theme colors will be enabled for Chrome modern design, so there is no need to force the default theme color in LayoutTab. BUG=803098 Change-Id: Iab41c5f7ba8250a3dd2a62433392428f305efca4 Reviewed-on: https://chromium-review.googlesource.com/894694 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#533326}
-
Christian Fremerey authored
This is an attempt to enable tests that had been disabled due to flakiness on webrtc bots. There is hope that the flakiness is resolved by the tests now being run sequentially since [1] and [2] have landed. The test pass when I run them on my local machine. [1] https://chromium-review.googlesource.com/872260 [2] https://chromium-review.googlesource.com/876003 Test: content_browsertests --gtest_filter=UsingRealWebcam* --run-manual --test-launcher-jobs=1 Bug: 733582 Change-Id: If536e4c0b87c0a7de50ffc35f8c0a1d9abc52359 Reviewed-on: https://chromium-review.googlesource.com/894883Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#533325}
-
W. James MacLean authored
This code no longer appears to be touched at all. Removing it will reduce the complexity of FindMouseEventTarget, and facilitate removing the similarly dead code path associated with BrowserPluginMsg_SetTooltipText. Bug: 533069 Change-Id: I25927f17268e25d39edbe6586dfc37bae959eb7c Reviewed-on: https://chromium-review.googlesource.com/894422Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#533324}
-
Shivani Sharma authored
This CL tags a subframe as an ad if its parent frame is tagged as well. This extends the coverage of frames tagged as ads from just those that match the ruleset to those that do not match but their parent frame is tagged as an ad frame. BUG: 807640 Change-Id: Ifee656298cdbe8bc16bcd24a16bc9a9905e2c2a3 Reviewed-on: https://chromium-review.googlesource.com/894542 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#533323}
-
https://chromium.googlesource.com/angle/angle.git/+log/e13f7ebea887..79de62c665bd $ git log e13f7ebea..79de62c66 --date=short --no-merges --format='%ad %ae %s' 2018-01-31 thakis Explicitly suppress -Wimplicit-fallthrough for angle and its deps. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ie3905a4b23589a3ffa6af08db2a816c42c538d4f Reviewed-on: https://chromium-review.googlesource.com/894695 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533322}
-
https://pdfium.googlesource.com/pdfium.git/+log/4b0c5b935471..41b45a88f14e $ git log 4b0c5b935..41b45a88f --date=short --no-merges --format='%ad %ae %s' 2018-01-31 rharrison Clean up CSS property table 2018-01-31 thestig Clean up FPDFPage_New() documentation. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1d1f78460b346c66b4d574c559e0f7ba7d343057 Reviewed-on: https://chromium-review.googlesource.com/894899Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533321}
-
https://webrtc.googlesource.com/src.git/+log/f9e012149f27..7c4dedade158 $ git log f9e012149..7c4dedade --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I156bb813c55350577a9787eb286afd99ac898040 Reviewed-on: https://chromium-review.googlesource.com/895407Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533320}
-
Emily Stark authored
This transition (which is currently only possible with an experiment enabled) can look messy/confusing when animated, so do not animate it. Bug: 807075 Change-Id: I1dae69b64e0e9f457b87abf7c4ff45ba1f595dad Reviewed-on: https://chromium-review.googlesource.com/891587Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#533319}
-
bsheedy authored
Adds VrShellNavigationTestWebXr, which contains copies of all the tests in VrShellNavigationTest that make use of WebVR. These will be merged back in to VrShellNavigationTest once WebVR is removed. Bug: 804043 Change-Id: I50c6a8618d9f1ef09de92a44b88aef5dff4bd46d Reviewed-on: https://chromium-review.googlesource.com/887165Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533318}
-
Mohamad Ahmadi authored
This CL fixes a bug where the value of the currency amount was being checked against the maximum allowed string length not the length of the value string. Bug: 806666 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8897c93f06e8cb590c5414497b53ab87fa291e77 Reviewed-on: https://chromium-review.googlesource.com/895546Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#533317}
-
bsheedy authored
Adds bsheedy as an owner of chrome/android/BUILD.gn for changes related to VR Javatests so that other owners don't have to be bothered by VR-only changes. Change-Id: I0d84468848d1e6a8b43f2a4844edfdbad3e78ca9 Reviewed-on: https://chromium-review.googlesource.com/894362Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533316}
-
Danyao Wang authored
location.replace changes the URL of WKBackForwardListItem. Update the URL of NavigationItem to that of the host WKBackForwardListItem upon access. It's done this way because location.replace cannot be reliably distinguished from normal navigations in either WKNavigationDelegate callback or URL KVO. This fixes NavigationTestCase/testWindowLocationReplaceAndChangeHash. Bug: 807428 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaef4ed5efd788283050b43a3b4e988311ec9cf76 Reviewed-on: https://chromium-review.googlesource.com/894490 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#533315}
-
Raymond Toy authored
This is a reland of 53b1b7da. Original change's description: > Remove Dezippering from BiquadFilter > > Remove dezippering from all of the attributes. The value will now > change immediately instead of gradually changing from the old value > to the new value. > > Chromium Feature: https://www.chromestatus.com/features/5287995770929152 > Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/YKYRrh0nWMo/aGzd3049AgAJ > > Bug: 752986 > Test: BiquadFilter/dezipper.html > Change-Id: I86840159709158fd52a69a7c3c5f279267277d44 > Reviewed-on: https://chromium-review.googlesource.com/612104 > Commit-Queue: Raymond Toy <rtoy@chromium.org> > Reviewed-by: Hongchan Choi <hongchan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532910} Bug: 752986 Change-Id: Ia911c6e93d7dd7da1dea6290ac4201f81f42da3a Reviewed-on: https://chromium-review.googlesource.com/894243Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533314}
-
Miguel Casas-Sanchez authored
This CL relands crrev.com/c/886543, enabling the GLImageBindTest for GLImageIOSUrface with the BufferFormat BGRX_1010102. The CL also adds a provision to swizzle the color channels when running on nVidia on High Sierra to workaround some bug that can be repro'ed on the bots and stand alone laptops. Bug: 803473 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5472606a82b393fe1d2375b3c644e836ea7f12cf Reviewed-on: https://chromium-review.googlesource.com/890007Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#533313}
-
Emily Stark authored
This transition (which is currently only possible with an experiment enabled) can look messy/confusing when animated, so do not animate it. Bug: 807075 Change-Id: Ib7bda303958739cd4840dbc57910c1c850c5e97a Reviewed-on: https://chromium-review.googlesource.com/891630Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#533312}
-
Sahel Sharifymoghaddam authored
This reverts commit 871421fc. Reason for revert: this change hasn't fixed the failing tests. Original change's description: > Fix SitePerProcessMouseWheelHitTestBrowserTest.* tests on Win official. > > https://chromium-review.googlesource.com/865558 fixes this flaky tests > on win7_chromium_rel_ng, but it only waits for dispatching of the > first wheel event before sending the others. > > This cl makes sure that each wheel event gets dispatched before sending > the next one. > > I haven't been able to reproduce the bug on my local windows official > build but I suspect that after using async wheel targeting for wheel > events some of the wheel events in RunTest get coalesced to each other > before getting dispatched. > > Bug: 800822 > Change-Id: Id693ef3beff19daf08c3e11c2119b2bf90ef6737 > Reviewed-on: https://chromium-review.googlesource.com/893803 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533002} TBR=kenrb@chromium.org,nasko@chromium.org,wjmaclean@chromium.org,sahel@chromium.org Change-Id: I62fa9ba2075ffaf7ac685dad56af84bd06237214 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800822 Reviewed-on: https://chromium-review.googlesource.com/894998Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#533311}
-
François Beaufort authored
https://wicg.github.io/picture-in-picture/ The API is currently not working. It is mostly about implementing the shell: it exposes document.pictureInPictureEnabled, document.exitPictureInPicture(), and video.requestPictureInPicture(). It also adds the "picture-in-picture" feature policy. Everything is gated by the "PictureInPictureAPI" runtime feature. Intent to implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/U8Apo-WLBm4/03sO4ITYAQAJ Change-Id: I64d8e17c6975017565c850afeeca19d94e9f9ceb Bug: 806249 Reviewed-on: https://chromium-review.googlesource.com/867915 Commit-Queue: Mounir Lamouri (slow) <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri (slow) <mlamouri@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#533310}
-
Elly Fong-Jones authored
Whenever any requests are running, ResourceDispatcherHostImpl polls for state changes to running requests, so that these can be reflected in the UI. However, ResourceDispatcherHostImpl doesn't remember the previous state of a request, so it always calls LoaderDelegate::LoadStateChanged() for any running request, at 4Hz. This calls into WebContentsImpl::LoadStateChanged(), which *does* have access to the previous state, which then notifies the UI of a change. Instead, WebContentsImpl should check if the state notification is redundant, and if so, should ignore it. This will save doing a bunch of work in the UI. In principle, ResourceDispatcherHostImpl could do this de-duplication instead, but that involves storing more data in RDHI for a very small further decrease in work done. This also fixes the root cause of an old bug where on Mac, the status bar would be clobbered (at 4Hz) whenever there was a pending request in the current tab. This bug was worked around in the Views status bar code by suppressing updates with no text changes, but that workaround never made it to the Cocoa status bar. Bug: 147303 Change-Id: Idbaded695b161543d1750aa9e6253c3bdd0a145a Reviewed-on: https://chromium-review.googlesource.com/895724Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#533309}
-
Jonathan Metzman authored
TBR=vitalybuka@chromium.org Bug: 539572 Change-Id: I1e7dbad47b8f5b4debfd4ab071ce946d07c0d93f Reviewed-on: https://chromium-review.googlesource.com/885085Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533308}
-