- 23 Oct, 2018 40 commits
-
-
Martin Kreichgauer authored
In 2c29863d, a change to sign_app.sh.in changed the value of is_development in the false case from "" to "0". Because the script tests with the -z/-n flags of the bash test command, this made is_development effectively always true. Bug: 897973 Change-Id: Ic1181413237a4d0b966d94bbbf5bcc7bdf29450b Reviewed-on: https://chromium-review.googlesource.com/c/1297402Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#602167}
-
Gabriel Charette authored
This is a reland of f7da13a2 (original change in PS1) The original change was missing acquire ordering in DisconnectFromParent(). This is necessary in order for the disconnecting thread to see all memory side-effects previously made by other threads (or some side-effects of message_loop_->ScheduleWork() could racily come in after ~MessageLoop()). Also removed the DCHECK that |operations_state_ == kDisconnectedBit| at the end of DisconnectFromParent() as it was incorrect. A racy BeforeOperation() call can make it 1->3 (and no-op) after DisconnectFromParent() made it 0->1. And lastly, added a scoped allowance to always allow the very fast wait instead of requiring callers to know about this implementation detail of MessageLoop (and reverted changes to //net). Original change's description: > [MessageLoop] Lock-free ScheduleWork() scheme > > The Lock is causing hangs because of priority inversion > mixed with priority boosting (ScheduleWork() tends to > boost the destination thread which may deschedule the > posting thread; if the posting thread is a background > thread this boost-induded-desched-while-holding-lock > can cause a livelock). See https://crbug.com/890978#c10 > for example crashes catching this. > > The Lock was only necessary for startup/shutdown and is > being replaced by a lock-free atomic scheme in this CL. > > MessagePump::ScheduleWork() itself was already thread-safe > (but the Android impl did unnecessarily check a non-atomic bool) > > This adds a WaitableEvent in ~MessageLoop(); hence the requirement > for a wait-allowance in net's EmbeddedTestServer. > > TBR=zhongyi@chromium.org (embedded_test_server.cc side-effects) > > Bug: 890978, 874237 > Change-Id: I0916e5a99035a935b0a23a770af256f334e78c43 > Reviewed-on: https://chromium-review.googlesource.com/c/1278631 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601600} Bug: 890978, 874237, 897925 Change-Id: I17c515f9a3169bbdfc303a4b259f34097e31730d Reviewed-on: https://chromium-review.googlesource.com/c/1297129Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#602166}
-
Xiaohan Wang authored
This partially reverts commit 251e255f. After mojo CDM was enabled by default, with the performance gain, we changed the audio buffer size back to the original value at 200ms, which is the same as the size as clear playback. Recently, we found cases where we still have performance issues for encrypted audio. Given the fact that users are super sensitive to audio glitches, and encrypted playback always has worse performance than clear playback, it makes sense to use a larger buffer size. This CL changes the audio buffer size back to 500ms. It may increase the start-to-play time slightly, but should help reduce rebuffers during playback. Bug: 718161,879970 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I41909d3fc3356df119b21fe720ebe8cafad206a5 Reviewed-on: https://chromium-review.googlesource.com/c/1297329Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#602165}
-
Daniel Cheng authored
The supplement is no longer useful; it was previously used as a way to bridge modules and web, but that split no longer exists. Since CheckIfAudioSinkExistsAndIsAuthorized isn't conceptually a 'controller' method, just have HTMLMediaElementAudioOutputDevice call it directly. Change-Id: I90a2450f8d0e984a5f124e5ac27c4dacb249487a Reviewed-on: https://chromium-review.googlesource.com/c/1296824Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#602164}
-
Klaus Weidner authored
This regressed in https://chromium-review.googlesource.com/c/1197225, the frame property updates were happening in the wrong code location. Revert to the original code ordering, and add comments explaining the order dependency. BUG=897525 Change-Id: If88575c15de7ca3b069771362d4388f1a95aca06 Reviewed-on: https://chromium-review.googlesource.com/c/1297473Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#602163}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/42645509..130258cf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If09e43487c01819cbed945ab2f9767bce633762d Reviewed-on: https://chromium-review.googlesource.com/c/1297088Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602162}
-
Xianzhu Wang authored
Now for tests that don't call any dumpAsXXX methods, they by default generate pixel results only, and run_web_tests.py just check their pixel results against the corresponding pixel baselines only. Provide testRunner.dumpAsLayout() and dumpAsLayoutWithPixelResults() for tests that do need to dump the layout tree. We still dump layout tree when running such tests in content_shell --run-web-tests command line (instead of running from run_web_tests.py in protocol mode). Changes to layout tests and their expectations: - Use testRunner.dumpAsLayoutWithPixelResults() or dumpAsLayout() in some tests that still requires the layout dump: - editing/ tests need layout dump to show the caret position. - two printing/ tests need layout dump to show how the bug is fixed. In the future, we may just get rid of layout dumps if it's feasible. - Remove testRunner.dumpAsTextWithPixelResults() from some tests which used the function just to suppress layout output. They didn't actually want text output but we hadn't had a way to dump image only until we had the ImageFirst feature. - Previous platform-specific -expected.txt for tests under previous ImageFirst directories are removed and the common baselines are created because the baselines are no longer platform-specific without the layout dump. Extra -expected.txt baselines are not deleted in this CL. Will follow-up in https://chromium-review.googlesource.com/c/chromium/src/+/1286894. Bug: 703899 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ifcf7fea90684e133b4222909ee508469d0c985e0 Reviewed-on: https://chromium-review.googlesource.com/c/1277654 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Robert Ma <robertma@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#602161}
-
Jun Mukai authored
It seems nobody is using this, so it's safe to remove entirely. Bug: none Test: build succeeds Change-Id: I7121c85f1cf132894ee191aa61e22acf32aff77d Reviewed-on: https://chromium-review.googlesource.com/c/1297133Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#602160}
-
Collin Baker authored
This will allow wider use of this class without creating trivial subclasses. Bug: 887991 Change-Id: I885dd5e0319b1ad3aea22b0d04c4a377f65ba358 Reviewed-on: https://chromium-review.googlesource.com/c/1294408 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#602159}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/76181e617aa7..29e179cc0d5f git log 76181e617aa7..29e179cc0d5f --date=short --no-merges --format='%ad %ae %s' 2018-10-23 derat@chromium.org chromeos_config: Reenable Tast on VM paladin builders again. 2018-10-23 yshaul@google.com chromeos_config: Migrate test config from IncrementalBuilders 2018-10-23 yshaul@google.com chromeos_config: Migrate test settings from ApplyCustomOverrides 2018-10-23 dgarrett@google.com chromeos_config: Make *-payloads builds Prod builds. Created with: gclient setdep -r src/third_party/chromite@29e179cc0d5f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I519b11f38aa7650c4fc5baae08107da329e37780 Reviewed-on: https://chromium-review.googlesource.com/c/1297274Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602158}
-
Justin Cohen authored
Bug: 894099 Change-Id: I06d27f47125b5a7d056bcf0ae78f3765cd999c0e Reviewed-on: https://chromium-review.googlesource.com/c/1294295Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#602157}
-
Jun Mukai authored
This reverts commit 74e42e9b. I added this but wasn't the right fix. After the number of fixes for crbug.com/897875, SendKeyPressSync now waits for the change of focus, so this code isn't necessary anymore. BUG=894911 TEST=interactive_ui_tests --enable-features=SingleProcessMash Change-Id: I8b7df7e400d66878e66940f7f676906d935e11f7 Reviewed-on: https://chromium-review.googlesource.com/c/1297410Reviewed-by:
-
Liquan(Max) Gu authored
We need to report Largest Image Paint to UKM and UMA. This CL uses mojo to send the metric from web performance (Blink) to the page load metrics (Browser). The browser then reports the metric to UKM and UMA. Privacy review: https://docs.google.com/document/d/1LJnD-INFo7UnvPyB6C-tzpJ3BLK9rYA2SbnwTcsyeTs/edit# Bug: 869924 Change-Id: I7825634630f924c6016c3d24cf295b33acd6ba3b Reviewed-on: https://chromium-review.googlesource.com/c/1283474Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602155}
-
Jordan Demeulenaere authored
This is necessary for some websites that have listeners for keyboard events (e.g. atomtickets.com), which trigger some validation in JavaScript that will be ran only if we actually type the value. Bug: 806868 Change-Id: Ifaf56957c4d133fb6c14588e79e3adbc3d8c6f27 Reviewed-on: https://chromium-review.googlesource.com/c/1293590 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#602154}
-
Antoine Labour authored
This is to be consistent with GLES2DecoderImpl and RasterDecoderImpl. Bug: 870116 Change-Id: I07f7cf15db40046a3ada72bf3fa9621b252dd65e Reviewed-on: https://chromium-review.googlesource.com/c/1297063Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#602153}
-
Esmael El-Moslimany authored
Bug: 888922 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I703c74ed1e849bf9fb3814976163dd2a6b6a3a54 Reviewed-on: https://chromium-review.googlesource.com/c/1263561 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#602152}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/087e9bed41f5..73f3917e89ca git log 087e9bed41f5..73f3917e89ca --date=short --no-merges --format='%ad %ae %s' 2018-10-23 eladalon@webrtc.org Add support for signed deltas in FixedLengthDeltaEncoder 2018-10-23 eladalon@webrtc.org Disable CertificateTest.CertificateIsUsedInConfig Created with: gclient setdep -r src/third_party/webrtc@73f3917e89ca The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If22cbc32ecc71da8bb69e461748c5d3f0d9afe25 Reviewed-on: https://chromium-review.googlesource.com/c/1297116Reviewed-by:
-
Philip Rogers authored
BlinkGenPropertyTrees (BGPT) is an incremental step towards making compositing decisions after the paint lifecycle phase. The primary changes are to build property trees in blink and send a layer list to the compositor, rather than building property trees in cc from a layer tree. This patch marks the project as experimental which will give us test and perf coverage on the bots. Sheriffs: This shifts time (e.g., we now run PaintArtifactCompositor and no longer run the cc property tree builder) and will likely change performance benchmarks. Because this is an initial trial, feel free to roll this patch out. Bug: 836884 Change-Id: Ib867beebbead940162db0801822389f76e8eb8dc Reviewed-on: https://chromium-review.googlesource.com/c/1294204Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602150}
-
Lukasz Anforowicz authored
Change-Id: Ie0eaee0bf820107ac4bc4f27b965fbe9ddfcc53f Reviewed-on: https://chromium-review.googlesource.com/c/1289996 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#602149}
-
Xianzhu Wang authored
- Naming: ThisOrNextLayersDoXXX => AnyLayerDoesXXX to shorten the names HasImage => AnyLayerHasImage because HasImage was ambiguous about whether it was for the FillLayer itself or all whole FillLayer chain. - Implementation: Now use the same caching mechanism for all queries of properties for the whole FillLayer chain. Also renamed some ComputedStyle methods using the FillLayer methods to keep consistence. Change-Id: I87d64b144baacb0dfba8c1ae70a6c6b97d11c0ea Reviewed-on: https://chromium-review.googlesource.com/c/1297170 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602148}
-
Alexander Alekseev authored
Do not show HID detection screen for devices that have virtual keyboard and pointing device. Bug: 890142 Change-Id: I0fa128664166a566fead192174253d1e6fef878a Reviewed-on: https://chromium-review.googlesource.com/c/1297399Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#602147}
-
Bill Orr authored
The idea here is that we have potentially multiple "runtimes" backing a single VRDisplay for WebVR so we don't need GVR for magic window sessions. However, that means we have to aggregate multiple display info changes coming from multiple runtimes and decide which display info the aggregate device reports. This flag is used as part of that logic - mostly we take the presenting display info. This was a simple copy-paste error that causes us to treat immersive sessions as non-immersive for these updates. BUG=897401 Change-Id: If4685282e8756875b85b808aa61aca1e9622cb16 Reviewed-on: https://chromium-review.googlesource.com/c/1295317 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#602146}
-
Alexandre Frechette authored
Bug: 883456 Change-Id: I48aab1bb09fe5527cc6ad07a9c3ccadc87224055 Reviewed-on: https://chromium-review.googlesource.com/c/1291784 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#602145}
-
siyua authored
And also remove card index since we are not using index for checkbox status update. Bug: 897998 Change-Id: I60513831b0392c469d62dfd45a15719670662272 Reviewed-on: https://chromium-review.googlesource.com/c/1287434Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#602144}
-
Kevin Strohbehn authored
Bug: 897892 Change-Id: I0f1412fba8ee32d998f7166a90c1d4ee7d78b70b Reviewed-on: https://chromium-review.googlesource.com/c/1292891 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602143}
-
dpapad authored
Because of Polymer 2's different observer dependencies semantics the default setting was erroneously toggled when the user enter the subpage. Bug: 897236 Change-Id: I83b8959734e85d39e35f0acd187062326143b876 Reviewed-on: https://chromium-review.googlesource.com/c/1297231Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#602142}
-
dpapad authored
Wrapping <style is="custom-style"> with <custom-style> per Polymer 2 migration guide. Bug: 897221 Change-Id: If7fe3c858b631ad11604feb7f1eb144b1488ccfb Reviewed-on: https://chromium-review.googlesource.com/c/1297253Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#602141}
-
Mohamed Heikal authored
Add a new function to build_utils to make it easier to filter output from CheckOutput if you just have a regular expression matching silenceable lines. Change-Id: I41f1c94fbe47405aae980a00df137439825a7f05 Reviewed-on: https://chromium-review.googlesource.com/c/1284751 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#602140}
-
Xianzhu Wang authored
Whether a test produces pixel results should be decided by the test itself. Controlling that outside of the test is unnecessary. Removing it can greatly simplify our code. This is a preparation to replace the ImageFirst feature with a better solution (https://chromium-review.googlesource.com/c/chromium/src/+/1277654). TBR=mkwst@chromium.org # For simple passive changes Bug: 703899 Change-Id: Ia04b622e24f88cf2408f20e5e6888d933e34dac5 Reviewed-on: https://chromium-review.googlesource.com/c/1277820 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
-
Justin Cohen authored
While ios/chrome will soon be dropping iOS10, ios-web will need to continue to support the old versions SDK. Bug: 894099 Change-Id: I9743fc39eccf7493ee4df8f09bd9313ee05e84ad Reviewed-on: https://chromium-review.googlesource.com/c/1296678 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Xida Chen authored
Right now the CSSPaintDefinition::Paint takes a FloatSize which is the container size without subpixel snapping. So when we create the paint worklet input, we should use the same FloatSize. Bug: 884698 Change-Id: Ifcabb84cdb8db041a8ebd28112d4943c4c7adcb0 Reviewed-on: https://chromium-review.googlesource.com/c/1291783Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#602137}
-
Morten Stenshorne authored
Got fixed a long time ago by something, and got picked up by https://chromium-review.googlesource.com/844269 , which fixed the NG-specific expectations file. TBR=kojii@chromium.org Change-Id: Ib973a02cc91d2699b9c9b6fdd927ff24f997da42 Reviewed-on: https://chromium-review.googlesource.com/c/1296607Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#602136}
-
Esmael El-Moslimany authored
When |ticks.length == 1| or the public |disabled| property is true, the slider is effectively disabled. Bug: 895831 Change-Id: Iea13afaec1b784a433fd9f7fa8fe9d7a98a531b9 Reviewed-on: https://chromium-review.googlesource.com/c/1284090 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4624f363d41a..8f7440e30ca2 git log 4624f363d41a..8f7440e30ca2 --date=short --no-merges --format='%ad %ae %s' 2018-10-23 treehugger-gerrit@google.com Merge "perfetto: Commit memory in chunks in TraceBuffer" Created with: gclient setdep -r src/third_party/perfetto@8f7440e30ca2 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I100a4101a3ec8b0adb966df381d9f88d4798b0d1 Reviewed-on: https://chromium-review.googlesource.com/c/1297272Reviewed-by:
-
Josh Gao authored
Having multiple objects simultaneously own a file descriptor inhibits error-checking that prevents unintentional double closes where we don't immediately release an fd from the previous owner after handing over ownership. Release the fd before passing ownership instead. Bug: 897897 Change-Id: Iecc5fa434d2e676fef44b9d27313337efd02c9e3 Reviewed-on: https://chromium-review.googlesource.com/c/1297411Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Josh Gao <jmgao@google.com> Cr-Commit-Position: refs/heads/master@{#602133}
-
Xiaohui Chen authored
Bug: None Test: locally build Change-Id: If7f936051ecc056969e10328fed1ffe257cce226 Reviewed-on: https://chromium-review.googlesource.com/c/1297351Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#602132}
-
Xiaohan Wang authored
This CL converts MediaSourceTest to use GetMimeTypeForFile() to get the mime type for test files to remove duplicate code. Bug: 897767 Test: No functionality change Change-Id: I5953cf8ae4e466d6fbb9c5d0ea021077a6f27f7f Reviewed-on: https://chromium-review.googlesource.com/c/1296998Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#602131}
-
erikchen authored
Previously, the implementation only worked on Win8.1+, and had no fallback for DiscardVirtualMemory failures [which are known to occur on some Win10 versions]. This CL switches the logic to be the same as PartitionAlloc -- it uses DiscardVirtualMemory with a fallback to VirtualAlloc(MEM_RESET), which works on all OSes. Change-Id: Icb3fcf8de12820496c613af5ab4ce2a5386aabef Reviewed-on: https://chromium-review.googlesource.com/c/1291389Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#602130}
-
Yunlian Jiang authored
glibc 2.27 changed the implementation of the "raise" system call to block all signals and call getpid/gettid, and then finally call raise. This implementation breaks our test, so we use 'kill' instead. BUG=chromium:896903 TEST=sandbox_linux_unittests passes on host with glibc 2.23 and glibc 2.27. Change-Id: I4a037989cddb29d7dff2741f3abd03947feef8b2 Reviewed-on: https://chromium-review.googlesource.com/c/1294845Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Yunlian Jiang <yunlian@chromium.org> Cr-Commit-Position: refs/heads/master@{#602129}
-
Philip Rogers authored
This patch is a followup to https://crrev.com/601428 and stops clearing the paint controller in SPV2 mode. This prevents flashing on all pages when running with SPV2+BGPT and will unblock making BGPT experimental (all SPV2 layout tests fail without this change): https://chromium-review.googlesource.com/c/chromium/src/+/1294204 Bug: 836902 Change-Id: I80bea03bc3d06c5fe6761734babdf6517813e7bb Reviewed-on: https://chromium-review.googlesource.com/c/1297060Reviewed-by:
-
