- 22 Jan, 2021 40 commits
-
-
Yusuke Sato authored
The former has been moved to platform2/arc/setup. The latter is not used anymore. BUG=chromium:1163122 TEST=try Change-Id: I104a468668b7e56087740818ef5cdf93a370f761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613398 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#846270}
-
Monica Basta authored
This CL resets the invalid state of the input profile name on the profile picker's local profile creation flow on navigation to the flow if the profile name is empty. Fixed: 1169724 Change-Id: I81ab063edbc544102aea0dc439e8b2de18774898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643731Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#846269}
-
Matt Jones authored
This patch adds a LayoutManagerProvider with a static method to access the activity's LayoutManager. This patch has a fair amount of indirection to keep certain apis internal and the public api clean. LayoutManagerAppUtils: A utility class only exposed to app or glue code to attach the LayoutManager to the window. This exists in its own build target with ManagedLayoutManager. ManagedLayoutManager: Another app/glue code api for lifecycle management. This extends LayoutManager and includes other external signals that would not otherwise be exposed through the LayoutManager interface. LayoutManagerProvider: This is the main access point for clients wanting an instance of the LayoutManager. LayoutManagerProvider.Unowned: A package-protected interface for obscuring attach and detach method implementations in the public api. Bug: 1161560, 1167255 Change-Id: Ie9561cd6d9dafcca8acac54a85c3c7bc27ca085e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634003Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#846268}
-
Monica Basta authored
Fixed: 1162443 Change-Id: I32b86c1d8bb600e45920aaf508a2ad313354e930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645124Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#846267}
-
Lukasz Anforowicz authored
After this CL, blink::ResourceFetcher should not start HTTP requests if an MHTML archive is present. Additionally tweak GetCacheIdentifier to make sure that globally cached requests (e.g. fulfilled via HTTP) are not reused for requests within MHTML archive. Change-Id: I3b7253c22bc42b941d9abd8dec82e58f730dd815 Bug: 1168249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638219Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#846266}
-
Owen Min authored
CloudReportingExtension is fully deprecated in Chromium. Hence we no longer need to support them in the management UI. Also removing safe browsing message from the management UI as there is nothing display this message. Bug: 1107440 Change-Id: I67eab265860a2b31930fd8255027bf6109a19b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642186Reviewed-by:
Greg Levin <glevin@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846265}
-
James Cook authored
Regression test for https://crbug.com/1157664. Verifies that opening a menu via long-press on a tab does not result in a popup window with empty bounds. In production this bug caused a Wayland protocol error and lacros crash. Adds a new test crosapi to inject touch events from the ash side. See comments in test for why we do it this way. I verified that this test fails appropriately when the fix for the original bug is reverted. The test does not reproduce the Wayland protocol error, because that error is in code that only runs when graphics overlay forwarding is enabled, which only happens on device. However, it's sufficient for the test to verify that the popup in lacros has non-empty bounds. Bug: 1157664 Test: lacros_chrome_browsertests Change-Id: Ia8aabaec1d6ec4bc72d1e77eda9a7f0efbe5f0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643026 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#846264}
-
Owen Min authored
Round II EXPECT_DEATH tests are executed in a sub-process. However, this doesn't work with the BrowserWithTestWindowTest which requires access to the global |g_browser_process| instance. Running in a sub-process causes crash during SetUp(). The test was passed as EXPECT_DEATH can catch the crash inside SetUp() but it didn't check the crash error message. There is no good way to solve this issue, hence only run the NoExtension test while DCHECK is off and no longer verify any DCHECK failure. Bug: 1137094 Change-Id: I59a9eb4ab0c6283194dbd80f8f1afec15410def0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643629 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#846263}
-
Nina Satragno authored
This reverts commit d2adbc52. Reason for revert: causing ~600 html failures on tests Example stack trace STDERR: Received signal 11 SEGV_MAPERR 000000000099 STDERR: #0 0x56419ad17d39 base::debug::CollectStackTrace() STDERR: #1 0x56419ac8fc63 base::debug::StackTrace::StackTrace() STDERR: #2 0x56419ad178e1 base::debug::(anonymous namespace)::StackDumpSignalHandler() STDERR: #3 0x7f96ed01d390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f) STDERR: #4 0x56419c8a9228 WTF::StaticSingleton<>::StaticSingleton<>() STDERR: #5 0x56419c8a90cc blink::CounterStyleMap::GetUACounterStyleMap() STDERR: #6 0x56419c8da407 blink::StyleEngine::FindCounterStyleAcrossScopes() STDERR: #7 0x56419ce564a7 blink::ListMarker::GetCounterStyle() STDERR: #8 0x56419ce5640e blink::ListMarker::GetListStyleCategory() STDERR: #9 0x56419ce56d3e blink::ListMarker::InlineMarginsForInside() STDERR: #10 0x56419c8846ae blink::StyleAdjuster::AdjustComputedStyle() STDERR: #11 0x56419c877f3c blink::StyleResolver::PseudoStyleForElement() STDERR: #12 0x56419c964063 blink::Element::StyleForPseudoElement() STDERR: #13 0x56419c9a6bd9 blink::PseudoElement::CustomStyleForLayoutObject() STDERR: #14 0x56419c95b52f blink::Element::StyleForLayoutObject() etc see e.g. https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/22892/test-results Original change's description: > Refactor counter style updates > > Currently, counter style updates is a phase in UpdateActiveStyles. This > patch moves it out as a standalone phase of UpdateStyleAndLayoutTree, > so that we update counter styles only when needed. > > This patch also adds MarkCounterStylesNeedUpdate() to indicate whether > counter style updates are needed. > > Note: After refactoring, the framework of counter style updates looks > almost identical to font updates. This is intentional. We will try to > unify them in the future. > > Bug: 687225 > Change-Id: If07de2878ae5faa6800644a967029a569bef566a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639535 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#846203} TBR=xiaochengh@chromium.org,futhark@chromium.org,andruud@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I3c1e09dce14cd4edb366b911d3aaf5da66b2b100 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 687225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644742Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#846262}
-
Nicolas Arciniega authored
This policy allows an admin to specify a list of URLs for which their users can bypass the SSL error interstitial when the existing SSLErrorOverrideAllowed policy is enabled. On all other URLs, their users will not be able to bypass the SSL error interstitial. This policy has no effect if SSLErrorOverrideAllowed is disabled. Bug: 1156778 Change-Id: I4294c96f0bea4dfcc405e1d57539e92b4bda33ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631291 Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#846261}
-
Rahul Singh authored
This CL updates the MFAttributes we use for video capture on Windows. By default, we only include MFAttributes for RGB color cameras. So, the resulting device enumeration contains only RGB cameras. When the newly added `kIncludeIRCamerasInDeviceEnumeration` feature flag is enabled, we also include MFAttributes for IR cameras. The resulting device enumeration contains both RGB and IR cameras. Testing: Created versions of the GetDevicesInfo unittest with the feature flag enabled, and with it disabled. Bug: 1144049 Change-Id: Id234413f5125e866be5177141decfc9a68bc2fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631409Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#846260}
-
Sophie Chang authored
Bug: 1107336 Change-Id: Ia380c1f73fb2f5c768eb4c94602f061aafac3cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638445 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#846259}
-
Cammie Smith Barnes authored
This CL is part of the Code Health Rotation, and converts base::Bind, base::Callback, and base::Closure to Once/Repeating as the code context dictates. It also replaces 'typedef' with 'using' in several places adjacent to other changes. Bug: 1007635 Change-Id: I90dfca648b536d677cadf74694992fb0d0923d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630369 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#846258}
-
Ryan Heise authored
Bug: chromium:1163679 Change-Id: I7df0737b2c7ab66af29429f6ec8d47cc1b08a45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644378Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#846257}
-
chrome://appsdpapad authored
Removing not just any dead CSS code, but specifically CSS code that relies on flattenhtml=true. This is part of the effort to remove flattenhtml usages and auto-generate a grd file for chrome://apps. Specifically the elements styled in the dead code (.close-button) were - Added at https://codereview.chromium.org/7124002 and https://codereview.chromium.org/7342017 - Removed athttps://codereview.chromium.org/1129903008 and https://codereview.chromium.org/1753783004/ (~5 years ago). Bug: 1152343,1169733 Change-Id: If05ffdec4d95bee6c9b146dc4a7ac86d2040f135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643558Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#846256}
-
Mikel Astiz authored
The fake server leverages the recently used authenticator API, syncTrustedVaultKeys, that allows the server to provide sync encryption keys during authentication. This server-side logic triggers only if the client expressed the desire to receive sync trusted vault keys, achieved via newly-introduced URL parameters. Change-Id: I1538d83fd9716fbdc7989d299911368ba346e39b Bug: 1081651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587171Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#846255}
-
Mike Jackson authored
Per UX review, the only planned place to expose Run on OS Login is via the context menu option on a web app listed in chrome://apps list. This change cleans up a code comment indicating it might be surfaced elsewhere in the UI. Bug: 1110407 Change-Id: I43c5987d18ba42081b88eea723a776d556ea839c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633878Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Mike Jackson <mjackson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#846254}
-
Hui Yingst authored
The in-page coordinates from an XYZ named destination sometimes can be out of the range of the PDF's page width and height. This CL preprocesses such out-of-range x and y coordinates before converting them from in-page coordinates to in-screen coordinates. Bug: 1157061 Change-Id: I3279890459188e3856c75478caebefa6bafaa655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633191 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#846253}
-
Clemens Arbesser authored
The initial url can and often is a redirect to the deeplink, rather than the deeplink itself. That can lead the client to believe that we are triggering on the wrong domain. Bug: b/178082640 Change-Id: Ife02a1acbb17d52042b016501a1eb9abdd01b3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642787Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#846252}
-
Kyle Milka authored
Create base for area selection dialog. Currently just display an empty dialog with the title and two bottom buttons with logic/classes added to control the dialog. Bug: 1153969 Change-Id: I489dc95d198037e57262938bf9f94fc6041dbbff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630825Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#846251}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611316382-261a271ac3191d9a6f726d2f754b45ee0d0f178e.profdata to chrome-win32-master-1611327254-197533b8b85e35cc3db30df56ae54c1d061aca59.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I40b29a3c3ccd5db365180e300ba481462ce8d2d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645108Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846250}
-
Liviu Tinta authored
When we run web tests with --enable-thread-compositing we have a compositor thread available. The code in web_page_popup_impl.cc assumes all web tests are run single-threaded. In single-threaded web tests, the owner frame tree runs the composite step for the popup. If --enable-thread-compositing is used allow the popup to run the composite step. virtual/scroll-unification/fast/forms/suggestion-picker, virtual/scroll-unification/fast/time Bug: 1144434 TEST: virtual/scroll-unification/fast/forms/select-popup, Change-Id: I969f825fd6fc331f1e1ed682b98b3e18caeb4f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636296 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#846249}
-
Avi Drissman authored
If no architectures are specified in the distribution pkg, the installer on M1 Macs will assume the package requires Rosetta and will show a dialog asking to install it. Showing such a dialog prevents the package from being installed unattended or at the login screen. Therefore, include architecture information in the distribution xml. For reference: https://scriptingosx.com/2020/12/platform-support-in-macos-installer-packages-pkg/ Fixed: 1169145 Change-Id: I63e26ede4ec4d583ca090121e91c3c4a5d7ebe04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643167 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#846248}
-
Nate Fischer authored
This extends two histograms (and changes ownership) and marks two others as obsolete (removing the relevant code). Fixed: 1160837 Test: run_webview_instrumentation_test_apk -f "*Variations*" Change-Id: I97267f2b2c81bebfb5cd8b572f0b0cdb1ecb3d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639168Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#846247}
-
Elly Fong-Jones authored
I missed one part of the test in r846127. Bug: 1101339 Change-Id: I2e0cdc56c31800577baecf2e10cb233ab7311099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645205Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#846246}
-
rajendrant authored
This CL records the ineligibility for Blink disabling images for subresource redirect. Bug: 1167025 Change-Id: I615fba6989b9fa2bb2d7391e45bd89348992c731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633097 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Auto-Submit: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#846245}
-
Daniel Hosseinian authored
The PDF Viewer has a password dialog that is prompted to the user before the document loads. However, PDF browser tests run only after the document loads. Alter the EnsurePDFHasLoaded() helper method to also return when the PDF prompts the password dialog. To do so, a 'passwordPrompted' message is sent to the PDF Viewer embedder. Bug: 1167036 Change-Id: I17ae5daa4e6ce51ad1bc402c7d352beadae43256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639293 Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#846244}
-
Salvador Guerrero authored
This CL modifies the trace events logged in components/content_settings to used the new API with typed arguments. Change-Id: I20f64bb9cefaef739651f12fbaa1f6340ae9c25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627938Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#846243}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/361ccce1243f..5397151e88ff 2021-01-22 ehmaldonado@google.com Add whitespace.txt If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I24d72e9ec0dd7b6a76db324f693372504b5e68cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643345Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846242}
-
Eric Seckler authored
Follow-up to crrev.com/c/2644798. The symbol also needs to be exported and defined in a .cc. Bug: 1168791 Change-Id: I0c7308bfe24846381d3dcad00e8d76f337909634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645005Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#846241}
-
Curt Clemens authored
The following strings are updated: * Contact visibility page "Hidden" description * Onboarding page subtitle * Discovery page help text Fixed: 1168268, 1168262, 1168271 Change-Id: I3efb9d454b539ffdb869bc58138f514d0d26ccdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643463Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#846240}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/28c13893f937..1dbdce5fbbcb 2021-01-22 jacktfranklin@chromium.org Improves render performance of DataGrid If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1169021 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibcf36678974bae6541e0d0549f88ffa53714d2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846239}
-
Shimi Zhang authored
Android framework (TextView) uses SuggestionSpan.SUGGESTION_MAX_SIZE, we should match the behavior in WebView and Chrome. See https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/java/android/widget/SpellChecker.java;drc=401e3d4c842ce86569de4477138137dc07a6aa6f;l=318 Bug: b/177876412 Change-Id: I0583668645c953629b793b901e1b467058df2535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644318Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#846238}
-
Katie Dektar authored
As requested by PgM and TLM. AX-Relnotes: N/A Bug: 1121204, 1160728 Change-Id: I47c20f62c2ea236d37f2a2537d659fc200069eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638007Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#846237}
-
Dave Tapuska authored
Move ZoomToFindInPageRect and get rid of the WebRect usage. BUG=738465 Change-Id: I50802f600b80d28694eac1538e22cc001021f6a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641120 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#846236}
-
Guohui Deng authored
Bug: internal b/166313191 Test: None Change-Id: I2d9c60c33a9076f73140a2b6181820ec2382c3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643401Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Guohui Deng <guohuideng@chromium.org> Cr-Commit-Position: refs/heads/master@{#846235}
-
Yusuke Sato authored
This CL depends on https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2611416 BUG=chromium:1163122 TEST=tast run arc.Boot[.vm] Change-Id: I84a2f6c3a818877abba54cce15106a670386b1e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613917 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#846234}
-
Monica Basta authored
The tooltip is only useful when the profile name or the gaia name is long enough to be truncated. This CL also fixes the flickering of the profile card container and profile card cursor at the bottom of the card due to the gaia name tooltip. Fixed: 1169169 Change-Id: I106cde6aff8e26b895af6293e73776f45732ea6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642371Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#846233}
-
Xiaoqian Dai authored
Rename |restore_focus_window_| to |active_window_before_overview_| to better match the code. The active window might not be the same window as the focused window, but by activating the right window, the focus will be restored properly as well. Pure renaming. No functional change. Bug: None Change-Id: I67250ce1fd5a48cf817ec04ef4f59de0ab83c38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644348Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#846232}
-
Oriol Brufau authored
r834202 changed MutableCSSPropertyValueSet::SetProperty so that, when changing the value of a property that belongs to a logical property group, which is followed by a property in the same logical property group but opposite mapping logic, the changed property is moved to the end, to ensure it takes precedence. However, this regressed the CSSPropertyUpdateValue perf test. This patch adds a may_have_logical_properties_ flag. When false, it means the MutableCSSPropertyValueSet has no logical property, so we can skip the extra work added in r834202. Bug: 1156321 Change-Id: I4ab6d92cf51126bcab16ffa9635bf91c98d6f738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640097Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#846231}
-