- 13 Jan, 2021 40 commits
-
-
Mikel Astiz authored
The general idea is that, if a client tag is provided upon *creation* of a bookmark, it should be delivered back to clients during later GetUpdates. In order to do so, PersistentBookmarkEntity is extended with a new member field to accommodate the client tag hash, and the corresponding conversion to/from protos. Bug: 1032052 Change-Id: Ie5fe597abb6b913da46a293a5f7bdee4446fcf6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624467Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#843151}
-
Joe Downing authored
We currently have a maximum session duration hard-coded for Linux hosts (20 hours) but it isn't configurable and Windows/Mac don't have a max duration. This CL adds a policy to allow network admins to configure the maximum duration of remote access sessions. The policy will be applied to hosts running on Windows, Mac, and Linux. Change-Id: Ia535979155a3f7bfe45c3a2b703e6e84fcae9852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626130 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#843150}
-
Trent Begin authored
Some devices do not have batteries and will have a null BatteryInfoPtr to represent this. This value needs to be checked before being used when processing the CrosHealthdProbe. Bug: chromium:1159440 Change-Id: I427ba3a8fd9d6a3b26ef0e0e2a21b30d3bdd92a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626097 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
-
Ilya Nikolaevskiy authored
This reverts commit 3ca3d70c. Reason for revert: Broke "Share this tab instead" button. Original change's description: > Minor UI logic changes to prevent a UAF bug when starting tab capture. > > See discussion in crbug 1155426 for details. Changes: > > MediaStreamCaptureIndicator::UIDelegate: Ignore multiple calls to > OnStarted(). > > TabSharingUIViews: Unconditionally execute clean-up tasks in destructor. > > Bug: 1155426 > Change-Id: I392fba38118ce51744ba36b4dec19ebfe39f1fbe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581028 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> > Commit-Queue: Yuri Wiitala <miu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835736} TBR=miu@chromium.org,guidou@chromium.org,marinaciocea@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. TBR=marinaciocea@chromium.org Bug: 1155426, 1165947 Change-Id: I9df25d596cb4df7b5e98db78f019b2665b01e8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627848 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#843148}
-
Justin Cohen authored
This API seems to trigger a TCC violation on iOS13 but not iOS14. Simply reverting on iOS13 for now. Bug: 1159431 Change-Id: I7cf85099536aa9ae44345240bd1d8f1ca67f96a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625912 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#843147}
-
Tommy Li authored
For keyword conflicts, never Remove() prepopulated engines during the deduplicate step. This also makes sure that an Add() call using a prepopulated engine never fails, even if it the prepopulated engine is outranked. This is needed for proper DSE repair. These changes are not strictly speaking necessary, since we have made prepopulated engines outrank autogenerated engines now. However, it's still possible for an extension or user-added engine to have a keyword matching the prepopulated engine, so we still want to do this to handle that unusual case. We think we eventually will make prepopulated engines marked as NOT safe_for_autoreplace(). Even if that happens, we should keep this newly added check in place to handle old database entries. Bug: 1164024 Change-Id: I362bb44a54b39caa4ad6400a8e478fc5a5941305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621961 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#843146}
-
Peter Kasting authored
Bug: 1159562 Change-Id: I0d2bc560e7abe14e4b6ff8be56fb841e9e98ce63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626197 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#843145}
-
Fabrice de Gans-Riberi authored
This removes the fuchsia sub-namespace from the following classes: -ScopedServiceBinging -ScopedServicePublisher -ServiceDirectoryTestBase A ::base::fuchsia pseudonym is left in place for these classes for the duration of the transition. In addition, this CL removes an unused source file. Bug: 1073821 Change-Id: I2c0bb6215e9bc073ec03b37834a887457ebcff38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602596 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#843144}
-
John Delaney authored
This is a reland of 107694e1 The change was reverted due to an uninitialized member on an Impression object in the test. The reland defaults Impression.impression_data to 0 to avoid these types of errors. Original change's description: > [conversions] Use base 10 encoding for impression and conversion data > > What: > No longer parse impressiondata as hex, or use hex when sending > conversion reports. > > Why: > This causes needless conversions for developers, as raised on > https://github.com/WICG/conversion-measurement-api/issues/60 > > Note that the conversions database stores imp and conversion data as > strings currently because they are represented as hex. These can > be converted to strings now, but this is left as a followup. > > Bug: 1163599 > Change-Id: I5b164c380a97cb272c6a0ee698df8b744feb58ae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611958 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Commit-Queue: John Delaney <johnidel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842561} Bug: 1163599 Change-Id: I192ba4b9452c3ad97f9511ce093f36f9c697ba2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625293Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#843143}
-
Joe Downing authored
This CL addresses an issue where KeyboardLock stops working (on Windows) when the microphone permission is granted. I tracked this down to the RawInput key handler created by the UserInputMonitor instance used in the audio pipeline (for keypress noise cancellation). After discussing this with the audio team last year, we decided to pause the UserInputMonitor when keyboard lock is engaged (and resumed when keyboard lock is disengaged). In order for the UserInputMonitor to know when the keyboard hook has been engaged, I've added a KeyboardHookMonitor class that the keyboard hook impl can use to notify observers of keyboard hook status changes. Change-Id: Ib8a51a0a49d33c6989c9325739d071c26860f98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615666Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#843142}
-
Toni Barzic authored
On some boards privacy switch state gets reported only when the camera is active (due to hardware limitations). In these case, when the camera is off, chrome will notice the privacy switch is on only after the active camera client gets set - in these cases, prefer showing notification over toast when the camera privacy switch state changes to ON (from UNKNOWN). Change-Id: I55990b10d3b89285b9fe064d87e5bf82adf453c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625821Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843141}
-
Joe Mason authored
Do not trigger WebMeasureMemoryStressTester from opaque origins. WebMeasureMemory hits a DCHECK in FindAggregationStartNode when triggered from a page with an opaque origin (such as chrome://discards/graph): [24736:30760:0113/113856.302:FATAL:web_memory_aggregator.cc(416)] Check failed: requesting_origin.IsSameOriginWith(GetOrigin( start_node)). The cause is that each time an Origin is constructed from the same URL, a new opaque origin is returned. R=ulan Bug: 1085129 Change-Id: Ibbf23b9c9f085ab3f447551d54b0809000e1e863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627622 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843140}
-
Daniel Cheng authored
On-stack tracing of TraceWrapperV8Reference Just Works. Bug: 1013149 Change-Id: I8c403cd4b9c86adb344fefbf32602d87d39eceb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625372Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#843139}
-
Michael Lippautz authored
Drive-by: Cleanup HashTraits for Member and friends. Bug: 1056170 Change-Id: I5fe4c7c2b5ae958e80e8078919f4bfec9cd8b539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626660Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#843138}
-
Michael Bai authored
Bug: 1160723 Change-Id: I5c12e4a0034f52aff475959832b0857ecbaf1525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625530Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#843137}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610538373-76fca52980f687d249587bbfe52df46587227f16.profdata to chrome-win64-master-1610549866-1e248feef781fb0cfb48b77513413e45541eeb72.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I25754d6f46baae1b6fa2efd83403f7b34049467e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627807Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843136}
-
Scott Lee authored
Visit https://crbug.com/1163553#c12 for the context. Bug: 1163553 Change-Id: Ib9ae405f1bfeb2bff552836cc83101d88d330ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611572 Commit-Queue: Scott Lee <ddoman@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#843135}
-
dpapad authored
Preparation for bundling the PDF Viewer's resources, step 2/3. - Add a pdf_viewer_wrapper.js top-level file, necessary to make tests work in both optimized_webui true/false modes - Update all PDF Viewer tests to import dependencies from the new file - Minor tweaks to keep Print Preview working, while using the same c/b/r/pdf/main.js file Bug: 1163956 Change-Id: I92dde642f94edbcf08ff72c9cdb5c11bd9f7e8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625334 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#843134}
-
Andrew Xu authored
This CL allows a copied image to be shrunk in order to fill the contents area of a clipboard history menu item. Bug: 1165286 Change-Id: I4ce2ce415021b04db4b5de67815791e5e052103f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627434Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Auto-Submit: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843133}
-
Andrew Xu authored
Now the placeholder image's bounds are smaller than the available drawing area. It brings white lines around the placeholder image, which might be caused by the rendering code (note that we draw the placeholder image through gfx::Canvas's APIs) The specific reason is unknown yet, still under investigation. Given that the paddings of the placeholder image are not really needed, they are removed by this CL. Bug: 1163621 Change-Id: Ibe309ea5044ab2c411917bb4ffd9d58c9d33bc5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627433 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Auto-Submit: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
Bug: 959776 Change-Id: Id86d44b6fd42a06a072f73381ecc78b4a5905336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627159 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#843131}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8fccd82e4e02..704a1aa4c802 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie6c59ffb0d15c5f0ac84cfafddbb703956048679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627432Reviewed-by:
-
Roman Aleksandrov authored
Create behavior which is responsible for initial focus on the screen. Bug: 1165730 Change-Id: If9cf77761acd4a405202ead87cfb3caf952f338c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622394 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#843129}
-
adamta authored
Refactored NTP offset starts negative because of the way the content suggestions header are added on top of the feed. Fixes header synchronizer by using additional offset property to compensate for the negative offset. Bug: 1114792 Change-Id: I62d2be34444d705e8ad7fd862ded80e9e947b783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626830 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#843128}
-
Erik Chen authored
Device attributes are used by the extension API enterprise.deviceAttributes. This API is in the process of being replaced by a new Web API. In both cases, we need to add a crosapi to support this API in Lacros. This CL adds plumbing for the five methods in enterprise.deviceAttributes. From a security perspective, the Lacros implementation checks that the profile is the "main profile" -- which is to say it's affiliated with the log-in ash-chrome proifle. The ash implementation of the crosapi then checks that the profile is a regular, sign-in profile that is affiliated with the device. These security checks mimic the security checks for the existing ash implementation of enterprise.deviceAttributes. Change-Id: Ic4bd2ce88041a3bc7b2af94fa52fef2f0722aac7 Bug: 1164523, 1165882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623722 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#843127}
-
Anupam Snigdha authored
There are cases where the IME tries to replace the characters that are in the middle of grapheme cluster and in those cases |VisiblePositions| adjust the positions to not be at the middle of grapheme clusters. Thus this ends up replacing/duplicating characters in many languages such as Devanagari, Tibetan, Burmese etc. In this patch we are using the |SelectionInDOMTree| instead which has the correct node and offsets which is used to place the positions in the middle of grapheme cluster and perform the composition operation correctly. Also added logic to not remove the existing TypingCommand when a composition is in-progress. Bug: 621394, 1020371 Change-Id: I6472ce2e2e34b43ec3e385a2874dee29a158f5ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619002 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843126}
-
Haiyang Pan authored
Introduced packager_vars.star so that properties will be the shared between CI and matching try builders. Also reorg the following builder to use a similar starlark structure: * android-androidx-packager * android-avd-packager * android-sdk-packager Bug: 1132368 Change-Id: I8001cfa818c2e647cc513e46a2f166fbe1e253df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625271 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#843125}
-
Liquan (Max) Gu authored
Motivation: Currently, we allow all mime-types except for pdf as Payment Handler pages. This exposes payment handlers to the vulnerabilities of certain less-maintained mime-types. Since "text/*", "image/*", "video/*", javascript, xml, json could satisfy a majority of use cases, this CL allowlist the supported mime-types for payment handlers. Before, we disallowed the "application/pdf" mime-type for payment-handler pages. After, we allowlist the following mime-types for payment handler pages: * text/* * image/* * video/* * application/javascript * application/xml * application/json Before, we applied the throttle to mainframes. After, we apply the throttle to all frames. Bug: 1165367, 1165392 Change-Id: Ie69e296dc2c287c38a10ed08c1c40527f941ee47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622871 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843124}
-
Richard Knoll authored
Adds additional timing metrics for the mute notifications feature: - How much time passes before the user takes an action on the notification - How long a screen capture session lasts - How much time passes from start of a session until the user reveals notification content again Bug: 1131375 Change-Id: I70e99cfe5f5726c4372930df84b3a90c37970629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617942Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#843123}
-
Ben Joyce authored
Bug: None Change-Id: I39c221fd574b9d19fe0d9cbabf81769644823e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627142Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#843122}
-
Mitsuru Oshima authored
Bug: 1155308 Change-Id: I6dc2ef187ccd5ab06b6b9b27b9d6ee2880ca8489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617203Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#843121}
-
Benoit Lize authored
Switch to PartitionAlloc for malloc() on Android. According to dev experiments, this is either neutral or a win for memory, performance and stability, with the exception of median GPU process footprint, which regresses by a small amount, but is being addressed. Note to sheriffs: If something breaks in this range on Android, this CL is a likely culprit. Note to perf sheriffs: This is expected to move a lot of performance metrics, in both directions. For details, see linked bugs, and for performance data from experiments, https://docs.google.com/document/d/1asZy8Dy0m97AECTTU2jTbgwc-mwI9BLOMVYKKiQAp04/edit (Google internal). Bug: 1121427, 998048 Change-Id: Ice8d5c65e814a3086d121f8e8641f874d6b9e68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625869 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#843120}
-
Josh Nohle authored
We make a few simple changes to help diagnose the crash occurring in https://crbug.com/1162157: 1) Reset the URL loader and stream parser before invoking the callback to ensure we stop streaming before any callback side effects occur. 2) Add a CHECK to OnDataReceived() to ensure the stream parser is not null. Will change to DCHECK when the crash is resolved. 3) In the stream parser, use the native StringPiece methods to get the underlying data and string length. 4) Add additional VERBOSE logging to ReceiveMessageExpress. I'm skeptical that these changes will fix the crash, but they will help eliminate some possibilities. Bug: 1162157 Change-Id: Ic1eef5c4bf0d047c66420aad29cbd3d93992ba05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627564 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#843119}
-
Oleg Davydov authored
Back in https://crrev.com/c/2485936 a new flag in ExtensionSettings policy was added. Since name of the flag was changed during the discussions, unfortunately, in parsing code and in policy scheme it landed with different names (override_update_url vs update_url_enforced). This CL fixes this. Bug: b:177419604 BYPASS_POLICY_COMPATIBILITY_CHECK=update_url_enforced is the wrong name for the flag and wasn't used anywhere Change-Id: I3df2247f0a75d8737425dba1d4ceb88763326693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627319 Auto-Submit: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#843118}
-
Caroline Rising authored
This metrics is being adding to show trends in user behavior when accessing the reading list. We want to find out whether the user is on the NTP (where the bookmarks bar is always visible) and the status of the bookmarks bar pref (shown/hidden) when a user accesses the reading list. Bug: 1163938 Change-Id: Ie846717e1dca5b217f234d35ef74213623ccf665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622990 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#843117}
-
Andreas Haas authored
A new tracing category was introduced in https://crrev.com/c/2595436. Bug: chromium:1084929 Change-Id: I9327c3375dfd65727f6d5a81bf1efcf51eda90cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627398Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#843116}
-
Dominique Fauteux-Chapleau authored
A small change in ConnectorsService is required to make this test config work. When checking analysis/reporting settings, 2 things are required to obtain settings: a policy set to a valid value and a DM token (from the browser or the profile). The previous implementation checked the DM token first, meaning the blocking BrowserDMTokenStorage::RetrieveDMToken call would trigger on multiple tests and crash them (see patchset 1 failures for examples of this). The solution is to simply switch the order of checks and read the policy first. This is also a valid optimization of Connectors logic, as reading prefs is faster than potentially reading the DM token from local storage. Change-Id: Ie1026b57cf7a4fd66663530ec2a77a72f21d6d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623812 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Marc-André Decoste <mad@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#843115}
-
Nicolas Ouellet-Payeur authored
Previously, when DestroyProfileOnBrowserClose was enabled, the last-used profile could get deleted. This would leave Chrome in a state where no profiles were loaded at all, but the Chrome process is still alive. Some codepaths assume that GetLastUsedProfile() returns a loaded Profile. This patch makes AppController hold a ScopedProfileKeepAlive when there's only 1 Profile loaded. This prevents that Profile's deletion, so GetLastUsedProfile() works as expected. Bug: 88586 Change-Id: I128933003cd708500457ddf8d55b8dfecbcab29d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593749 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#843114}
-
Jamie Madill authored
Was missed on a prior expectations update. Bug: angleproject:5499 Change-Id: I7dbfc0061daf03ca149345f00b620a35095c9d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625992 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843113}
-
Mila Green authored
Bug: 1144151 Change-Id: Ie836759be36fc86e9a3b15b2ee2b6c086bc2f890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625227Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#843112}
-
