- 28 Nov, 2018 40 commits
-
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: Ib22a139e17450b34471a19a9ba46504fe0c1be5e Reviewed-on: https://chromium-review.googlesource.com/c/1352755Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#611771}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I6065320160279528dd1a2e77269ab94e86c6a5c8 Reviewed-on: https://chromium-review.googlesource.com/c/1353887Reviewed-by:
-
Sylvain Defresne authored
This reverts commit ec18ec70. Reason for revert: the conversion was incorrect as the new API is not yet implemented. This probably causes regressions (sad that no tests caught this) and spam logs (see crbug.com/909712). Original change's description: > Convert startup_tab_provider.cc to IdentityManager > > It was using the SigninManager API to check whether the primary > account was authenticated and an authentication was in progress. We > can use the IdentityManager and PrimaryAccountMutator APIs to perform > the same operations. > > Bug: 890801 > Change-Id: Ia2567a567481a4d67b68eee6b714aab72c537b5a > Reviewed-on: https://chromium-review.googlesource.com/c/1346467 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Sergio Villar <svillar@igalia.com> > Cr-Commit-Position: refs/heads/master@{#610389} TBR=ellyjones@chromium.org,blundell@chromium.org,svillar@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 890801 Change-Id: I8df5a79a40c503abd6dd74974a84eded8f69472a Reviewed-on: https://chromium-review.googlesource.com/c/1353980Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#611769}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/ac3eccdc24bc..615922dfb531 $ git log ac3eccdc2..615922dfb --date=short --no-merges --format='%ad %ae %s' 2018-11-27 marpan vp9-svc: Add check/reset for long term reference. 2018-11-27 jianj vp9 svc: copy block if ref buffer in denoiser is NULL. 2018-11-27 jingning Replace deprecated scoped_ptr with unique_ptr 2018-11-26 johann.koenig rename quantize_x86.h 2018-11-26 marpan vp9-svc: Put check on usage of long term temporal ref. 2018-11-26 jianj VP9 SVC: fix crash on scaling partition. 2018-11-26 marpan vp9-svc: Fix to skip enhancement layer setting 2018-11-26 jingning Fix ARF rate allocation for cq mode 2018-11-21 marpan vp9 screen-content: Keep lower step_param for quality layers. 2018-11-21 angiebird Fix scan_build warnings in user_priv_test.cc 2018-11-21 marpan vp9 screen-content: Adjust seach step param 2018-11-20 angiebird Fix scan_build warnings in tiny_ssim.c 2018-11-20 angiebird Fix scan_build warnings in convolve_test.cc 2018-11-20 angiebird Fix scan_build warnings in vp9_loopfilter.c 2018-11-20 angiebird Fix scan_build warnings in variance_test.cc 2018-11-20 angiebird Fix scan_build warnings in vp9_resize.c 2018-11-20 angiebird Replace assert by ASSERT_TRUE 2018-11-19 angiebird Fix scan_build warnings in temporal_filter_test.cc 2018-11-19 angiebird Fix scan_build warnings in dct_test.cc 2018-11-20 jianj Disable partition scaling on 1080p and above. (...) Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com BUG=b/119097707 Change-Id: I89c3b7dedfc7d6abc25fa2ded3c7754349f3e023 Reviewed-on: https://chromium-review.googlesource.com/c/1352974Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#611768}
-
Dave Tapuska authored
Some blink public interfaces used size_t then truncated on the calls internally to int. Use size_t throughout call graph. BUG=879657 Change-Id: I3c124524c2e969b65e662a30d0c8898d9d4e01a5 Reviewed-on: https://chromium-review.googlesource.com/c/1354061Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#611767}
-
Robert Sesek authored
This reduces some setup and layer plumbing because the WebSandboxSupport is now implemented on top of Mojo. Change-Id: Ib969ce301963151d6abb048aaa0319283b987b57 Reviewed-on: https://chromium-review.googlesource.com/c/1351727Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#611766}
-
Michael Ludwig authored
Bug: 908573 Change-Id: I3c971f449c1db305ae8aeb31d0678e949dc303e9 Reviewed-on: https://chromium-review.googlesource.com/c/1351741Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#611765}
-
Mario Sanchez Prada authored
Use identity::IsUsernameAllowedByPattern() instead so that we can migrate those consumers entirely to the IdentityManager in follow-up patches. Also, in order to make it explicit that this API should not be used any more, make SigninManager::IsAllowedUsername() a private method and friend it with the relevant test cases from SigninManagerTest, so that it can only be used from there. And while at it, also remove some stale lines "friending" SigninManager with test cases that no longer exist. Bug: 890794, 890815, 906085 Change-Id: I2a5be231ff70d3e390aa1718c795aef9d8b255ff Reviewed-on: https://chromium-review.googlesource.com/c/1353894Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Matthew Jones authored
This patch adds the infrastructure to allow the omnibox suggestion list to support custom view types. A view type is registered with the adapter and the mediator is responsible for specifying the type of view to be displayed. Bug:909779 Change-Id: I2e3e6905fbf7e44d991c536134511e311078d1db Reviewed-on: https://chromium-review.googlesource.com/c/1340947 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#611763}
-
Ben Pastene authored
R=dpranke CC=inferno, hans, thakis, metzman, mmoroz Bug: 893614 Change-Id: I24c0da4da030bf2139d29a8088526e450262cc8c Reviewed-on: https://chromium-review.googlesource.com/c/1351140Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#611762}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d437c79ed036..6616efbdebd2 git log d437c79ed036..6616efbdebd2 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 egdaniel@google.com In Vulkan, use 1000 for maxLod instead of maxMipLevel when using mips. 2018-11-28 borenet@google.com Use LUCI trybots in update_meta_config 2018-11-28 reed@google.com rm SK_SUPPORT_LEGACY_TEXTBLOBBUILD_WITH_PAINT from fluter 2018-11-28 reed@google.com rm SK_SUPPORT_LEGACY_NESTED_HINTINGENUM from flutter Created with: gclient setdep -r src/third_party/skia@6616efbdebd2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I0a97627da750bf829da129f425264f4a25ee5ac2 Reviewed-on: https://chromium-review.googlesource.com/c/1352803Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611761}
-
Ryo Hashimoto authored
The new ID will be used to identify the corresponding client-side controller object (e.g. Android Window). BUG=b:118842548 TEST=exo_unittests Change-Id: Ifedfa236db19b57ea00947fce339f84d397bf57f Reviewed-on: https://chromium-review.googlesource.com/c/1335079 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#611760}
-
Hector Carmona authored
Bug: 894499 Change-Id: I698b51eac47cdb7af63e4bb2ace338f87c5e7493 Reviewed-on: https://chromium-review.googlesource.com/c/1351779Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#611759}
-
Hiroshige Hayashizaki authored
Bug: None Change-Id: I10debc9f1636250545b4bf9508d2df7ecf0e62e1 Reviewed-on: https://chromium-review.googlesource.com/c/956234Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#611758}
-
Xianda Sun authored
We previously use other hit test data providers whenever there is one created, regardless of whether we enable VizHitTestSurfaceLayer or not. This makes the flag no longer effective in some conditions as we can create a draw quad hit test data provider arbitrarily sometimes. It accounts for the async hit testing of approximately 1% of all hit testing requests when VizHitTestSurfaceLayer is enabled. This patch makes us use layer tree hit test data when the flag is enabled. Bug: 901882 Change-Id: I833b693368721b09e1d2922274d21170a24125d7 Reviewed-on: https://chromium-review.googlesource.com/c/1348949 Commit-Queue: Xianda Sun <sunxd@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611757}
-
Dan Elphick authored
Since BooleanValue cannot actually throw, the Maybe version of the function is now deprecated. Bug: v8:7279, v8:8238 Change-Id: I8ec2cf1a305fdcf79681a8b39db4728f205428c4 Reviewed-on: https://chromium-review.googlesource.com/c/1353938Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#611756}
-
sebsg authored
It should be shown only if: - The feature is enabled - The user is not syncing - The user has server cards - The user has not already opted-in - The user is in sync transport mode for Wallet The last point is checked implicitly by the fact the the user is not syncing and has some cards. Bug: 909026 Change-Id: Id0976ea98a2be295968f825f1269888b3d820f0d Reviewed-on: https://chromium-review.googlesource.com/c/1351944 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/heads/master@{#611755}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I43de3ccb29bcb978c0a426094e996638b352d8ea Reviewed-on: https://chromium-review.googlesource.com/c/1352762Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#611754}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: Ib283fca5ff7e09a4e24bde1f728e195ad365e6ce Reviewed-on: https://chromium-review.googlesource.com/c/1352761Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#611753}
-
Henrik Boström authored
The state tracker is already well-tested. What is new is reporting the existing states. This is done at Dispose()-time because we cannot generally speaking know when an RTCPeerConnection is done with the call setup. We cannot trust close() is called because not all apps call it, but even if they do this will not happen if the user closes the tab. Dispose() will happen even if the tab is closed even if close() was never called, though it only happens when the GC decides to clean things up (which may happen at a much later time, and which does not happen if all of Chrome is shut down). Making the reporting independent of any API calls is a good thing to do regardless since this should reduce the risk of additional sampling bias. There are two flavors of the enums: One that always reports, and one that only reports if the RTCPeerConnection belongs to a document that has ever performed getUserMedia(). This is a heuristic for "is this a media use case?" that does not depend on looking at the SDP. Because Dispose() most likely happens after the context/document is destroyed, the flag for if a document uses media is stored within the CallSetupStateTracker, and is updated along side other state changes. Bug: 906029 Change-Id: Icf6b983119ef52f3cf9901695968bc3236073cd5 Reviewed-on: https://chromium-review.googlesource.com/c/1352257Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#611752}
-
chrome://flagsLukasz Anforowicz authored
Bug: 901522 Change-Id: I6c0f672a3544641bc44b218773e4db9fb1fa64b2 Reviewed-on: https://chromium-review.googlesource.com/c/1340579 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#611751}
-
Robert Liao authored
This test now presents a consistent set of supported scale factors invariant of the running platform, avoiding any surprises in expectations. BUG=298406 Change-Id: Ibcfa08f42f4e97ce7cf6244fa2a50ccab309c1c9 Reviewed-on: https://chromium-review.googlesource.com/c/1351769Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#611750}
-
Vaclav Brozek authored
The autofill server may issue CREDIT_CARD_VERIFICATION_CODE hints for fields. These should be used by password manager to understand that a CVC field is not a password field. The old parser had this functionality (see IsPredictedTypeNotPasswordPrediction), although it generally did not have the data at the right time. This CL teaches also the new parser to understand that server hint. Bug: 899331 Change-Id: Iddff8c03014ca9cf26ace5d259e33a56eaec1d1d Reviewed-on: https://chromium-review.googlesource.com/c/1353939 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#611749}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I23c823f9391b84eb3cb97143bf0482dba64f9101 Reviewed-on: https://chromium-review.googlesource.com/c/1352424Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#611748}
-
Adithya Srinivasan authored
- Converts IPC messages in midi_messages.h to mojo interfaces (in midi_service.mojom) - Updates MidiHost and MidiMessageFilter to use mojo - Changes MidiMessageFilter to do all work on the main task runner - Renames MidiMessageFilter to MidiClientImpl Bug: 582328 Change-Id: I1a62af005dc31118aad0081c30b6fbd1f63068a3 Reviewed-on: https://chromium-review.googlesource.com/c/1238815 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Sergio Villar Senin authored
It was using the SigninManager API, but the only test using it was removed in crrev.com/c/1346400. Just removing the leftover includes. Bug: 903881 Change-Id: Idb35dbff7a1b4f1d48140f4d2a6955cc8788dc63 Reviewed-on: https://chromium-review.googlesource.com/c/1352423Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#611746}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5403e4fde106..fd13c06f14de git log 5403e4fde106..fd13c06f14de --date=short --no-merges --format='%ad %ae %s' 2018-11-28 fmayer@google.com Merge "profiling: Set startup system properties." Created with: gclient setdep -r src/third_party/perfetto@fd13c06f14de The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I2eed4aa06a24fd91d35193435ab2f402a69f282f Reviewed-on: https://chromium-review.googlesource.com/c/1352862Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0d86a6b9d74..da575ec6b7fc Created with: gclient setdep -r src-internal@da575ec6b7fc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I70670194c920cf5d90b8a4ffd29725e6cc41fe6a Reviewed-on: https://chromium-review.googlesource.com/c/1351300Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611744}
-
liberato@chromium.org authored
Makes TrainingDataStorage refcounted, and causes TrainingData to keep a reference to the underlying backing store. Change-Id: Id675a57571ff5a6137527f966959dc1953e88351 Reviewed-on: https://chromium-review.googlesource.com/c/1351568 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#611743}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9bbc291e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: If86fa53b0cc0380d4324eb108e98719873ee9f9b Reviewed-on: https://chromium-review.googlesource.com/c/1352988 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611742}
-
Ken Rockot authored
This reverts commit 965f2dd7. Reason for revert: Still broken, unfortunately: https://crbug.com/909760 Original change's description: > Reland "[ios] add credit card test for manual fallback" > > This is a reland of 30e1dd18 > > Adding feature flags to slimnav. > Revert bug: https://bugs.chromium.org/p/chromium/issues/detail?id=908970 > > Original change's description: > > [ios] add credit card test for manual fallback > > > > Also adds AutofillManualFallbackPhaseTwo to test bots. > > > > Bug: 845472 > > Change-Id: I6bd05781c09c24c0768e24acfe59efa7ce1da05d > > Reviewed-on: https://chromium-review.googlesource.com/c/1337347 > > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > > Commit-Queue: David Jean <djean@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#611171} > > TBR=rohitrao@chromium.org > > Bug: 845472,908970 > Change-Id: I2cc0cddf0be8cea447f45f69457afbe19c840f29 > Reviewed-on: https://chromium-review.googlesource.com/c/1352328 > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611679} TBR=rohitrao@chromium.org,bpastene@chromium.org,javierrobles@chromium.org,djean@chromium.org Change-Id: Ie4ab90910a6c9b63c0b15044663c2dab68637ae9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845472, 908970 Reviewed-on: https://chromium-review.googlesource.com/c/1352934Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#611741}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I044cd0590ade65e2a8620b0e9e4c463eb2d3c9ac Reviewed-on: https://chromium-review.googlesource.com/c/1353879Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#611740}
-
Elly Fong-Jones authored
Not using an IME here makes certain keyboard layouts very difficult to use. Bug: 895434 Change-Id: I76e6121ca6512c8804fdb4afd2bceba10160bef0 Reviewed-on: https://chromium-review.googlesource.com/c/1351151 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Robert Ogden authored
This is needed for ChromeDriver testing. See bug. Bug: 908491 Change-Id: Ifaf1505757badc0b9c39b2a98e48a733a26564d7 Reviewed-on: https://chromium-review.googlesource.com/c/1351097Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#611738}
-
edchin authored
Explicit property synthesis is no longer necessary. Change-Id: Ib70f7b876297a50368c2e8167d3eba809bb259e8 Reviewed-on: https://chromium-review.googlesource.com/c/1352983Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#611737}
-
Daniel Vogelheim authored
Bug: 739170 Change-Id: Iafeabd00f6dde0c1ecf055a5f9f006059e43c9f7 Reviewed-on: https://chromium-review.googlesource.com/c/1346449 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
-
Tom Anderson authored
On Trusty, the file is called libpulsecommon-4.0.so. On gLinux (debian testing), the file is libpulsecommon-12.2.so. This causes some log spam due to not being able to find the file. However, the library does get loaded indirectly by libpulse.so.0 (which is also in the list of libraries loaded by LoadAudioLibraries()): $ ldd libpulse.so.0 | grep libpulsecommon libpulsecommon-12.2.so => /usr/lib/x86_64-linux-gnu/pulseaudio/libpulsecommon-12.2.so So the solution is to simply remove libpulsecommon-11.1.so from the list. BUG=None R=miu,marinaciocea Change-Id: Idefca3b7f25b1875188ffd4f300f0f9ff9ec6c7d Reviewed-on: https://chromium-review.googlesource.com/c/1352815Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#611735}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cde48580e93d..d2ede8935345 git log cde48580e93d..d2ede8935345 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@d2ede8935345 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iff4a7b7c085a3fa1f4d0e8e80d92d0007395f800 Reviewed-on: https://chromium-review.googlesource.com/c/1351299Reviewed-by:
-
Ned Nguyen authored
They are: * contrib.oilpan.oilpan_gc_times_unittest.OilpanGCTimesTest.testForParsing * contrib.oilpan.oilpan_gc_times_unittest.OilpanGCTimesTest.testForParsingOldFormat NOTRY=true # Disabling CL only TBR=haraken@chromium.org, peria@chromium.org Bug: 909752 Change-Id: I87176fab5851ccc910fb5cc5dfede31880626423 Reviewed-on: https://chromium-review.googlesource.com/c/1354127 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#611733}
-
Lan Wei authored
In order to match with WebDriver Action API, we need to modify the command of ExecutePerformActions in ChromeDriver. I also add this new action API in chromederiver.py and some tests to test this new API. Because we have not added this Action API to CDP, I am using Input.dispatchMouseEvent right now for mouse events only. Bug: chromedriver:1897 Change-Id: I28cac07b58d570ab1a102ac7b13d3d06dac507d8 Reviewed-on: https://chromium-review.googlesource.com/c/1333831Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#611732}
-
