- 11 Dec, 2019 40 commits
-
-
Donn Denman authored
We've recently had all of our tests in this file fail on P+, so disabling them until we can figure out what's going wrong. BUG=1032760 Change-Id: Ibe6a3be3dcdfde61696f53513bfe2b98e42aba83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961077 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#723629}
-
Gyuyoung Kim authored
This CL cleans up unnecessary binding.h includes in //content. Bug: 955171 Change-Id: I20968eecb210e0f60d0ac0d89db28d6cbbbf92c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959194Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#723628}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/modules/picture_in_picture only when it meets the policy of removing Create(). Then, this CL makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below factory functions, - PictureInPictureControllerImpl::Create Bug: 939691 Change-Id: I9b0fb7af883c19bccb5fe5466186b5e560a02285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958267Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#723627}
-
Caroline Rising authored
This change increases the delay before a hover card will appear. Bug: 910739 Change-Id: I1bfc24b6ab56316fd3d05147e1c46fd6add5169d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961078Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#723626}
-
Shakti Sahu authored
We should show NTP entry point only when 1 - There are prefetch or content indexed articles available 2 - Show only once per session. If user dismissed in one tab, don't show it on another new tab when opened Bug: 1031796 Change-Id: I229fa4ecfa1b58ffcfe281af5c732f168268ed36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956162 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#723625}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ad994cd8941d..9d1cb79e7718 git log ad994cd8941d..9d1cb79e7718 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-12-10 mtklein@google.com test for c++17 w/ c++14 stdlib 2019-12-10 scroggo@google.com SkWebpCodec: enable a loop count of 1 2019-12-10 herb@google.com Move luminance calculation to GrTextBlob::Make() 2019-12-10 egdaniel@google.com Add GrSurfaceProxyView to the various draw atlas ops. Created with: gclient setdep -r src/third_party/skia@9d1cb79e7718 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: I604c656482a3d05775a674d4fd2da2d94890c8a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961001Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723624}
-
Ben Pastene authored
This reverts commit 008b7265. Reason for revert: causing ARC-related tast tests to fail eg https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-chrome/2 Original change's description: > Move Ash off Service Manager > > This removes all dependences on the Service Manager from within Ash and > clients of Ash. The "Ash Service" is deleted, and the few interfaces > which the browser bound through it are now bound through a handful of > public helper functions that route through Shell. > > The only service interfaces used from within Ash are from the > Device Service, and those are now acquired through ShellDelegate. > > Bug: 977637 > Change-Id: Ia117241f4adddd14303176af78075d0df6c5b563 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956160 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#723475} TBR=sky@chromium.org,rockot@google.com,tsepez@chromium.org Change-Id: I60bd3b9803f7017e44f2adc41b3304beee5fddd2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977637, 1032816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961271Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#723623}
-
Simon Que authored
CI: -GPU FYI Win Builder -GPU FYI Win Builder (dbg) -GPU FYI Win dEQP Builder -Win Builder -Win Builder (dbg) -Dawn Win10 x86 DEPS Builder -Dawn Win10 x86 Builder Try: -win-angle-rel-32 -gpu-fyi-try-win7-amd-rel-32 -gpu-fyi-try-win7-nvidia-rel-32 -gpu-fyi-try-win10-nvidia-rel-32 -gpu-fyi-try-win7-amd-dbg-32 -gpu-fyi-try-win7-amd-dqp-32 -win-angle-deqp-rel-32 -win_chromium_compile_rel_ng -win7-rel -win_chromium_compile_dbg_ng -win_chromium_dbg_ng -dawn-win10-x86-deps-rel Migration schedule: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413 Change-Id: Ib0356f986b1c09d5a2692b443c3aca2f06443be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924183Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#723622}
-
Chris Blume authored
Previously, we were creating temporary ColorSpaces just to see if the transfer ID would require color correction. This was rather roundabout. Now that a .GetTransferId() function is available in ColorSpace, use that to avoid the unnecessary temporaries. Change-Id: Ia1680b25da8d9ae83dd5555cb84a84b1692f90b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924703 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#723621}
-
Ben Pastene authored
And update references to them in public consoles. Bug: 1032272 Change-Id: Ie40e34dd6d9cc9d0025a5361bb62a3ae0b93b96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960578Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Kurt Horimoto authored
This is a minimum InfoBarDelegate subclass to use for tests. Bug: none Change-Id: Iee4ea0d819ac436ea64b471a166c6399df3cebbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959664 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#723619}
-
Fergus Dall authored
BUG=none TEST=none Change-Id: If7961a42629d2217b6ae2581247dce577eb0299f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957944Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#723618}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8ed7ae4c8e9b..353f3314bf40 git log 8ed7ae4c8e9b..353f3314bf40 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 bclayton@google.com Vulkan/Debug: Add Thread and EventListener 2019-12-10 bclayton@google.com Vulkan/Debug: Add Location 2019-12-10 bclayton@google.com Vulkan/Debug: Add File 2019-12-10 bclayton@google.com Vulkan/Debug: Add WeakMap 2019-12-10 bclayton@google.com Vulkan/Debug: Add Value and Variable 2019-12-10 bclayton@google.com Vulkan/Debug: Add Type 2019-12-10 bclayton@google.com CMakeLists: Fix logic of BUILD_CPPDAP 2019-12-10 swiftshader.regress@gmail.com Regres: Update test lists @ d00dfe49 2019-12-10 chrisforbes@google.com Advertise VK_PRESENT_MODE_MAILBOX_KHR 2019-12-10 bclayton@google.com Regres: Reduce scope of regres CI emails Created with: gclient setdep -r src/third_party/swiftshader@353f3314bf40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic749c891af536b0d874fff8c40f60dd380551a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960995Reviewed-by:
-
Kyle Horimoto authored
Change-Id: I8647329b15dcbc39eaafcd0c6916e352ba3e17ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959922 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#723616}
-
Collin Baker authored
Bug: 1032649 Change-Id: Ifc70677c15ad29dae8db64b98feb73bb6f901110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961069 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#723615}
-
Demetrios Papadopoulos authored
The rule disallows == in favor of ===, and != in favor of !==, which matches the Google JS styleguide (which Chromium's JS styleguide inherits from). The stricter comparison checks actually revealed a bug in service.js, which is also fixed in this CL. Bug: 720034 Change-Id: I2288fe1395c930bf6e541681b500c7ee66c80f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959788Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#723614}
-
tby authored
This CL adds the skeleton of the structured metrics system within /components/metrics/structured. It's very similar to the set up of the AppListLaunchRecorder, and contains three parts: - EventBase. Represents a single logging event, and will be subclassed by generated code for each event added to the file of metrics definitions. - StructuredMetricsProvider. This is owned by the metrics service and will collect, hash, and report metrics. It observes the Recorder for events. - Recorder. This is a glue singleton that allows EventBase objects to communicate with the StructuredMetricsProvider. It also provides a mechanism for the ChromeMetricsServiceClient to inform the provider when a profile is added (ie. a user logs in), which triggers initialization. This CL instantiates the new metrics provider and adds it to the metrics service client, so the code is running on the waterfall and any issues are caught early. However ProvideCurrentSessionData will be empty until the final CL, which I'll send to the metrics team. If you'd prefer to do a full review before the provider is instantiated, just let me know. Unit tests checking initialization logic and that the notification route from recorder to provider works correctly will come in a follow- up CL. Bug: 1016655 Change-Id: I632bd47d712c10201b2d322f3ac0a0e918334738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918781Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#723613}
-
sczs authored
Change-Id: I0d32f0f7df8e09cb7abe9a2dcd3266eadf85c434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959325 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#723612}
-
Jack Lynch authored
The changes to UI.ListControl in [1] break a web test, so this CL exists to fix and re-enable it once the product changes merge. [1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880309 Bug: 963183 Change-Id: Ifd52271fdd1d43f45e4635ba3ac88a3cdb80fe07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690089Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#723611}
-
Bo Liu authored
When using virtual context, there is no code that checks the underlying context is not lost before reusing it again for the next virtual context creation. Add code to check this and create a new underlying context if the existing one is already lost. Bug: 1032189 Change-Id: Ie58f9844c08826960bf8abc12511e792530178ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960465Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#723610}
-
Raymond Toy authored
AudioContext.suspend() would call StopRendering(). This stops the audio thread from pulling the graph (eventually) but it also clears out any handlers, including those associated with automatic pull nodes for any AnalyserNode that isn't connected to the destination. When the context is resumed, the AnalyserNode isn't pulled anymore, so the output never changes. Add a SuspendRendering() method to handle AudioContext.suspend() which doesn't clear the handlers. Then when the context is resumed, AnalyserNodes will get pulled again. Then StopRendering() is used only for AudioContext.close() where it is ok to clear out the handlers since we can't resume a closed context. Bug: 1018499 Change-Id: I4b4ccf688b37e6b81d310d2596cfff9603048876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903894Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#723609}
-
Shakti Sahu authored
This CL addresses the surface view transparent issue after screen off/on. This is one of the approaches to fix this. When screen is turned off, in versions >=P, we recreate the compositor surface. Also in Q, we use surface control, and use a Translucent surface. For translucent surfaces, we use zOrderMediaOverly. This CL fixes this issue by not setting zOrderMediaOverlay for the main compositor view when surface control is enabled. Another alternative is to recreate the ThinWebView surface after screen off/on, and order both of them correctly so that TWV surface is created after the main compositor. This CL follows the former approach. This CL also reverts back the setZOrderOnTop added recently in CL https://chromium-review.googlesource.com/c/chromium/src/+/1939892 Bug: 1024622 Change-Id: I889a98aa18943bfbcd45797c031196640a822b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954452 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#723608}
-
Stefan Zager authored
When generating hit test data to send to the viz process, the renderer will mark any iframe that has other cc::Layers overlapping it as "inconclusive" for hit testing, which means that the browser process will have to send the hit test to the renderer process to get a final result. However, just because a cc::Layer overlaps an iframe does not necessarily mean that there is painted content overlapping the iframe. With this patch, the renderer will perform a hit test to determine whether any web content overlaps an iframe; and if not, then it avoids setting the "inconclusive" flag for hit tests targeting the iframe. BUG=1014273 Change-Id: I4812894972cfd33be52c484628005ac60fe65440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956385 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#723607}
-
David Roger authored
Change-Id: Iaa59fca40749663e5edce9c522dbb26c0b43cba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955558Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#723606}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7f9e1a2dc019..6865d13248b3 git log 7f9e1a2dc019..6865d13248b3 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 agable@chromium.org Update git-drover to use branch CQ 2019-12-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-12-10 iannucci@chromium.org Roll python 2 and 3 to versions matching the fleet. Created with: gclient setdep -r src/third_party/depot_tools@6865d13248b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I0ec868c0fafe146b21b6adf7b9009b74c3895408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960996Reviewed-by:
-
Michael Liao authored
DevTools [Security - Test Fixes]: temporarily disabling security tests to check in devtools security button fix change Disabling tests to check in this CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1871825 Re-enabling and fixing tests in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1819626 Bug: 963183 Change-Id: I23b26eda450869c0f027aef87c61d474f06fcac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894401 Commit-Queue: Michael Liao <michael.liao@microsoft.com> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ieae0c7479371562772846d47b4058b0666c0a562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960998Reviewed-by:
-
Collin Baker authored
Bug: 1032649 Change-Id: Iceeac8d83d0da258cac9ea18474be36f564050cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961075Reviewed-by:
-
Balazs Engedy authored
Adds metrics that track: -- whether the "Quiet UI" setting is enabled/disabled, -- when the "Quiet UI" setting is changed to enabled/disabled, -- the result of the adaptive activation logic, Ensure also that the AdaptiveQuietNotificationPermissionUiEnabler is initialized with the profile, to ensure it can keep track of the setting state at startup and as it changes. Bug: 1031477 Change-Id: Ib9776c98cb20951be8834b76706b8fcd902ec792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953713 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#723601}
-
Clark DuVall authored
For monochrome bundles, we attempt to share chrome resources. Unfortunately for us, official builds have an additional optimization which de-duplicates chrome and webview resources, removing webview resources from the chrome paks. Previously, we were not loading the webview paks, since during local testing I was not using an official build. This patch loads both webview and chrome paks, to make sure we have access to all resources. This was causing a crash in the safe browsing interstitial page, since it uses resources shared with webview. Bug: 1032644 Change-Id: I84d3044917d15bd5c5955c42c1a00082748e2f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960719Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#723600}
-
Clark DuVall authored
These requests were using a request ID of 0, which causes problems for some webRequest features, since webRequest uses the request ID to map requests back to the webRequest ID. Bug: 1029944 Change-Id: I667ab49cffe431c5d13e03f77caa2a537f9431b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957832 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#723599}
-
Yu Shan authored
StringFromMemBuffer would panic when input buffer is 0 length. This bug could be triggered by sending empty data on cast app control port. cause crash. Test: Manual test, passing an empty data on control port would not Bug: b/145944837 Change-Id: I6bb2f14844ec12b28c6ecceea0f680d93e095b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959104Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Yu Shan <shanyu@google.com> Auto-Submit: Yu Shan <shanyu@google.com> Cr-Commit-Position: refs/heads/master@{#723598}
-
Alex Danilo authored
Test for CL:1943777 behavior. The background page for FilesApp stores state for file operations in progress, as well as error states. This information is propagated to all the Files App foreground windows during their lifetime, and also propagated to any newly created foreground windows. The background progress center has 2 callback functions for changing state - one for cancel of an operation in progress, the other for dismissal of an error state. This test triggers an error state, simulates a click on the 'dismiss' button on the error panel that is displayed in the foreground window. It then closes the foreground window and opens a new one to check the error panel is not displayed. Detection of the lack of an error panel is done by triggering a copy operation that never ends and checking for that panel. If the error had persisted, it would be present when the copy panel appeared. Bug: 990919 Tests: browser_tests --gtest_filter="*transferDismissedErrorIsRemembered" Change-Id: I38789d4e621801c8a03c9e7f606d841830332b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950372 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#723597}
-
Thomas Guilbert authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/68b4dfdbd607..252792a1ff65 $ git log 68b4dfdbd..252792a1f --date=short --no-merges --format='%ad %ae %s' 2019-12-09 tguilbert Fix null pointer addition error 2019-12-06 tguilbert Fix null pointer arithmetic Created with: roll-dep src/third_party/ffmpeg Bug: 1031252 Change-Id: I63615b0744a5fac96358dccc6ba16bf62c6dedf4 TBR: tmathmeyer Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960892Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#723596}
-
Jiawei Shao authored
This patch updates RequestDevice() into an asynchronous function RequestDeviceAsync() and moves the creation of GPUDevice into the callback function passed as a parameter of RequestDeviceAsync(). BUG=chromium:996713 Change-Id: I7208a107670ca6e79ad3a4a3107f35ae26330edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955171 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#723595}
-
Joel Hockey authored
Migration first implemented in M77, so safe to now remove in M81. Bug: 946273 Change-Id: I7944f601b6193c983fec66a3859ca079f4b8a5a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958269Reviewed-by:
Jason Lin <lxj@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#723594}
-
Tricia Crichton authored
Some websites alter basic javascript objects (Promise, Array, Symbol) in ways that break ChromeDriver. This cl saves the original javascript objects, and then uses those when making javascript calls. Unittests were reconfigured to support the 2 SendCommand calls needed in ConnectIfNecessary. Bug: chromedriver:3237 Change-Id: Id7375ec78d661c5400f44db4e2e0d4e443cbd8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947385 Commit-Queue: Tricia Crichton <triciac@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#723593}
-
nancy authored
When the app_id is empty from web contents, the tab could be an webpage without app_id, so set the app_id as Chrome app_id, and set the correct InstanceState for Chrome: 1. When the tab is active, it should be started, running and visible. 2. When the tab or an app is inactive, it should be started, running. This CL also fix a crash bug which is caused by AppWindowBase smart pointer. Update AppServiceAppWindowLauncherController and browser_status_monitor init order, so when browser status is updated, AppService app window can be updated with the function OnInstanceUpdate. BUG=1011235 Change-Id: Ie5146d44517f844d9bced6812b4c4c6e83930845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959191 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#723592}
-
Steven Bennetts authored
Bug: 1032339 Change-Id: Iae5891afdb72391b0ba5844dac48867dc045eae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960069Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#723591}
-
zxliang authored
Renaming mask as remove_data_mask. Bug: b/144316586 Test: CQ Change-Id: I49f490e11bee9e837ec24ff611142cee1b334e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961167Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Zhaoxin Liang <zxliang@google.com> Cr-Commit-Position: refs/heads/master@{#723590}
-
