- 15 Oct, 2019 29 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2b47014e. With Chromium commits locally applied on WPT: 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." 0583f458 "Fetch Metadata: split up `document` destination." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I99cb790d016d082b82bd807f95ef5cf6bd4c38a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860777Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705782}
-
Eric Karl authored
Fixes two small issues: - Padding of visible layer region did not consider page scale. - New layers may jitter as we won't de-jelly them for 1 frame. We now use a reasonable default. Bug: 995965 Change-Id: Ib2ad58eab9b393b691e586e8649672c1d4323864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861096Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#705781}
-
Will Harris authored
On 64-bit the OOM termination might not always be from the sandbox termination (SBOX_FATAL_MEMORY_EXCEEDED) but might be one of the allocators choosing to OOM. Change the test on 64-bit to handle both exit codes. BUG=916162 Change-Id: I0d70460e6c49e34df90c7dd37e9f362a9472d3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860977 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#705780}
-
Daniel Libby authored
We're planning on running an experiment to turn off this codepath. It's unclear how to implement for CAP and could result in GPU memory savings. Spot checked Google Maps mobile site, and it no longer triggers this particular behavior. Bug: 875110 Change-Id: Ie2bb7e03585a87ac07843e08177992a0f3b9c81b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852192Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705779}
-
Lei Zhang authored
The PointerLockRequestUnadjustedMovement test case is flaky. TBR=eirage@chromium.org Bug: 1014324 Change-Id: Ib2793d5a76f3d45e7f26df689e938d7d41b5f5b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861015 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705778}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I707c292f12870ecdf16d2f2b6d9bdb9393796cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860893 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#705777}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2f960fbb7d1a..e18484723e86 Created with: gclient setdep -r src-internal@e18484723e86 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1011937),chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I978bac4a2fd34415738ef48051c8bde2ba0d54ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860399Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705776}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic656af0a10621ce997c5160984ec948dfa78f376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860892Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705775}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/624e60f81111..407cb5ca3318 git log 624e60f81111..407cb5ca3318 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 fmayer@google.com Merge "Add java hprof CTS." 2019-10-14 treehugger-gerrit@google.com Merge "Properly set field_name in heap_graph_reference." Created with: gclient setdep -r src/third_party/perfetto@407cb5ca3318 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I24db99751b01db453670b2028368687025e64612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860983Reviewed-by:
-
Robert Liao authored
BUG=1014283 Change-Id: I819a1aa7bbc8dd29422cb5768571ff4735f79904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859583 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#705773}
-
Lei Zhang authored
The F4ClosesMenuWhileSelectingHighlightedMenuItem, MenuCanAdaptToContentChange, and UpOrDownKeysMoveInMenu test cases are all failing multiple times a day. TBR=ellyjones@chromium.org Bug: 965601 Change-Id: If2ea292580257ebcdfebef33bbb368aa45911f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860505Reviewed-by:
-
chrome://safe-browsingXinghui Lu authored
This is the follow up CL for crrev.com/c/1856804. Bug: 1013370 Change-Id: I1170f8875a509e8231761981bb65c6f54bd53fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856908 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#705771}
-
Luciano Pacheco authored
Remove z-index from list.css because it was causing unnecessary re-painting of breadcrumbs, toolbar buttons, and others. Bug: 992821 Change-Id: I31e021122d74c13978bd1c1bb4603b64f8611d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859421 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#705770}
-
Andrew Luo authored
Change-Id: Ida2ec475ad8a63f2d15705e306f65283b44624a7 Bug: 924194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853846Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#705769}
-
Ahmed Mehfooz authored
Always ensure the focused view is visible by switching pages when needed. Bug: 1013722 Change-Id: I27e561dabc43daea32167ff68d84ba710821d902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856852 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#705768}
-
Xiaoqian Dai authored
Changes in this CL: - Overview is hidden when the speed of window dragging is large enough and will be reshown when window dragging slows down or stops - Do not show drag-to-snap or cannot-snap splitview indicators during dragging - Use the same dim and blur as in overview during the entire dragging. When drag starts, overview will only be opened when the speed of window dragging decreases to a certain degree. To prevent the background dimming and blur from jumping-cut, we use the same dim and blur during the entire dragging process. Bug: 997885 Change-Id: I94386e9a9cced7daa4d7d0123f22b682b7a835aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857602 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#705767}
-
Garrett Beaty authored
Change-Id: I1bf5d09afb90bee903a147972db5f0b770e33f98 Bug: 1011908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837196Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#705766}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fb632b91110c..a27dfcf868bf git log fb632b91110c..a27dfcf868bf --date=short --no-merges --format='%ad %ae %s' 2019-10-14 digit@google.com Fix Linux build. 2019-10-14 digit@google.com [vulkan] Implement Linux-based external semaphore Created with: gclient setdep -r src/third_party/swiftshader@a27dfcf868bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:140419396,chromium:b/140421726 Change-Id: Icd4b752a0fab65d56a76ba387b49a9aaadf231b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860889Reviewed-by:
-
Shakti Sahu authored
This CL sets offline home title and tab texts. Bug: 1012619 Change-Id: Ic105869e5d26467ae552982cb84691beed0fdf52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849451 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#705764}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e16ffffc28f3..c6512213a7b7 git log e16ffffc28f3..c6512213a7b7 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 ehmaldonado@chromium.org depot_tools: Run recipe scripts using vpython. Created with: gclient setdep -r src/third_party/depot_tools@c6512213a7b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: I443f3cb3532c3ce6751540441d2bb806f5827e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860982Reviewed-by:
-
Robert Liao authored
BUG=1014283 Change-Id: I7c81dcbe039392b91ca8f8b7875b9b5bcad65d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859903 Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#705762}
-
Tim Song authored
BUG=1009622 Change-Id: Ib26a700b2889f101da40947f9f90f3058282540b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848363Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#705761}
-
Eric Karl authored
Adds Android-specific customization of de-jelly effect based on display properties. Bug: 995965 Change-Id: Ie48ddf1e3f61d601e05522cf1f7b99a3dc25f012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837115 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
minch authored
Do not go back and show the back gesture affordance while in overview mode, home screen or not in an ACTIVE session. Bug: 1002733 Change-Id: Id01ac4fe02fefd94423924ea4871428c29aee497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854792Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
Lei Zhang authored
TBR=emaxx@chromium.org Bug: 1014318 Change-Id: Ia50ec7454db51e18b287a48fa72a7777967259e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861107 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8cd95dd1d376..61d564ff3b00 git log 8cd95dd1d376..61d564ff3b00 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 bpastene@chromium.org chrome_committer: Send all CHROMEOS_LKGM updates to the current gardener via gwsq. Created with: gclient setdep -r src/third_party/chromite@61d564ff3b00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ie1f29b33d0c134f0bcdce984d7f707b4233c9a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860890Reviewed-by:
-
Shakti Sahu authored
This CL adds an offline message card on NTP when chrome is offline, tapping on which will open offline home. It also fixes the way NTP hides or unhides the views depending on search provider logo availability. Bug: 1012267, 1012397 Change-Id: I0fcfcc22b63c41e43bbd047529752ae48dba89e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847771 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Kristi Park authored
Bug: 851335 Change-Id: Ib73f8952c5e0e01f8a2f9523bfec65d5cf34b55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854418 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#705755}
-
Klaus Weidner authored
OnSessionEnded claimed to be safe to be run repeatedly, but it wasn't quite a no-op. Use VRDeviceBase's session tracking to be clearer about session lifetime, and only do teardown once. This is a speculative fix for DCHECK errors in the linked bug, though I haven't been able to specifically reproduce these. Bug: 1014159 Change-Id: I800f62bee87a1827d57999af12e721ba06fd3c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859832Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#705754}
-
- 14 Oct, 2019 11 commits
-
-
Avery Musbach authored
The present CL is a new version of: https://chromium-review.googlesource.com/c/chromium/src/+/1726272 Bug: 970013 Change-Id: Ie4960fb590b3ce096ac0cca8f4a6bcbf2d4c73be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857178Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#705753}
-
Austin Eng authored
In https://github.com/gpuweb/gpuweb/pull/429, we said that popErrorScope throws an exception instead of rejecting the Promise. However, according to http://heycam.github.io/webidl/#es-operations, it is illegal to throw an exception and not return a Promise from a Promise-returning function. Instead, we need to reject the Promise with an exception. Bug: 1013815 Change-Id: I0879ab13764a3c6d475a9f8d47c06034069ce328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857483Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#705752}
-
Shik Chen authored
We should prefer constant 30 fps over the default {min: 24} constraint for video recording. Bug: b:139118507 Test: Check FPS in CCA Expert Mode with lens covered in low resolution to isolate the performance issue. Test: Check the metadata control.aeTargetFpsRange is set to "30 30" with metadata inspector. Such as $ cros_camera_service \ --metadata_inspector_output=/dev/stdout \ --metadata_inspector_whitelist=fps Change-Id: Ib8115cdd371b767e1ea4bd0a3d9d21cee15d5126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859534Reviewed-by:Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#705751}
-
Mike Wasserman authored
The bubble was passing the desired icon color as |related_text_color|. Use a slightly different function that takes the icon color itself. Bug: 999761 Test: Button color appears as expected. Change-Id: Iff87e0f3950131695cbcfe179b4ef33732b55b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861034 Commit-Queue: Michael Wasserman <msw@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#705750}
-
Ahmed Mehfooz authored
Modify check for message center gaining activation to not dereference the message center widget. There's a crash caused by focus switching between the message center and quick setting bubbles before the message center bubble's constructor has exited. Change-Id: Ia15acb47dc3806466a2f40a73e843333655e7953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860692 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
-
Ahmed Mehfooz authored
When Alt+Shift+N is used to open the message center, the first notification will be focused with this change. This fix is only available when the "Enable Message Center Redesign" flag is enabled. Bug: 1009485 Change-Id: I3509725aa76ad10d2a711c7cd923af4adc6ba31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859647Reviewed-by:
-
Jesse Schettler authored
Replace PrintMsg_ClosePrintPreviewDialog and PrintMsg_PrintForSystemDialog IPC messages with new Mojo methods. Bug: 1008939 Test: Print a webpage and PDF Change-Id: I59dd3f50f01c04debe3cb0ebd51062bc6cf597be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829467Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#705747}
-
chrome://media-appTrent Apted authored
Note that --enable-features=MediaApp and the added test still work even when gn args has enable_cros_media_app = false, but the mock app is loaded in this case (i.e. js/app_main.js is an empty file). The manifest and html served are the same regardless of enable_cros_media_app. Bug: 996088 Change-Id: I4b81f622efc874afdc53794eede8d04b69e3e3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824523Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
-
Jeevan Shikaram authored
This CL adds null checks to shelf related pointers within the shelf delegate. This prevents null pointer errors when the App Management page handler is created when the shelf does not exist, e.g. on the lock screen. Bug: 1011756 Change-Id: I97d3bee4daeba9a97c89ba4a91c3f736857df964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858022 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#705745}
-
Rakib M. Hasan authored
Bug: chromium:1014196 Change-Id: If433f69918658cc8336bc4f48f156e5f6e8a7f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860975Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#705744}
-
Renjie Tang authored
The data is generated by QUIC transport and has no user information. Change-Id: I001bb30a69129cdb5195c36e1ba3abc39628fd89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838538Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#705743}
-
