- 18 Oct, 2017 40 commits
-
-
Darren Shen authored
Spec: https://drafts.css-houdini.org/css-typed-om-1/#keywordvalue-objects There are no failing tests. Bug: 774887 Change-Id: If78a3e490c406e8743eb591f1e9bdcb28f9fb3a5 Reviewed-on: https://chromium-review.googlesource.com/720582 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#509711}
-
Rakina Zata Amni authored
In some cases, relatedTarget kept its value after event dispatch has finished even though target is set to null. See test file for the cases. This change adds a check so that when target is set to null in the post-processing phase, the change is also reflected in relatedTarget. Bug: 771580 Change-Id: Idda5d00c1a793b2669be66e76439851d1f66459c Reviewed-on: https://chromium-review.googlesource.com/720897Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#509710}
-
Kinuko Yasuda authored
When S13nServiceWorker is enabled: Before this change, subresource requests initiated from client documents are: - intercepted by SWSubresourceLoader in the renderer process, - forwarded to BrowserSideControllerServiceWorker in the browser process, and - dispatched to ServiceWorkerContextClient in the SW's renderer process. After this change, subresource requests are: - intercepted by SWSubresourceLoader in the renderer process, - forwarded to ControllerServiceWorkerImpl in the SW's renderer process, and - dispatched to ServiceWorkerContextClient in the SW's renderer process. Same layout tests and browsertests should keep passing with this change on Linux Mojo bots. Bug: 715640 Change-Id: I1c2be11897df162f9c375049e9b3eb618b81d3e7 Reviewed-on: https://chromium-review.googlesource.com/713114 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#509709}
-
Bhagirathi Satpathy authored
This CL removes unused memory inclusion from Document. Bug: Change-Id: I14b5f687b901270301d456b924373355692bf07f Reviewed-on: https://chromium-review.googlesource.com/723239Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#509708}
-
Mikhail Pozdnyakov authored
As it follows from https://github.com/w3c/sensors/issues/313 Change-Id: Ic81e118b2a3c8db6d8b30ee61ef8811b88a0f970 Reviewed-on: https://chromium-review.googlesource.com/721742Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Dariusz Marcinkiewicz authored
BUG=b:67364190 Change-Id: I7cd3816955683342276b585132de5fc37ed936e5 Reviewed-on: https://chromium-review.googlesource.com/718748Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Dariusz Marcinkiewicz <darekm@chromium.org> Cr-Commit-Position: refs/heads/master@{#509706}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5546c921e0ca..1f7c31e27e26 $ git log 5546c921e..1f7c31e27 --date=short --no-merges --format='%ad %ae %s' 2017-10-18 angle-deps-roller Roll skia/third_party/externals/angle2/ c514348e2..0a6752e3c (1 commit) 2017-10-18 angle-deps-roller Roll skia/third_party/externals/angle2/ ebf7299e4..c514348e2 (1 commit) Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I10e32e98271f2ebd3fc482aaeaf8c4c5fe3a6ae6 Reviewed-on: https://chromium-review.googlesource.com/725219Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509705}
-
Raymes Khoury authored
This also changes the log level for these type of messages to WARNING since that seems more appropriate given their nature. Bug: 689802 Change-Id: I1ca15b71caa35ca941572d0fbca864855696bb6e Reviewed-on: https://chromium-review.googlesource.com/722659Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#509704}
-
Aleks Totic authored
This CL implements flag feature from results.html. I've used this feature to rework "Rebaseline" feature. Now it is just another format. Also, fixed a bug where hitting enter in text search would display results twice. With this, I think we've reached feature parity with results.html. Once it is in, I'll make another pitch to replace results.html with test-expectations. Bug: 726520 Change-Id: I811fead7940c7c1e44326ea03c3394ccf06a44bc Reviewed-on: https://chromium-review.googlesource.com/720172 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#509703}
-
Vlad Tsyrklevich authored
This reverts commits 3d8ae2fd and e3168df0. Reason for revert: e3168df0 broke the Linux CFI bot due to a misplaced blacklist entry and 3d8ae2fd was a follow-up change. Change-Id: I13f8db49d0621cb8e588ae26d261e362faa462a9 Reviewed-on: https://chromium-review.googlesource.com/724921Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#509702}
-
Hajime Hoshi authored
This CL is a preparation for the change that WebTaskRunnerImpl will always be created for each call of WebFrameSchedulerImpl:: *TaskRunner(). This CL replaces WebTaskRunner* with RefPtr<WebTaskRunner>. This is part of the big CL for changing WebFrameSchedulerImpl:: *TaskRunner() to create WebTaskRunnerImpl anytime: https://chromium-review.googlesource.com/c/chromium/src/+/704459 Bug: 762453 Change-Id: Iad2b4ae62bbc73d5c20a90c79c2a1fc947bbd3cc Reviewed-on: https://chromium-review.googlesource.com/722861 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#509701}
-
Henrik Grunell authored
Bug: None Change-Id: Iaa2da4e58fe8605cbccbd8d204eafe0689de2387 Reviewed-on: https://chromium-review.googlesource.com/721039Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#509700}
-
Giovanni Ortuño Urquidi authored
This way we are sure we are not unintentionally changing the behavior for hosted apps. Also changes tests to use a LINK page transition which more closely matches what happens when a user clicks a link. Passing NavigateParams as an argument to NavigateToURL causes it to not block so this patch also adds code to wait for the url to load. Change-Id: I20c57ba8727535a8cc7768fc1fb80847f9d0977a Reviewed-on: https://chromium-review.googlesource.com/720724 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#509699}
-
Eddy Mead authored
This allows us to remove some duplicate code, and prepares the way for generating ComputedStyle's Initial* functions elsewhere. This ended up reducing the number of includes in each APO subclass header. Gist diff: https://gist.github.com/wilddamon/5bfa127e71e9c7993104bbfa602b3f97/revisions Bug: 763306 Change-Id: Icaacee6abe218b73a460311eb1ffcbff5c81d4c5 Reviewed-on: https://chromium-review.googlesource.com/716442 Commit-Queue: meade_UTC10 <meade@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#509698}
-
Hidehiko Abe authored
Before this CL, the state machine may enter STARTING_INSTANCE twice (for a mini instance starting, and upgrade), and as a result and because of that OnInstanceStarted() needed an extra parameter. With this CL, the state machine enters each state up to once, which simplifies the callback functions. BUG=None TEST=Ran trybot. Change-Id: Ie92abbfd92fbae53c47bba1ed34fd3c71a60f46f Reviewed-on: https://chromium-review.googlesource.com/723679 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#509697}
-
Chris Watkins authored
The docs previously claimed that you don't need to add a Trace() method to an on-heap class if it does not contain on-heap members. However, this is no longer true. Change-Id: I4a8faf9805f940735af4fb722265fe0d7bf0edda Reviewed-on: https://chromium-review.googlesource.com/725100Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1e66d75f. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/3387 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/IndexedDB TBR=qyearsley@chromium.org No-Export: true Change-Id: I0774a1cef1818f3b0bdfe54999640f418ada537b Reviewed-on: https://chromium-review.googlesource.com/724899 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509695}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/d71c6d1994f6..5546c921e0ca $ git log d71c6d199..5546c921e --date=short --no-merges --format='%ad %ae %s' 2017-10-18 angle-deps-roller Roll skia/third_party/externals/angle2/ b9cb7f60d..ebf7299e4 (1 commit) 2017-10-17 angle-deps-roller Roll skia/third_party/externals/angle2/ 8a9e0fc23..b9cb7f60d (1 commit) 2017-10-17 benjaminwagner Synchronize public.bzl float-cast-overflow omit list with test.py. Created with: roll-dep src/third_party/skia BUG=774309 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I4f4ad7cf3865ab75b485e46ce77942a42f261637 Reviewed-on: https://chromium-review.googlesource.com/724960Reviewed-by:
-
Jay Civelli authored
When using zip::Zip() with an IPC based FileAccessor, zipping directories with large number of files triggers many IPC calls making the entire operation significantly slower than with direct file access. In order to alleviate this performance hit, this patch groups file reads by modifying the FileAccessor read method so it reads multiple files at once. zip::Zip() can then group these reads when writing the ZIP file. The writing code has been factored out into a new ZipWriter class to make that code more readable. Bug: 773310 Change-Id: I8121980bf05d87a174c63164840ec6bf325c7e52 Reviewed-on: https://chromium-review.googlesource.com/719356 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509693}
-
Renee Wright authored
- Slightly re-arranged the order of the members in the "parameters" object. - Re-arranges members in the data objects to match the order in which they appear in "parameters" - Deleted a useless comments (-1 LOC) - Added a comment advising we stick to this ordering (+2 LOC) I've checked the gen diff to verify that there is no change in output. It would be nice to add a script to enforce this ordering if it's not too hard. Bug: Change-Id: I9f8b1248c6fd48f0f0e77769558b2770848b8b65 Reviewed-on: https://chromium-review.googlesource.com/714799 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#509692}
-
Alice Boxhall authored
Bug: 390254 Change-Id: I3fc5b0ac80fe861c04b0bbe72ec93438bbf25145 Reviewed-on: https://chromium-review.googlesource.com/698844 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509691}
-
Changwan Ryu authored
Currently, we are testing whether certain callbacks are called / not called in specific situations. This type of one-off tests are easily isolatable, but it has its own limits - it is difficult to detect newly added callbacks. The new scheme audits all the calls into AutofillManager and ensures that WebView autofill functionalities can work as expected. Also, this CL refactors out some variables from TestAwAutofillManager (renamed from AwAutofillManagerHelper) into AwAutofillTest and make the test manager a thin wrapper. Note: All the tests were run locally, as there is no trybot for O. BUG=717658 Change-Id: Idacea03727f5f1cd56cd62dc1420dc74f48b04cf Reviewed-on: https://chromium-review.googlesource.com/706379Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Yoland Yan <yolandyan@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#509690}
-
Tetsui Ohkubo authored
In new-style notification, system notification has different style from other notifications such as web notifications. This CL fixes sync error notification: * The context header shows the title "Sign In". * The context header has an accent color. * "Update sync passphrase" button is removed. * New MD icon is used. If chrome://flags#enable-message-center-new-style-notification is disabled, this CL has no effect. Before: http://screen/kTTXQujdxao After: http://screen/WoRuaLE732T TEST=manually tested on chell device BUG=775381 Change-Id: I8c030131a5a9241223b6b02601fabe4035e9b866 Reviewed-on: https://chromium-review.googlesource.com/722545 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#509689}
-
Tetsui Ohkubo authored
As a part of message center restyling, this CL adds a new view for message center when there are no notifier sources. Previously, there was no such view and the layout was broken when there were no notifier sources. TEST=ash_unittests BUG=726246 Change-Id: I51c6b6b074995003c622e4bd4e1de19d2db5f56b Reviewed-on: https://chromium-review.googlesource.com/708106 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#509688}
-
Koji Ishii authored
Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I2f6d01a6351b07d8bc93ad016858f49f549cf89c Reviewed-on: https://chromium-review.googlesource.com/722383 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#509687}
-
khmel authored
This fixes regression when ARC deferred launch controller does not have a menu and user cannot closes launch request and pin/unpin item. Test: Manually on device. Unit test added Bug: 775744 Change-Id: I85d902a77a251d2958f9cd2a42dd7c10a393d6c0 Reviewed-on: https://chromium-review.googlesource.com/724460 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#509686}
-
Tetsui Ohkubo authored
Previously, message center was closed only when WebNotificationTray::ClickedOutsideBubble() was called. As a result, when a user opens the launcher by Search key, message center bubble remained open. This CL also closes the bubble when another window is activated. The implementation is based on SystemTray::ActivationObserver. TEST=WebNotificationTrayTest.CloseOnActivation BUG=757979 Change-Id: Ifea4c2cc56cfe4ca7b0ecfc065426cc30eccc512 Reviewed-on: https://chromium-review.googlesource.com/716441Reviewed-by:
-
Nathan Bruer authored
This patch adds the ability to intercept requests and rewrite them with content that as changed in the devtools session. see: https://user-images.githubusercontent.com/1831202/31698204-2668249e-b371-11e7-814f-4253aa61ed7d.png see: https://user-images.githubusercontent.com/1831202/31698205-26818cea-b371-11e7-804a-68a172537644.png R=lushnikov,pfeldman,einbinder BUG=760316 Change-Id: I9ab2fc3aeca22cf49bc20f2be569c543f9fa4ab8 Reviewed-on: https://chromium-review.googlesource.com/720160 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#509684}
-
Sammie Quon authored
Fixed in this cl: 1) Snap two windows, and then tap the divider but do not drag. Divider shifts. 2) Drag divider to one third, then to two thirds. Left window in first scenario is larger than right window in second scenario. 3) Replace some instances of CreateTestWindowWithBounds with CreateTestWindow. Test: manual, ash_unittests SplitViewControllerTest.* Bug: 766845 Change-Id: I37ae535bd1aa881898b723359cfbdb1f3b77d845 Reviewed-on: https://chromium-review.googlesource.com/673905 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#509683}
-
Ryan Hamilton authored
Change-Id: I8f5a6e787a1888b81f1a265cda788a034267b885 Reviewed-on: https://chromium-review.googlesource.com/724961Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#509682}
-
Eric Willigers authored
Wait for compositor before capturing output. Examples of recent flakes: https: //test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests%20(with%20patch)&tests=virtual%2Fthreaded%2Fanimations%2Fcomposited-pseudo-element-animation.html Change-Id: I909315617a70a4845d29b9134d50e5efc4b51a47 Reviewed-on: https://chromium-review.googlesource.com/706734 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#509681}
-
Yoshifumi Inoue authored
This patch adds test cases for comment syntax of |SelectionSample::SetSelectionText()| and adding a comment for comment syntax of selection marker. Example: Selection text: <span><!--^-->foo<!--|--></span> Result Selection: base=SPAN@0 extent=SPAN1 Change-Id: If45fe964a906843a3490a4ee12e940c18a7608e4 Reviewed-on: https://chromium-review.googlesource.com/722464Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#509680}
-
Hans Wennborg authored
This reverts commit 6489c3bf. Reason for revert: Clang has rolled past r315330 (in #508804), so the work-around is not necessary anymore. Original change's description: > Work around clang-cl bug to fix media_unittests link failure > > TBR=wolenetz > > Bug: 771710 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Id2de82dfda1fc003ed3a8095ad000e7a21f3feb9 > Reviewed-on: https://chromium-review.googlesource.com/701456 > Commit-Queue: Hans Wennborg <hans@chromium.org> > Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506554} TBR=thakis@chromium.org,wolenetz@chromium.org,hans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 771710 Change-Id: I6916002fd569007a006ccf25285ee1dcf33159d7 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/724339Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#509679}
-
Michael McGreevy authored
Bug: 770016 Change-Id: I3375293694ca5e124ae3a37224a150f495d76179 Reviewed-on: https://chromium-review.googlesource.com/718059 Commit-Queue: Michael McGreevy <mcgreevy@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#509678}
-
Siddhartha authored
The block cache is shared across multiple databases. So, calculate the correct sizes of each leveldb database for the memory dumps. Bug: 758267 Change-Id: I4ca76422754c0a7fce46354f79631362d5553cdc Reviewed-on: https://chromium-review.googlesource.com/667916 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Michael Nordman <michaeln@chromium.org> Reviewed-by:
Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#509677}
-
Weidong Guo authored
Changes: Combine AccessibilityController::RequresCursorCompositing() with NightLightController::GetEnabled() and move the function to CursorWindowController. BUG=772457 Change-Id: I8b662c0a68aff6bdd0d69852f5516b4b9f564d3f Reviewed-on: https://chromium-review.googlesource.com/706058 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#509676}
-
Stephen McGruer authored
blink::AnimatableValueKeyframe is no longer used outside of tests. This CL converts the remaining tests that use it to use StringKeyframe instead and deletes AnimatableValueKeyframe. Using a StringKeyframe rather than an AnimatableValueKeyframe does cause some code churn, most notably: * The underlying interpolation becomes an InvalidatableInterpolation rather than a LegacyStyleInterpolation. This requires us to 'play nice' in certain places to make sure the interpolation result has been cached. * AnimatableValueKeyframe does no CSS 'type checking', which allowed the tests to abuse types (ignoring units, using invalid values for the property, or using AnimatableUnknown with interpolable CSS properties to make them noninterpolable). StringKeyframe does do CSS type checking, so all that code had to be fixed. Bug: None Change-Id: Ief3772390aaa72135fff23ccdfb85bc622bdb5cd Reviewed-on: https://chromium-review.googlesource.com/717574Reviewed-by:Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#509675}
-
Eric Roman authored
(Wired up TestRootCerts). Bug: 649017 Change-Id: I30e22e12a963d0fc398f679dcf79aa7f896557a0 Reviewed-on: https://chromium-review.googlesource.com/720596 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#509674}
-
Andrey Kosyakov authored
we were waiting for undefined instead of a promise. Bug: 775756 Change-Id: I2fcddae0df9aaab48aa803787b46e87aa72ed61e Reviewed-on: https://chromium-review.googlesource.com/724427Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#509673}
-
Tetsui Ohkubo authored
According to new message center mock (go/cros-md-notificaiton-mock), - Notifications in message center no longer have shadows. Instead of that, they have rounded corner border. - The padding between notification: 10dp -> 8dp - Background color of is changed. In the mock, blur background like app launcher is specified, but it's still not implemented in this CL. Before: http://screen/m7HbFpaHWUu After: http://screen/mwr5kPmv7p3 TEST=ash_unittests BUG=726246 Change-Id: Ie3ec6c66a6b7b360f2112eaefad71915e74d3f11 Reviewed-on: https://chromium-review.googlesource.com/722303 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#509672}
-
