- 06 Aug, 2020 40 commits
-
-
Alison Maher authored
If an OOF positioned element starts layout in a non-existing fragmentainer or fragments into a non-existing fragmentainer, new fragmentainers must be added to hold these OOF fragments. This change makes the necessary updates to handle the above cases. Bug: 1079031 Change-Id: I643c1cbc8c30220d07ef9d0fbd843269eb1583c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335643 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#795505}
-
Tanmoy Mollik authored
Move code related to creation of Sync Promo inside SigninPromoUtil. Also update the badge inside ProfileDataCache instead of creating new instance inside BookmarkPromoHeader. Bug: 1095628 Change-Id: I5973c1db3feda7665823ff545aebc9f3b09bca72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264112Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#795504}
-
Mason Freed authored
Bug: 1104846 Change-Id: Ia91bb271ecb11dc4af55eb284fce8eae9f130e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340385Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#795503}
-
Alexei Svitkine authored
The allowlist provides a way to specify which external experiment ids can be sent and also provides a way to associate a study name for such external experiment ids. Since the API now uses an allowlist, its use is no longer restricted via metrics service accessor, which allows us to simplify the plumbing. A metrics client API is provided to disable the allowlist, which is needed for some configurations such as WebLayer. Additionally, the new allowlist support is implemented behind a base::Feature, which is off by default in this CL. When the feature is disabled, the behavior from before is unchanged. Bug: 1111941 Change-Id: I63b92254e27a32dd5236c37f0b70fb3683f447e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324172 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#795502}
-
James Long authored
Package names are now shortened like they are in the SVG. Class names (for example, "packageName.className") are shortened as "className (shortenedPackageName)". The filter input's dropdown is now sorted by these shortened names instead of the original ones. Bug: 1102546 Change-Id: I71f5c6b6c51e9c1d1c597fc36899879895d65e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337318 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#795501}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de2a1c51379f..4b2d9bf02a88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ftirelo@google.com,fernandex@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ftirelo@google.com,fernandex@google.com Change-Id: Ib22d513be6082df9714a524818a2ebe4e2845dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341115Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795500}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f123f22cb971..889f00501aaa 2020-08-06 zwisler@google.com chromeos-config: remove reference to security_SMMLocked 2020-08-06 linxinan@chromium.org api: update suite scheduler proto's python binding 2020-08-06 vapier@chromium.org licensing: fix license searching for the SDK 2020-08-06 briannorris@chromium.org paygen_stateful_payload_lib: de-duplicate hard links 2020-08-05 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I59abcb21ec0e17ba18c284248fbe268657438f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341120Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795499}
-
Theresa Wellington authored
Add additional debug logging while loading / merging tab state, to be (mostly) removed after bug resolution. Also adds two new IllegalStateException's for completely unexpected states. BUG=1111594 Change-Id: I2c900eb47889659e593de5f8186e3e82c2bbd0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340296 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#795498}
-
Andrey Zaytsev authored
UI deck: https://docs.google.com/presentation/d/13qExIGI7BDaSUGBAXR0B02VzKcIqVt5Y_vo0lC7nC04/edit?ts=5ef0c30f#slide=id.g8a1bab3ac0_6_25 Bug: 1070620 Change-Id: Ie8a660e5cb29c40009320e71b4347c4e7b95b9b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339134 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#795497}
-
Side Yilmaz authored
Currently opening downloaded articles and most visited website does not work, since OfflinePageUtils returns null for given off-the-record profile. This CL fix the bug by passing always regular profile to OfflinePageUtil. It is safe, since offline page download is only available for regular mode. Bug: 1093758 Change-Id: Id542113e2d5676541766fbd2a2770e954c0b24a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299233Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#795496}
-
Juanmi Huertas authored
Replacing use_hardware_decode_cache method name with proper format, to become UseHardwareDecodeCache. Bug: 1021287 Change-Id: I8313f2a90753b1b6ac327c4ffe68f4d3a896c7c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292204Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#795495}
-
Pete Williamson authored
IPH triggering was relying on the onScrollStateChanged() method, but feed V2 was not passing along onScrollStateChanged. This change routes the message to listeners. Bug: 1113468 Change-Id: I087915022087928c33135e5a71e712f3964a1d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340366Reviewed-by:
Vincent Boisselle <vincb@google.com> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#795494}
-
Ben Mason authored
This reverts commit c71f4c7c. Reason for revert: Missing screenshots crbug.com/1113762 Original change's description: > extensions: change to singular term in context menu > > when clicking the "Manage extensions" button in the context menu, > we go to the chrome://extensions page for that extension instead > of all the extensions. > > Bug: 986890 > Change-Id: I1e17b4ad0ffebc5c38591cc3fae2953efd8aa0fe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233303 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795279} TBR=rdevlin.cronin@chromium.org,andreas@apap04.com Change-Id: I0b23e078b3ab543c78c867c118058d955f13ef2f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340669Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#795493}
-
Dirk Pranke authored
Now that the jumbo build is no longer supported (and hasn't been for quite a while), there is no need to use the jumbo target types like jumbo_source_set, jumbo_component, and jumbo_static_library. This CL converts all such targets back to their non-jumbo equivalents. The change was made via a simple search and replace. Bug: 994387 Change-Id: I19b431c148d3b43fa19a72f00b28d84ff5a14e8b AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337280Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#795492}
-
Benoit Lize authored
A beta experiment has started, align the testing configuration with the experiment. Bug: 1029320 Change-Id: Ib1439e056cabf9004f7bf566ebc2060eb1989f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340047Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#795491}
-
Abigail Klein authored
This fixes a bug where when a page loads, Voiceover focus shifts to the main content and starts reading it, regardless of whether the "Automatically speak the webpage" option is checked in VoiceOver Utility. It also sometimes causes focus changes to a different window when VoiceOver is launched. The underlying cause of this is that Voiceover hard-coded (using Chrome and Chromium's bundle IDs) us to automatically read the web page on an AXLoadComplete event. Webkit fires AXNewDocumentLoadComplete events rather than AXLoadComplete, so we adopt that here. For a much longer explanation and how we debugged this: https://docs.google.com/document/d/1Rn63cAf1ZVByfh2_ln9rRA388EFM2NVW3wzZo81Bw-c/edit# AX-Relnotes: Fix a bug where when a page loads, Voiceover focus shifts to the main content and starts reading it, regardless of whether the "Automatically speak the webpage" option is checked in VoiceOver Utility. Bug: 1049320 Change-Id: Icf10fbd09bd17018ffe4d3efe9b656ed790d77c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339769Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#795490}
-
Abhishek Kumar authored
crrev.com/c/2292780/ refactors profile support and added entrypoint check in IsProfileSupported.Currently in IsLowPowerEncSupported function all LP encoder supported profiles(kSupportedLowPowerEncodeProfiles) are checked if it support VAEntrypointEncSliceLP and returns true if any profile supports lp entrypoint.This Cl fixes lp encoder entrypoint check and returns true only if va_profile(function argument) supports VAEntrypointEncSliceLP. Fixes:a9bbd8a5 BUG=chromium:1105103 TEST=tast run -checktestdeps=false <IP> video.EncodeAccel.vp9* on octopus Change-Id: Ia3310db0a82f5d9663408fc785aca36773c2ab2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334806 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#795489}
-
Fabio Tirelo authored
This reverts commit d5278fe6. Reason for revert: crbug.com/1113730 Bug: 1113730 Original change's description: > Update V8 to version 8.6.338. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/4f52dde7..351fdfe7 > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: I8cb6b17de69c96b44145019992c01073d2b55966 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340982 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#795410} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4f96d2e13a7cba2c24750c3cf7c7a6b6409d72a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340789Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795488}
-
Curt Clemens authored
Add unit tests for a few scenarios around initializing LevelDB in NearbyShareCertificateStorage, including the deferred callback queueing mechanism and failure retry. Change-Id: I005da00cd0ee85c969f10875bd77d3412ad855a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339824Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#795487}
-
Tommy Martino authored
Before the text fragment can be sent to the JavaScript that will highlight/scroll the page accordingly, it needs to be parsed into components according to the spec. Bug: 1099268 Change-Id: I75d281996b922542aea25501bc22f064a1a5ac73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337407Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#795486}
-
Sorin Jianu authored
When AppWake::AppWake() is invoked, a thread pool is not available yet. This fix is not ideal since it changes how the class members are initialized but the fix helps unblocking some future work. Bug: 1113448 Change-Id: I875b1f27ef7538cc4b5d41c1646e313b2564a6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339613Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795485}
-
Benoit Lize authored
This is currently being experimented on, with very positive results (see https://uma.googleplex.com/p/chrome/variations?sid=0fbe3f0abe9a6530dbf34357a30ed0f3 for the dev/canary data). Enable it, in preparation for the beta experiment. Bug: 1109208 Change-Id: Iffade4ec360dbda6fcdb065d9e640517f38aa98f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340046Reviewed-by:
-
Teresa Kang authored
Removing myself from the owners of histograms since the account will be deactivated soon. Bug: 1090180 Change-Id: I336ddd027ca3d3704bedd3cbc94768575e232805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340161 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This is making sure that the tests are passing when the flag to use the UserAgent of the WebClients is enabled or disabled. Bug: none Change-Id: If61994b6c6ec13327475e4f2f525a93ea121ed1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332606 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Charlie Hu authored
This CL cleans up the remaining bits of layout-animations policy: - update enums.xml - migrate test composited-animations-allow.php Change-Id: I24450bb070d05466f88587d3e00427fc3f98110c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333491Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#795481}
-
henrika authored
Adds more details related to audio output device authorization (required e.g. when a device is switched, or SetSinkId is called). Example of new log output: https://paste.googleplex.com/4803560074117120 Added tag(s): RFAOSF See https://chromium-review.googlesource.com/c/chromium/src/+/2093443 for related work. Bug: 1017219, b/152054751 Change-Id: I568a3d02f41599dc3e564682761e602592048f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340908Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#795480}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I4c5b5068296a5d4f489f3245f7ee8387352fc40c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340863Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795479}
-
Nohemi Fernandez authored
Removes duplicate Identity test APIs with similar intent, as well as duplicated code to create identities. Bug: 1103274 Change-Id: I2730287d5efe430dd0b9ef8dfb255648c5c82329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332673Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#795478}
-
Chris Hamilton authored
This adorns ScriptStates with a unique identifier, and adds lifecycle tracking instrumentation hooks. A further CL will wire this up in order to implement detached context tracking as part of the performance.measureMemory API. BUG=1085129 Change-Id: I4ddb84c547430a28615dea57e7fd346c9e27b1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327851 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#795477}
-
Wez authored
This reverts commit 8b856148. Reason for revert: Appears to cause thread-local-storage related failures under handle-verifier stacks (see https://crbug.com/1112636, https://crbug.com/1111492), when Perfetto happens to FlushPendingCommitDataRequests() while recording a trace event. Original change's description: > Fix HandleVerifier trace events for static builds > > This CL is fixing the trace events of the HandleVerifier for a > non components build. > > For a static build, there are two instances of the HandleVerifier > 1) chrome.exe!HandleVerifier > 2) chrome.dll!HandleVerifier > > At chrome startup, chrome.exe!InstallVerifier set a global singleton > which start tracking ScopedHandle objects. > > After the initialisation, chrome.dll is loaded. The call of > chrome.dll::InstallVerifier() is fetching the singleton from 1) and is > storing it as a global singleton into chrome.dll. Calls to the > chrome.dll!VerifierTraits::StartTracking() and > chrome.dll!VerifierTraits::StopTracking are forwarded to the > chrome.exe!HandleVerifier instance. > > Since TraceLog is also part of base, there is also two instances > in each module. There are two instances of categories array that specify > which categories are enabled but only one is used by chrome tracing. > > A trace event executed in chrome.exe will never be enabled. This is > explaining why trace events from chrome.exe!HandleVerifier are not > emitted unless the build is a component build. > > To solve this issue, this CL is lifting the trace events before > entering the code that forward the call to chrome.exe. This way trace > events are using the right instance of TraceLog (e.g. chrome.dll). > > Bug: 1110507 > Change-Id: I61ee1e18b849d32f90d2430759da6d1c8666c854 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324873 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792764} TBR=gab@chromium.org,wfh@chromium.org,etienneb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1110507, 1112636, 1111492 Change-Id: I30f956e4110a8ca008f2c290f3e0103374166f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339667 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#795476}
-
Patrick Noland authored
Bug: 1111296 Change-Id: I7f0609ee89c00362885cf9ab8df1b41d26ee453e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339703Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#795475}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5d9552ef6987..76488e6d8e63 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If650993b533005bf17717c4e5c6788b59e38d19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341029Reviewed-by:
-
Fabio Tirelo authored
This reverts commit 784ec9ef. Reason for revert: we suspect this is causing several browser_tests to fail on CrOS - more details at crbug/1113730 If tests don't go away, we will restart Skia roll-out and investigate it again. Original change's description: > Roll Skia from 1362c1eac458 to 7a171cca0ca4 (1 revision) > > https://skia.googlesource.com/skia.git/+log/1362c1eac458..7a171cca0ca4 > > 2020-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6c873cfde957 to bedac4f06b5c (13 revisions) > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/skia-autoroll > Please CC herb@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Cq-Do-Not-Cancel-Tryjobs: true > Bug: chromium:1104516 > Tbr: herb@google.com > Test: Test: Test: CQ > Change-Id: I11a7da040639041e1f7826d8f8847029b92ecc99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340929 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#795388} TBR=herb@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: Id73d8938c14e8462ed474acceedbb4744e8cf4e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1104516 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341164Reviewed-by:
-
James Vecore authored
This is a mock up of the Nearby Share on-boarding page. Specs/css strings, accessibility to be refined in another CL. This UI is gated behind the feature flag. Screenshot: https://screenshot.googleplex.com/hN3F6gjGFBJ The settings behavior wraps up the mojo interface into a Polymer property which can be passed down from the root object to the children to allow them to bind and edit settings. In this case, the app.js element hosts the settings object and passed it down to the on-boarding page with two-way binding. Change-Id: I2f1dbe25d0706597c94fc80393084570610424f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332988Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#795472}
-
Liviu Tinta authored
action.pointerMove requires integers as arguments. Change-Id: I3efad46da26fee54ab875e8d88b72a73c91c44c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332303 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#795471}
-
Tina Wang authored
When the settings are managed by enterprise policy, a "learn more" link should be shown in the popup bubble triggered by the information icon by the end of the settings item. Clicking "Learn More" will navigate to chrome://management page. Added access to settings below: - Settings -> Password -> Save password - Settings -> Payment Method -> Save and Fill Payment Methods - Settings -> Address and More -> Save and Fill Addresses - Settings -> Search Engine - Settings -> Content Settings -> Block Pop-ups Bug: 1109002 Change-Id: I4bdba99c1a4d2451a99ddeb8f048af77a2aaa334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337719 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#795470}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ae523ca9..f870c336 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7248052bf1505bb8a1ae4768e99ffdd99ae63ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339002Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795469}
-
Mark Cogan authored
The Clear Browsing Data flow uses the ChromeActivityOverlayCoordinator to block user interactions in the window in which it was triggered. To extend this to multiple windows, this CL adds an option to the activity coordinator to block all windows, implemented by triggering the blocking UI. that the blocking UI is shown in the other window. TEST: Opened two windows, opened History, chose Clear Browsing Data, saw Bug: 1045580 Change-Id: I8466cd8e67ddedce13c6db6580cd0d57b76b120d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339963Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#795468}
-
Liviu Tinta authored
action.pointerMove requires integers as arguments. Change-Id: I6abacedba07090038aff38e9788eec5b0445d4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332330 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b3545b42a10a..99f48c74ab76 2020-08-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from bfe4f378aee6 to ef36eedb0d09 (1 revision) 2020-08-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 8bc27a1cfbc1 to 5fd92a7e0c84 (5 revisions) 2020-08-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from a4505d37ffe7 to a1c21580f50b (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ibd5d730810955fb1fd9307a904a1c1263f59238b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341107Reviewed-by:
-
