GitLab

The base::CommandLine was overly broad. The flakiness analysis of
https://chromium-review.googlesource.com/c/chromium/src/+/1539787
reported that DumpAccessibilityTreeTest.AccessibilityObject and
QuicAllowedPolicyIsNotSet.NoQuicRegulations were flaky.

The latter has a 1.8% confidence and is on a non-TSan builder, so it's
probably a false positive. DumpAccessibilityTreeTest.AccessibilityObject
is real and is tracked in crbug/946481. Refine the suppression to just
cover that.

(If other command-line races come up, I think it's preferable to add new
suppressions and file new bugs rather than revive the overbroad
base::CommandLine suppression. The overbroad one has let new bugs
through, like the accessibility test.)

Bug: 946481, 334140
Change-Id: If09cb2fa2629751367e3fd822e3ba5159d529492
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548138
Commit-Queue: David Benjamin <davidben@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646493}

The current FtlSignalingPlayground is basically for testing the FTL
service APIs, and isn't much related to the signaling process. The
flow for testing the actual signaling process (which uses the jingle
session manager) seems to be very different to just playing with the FTL
APIs, so we will likely need a different playground binary for that.

For now lets rename the binary to FtlServicesPlayground, and I'll send
another CL to refactor CLI common logic.

Bug: 947337
Change-Id: I86661738bcc78982df596b5909968b7122bff6c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547758Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646492}

Using wpt-import in Chromium b5462db2.
With Chromium commits locally applied on WPT:
0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2"
6f2e9bd4 "webrtc wpt: add test for ice disconnection"
be4bce5d "[WPT] Merge subresource scripts into common/security-features"
d1ac10ff "Revert "webrtc wpt: add test for ice disconnection""
e46d3296 "Revise tests for datachannel ID handling"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: I81b566a38fde7c3fffbf472f81109bd797a85621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547940Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646491}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d7d8b4c6d219..5be29a31559d


Created with:
  gclient setdep -r src-internal@5be29a31559d

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org

Change-Id: I58f7fcd5325f578d22e3c4c01a478dd87d5e7934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548096Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646490}

We plan to add a new portal result (Redirect Found) in CL:1532970.
Modify the NetworkPortalResult histogram to accommodate this.

Bug: 903645
Change-Id: I488508ed6f618d69baa0f59a8b7f28d52c8c8fac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542660Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Matthew Wang <matthewmwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646489}

Bug: 916331
Change-Id: I794be5f9c5aa25ca0dfb84f3209061ea992e6875
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548130Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646488}

It says in the JavaDoc for the method to never downcast, but looks like
some places were still doing it.

This change removes all such downcasts and also removes some useless plumbing of
the application context as parameters.

To ensure this doesn't happen again, getApplicationContext() now always
returns a ContextWrapper when DCHECKS are enabled.

Bug: 846456
Change-Id: If9db976511ee1c7da99d71d455b7baa6b7fdec5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545503
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646487}

As a first step towards supporting different cache_storage backends, this
CL splits the CacheStorage and CacheStorageCache objects into separate
base interface and concrete implementation classes.  The interface classes
maintain the existing names.  The new implementation classes are called
LegacyCacheStorage and LegacyCacheStorageCache.

To make this CL easier to review the code remains in the currently existing
files.  A follow-up CL will move the implementation code into separate
files.  Doing the move as a separate CL makes it easier to see what is
changing vs what is moving.

In addition, future CLs will split the CacheStorageManager and create a
factory method for choosing implementations.

Bug: 940449
Change-Id: Ie42b02138e2c41555de3e3ac35870c287f025525
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542177
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646486}

This CL adds parsing of the mastering metadata (hdr) to
AVStreamToVideoDecoderConfig() function, and its
stringification to VideoDecoderConfig::AsHumanReadableString().
It also adds unit testing for this new functionality.

Bug: 945850
Change-Id: I8974311f255c80198442a774d633f05523779e09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546513Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646485}

R=liaoyuke,sajjadm

Bug: 934059
Change-Id: I1496d6c7e699929911561134b15e828a431c4dd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546622Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646484}

Bug: 943349
Change-Id: I527f92e6aae7dbb553d98cc128018db2f136ad4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547945Reviewed-by: Min Chen <minch@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646483}

The crash is because the XWindow is destroyed before destroying the
vulkan surface. Fix the problem by blocking the viz thread until the
SkiaOutputSurfaceImplOnGpu is destroyed.

Bug: 934254
Change-Id: Ib39d08407daeb7fe7a3efdca8478b6fe8ca24f9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547753
Commit-Queue: Peng Huang <penghuang@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646482}

The following errors:

  ERR_PROXY_CERTIFICATE_INVALID,
  ERR_PROXY_AUTH_UNSUPPORTED,
  ERR_PROXY_CONNECTION_FAILED

indicate failure to connect to the proxy (there's also the QUIC-specific
ERR_NO_SUPPORTED_PROXIES). Before this CL, when a URLRequest completed
with one of these errors, |URLRequest::proxy_server_| was not set.

While there's some inherent ambiguity as to which proxy server is set in
this case (ProxyInfo can store multiple proxies), we already report the
net::Error we got for the last proxy we tried, even though previous
proxies might have failed with a different error.

BUG=940428

Change-Id: I900d7be7ea4761cc81bd08d21ca1abfbe8e824ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541164Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com>
Cr-Commit-Position: refs/heads/master@{#646481}

This reverts commit 1dc524aa.

Reason for revert: Causing compile failure on android-jumbo-rel. See https://bugs.chromium.org/p/chromium/issues/detail?id=946562

Original change's description:
> Introduce UserLevelMemoryPressureSignalGenerator
> 
> UserLevelMemoryPressureSignalGenerator's purpose is to generate extra memory pressure signals when the OS signals are not sufficient.
> When the memory usage is over a certain threshold, a critical memory pressure signal will be sent.
> Feature is disable by default and enabled through finch.
> 
> Bug: 920922
> Change-Id: I6c6a8b1890a7964902655198f842d8c0e7e74259
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505738
> Commit-Queue: Keishi Hattori <keishi@chromium.org>
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Takashi Sakamoto <tasak@google.com>
> Cr-Commit-Position: refs/heads/master@{#646224}

TBR=mpearson@chromium.org,tasak@google.com,haraken@chromium.org,keishi@chromium.org

Change-Id: Ie9c6544ac7669158bfaa4f2fbcb9ec77bbc8ef05
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 920922
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548320Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646480}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I2f58334622caf19bd8a90db65d93cbd1d6bbf025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548095Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646479}

This reverts commit f7bfe7d0.

Reason for revert: vulkan_function_pointers.h must be generated

Original change's description:
> Add gpu::SemaphoreHandle and use it in VulkanImplmentation
> 
> Previously VulkanImplementation defined functions for semaphore
> import/export from/to file descriptors. This approach doesn't work on
> platforms that don't support FDs for semaphores, specifically on
> Fuchsia and Windows.
> 
> This CL:
> 1. Adds cross-platform gpu::SemaphoreHandle that allows to
> represent semaphore handle on any platforms.
> 2. Replaces ImportSemaphoreFdKHR() with ImportSemaphoreHandle().
> 3. Replaces GetSemaphoreFdKHR() with GetSemaphoreHandle()
> 
> This allows to remove dependency on ScopedFD in
> gpu::ExternalVkImageFactory, which will make it easier to reuse that
> class on Fuchsia and Windows.
> 
> Bug: 934526
> Change-Id: I16b1a9f3a606683b76a73c4e68a33b3294f25a90
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540724
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Commit-Queue: Bo <boliu@chromium.org>
> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Michael Spang <spang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#646424}

TBR=spang@chromium.org,boliu@chromium.org,sergeyu@chromium.org,piman@chromium.org

Change-Id: Ie273be284b587c2c5a2259da3b6a04e902f87e1b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 934526
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548147Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646478}

This reverts commit 7d13b860.

Reason for revert: Cannot be merged back and will cause merge
conflicts for other tab management CLs.

Original change's description:
> [modules] Auto-determine if resouces go into base or feature module
> 
> + Move tab management resources into its DFM.
> 
> Bug: 944115
> Change-Id: If14cdcfeb6bca94b9f1b040049c0f659831b193b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534777
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#646437}

TBR=wnwen@chromium.org,yusufo@chromium.org,agrieve@chromium.org,tiborg@chromium.org

Change-Id: I4f15497d2a87c44b8b5833886f1726ea18e64ac3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 944115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547762Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646477}

protos are movable now, so let's simplify the code making use of this
fact.

Bug: 947044
Change-Id: I1296f3747e22dc461c6ac5013a627dff68e8b76f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547832
Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646476}

Downstream projects that used android_tools need to switch to android_sdk,
see https://webrtc.googlesource.com/src.git/+/c90e81e2d9592584c5f27074e0b5c33ebad75a5f
for an example.

Bug: 947060
Change-Id: I982960d4bde88e2d780b71b019ec0aaba1019af3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546876
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646475}

https://skia.googlesource.com/skia.git/+log/b6a3a3b245a5..f23ff10eb270


git log b6a3a3b245a5..f23ff10eb270 --date=short --no-merges --format='%ad %ae %s'
2019-04-01 bungeman@google.com Cache data stream for CG typefaces.
2019-04-01 bsalomon@google.com GrBackendTextureImageGenerator proxy callback uses unique key to find existing GrTexture.
2019-04-01 robertphillips@google.com Make prepareSurfaceForExternalIO always flush
2019-04-01 bsalomon@google.com Make GrVkGpuRTCommandBuffer::CommandBufferInfo hold textures by pending read.
2019-04-01 rmistry@google.com Remove 4 page sets that are not useful as SKPs


Created with:
  gclient setdep -r src/third_party/skia@f23ff10eb270

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jlavrova@chromium.org

Change-Id: If7a8a4310e16dd8d8c6d0ee4cf1cc830dda096c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548092Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646474}

Previous to this CL, backdrop_filter_bounds were not properly
scaled by the browser zoom factor. This lead to improper clipping
of the backdrop filtered element.

Bug: 932160
Change-Id: I345f56ae50af319a8b805c7d54ca498221613932
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542677
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646473}

The class keeps track of isolates creation/deletion.

Change-Id: I65ab6aa4ef5c2f1b0df6eb3b024e7df9051a251c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546853
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646472}

Refactor to make code more understandable.

Change-Id: I1439547ccbde474bf007adfea06748dc11b17ab1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546786Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Commit-Queue: Hui Wu <wuandy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646471}

If there is no title on a web contents media session
then use the page title instead. If there is no
artist then move the origin from source title.

BUG=897836

Change-Id: I3a2182c4be4ef2d64f141394d010d7e689863650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546712
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646470}

Navigation Predictor only preconnects to the host site during the first
foreground (after a background). This condition should be relaxed to
every foreground as there are already good experimental results
currently.

Bug: 947721
Change-Id: Ied5af28ef53c06cee4729c8778578753918c4af2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546621Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Auto-Submit: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646469}

Some interactive_ui_tests were disabled on all platforms, but are in
fact only flaky on Windows due to https://crbug.com/711256. Re-enable
these tests on other platforms. Other Web UI tests are still enabled
but continuing to flake on Windows for the same reason; disable these
tests on Windows also.

Bug: 711256, 945630
Change-Id: Ida4bf95839870aa56a1c0de6d5152e1097bc5e66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546849Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646468}

Conditioned STTS behavior on model being loaded.

Added histogram to capture cases it wasn't

Bug: 944591
Change-Id: I279a1577de416d7519ed25fdb605d135bd8f6ed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545726
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646467}

This CL adds a /* all_data_received */ comment to the second parameter
of lazy_decoder_->SetData() calls in deferred_image_decoder_test.cc for
documentation purposes.

Bug: None.
Test: None.
Change-Id: I4943db02521c787f1c7f6739dc2de87c7648f48a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546782
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646466}

When requesting position estimates through the Geolocation API, the
caller may specify a timeout. If the location provider cannot provide an
estimate before the timeout expires, the returned promise is resolved
with a TIMEOUT error.

The Geolocation API specification requires that the timer is not started
until the page has received the geolocation permission. Prior to this
CL, Chrome would start the timer when the API call is made. This meant
that sometimes the TIMEOUT error would be received before the user had
made a selection in the permission prompt. This could also result in
multiple error callbacks being called for the same geolocation request.

To fix, CreateGeolocation will asynchronously return a PermissionStatus
when the permission prompt is complete. The renderer will delay
starting the GeoNotifier timer until a status is received that
indicates the permission was granted.

BUG=784886

Change-Id: I86294ebf1d212a164e4c3a2cb96c4ad27f759cb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/773575Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Conley Owens <cco3@google.com>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646465}

The assertions wouldn't hold for frozen and external tabs. Convert
to early return.

Bug: 947902
Change-Id: Ia1411a59fea2165f78bca5fabc2d3d35d8825bda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548033
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646464}

This bug surfaces when the new download offline item backend is enabled.
We need to filter out the CANCELLED offline item updates from the UI.
Offline pages don't suffer from this issue as they issue an
onDownloadRemoved on cancellation.

Bug: 947433
Change-Id: Ic668d1190f77a71cccc6e91f6b80130f8e539320
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546325
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646463}

https://chromium.googlesource.com/angle/angle.git/+log/9cce3cd9e376..3b14b7861096


git log 9cce3cd9e376..3b14b7861096 --date=short --no-merges --format='%ad %ae %s'
2019-04-01 jonahr@google.com Ignore flaky failures from ANGLE's dEQP deps on Win/Linux/Mac.
2019-04-01 syoussefi@chromium.org Vulkan: Clear DS through render pass even if color is masked
2019-04-01 ynovikov@chromium.org Mark vertex attributes dirty during context switches


Created with:
  gclient setdep -r src/third_party/angle@3b14b7861096

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:920033
TBR=syoussefi@chromium.org

Change-Id: Ibe7abc3c8fb684df47d019582eef2128501b2095
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548089Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646462}

A few race conditions are fixed:
1. The http_url_fetcher is created in a separate thread and this thread could
possibly be running after the actual test that requested it has finished. In
this case we could end up losing the fake url fetcher factory that was created
and end up using a real fetcher trying to access the internet. Now we create
the fetcher object before starting the thread that checks the token handle.
2. A unit test that created a fake provider on the stack and passed it to a
gaia credential that runs the gls will have the fake provider deleted before
the gaia credential is destroyed later because there are two places that hold
a reference to the gaia credential:
  1. The main thread running the test and creating the credential.
  2. The thread waiting for the GLS process to finish.
There can be a race condition where the main thread could finish before the
waiting thread finishes, causing the gaia credential to stay alive and be
deleted at a later time after the fake provider that was created on the stack
was already destroyed. This bug is fixed by adding a missing Terminate in
a test to release the reference to the provider.

Also an error was not reported correctly when the user cancels a GLS process
by selecting a different credential. This caused a kUiecKilled exit code which
was not correctly handled by the waiting function.

Bug: 944126
Change-Id: I220555cbb4d48a7dbdf4dda8fb19892eab200c1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531567Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Tien Mai <tienmai@chromium.org>
Auto-Submit: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646461}

BUG=554299

Change-Id: I92a368dac9a618e070c893072d75c8769e13dd03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546162Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646460}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e160126c..32a51a79

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I895d3d3d329fee64250cad3f9a8dae86bc525b93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547947Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646459}

OnDeviceAdded() and OnDeviceRemoved() abstract.
destructor being protected.

Change-Id: Ibc348d6565b6d2627ae53a34f05a63c08f68a8e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546308Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#646458}

Bug: 947926
Change-Id: I14d96dc424c6edc7073d7d8135c67ac42fd7ff92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546062Reviewed-by: Adam Langley <agl@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646457}

Bug: 932737
Change-Id: Ica1e081aca23aa0195d965f8583ae44b60a7d80b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531165
Commit-Queue: Tien Mai <tienmai@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646456}

This is the 3rd refactoring CL aimed at reducing duplication and
inconsistency for classifying omnibox results. This CL

1) Creates a autocomplete_match_classification file to group static
classification methods. This organizes related code adjacently, promotes
code reuse instead of duplicated code per provider, and avoids providers
calling into other providers' static classification methods.

2) Renames HistoryProvider::SpansFromTermMatch to ClassifyTermMatches
and moves it to autocomplete_match_classification. It is responsible for
creating ACMatchClassifications from TermMatches.

3) Previously, SpansFromTermMatches accepted the bool param is_url which
determined how to style matches and non-matches. To make the method
reusable by the search provider, which uses reversed styling compared
to other providers for non-URL text, ClassifyTermMatches is overloaded
with a more generic signature that parameterizes the match and non-match
styles.

Bug: 366623
Change-Id: I60dfb82305f6e81fa00ff86662e63d2f9e24bb99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546783
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646455}

I've been seeing a revert due to this test being flaky.
Root cause appears to be that sometimes, the Window's node
name is just "Window", and sometimes it's "Window / file://".
So I'm thinking this can be cured by making it always Window.

Change-Id: I89e57f248d24462fdcb79e6db4e278e58f93c473
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546939Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646454}