- 20 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a3c06205b28b..477bd92472cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I91669c7eb0ffb88696494a31b93471bc689f96f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845377}
-
Matthew Denton authored
Add blink::ContainerNode::hasChildren() to shadow blink::Node::hasChildren() to avoid the virtual dispatch that leads to at least 7-12% regressions in some blink query-selector benchmarks, when we know the type statically to be ContainerNode. This is especially bad on Android, where the blink::Node::hasChildren() function is big enough not be inlined, so we miss out on extra optimizations. See the linked bug for a more in-depth analysis of the regression. Bug: 1149340 Change-Id: Ida1d8b609b23ada25ae5ed67826439c74633721c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633194Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#845376}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1b1c73ad500b..8a9da73687e3 2021-01-20 johnstiles@google.com Fix overzealous optimization of short-circuits. 2021-01-20 fmalita@chromium.org [svg] Fix handling of root element position attributes 2021-01-20 johnstiles@google.com Optimize (boolExpr == true) and (boolExpr != false) into boolExpr. 2021-01-20 brianosman@google.com Add ExternalFunction support to SkSL-to-SkVM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I159c236bdb828e124fae600ca5c5508d42487da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640884Reviewed-by:
-
Wei Li authored
Bubble locking was used to prevent bubbles from being dismissed after deactivation. This CL adds general widget blocking by preventing widgets from being dismissed after deactivation. The impl extends the ways of disabling widget activation changes to achieve that. Bug: 1167285 Change-Id: I8b67a7d00e1f1fb9f598d51460e162d111b3110b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638000 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#845374}
-
Leonid Baraz authored
In ScopedReservation destructor did Reserve instead of Discard! This is now fixed; tests will be added separately. Bug: b:159361496 Change-Id: I6cf8932ff113e53a6c15564675135406d81fccc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640820 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#845373}
-
Alex Ilin authored
This CL leverages the already existing kIsOmittedFromProfileListKey preference in ProfileAttributesEntry to mark profiles that shouldn't be shown to the user. kIsOmittedFromProfileListKey was created for profiles in the middle of being set up as new legacy supervised users. The preference was dead because it was never set to true. This CL revives it and adds additional checks to profile_picker_handler.cc and profile_menu_view.cc to not display omitted profiles. Bug: 1126913, 1166809 Change-Id: Ieb05f31d8951f2971201351bead7c108eb874473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632752 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#845372}
-
Wojciech Dzierżanowski authored
With the previous set-up, MediaWebContentsObserver::BindMediaPlayerHost() contained a hidden assumption that a RenderFrameHost uniquely identifies a media element. When another element was created within the same frame, BindMediaPlayerHostReceiver() would reset the connection to the renderer that was set up previously. As a result, MediaPlayerHost messages for the media elements created earlier were not reaching the browser if a frame created multiple media elements. To fix this, we add support for multiple MediaPlayerHost connections from a single frame, one for each HTMLMediaElement, with each HTMLMediaElement calling mojom::MediaPlayerHost::OnMediaPlayerAdded() through a dedicated connection. The disconnect handler for MediaPlayerHost receivers is gone. It could have been reimplemented as a handler on the ReceiverSet, removing MediaPlayerHostImpl from MediaWebContentsObserver when the receiver set becomes empty. However, this removal is effectively a 'delete this' operation and it doesn't seem necessary. By the time there are no receivers, the MediaPlayerHostImpl object is just an empty ReceiverSet and two pointers. It is cleaned up upon render frame deletion. Bug: 1167154 Change-Id: Idd7873da91ee452c91b2f4667f29a1aa80831678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632691 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#845371}
-
Xing Liu authored
Keep the bookmark UI reading list page open after the user open a reading list page in CCT. Bug: 1163719 Change-Id: Ibfdd1045301bcf7de5dcb301877f2b4394181bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639220Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#845370}
-
Austin Eng authored
Bug: 1164115 Change-Id: Id009288173d3a05c6c87f17a97eb9f359a58a17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640993Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#845369}
-
Russell Hawkins authored
Run set_adjust_if_offscreen(true) after group editor bubble is created so that it doesn't go offscreen. Bug: 1162253 Change-Id: Ic9161cc65ea2ae2a00a925c5db4c93514ee002ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638248 Commit-Queue: Russell Hawkins <thatguyrussell@google.com> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#845368}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611153816-d2f18273110c533af9e6c4795ef7f831ac05328f.profdata to chrome-win32-master-1611165592-7dc454a3a93e8067ea7c07bb6e94372701a24ad7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6a1cd4dd776a0188707a785046c136b52abd4f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640882Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/39ca1963aa25..15c630fcaa35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC harringtond@google.com,gab@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1150968,chromium:1151505,chromium:1164189,chromium:1166926 Tbr: harringtond@google.com,gab@google.com Change-Id: I3959a8e5e8f1ee21da9e0422059678dfd52132e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640706Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845366}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chromeos/components/proximity_auth. Bug: 1007654 Change-Id: I55f3a3a1a4b30a628f106886ffa9937c01849fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637412 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#845365}
-
Moe Ahmadi authored
- This is step 1 to transfer ownership of realbox to the omnibox team. - The next step is to move the realbox resources into their own dir. Bug: 1159934 Change-Id: I19c7eb5253524d393c1bed9e0c9b0a36ac23c4ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595205 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#845364}
-
Shane Fitzpatrick authored
Regression checklist: https://docs.google.com/spreadsheets/d/1RnMjwDc4KkvxIY9fbjCJnborlawdlJOVfBJWejl6DZM/edit#gid=486249825 Fixed: 1102458 Change-Id: I94f17817b56a3c435cd5561f275441a677a591d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638974Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Shane Fitzpatrick <shanefitz@google.com> Cr-Commit-Position: refs/heads/master@{#845363}
-
Bailey Berro authored
This change wires up the RoutineLog to SystemRoutineController so that the log is added to anytime a routine starts or finishes. Bug: 1128204 Change-Id: I2ff1e23fccb4a3f6891ffa8a7a8c118278618c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632872 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#845362}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c895583f9314..54d70996a75a 2021-01-20 tfiga@chromium.org gerrit: Add wip/ready to control the Work-In-Progress state 2021-01-20 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-20 tcwang@google.com toolchain: Format toolchain api controller 2021-01-19 mikenichols@chromium.org chromeos_config: Set factory to false for loonix boards 2021-01-19 geohsu@google.com Re-instantiate M89 builders, use correct branch 2021-01-19 morg@google.com Disable unit tests for zork-arc-r AMD board If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ide5157a643b9bf821bd4e89fe100353600d2c1f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639137Reviewed-by:
-
Tanya Gupta authored
Change-Id: If15c21b7cb2da83ec9c8b41bc77c525ef1dc1422 Bug: 1153969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630885Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
-
James Cook authored
This reverts commit 524d9990. Reason for revert: Multiple developers were unable to launch lacros, due to using @managedchrome.com or @chromium.org accounts for testing. Until we can revisit the policy settings for common domains used by developers, I'm going to revert. Original change's description: > lacros: Allow LacrosAllowed policy to apply to developer builds > > Clean up some leftover logic from when we disabled lacros in M87 for > non-google managed users. In particular, don't skip the policy check > for developer builds with channel unknown. The LacrosAllowed pref > defaults to true, so this doesn't affect developers who aren't working > with policy. > > Bug: 1135494 > Test: updated unit_tests > Change-Id: I510ada8de5d266626ba8adef64a7dd33202574a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628592 > Reviewed-by: Igor <igorcov@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844259} TBR=jamescook@chromium.org,igorcov@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1135494 Change-Id: Ice9c8695697c3362dc4170410752484e0ff05f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640644Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#845359}
-
Jonah Chin authored
This is a reland of 0c93bcb5 This change depends on an earlier change that has been relanded. https://chromium-review.googlesource.com/c/chromium/src/+/2634055 This one can now reland too. Original change's description: > Introduce mailbox-based version of VideoTextureBacking > > This CL introduces an OOPR compatible version of VideoTextureBacking and > updates PaintCanvasVideoRenderer::UpdateLastImage() to use this new > version in the OOPR codepath. > > More details about overall PaintImage effort: crbug.com/1023259 > Info about the OOPR-Canvas2D project: crbug.com/1018894 > > Bug: 1115217 > Change-Id: I4590cf16d6faef0e5575b0b4006ea88de89aa13d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419653 > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Jonah Chin <jochin@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#826449} Bug: 1115217 Change-Id: I7350332bad441440b69c7b472cbf08074a33304e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640815Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#845358}
-
Sreeja Kamishetty authored
Have PageLoadTracker dispatch OnEnterBackForwardCache before dispatching PageHidden. This would ensure that if the observer does not override OnEnterBackForwardCache, only OnComplete is dispatched, making it similar to the flow without BackForwardCache. In particular, this fixes the following tests in UmaPageLoadMetricsObserverTest when base::Feature::kBackForwardCache is enabled: LargestContentfulPaintAllFrames_MergeFromFramesBySize_MainFrameLarger LargestContentfulPaintAllFrames_MergeFromFramesBySize_SubframeLarger LargestContentfulPaintAllFrames_OnlyMainFrameProvided LargestContentfulPaintAllFrames_OnlySubframeProvided LargestContentfulPaintAllFrames_SubframesCandidateOnlyGetLarger_Larger LargestContentfulPaintAllFrames_SubframesCandidateOnlyGetLarger_Smaller LargestContentfulPaint_ImageLargerThanText LargestContentfulPaint_OnlyImage LargestContentfulPaint_OnlyText LargestContentfulPaint_TextLargerThanImage LargestImageLoadingSmallerThanText where the paint histograms were not recorded as the time was not set correctly. Bug: 1157426 Change-Id: I287cf2c0dad2887957f1f359d51f502e0e6570d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627135 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845357}
-
Gordon Seto authored
Add backward navigation to eSIM setup flow. Add unit tests for logic. Bug: 1093185 Change-Id: I1fffd4c953597d1d900bf3c99411601b3474c32e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637970Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/master@{#845356}
-
Vikas Soni authored
Also removed the old study which WebViewZeroCopyVideo which is now closed. Bug: 1091945 Change-Id: I7448724c227907261fd715e8d0ac3df8401e01d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638518 Auto-Submit: vikas soni <vikassoni@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#845355}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 59a25f2b. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-sizing futhark@chromium.org, andruud@chromium.org, ericwilligers@chromium.org, shend@chromium.org: external/wpt/css/css-conditional NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I865871111fc084532cae6d7dfff74ceaa3746aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640755Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845354}
-
ckitagawa authored
The scale tests appear to flake only on android-pie-arm64-rel. The root cause seems to be inside UiAutomator (Pixel 2 or P specific probably). In particular it looks like an AccessibilityNodeInfo is null when UiAutomator attempts to use it. There could be a missing null check or the state of the UI somehow changes and results in an invalid node. I tried a number of fixes including: - Disable the test on P -> coverage loss - Run the code on a different thread (UI thread) -> didn't fix the issue (probably not a UI change within Chromium code). - Wait/Sleep before the test -> didn't fix the issue (again suggesting this isn't test/chromium code specific). - Retry the test in a try-catch -> still fails sometimes (looks like a clean run of the testcase is needed even if teardown is simulated). What was settled on: - Catch the NullPointerException from UiDevice#findObjects(). On P the exception is forgiven. This only happens < 30% of the time. This isn't ideal as it hides the error, but only on P and this ensures coverage still exists. Bug: 1167884 Change-Id: I3f41b57056ccc214f7ba4ff5f060405a8f42c8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636276 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845353}
-
Adam Norberg authored
external_constants.cc now uses ExternalConstantsOverrider to load overrides rather than DevOverridesProvider. Tests have been updated to use ExternalConstantsBuilder or write the override file directly, whichever is more appropriate. Bug: 1154901 Change-Id: I35383e25058c1799f99583128b5e695cbf90ac1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634264Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Adam Norberg <norberg@google.com> Cr-Commit-Position: refs/heads/master@{#845352}
-
Wojciech Dzierżanowski authored
Bug: 1140960 Change-Id: Ib33835d9da6777599ef0ab1515a8cf6465e8cdd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640393Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#845351}
-
Eugene But authored
Bug: None Change-Id: I7ffc7064b2a84e47d466512ef5eab7cfd873cbd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638098Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#845350}
-
Boris Sazonov authored
Adds AccountManagerFacade::Observer interface along with {Add/Remove}Observer methods, corresponding implementation in AccountManagerFacadeImpl and some tests. Bug: 1117472 Change-Id: Ia84f37703af56b8f22683d9a97cfc2dddb5579ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560122 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#845349}
-
Eugene But authored
Bug: None Change-Id: I29a3862af76bb103713374ca2b06d8172eca1d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633852 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#845348}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611153816-7597e0f48ca66fa59a87e60988316d59a3bbff86.profdata to chrome-win64-master-1611165592-b5253c098e9c7fa5265e7248ae4df5f8c48efe50.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib7d9cfc6368daecad4a6217eccfeccc8475de9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640743Reviewed-by:
-
manukh authored
Closing the omnibox popup can change the selected suggestion. This occurs in 3 cases: 1) Search what you type suggestions that look like URLs. E.g. after selecting the search-what-you-typed suggestion 'x.com' and closing the popup, the omnibox will navigate to 'x.com' instead of searching the default search engine for 'x.com' 2) Title autocompletions for inputs that look like searches. E.g., for the suggestion 'jupiter - wi[kipedia]', after closing the popup, the omnibox will display 'jupiter - wikipedia (wikipedia.org/wiki/Jupiter)' but will search for 'jupiter - wikipedia' instead of navigating to 'wikipedia.org/wiki/Jupiter'. 3) Title autocompletions for inputs that look like a different URL than their URLs. E.g., for a bookmark titled 'x.com' with URL 'y.com', after closing the popup, the omnibox will display 'x.com (y.com)' but actually navigate to 'x.com' instead of 'y.com'. The first case isn't problematic, because closing the popup updates the omnibox favicon, and there's no additional text. Cases 2 and 3 are problematic because the additional text from before closing the omnibox no longer represents where the omnibox will actually navigate to after closing the omnibox. This CL addresses this by clearing the additional text when closing the popup. Perhaps the preferred long-term solution would be to prevent the selected suggestion from changing when closing the popup. But for the time being, this CL at least updates the view to correspond to the updated suggestion. Bug: 1062446 Change-Id: If5c4ef25abbd73d54540eeb8cb5b85b4db307107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628011Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2d79f95e908d..a3c06205b28b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8974ac0963cf26b478f74572c01167ad89af86fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640995Reviewed-by:
-
alanlxl authored
To make sure ServiceConnection is bound to UI sequence task_runner. Bug: chromium:916760 Test: pass the unit_test Change-Id: Ia03094fca3dcaa86774520f681b522f77508d4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631805Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xinglong Luan <alanlxl@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#845344}
-
Andrew Grieve authored
module_build_configs were not being added as inputs nor to depfile. Bug: 1168655 Change-Id: I7576f168f219a2e45625988ecfc20ca9c0e6d2f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640897 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#845343}
-
Sunny Sachanandani authored
https://crrev.com/c/2626100 added RG_16EXT as a viz::ResourceFormat, and accidentally marked it as a supported GpuMemoryBuffer format too. This causes crashes on ChromeOS when playing VP9.2 HDR video. Bug: 1116101, b/177910735 Change-Id: Iaed4ffefa42bcca4b6bd1885d7e090d9f2782b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639578 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#845342}
-
Amr Aboelkher authored
This CL is adding test coverage for Hash dance request status i.e. AutoEnrollmentRequestStatus, and Hash dance network error i.e. AutoEnrollmentRequestNetworkErrorCode UMA histograms. BUG=chromium:1167383 Change-Id: Ib35c0bd99ff0457007df500d4e6d7b273fffd2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639762 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#845341}
-
Dominick Ng authored
Bug: None Change-Id: I3032cf6514dbe29d44092b871e12b2a022dc67c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639417Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#845340}
-
Lei Shi authored
Previously, at the end of a nodeGroup, we use the trimmed text of the nodeGroup to update currentCharIndex_. This approach causes issues when the user resumes from selection that ended in space. Bug: 1167435 Change-Id: Ifa74c459100f6fd444f6200b09eec1fe2f2b4042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638917Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Lei Shi <leileilei@google.com> Cr-Commit-Position: refs/heads/master@{#845339}
-
Eugene But authored
Bug: None Change-Id: I7a65f31b28c977a92c8d96759d29f35bc364a237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634268 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
