- 11 Jan, 2019 40 commits
-
-
Dave Tapuska authored
It is no longer used. All other classes have mitigated to using CancelableTasks and ContextLifecycleObservers directly. BUG=907125 Change-Id: I9bfa406836e842b1dfc2b14a9144758e3edd55d1 Reviewed-on: https://chromium-review.googlesource.com/c/1407094Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#622125}
-
Jamie Madill authored
The drivers have been upgraded. Try running the test suites again to see if the device lost problems have gone away. Bug: 917046 Change-Id: I8a8b92e5cdb0f26f7b6f502cbd99c52308767ecd Tbr: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1407089Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#622124}
-
Stephen McGruer authored
This relands the commit b0eab4a3 from https://chromium-review.googlesource.com/c/chromium/src/+/1372173 The only change is to mark virtual/threaded/animations/skew-notsequential-compositor.html as flaky; it has been decided that it is worth landing the CL anyway and investigating the flakiness afterwards. TBR=majidvp@chromium.org,pdr@chromium.org Bug: 912574, 921105 Change-Id: I93dfc5db4056e3567f99254f28b1072a66c4f532 Reviewed-on: https://chromium-review.googlesource.com/c/1407385Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#622123}
-
Miguel Casas authored
This CL adds "Measure" to the html_media_element_capture idl file, so we can track its usage -- it was probably overlooked before. Change-Id: Ic70ebb689386f22ff134b4296fd79f13b53b3670 Reviewed-on: https://chromium-review.googlesource.com/c/1407031 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#622122}
-
Miguel Casas authored
This CL moves MediaRecorder-events-and-exceptions.html to the wpt/ folder, and refactors it to use canvas.captureStream() (ISO the Chrome-specific blink_test_runner.cc thing). It also fixes partially MediaRecorder-error.html: a new method drawSomethingOnCanvas() is introduced and called to guarantee that the canvas produces some captured VideoFrame, kicking the event(s) generation. This fix is partial because Chrome doesn't have MediaRecorderErrorEvent, but at least we verify that an error event is thrown. Bug: 919951 Change-Id: Ie9d7cfeeb2bf4452f4b5928eb2a7c644778751a7 Reviewed-on: https://chromium-review.googlesource.com/c/1406150Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#622121}
-
Christopher Cameron authored
Just flushing before and after DoRasterCHROMIUM was not enough to prevent crashes. In fact, it appears that DoRasterCHROMIUM's behavior is unrelated to crashes. Flush after every segment of decoded commands. If this limits crash rates (it likely will because that worked for non-OOP raster), then we can start examining the actual commands that were run to find patterns. Remove old no-longer-needed instrumentation. Bug: 906453 Change-Id: Ic5faa5a07dbb4223219a3e88a97b5afaeb65d6b7 Reviewed-on: https://chromium-review.googlesource.com/c/1400772Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#622120}
-
Johann authored
https://chromium.googlesource.com/webm/libvpx.git/+log/57f7c6f19144..759d1de9d0d2 $ git log 57f7c6f19..759d1de9d --date=short --no-merges --format='%ad %ae %s' 2019-01-08 jianj vp8 dec: Add flag to bring up threads. 2019-01-07 johannkoenig vp8 idct dequant: resolve missing declarations 2019-01-07 johannkoenig vp8 overlaps: resolve missing declaration 2019-01-07 johannkoenig vp9_get_blockiness: resolve missing declaration 2019-01-07 johannkoenig vp8 blend: resolve missing declarations 2019-01-07 johannkoenig vp8_copy32xn: resolve missing declaration 2019-01-07 johannkoenig arm neon: resolve missing declarations 2019-01-07 johannkoenig vpx_filter: resolve missing declarations 2019-01-07 johannkoenig vpx_clear_system_state: resolve missing declaration 2019-01-07 johannkoenig vp9 intra pred test: resolve -Wuninitialized warning 2019-01-07 johannkoenig vp8 multi dimensional search: resolve missing declarations 2019-01-04 kyslov Fix OOB memory access on fuzzed data 2019-01-07 johannkoenig fix vp9 fdct_quant 2019-01-03 urvang VP9 firstpass: Bugfix when mi_col_start/end is odd 2018-12-31 angiebird Increase memory size in non-greedy-mv 2018-12-22 angiebird Build pyramid motion field 2019-01-02 jianj vp9: psnr diff thres for single vs multi threading. 2018-12-21 yunqingwang Adaptively choose block sizes in temporal filtering 2018-12-22 jzern test-data: add missing test data entries 2018-12-22 jzern Revert "Add Tile-SB-Row based Multi-threading in Decoder" (...) Created with: roll-dep src/third_party/libvpx/source/libvpx BUG=webm:1573 Change-Id: I6488543cc2773fb02a2f8ba508d50f246789237d Reviewed-on: https://chromium-review.googlesource.com/c/1400959Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#622119}
-
Hector Carmona authored
Bug: 920685 Change-Id: Ibbb068b85f5bd3a94b5823dbece9409ea68bcb36 Reviewed-on: https://chromium-review.googlesource.com/c/1406180 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#622118}
-
Nate Fischer authored
When the app targets at least Q, we should return a dedicated integer constant. Otherwise, we should return UNKNOWN for backwards compatibility. Bug: 887186 Test: run_run_webview_instrumentation_test_apk -f=SafeBrowsingTest#*Billing* Change-Id: Ifcab24c33469d3c5ce31dafa3b947a60cf6a82ed Reviewed-on: https://chromium-review.googlesource.com/c/1406317Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#622117}
-
Chase Phillips authored
IndexedDBCallbacksImpl was originally an implementation of the Mojo IDBCallbacks interface hosted by the renderer process defined in content/renderer/. In onion souping IndexedDB, all of the Mojo interfaces moved to be hosted in blink/renderer/modules/indexeddb/, which made the extra layer of IndexedDBCallbacksImpl redundant with WebIDBCallbacks. This commit removes the redundant layer, moving the Mojo IDBCallbacks interface from IndexedDBCallbacksImpl to WebIDBCallbacks. Bug: 717812 Change-Id: I076002f019f2cf9e5ddb965c504615c8ed60fcf9 Reviewed-on: https://chromium-review.googlesource.com/c/1395558 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#622116}
-
Samuel Huang authored
This CL adds new files for ARM support. The code is not yet integrated into Zucchini, but are only used by the added tests. The high-level goal is to support rel32 reference read / write via: (data bytes) <-> |code| <-> |disp| <-> |target_rva|, where |code| is ARM machine code value (read-write), and |disp| is a PC-relative displacement. Details: * Add template class ArmAddrTraits as API to process rel32 references. It is specialized for each rel32 address type, and aggregates selected low-level static functions from an ARM *Translator class. * Add class Arm32Rel32Translator for 32-bit ARM (ARM32) * ArmAddrTraits is specialized to {A24} encoding for ARM mode, and {T8, T11, T21, T24} encodings for THUMB2 mode. * Complication: |code| can affect |disp| <-> |target_rva|, since the the BLX instruction dictates whether |target_rva| should be 2-byte or 4-byte aligned! * The BLX special case makes |disp| <-> |target_rva| unsuitable for ArmAddrTraits. This led to the API to be defined as: * Fetch() for (data bytes) -> |code|. * Store() for |code| -> (data bytes). * Decode() for |code| -> |disp| & alignment spec (ArmAlign). * Encode() for |disp| -> |code|: Modifies existing |code|. * Read() for |code| -> |target_rva|: Needs |instr_rva|. * Write() for |target_rva| -> |code|. * Needs |instr_rva|; modifies existing |code|. * Add class AArch64Rel32Translator for 64-bit ARM (AArch64). * ArmAddrTraits is specialized to {Immd14, Immd19, Immd26} encodings. Bug: 918867 Change-Id: Ie20935e391ed0ac85c408aa9c8959305dc8bba42 Reviewed-on: https://chromium-review.googlesource.com/c/1394397Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#622115}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f7f13a85db94..4f3f4e172145 git log f7f13a85db94..4f3f4e172145 --date=short --no-merges --format='%ad %ae %s' 2019-01-11 achuith@chromium.org chrome_stages: Add cros_run_vm_test. 2019-01-11 gbiv@google.com SimpleChrome: use lld in branded+official builds 2019-01-11 dgarrett@google.com generic_stages: Use active buildroot for portage lookups. Created with: gclient setdep -r src/third_party/chromite@4f3f4e172145 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3f743848a100f6e6393a1d757b99466a967607b9 Reviewed-on: https://chromium-review.googlesource.com/c/1407097Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622114}
-
Sergey Ulanov authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f8374cf..24e7192 Bug: 778467 TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I4617e82b69a9b2de877c63f735d8ea461c960e57 Reviewed-on: https://chromium-review.googlesource.com/c/1406132Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#622113}
-
Liquan(Max) Gu authored
We introduced a bug in https://chromium-review.googlesource.com/c/chromium/src/+/1380193. When image paint detector finds the largest paint candidate with null time, it passes in to the trace, which will cause a crash. To fix it, we skip the candidate if the candidate's time is null. Bug: 920627 Change-Id: Ie39ac9fbc1d09fc88e09851497a80610969bd527 Reviewed-on: https://chromium-review.googlesource.com/c/1407088Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#622112}
-
Mustafa Emre Acer authored
We currently fetch the list of engaged sites on every navigation on the UI thread. This is slow. We also do this separately for each tab. This CL introduces a profile keyed service called LookalikeUrlService. This service fetches the list of engaged sites every 5 minutes in a background thread and stores the results until the next update. It also gets rid of the need to do a fetch for each tab separately. Bug: 913647 Change-Id: I9f7080c45834de576eb081243778f2f17c3e4ccd Reviewed-on: https://chromium-review.googlesource.com/c/1389167 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/master@{#622111}
-
Hector Carmona authored
Also fix some const references surfaced by presubmit. Bug: 912026 Change-Id: If18dc61d8284c86cbec9f23e09286e9c5f666824 Reviewed-on: https://chromium-review.googlesource.com/c/1405459Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#622110}
-
Jeremy Roman authored
This reverts commit 02090026. Reason for revert: Causing crashes in canary. Original change's description: > [Reland] webaudio: Always delete handlers in a non-nestable task on the main thread. > > Deleting handlers does considerable non-trivial work that requires the > graph lock. Allowing this to happen during finalization introduces > considerable complexity because it can happen during any GC heap allocation, > including ones that occur while the graph lock is already held. > > Instead, when the last reference is dropped, the handler is not deleted > immediately, but a non-nestable task to delete it is enqueued. Since the > task is non-nestable, it will not run while the graph lock is held by the > main thread (and if it is held by another thread, it will block on it). > > This slightly extends the lifetime of audio handlers, during which time > it is illegal to take a new reference (and RefCounted checks this in > debug builds). So a flag is set in the destructor (though it could be > sensibly set as early as the ref count reaches zero) that prevents the > handler from adding itself to the tail processing queue if it is already > being destroyed. > > The cycle collection layout test is updated to handle the fact that the > handler count does not go to zero immediately on GC, but shortly thereafter. > This has been done by merging with another recently added unit test, which > tests something very similar (a cycle of one element). > > The leak detector has been augmented to wait for audio handlers that are > awaiting deletion, if there are any. > > Bug: 884059 > Change-Id: I818bcdbf87dc3e83359ad7a62aa56547dea2d7a5 > Reviewed-on: https://chromium-review.googlesource.com/c/1392109 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hongchan Choi <hongchan@chromium.org> > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621840} TBR=jbroman@chromium.org,haraken@chromium.org,hongchan@chromium.org Change-Id: Ib13b613f6fa696935f64362f65eb94cba50acdfd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884059,921018 Reviewed-on: https://chromium-review.googlesource.com/c/1407501 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#622109}
-
Tom Anderson authored
The copied test fonts are inputs to generate_fontconfig_caches, so must be listed in deps, not data_deps (https://crbug.com/919422). generate_fontconfig_caches creates test_fonts/.uuid, but fontconfig deletes .uuid when there are no fonts [1], so if generate_fontconfig_caches runs before test_fonts are copied, .uuid will be deleted and the build will be dirty (and the cache file will be incorrect). [1] https://cs.chromium.org/chromium/src/third_party/fontconfig/src/src/fcdir.c?rcl=ba206df9b9a7ca300265f650842c1459ff7c634a&l=429 BUG=919422 R=thakis CC=erikchen,tikuta Change-Id: I94057b8035510a122e379249f9f8c60c9e526a57 Reviewed-on: https://chromium-review.googlesource.com/c/1406228 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#622108}
-
Katie D authored
Also adds a bubble to confirm that a user wants the setting on. This copies the behavior of the spelling suggestions service. Context menu change is only added when the feature flag is enabled. Bug: 905419 Change-Id: I171f21a9766d150b113e15a0f95238ed435fda5e Reviewed-on: https://chromium-review.googlesource.com/c/1404156Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#622107}
-
Dana Fried authored
Client area of views is now caluclated from GetInsets(), and the old way dialogs were using GetInsets() to mean something completely different has been fixed/changed, so there is no reason to override GetInsets() to return zero. Removing the override fixes the layout of the dialog. Bug: 916479 Change-Id: I586236a3cfadd08805a5df4f737c982102850077 Reviewed-on: https://chromium-review.googlesource.com/c/1405874Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#622106}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f7793ef4be2e..6daa05d3185a git log f7793ef4be2e..6daa05d3185a --date=short --no-merges --format='%ad %ae %s' 2019-01-11 fmayer@google.com Merge "profiling: Allow script to not start / stop heapprofd." 2019-01-11 fmayer@google.com Merge "profiling: waitpid(2) for children spawned in test." 2019-01-11 treehugger-gerrit@google.com Merge changes I00fcf098,I244a6879 2019-01-11 primiano@google.com Merge "Add traced_probes to log group" 2019-01-11 treehugger-gerrit@google.com Merge "WASM: Enable clamp mode on float -> int conversion" Created with: gclient setdep -r src/third_party/perfetto@6daa05d3185a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Idfcc6b15c617138e607e3b0712f6a948a9810a10 Reviewed-on: https://chromium-review.googlesource.com/c/1407114Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622105}
-
Kyle Milka authored
Bug: 904565 Change-Id: Ibe5112bb6a0b938c24315606ae5647a5ae6913fd Reviewed-on: https://chromium-review.googlesource.com/c/1338122 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#622104}
-
Peter Kotwicz authored
This CL changes the splash screen hiding logic to not hide the splash screen while the network error dialog is up. BUG=920729 Change-Id: Ifa4659b2e97c70b5d4dde83ba52b3bd41a80ea29 Reviewed-on: https://chromium-review.googlesource.com/c/1405985 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#622103}
-
Eugene But authored
Bug: 781534 Change-Id: I9558bbf6996504ecdea358119da16ef160a6ca28 Reviewed-on: https://chromium-review.googlesource.com/c/1405990 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#622102}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e58cda9a3da9..0ef2f1153a1b Created with: gclient setdep -r src-internal@0ef2f1153a1b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6fb5801f3dcda4b98075c51372d2eeee6410be8b Reviewed-on: https://chromium-review.googlesource.com/c/1407249Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622101}
-
David Bokan authored
This CL moves logic specific to spatial navigation out of FocusController and into the newly created SpatialNavigationController. This is a straight move-only operation, with limited and minor name changes and comments. There should be no functional changes. Bug: 919158 Change-Id: Ib2fd763c82d612f13e0c33ccaeb9700890bb2458 Reviewed-on: https://chromium-review.googlesource.com/c/1404561 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#622100}
-
Chris Harrelson authored
Pauses may happen while the parser has already yielded, and in particular when a script-inserted style sheet appears that has an external resource. The failure mode before this patch was: 1. Yield & schedule unyield 2. Script task runs 3. Script task inserts stylesheet with external resource 4. Resource finished 5. ResumeParsingAfterPause called, but there is no last_chunk_before_pause_ because there was a yield, not a pause. Bug:902237 Change-Id: Id65c721fc193ecec7190e6b466a6794b65ea6acc Reviewed-on: https://chromium-review.googlesource.com/c/1389502Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#622099}
-
Michael Lippautz authored
Switch to a uniform object construction that does not differentiate between mixins and regular garabge collected objects and as a consequence can interrupt both construction cases with garbage collections. Object construction now uniformely works as follows: 1. The object under construction is marked so in the HeapObjectHeader. 2. Upon discovering such an object it is delayed in a separate marking worklist. 3. Upon hitting the main atomic pause all such objects are conservatively scanned for pointers without using the Trace method. Special cases: a. Mixins in construction: The HeapObjectHeader cannot retrived for such objects. A default GetTraceDescriptor() implementation returning a sentinel marker is used to discover that such objects should be delayed. b. Upon reaching a safepoint (e.g. no stack), in-construction objects are moved to a marking worklist that, similar to the regular marking worklist, allows for incremental processing. Effects: - No more TLS access for no-GC scope on mixin construction. - No more memory needed for the no-GC scope marker in mixin classes - MakeGarbageCollected should require less binary size as implementations can be aligned. - Incremental marking Start and Step operations are safe to be called with stack (even though it is preferable to not do so). - Object construction is safe to be used with a concurrent marker as it is ok for any objects (mixins as well as normal ones) to be published to the object graph during constructors. This reverts commit ad406608. Bug: 911662 Change-Id: I7babc6bac25b446a63783bf2c3d19e9b525d9e9a Reviewed-on: https://chromium-review.googlesource.com/c/1405991Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#622098}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cb42fc0dc56f..9716603f9736 git log cb42fc0dc56f..9716603f9736 --date=short --no-merges --format='%ad %ae %s' 2019-01-11 nednguyen@google.com Update skia docs to stop referring to NeedsManualRebaseline 2019-01-11 fmalita@chromium.org Hack up SkShaper to pass additional callback info 2019-01-11 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-01-11 ethannicholas@google.com fixed SPIR-V decoration 2019-01-11 jvanverth@google.com Revert "Add target SkColorSpace to SkImage_GpuYUVA." 2019-01-11 robertphillips@google.com Reduce reliance on the SkImage_Gpu's GrContext pointer 2019-01-11 benjaminwagner@google.com Omit another gm for IntelIris655 vk. 2019-01-11 jvanverth@google.com Add target SkColorSpace to SkImage_GpuYUVA. 2019-01-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 18af9a5a50c6..92ee1f9f3032 (1 commits) 2019-01-11 ethannicholas@google.com Fixed GPU perlin noise shaders under rotation. Created with: gclient setdep -r src/third_party/skia@9716603f9736 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:621126 TBR=bsalomon@chromium.org Change-Id: Ic2fe98f2713fec5d3914ac2a13589999b9617e13 Reviewed-on: https://chromium-review.googlesource.com/c/1406959Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622097}
-
Scott Violet authored
Windows that want to receive drop events must call WindowTree::SetCanAcceptDrops(). This was only done for DesktopNativeWidgetAura's content-window by DesktopWindowTreeHostMus. A better approach is to implicitly call SetCanAcceptDrops() any time a DragDropDelegate is registered on a window. Going this route means DesktopWindowTreeHostMus doesn't need to explicitly call SetCanAcceptDrops() because DesktopNativeWidgetAura registers a DropDropDelegate. BUG=920789 TEST=covered by test Change-Id: I3c350d51ba0258dafc70fcee98c694b7fc39ce0b Reviewed-on: https://chromium-review.googlesource.com/c/1407082 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#622096}
-
Alexandre Frechette authored
(1) Adds an optional test to check serialized data against complete data. (2) Add script to move data from a single arbitrary folder to the correct locations in chromium. (3) Update data to latest version. (4) Fix serialized data to C script so that bytes to uint32 conversion is done manually. Bug: 850947 Change-Id: I84d5a6e34a99eee60c973525f2c8358c583d3a87 Reviewed-on: https://chromium-review.googlesource.com/c/1383351Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#622095}
-
Antoine Labour authored
All callers pass an internalformat consistent with gpu::InternalFormatForGpuMemoryBufferFormat, so there's no need to specify redundantly the internalformat and the BufferFormat. Instead just pass in the BufferFormat, which simplifies all callers and increases consistency. Bug: 900044 Change-Id: I19916a6f53a19e1419e3312a2ea4368d79fd95e4 Reviewed-on: https://chromium-review.googlesource.com/c/1405286Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#622094}
-
Steven Bennetts authored
chromeos_export.h is being included outside of src/chromeos which should not be the case. This is probably from files moved out of src/chromeos. This CL fixes those and makes chromeos_export a non public deps of //chromeos. Bug: 918682 Change-Id: I6bf394f0c933b8259f7567cfbb514c936b2d457c Reviewed-on: https://chromium-review.googlesource.com/c/1405979 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
A Olsen <olsen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#622093}
-
Aleks Totic authored
Bug: 918904 Change-Id: I95483729d4f4839d18731ed73ae979a5917cf835 Reviewed-on: https://chromium-review.googlesource.com/c/1407119 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#622092}
-
David Valleau authored
This change fixes the bug where if a user attempts to change the URI of an existing configured zeroconf printer from a link local address to a static IP address the attempt to add the device would timeout and fail. This issue was caused by wrongly attempting to perform domain name resolution on the IP address instead of simply performing the configuration with the new address. Bug: 838677 Change-Id: Iba1a8fb8dfd0194138e2d0aa881592027fd713bd Reviewed-on: https://chromium-review.googlesource.com/c/1109387 Commit-Queue: David Valleau <valleau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#622091}
-
Lei Zhang authored
This removes non-determinism and makes tests run more reliably. BUG=905266 Change-Id: I1350e5aa9d1c5571c2fd763f226c8282b8e5f955 Reviewed-on: https://chromium-review.googlesource.com/c/1405725Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#622090}
-
Nathan Parker authored
This lets us look just at known-advanced-protection users, so we can tell when there are real errors. This also lets us count those users. Once this hits stable I'll setup Chirp alerts on this. I also added tests for metrics. Bug: 919220 Change-Id: I44b0f17b129b565003fa58b43945034a949ca9c5 Reviewed-on: https://chromium-review.googlesource.com/c/1395835Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#622089}
-
Xiyuan Xia authored
- Add an ensureWindowServiceClientHasDrawnWindow method to check a Window Service client really paints on screen. - Add a chrome_content_browser_manifest_test_overlay.json that is only applied with --use-test-config switch so that the autotest API could make a mojo call to WindowServerTest. Bug: 908545 Change-Id: I72f9b64fa06b4acf8e7fb8440dd65375949ef3c7 Reviewed-on: https://chromium-review.googlesource.com/c/1406155Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#622088}
-
Mike Wasserman authored
ShelfWindowWatcher proactively adds shelf items for certain windows. Limit this experimental behavior to multi-process Mash. Avoids unwanted shelf items for select file dialogs in SingleProcessMash. Bug: 920714 Test: Select file dialogs do not get shelf items (except in multi-process Mash). Change-Id: Ic5986a837d040f9bb8c59c203c6de87375e9091f Reviewed-on: https://chromium-review.googlesource.com/c/1407081Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#622087}
-
Xiyuan Xia authored
Make WindowServerTestImpl::EnsureClientHasDrawnWindow capture output of the first ClientRoot window of the client and sanity check the captured pixels. The output is considered okay when there are more than 5 colors. Bug: 908545 Change-Id: Iaa2306da6e2b40b0cf9a8379e71f564b0cf92a8b Reviewed-on: https://chromium-review.googlesource.com/c/1406189Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#622086}
-