- 21 Feb, 2019 40 commits
-
-
Jazz Xu authored
Bug: 909963 Change-Id: I5c443e1cd33d9ff88136904de9695b3aa12a58f6 Reviewed-on: https://chromium-review.googlesource.com/c/1481620Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634368}
-
Raul Tambre authored
Bug: 879657 Change-Id: Iefd2f8c923d08b6d0a25ba4aa4fad3f2716ea574 Reviewed-on: https://chromium-review.googlesource.com/c/1481323Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#634367}
-
Alex Ilin authored
AutocompleteActionPredictor database can grow infinitely during a single browsing session. The memlog bot reports that the database can reach up to 20M in size. This CL limits the maximum number of rows that the database can contain. Whenever a newly added element makes the database exceed this limit, one element with the lowest confidence score is removed. Extra rows are also removed when the database is read from a disk. Bug: 854665 Change-Id: Ic6faf8c135c83c0a873b4eef1760c035c385594e Reviewed-on: https://chromium-review.googlesource.com/c/1480461 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#634366}
-
Justin Cohen authored
Bug: 934294 Change-Id: I34eac982df5e4ce23a7e748debe9b118cd88afb4 Reviewed-on: https://chromium-review.googlesource.com/c/1481491 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#634365}
-
Henrique Ferreiro authored
Replace uses of SnapSelectionStragegy from third_party/blink/renderer/platform/scroll_snap_data.h with the unwrapped type from cc/input/scroll_snap_data.h. This is part of a series of CLs to remove platform/scroll. Bug: 922111 Change-Id: Icb63605c2f4aeabf486b7080220b45afc23faa30 Reviewed-on: https://chromium-review.googlesource.com/c/1479967Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#634364}
-
Eric Roman authored
Bug: 932907 Change-Id: I452a014dad0fdc002d4cd96c8f21f7c2ce11a553 Reviewed-on: https://chromium-review.googlesource.com/c/1480551 Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#634363}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/0eee33250ebb..3fc635ac4a7f git log 0eee33250ebb..3fc635ac4a7f --date=short --no-merges --format='%ad %ae %s' 2019-02-21 bclayton@google.com GLES: Fix race in Renderer destruction Created with: gclient setdep -r src/third_party/swiftshader@3fc635ac4a7f The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/124288179 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I6f217308e01522f9e5582b72d8231e485b8681cc Reviewed-on: https://chromium-review.googlesource.com/c/1480988Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634362}
-
Ryan Sturm authored
Optimization guide is used for all profiles on chromeOS, so browser tests should check the per-profile state rather than a histogram that spans multiple profiles. Bug: 932913 Change-Id: I2a8aa5e3c70ad59b8924f83173454fccc6bc27fa Reviewed-on: https://chromium-review.googlesource.com/c/1477879 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#634361}
-
Fredrik Söderquist authored
f6e075c5 removed the only real usage of this flag. Remove the flag and clean up. Also avoids setting SetCompositingReasonsChanged when the flag changes. Bug: 812166 Change-Id: Id4d204db83117feafeb92baa765988952cdb7af3 Reviewed-on: https://chromium-review.googlesource.com/c/1480004 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#634360}
-
Ian Prest authored
1. Added `BrowserAccessibilityManagerWin::FireUiaAccessibilityEvent`. -- New function, modelled on `FireWinAccessibilityEvent`. -- Both functions now examine the experimental UIA flag. 2. Fire the `UIA_AutomationFocusChangedEventId` event when appropriate. 3. Refactored the test "pass" logic in `DumpAccessibilityTestBase` to run a test pass for each tree-formatter factory method that is returned by `AccessibilityEventRecorder::GetTestPasses`. -- This allows each platform to run a different set of test passes. 4. Added a third pass for tests on Windows to test UIA. -- They look for files with the "-expected-win-uia.txt" suffix. -- This allows us to provide expected results for UIA events separately from MSAA events. 5. All existing Windows/MSAA tests that had `EVENT_OBJECT_FOCUS` events were enabled for the new UIA pass. -- We'll enable the remaining tests as more UIA events are added. 6. Since you can't simultaneously listen to both MSAA and UIA events, a new event-recorder `AccessibilityEventRecorderUia` was needed to record UIA events. -- Heavily based on existing class `AccessibilityEventRecorderWin`. Bug: 928949 Change-Id: Ic4fde227c8f5674a915c0d30eb05151f3250a704 Reviewed-on: https://chromium-review.googlesource.com/c/1474976 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#634359}
-
Daniel Murphy authored
This allows scopes to be used in the DeleteDatabase call, and cleans up some code in the IndexedDBDatabase class. The last part of the codebase that doesn't have locks before being used is the IndexedDBBackingStore::Initialize call. Since this happens on the opening of the database, this can probably use just the raw database + a WriteBatch. Bug: 862456 Change-Id: I89c79ec89a4450e21f1ee700b007ec867b3a4f48 Reviewed-on: https://chromium-review.googlesource.com/c/1478391 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#634358}
-
Benjamin Shaya authored
Bug: 124534506 Test: cplay Change-Id: I512e2b6d2f43d56c13d0dcf1dcf5d63778156135 Reviewed-on: https://chromium-review.googlesource.com/c/1479303 Commit-Queue: Benjamin Shaya <bshaya@chromium.org> Auto-Submit: Benjamin Shaya <bshaya@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#634357}
-
Dmitry Gozman authored
This CL introduces DidStartNavigation and ReadyToCommitNavigation to replace DidStartProvisionalLoad. The focus here is to split two entirely different signals and stop passing fake DocumentLoader to DidStartProvisionalLoad. Unfortunately, this leaves us in an intermediate state, but addressing all the issues at once is pretty hard and will be easier after some other cleanups land. 1. For browser-initiated navigation, when it comes to the renderer, we immediately commit. The old flow: DidStartProvisionalLoad -> DidCommitProvisionalLoad. The new flow: DidStartNavigation -> ReadyToCommitNavigation -> DidCommitProvisionalLoad. 2. For renderer-initiated navigation, we issue a request from the renderer process to the browser process to begin navgation, and then follow up with commit coming from the browser to the renderer. The old flow: DidStartProvisionalLoad (with a fake DocumentLoader) -> browser process does something -> DidStartProvisionalLoad (with a real DocumentLoader) -> DidCommitProvisionalLoad. The new flow: DidStartNavigation -> browser process does something -> ReadyToCommitNavigation -> DidCommitProvisionalLoad. See https://docs.google.com/document/d/1eCcUmWMUkIeCgieIxFA_T7UkML-V3mzwT2yu26Q-PX4/view for motivation. This also corresponds to the step 14 from the doc linked in the bug. TBR=nyquist@chromium.org Bug: 855189 Change-Id: I830c5317bf7f58db35589488efb2cb1b47c50b8a Reviewed-on: https://chromium-review.googlesource.com/c/1427442 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#634356}
-
Roberto Carrillo authored
This change passes the LLVM_PROFILE_FILE var from the test_runner environment down to the environment inside the VM where actual test is run. The location is set to /tmp inside the VM, where the test can write to, and passed to the test runner for extracting the data out into the results directory (which should be included in the isolated output IIUC) R=liaoyuke,stgao,jbudorick BUG=934059 Change-Id: Id85f54120355176925cc39ce52947fcfe83c2e62 Reviewed-on: https://chromium-review.googlesource.com/c/1480552 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#634355}
-
Alex Clarke authored
Previously this API behaved differently depending on whether mock time was used or not. If mock time was used, it only returned false if there where no pending tasks at all. If mock time wasn't used it returned false if there where no tasks to run now. This is confusing so we replaced it with MainThreadHasPendingTask which checks if there are any tasks to run now. We also fix a problem with ~TestBrowserThreadBundle which was flaking if CHECK(!MainThreadHasPendingTask()) if a delay expired between the last RunUntilIdle() and it. TBR=mfoltz@chromium.org, rouslan@chromium.org, bajones@chromium.org, bnc@chromium.org Bug: 925315 Change-Id: I664615b43882f94126309e1355f5045305bd02c1 Reviewed-on: https://chromium-review.googlesource.com/c/1454363 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#634354}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/04097a34d39e..a5230e24c600 git log 04097a34d39e..a5230e24c600 --date=short --no-merges --format='%ad %ae %s' 2019-02-21 rycsmith@google.com Select/deselect and isIndexSelected for Comboboxes and Listboxes. 2019-02-21 thestig@chromium.org Add more checks to ValidateDecoderPipeline(). 2019-02-21 thestig@chromium.org Validate filters in CPDF_DIBBase::LoadColorInfo(). Created with: gclient setdep -r src/third_party/pdfium@a5230e24c600 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/124253371 TBR=dsinclair@chromium.org Change-Id: Ib6f2df8e0b91b2b439b7dee279fceca4731eb255 Reviewed-on: https://chromium-review.googlesource.com/c/1480983Reviewed-by:
-
Devlin Cronin authored
Since URLPattern::Contains() now properly checks schemes, checking whether an extension had the <all_urls> permission through the permissions API began failing if the extension didn't have file access. This is because the permissions API, for contains(), unpacked the permissions as if the extension had file access. This then meant that checking against active permissions would indicate the extension didn't have permission if it didn't have file access. Fix this by instead always parsing file:-scheme patterns (always including URLPattern::SCHEME_FILE as a valid scheme), but removing it from the valid schemes for <all_urls> patterns if the extension doesn't have file access. For patterns that explicitly specify the file:-scheme, populate them in a new group of |restricted_file_scheme_patterns|. This also lets us trivially fix an oddity in the permissions.request() function, where requesting a file:-scheme pattern would fail with the message "Invalid value for origin pattern file:///Invalid scheme.: *" if the extension didn't have file access. Add unit tests for the API behavior as well as the changes to permissions_api_helpers. Bug: 931816, 932703 Change-Id: I891d7aae5042cdb58d24fd7ef2d19f919a893228 Reviewed-on: https://chromium-review.googlesource.com/c/1475805 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#634352}
-
Sergey Ulanov authored
The following tests will run on all fuchsia FYI bots: blink_common_unittests, blink_heap_unittests, blink_platform_unittests Bug: 821951 Change-Id: Ife49c41157727230bb9e0378957b6df75323fe03 Reviewed-on: https://chromium-review.googlesource.com/c/1444703Reviewed-by:
-
Jia authored
Bug: 931149 Change-Id: I2b5007ad211eeb785091662257f34fa1ce89f44f Reviewed-on: https://chromium-review.googlesource.com/c/1480307Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#634350}
-
Oystein Eftevaag authored
The large buffer size is causing flakiness on memory_top10_mobile webview perf bots, and should no longer be necessary given other recent improvements like always adding trace metadata at the end of the trace R=eseckler@chromium.org,ssid@chromium.org,perezju@chromium.org Bug: 929802,929793 Change-Id: I71f8421bacce1f1d785f8553f8d8e0d54db3d4ee Reviewed-on: https://chromium-review.googlesource.com/c/1481612Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#634349}
-
Natalie Chouinard authored
This internals page is used to surface debugging information useful to developers of the NTP Interest Feed. The first set of properties being added here display whether the new Interest Feed is enabled, some user classifier information (type of user, frequency of usage), and provide the ability to easily clear the current user classification. https://screenshot.googleplex.com/FY6F7zhx0ur Bug: 913126 Change-Id: I6cebc1b3f217677bd184ed7eba7f68793cd26091 Reviewed-on: https://chromium-review.googlesource.com/c/1478174Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#634348}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb774460bda0..689da99593bd Created with: gclient setdep -r src-internal@689da99593bd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:790088,chromium:790095,chromium:790105,chromium:790115 TBR=mmoss@chromium.org Change-Id: Iaeba6681c45298e785b83dcbf88c8b8813a93e91 Reviewed-on: https://chromium-review.googlesource.com/c/1480986Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634347}
-
Brian Sheedy authored
This reverts commit c9078153. Reason for revert: Cause of https://crbug.com/934351 Original change's description: > Hide URL from lookalike URL warning interstitial. > > This CL adds support for hiding of URLs in the omnibox by security > interstitials so as to enable it for the lookalike URL interstitial. > > Bug: 927924 > Change-Id: I2a7c7311480d6626d2ef27572e326c0a473dc20b > Reviewed-on: https://chromium-review.googlesource.com/c/1478358 > Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Carlos IL <carlosil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634067} TBR=msw@chromium.org,carlosil@chromium.org,jdeblasio@chromium.org Change-Id: Ibe82a239db4be9f799187dff4b1d321461cb784e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927924 Reviewed-on: https://chromium-review.googlesource.com/c/1480718Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#634346}
-
James Zern authored
https://chromium.googlesource.com/webm/libwebm.git/+log/e4931ebc0a81..51ca718c3adf $ git log e4931ebc0..51ca718c3 --date=short --no-merges --format='%ad %ae %s' 2019-01-24 johannkoenig add declaration for SerializeFloat 2018-12-11 jzern mkvparser/mkvparser.h: remove stray semicolon 2018-11-18 ccawley2011 Fix compilation with MinGW32 2018-11-20 angiebird Fix a potential memory leak in mkvparser.cc Created with: roll-dep src/third_party/libwebm/source Bug: 926235 Change-Id: Ia528e9dbf526c9accaf3131531442a247eea03cc Reviewed-on: https://chromium-review.googlesource.com/c/1481718 Commit-Queue: James Zern <jzern@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#634345}
-
Kyle Milka authored
Add presubmit that checks for changes to local_ntp.html that don't also include changes to local_ntp_browsertest.html. Bug: None Change-Id: I5ab07a46800d4a9fdac2fd7978fe250a4a0bdf22 Reviewed-on: https://chromium-review.googlesource.com/c/1477769 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634344}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/56006dcf659d..fda0617505c1 git log 56006dcf659d..fda0617505c1 --date=short --no-merges --format='%ad %ae %s' 2019-02-21 cwallez@chromium.org DawnTest: Print system configuration on env SetUp 2019-02-21 cwallez@chromium.org DawnTest: add a test environment to contain global data. 2019-02-21 cwallez@chromium.org Require a semicolon at the end of DAWN_INSTANTIATE_TEST 2019-02-21 thakis@chromium.org dawn: Remove semicolons. Created with: gclient setdep -r src/third_party/dawn@fda0617505c1 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:926235,chromium:926235 TBR=cwallez@chromium.org Change-Id: I70d367baab81efd54cc3387dc0b1c0620ebac858 Reviewed-on: https://chromium-review.googlesource.com/c/1480985Reviewed-by:
-
Raul Tambre authored
Bug: 879657 Change-Id: Ie4c19c8b9e004bd8303a5b61551a422885025370 Reviewed-on: https://chromium-review.googlesource.com/c/1481338 Commit-Queue: Raul Tambre <raul@tambre.ee> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
Tien Mai authored
- Created a global token handle validator that can check in the background if a token handles are still valid. The validator tries to only check token handles who's status has not been updated for a certain amount of time. - When setting the user array, don't create reauth credentials if user's token handle is still valid. This allows the user to simply enter their Windows password through the normal windows password credential if their token handle is valid. - If no internet is detected, then all user token handles are valid. - Created a new centralized singleton used to check if internet is available. This singleton can be overridden in tests to simulate loss of network. - Removed no longer necessary IGaiaCredentialProviderForTesting interface since the new internet check singleton can handle the testing cases. Bug: 923884 Change-Id: I02dff168786601b085b48e664b5e2de947fe853d Reviewed-on: https://chromium-review.googlesource.com/c/1475195Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#634341}
-
Lukasz Anforowicz authored
Bug: 734209 Change-Id: Ib3236c95249147f0cce7b3bcaafba3d92581f5a7 Reviewed-on: https://chromium-review.googlesource.com/c/1481531 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#634340}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/345810843bb0..0e784189b200 git log 345810843bb0..0e784189b200 --date=short --no-merges --format='%ad %ae %s' 2019-02-21 dgarrett@google.com workspace_stages: Download Android Symbols. Created with: gclient setdep -r src/third_party/chromite@0e784189b200 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I2a80f237eaf696633b89a8b7cd5db96516e05b4f Reviewed-on: https://chromium-review.googlesource.com/c/1480984Reviewed-by:
-
Sergey Ulanov authored
After crrev.com/632414 the test fonts were moved to the framework bundle, but the code was still trying to load them from Content Shell bundle. Bug: 928459 Change-Id: I7be6ce7bb3fe42c9e6ce64f31d61582e7661d00f Reviewed-on: https://chromium-review.googlesource.com/c/1481026Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634338}
-
Robert Liao authored
BUG= Change-Id: I4d5e408d9f861f177f2d2a9929331b036f7a1a13 Reviewed-on: https://chromium-review.googlesource.com/c/1481851 Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
-
Miguel Casas authored
This CL renames CanvasResourceProvider's ProduceFrame() to ProduceCanvasResource() to better reflect what it does. No functionality change intended, this is a mechanical substitution + git cl format. Bug: 920626 Change-Id: Id2e8d934793075c43fbacb0ee238d15fe8c0ec3d Reviewed-on: https://chromium-review.googlesource.com/c/1479940Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#634336}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/08573730b75a..962c222aa3be git log 08573730b75a..962c222aa3be --date=short --no-merges --format='%ad %ae %s' 2019-02-21 syoussefi@chromium.org Vulkan: Enable anisotropy feature when available Created with: gclient setdep -r src/third_party/angle@962c222aa3be The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ib75d1c0cbb9a889349660b33343b6d3cb525a616 Reviewed-on: https://chromium-review.googlesource.com/c/1480977Reviewed-by:
-
Majid Valipour authored
Previously it was possible for the AnimationWorkletMutatorDispatcherImpl::MutateSynchronously to wait indefinitely and hang if the worklet task runner didn't execute the posted mutation task. (I suspect this would happen if task is posted during the worklet thread shutdown process) In fact, this condition would occur occasionally when running our tests and causing the content_shell to hang and test to timeout which lead to the test flakiness. This fix ensures the done closure is guaranteed to run even when destination task runner drops it. This is achieved by using base::ScopedClosureRunner which runs the closure on destruction if not run already. TEST: Locally running the tests no longer produces the hang. TEST: AnimationWorkletMutatorDispatcherImplTest.DispatcherShouldNotHangWhenMutatorGoesAway Bug: 930462 Change-Id: Ie35ab9c2072d71c301d304b10e0cf15c3d6616da Reviewed-on: https://chromium-review.googlesource.com/c/1477960 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#634334}
-
Robbie McElrath authored
Bug: 920038 Change-Id: I577d9d497bc564b885a4a96ce5baf4f3326ce1a8 Reviewed-on: https://chromium-review.googlesource.com/c/1464069 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
-
Ben Pastene authored
chromeos-kevin-rel is a simplechrome bot running tests on kevin DUTs: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel This will enable chromium sheriff alerts for its 3 suites: all_tast_tests, sanity_test, and base_unittests. (That third might not be the most useful; could be removed.) I'll send out a PSA prior to landing. R=jbudorick, martiniss Bug: 866062 Change-Id: I3d8f853aacc41d1f381d18939a1b26b3ed4adbbb Reviewed-on: https://chromium-review.googlesource.com/c/1478117Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#634332}
-
rbpotter authored
To ensure all automated tests are run with both configurations until the migration is completed, change test suites to run with Polymer 1 instead of Polymer 2, now that Polymer 2 has been enabled by default for all OSes. Bug: 931434 Change-Id: I9a6cc87fdc4c761b35907fbe6ccdbc826ec45589 Reviewed-on: https://chromium-review.googlesource.com/c/1469297 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Ryan Hansberry authored
The original commit (crrev.com/c/1479941) was reverted (crrev.com/c/1480309) because of usage of unitialized memory. Specifically, the MockProximityMonitor object had been deleted but was then derefenced. Patch 1 is the original commit, Patch 2 is the fix. Original commit message: UnlockManager was previously holding onto a stale ProximityMonitor from its first connection. That meant that if a disconnection and subsequent new connection occurred, the old ProximityMonitor, with an old reference to the previous connection (represented as a ClientChannel object) was used. This always resulted in a Smart Lock failure for a second connection, and occasionally, a crash. In order to correctly reset the ProximityMonitor object, the way that it is called had to be refactored (remove completely unneeded ScreenLockBridge logic), in order to consolidate calls to one place. Bug: 931929 Change-Id: If8d7b48efe0055b8d0afc2f4cd3954114c0b7a71 Reviewed-on: https://chromium-review.googlesource.com/c/1481613Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#634330}
-
Saman Sami authored
A child should not be throttled if the parent is blocked on it. Otherwise the parent is guaranteed to hit the deadline, causing jank. Bug: 933610 Change-Id: Id4cc7bcf6d942a2413a63986e9f10377543fb089 Reviewed-on: https://chromium-review.googlesource.com/c/1479427Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#634329}
-
