- 06 Jan, 2020 40 commits
-
-
Kurt Horimoto authored
This class was unnecessary, as the same functionality can be implemented much more easily by observing OverlayPresenter from BadgeMediator, which acts as the InfobarBadgeTabHelper's delegate. This implementation will be added in a follow-up CL. This CL replaces the browser agent's instantiation with an infobar- specific BrowserAgent creation helper function that will set up BrowserAgents to handle the model-layer updates from overlay UI interaction events. Bug: 1030357 Change-Id: I4fa3f0c3afa6d0f747f0a7d3b9f5ee14dd43d4e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978623 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#728664}
-
Chris Mumford authored
WebGraphicsContext3DProvider::SetLostContextCallback already exlicitly uses base::RepeatingClosure so converting two overrides to do the same. Bug: 1007835 Change-Id: Id83a1067d9c555700b630deb75fe2b3d13c93d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988487Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#728663}
-
Joey Arhar authored
If a <button> element inside a <form> has a child element which is clicked, and the <button>'s onclick handler removes the child element from the DOM, the <button>'s default event handler which submits the form is never called. If this happens, and the <button>'s onclick handler also manually submits the form via form.submit(), then the form double-submit fix made in crrev.com/c/1850358 will prevent form.submit() from submitting the form because the form.submit() is blocked until the <button> gets the DOMActivate event, which never happens if the child element is removed from the DOM before it can emit the DOMActivate event to the parent <button>. This patch will submit the form in this case by listening to the click event instead of the DOMActivate event. If the click event is additionally preventDefault()ed, this patch will not cover that case. Once we switch back to async form submission in crbug.com/1013385 then all of the cases will be covered and this patch will be reverted. Bug: 1037740 Change-Id: I04cdff451b363b5fafa26d2c58ec0aa76ed95a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983547Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#728662}
-
Devlin Cronin authored
ExtensionIdSet is typedef'd to a std::set<ExtensionId>. Move the declaration from extension.h to extension_id.h, where the ExtensionId typedef is. Bug: 1038392 Tbr: vakh@chromium.org (micro change in extension_data_collection_unittest.cc) Change-Id: I98c4aa8285c67ac6c48cb372365f8b11700d1d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983192 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#728661}
-
Toby Huang authored
Child/Geller users currently cannot remove extensions with state BLOCKED or REQUIRE_APPROVAL because UserMayModifySettings() returns false. Make UserMayModifySettings() always return true so that child/ Geller users can remove installed extensions regardless of the state. Bug: 1033687,1032352 Change-Id: I4608c22099325578982e48b6da31840c124167d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969068 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#728660}
-
Dan Beam authored
R=dpapad@chromium.org Bug: 1038846 Change-Id: I72d5b46a6132d0e033a1236af57153cf6a7b603b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987134Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#728659}
-
Peng Huang authored
The tearing is because the displayed_image_->EndPresent() is called in wrong place. It should be called when the displayed_image_ is being replaced by a new image. Bug: 1036566 Change-Id: Ic12c41d0191e9ad62638f931bce03c9d44a31c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988687Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#728658}
-
Richard Knoll authored
Sharing.ClickToCallDialerPresent: Extended to M84 Sharing.ClickToCallHelpTextClicked: Obsolete Sharing.ClickToCallDialIntent: Replaced with ClickToCallDialerPresent Sharing.ClickToCallContextMenuPhoneNumberParsingDelay: Extended to M84 Bug: 1037598,1037286 Change-Id: Icbfee90db84403c43cdc2bbc6f73960a912939d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986802Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728657}
-
kylechar authored
This CL finishes removing code to handle submitting renderer CompositorFrames through content/browser/renderer_host/, primarily code left in RenderWidgetHostImpl. Also update RenderWidgetHostTest.FrameToken_* to not submit CompositorFrames. Bug: 812322, 766481 Change-Id: I9e6142a116da2cdf41ecb0d0b86cdaf5f479ce53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986784 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#728656}
-
Yusuf Sengul authored
Bug: 1039027 Change-Id: I3936986b390f414621df4d305b7ad8aa2f8bcbb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986057 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#728655}
-
Darwin Huang authored
As per Android documentation[1], Android clipboard formats should be referenced using MIME types. Update Chrome's Android clipboard formats to use MIME types, as opposed to shorter (but platform-specific) names. These formats are only really passed within Chrome clipboard code (through ClipboardFormatType, ClipboardAndroid, and ClipboardMap). This does also remove GetBookmarkType(), because as mentioned in ClipboardAndroid::WriteBookmark, this tends to actually write the URL spec. That said, ClipboardAndroid::ReadBookmark isn't implemented, so this has no real effect. This is primarily a refactoring change to simplify/consolidate code. No functional changes intended. [1]: https://developer.android.com/reference/android/content/ClipDescription.html#constants_2 Change-Id: If7008dd8ef5657f8bebf71d31f4f5cd246e753f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986243Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#728654}
-
Gabriel Marin authored
BUG=1036859,b:147113394 Change-Id: I10422d47e41057e1aca831cd7b65388f75d2fb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982185Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#728653}
-
danakj authored
Use OnceCallback where possible because the callback is only used once and RepeatingCallback and BindRepeating otherwise. Where a OnceCallback is conditionally consumed, pass it by pointer so that ownership is only moved when the callback will be run. R=alemate@chromium.org Bug: 1007659 Change-Id: I8174ce06a0937c2b9d54cfce45538c3b7a4f5bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967914 Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
ckitagawa authored
Introduces a public API for compositing of paint previews. This should complete the API surface required for implementers of the base service to both capture and playback paint previews. I intend to follow this up with a change that moves the parts that should be depended upon externally to a separate target in a public/ directory within components/paint_preview/browser/ Bug: 1030269 Change-Id: I9275ffc6e00267e84a2eaf60b1c07d65f6f4b053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966073 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#728651}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2478e62054cf..ba37867fd234 git log 2478e62054cf..ba37867fd234 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 dberris@chromium.org Catapult: Use x86-64 exclusively for Presubmit Created with: gclient setdep -r src/third_party/catapult@ba37867fd234 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1039167 Tbr: nuskos@google.com Change-Id: Ia1734ed97d9c02619225426f28b9f1e9e9b809be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988257 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728650}
-
Andrew Grieve authored
The version of apkanalyzer within android_sdk/tools/bin does not work with JDK11. This alpha package of cmdline-tools has a version that does. Bug: 1036426 Change-Id: I7a85300d243fc8ac2d2e79a9c5bd0b00c0956102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984667Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#728649}
-
Tommy Steimel authored
This reverts commit 34d462f6. Reason for revert: compile failure on tree: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/8162 Original change's description: > Add end-to-end tests for demographic metrics in UMA and UKM > > Bug: 992573 > Change-Id: I5a27682828538c72fbe8fc71c78cbadc8fdef23e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872643 > Commit-Queue: Roger McFarlane <rogerm@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728621} TBR=rogerm@chromium.org,asvitkine@chromium.org,vincb@google.com Change-Id: Ib04abc8549e152033951e13d140da9bd529446fd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 992573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988233Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#728648}
-
David Munro authored
Bug: None Test: Manual, check logs after failing to create a container Change-Id: I56d456878fe61156307c7060f844477efa8b330e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983693 Auto-Submit: David Munro <davidmunro@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#728647}
-
Daniel Murphy authored
IndexedDB now generates a lot more data during it's readwrite transactions during API calls like IDBFactory.deleteDatabase. The system is designed to clean this up over time, but there are possible worst- case scenarios where the amount of data being written outstrips the amount of data being compacted/deleted. This change makes it so all IndexedDB leveldb databases are compacted when the backing store is closed. This happens after the normal 2 second grace period. This should: 1) Make IndexedDB's size smaller for all users. 2) Make IndexedDB's performance and usage more consistent 3) Eliminate the case where uncompacted data from deleting databases is hogging up the disk. R=jsbell@chromium.org, pwnall@chromium.org Bug: 1035025 Change-Id: I893743ce0ad5e2b66c1c0ceb5f636b8b424a05c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972910Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#728646}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/32eff228855c..804ad6f18ad8 git log 32eff228855c..804ad6f18ad8 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 bookatz@google.com CtsPerfettoTestCases secondary_user Created with: gclient setdep -r src/third_party/perfetto@804ad6f18ad8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:141773058 Tbr: perfetto-bugs@google.com Change-Id: Ib6a39bea17d1a8df1c2816518c79507e60b2a7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988517Reviewed-by:
-
Bettina authored
Previously, placeholders for the saved password protection warning are reordered based off of commonly spoofed domains. This means that the placeholders may not be in the same order as the |saved_password_matching_domains|. This is the unit test for cr/1983352. Bug: 1038132 Change-Id: I5a2d7ee57508c72097631414fc12b4aa0fcc612e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986187 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#728644}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ce09fb43963c..6dbd7ff34a49 git log ce09fb43963c..6dbd7ff34a49 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 mtklein@google.com first foray into SkVM image shaders 2020-01-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-06 bsalomon@google.com Remove unused varying type param from GrGLSLShaderBuilder texture methods. 2020-01-06 brianosman@google.com Remove SkRuntimeShaderFactory 2020-01-06 robertphillips@google.com Add GrCompressedDimensions helper function 2020-01-06 csmartdalton@google.com Move "set_path_pt" from SampleAAGeometry into ToolUtils 2020-01-06 kjlubick@google.com [canvaskit] Remove support for T1 fonts and reduce code size 2020-01-06 kjlubick@google.com Make tracing data a compile-time option Created with: gclient setdep -r src/third_party/skia@6dbd7ff34a49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: I0e407dc41a6f98f7b2f12f0670e17fe23e68967d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988748Reviewed-by:
-
Daniel Murphy authored
This patch creates the IndexedDBControl mojo interface that is the eventual replacement for IndexedDBContext. It can be accessed on the StoragePartition, which handles binding it on the correct thread. This change also remove the IOTaskRunner() from the IndexedDBContext interface. Planning Doc: https://docs.google.com/document/d/18suNOOzuEJbqgRJF0MB2VqdTyYqS4cvI2PGaCpyPXSw/edit?ts=5de6dc30&pli=1#heading=h.k6qp3j6uiwi0 Bug: 1015214 Change-Id: If56fe06a7349d09325d1e2360b0ceb53e9c6e5fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959385Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#728642}
-
Ian Clelland authored
This test was previously disabled under some circumstances, but is also failing on the Win7 Tests (dbg)(1) bot (see https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29) Failing builds: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81051 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81064 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81067 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81069 Bug: 1039406 Change-Id: I1eb6e1733bc88d21acf377db50c679f6e3306194 TBR: jrummell@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988229Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#728641}
-
Renjie Tang authored
The histogram will be used once the third party QUIC code is merged into chromium. Change-Id: Iaf2fd34ca1b60935506d000e6699024bb640ca71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981638Reviewed-by:
-
Bruce Dawson authored
Change-Id: I1d6fb45ac8755c39cfebb7a00c3ad04f1d08c3ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986620 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#728639}
-
Hal Canary authored
Motivation: It is odd to define a Gr- prefixed function outside of third_party/skia. GrGLCreateNativeInterface exists in third_party/skia, and is deprecated. Change-Id: Icb20c390926c063c57d3cd84a9f1a4bfda2e171b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982620 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Auto-Submit: Hal Canary <halcanary@google.com> Cr-Commit-Position: refs/heads/master@{#728638}
-
Peter Kasting authored
Bug: none Change-Id: I6035f72ae4a4eccf815a9263f75fdfcd3ff342f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983513 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#728637}
-
Richard Knoll authored
After https://crrev.com/c/1592230 the relative path to the framework changed but this rpath was not updated. Bug: None Change-Id: I69b044c96a7eefb09534b62245545e20714b92ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986834Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728636}
-
Weilun Shi authored
Ensure that <histogram> should be added in <hisotgrams> and <histogram_suffixes> should be added in <histogram_suffixes_list> so that they will be sorted separately. Bug: 1034123 Change-Id: Iaf009dacf20a549f6e5865a4a699bb3919e96082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978539 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#728635}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/25b001799ea6..77e01616ea7b git log 25b001799ea6..77e01616ea7b --date=short --first-parent --format='%ad %ae %s' 2020-01-06 aerotwist@chromium.org Migrates refs to Common inside ui/ to ESM Created with: gclient setdep -r src/third_party/devtools-frontend/src@77e01616ea7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I89cf290b390a818d7439caff98e3337f7eb59fa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988254Reviewed-by:
-
Peter Kasting authored
Bug: 1033922 Change-Id: I8c8efc7cae25c2308d8f5289f3f124b0fa4782d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983539Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#728633}
-
Liquan (Max) Gu authored
Component: the toolbar of the Bottom-sheet based Payment Handler UI. Description: the toolbar instantiates a URI with a shortened (ripped off the scheme and keep only the origin) URL. However, the URI instantiation should take a URL that has a scheme, otherwise, throws URISyntaxException. This is an insidious bug because a domain url like "www.google.com:1234" wouldn't cause exception because it would be accepted as a scheme. Before change: when the toolbar takes a URL that is "IP + port" (no scheme), the Payment Handler UI would fail with a URISyntaxException. An example of url is "192.168.1.1:1234". After change: a URL "IP + port" (no scheme) wouldn't cause URISyntaxException any more. Change: after shortening a URI string, no longer instantiate a URI from the shortened string. Bug: 999196 Change-Id: If7cb8e0eff6bc24d973785f9d60b0e02666836e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988513Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#728632}
-
Antonio Rivera authored
This is the chromium side of the effort to consolidate TestMediaResourceTracker definitions. Currently there are two definitions: one in chromium, and one in the internal cast codebase. After this CL and an internal CL, there will be only one version (the chromium version). Test: Ran cast_media_unittests locally. Bug: b/143154455 Change-Id: I16d6a27679a395a0d4ae512cf29a7fe98e08af84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975071Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Antonio Rivera <antoniori@google.com> Cr-Commit-Position: refs/heads/master@{#728631}
-
Lijin Shen authored
Thouch menu_button_wrapper is big enough to meet the requirement of smallest touch size, it does not handle the click or touch events. The image button, which is handling the click event, inside the menu_button_wrapper is too small. Bug: 1038691 Change-Id: If1f6bd4e0dabdc238f9f1a37604b843cb60c360e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986251Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#728630}
-
Jonathan Ross authored
On Mac there is a race between the Browser resizing and a Renderer reconnecting to a frame sink. Due to this the Browser can end up sending a merge LocalSurfaceId to the Renderer, which it already used for a previous size. This is in part because on Mac we are currently accepting all resize requests from child Renderers. Which is not what we do on other platforms. This change updates BrowserCompositorViewMac to only merge LocalSurfaceIds, and to not change the sizes, when requested. Unless auto_resize is enabled on the RenderWidgetHostImpl. This is also inline with RenderWidgetHostViewMac::UpdateNSViewAndDisplayProperties TEST= ContextLost_WebGLContextLostFromGPUProcessExit ContextLost_WebGLUnblockedAfterUserInitiatedReload GpuCrash_GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash Bug: 1031095 Change-Id: Ie8ef6283ec36169f422af10831001b7c0ee757f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975014Reviewed-by:Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#728629}
-
Yilong Li authored
Scenic functions with C-style array arguments will be removed from SDK in favor of std::arrays. This change replaces all the C-style arrays used in Scenic SDK functions with std::array. Change in Fuchsia-review: https://fuchsia-review.googlesource.com/c/fuchsia/+/351051 TEST=Build on Fuchsia target; run_base_unittests Bug: fxb/SCN-1442 Change-Id: I2f828e7217258a71267295f4b26b735d29a9b103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986979 Commit-Queue: Yilong Li <liyl@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#728628}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7b0b7215. With Chromium commits locally applied on WPT: 400050e6 "Fix toJSON in WindowPerformance and PerformanceResourceTiming" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ic4739759f628638dffd27478a507d56365ee6620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988297Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728627}
-
Yuke Liao authored
This CL bumps the shard number for a few test targets because they're consistently timing out. Bug: 1036394 Change-Id: I6d5e1837dd45e942e3f3d14bee15b155917d7253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979105Reviewed-by:
-
Chris Mumford authored
SetCopyAudioCallback accepts an CopyAudioCB which is a RepeatingCallback so switching to using WTF::BindRepeating. Bug: 1007835 Change-Id: If2291c8217a4b2528e686f6f1350e53fc9224461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988505Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#728625}
-
