- 08 Jun, 2018 40 commits
-
-
Jun Choi authored
Make CTAP MakeCredential request be backwards compatible with U2F devices. Remove u2f_register.h file and migrate all U2F register logic to DeviceRegisterOperation under MakeCredential{Handler, Task} infrastructure. With this change, all input and output validation for MakeCredential and U2F Register request are moved from AuthenticatorImpl to MakeCredentialTask. Bug: 798573 Change-Id: I896a2cd0d119f9f63aaf4ab9eed16792d9c1f1bf Reviewed-on: https://chromium-review.googlesource.com/1027202 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:Antoine Labour <piman@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#565737}
-
Mark Pearson authored
TBR=chcunningham NOTRY=true Bug: 849979 Change-Id: Idcce1c5a044fb48001909ad48860ba1777bf8975 Reviewed-on: https://chromium-review.googlesource.com/1093469 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#565736}
-
Erik Chen authored
The mapping was added in https://codereview.chromium.org/3011002. There was no reason for it to use a character rather than a virtual keycode. After a recent refactor, this logic caused cmd + c to trigger IDC_DEV_TOOLS_INSPECT, since the shift key is ignored for character comparisons. Bug: 846893, 850895 Change-Id: Ic74e418bd9fa55eda90dd3bd55b10a456abce581 Reviewed-on: https://chromium-review.googlesource.com/1093301 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#565735}
-
Samuel Huang authored
This reverts commit a717720f. Reason for revert: Speculative revert to fix net_unittests failure for Mac bots. Original change's description: > Fix //ios/web_view/tools/build.py to reflect new build flags. > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I79b509fc63a011a8dcdfcf040ef694fc4a2170f8 > Reviewed-on: https://chromium-review.googlesource.com/1092074 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: John Wu <jzw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565691} TBR=eugenebut@chromium.org,jzw@chromium.org Change-Id: Ia5257e274d77be6f3582d972f0d56cd034a6f83b No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1093479Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#565734}
-
Mark Pearson authored
Mark four tests as disabled: virtual/threaded/http/tests/devtools/tracing/timeline-time/timeline-usertiming.js virtual/threaded/http/tests/devtools/tracing/timeline-paint/timeline-paint-and-multiple-style-invalidations.js http/tests/devtools/tracing/timeline-js/timeline-script-id.js due to flake here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/69598 virtual/threaded/http/tests/devtools/tracing/timeline-misc/ imeline-event-causes.js due to flake here: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/16773 NOTRY=true TBR=kozyatinskiy@chromium.org Bug: 850892 Change-Id: I6918161001cd3c4fd537476406d0ff66183096f4 Reviewed-on: https://chromium-review.googlesource.com/1093456 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Mark Pearson authored
Disables SingleClientDirectorySyncTest.DeleteDirectoryWhenCorrupted due to repeated flakes on Mac. TBR=treib Bug: 850980 Change-Id: I0906849dd03a2ce0a6fa007de10036519b502958 Reviewed-on: https://chromium-review.googlesource.com/1093548Reviewed-by:
-
Dave Tapuska authored
Microsoft has confirmed there are some issues with InputPane on earlier versions before RS4. BUG=817501 Change-Id: Ifa4557ecf479e10d619a6353e28c4f8eb3684867 Reviewed-on: https://chromium-review.googlesource.com/1093266Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#565731}
-
Kevin Marshall authored
Component manifests (*.cmx) are a new type of package metadata that will eventually consolidate most existing package metadata sources into one JSON file. Sandbox policies are now parsed by the cmx manifest parser. This CL migrates our sandbox policies from standalone files to inline CMX content. Change-Id: I4ac57a979811000d09eb90229ba5e97a03cb15be Reviewed-on: https://chromium-review.googlesource.com/1093396Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#565730}
-
Devlin Cronin authored
Remove the per-file histogram_tester OWNERS rules from //base/test/OWNERS, since histogram_tester* now lives in //base/test/metrics (which has a dedicated OWNERS file). Bug: 846421 Change-Id: I0d9a44379e48b8b5a50c242f13bba56b429d3020 Reviewed-on: https://chromium-review.googlesource.com/1091597 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#565729}
-
Xiaoqian Dai authored
In tablet mode, when a window is newly created, TabletModeWindowState will try to maximize it upon its creation. We should not do it for a window that's currently in tab-dragging process. The window will be maximized or snapped later by SplitViewController when the drag ends. See before: https://drive.google.com/open?id=1AcD3VG6C7aFXwdi1Cq3-RGvkg4U3K5ME and after: https://drive.google.com/open?id=1UoTIkeG50Bv0w0NQKWtEhbD3frfp7Vd8 Bug: 823769 Change-Id: I393fc57ef8cfe2c767512a5ad7a8f181bc36c835 Reviewed-on: https://chromium-review.googlesource.com/1089729 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#565728}
-
Samuel Huang authored
TBR=thestig@chromium.org NOTRY=true Bug: 851090 Change-Id: Ic7af45ee47f5beb60f2e919034619b11433822e5 Reviewed-on: https://chromium-review.googlesource.com/1093655 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c971895..eca23c3 git log c971895..eca23c3 --date=short --no-merges --format='%ad %ae %s' 2018-06-08 benjhayden@chromium.org Allow controlling dev dashboard version with environ variable. 2018-06-08 perezju@chromium.org [soundwave] Ensure API and DB are always initialized 2018-06-08 nednguyen@google.com Revert "Add deprecation message for grouping_keys" Created with: gclient setdep -r src/third_party/catapult@eca23c3 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849363 TBR=sullivan@chromium.org Change-Id: Id60e3bb0d986359efdd4252cce4f5ff9e583d839 Reviewed-on: https://chromium-review.googlesource.com/1093454Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565726}
-
Ryan Sturm authored
PLM tracks pages as new page main frame navigations, the page load capping infobar should match this behavior exactly to keep consistency between the two approaches. This may allow better understanding of what a page load actually is when the infobar is showing. Bug: 850988 Change-Id: I339f9000088731d807b4db973220c805cf4d3e3b Reviewed-on: https://chromium-review.googlesource.com/1093191 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#565725}
-
dpapad authored
These pages do not seem to be using that dependency, so it's unnecassary. This is in preparation of disallowing eval/Function for all WebUI pages that don't need it (and jstemplate_compiled.js implies that Function is needed). Pages affected: chrome://devices chrome://dom-distiller chrome://predictors chrome://webrtc-logs Also removing such dependency from the "Feedback" component extension. Bug: 525224 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I31728d2b3323f860c6b65455b0c72873981c4805 Reviewed-on: https://chromium-review.googlesource.com/1088157Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#565724}
-
Tommy C. Li authored
Previously they were 24x24. But in the new Material Refresh spec, they take up 32x24. Bug: 849779, 823535 Change-Id: Ie1f5dfe9e9f2ae88bcf07643fb6b33f6472bdcdf Reviewed-on: https://chromium-review.googlesource.com/1090073Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#565723}
-
Nico Weber authored
These bots used to be on FYI, but they're on the clang waterfall now (and also listed for that waterfall in waterfalls.pyl) Bug: 843511 Change-Id: I5ee01813e2701e1346edb05bbb5d3bae723b9b96 Reviewed-on: https://chromium-review.googlesource.com/1093555 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565722}
-
Jiaquan He authored
This commit: - removes some TODOs; - uses kGridIconDimension in ash/public/cpp/app_list/app_list_constants.h; - passes a trimmed query string over mojom for searching, since it's smaller and the raw query string in Chrome was only needed by search history, which has been removed. Bug: 733662 Change-Id: I2f8e7f5294079b4a9ac0141384502cc7dda1a806 Reviewed-on: https://chromium-review.googlesource.com/1093388 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#565721}
-
jdoerrie authored
This change partially reverts r550197 which introduced CHECKs to base::Optional's operator*, operator-> and value(). This is done to reduce binary size and to be more standard's compliant, as std::optional also doesn't perform checks for operator* and operator->. Lastly, the CHECKs in value() are kept, as here CHECKing is desired, and also matches std::optional's behaviour. Bug: 832678 Change-Id: I467c7d7623c2880ee761b8a58a74738c09e0ba2a Reviewed-on: https://chromium-review.googlesource.com/1093314Reviewed-by:
-
Sorin Jianu authored
This change introduces new error codes for these responses. Bug: 850720 Change-Id: I85462e964a573bf310b7b0ae5e9180e2e87eafdc Reviewed-on: https://chromium-review.googlesource.com/1091876Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565719}
-
Lei Tian authored
This CL fixes Browser Actions bugs includes: 1. Change download menu text to "Download link". 2. Fix flaky test. Bug: 773073, 831306 Change-Id: I4f2bc4d9288c2d96b7d878eb80ac0802e8065fe3 Reviewed-on: https://chromium-review.googlesource.com/1091875Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Lei Tian <ltian@chromium.org> Cr-Commit-Position: refs/heads/master@{#565718}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e4d73cb..7a01ce9 git log e4d73cb..7a01ce9 --date=short --no-merges --format='%ad %ae %s' 2018-06-08 tsepez@chromium.org Update fxjs/README now that context data slots are gone 2018-06-08 thestig@chromium.org Use FPDFText_GetBoundedText() to get the visible text in a test. 2018-06-08 thestig@chromium.org Consolidate repeated constants in FPDFTextEmbeddertest. Created with: gclient setdep -r src/third_party/pdfium@7a01ce9 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0a02663ad82b0e535c211aa2b792110edcf16b9a Reviewed-on: https://chromium-review.googlesource.com/1093274Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565717}
-
Xiaohan Wang authored
This allows KeySystemConfigSelectorTest to fully depend on the FakeKeySystems. Previously KeySystemConfigSelector calls CanUseAesDecryptor() which calls into KeySystemsImpl which makes the test really confusing. Bug: 727948 Change-Id: Id5536a142285034f1ec589758a171c70d3a77153 Reviewed-on: https://chromium-review.googlesource.com/1092412Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#565716}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8e6f58c..e05f18d git log 8e6f58c..e05f18d --date=short --no-merges --format='%ad %ae %s' 2018-06-08 ehmaldonado@chromium.org Reland "Reland "Expand variables in gclient flattened output."" Created with: gclient setdep -r src/third_party/depot_tools@e05f18d The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:848990 TBR=agable@chromium.org Change-Id: I348ead5c56b9fc1a54cc4b082d318d1d35bc7b21 Reviewed-on: https://chromium-review.googlesource.com/1093275Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565715}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6bfc16d6. With Chromium commits locally applied on WPT: e8832df8 "webrtc wpt: remove test_state_change_event" fbdd17fb "Improve RTCPeerConnection-setRemoteDescription-tracks.https.html tests." c220be7c "Fire RTCPeerConnection.onsignalingstatechange in the correct order." 4049f639 "[LayoutNG] Orthogonal flows need available inline size for min/max calculation." 69af6f38 "webrtc wpt: add cleanup to close peerconnections" ef28de47 "service worker: Add long timeout to registration-updateviacache.https.html." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19209 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: igrigorik@chromium.org, panicker@chromium.org: external/wpt/performance-timeline jsbell@chromium.org: external/wpt/resources panicker@chromium.org: external/wpt/user-timing TBR=foolip No-Export: true Change-Id: Icbf1e91867e9cc114a7dedaaa8b7b9eba52a053f Reviewed-on: https://chromium-review.googlesource.com/1093116 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#565714}
-
Xiangjun Zhang authored
Currently the media::AudioDeviceThread is always created with REALTIME_AUDIO thread priority. However, when calling from the new Mirroring Service running in a sandboxed utility process (coming in future CLs), the REALTIME_AUDIO priority is not allowed due to sandbox syscall restrictions. Also, since the input audio data is buffered, there is no need to use REALTIME_AUDIO thread for mirroring. This CL allows media::AudioDeviceThread to be created with requested thread priority. There should be no change to existing behavior. Bug: 850352 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id9e724b230e14c269f262c1c4c7e2b15ac08a57d Reviewed-on: https://chromium-review.googlesource.com/1090226 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#565713}
-
Paul Miller authored
Change-Id: Id4c60445a0e394abf2386339801b83b6e1533020 Reviewed-on: https://chromium-review.googlesource.com/1079696Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#565712}
-
Nico Weber authored
Looks like these waterfalls now exist in luci-milo.cfg, so this is now possible. - Remove no-longer-existing bots "Chromium Mac 10.11", "Chromium Mac 10.11 Force Mac Toolchain", "Chromium Win 10 GCE Tests" - "Chromium Win 10 GCE Tests" was the only bot using chromium_win_fyi_gtests, so remove that too (since the bot didn't exist, it wasn't used previously either), which in return was the only user of chrome_cleaner_gtests, so remove that too. - Fix case sensitivity misspellings: We're not consistent about if bots are called ASan (more common) or ASAN (less common, but present). - While here, also remove some remaining references to PGO from mb_config.pyl. Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1061597 Bug: 843511,820422 Change-Id: I70518fdedfab23c807afdcd8bb335a9aeacf09dc Reviewed-on: https://chromium-review.googlesource.com/1093159Reviewed-by:
-
David Roger authored
Bug: 850498 Change-Id: I304084db180fa729ceb5b6ec54e4c955fb4ae401 Reviewed-on: https://chromium-review.googlesource.com/1090838Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#565710}
-
Mustafa Emre Acer authored
U+10D5 (ვ), U+1012 (ဒ) => 3 Bug: 847242, 849398 Test: components_unittests --gtest_filter=*IDN* Change-Id: I9abb8560cf1c9e8e5e8d89980780b89461f7be52 Reviewed-on: https://chromium-review.googlesource.com/1091430Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#565709}
-
Tommy C. Li authored
This CL links many of the Omnibox OWNERS files together. It also specifically adds location_bar to the Omnibox team's ownership to lighten the review load on pkasting@. Bug: NONE Change-Id: I3b8b3a2e50dc2ad96d85e7b5fe02379b558e2bd0 Reviewed-on: https://chromium-review.googlesource.com/1091808 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#565708}
-
Xiaoqian Dai authored
A window's tab(s) should be able to be dragged out and dropped onto an eligible overview window item and merged into the overview window's tabs. See UI mock: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZQkoNXdY_I0T/files/MCHbtQVoQ2HCZU9_w4Gwefkm See recorded video: https://drive.google.com/open?id=1jLFN3Rv59uukVohOxIBsmeGQQolxUoxH From the UI mock, when a dragged window hovers over an overview window item, if the window is eligible to be merged into, a highlight indication will show up to indicate its selection; and when the dragged window hovers out it, the highlight indication will be hidden. The dragged window should not merge into the overview window during dragging, but should wait until the user drops the dragged window onto it (i.e., releases the mouse/tap). Thus TabDragController should defer attaching a dragged window to an overview window until the drag ends. Bug: 823769 Change-Id: I3b0e41d677d41231a4cd5382b33ccb4203351f19 Reviewed-on: https://chromium-review.googlesource.com/1065499 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#565707}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ed51a6e..2d61162 git log ed51a6e..2d61162 --date=short --no-merges --format='%ad %ae %s' 2018-06-08 jonasolsson@webrtc.org Remove stringstreams from media/sctp/ 2018-06-08 jonasolsson@webrtc.org remove unused stringstream import 2018-06-08 buildbot@webrtc.org Roll chromium_revision f9a24d5d..e9fcce49 (564886:565609) 2018-06-08 nisse@webrtc.org Add full stack test with link capacity of 150 kbit/s. 2018-06-08 danilchap@webrtc.org Revert "Move class VideoCodec from common_types.h to its own api header file." 2018-06-08 phoglund@webrtc.org Add R8 to DEPS. 2018-06-08 phoglund@webrtc.org Roll chromium_revision 42930fc8..f9a24d5d (564069:564886) 2018-06-08 nisse@webrtc.org Move class VideoCodec from common_types.h to its own api header file. 2018-06-08 magjed@webrtc.org Android: Add deprecation annotations to VideoRenderer and I420Frame 2018-06-08 kwiberg@webrtc.org Remove test AudioCodingModuleTest.TestAPI 2018-06-08 brandtr@webrtc.org Add simulcastStream output from VideoCodecTestFixture::Config::ToString. 2018-06-08 brandtr@webrtc.org Add bitrate_priority to GetSimulcastConfig call. 2018-06-07 ouj@fb.com Guard the android aaudio headers include with the aaudio preprocessor Created with: gclient setdep -r src/third_party/webrtc@2d61162 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7d04ce26471fcbe6804353f718059174ace44d30 Reviewed-on: https://chromium-review.googlesource.com/1092995Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565706}
-
Moe Ahmadi authored
Bug: 816941 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5fae03657bd3e05ed101b4b85c2904aa28b3611d Reviewed-on: https://chromium-review.googlesource.com/1089857Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#565705}
-
Kyle Horimoto authored
Bug: 824568, 752273 Change-Id: I7bafac91260e56b977caf89738931ad752115b73 Reviewed-on: https://chromium-review.googlesource.com/1093383Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#565704}
-
Tessa Nijssen authored
StatusBubbleViews now calls views::style::GetFont() instead of gfx::FontList(). This allows the passing of a TextContext, in this case CONTEXT_LABEL. When the context is passed on Mac, the font returned has a default size of 12pt. This is more consistent with Safari and other platforms. Since the system font on Mac (without user changes) returns 13pt font, this change now sets the StatusBubbleViews font size to 12pt on Mac. On other platforms, the default font size was already 12pt, so this change does not change the status bubble font size on non-Mac platforms. Bug: 834125 Change-Id: Ic1a9c5f728228341f18ddb41e36ea1e51078f95a Reviewed-on: https://chromium-review.googlesource.com/1079849 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
-
Mark Pearson authored
This reverts commit 73932db2. Reason for revert: caused failure in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/3347 failures: MSE_ExternalClearKey/EncryptedMediaTest.Playback_VideoOnly_MP4/0 [ RUN ] MSE_ExternalClearKey/EncryptedMediaTest.Playback_VideoOnly_MP4/0 [51235:2819:0608/103709.237938:WARNING:notification_platform_bridge_mac.mm(510)] AlertNotificationService: XPC connection invalidated. 2018-06-08 10:37:09.383 browser_tests[51235:780694] *** Owner supplied to -[NSTrackingArea initWithRect:options:owner:userInfo:] referenced a deallocating object. Tracking area behavior is undefined. Break on NSTrackingAreaDeallocatingOwnerError to debug. BrowserTestBase received signal: Terminated: 15. Backtrace: 0 browser_tests 0x000000010ea3aeac base::debug::StackTrace::StackTrace(unsigned long) + 28 1 browser_tests 0x000000010efd4b45 content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 229 2 libsystem_platform.dylib 0x00007fff51ad5f5a _sigtramp + 26 3 browser_tests 0x000000010e9b6c3f base::internal::IncomingTaskQueue::PostPendingTask(base::PendingTask*) + 111 4 CoreFoundation 0x00007fff29e9bdc5 __CFRunLoopServiceMachPort + 341 5 CoreFoundation 0x00007fff29e9b117 __CFRunLoopRun + 1783 6 CoreFoundation 0x00007fff29e9a787 CFRunLoopRunSpecific + 487 7 HIToolbox 0x00007fff291a7e26 RunCurrentEventLoopInMode + 286 8 HIToolbox 0x00007fff291a7b96 ReceiveNextEventCommon + 613 9 HIToolbox 0x00007fff291a7914 _BlockUntilNextEventMatchingListInModeWithFilter + 64 10 AppKit 0x00007fff27472f5f _DPSNextEvent + 2085 11 AppKit 0x00007fff27c08b4c -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044 12 browser_tests 0x000000010eae2920 __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke + 64 13 browser_tests 0x000000010e9ab94a base::mac::CallWithEHFrame(void () block_pointer) + 10 14 browser_tests 0x000000010eae2854 -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 164 15 AppKit 0x00007fff27467d6d -[NSApplication run] + 764 16 browser_tests 0x000000010e9bbc0c base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 364 17 browser_tests 0x000000010e9ba72e base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 110 18 browser_tests 0x000000010e9dee55 base::RunLoop::Run() + 53 19 browser_tests 0x000000010effa3b9 content::WindowedNotificationObserver::Wait() + 153 20 browser_tests 0x000000010efd5959 content::WaitForLoadStop(content::WebContents*) + 105 21 browser_tests 0x000000010ea70771 InProcessBrowserTest::PreRunTestOnMainThread() + 161 22 browser_tests 0x000000010efd4778 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 280 23 browser_tests 0x000000010eae8a45 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4341 24 browser_tests 0x000000010eae784e ChromeBrowserMainParts::PreMainMessageLoopRun() + 62 25 browser_tests 0x000000010d57f283 content::BrowserMainLoop::PreMainMessageLoopRun() + 67 26 browser_tests 0x000000010d96b377 content::StartupTaskRunner::RunAllTasksNow() + 39 27 browser_tests 0x000000010d57dccd content::BrowserMainLoop::CreateStartupTasks() + 813 28 browser_tests 0x000000010d581562 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) + 98 29 browser_tests 0x000000010d57bd4c content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) + 204 30 browser_tests 0x000000010e92fa77 content::ContentMainRunnerImpl::Run() + 615 31 browser_tests 0x000000011060dab5 service_manager::Main(service_manager::MainParams const&) + 2709 32 browser_tests 0x000000010e92ea74 content::ContentMain(content::ContentMainParams const&) + 68 33 browser_tests 0x000000010efd447b content::BrowserTestBase::SetUp() + 2571 34 browser_tests 0x000000010ea6f8d3 InProcessBrowserTest::SetUp() + 723 35 browser_tests 0x000000010ca9350d testing::Test::Run() + 109 36 browser_tests 0x000000010ca941a0 testing::TestInfo::Run() + 320 37 browser_tests 0x000000010ca94717 testing::TestCase::Run() + 279 38 browser_tests 0x000000010ca9fd87 testing::internal::UnitTestImpl::RunAllTests() + 871 39 browser_tests 0x000000010ca9f9fd testing::UnitTest::Run() + 109 40 browser_tests 0x000000010ea89786 base::TestSuite::Run() + 166 41 browser_tests 0x000000010e98b2f5 ChromeTestSuiteRunner::RunTestSuite(int, char**) + 37 42 browser_tests 0x000000010eff5f35 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) + 389 43 browser_tests 0x000000010e98b7db LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) + 347 44 browser_tests 0x000000010e98b26e main + 94 45 libdyld.dylib 0x00007fff51854115 start + 1 46 ??? 0x000000000000000a 0x0 + 10 Original change's description: > media: MediaBrowserTest not watching for plugin crash > > Now the CDM is not running in a plugin, there's no need for > MediaBrowserTest to watch for plugin crash. > > For the record, see the original CL that added this: > https://codereview.chromium.org/206693004 > > Bug: 772160 > Test: Remove obsolete code. No functionality change. > Change-Id: I8c0a9e74cc4c1d05b153f1e80a0882ee28287ac7 > Reviewed-on: https://chromium-review.googlesource.com/1091888 > Reviewed-by: Frank Liberato <liberato@chromium.org> > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565649} TBR=xhwang@chromium.org,liberato@chromium.org Change-Id: Ib80cd4be4d495c13f19196456ac621168acfa270 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 772160 Reviewed-on: https://chromium-review.googlesource.com/1093514Reviewed-by:
-
Martin Kreichgauer authored
Revert "chrome/installer/mac: set -x in sign_app and fix unquoted variable expansion" and "//chrome/installer/mac: add entitlements during code signing" This reverts commits a221822f and b69d8c48. Bug: 850890, 848052 Change-Id: I1b34c71d6522a051abc44a00b43b2466edffe51b Reviewed-on: https://chromium-review.googlesource.com/1093119Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
gogerald authored
Use case of this change is for payment request + payment handler (service worker): Users could enter into incognito mode and install a payment handler (service worker) there. Then go to a merchant website to buy with that payment handler, which will open a web page in custom tab to ask inputs. After that the opened web page should be able to find out the service worker to send back the result. So the registered payment handler (service worker) and opened web page must in the same browser context. Below is the test video record, https://drive.google.com/file/d/1CTFw9_-jCOvmV1fEMg8TZHd0inNKdPS2/view?usp=sharing Bug: 848245 Change-Id: Ice00df0b53c40a34108d84c8fa55d8160a03d6e2 Reviewed-on: https://chromium-review.googlesource.com/1080688 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
-
Robert Ogden authored
This CL adds a content description to the "Details" TextView header over the Data Usage Breakdown table. This content description describes what the current sorting scheme to users using TalkBack. Bug: 849395 Change-Id: I8328a5a41a37a55a532c5955777200df73a44f53 Reviewed-on: https://chromium-review.googlesource.com/1090072Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#565699}
-
sczs authored
- Adds a BlurEffect to the styler. - Makes NavigationBar translucent. Screenshot: https://drive.google.com/open?id=1wW2bL4AP3TusA64yPVgAyGMg4_hncVQT (The blue squares were added so the Visual effect is easier to see) Bug: 838580 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4e03b2dde5633716fbe131893433e6142abfa653 Reviewed-on: https://chromium-review.googlesource.com/1084321 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#565698}
-
