GitLab

BUG=231725
TEST=none

Review URL: https://codereview.chromium.org/14063011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194633 0039d316-1c4b-4281-b951-d872f2087c98

windows.h defines BEGIN_INTERFACE -- we need to undefine it before we redefine
it.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/13998024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194632 0039d316-1c4b-4281-b951-d872f2087c98

It is flaky on linux too. The failure tends to reproduce more often on linux
swarm slaves than linux_rel but this is really race-condition like.

TBR=jeremya@chromium.org
BUG=223467

Review URL: https://codereview.chromium.org/14329003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194631 0039d316-1c4b-4281-b951-d872f2087c98

My http://crrev.com/192493 caused a regression:
FindBarView doesn't select-all on tab-switch focus restoration.

Restore the FindBarView::SearchTextfieldView class with RestoreFocus override.
( this restores the previous select-all behavior to fix the regression )

BUG=232290
TEST=Switching back to a tab that had the find bar focused (from a tab that didn't have the find bar focused) restores find bar focus and selects the entire text content.
R=finnur@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/13976011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194630 0039d316-1c4b-4281-b951-d872f2087c98

This provides a replacement for the inner class of SerializedVar for serializing a PP_Var. It achieves 2 purposes: 1) it refactors the design of SerializedVar::Inner which was growing increasingly messy (and was going to become nastier) 2) it provides support for serializing/deserializing dictionary and array PP_Vars. To serialize a PP_Var, first the transitive closure of that var is computed (all nodes referenced) and then each var in the transitive closure is written to the message. Some trickiness arises from the fact that a PP_Var can be either a primitive or a reference and references have to be maintained when transmitting over the wire. The comments in the header files provide a description of the approach in more detail.

BUG=

Review URL: https://codereview.chromium.org/13887007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194629 0039d316-1c4b-4281-b951-d872f2087c98

Previously P2PSocketHostTcp was calling Write() even when another write is
pending.

BUG=232046

Review URL: https://codereview.chromium.org/13926013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194628 0039d316-1c4b-4281-b951-d872f2087c98

Serializing calls to getAuthToken will eliminate unnecessary calls to
GAIA and consolidate UI flows.

There is are two queues of requests for each (extension, scopes)
tuple, one for the non-interactive IssueToken flow and one for the
interactive prompt.

BUG=228908
(step #1 of the bug description)

Review URL: https://codereview.chromium.org/14270007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194627 0039d316-1c4b-4281-b951-d872f2087c98

R=enne
BUG=171734

Review URL: https://codereview.chromium.org/14299010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194626 0039d316-1c4b-4281-b951-d872f2087c98

This change puts the final signatures containing doubles in place so that
they can be used by Blink code. After this change lands Blink will be updated
to call these methods instead of the temporary xxxFloat() methods.

BUG=227156
TEST=All existing tests still pass. No user visible behavior has changed.

Review URL: https://codereview.chromium.org/13866046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194624 0039d316-1c4b-4281-b951-d872f2087c98

logged into (or has been logged into).
re-submission of https://codereview.chromium.org/13903018

Review URL: https://codereview.chromium.org/14065014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194622 0039d316-1c4b-4281-b951-d872f2087c98

This short fix in the deprecated bluetooth ChromeOS implementation
shows a trusted device (but not paired) as paired. This allows testing
the Verbatim mouse in the current implementation.

BUG=232145
TEST=Connect to a Verbatim device (connected but not paired). Device shows up in the settings list.

Review URL: https://codereview.chromium.org/14316006

Patch from Alex Deymo <deymo@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194621 0039d316-1c4b-4281-b951-d872f2087c98

With fixed include path.

TBR=cpu@chromium.org
BUG=225822

Review URL: https://codereview.chromium.org/14096011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194620 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/14328003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194619 0039d316-1c4b-4281-b951-d872f2087c98

> Pepper: Autogenerate thunk for PPB_URL_Loader.
> 
> This requires another annotation:
>   "always_set_output_parameters"
> 
> This annotation ensures that the thunk implementation will zero-out the value of all output parameters on failure.
> 
> Tested:
>   Built chrome and browser_tests.
> 
> BUG=
> 
> Review URL: https://codereview.chromium.org/14007010

TBR=teravest@chromium.org

Review URL: https://codereview.chromium.org/14195008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194617 0039d316-1c4b-4281-b951-d872f2087c98

In r174057, enne@ added support for implicit testing to scoped_ptr<>. Removes
these in chrome/browser/extensions/.

BUG=232084

Review URL: https://codereview.chromium.org/13949011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194616 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for stacking panels. The foreground panel windows will turn off the shadow while the background stack window will provider the shadow.

BUG=223155,177770
TEST=none due to no functionality change yet

Review URL: https://codereview.chromium.org/13853010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194615 0039d316-1c4b-4281-b951-d872f2087c98

This requires another annotation:
  "always_set_output_parameters"

This annotation ensures that the thunk implementation will zero-out the value of all output parameters on failure.

Tested:
  Built chrome and browser_tests.

BUG=

Review URL: https://codereview.chromium.org/14007010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194613 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Ran tests locally with the flag.

Review URL: https://codereview.chromium.org/14130017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194612 0039d316-1c4b-4281-b951-d872f2087c98

In r174057, ajwong@ added support for implicit testing to scoped_ptr<>. Removes
these in ash/.

BUG=232084

Review URL: https://codereview.chromium.org/14297013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194609 0039d316-1c4b-4281-b951-d872f2087c98

In r174057, ajwong@ added support for implicit testing to scoped_ptr<>. Removes
these in content/.

BUG=232084

Review URL: https://codereview.chromium.org/14081010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194608 0039d316-1c4b-4281-b951-d872f2087c98

BUG=227416
TEST=WebMParserTest.ZeroPaddedStrings

Review URL: https://codereview.chromium.org/14299005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194607 0039d316-1c4b-4281-b951-d872f2087c98

R=danakj@chromium.org
BUG=231458

Review URL: https://codereview.chromium.org/14269002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194606 0039d316-1c4b-4281-b951-d872f2087c98

The method is logically const, all callers are already const, and I
wanted to call this from a const method.

BUG=

Review URL: https://codereview.chromium.org/13945023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194605 0039d316-1c4b-4281-b951-d872f2087c98

Persists-across-all-workspace flag should not cause workspace switch when
showing a transient child of a maximized transient parent.

BUG=232119
TEST=Covered in a new test.

Review URL: https://codereview.chromium.org/13867010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194603 0039d316-1c4b-4281-b951-d872f2087c98

The CL turned out to be innocent, the bots turned green without the revert.

> Revert 194578 "Add ash SessionStateDelegate"
> 
> > Add ash SessionStateDelegate
> > 
> > This CL refactors the ShellDelegate by adding a SessionStateDelegate to
> > which methods dealing with the session state can be moved. This cleans up
> > the huge ShellDelegate interface and paves the way for further Chrome OS
> > multiprofile work which will need to add several new methods related to
> > the session state.
> > 
> > This CL is only the first step. Several other methods should also move to
> > SessionStateDelegate but I do not want to overburden a single CL.
> > 
> > BUG=None
> > TEST=Manual and browser/unit tests
> > 
> > TBR=sky (for c/b/idle_chromeos.cc and c/chrome_browser_ui.gypi)
> > 
> > Review URL: https://codereview.chromium.org/14295008
> 
> TBR=bartfab@google.com
> 
> Review URL: https://codereview.chromium.org/14200034

TBR=gavinp@chromium.org

Review URL: https://codereview.chromium.org/14200038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194602 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138275

Review URL: https://codereview.chromium.org/13445005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194601 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160311

Review URL: https://codereview.chromium.org/14321002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194600 0039d316-1c4b-4281-b951-d872f2087c98

An anchored widget is repositioned automatically when the top-of-window views bounds change.
This is useful to reposition the fullscreen exit bubble when the bookmark bar is shown / hidden.

Bug=188567
Test=ImmersiveModeControllerAshTest.AnchoredWidgets

Review URL: https://codereview.chromium.org/13866026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194599 0039d316-1c4b-4281-b951-d872f2087c98

Clean up the only presubmit error in the compositor bindings and
turn on cpplint warnings to prevent any future regressions.

Also, clean up cc's presubmit to match now that depot_tools has cpplint
in its input_api.

R=danakj@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/13949005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194598 0039d316-1c4b-4281-b951-d872f2087c98

Got linker error not caught by try servers.

> Make sure manifest specified shortcut for Extension Command can not override the built-in shortcuts.
> 
> User is still free to override manually.
> 
> BUG=226994
> TEST=Automated test included.
> 
> Review URL: https://codereview.chromium.org/13044014

TBR=finnur@chromium.org

Review URL: https://codereview.chromium.org/14096026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194597 0039d316-1c4b-4281-b951-d872f2087c98

When a part of the layer is visible, then it has a visible_content_rect which
is the best place to expand the prioritized rect from.

If no part of the layer is visible, we use the viewport rect in content space.
However, when the layer clips the viewport, this rect becomes enormous.
Currently the ExpandRectEquallyToAreaBoundedBy function "expands" the viewport
to cover the target area, but if the viewport is huge, it shrinks it instead.
When it shrinks to a rect far away from the layer, the layer is considered too
far from the viewport for prioritization.

Instead, we should only grow the viewport in content space, then intersect with
the tiling's content bounds (as before) to find an appropriate starting rect.

Tests:
PictureLayerTilingIteratorTest.TilesExistGiantViewport
PictureLayerTilingIteratorTest.TilesExistOutsideViewport
PictureLayerTilingIteratorTest.TilesExistLargeViewportAndLayerWithSmallVisibleArea
PictureLayerTilingIteratorTest.TilesExistLargeViewportAndLayerWithLargeVisibleArea

BUG=231521

Review URL: https://codereview.chromium.org/13895005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194596 0039d316-1c4b-4281-b951-d872f2087c98

We don't have this library in the WebView tree, and we don't want to
enable WebAudio on only ARM platforms for consistency reasons in any
case.

BUG=

Review URL: https://codereview.chromium.org/14324003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194595 0039d316-1c4b-4281-b951-d872f2087c98

Make sure manifest specified shortcut for Extension Command can not override the built-in shortcuts.

User is still free to override manually.

BUG=226994
TEST=Automated test included.

Review URL: https://codereview.chromium.org/13044014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194594 0039d316-1c4b-4281-b951-d872f2087c98

R=jam@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/14130007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194593 0039d316-1c4b-4281-b951-d872f2087c98

On Content Settings exceptions dialogs: Replace the placeholder text ("Add a new hostname pattern") of the input field used for adding new exceptions with a string containing a sample pattern ("[*.]example.com")

BUG=232378
TEST= (1) open chrome://settings/contentExceptions#cookies
  (2) Verify that the text in the input field is "[*.]example.com"

Review URL: https://codereview.chromium.org/13865003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194592 0039d316-1c4b-4281-b951-d872f2087c98

Upcoming work for multiple operations, CRC calculation, etc... have made the lifetime of the SimpleEntryImpl more tricky. By adding ref counting, asynchronous operations are guaranteed access to the entry after execution.

R=pasko@chromium.org,felipeg@chromium.org,rvargas@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/13880016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194591 0039d316-1c4b-4281-b951-d872f2087c98

> Add ash SessionStateDelegate
> 
> This CL refactors the ShellDelegate by adding a SessionStateDelegate to
> which methods dealing with the session state can be moved. This cleans up
> the huge ShellDelegate interface and paves the way for further Chrome OS
> multiprofile work which will need to add several new methods related to
> the session state.
> 
> This CL is only the first step. Several other methods should also move to
> SessionStateDelegate but I do not want to overburden a single CL.
> 
> BUG=None
> TEST=Manual and browser/unit tests
> 
> TBR=sky (for c/b/idle_chromeos.cc and c/chrome_browser_ui.gypi)
> 
> Review URL: https://codereview.chromium.org/14295008

TBR=bartfab@google.com

Review URL: https://codereview.chromium.org/14200034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194589 0039d316-1c4b-4281-b951-d872f2087c98

This pref will also be used by Chrome on Android and iOS,
in addition to ChromeOS.

BUG=226757

Review URL: https://codereview.chromium.org/14066011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194587 0039d316-1c4b-4281-b951-d872f2087c98

Due to a Blink bug (http://crbug.com/231830), the clear button in the
search field is not properly rendered if the <header> element has
its transform style property set to anything other than 'none'.

A simple workaround to make it render properly in 99% of cases is to
set the value of -webkit-transform to 'none' instead of 0px.

BUG=231291
TEST=Open chrome://history, type something in the search field, and
ensure that the clear button (a circle with a "X") is visible.

Review URL: https://codereview.chromium.org/14053006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194586 0039d316-1c4b-4281-b951-d872f2087c98

> Add a virtual keyboard webui at chrome://keyboard/
> 
> This is just the old virtual keyboard that was removed a couple of years
> ago, being used as a temporary stand-in.
> 
> BUG=222801
> 
> Review URL: https://codereview.chromium.org/13652010

TBR=bryeung@chromium.org

Review URL: https://codereview.chromium.org/14031009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194585 0039d316-1c4b-4281-b951-d872f2087c98