- 28 Jul, 2020 40 commits
-
-
Will Cassella authored
This CL converts base::Callback (and corresponding calls to base::Bind) to either base::OnceCallback or base::RepeatingCallback in chrome/browser/media. In general a base::OnceCallback is preferred since that's a stronger API guarantee, so that's been done where safe. Bug: 1007635 Change-Id: Ie3113c61db1ae43ce2e31c262f023d714f42dfc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321003 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#792380}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a58287b8ee08..7291750ae258 2020-07-28 ehmaldonado@google.com presubmit: Add dirmd_bin to CheckDirMetadataFormat. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1102997 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I1fa267030e6ddd5b2d79125215721590dab0511b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323765Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792379}
-
Richard Townsend authored
Corrects a problem with the inline assembly formatting on Windows (Clang's assembler behaves differently with line-breaks vs semi-colons on Windows than it does on other systems - was incorrectly squashing nops). It also ensures that the right number of instructions are skipped to avoid an instruction alignment crash when the linker's configured incorrectly. Bug: 1108769 Change-Id: I1f1f1ac7866c72d62068ad1db87f12c08204303c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320570Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#792378}
-
phillis authored
Moves |AppShimRegistry::OnAppInstalledForProfile| from AppShortcutManager observer pattern to |OsIntegrationManager::InstallOsHooks| Bug: 1098027 Change-Id: I102a787aeee35ebed401025eac7cbdd54177f3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311115Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#792377}
-
Yu-Hsuan Hsu authored
The change is related to CL:2291484. Add histogram information in histograms.xml to make the histogram visible on chromedashboard. BUG=b:160939695 Change-Id: Ic528934c18e0c3094e37cc16069c61bd5c931002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311983 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#792376}
-
bttk authored
Bug: 1109369 Change-Id: Ib1668e3de81d0da1c9c283ab925c21a6a92515fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318506 Reviewed-by: Ender
💬 =🕐 (ping me for faster reviews) <ender@google.com> Reviewed-by:Theresa <twellington@chromium.org> Commit-Queue: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#792375}
-
Will Cassella authored
This CL converts instances of base::Callback and base::Bind into base::OnceCallback/base::RepeatingCallback and base::BindOnce/ base::BindRepeating, as part of the Chrome code health project. In this case all of the `GenericDoneCallback` etc types were effectively OnceCallbacks, so this CL replaces them with that, as they're generally more efficient and provide more flexibility to the creator of the callback. Bug: 1007635 Change-Id: I63b70bc3e46497d979d5f524a533621ad824c0d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318004Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#792374}
-
Changwan Ryu authored
Bug: 1088548, 1088549 Change-Id: I186748bfc9d45b4142f13b962a74b74f9420371d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317766 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
Chris Lu authored
Creates DefaultBrowserPromoCoordinator, which will manage new DefaultBrowserPromoViewController to show the fullscreen promotion modal for users that may want to set Chromium as their default browser. Screenshot: https://drive.google.com/file/d/1wGlAB88CA-vokoBnolz59a4lvaFrKXfc/view?usp=sharing Bug: 1107489 Change-Id: Ia937bdbdb5bb275435dfe234a2019455b1ffdff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318687Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#792372}
-
Caleb Raitto authored
These IDs introduce variance in digest values for the same set of canvas 2D context operations. Also, add some unit test coverage that we were missing. Bug: 973801 Change-Id: I12728c5ab4dcd46b6a21bbcfbb18066652ebbf93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243731 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#792371}
-
Daniel Rubery authored
Based on UX feedback we don't want a "learn more" link in the dropdown, and there's nothing a user can do with these downloads since they have been blocked, so remove the dropdown entirely. Old screenshot: https://screenshot.googleplex.com/7r65OQPO7Xs.png New screenshot: https://screenshot.googleplex.com/TPkBgzZMDYT.png Fixed: 1069527 Change-Id: I81b7eee8399ef1ba3e5ec449bee6c6899b09db58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321329 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#792370}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/eede82b9b785..e7415a5b8712 $ git log eede82b9b..e7415a5b8 --date=short --no-merges --format='%ad %ae %s' 2020-07-27 haoyuewang Simplify the usage of ack_frequency and ack_delay in quic_received_packet_manager. flag protected by gfe2_reloadable_flag_quic_simplify_received_packet_manager_ack. 2020-07-27 wub In quicconnection, revert to a previously validated mtu after a delay equivalent to the duration of three ptos. protected by --gfe2_reloadable_flag_quic_revert_mtu_after_two_ptos. 2020-07-27 fayang Deprecate gfe2_reloadable_flag_quic_always_send_earliest_ack. 2020-07-27 bnc Update goaway behavior. protected by gfe2_reloadable_flag_quic_http3_goaway_new_behavior. 2020-07-24 nharper Replace reloadable quic_enable_tls_resumption flag with restart flag 2020-07-24 fayang Do not enforce push promise arrive in order in http3. client side only, not protected. 2020-07-24 fayang Surface hpack decoder detailed error for header value too long, and put detailed error to quic connection close error details. only change connection close error detail, not protected. 2020-07-24 haoyuewang Reserve a few connection options for using gfe measured bandwidth data in cwnd bootstrapping. no behavior change and not flag protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I8273dc56d706086ab271aba32932635e99a3f552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321850Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#792369}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I913d1d52eeff98eb989458bfc8b16eb189987620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323825Reviewed-by:
-
Albert Chaulk authored
Bug: b/158233592 Test: None Change-Id: I2cb9df2c01e15be5202a2d905c211490d916b814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257746 Auto-Submit: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#792367}
-
Vadim Bendebury authored
Let's keep collecting Platform.Cr50.BoardIdOfRlzMismatch, Platform.Cr50.FlashLog and Platform.Cr50.RlzOfBoardIdMismatch metrics for another year. Bring the FlashLog deadline in sync with the rest. BUG=chromium:1089267 TEST=none Change-Id: I8da92cd6b66846730c190ad191efcae4a3addf03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225459 Auto-Submit: Vadim Bendebury <vbendeb@chromium.org> Commit-Queue: Vadim Bendebury <vbendeb@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#792366}
-
Lukasz Anforowicz authored
This CL deduplicates ContentBrowserClient::WillCreateURLLoaderFactory and devtools_instrumentation::WillCreateURLLoaderFactory calls made by RenderFrameHostImpl from RenderFrameHostImpl::CommitNavigation (for |non_network_url_loader_factories_|) and from RenderFrameHostImpl::CreateNetworkServiceDefaultFactoryInternal. This deduplication will help in a follow-up CL that changes the lifetime of FileURLLoaderFactory and needs to add one more call to WillCreateURLLoaderFactory - see https://crrev.com/c/2305213/11. This CL ignores RFHI callers of ContentBrowserClient::WillCreateURLLoaderFactory that don't call into devtools_instrumentation (AppCache and WebUI). Omitting devtools_instrumentation from these callers is intentional (as discussed in the code review). Bug: 1106995 Change-Id: I9888a39f3a7169399e535b3c68eae6fc53610b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321538 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#792365}
-
Andrey Kosyakov authored
Change-Id: Iab48be6f9588bd1ce118892823323dfeae67abb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320996 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#792364}
-
Maria Kazinova authored
Previously the FieldDataManager data was not cleaned in time, and it was causing problems especially on interaction with pages retrieved from cash. Bug: 1109189 Change-Id: I8ec9707157d1fb90c38fd4cf931c6faff8d28513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322828Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#792363}
-
Brandon Wylie authored
Bug: 967960 Change-Id: I2fad7427977c15b19e914022cc6e4559be8e11e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303599Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#792362}
-
Adam Langley authored
This change defers ending the Activity until all the fragments of the reply have been sent. This _may_ help BLE reliability. BUG=1002262 Change-Id: I3434817cbd60e3f91eeced083772077731cbf74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310192 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#792361}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e8188f21..32344f5f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id3b29ffd603147f6084b7bd19285fb2b01971233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322947Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792360}
-
Frédéric Wang authored
Bug: None Change-Id: I5ef5990cfcf08aea0776f44365963719bd6a44e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323684 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792359}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0bb26390604e..24a53a05a52d 2020-07-28 dminor@webrtc.org Fix division by zero in I420Buffer::CropAndScaleFrom 2020-07-28 hbos@webrtc.org [Perfect Negotiation] Implement non-racy version of SetLocalDescription. 2020-07-28 sakal@webrtc.org Delete dead code from JNI audio header. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1071733 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7f2478c5f1258a935467101742f6bd5cb5f68f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323241Reviewed-by:
-
Adlai Holler authored
This is part of a larger effort to require users to provide powered-up GrDirectContexts when manipulating GPU images. See bug for details. Bug: skia:104662 Change-Id: I9e611b6ed3a665f706e7dbce490b0229186e8824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323135 Commit-Queue: Adlai Holler <adlai@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Auto-Submit: Adlai Holler <adlai@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#792357}
-
Changwan Ryu authored
These still provide valuable insights into how WebView is used, so extending the expiration dates of these metrics. Bug: 1089669, 1088548 Change-Id: I9a4aa46ed6099ac961de54346ac632a0b014f8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317708Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I13c1e728a5a62eeb29f45e878b5a969b4eb91e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322179Reviewed-by:
-
Mohamed Heikal authored
- Exposes material design's deps to be public so that the external version of material design could depend on its deps from //third_party/android_deps. - Replace all usages of the material design target to be a variable. TBR=just mechanical renaming of material design target Change-Id: I12e0e6f534aab3fdc0d5f868373f8687d3e41e8e Bug: 1110346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321748Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#792354}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/52d2563373fa..44bb4d7abee6 2020-07-28 jmadill@chromium.org D3D11: Fix bug with static vertex attributes. 2020-07-28 nguyenmh@google.com Adds sampler serialization capability 2020-07-28 syoussefi@chromium.org Vulkan: Fix sub invalidate marking render targets undefined 2020-07-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 361fb5311b9b to 171e04fac342 (8 revisions) 2020-07-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 8b5ed4448dfe to 150be20d4334 (33 revisions) 2020-07-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3b2cd31c7400 to 12c9d4ac61f2 (4 revisions) 2020-07-28 cclao@google.com Vulkan: Make staging buffer per context 2020-07-28 nguyenmh@google.com Serializes GL context states and reformats frame_capture_utils If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1107433 Tbr: tobine@google.com Change-Id: Ia736d2e43c9b1e899c60ef43009a33d17fdc9a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323762Reviewed-by:
-
Ben Pastene authored
Backlog of tasks is too large, we need to shed some load. Bypassing the CQ freeze to fix the CQ... sigh. TBR=martiniss No-Try: true Ignore-CQ-Freeze: true Bug: 1109999 Change-Id: Icea0bd75b11115cc44e8fe829f177951d3227eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324642Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#792352}
-
Anastasiia N authored
Currently GetInstance() has a DCHECK for the instance pointer and CreateInstance() overrides the current pointer, so there is no way to check if CreateInstance() was already called. We need to get a pointer to TestNetworkConnectionTracker in IdentityTestEnvironment. Since some tests create it (e.g. if they use TestingBrowserProcess) and others don't, we need a way to know if CreateInstance was called. Bug: 1068240 Change-Id: I99bb1dc64a170203beaae71d76de73d0b4483af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307249 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#792351}
-
Tommy Li authored
Fixes a layout bug with the suggestion button view, see the bug for screenshots. I'm not sure if this fixes all instances, but this fixes at least one. Bug: 1091354 Change-Id: I3e98c9f7ba6aeec24561ad377d6bde484a2fd12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321145 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#792350}
-
Devlin Cronin authored
ScriptContext::GetEffectiveDocumentURL() is used to 1) Classify javascript contexts (e.g., associating about:blank frames with an extension context), and 2) Determining an "effective" URL for script injection (to allow content scripts to run in about:blank frames if an extension has access to the parent). However, these have different traits. For instance, for case 1), we don't want to consider sandboxed frames (which cannot access their parent frames) - a sandboxed frame should not inherit its privileges. But for case 2), we want to consider sandboxed frames, so that content scripts can run in these. Split ScriptContext::GetEffectiveDocumentURL() into ScriptContext::GetEffectiveDocumentURLForContext() and ScriptContext::GetEffectiveDocumentURLForInjection() to account for these differences; this fixes an issue where scripts wouldn't correctly inject in sandboxed frames. Modify existing tests for both GetEffectiveDocumentURL() and injecting scripts in sandboxed frames. This also paves some more of the way to injecting in data: URLs. Bug: 1108505, 55084 Change-Id: I97707b7bba520f8177f59a4568971df543f69785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314810 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#792349}
-
Ian Clelland authored
Bug: 1062400 Change-Id: I787f4996c76946b53e67122672ef085036ee33c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323821Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#792348}
-
Avi Drissman authored
If another channel of Chromium is already default, don't ask to become default. This re-lands e2d335fb with a fix. Bug: 1109417 Change-Id: Ib0c699ebbbc15e0bb636f6d49ea6082c3208f423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323824Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792347}
-
Nnamdi Theodore Johnson-Kanu authored
References to assertNotReached() cause closure compilation to fail for code using JS modules. This CL removes these generated calls at the top of the files, and replace the calls serving as placeholders with empty implementations. Updates were generated using a script ./tools/json_schema_compiler/compiler.py \ chrome/common/extensions/api/quick_unlock_private.idl \ --root=. --generator=externs > \ third_party/closure_compiler/externs/quick_unlock_private.js python tools/json_schema_compiler/compiler.py \ chrome/common/extensions/api/quick_unlock_private.idl \ --root=. --generator=externs > \ third_party/closure_compiler/externs/quick_unlock_private.js Bug: 1045266 Change-Id: Ib4fa9a09a985e08eccc5834241f308b651efff6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314812Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#792346}
-
Dylan Cutler authored
last_access_time. Bug: None Change-Id: Ic3709bc975dac8d7ffa1bcba0451e92364433943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321348Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#792345}
-
Charlene Yan authored
Bug: 1110108 Change-Id: Ie23896b56983ec165180e4f02deddce7bdd9d735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321530 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#792344}
-
Matt Mueller authored
Bug: 1108632 Change-Id: Ia1ab7aaabe38f5c9d15fcb781768fae29b59c716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321555 Commit-Queue: Matt Mueller <mattm@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792343}
-
Evan Stade authored
Bug: 1007823 Change-Id: Ie9c7bb8db921ff4723dbb913c7010da3f0b90110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304721Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#792342}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a3b0adc306c5..150be20d4334 2020-07-28 andreperezmaselco.developer@gmail.com spirv-fuzz: Add condition to make functions livesafe (#3587) 2020-07-27 rharrison@google.com Rolling 4 dependencies (#3601) 2020-07-27 andreperezmaselco.developer@gmail.com spirv-fuzz: Implement the OpTranspose linear algebra case (#3589) 2020-07-27 rdb@users.noreply.github.com Fix SyntaxWarning in Python 3.8 (#3388) 2020-07-27 bclayton@google.com CMake: Enable building with BUILD_SHARED_LIBS=1 (#3490) 2020-07-27 dneto@google.com Avoid operand type range checks (#3379) 2020-07-27 jaebaek@google.com Preserve debug info in scalar replacement pass (#3461) 2020-07-27 pierremoreau@users.noreply.github.com Update OpenCL capabilities validation (#3149) 2020-07-27 stevenperron@google.com build(deps): bump lodash from 4.17.15 to 4.17.19 in /tools/sva (#3596) 2020-07-27 antonikarp@google.com spirv-fuzz: adds TransformationReplaceLoadStoreWithCopyMemory (#3586) 2020-07-27 jaebaek@google.com Preserve OpenCL.DebugInfo.100 through private-to-local pass (#3571) 2020-07-27 stefanomil@google.com spirv-fuzz: Relax type checking for int contants (#3573) 2020-07-27 stefanomil@google.com spirv-fuzz: Generalise transformation access chain (#3546) 2020-07-27 stefanomil@google.com spirv-fuzz: Split blocks starting with OpPhi before trying to outline (#3581) 2020-07-27 afdx@google.com spirv-fuzz: Set message consumer in replayer when shrinking (#3591) 2020-07-24 vasniktel@gmail.com spirv-fuzz: Don't use default parameters (#3583) 2020-07-23 rharrison@google.com Change DEPS rolling script to point at external/ (#3584) 2020-07-23 vasniktel@gmail.com spirv-fuzz: Create a helper in fuzzerutil to reuse function type (#3572) 2020-07-23 vasniktel@gmail.com spirv-fuzz: Test usages of IdIsIrrelevant fact (#3578) 2020-07-23 antonikarp@google.com spirv-fuzz: adds TransformationReplaceCopyMemoryWithLoadStore (#3575) 2020-07-23 antonikarp@google.com spirv-fuzz: adds TransformationReplaceCopyObjectWithStoreLoad (#3567) 2020-07-22 stevenperron@google.com Start SPIRV-Tools v2020.5 2020-07-22 stevenperron@google.com Finalize SPIRV-Tools v2020.4 2020-07-22 vasniktel@gmail.com spirv-fuzz: Fix usages of irrelevant constants (#3566) 2020-07-22 stevenperron@google.com Update CHANGES 2020-07-22 alanbaker@google.com Support SPV_KHR_terminate_invocation (#3568) 2020-07-22 stevenperron@google.com Sink pointer instructions in merge return (#3569) 2020-07-21 greg@lunarg.com Preserve OpenCL.DebugInfo.100 through elim-dead-code-aggressive (#3542) 2020-07-21 vasniktel@gmail.com spirv-fuzz: TransformationReplaceParamsWithStruct (#3455) 2020-07-21 38144211+vkushwaha-nv@users.noreply.github.com Add changes for SPV_EXT_shader_atomic_float (#3562) 2020-07-21 vasniktel@gmail.com spirv-fuzz: Use irrelevant constants (#3565) 2020-07-21 stefanomil@google.com spirv-fuzz: Extend TransformationRecordSynonymousConstants to allow composite constants (#3537) Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers from ac638f181542 to 979924c8bc83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,tobine@google.com Change-Id: I4409d7670e9ddcd4cec62cdaf945b69b10e4d4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322210Reviewed-by:
-
