- 20 Mar, 2020 40 commits
-
-
Wei-Yin Chen (陳威尹) authored
Bug: 930892 Change-Id: I85583fa6d0e6db62fb5519ed7d043870b47c9afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080925 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#751924}
-
Eugene Zemtsov authored
Previous CL removed hand made memory related UMAs for WMP. This CL uses the standard way to expose similar memory metrics. The only interesting part is where we change memory dump naming format from: media/webmediaplayer/player_%d/{video|audio} to media/webmediaplayer/{video|audio}/player_%d This is done in order to have readily available aggregating top level nodes where total video or audio memory consumption can be found. Bug: 1056839 Change-Id: Ibf8d57da47f54b90ff4e3fe207d351ee043aa41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109461 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#751923}
-
Eugene Zemtsov authored
According to Dale Curtis these metrics are not used and won't be missed. We should consider whitelisting media player memory dumps for background collection. Bug: 1056839 Change-Id: I46056dd24b8f54153849fb4181749b51a4fdf68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090972Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#751922}
-
rbpotter authored
Note: Currently SiteList test is disabled for flakiness. Re-enabled to test locally, and fixed a few consistent errors that likely appeared since the test was disabled. Did not observe any failures in 10 runs locally so will try to re-enable this test in a separate CL. Bug: 1026426 Change-Id: I72eead1d0fe4d70052ad7c1333a9c7b2ed104c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109410 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#751921}
-
Lei Zhang authored
Bug: 1062179 Change-Id: Icf81d6363d27f460d32f1ba7e03dabaece8f94eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107721 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#751920}
-
Victor Costan authored
Bug: 1062925 Change-Id: I075bd135bf334f511480bcdccd04e91f99ad54ea Tested: Compared old and new output on macOS 10.15.3, via DLOGs. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104102 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#751919}
-
Nicholas Hollingum authored
Bug: 1062860 Change-Id: I1d0d8281c01bc471b6c020513101738225110f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108408Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#751918}
-
Lei Zhang authored
Check in a .plist file since NSMutableDictionaries created in memory get sorted when written out to disk. Bug: 1062179 Change-Id: I4c8fd6876b138094855ae76dea982b040877aca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108001Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8fa0f9e0706b..c9453ffe96c1 Created with: gclient setdep -r src-internal@c9453ffe96c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I4feb60d805a6c9502e86bf49f0de58b74ad53aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111779Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751916}
-
Patrick Monette authored
Fixes PerProfileWorkerTaskTracker so that the WorkerTaskTracker is notified when there are outstanding tasks that are about to be deleted. Bug: 1060506 Change-Id: Ic81ad1557c1e27a8fc96fc079f7447efcc2ce7f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110350 Auto-Submit: Patrick Monette <pmonette@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#751915}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/c400416ee6a2..1618f0d88fdc $ git log c400416ee..1618f0d88 --date=short --no-merges --format='%ad %ae %s' 2020-03-19 bnc gfe-relnote: Ignore CANCEL_PUSH frames on the control stream. Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-03-18 fayang gfe-relnote: In QUIC, remove is_config_negotiated_ from QuicStreamIdManager. No functional change expected, not protected. 2020-03-18 quiche-dev Internal QUICHE change 2020-03-18 fayang Use 1-RTT instead of 0-RTT write key to send H3 SETTINGs in quic_spdy_stream_test. 2020-03-18 fayang Add a OnCoalescedPacketSent to QuicConnectionDebugVisitor. This will used for net-log in chromium. 2020-03-18 quiche-dev Add byte counters to the bonnet in addition to the existing packet counters. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=zhongyi@chromium.org Change-Id: I80ac216bf85943d28aaa91f665dc5b74f94daff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110174Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#751914}
-
Jason Lin authored
Some of the default tab menu items (e.g. reload, move to existing window) does not make sense or work well with the terminal SWA, so we want to remove them. This CL adds GetTabMenuModelFactory() to AppBrowserController to allow an app to specify the tab menu model that it wants. Before screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=438083&signed_aid=ucqPxHzsGWc98617EvvGUQ==&inline=1 After Screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=438084&signed_aid=R3gAlYCzETMUFNVq8NvAxw==&inline=1 Bug: 1060861 Change-Id: If1c318663690f2db637c31330299f95fb2b06ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105676Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#751913}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: Iaa7a05279f158dbdc332d4bb6ba9a683f9ea9c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112070Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751912}
-
Brian Sheedy authored
Switches the GPU Win10 Intel experimental bot to trigger tests on machins with driver 26.20.100.7870 to test the stability. TBR=ynovikov@chromium.org Bug: 1053803 Change-Id: I3fa8467656312288add0658a3e4b7dfb9c5ac2d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111470Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#751911}
-
Yoshifumi Inoue authored
This patch fixes hit test on position:relative inline element by changing |NGInlineCursor::PositionForPointInInlineBox()| and |LayoutInline::NodeAtPoint()| with descendants to pass assertions in following tests: - All/LayoutViewHitTestTest.HitTestHorizontal/* - All/LayoutViewHitTestTest.HitTestVerticalLR/* - All/ParameterizedLayoutInlineTest.MultilineRelativePositionedHitTest/1 This patch also changes |LayoutViewHitTestTest| class to check whether LayoutNG is enabled or disabled by |RuntimeEnabledFlag| instead of gTest's parameter for ease of working with |LayoutNGFragmentItem| runtime enabled feature. Note: Changes of |LayoutInline::NodeAtPoint()| is brought by http://crrev.com/c/2109575. Bug: 982194 Change-Id: I5d13542a2f57ca8ddd9dcf61a90f3ebbe4b2e0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104812 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#751910}
-
David Tseng authored
This test attempted to wait for "foo" (the initial window title to be correctly read), however, we were getting " 'Untitled - Chromium - User 1' properties={"category":"nav"}" read out instead. This may indicate some races in the population of the window title under heavy load. This wasn't the intent of the test though which covers only the reading of the title once it changes (from the initial value). Removing this first expectation makes the test run without flaking. Fixed: 1060001 Change-Id: I354f08c99299c315b980d15ab69fa11a0eddaa0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111275Reviewed-by:Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#751909}
-
Andrew Grieve authored
Bug: 1059928 Change-Id: I8b39bc87abfecea5cc9f43a9cdd9cea3a228eed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108925 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#751908}
-
Martin Kreichgauer authored
When handling makeCredential requests in the caBLEv2 authenticator, pass request arguments from the native side where they are unmarshaled over to the Java side, so they can be used to construct the GMSCore FIDO API request. When receiving a response from the FIDO API, pass response parameters back to native code where they are converted into a CTAP response. Both sides were previously using hard-coded fake data. Move CtapMakeCredentialRequest and CtapGetAssertionRequest parsing code out of VirtualCtap2Device so that caBLEv2 authenticator native code can reuse them. Add a Parse() factory method to AttestationObject because the native code needs to parse the CBOR Java response from Java in order to convert it into a CTAP message. Also switch native code to make use of //base/android JNI type conversion helpers throughout. Bug: 1002262 Change-Id: Ie24adec8c2b8f64e4330aa1fc4b3bf8a273617e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109037 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#751907}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d812d033..02c1ddad Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie034967a3f5f5c56c764256862d4ef1e0c96802b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111570Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751906}
-
Jing Wang authored
A bunch of nits were raised in https://crrev.com/c/2049013 post-commit, so making another change to fix them. Test: tested with Linux emulator. Bug: 1042084 Change-Id: I44d5835c21658e475dbba33c49a92c4b2e40d816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109573 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#751905}
-
Julie Jeongeun Kim authored
This CL fixes the assertion 'G_IS_OBJECT (object)' with an early return if AXPlatformNodeAuraLinux doesn't have AtkObject as GetOrCreateAtkObject() could return nullptr if AX mode is not enabled. It also updates |accessibility_mode_| from BrowserAccessibilityStateImpl using AddAccessibilityModeFlags instead of direct assigning since it should call NotifyAddAXModeFlags() together when the mode is updated to sync it with the mode from AXPlatformNodeAuraLinux. Bug: 1061429 Change-Id: I0b4fa09d8d788608a403383c9e2c6123c618ccc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103997Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#751904}
-
John Palmer authored
There was a small cut and paste mistake in the earlier CL. Also, actually make the feature available for the keyboard to query. Bug: 1046641 Change-Id: I9f4abdf48e0436b2f4feb7f56b4c5cf3e68f86b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105672 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Auto-Submit: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#751903}
-
Alex Gough authored
Confines the sharing service WebRTC helper in the union of utility and renderer sandboxes. Windows:- Adds win32k lockdown. Adds dynamic code disable. Linux:- Utility style seccomp with some calls removed. Mac:- Shortcuts to utility. Testing:- Manual test on each platform of large remote clipboard copy to/from unmodified Canary with all sharing flags enabled. Bug: 1045590 Change-Id: I72c1270c7db0dcce9e532ac97ad756fd22970574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051405Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#751902}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Ia715033aac447cd09ac11520d9c7c636e06a8b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111773 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#751901}
-
Frank Liberato authored
This CL adds |disable_dxva_video_decoder|, which turns off the DXVA VDA. In addition to refusing to instantiate one if the workaround is enabled, it also removes it from SupportedConfigs so that the renderer shouldn't bother to try. This CL also makes the D3D11VideoDecoder SupportedConfigs only show up if the decoder is enabled, so that the renderer doesn't try to instaniate one that will fail anyway. Bug: 625785 Change-Id: Ie9323049ce4263ea450127557e7ce20fec8e5625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106892Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#751900}
-
Demetrios Papadopoulos authored
Bug: 1026426 Change-Id: I9a155e796d3fd7cda5b569f90b9aff45678c8083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109314Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#751899}
-
Ahmed authored
This test verifies that when an editable element is focused within the page, top-chrome is forced-shown and is kept so until the element is blurred. The implementation of this behavior used the deprecated NotificationService for which we have now a replacement call in WebContentsObserver. This CL removes the use of the deprecated code. The flakiness in the test was due to a timing issue. In the cases when the test fails, I found that the generated fling events, cause gesture scrolling to be set to start and stop immediately in succession without generating any calls from the renderer to the browser to set the shown ratios. This was fixed by giving those events a chance to propagate, by waiting for at least 2 render frame submissions before generating the next one. With this fix, I ran the test with --gtest_repeat=40 and all instances passed. BUG=1049178 TEST=browser_tests --gtest_filter=TopControlsSlideControllerTest.*Editable* --test-launcher-bot-mode --gtest_repeat=40 Change-Id: I1ddfcfaf172e1fbcf1d6a851bb89ad051e1b8942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111064Reviewed-by:
-
Victor Costan authored
Bug: 1062925 Change-Id: I7210f4557595f2a310b7d6db717d7f23b1ea5077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109178 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Justin Miron authored
Reverts the blink/content renderer changes of https://crrev.com/c/1982622 as they break chromeos with --thinlto. The entire CL cannot be reverted due to a windows_archive_rel build breakage (crubg/1062857). Reverting the culprit portion as this is blocking chromeos uprev (crbug/1062006). Disables the browser side tests as the correct intersections will no longer be propagated. There are currently other consumers of the intersections. This will be relanded following fixing for chromeos --thinlto. BUG=1062006 Change-Id: I9f4eb13527a48965c1eed5613f26bc226fa971ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108343Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Justin Miron <justinmiron@google.com> Cr-Commit-Position: refs/heads/master@{#751896}
-
Tarun Bansal authored
Bug: 1037017,1037024,1052956 Change-Id: I778308ae01b3398ed877f1a82af32e3ae2967c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111754 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Auto-Submit: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#751895}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1058196 Change-Id: I90b37842d62e3be88864cf011a0aaea134f726a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086332 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#751894}
-
Johannes Henkel authored
This reverts commit d8d217c2. Reason for revert: Relanding original change with a fix, which I submitted upstream here: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2109466 New third_party/inspector_protocol revision: c69cdc36200992d21a17bf4e5c2f3a95b8860ddf Original change's description: > Revert "[DevTools] Roll inspector_protocol (Chromium)" > > This reverts commit c29bddc2. > > Reason for revert: this has broken exposeDevToolsProtocol somehow. > > Original change's description: > > [DevTools] Roll inspector_protocol (Chromium) > > > > Upstream PR: > > Introduce a crdtp/dispatch.{h,cc} library. > > https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1974680 > > > > New Rev: 8c2064ea99cffdb5647760ad3953c43e612e07fc > > > > Notable downstream changes: > > - ChromeDevToolsManagerDelegate::HandleCommand no longer carries > > a method. Reason being, the shallow parser (crdtp::Dispatchable) > > should be efficient enough to parse an incoming message a couple > > of times, e.g. once for the content layer and once for the > > embedder, and if we felt differently then we'd quite possibly > > want to carry more than just the method - e.g., we'd want to also > > pass the params. Anyway, for now simplifying this interface. > > - crdtp::FrontendChannel::FallThrough; here, it's advantagueous > > to keep the method around, but now it's a crdtp::span. This is > > much better than const std::string& because the generated code > > knows exactly which method is going to fall through and we > > can pass a C++ string literal via this span. > > - The crdtp/dispatch library presents a somewhat different surface > > between the UberDispatcher and the session implementations. > > The session implementations are responsible for creating a > > crdtp::Dispatchable instance (the shallow parser) which > > it then hands to the dispatcher for dispatching. Rather than > > querying for whether it can dispatch and then doing it, > > the result of the Dispatch indicates whether a method was > > found and can be executed. There's no more need to instantiate > > protocol::Value in a devtools session class. > > - Since the dispatch library uses crdtp::span to represent > > method names, we no longer need to reference platform specific > > routines for finding strings and making substrings. As a result, > > v8_inspector_string.h is losing a few more methods > > (and same for base_string_adapter_h.template). > > - crdtp::DispatchResponse (also known as protocol::Response) has > > some renames for consistency ( > > Response::Error -> Response::SeverError, > > Response::OK -> Response::Success). Touches all domain handlers > > but is mechanical. > > - All protocol error messages, such as the parameters passed > > to DispatchResponse::ServerError are required to be UTF8 strings, > > even for Blink, so when code generates them as WTF::String, > > we convert them to std::string using WTF::String::Utf8() > > before passing them to DispatchResponse::ServerError. > > - We're better about checking messages and sending errors when we > > can't parse them - esp. we no longer drop messages on the floor > > if we can't make sense of them; the LOG statements are gone, > > because we can either send an error or assume that we've > > previously parsed the message elsewhere and put a DCHECK (e.g., > > a message received by blink has always been shallow-parsed by the > > browser before). > > - DevToolsAgentHost::DispatchProtocolMessage no longer has a boolean > > return value. Reason being, it's not well defined what the > > boolean should indicate. If we reject the message and send > > an error, arguably we've also handled it. And of course, we > > always do that (now). So it's not useful to generate or check > > this return value, and there is only one DCHECK on it currently, > > which is also not covered by tests. > > - content::DevToolsSession uses binary searches to match method names > > (e.g. in ShouldSendOnIO). > > This is because I've switched the method names to span, and > > implemented similar searches for the dispatching library, so > > it's best to be consistent. It will also scale better if we add > > more methods. > > - The additional unittests added to the CRDTP library upstream cover > > shallow parsing, dispatching, etc. and are now also part of > > the content_unittests. > > - Improves Android binary size by about 36k, by reducing code > > duplication. There's now just one UberDispatcher, for example, > > as opposed to one for blink, one for content, one for headless, > > one for chromium, ... > > - Speeds up execution by 1-2% (based on internal measurements), > > because message serialization no longer takes a detour via > > protocol::Value. > > > > Change-Id: I422fe527d6f8a6ffb098b3992728ecba408b571f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047966 > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Reviewed-by: Ganggui Tang <gogerald@chromium.org> > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > Reviewed-by: Leonard Grey <lgrey@chromium.org> > > Commit-Queue: Johannes Henkel <johannes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#750284} > > TBR=dgozman@chromium.org,caseq@chromium.org,gogerald@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org > > Change-Id: I122738b9057cf6ab48b904a6ee0e67c7c9610b95 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103517 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750343} TBR=dgozman@chromium.org,caseq@chromium.org,gogerald@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org Change-Id: I5def0b19c3deb6516b52408e3a7c325b114c6edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111060 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#751893}
-
Hwanseung Lee authored
This is a reland of 4143ca0e Original change's description: > Clean up the AndroidSetupSearchEngine feature flag > > The AndroidSetupSearchEngine feature is enabled by default > and the config has no effect anymore. > Therefore, remove the config and every reference to > AndroidSetupSearchEngine. > > Bug: 1057939 > Change-Id: I5e395d7ed031d93b64d4ae9d012f72351b0dec22 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102032 > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> > Cr-Commit-Position: refs/heads/master@{#750834} Bug: 1057939 Change-Id: Ic39bb381f413d013729586a5c3c308679aa02c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108272Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Daniel Libby authored
Directly composited images is a feature that rasterizes images at their intrinsic size, when an image is the only thing drawn into a layer. However, this determination is today made prior to painting the image in blink, which can't be done with CompositeAfterPaint enabled. This CL adds support for detecting PictureLayers that qualify as directly composited images, by analyzing the paint ops of the display item list. If a single drawImageRect paint op is detected (with some facilities for detecting images for which orientation is respected), then we'll propagate the image's intrinsic size over to PictureLayerImpl on commit. PictureLayerImpl then uses that information to calculate a raster scale that results in the image being rasterized at its intrinsic size. There are a few additional changes needed outside that core calculation. If the aspect ratio of the layer bounds does not match the image's aspect ratio, we won't raster the image at the intrinsic size, but instead will choose the scale from one dimension. In these cases, we will choose to re-raster when the layer is resized until the layer bounds aspect ratio matches that of the image. If we do adjust the raster scale and add tilings to the active tree (as is seen in the default configuration for web_tests), we should drop the previous tilings (which are now non-ideal) since the max raster scale tile will be chosen when the SharedQuadState is created during AppendQuads. We also need to tell the LayerImpl if nearest neighbor should be used when the TileDrawQuad is scaled in the display compositor to preserve the same output of the original drawImageRect. Bug: 875110 Change-Id: I2cda143f483c2aa30a6ae1fb850e1c7ef1227882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036542Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751891}
-
Khushal authored
The transfer cache used to cache image uploads with OOP raster has an additional budget for these textures in addition to GrContext's budget. The budgeting is managed by ServiceTransferCache external to skia and these textures shouldn't be counted against GrContext's budget. R=bsalomon@google.com Bug: 936231 Change-Id: Ibd065aa75cda21fada019a9ded2811262c7bd85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108168 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#751890}
-
Noel Gordon authored
If the mouse/pointer/touch device is Pressed, adds a class to the root HTML element (and remove it when the device is released), to allow you to write CSS to prevent hover effects on inactive elements: html.pointer-active some-clickable-element:not(:active):hover { background-color: unset; } Bug: 1062902 Change-Id: I6bafc00b608f69ea35d61a8a9e77f22fb597a56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111810Reviewed-by:Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#751889}
-
Ayu Ishii authored
Bug: 1062668 Change-Id: I40137e8782a2456364271b62a39c5a10cac068c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111372 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#751888}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2f6e1e2b69e8..8fa0f9e0706b Created with: gclient setdep -r src-internal@8fa0f9e0706b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Id539e1c91f5dc667fa405bc3e89b92bdedb5675e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111590Reviewed-by:
-
Luciano Pacheco authored
This rule applies to file list and grid view. Bug: 1062207 Change-Id: I42c46b367ee50c4c409eb89a7e74aae80e564a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110831 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Dale Curtis authored
This wires up VP8 decoding through the same MFT we use for VP9 hardware decoding. The feature is default off. VP8 does not have color space information despite a comment in the spec saying its BT470NG. It does have range information though, so we indicate JPEG if full range. Bug: 1062849 Test: No intel hardware, so untested at present. Change-Id: Ia7006006f943c3dd1078f3a11ededa7e4b410c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109171Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#751885}
-
