- 17 Jul, 2019 40 commits
-
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Please review and LGTM before July 16th or the CL will be submitted as-is. TBR=sky@chromium.org NOTRY=true Bug: 977050 Change-Id: I931d31a5f716e469e52e85fdaa0ff9781febba00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700842Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#678275}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I12a0d472ab0bb37e77981f5059ad23ebb512e34f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703628Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#678274}
-
Antonio Gomes authored
There are some trailing includes, and also some forward declarations that can be removed. Drive by CL. BUG=704136 R=guidou@chromium.org Change-Id: I2cf0d2e9fcc0e273d759ba870718f87a5359e405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704719 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#678273}
-
Mike West authored
Spec change: https://github.com/whatwg/fetch/pull/916 Bug: 979946 Change-Id: Ic1cd8691c9b06371b94de29a5648fb6c8d7bebed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702311 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#678272}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: Ib8e79d7ab0748536e5a75a13153bcbc29039dabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702375Reviewed-by:
-
Sergey Poromov authored
DeviceLocalAccounts are supplied by |username| that is not a user email and can't be converted into AccountId. Because of that ValidateUser() can't be used and ValidateUsername() should be returned back that won't convert into AccountId. The same applies for component policy validations as they can belong to DeviceLocalAccount and also not have real username. This is an adapted partial "revert" of https://crrev.com/c/980873 and https://crrev.com/c/1003193. Before that ValidateUsername() existed and was used for all accounts. Bug: 983523 Change-Id: I11fab29bebd3770d6983206574595c2fab577cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698537 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#678270}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: Ifef1b1bb0ad29da61559db4e92a57cf982afbcd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703227Reviewed-by:
-
Dave Tapuska authored
It is obvious that even though the renderer has requested main frames the browser may not deliver it until a much later time. So we will definitely keep the raf fallback timer code. BUG=975271 Change-Id: I868bc32a7e95c59585dfa72fe3c56959979a17f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703092Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#678268}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/63fdd0191be0..e574f1e409aa git log 63fdd0191be0..e574f1e409aa --date=short --no-merges --format='%ad %ae %s' 2019-07-17 halcanary@google.com [reland] SkMetaData: move from src/ to tools/ Created with: gclient setdep -r src/third_party/skia@e574f1e409aa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=nifong@google.com Change-Id: Id4ef5dc90d78903ac3724fd12e36ceaed8b38fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706608Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678267}
-
Robbie Gibson authored
This does not change the color on the placeholder background + icon for when a suggestion has no image because that will be removed before dark mode is finished. Bug: 976641 Change-Id: I0bf0e26e7ce087917c38017d15a85c0a2ecbf6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706431 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#678266}
-
Yutaka Hirano authored
Discussion: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GF1Wg0JbEhw Bug: 983200 Change-Id: I27e02f2b195a93a7f2b0630af632ec0122581da9 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697481Reviewed-by:
-
Greg Thompson authored
external/wpt/referrer-policy/unsafe-url/http-rp/cross-origin/http-http/img-tag/no-redirect/generic.http.html and friends time out. BUG=982149 TBR=jochen@chromium.org Change-Id: I80773a464d18e243ece2f0677177ac32a5d13b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706501Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#678264}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2faec47d8d6a..45086ca6db84 Created with: gclient setdep -r src-internal@45086ca6db84 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=pdr@google.com,grt@google.com Change-Id: I8585d0f5ae07426f3ff6a76089cf5ea26b47974f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706389Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678263}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dcdb80df..aec429d1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I28e9b469cd9635866c3a9bb8431605128a0181c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706448Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678262}
-
Richard Knoll authored
This adds an icon in the omnibox via PageActionIconView. This is the ancher point of the Click to Call bubble dialog. Bug: 972059 Change-Id: I69aeb6bfcfd47082ad1a3460d58c2dd107746353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695551Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#678261}
-
Yi Gu authored
In the constructor of AggregatedHitTestRegion there is a DCHECK to verify that async_hit_test_reasons is set if and only if the kHitTestAsk flag is set [1]. This assertion stands for most cases but HitTestManagerFuzzer where we manually set the flag without setting async_hit_test_reasons. It was missed when introducing async_hit_test_reasons in crrev.com/c/1318078. [1] https://cs.chromium.org/chromium/src/components/viz/common/hit_test/aggregated_hit_test_region.h?q=AggregatedHitTestRegion&dr=CSs&l=48 Bug: 910872 Change-Id: I1d9e79e2583a0a180c8905ec4cf80d48bb1072f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705052Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#678260}
-
Javier Ernesto Flores Robles authored
Updates the close button for the tab grid, this is also used in the tab strip on iPads. Deletes the unused resolution @1x. Bug: 976817 Change-Id: I4144df5b4bf00bba65aff5919ed29e70f1e2f6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706688Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#678259}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a7fc7a353fbd..c182e466c1b0 git log a7fc7a353fbd..c182e466c1b0 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 treehugger-gerrit@google.com Merge "Remove stale comment." Created with: gclient setdep -r src/third_party/perfetto@c182e466c1b0 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I23b0e47f5fd17876606f895fa7be5f1fef54eab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706528Reviewed-by:
-
Emily Stark authored
This CL flips the HTTP auth committed interstitials feature flag to enabled by default, and adapts affected tests. The affected tests are password manager tests, and they mostly involve changing the tests to not rely on the navigation oddities of traditional interstitials. With committed interstitials, the navigation completes before the auth prompt shows, whereas with traditional interstitials, the tests didn't wait for the navigation to complete because it only completed after the auth prompt was dismissed. I've also fixed one bug revealed by these password manager tests, related to how the password manager (HttpAuthManagerImpl, in particular) decides when a password form is gone. Previously, HttpAuthManagerImpl assumed that a password form was gone when a navigation completed, but this is no longer the case because some error pages (including committed interstitials) show up as double-commits from the browser process's perspective. See comment inline in http_auth_manager_impl.cc. To fix this, we have the LoginHandler explicitly tell HttpAuthManagerImpl when the password form has been dismissed. Bug: 963307 Change-Id: I812bed808e35947fe89714d205896a24a2dcf8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688022Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#678257}
-
Hans Wennborg authored
To reduce the risk of forgetting to run one of them. Bug: none Change-Id: I5ecae435571a1cd7e0993f8857ae1041fbb9b309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705200 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#678256}
-
Antonio Gomes authored
This CL moves webmediaplayer_ms.cc|h|unittest as well as its dependency webmediaplayer_ms_compisitor.cc|h to Blink. The header of the former got moved to public/web/modules/mediastream, while the rest now reside in renderer/modules/mediastream. This CL wraps phase 4.4 on the design doc [1]. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/ Given the non-trivial size of this particular CL, a set of TODOs were left (properly flagged in the code), so one can follow up: - There is one instance of base::BindOnce that still needs to be replaced by WTF::Bind. - There is a use of std::map that needs to be replaced by WTF::HashMap. BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I36b0347dde02c368925a2a7355acc9a94aebe0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698170 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#678255}
-
Greg Thompson authored
BUG=984926 TBR=wangxianzhu@chromium.org Change-Id: I11edca703d8581bca0cfc9f7ffba6430aedbf2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706508Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ea3dddf1d088..134aeeec27e1 git log ea3dddf1d088..134aeeec27e1 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 oprypin@webrtc.org Allow using base jni targets on Linux 2019-07-17 jonasolsson@webrtc.org Reland "Remove the injectable bitrate allocation strategy API." Created with: gclient setdep -r src/third_party/webrtc@134aeeec27e1 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id4a0cd4d5f1065e745942fabc9a59ae185e7e3fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706388Reviewed-by:
-
Gustavo Avena authored
Introduce KidsChromeManagementClient's interface, implementation and factory class. Since KidsChromeManagementClient is derived from KeyedService, its lifetime will be associated with the user's `Profile`. Detailed information about KidsChromeManagementClient and its rollout plan can be found on the issue's bug. Bug: 978130 Change-Id: I2e61f4f17c4f7f0dada853f84a9c6df9cb2fecd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675250 Commit-Queue: Gustavo Avena <gustavoavena@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678252}
-
François Beaufort authored
Following https://dawn-review.googlesource.com/c/dawn/+/8863, we can now use the new constant DAWN_WHOLE_SIZE to indicate that the whole size of the buffer should be used in a buffer binding. Bug: 877147 Change-Id: I617792a23cbdc03a2912a7231bf7d2cfea756eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705789Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#678251}
-
Alex Chau authored
- Follow-up on https://crrev.com/c/1702313 - Even if FCM should not be invoked, we should still update device info in preference in case device capabilities has changed (e.g. feature flag enabled) Bug: 984002 Change-Id: I80923c5a681686838d994b1d0ae8e7ecc64e366f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705898Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#678250}
-
Nazerke authored
ios/chrome/app/. Bug: 973040. Change-Id: I80189b5c0e844aa9559713163666794412f69a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706510Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9197a8fa. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" 1e9c7b68 "[Client hints] Enable ACHL persistence in content shell, refactor tests" ee7626e7 "Fixing tranferFromimageBitmap-toBlob-offscreen.html to not be flaky" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I9e11db3a07a7d27b00edc3d41ca0c472ea3781db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706213Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678248}
-
Jan Wilken Dörrie authored
This change modifies PasswordManagerDriver to return GetLastCommittedURL by const-ref instead of by value. Bug: 916165 Change-Id: I796b7dc7a11947a72f00a2d4251f91aa82161de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702379Reviewed-by:
-
Lutz Justen authored
BUG=None TEST=Tested manually that notifications pop up reauth dialog Change-Id: I64e88864f9e028adf91eb3012fca0b7864816480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706429Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#678246}
-
Vasilii Sukhanov authored
- Editable combobox is a combobox group. Inside there is a text field and a button. Windows correctly allows to focus only the textfield and it's properly announced as a combobox. Mac is tricky. User selects a group of controls and then can step into. Inside both the text field and the button are accessible and announced properly. - The dropdown isn't shown by default on focus anymore. This is not how a standard OS combobox works. Also it confused the screen reader on Win as the menu was immediately announced skipping the actual combobox. - The dropdown can be opened with Arrow Up/Down. Bug: 972069 Change-Id: I1089f335ccf0870699946f87617fd4533577b149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683265 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/763b77946e17..64f2cec30c96 git log 763b77946e17..64f2cec30c96 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 bclayton@google.com Regres: Adjust test transition rules for CI reporting Created with: gclient setdep -r src/third_party/swiftshader@64f2cec30c96 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/137671242 TBR=swiftshader-team+autoroll@google.com Change-Id: I1903436374a17452f30b3e60837b7f2dd94bd3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705598Reviewed-by:
-
Denis Solonkov authored
This CL adds logging to histogram to PlatformSharedMemoryRegion::Create function on Posix, similar to Windows and Mac. Additionally, it adds new CreateError values to reflect posix specific situations. Bug: 881808 Change-Id: I53d7e592111fc24aa88a660c4cf583d1603802c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687407Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Denis Solonkov <solonkovda@google.com> Cr-Commit-Position: refs/heads/master@{#678243}
-
Friedrich Horschig authored
This is a reland of 04d2f0db. Diff to Patchset 1: The change was crashing when tapping a field after it was filled sometimes. The reason was that the second time a field was tapped, there is an (currently invisible and unused) special item like "Clear form". Since there was no label created for this, it ran out of bounds and crashed. This CL now reuses the previous (usually empty) label for these items which prevents the crash. Original change's description: > [MFill Android] Use password in PSL labels > > By adding the password to PSL labels, we make more clear that we fill > not only username but also passwords when tapping a chip. > > Bug: 982784 > Change-Id: Iea3fb6a537a47b16a32ea39c4ca4baa435885191 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695269 > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676491} Bug: 982784 Change-Id: I3504e792bc4051fa7626cac1c9a5adc4ffa77155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703406 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Victor Hugo Vianna Silva authored
Bug: 971666 Change-Id: I3396fc3081c6c0b552f3ee99393ab5f2bb7c546c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706328Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#678241}
-
Anna Malova authored
These prefs are used to configure Kerberos in WebView. Moved methods and classes which are using these prefs into AwBrowserProcess. Moving AwURLRequestContextGetter to AwBrowserProcess is a necessary fix to continue work on multiple profile support. Both SafeBrowsing and ProxyController relies on access to this class via AwBrowserContext::GetDefault method. We create AwURLRequestContextGetter earlier, so SafeBrowsing and ProxyController can use it. Default profile will reuse this object. All other profiles will have their own instance of AwURLRequestContextGetter to prevent using the same cache directory by different profiles. Bug: 963875 Change-Id: I6115a55d3f083603f1dad52913b89b0c4a0429e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695293 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#678240}
-
Joanmarie Diggs authored
The mapping to ATK_ROLE_ENTRY may have been done because ARIA has a textbox role which corresponds to the HTML input element. However, kInlineTextBox is not an input and thus should not be exposed as an entry on the platform. The correct mapping is ATK_ROLE_STATIC. But supporting that change for tests run on Ubuntu Trusty will likely impact a bunch of tests. In addition, we have other incorrect mappings to ATK_ROLE_TEXT which should be updated. Therefore, temporarily assign ATK_ROLE_TEXT to kInlineTextBox because it is far more correct than ATK_ROLE_ENTRY. Next, convert everything else and update the ~170 tests which will be impacted. Bug: 984590 Change-Id: I3c4d8ce50d49467e57446c460c99ab25164f7962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703455Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#678239}
-
Michael Lippautz authored
Bug is fixed with https://crrev.com/c/1705929. This CL just adds more infrastructure to diagnose such issues. Bug: 983923 Change-Id: Ic7c9d0c11ee605c111cac9e894286408735bf394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705790 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Michael Lippautz authored
This is currently required for the metrics to detect stand-alone forced followup GCs triggered by DevTools and benchmarking infrastructure. Bug: 948807 Change-Id: I084e9e59876bf29efdf6db3a7cc8ba6adb4e125e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705917 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1c16455ea1a5..b243a2a4f27b git log 1c16455ea1a5..b243a2a4f27b --date=short --no-merges --format='%ad %ae %s' 2019-07-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src e383c5f55def..74426f7570fd (1 commits) Created with: gclient setdep -r src/third_party/angle@b243a2a4f27b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: chromium:None Change-Id: I4bbdfd821c1d7bd7221df4f637719cf99ac6134c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706211Reviewed-by:
-
